Miscellaneous fixes (0.18) (#24567)

* run recording snapshot ffmpeg off the event loop

The recording snapshot and Frigate+ recording submit endpoints called get_image_from_recording inline, which is a blocking ffmpeg subprocess with no timeout, so every other request stalled until the frame was decoded. Both calls now run in asyncio.to_thread.

* fix camera info dialog overflowing on mobile

* adjust test

Makefile

@@ -1,7 +1,7 @@
 default_target: local
 
 COMMIT_HASH := $(shell git log -1 --pretty=format:"%h"|tail -1)
-VERSION = 0.19.0
+VERSION = 0.18.1
 IMAGE_REPO ?= ghcr.io/blakeblackshear/frigate
 GITHUB_REF_NAME ?= $(shell git rev-parse --abbrev-ref HEAD)
 BOARDS= #Initialized empty

docker/main/rootfs/usr/local/nginx/conf/nginx.conf

@@ -150,7 +150,9 @@ http {
             include auth_request.conf;
             types {
                 video/mp4 mp4;
-                image/jpeg jpg;
+                image/jpeg jpg jpeg;
+                image/png png;
+                image/webp webp;
             }
 
             expires 7d;

docs/data/object_detectors_models.yaml

@@ -894,6 +894,41 @@ deepstack:
             api_url: http://<your_codeproject_ai_server_ip>:<port>/v1/vision/detection
             type: deepstack
             api_timeout: 0.1 # seconds
+xdna2:
+  title: AMD XDNA2
+  models:
+    - key: yolov9
+      label: YOLOv9
+      recommended: true
+      download: |-
+        Prepare the model using the frigate-xdna setup instructions linked above. For local YOLO models, Frigate must have access to the same ONNX file bytes as the sidecar. The example below uses YOLOv9-C at 320x320. Frigate+ models may instead use the same `plus://MODEL_ID` in Frigate and the sidecar.
+      ui: |-
+        Navigate to **Settings > System > Detectors and model** and select **ZMQ IPC** from the detector type dropdown and click **Add**, then set the endpoint to `tcp://xdna:5555`. Then on the same page, in the **Custom Model** tab, configure:
+
+        | Field                                    | Value                                      |
+        | ---------------------------------------- | ------------------------------------------ |
+        | **Custom object detector model path**    | `/config/models/yolov9-c-320.onnx`       |
+        | **Label map for custom object detector** | `/labelmap/coco-80.txt`                   |
+        | **Object detection model input width**   | `320`                                    |
+        | **Object detection model input height**  | `320`                                    |
+        | **Model Input Pixel Color Format**       | `rgb` (Frigate's default value)          |
+        | **Model Input Tensor Shape**             | `nchw`                                   |
+        | **Model Input D Type**                   | `float`                                  |
+        | **Object Detection Model Type**          | `yolo-generic`                           |
+      yaml: |-
+        detectors:
+          xdna:
+            type: zmq
+            endpoint: tcp://xdna:5555
+
+        model:
+          model_type: yolo-generic
+          width: 320
+          height: 320
+          input_tensor: nchw
+          input_dtype: float
+          path: /config/models/yolov9-c-320.onnx
+          labelmap_path: /labelmap/coco-80.txt
 memryx:
   title: MemryX
   models:
@@ -1100,7 +1135,7 @@ synaptics:
     - key: ssd
       label: SSD MobileNet
       recommended: true
-      download: A synap model is provided in the container at `/mobilenet.synap` and is used by this detector type by default. The model comes from the [Synap-release Github](https://github.com/synaptics-astra/synap-release/tree/v1.5.0/models/dolphin/object_detection/coco/model/mobilenet224_full80).
+      download: A synap model is provided in the container at `/synaptics/mobilenet.synap` and is used by this detector type by default. The model comes from the [Synap-release Github](https://github.com/synaptics-astra/synap-release/tree/v1.5.0/models/dolphin/object_detection/coco/model/mobilenet224_full80).
       ui: |-
         Navigate to **Settings > System > Detectors and model** and select **Synaptics** from the detector type dropdown and click **Add**. Then on the same page, in the **Custom Model** tab, configure:
 

docs/docs/configuration/advanced/reference.md

@@ -251,17 +251,11 @@ birdseye:
   # Optional: Encoding quality of the mpeg1 feed (default: shown below)
   # 1 is the highest quality, and 31 is the lowest. Lower quality feeds utilize less CPU resources.
   quality: 8
-  # Optional: Activity types that include cameras in Birdseye (default: shown below)
-  # Multiple activity types can be enabled at the same time.
-  mode:
-    # Optional: All cameras are included always (default: shown below)
-    continuous: False
-    # Optional: Cameras are included if motion was detected in the last 30 seconds (default: shown below)
-    motion: False
-    # Optional: Cameras are included if they have had an active tracked object within the last 30 seconds (default: shown below)
-    objects: True
-    # Optional: Cameras are included while they have a stationary tracked object (default: shown below)
-    stationary_objects: False
+  # Optional: Mode of the view. Available options are: objects, motion, and continuous
+  #   objects - cameras are included if they have had a tracked object within the last 30 seconds
+  #   motion - cameras are included if motion was detected in the last 30 seconds
+  #   continuous - all cameras are included always
+  mode: objects
   # Optional: Threshold for camera activity to stop showing camera (default: shown below)
   inactivity_threshold: 30
   # Optional: Configure the birdseye layout
@@ -292,7 +286,7 @@ ffmpeg:
     # Optional: output args for detect streams (default: shown below)
     detect: -threads 2 -f rawvideo -pix_fmt yuv420p
     # Optional: output args for record streams (default: shown below)
-    record: preset-record-generic
+    record: preset-record-generic-audio-aac
   # Optional: Time in seconds to wait before ffmpeg retries connecting to the camera. (default: shown below)
   # If set too low, frigate will retry a connection to the camera's stream too frequently, using up the limited streams some cameras can allow at once
   # If set too high, then if a ffmpeg crash or camera stream timeout occurs, you could potentially lose up to a maximum of retry_interval second(s) of footage

docs/docs/configuration/birdseye.md

@@ -18,14 +18,13 @@ Each camera tile in Birdseye is composed from the frames of the stream assigned
 
 ## Birdseye Behavior
 
-### Birdseye Activity Types
+### Birdseye Modes
 
-Birdseye offers independent activity types that control when cameras are shown. Multiple activity types can be enabled together.
+Birdseye offers different modes to customize which cameras show under which circumstances.
 
-- **continuous:** The camera is always included
-- **motion:** The camera is included when motion was detected within the last 30 seconds
-- **objects:** The camera is included when an active object was tracked within the last 30 seconds
-- **stationary_objects:** The camera is included while a stationary object is tracked
+- **continuous:** All cameras are always included
+- **motion:** Cameras that have detected motion within the last 30 seconds are included
+- **objects:** Cameras that have tracked an active object within the last 30 seconds are included
 
 ### Custom Birdseye Icon
 
@@ -40,30 +39,27 @@ To include a camera in Birdseye view only for specific circumstances, or exclude
 
 **Global settings:** Navigate to <NavPath path="Settings > System > Birdseye" /> to configure the default Birdseye behavior for all cameras.
 
-**Per-camera overrides:** Navigate to <NavPath path="Settings > Camera configuration > Birdseye" /> to override the activity types or disable Birdseye for a specific camera.
+**Per-camera overrides:** Navigate to <NavPath path="Settings > Camera configuration > Birdseye" /> to override the mode or disable Birdseye for a specific camera.
 
-| Field                  | Description                                                |
-| ---------------------- | ---------------------------------------------------------- |
-| **Enable Birdseye**    | Whether this camera appears in Birdseye view               |
-| **Activity types**     | Conditions that determine when to show the camera          |
+| Field               | Description                                                   |
+| ------------------- | ------------------------------------------------------------- |
+| **Enable Birdseye** | Whether this camera appears in Birdseye view                  |
+| **Tracking mode**   | When to show the camera: `continuous`, `motion`, or `objects` |
 
 </TabItem>
 <TabItem value="yaml">
 
-```yaml {8-11,13-15}
+```yaml {8-10,12-14}
 # Include all cameras by default in Birdseye view
 birdseye:
   enabled: True
-  mode:
-    continuous: True
+  mode: continuous
 
 cameras:
   front:
     # Only include the "front" camera in Birdseye view when objects are detected
     birdseye:
-      mode:
-        continuous: False
-        objects: True
+      mode: objects
   back:
     # Exclude the "back" camera from Birdseye view
     birdseye:

docs/docs/configuration/genai/config.md

@@ -59,13 +59,17 @@ Running Generative AI models on CPU is not recommended, as high inference times
 
 ### Recommended Local Models
 
+#### Vision models
+
 You must use a vision-capable model with Frigate. The following models are recommended for local deployment of the `descriptions` and `chat` roles:
 
-| Model      | Notes                                                                                                                                                                |
-| ---------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `qwen3-vl` | Strong visual and situational understanding, enhanced ability to identify smaller objects and interactions with object.                                              |
-| `qwen3.6`  | Strong situational understanding, but missing DeepStack from qwen3-vl leading to worse performance for identifying objects in people's hand and other small details. |
-| `gemma4`   | Strong situational understanding, sometimes resorts to more vague terms like 'interacts' instead of assigning a specific action.                                     |
+| Model               | Notes                                                                                                                                                                |
+| ------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| `qwen3-vl`          | Strong visual and situational understanding, enhanced ability to identify smaller objects and interactions with object.                                              |
+| `qwen3.6`/`qwen3.8` | Strong situational understanding, but missing DeepStack from qwen3-vl leading to worse performance for identifying objects in people's hand and other small details. |
+| `gemma4`            | Strong situational understanding, sometimes resorts to more vague terms like 'interacts' instead of assigning a specific action.                                     |
+
+#### Embedding models
 
 The `embeddings` role needs a different kind of model. Text queries are matched against the stored image embeddings, so the model must be trained to place images and text into the same vector space. A chat or description model will still return vectors when asked, but those vectors are not trained for retrieval and text searches will return poor matches with no error to indicate why.
 

docs/docs/configuration/hardware_acceleration_video.md

@@ -498,7 +498,7 @@ cameras:
 
 ## Synaptics
 
-Hardware accelerated video de-/encoding is supported on Synpatics SL-series SoC.
+Hardware accelerated video de-/encoding is supported on Synaptics SL-series SoC.
 
 ### Prerequisites
 

docs/docs/configuration/license_plate_recognition.md

@@ -8,7 +8,7 @@ import TabItem from "@theme/TabItem";
 import NavPath from "@site/src/components/NavPath";
 import FaqItem from "@site/src/components/FaqItem";
 
-Frigate can recognize license plates on vehicles and automatically add the detected characters to the `recognized_license_plate` field or a [known](#matching) name as a `sub_label` to tracked objects of type `car` or `motorcycle`. A common use case may be to read the license plates of cars pulling into a driveway or cars passing by on a street.
+Frigate can recognize license plates on vehicles and automatically add the detected characters to the `recognized_license_plate` field or a [known](#matching) name as a `sub_label` to tracked objects of type `car`, `motorcycle`, `bus`, `truck`, `school_bus`, or `garbage_truck`, depending on which of those labels your model detects. A common use case may be to read the license plates of cars pulling into a driveway or cars passing by on a street.
 
 LPR works best when the license plate is clearly visible to the camera. For moving vehicles, Frigate continuously refines the recognition process, keeping the most confident result. When a vehicle becomes stationary, LPR continues to run for a short time after to attempt recognition.
 
@@ -24,7 +24,7 @@ When a plate is recognized, the details are:
 - Viewable in the Details pane in Review/History.
 - Viewable in the Tracked Object Details pane in Explore (sub labels and recognized license plates).
 - Filterable through the More Filters menu in Explore.
-- Published via the `frigate/events` MQTT topic as a `sub_label` ([known](#matching)) or `recognized_license_plate` (unknown) for the `car` or `motorcycle` tracked object.
+- Published via the `frigate/events` MQTT topic as a `sub_label` ([known](#matching)) or `recognized_license_plate` (unknown) for the vehicle tracked object.
 - Published via the `frigate/tracked_object_update` MQTT topic with `name` (if [known](#matching)) and `plate`.
 
 ## Model Requirements
@@ -35,7 +35,7 @@ Users without a model that detects license plates can still run LPR. Frigate use
 
 :::note
 
-In the default mode, Frigate's LPR needs to first detect a `car` or `motorcycle` before it can recognize a license plate. If you're using a dedicated LPR camera and have a zoomed-in view where a `car` or `motorcycle` will not be detected, you can still run LPR, but the configuration parameters will differ from the default mode. See the [Dedicated LPR Cameras](#dedicated-lpr-cameras) section below.
+In the default mode, Frigate's LPR needs to first detect a vehicle before it can recognize a license plate. If you're using a dedicated LPR camera and have a zoomed-in view where a vehicle will not be detected, you can still run LPR, but the configuration parameters will differ from the default mode. See the [Dedicated LPR Cameras](#dedicated-lpr-cameras) section below.
 
 :::
 
@@ -86,7 +86,7 @@ cameras:
 </TabItem>
 </ConfigTabs>
 
-For non-dedicated LPR cameras, ensure that your camera is configured to detect objects of type `car` or `motorcycle`, and that a car or motorcycle is actually being detected by Frigate. Otherwise, LPR will not run.
+For non-dedicated LPR cameras, ensure that your camera is configured to detect vehicle objects, and that a vehicle is actually being detected by Frigate. Otherwise, LPR will not run. The object types that can carry a plate are defined by your model's `attributes_map`, so if your model detects other vehicle labels, you can add them there.
 
 Like the other real-time processors in Frigate, license plate recognition runs on the camera stream defined by the `detect` role in your config. To ensure optimal performance, select a suitable resolution for this stream in your camera's firmware that fits your specific scene and requirements.
 
@@ -158,7 +158,7 @@ lpr:
 
 Navigate to <NavPath path="Settings > Enrichments > License plate recognition" />.
 
-- **Known plates**: Assign custom `sub_label` values to `car` and `motorcycle` objects when a recognized plate matches a known value. These labels appear in the UI, filters, and notifications. Unknown plates are still saved but are added to the `recognized_license_plate` field rather than the `sub_label`.
+- **Known plates**: Assign custom `sub_label` values to vehicle objects when a recognized plate matches a known value. These labels appear in the UI, filters, and notifications. Unknown plates are still saved but are added to the `recognized_license_plate` field rather than the `sub_label`.
 - **Match distance**: Allows for minor variations (missing/incorrect characters) when matching a detected plate to a known plate. For example, setting to `1` allows a plate `ABCDE` to match `ABCBE` or `ABCD`. This parameter will _not_ operate on known plates that are defined as regular expressions.
 
 </TabItem>
@@ -316,7 +316,7 @@ lpr:
 
 :::note
 
-If a camera is configured to detect `car` or `motorcycle` but you don't want Frigate to run LPR for that camera, disable LPR at the camera level:
+If a camera is configured to detect vehicles but you don't want Frigate to run LPR for that camera, disable LPR at the camera level:
 
 <ConfigTabs>
 <TabItem value="ui">
@@ -378,10 +378,10 @@ Navigate to <NavPath path="Settings > Camera configuration > Object detection" /
 
 Navigate to <NavPath path="Settings > Camera configuration > Objects" />.
 
-| Field                                          | Description         |
-| ---------------------------------------------- | ------------------- |
-| **Objects to track**                           | Add `license_plate` |
-| **Object filters > License Plate > Threshold** | Set to `0.7`        |
+| Field                                                     | Description         |
+| --------------------------------------------------------- | ------------------- |
+| **Objects to track**                                      | Add `license_plate` |
+| **Object filters > License Plate > Confidence threshold** | Set to `0.7`        |
 
 Navigate to <NavPath path="Settings > Camera configuration > Motion detection" />.
 
@@ -456,7 +456,7 @@ With this setup:
 - Snapshots will have license plate bounding boxes on them.
 - The `frigate/events` MQTT topic will publish tracked object updates.
 - Debug view will display `license_plate` bounding boxes.
-- If you are using a Frigate+ model and want to submit images from your dedicated LPR camera for model training and fine-tuning, annotate both the `car` / `motorcycle` and the `license_plate` in the snapshots on the Frigate+ website, even if the car is barely visible.
+- If you are using a Frigate+ model and want to submit images from your dedicated LPR camera for model training and fine-tuning, annotate both the vehicle and the `license_plate` in the snapshots on the Frigate+ website, even if the vehicle is barely visible.
 
 ### Using the Secondary LPR Pipeline (Without Frigate+)
 
@@ -611,9 +611,9 @@ If you are still having issues detecting plates, start with a basic configuratio
 
 </FaqItem>
 
-<FaqItem id="can-i-run-lpr-without-detecting-car-or-motorcycle-objects" question={<>Can I run LPR without detecting <code>car</code> or <code>motorcycle</code> objects?</>}>
+<FaqItem id="can-i-run-lpr-without-detecting-car-or-motorcycle-objects" question={<>Can I run LPR without detecting vehicle objects?</>}>
 
-In normal LPR mode, Frigate requires a `car` or `motorcycle` to be detected first before recognizing a license plate. If you have a dedicated LPR camera, you can change the camera `type` to `"lpr"` to use the Dedicated LPR Camera algorithm. This comes with important caveats, though. See the [Dedicated LPR Cameras](#dedicated-lpr-cameras) section above.
+In normal LPR mode, Frigate requires a vehicle to be detected first before recognizing a license plate. If you have a dedicated LPR camera, you can change the camera `type` to `"lpr"` to use the Dedicated LPR Camera algorithm. This comes with important caveats, though. See the [Dedicated LPR Cameras](#dedicated-lpr-cameras) section above.
 
 </FaqItem>
 
@@ -699,7 +699,7 @@ lpr:
 4. Ensure the characters on detected plates are being _recognized_.
    - Check the **Plate recognition** inference time in Enrichment metrics (<NavPath path="System metrics > Enrichments" />). High inference times (> 100ms) could lead to poor recognition results, especially for dedicated LPR cameras where the plate crosses the frame quickly.
    - Enable `debug_save_plates` to save images of detected text on plates to the clips directory (`/media/frigate/clips/lpr`). Ensure these images are readable and the text is clear.
-   - Watch the debug view to see plates recognized in real-time. For non-dedicated LPR cameras, the `car` or `motorcycle` label will change to the recognized plate when LPR is enabled and working.
+   - Watch the debug view to see plates recognized in real-time. For non-dedicated LPR cameras, the vehicle's label will change to the recognized plate when LPR is enabled and working.
    - Adjust `recognition_threshold` settings per the suggestions [above](#advanced-configuration).
 
 </FaqItem>
@@ -714,13 +714,13 @@ LPR's performance impact depends on your hardware. Ensure you have at least 4GB
 
 The YOLOv9 license plate detector model will run (and the metric will appear) if you've enabled LPR but haven't defined `license_plate` as an object to track, either at the global or camera level.
 
-If you are detecting `car` or `motorcycle` on cameras where you don't want to run LPR, make sure you disable LPR it at the camera level. And if you do want to run LPR on those cameras, make sure you define `license_plate` as an object to track.
+If you are detecting vehicles on cameras where you don't want to run LPR, make sure you disable LPR it at the camera level. And if you do want to run LPR on those cameras, make sure you define `license_plate` as an object to track.
 
 </FaqItem>
 
 <FaqItem id="it-looks-like-frigate-picked-up-my-cameras-timestamp-or-overlay-text-as-the-license-plate-how-can-i-prevent-this" question="It looks like Frigate picked up my camera's timestamp or overlay text as the license plate. How can I prevent this?">
 
-This could happen if cars or motorcycles travel close to your camera's timestamp or overlay text. You could either move the text through your camera's firmware, or apply a mask to it in Frigate.
+This could happen if vehicles travel close to your camera's timestamp or overlay text. You could either move the text through your camera's firmware, or apply a mask to it in Frigate.
 
 If you are using a model that natively detects `license_plate`, add an _object mask_ of type `license_plate` and a _motion mask_ over your text.
 

docs/docs/configuration/object_detectors.md

@@ -29,6 +29,7 @@ Frigate supports multiple different detectors that work on different types of ha
 
 - [ROCm](#amdrocm-gpu-detector): ROCm can run on AMD Discrete GPUs to provide efficient object detection.
 - [ONNX](#onnx): ROCm will automatically be detected and used as a detector in the `-rocm` Frigate image when a supported ONNX model is configured.
+- <CommunityBadge /> [XDNA2](#amd-xdna2): AMD Ryzen AI / XDNA2 NPUs can run object detection through the community-maintained `frigate-xdna` ZMQ sidecar.
 
 **Apple Silicon**
 
@@ -508,6 +509,28 @@ To verify that the integration is working correctly, start Frigate and observe t
 
 # Community Supported Detectors
 
+## AMD XDNA2
+
+AMD Ryzen AI / XDNA2 NPUs can be used through the community-maintained
+[frigate-xdna](https://github.com/mitchins/frigate-xdna) detector sidecar.
+The sidecar runs separately from Frigate and connects using Frigate's ZMQ
+detector interface.
+
+Currently qualified on **Ryzen AI Max 300 / Strix Halo**. Other XDNA2 devices
+are not yet qualified; XDNA1 is unsupported.
+
+Follow the frigate-xdna setup instructions to prepare and start the sidecar
+before starting Frigate.
+
+### Configuration {#configuration-xdna2}
+
+Using the detector config below will connect Frigate to the sidecar:
+
+<ModelConfigDropdown detectorTitle="AMD XDNA2" models={objectDetectorsModels.xdna2.models} />
+
+The example assumes Frigate and the sidecar share a Docker network where the
+sidecar is named `xdna`.
+
 ## MemryX MX3
 
 This detector is available for use with the MemryX MX3 accelerator M.2 module. Frigate supports the MX3 on compatible hardware platforms, providing efficient and high-performance object detection.

docs/docs/configuration/object_filters.md

@@ -45,10 +45,10 @@ Any detection below `min_score` will be immediately thrown out and never tracked
 
 Navigate to <NavPath path="Settings > Global configuration > Objects" /> to set score filters globally.
 
-| Field                                   | Description                                                      |
-| --------------------------------------- | ---------------------------------------------------------------- |
-| **Object filters > Person > Min Score** | Minimum score for a single detection to initiate tracking        |
-| **Object filters > Person > Threshold** | Minimum computed (median) score to be considered a true positive |
+| Field                                              | Description                                                      |
+| -------------------------------------------------- | ---------------------------------------------------------------- |
+| **Object filters > Person > Minimum confidence**   | Minimum score for a single detection to initiate tracking        |
+| **Object filters > Person > Confidence threshold** | Minimum computed (median) score to be considered a true positive |
 
 To override score filters for a specific camera, navigate to <NavPath path="Settings > Camera configuration > Objects" /> and select the camera.
 
@@ -103,12 +103,12 @@ Conceptually, a ratio of 1 is a square, 0.5 is a "tall skinny" box, and 2 is a "
 
 Navigate to <NavPath path="Settings > Global configuration > Objects" /> to set shape filters globally.
 
-| Field                                   | Description                                                              |
-| --------------------------------------- | ------------------------------------------------------------------------ |
-| **Object filters > Person > Min Area**  | Minimum bounding box area in pixels (or decimal for percentage of frame) |
-| **Object filters > Person > Max Area**  | Maximum bounding box area in pixels (or decimal for percentage of frame) |
-| **Object filters > Person > Min Ratio** | Minimum width/height ratio of the bounding box                           |
-| **Object filters > Person > Max Ratio** | Maximum width/height ratio of the bounding box                           |
+| Field                                              | Description                                                              |
+| -------------------------------------------------- | ------------------------------------------------------------------------ |
+| **Object filters > Person > Minimum object area**  | Minimum bounding box area in pixels (or decimal for percentage of frame) |
+| **Object filters > Person > Maximum object area**  | Maximum bounding box area in pixels (or decimal for percentage of frame) |
+| **Object filters > Person > Minimum aspect ratio** | Minimum width/height ratio of the bounding box                           |
+| **Object filters > Person > Maximum aspect ratio** | Maximum width/height ratio of the bounding box                           |
 
 To override shape filters for a specific camera, navigate to <NavPath path="Settings > Camera configuration > Objects" /> and select the camera.
 

docs/docs/configuration/objects.md

@@ -70,14 +70,14 @@ Object filters help reduce false positives by constraining the size, shape, and
 
 Navigate to <NavPath path="Settings > Global configuration > Objects" />.
 
-| Field                                   | Description                                                              |
-| --------------------------------------- | ------------------------------------------------------------------------ |
-| **Object filters > Person > Min Area**  | Minimum bounding box area in pixels (or decimal for percentage of frame) |
-| **Object filters > Person > Max Area**  | Maximum bounding box area in pixels (or decimal for percentage of frame) |
-| **Object filters > Person > Min Ratio** | Minimum width/height ratio of the bounding box                           |
-| **Object filters > Person > Max Ratio** | Maximum width/height ratio of the bounding box                           |
-| **Object filters > Person > Min Score** | Minimum score for the object to initiate tracking                        |
-| **Object filters > Person > Threshold** | Minimum computed score to be considered a true positive                  |
+| Field                                              | Description                                                              |
+| -------------------------------------------------- | ------------------------------------------------------------------------ |
+| **Object filters > Person > Minimum object area**  | Minimum bounding box area in pixels (or decimal for percentage of frame) |
+| **Object filters > Person > Maximum object area**  | Maximum bounding box area in pixels (or decimal for percentage of frame) |
+| **Object filters > Person > Minimum aspect ratio** | Minimum width/height ratio of the bounding box                           |
+| **Object filters > Person > Maximum aspect ratio** | Maximum width/height ratio of the bounding box                           |
+| **Object filters > Person > Minimum confidence**   | Minimum score for the object to initiate tracking                        |
+| **Object filters > Person > Confidence threshold** | Minimum computed score to be considered a true positive                  |
 
 To override filters for a specific camera, navigate to <NavPath path="Settings > Camera configuration > Objects" />.
 

docs/docs/configuration/profiles.md

@@ -191,14 +191,12 @@ cameras:
     detect:
       enabled: false
     record:
-      enabled: false
+      enabled: true
     profiles:
       away:
         enabled: true
         detect:
           enabled: true
-        record:
-          enabled: true
       home:
         enabled: false
 ```
@@ -251,6 +249,12 @@ Leaving the `objects` section empty (or omitting `track`) does not clear the lis
 
 Fields that require a Frigate restart to take effect cannot be overridden by profiles, since profiles are applied at runtime without restarting. Those fields are hidden when editing a profile override and can only be changed on the base configuration.
 
+### Why can't a profile enable recording when it's disabled in the base config?
+
+Frigate only sets up a camera's recording stream at startup when recording is enabled in the base config, so enabling it later from a profile has no effect. The same applies to turning recording on from the UI or MQTT.
+
+To keep recording off by default, leave `record.enabled: true` in the base config and create a profile that sets `record.enabled: false`. Activate that profile and it will be restored automatically when Frigate starts.
+
 ### Can I schedule profiles to be enabled or disabled at certain times?
 
 Not within Frigate itself. Frigate is an NVR, not an automation platform, so it intentionally does not include a scheduler for activating profiles. Instead, activate profiles from an automation platform that already handles time- and event-based triggers well, such as [Home Assistant](https://www.home-assistant.io/) or [Node-RED](https://nodered.org/). These integrate with Frigate and give you far more robust and flexible scheduling than a built-in scheduler could.

docs/docs/configuration/record.md

@@ -9,7 +9,7 @@ import NavPath from "@site/src/components/NavPath";
 
 Recordings can be enabled and are stored at `/media/frigate/recordings`. The folder structure for the recordings is `YYYY-MM-DD/HH/<camera_name>/MM.SS.mp4` in **UTC time**. These recordings are written directly from your camera stream without re-encoding. Each camera supports a configurable retention policy. Frigate chooses the largest matching retention value between the recording retention and the tracked object retention when determining if a recording should be removed.
 
-New recording segments are written from the camera stream to cache, they are only moved to disk if they match the setup recording retention policy.
+New recording segments are written from the camera stream to cache, they are only moved to disk if they pass a validation check and match the setup recording retention policy.
 
 :::tip
 
@@ -291,7 +291,7 @@ For advanced use cases, the [custom export HTTP API](../integrations/api/export-
 POST /export/custom/{camera_name}/start/{start_time}/end/{end_time}
 ```
 
-The request body accepts `ffmpeg_input_args` and `ffmpeg_output_args` to control encoding, frame rate, filters, and other FFmpeg options. If neither is provided, Frigate defaults to time-lapse output settings (25x speed, 30 FPS).
+The request body accepts `ffmpeg_input_args` and `ffmpeg_output_args` to control encoding, frame rate, filters, and other FFmpeg options. If neither is provided, Frigate defaults to time-lapse output settings (25x speed, 30 FPS) with audio removed (`-an`). When providing your own `ffmpeg_input_args`, include `-an` if you want audio stripped from the export.
 
 The following example exports a time-lapse at 60x speed with 25 FPS:
 

docs/docs/configuration/restream.md

@@ -197,7 +197,7 @@ For cameras that support two-way talk, go2rtc will automatically establish an au
 To prevent this, you must configure two separate stream instances:
 
 1. One stream instance with `#backchannel=0` for Frigate's viewing, recording, and detection (prevents go2rtc from establishing the blocking backchannel)
-2. A second stream instance without `#backchannel=0` for two-way talk functionality (can be used by Frigate's WebRTC viewer or other applications)
+2. A second stream instance with no `#` parameters at all for two-way talk functionality (can be used by Frigate's WebRTC viewer or other applications)
 
 Configuration example:
 
@@ -215,6 +215,8 @@ In this configuration:
 - `front_door` stream is used by Frigate for viewing, recording, and detection. The `#backchannel=0` parameter prevents go2rtc from establishing the audio output backchannel, so it won't block two-way talk access.
 - `front_door_twoway` stream is used for two-way talk functionality. This stream can be used by Frigate's WebRTC viewer when two-way talk is enabled, or by other applications (like Home Assistant Advanced Camera Card) that need access to the camera's audio output channel.
 
+Any `#` parameter on a bare `rtsp://` source disables the backchannel unless the URL explicitly contains `#backchannel=1`. A two-way talk stream with something like `#video=h264` on it silently loses two-way audio, and Frigate will report that two-way talk is unavailable for that stream.
+
 ## Security: Restricted Stream Sources
 
 For security reasons, the `echo:`, `expr:`, and `exec:` stream sources are disabled by default in go2rtc. These sources allow arbitrary command execution and can pose security risks if misconfigured.

docs/docs/configuration/semantic_search.md

@@ -245,8 +245,8 @@ Triggers are best configured through the Frigate UI.
 1. Navigate to <NavPath path="Settings > Enrichments > Triggers" /> and select a camera from the dropdown menu.
 2. Click **Add Trigger** to create a new trigger or use the pencil icon to edit an existing one.
 3. In the **Create Trigger** wizard:
-   - Enter a **Name** for the trigger (e.g., "Red Car Alert").
-   - Enter a descriptive **Friendly Name** for the trigger (e.g., "Red car on the driveway camera").
+   - Enter a **Name** for the trigger (e.g., "Red Car Alert"). Frigate derives the trigger's
+     internal **ID** from this name, which can be revealed and edited with the show/hide toggle.
    - Select the **Type** (`Thumbnail` or `Description`).
    - For `Thumbnail`, select an image to trigger this action when a similar thumbnail image is detected, based on the threshold.
    - For `Description`, enter text to trigger this action when a similar tracked object description is detected.

docs/docs/configuration/zones.md

@@ -28,7 +28,7 @@ During testing, enable the Zones option for the [Debug view](/usage/live#the-sin
 1. Navigate to <NavPath path="Settings > Camera configuration > Masks / Zones" /> and select the desired camera.
 2. Under the **Zones** section, click the plus icon to add a new zone.
 3. Click on the camera's latest image to create the points for the zone boundary. Click the first point again to close the polygon.
-4. Configure zone options such as **Friendly name**, **Objects**, **Loitering time**, and **Inertia** in the zone editor.
+4. Configure zone options such as **Name**, **Objects**, **Loitering Time**, and **Inertia** in the zone editor.
 5. Press **Save** when finished.
 
 </TabItem>
@@ -200,7 +200,7 @@ When using loitering zones, a review item will behave in the following way:
 
 1. Navigate to <NavPath path="Settings > Camera configuration > Masks / Zones" /> and select the desired camera.
 2. Edit or create the zone (e.g., `sidewalk`).
-   - Set **Loitering time** to the desired number of seconds (e.g., `4`)
+   - Set **Loitering Time** to the desired number of seconds (e.g., `4`)
    - Under **Objects**, add the relevant object types (e.g., `person`)
 
 </TabItem>
@@ -291,7 +291,7 @@ Accurate real-world distance measurements are required to estimate speeds. These
 
 1. Navigate to <NavPath path="Settings > Camera configuration > Masks / Zones" /> and select the desired camera.
 2. Create or edit a zone with exactly 4 points aligned to the ground plane.
-3. In the zone editor, enter the real-world **Distances** between each pair of consecutive points.
+3. In the zone editor, enable **Speed Estimation** and enter the real-world **Line A distance**, **Line B distance**, **Line C distance**, and **Line D distance** between each pair of consecutive points.
    - For example, if the distance between the first and second points is 10 meters, between the second and third is 12 meters, etc.
 4. Distances are measured in meters (metric) or feet (imperial), depending on the **Unit system** setting.
 
@@ -358,7 +358,7 @@ Zones can be configured with a minimum speed requirement, meaning an object must
 
 1. Navigate to <NavPath path="Settings > Camera configuration > Masks / Zones" /> and select the desired camera.
 2. Edit or create the zone with distances configured.
-   - Set **Speed threshold** to the desired minimum speed (e.g., `20`)
+   - Set **Speed Threshold** to the desired minimum speed (e.g., `20`)
    - The unit is kph or mph, depending on the **Unit system** setting
 
 </TabItem>

docs/docs/frigate/glossary.md

@@ -54,7 +54,7 @@ An object filter mask drops any [bounding box](#bounding-box) whose bottom cente
 
 ## Min Score
 
-The lowest score a detected object can have to be kept during tracking. Anything scoring below the minimum is assumed to be a [false positive](#false-positive) and discarded.
+The lowest score a detected object can have to be kept during tracking. Anything scoring below the minimum is assumed to be a [false positive](#false-positive) and discarded. Set with `min_score` in the config, shown as **Minimum confidence** in the settings UI.
 
 ## Model
 
@@ -86,7 +86,7 @@ A more specific identity assigned to a [tracked object](#tracked-object-event-in
 
 ## Threshold
 
-The median score an object must reach to be considered a true positive.
+The median score an object must reach to be considered a true positive. Set with `threshold` in the config, shown as **Confidence threshold** in the settings UI.
 
 ## Top Score
 

docs/docs/frigate/hardware.md

@@ -70,6 +70,9 @@ Frigate supports multiple different detectors that work on different types of ha
 - [ROCm](#rocm---amd-gpu): ROCm can run on AMD Discrete GPUs to provide efficient object detection
   - [Supports limited model architectures](../../configuration/object_detectors#amdrocm-gpu-detector)
   - Runs best on discrete AMD GPUs
+- <CommunityBadge /> [XDNA2 (Ryzen AI)](#amd-xdna2): AMD XDNA2 NPU (sub-watt power AI/ML processor separate to the GPU) inside Strix and other "AI" branded AMD platforms
+  - Has only been tested with YOLOv9, in theory other graphs may be compiled too.
+  - Runs via ZMQ proxy which adds some latency, only recommended for local connection
 
 **Apple Silicon**
 
@@ -296,6 +299,32 @@ The inference time of a rk3588 with all 3 cores enabled is typically 25-30 ms fo
 | ---------------- | ----------------------------------- |
 | yolov9-tiny      | ~ 4 ms                              |
 
+### AMD Ryzen AI / XDNA2
+
+Frigate supports AMD XDNA2 NPUs through the community-maintained
+frigate-xdna ZMQ sidecar. It works with stock Frigate and supports
+Frigate+ models or compatible local YOLO ONNX models. Models are compiled
+once on the target system and cached for subsequent use.
+
+Currently qualified on **Ryzen AI Max 300 / Strix Halo**. Other XDNA2
+devices are not yet qualified; XDNA1 is unsupported.
+
+Measured YOLOv9 detector latency on Strix Halo:
+
+| Model | 320 | 640 |
+| ----- | ---: | ---: |
+| YOLOv9-T | ~7.4 ms | unsupported |
+| YOLOv9-S | ~9.0 ms | ~20.0 ms |
+| YOLOv9-M | ~13.1 ms | ~34.4 ms |
+| YOLOv9-C | ~14.1 ms | ~35.2 ms |
+| YOLOv9-E | ~69.4 ms | ~224.8 ms |
+
+**YOLOv9-C at 320 is the recommended quality/performance balance.**
+C at 640 is also usable where the lower throughput is acceptable.
+
+Setup, model preparation, and compatibility details are available
+[in the frigate-xdna documentation](https://github.com/mitchins/frigate-xdna).
+
 ## What does Frigate use the CPU for and what does it use a detector for? (ELI5 Version)
 
 This is taken from a [user question on reddit](https://www.reddit.com/r/homeassistant/comments/q8mgau/comment/hgqbxh5/?utm_source=share&utm_medium=web2x&context=3). Modified slightly for clarity.

docs/docs/integrations/mqtt.md

@@ -11,6 +11,12 @@ MQTT requires a network connection to your broker. This is typically local, but
 
 :::
 
+:::note
+
+Wherever a topic below includes a camera, mask, or zone name, use its `ID` from the config, not its `friendly_name`. For example, a camera with `friendly_name: "Back Yard"` and ID `back_yard` publishes to `frigate/back_yard/...`, not `frigate/Back Yard/...`.
+
+:::
+
 ## General Frigate Topics
 
 ### `frigate/available`
@@ -555,21 +561,20 @@ Topic with current state of Birdseye for a camera. Published values are `ON` and
 
 ### `frigate/<camera_name>/birdseye_mode/set`
 
-Topic to set the Birdseye activity types for a camera. Send one uppercase activity type or combine multiple types with commas, for example `MOTION,OBJECTS,STATIONARY_OBJECTS`.
+Topic to set Birdseye mode for a camera. Birdseye offers different modes to customize under which circumstances the camera is shown.
 
-_Note: Changing the value from `CONTINUOUS` to non-continuous activity types will take up to 30 seconds for
+_Note: Changing the value from `CONTINUOUS` -> `MOTION | OBJECTS` will take up to 30 seconds for
 the camera to be removed from the view._
 
-| Command              | Description                                                      |
-| -------------------- | ---------------------------------------------------------------- |
-| `CONTINUOUS`         | Always included                                                  |
-| `MOTION`             | Shown if motion was detected within the last 30 seconds          |
-| `OBJECTS`            | Shown if an active object was tracked within the last 30 seconds |
-| `STATIONARY_OBJECTS` | Shown while a stationary object is tracked                       |
+| Command      | Description                                                       |
+| ------------ | ----------------------------------------------------------------- |
+| `CONTINUOUS` | Always included                                                   |
+| `MOTION`     | Show when detected motion within the last 30 seconds are included |
+| `OBJECTS`    | Shown if an active object tracked within the last 30 seconds      |
 
 ### `frigate/<camera_name>/birdseye_mode/state`
 
-Topic with the current Birdseye activity types for a camera. Multiple enabled types are published as a comma-separated value in the order `OBJECTS`, `MOTION`, `STATIONARY_OBJECTS`, `CONTINUOUS`.
+Topic with current state of the Birdseye mode for a camera. Published values are `CONTINUOUS`, `MOTION`, `OBJECTS`.
 
 ### `frigate/<camera_name>/notifications/set`
 

docs/docs/integrations/third_party_extensions.md

@@ -27,6 +27,10 @@ The [Advanced Camera Card](https://card.camera/#/README) is a Home Assistant das
 It supports automatically setting the sub labels in Frigate for person objects that are detected and recognized.
 This is a fork (with fixed errors and new features) of [original Double Take](https://github.com/jakowenko/double-take) project which, unfortunately, isn't being maintained by author.
 
+## [frigate-abr](https://github.com/007hacky007/frigate-abr)
+
+[frigate-abr](https://github.com/007hacky007/frigate-abr) is a drop-in Docker image of Frigate that adds adaptive bitrate (ABR) playback for recordings: a sidecar transcodes footage to lower quality tiers on demand, for reviewing over slow remote connections. Segments are transcoded when played and cached, so no additional stream is recorded. Frigate itself is not modified.
+
 ## [Frigate Notify](https://github.com/0x2142/frigate-notify)
 
 [Frigate Notify](https://github.com/0x2142/frigate-notify) is a simple app designed to send notifications from Frigate to your favorite platforms. Intended to be used with standalone Frigate installations - Home Assistant not required, MQTT is optional but recommended.

docs/docs/plus/faq.md

@@ -21,7 +21,13 @@ Yes. Models and metadata are stored in the `model_cache` directory within the co
 
 ### Can I keep using my Frigate+ models even if I do not renew my subscription?
 
-Yes. Subscriptions to Frigate+ provide access to the infrastructure used to train the models. Models trained with your subscription are yours to keep and use forever. However, do note that the terms and conditions prohibit you from sharing, reselling, or creating derivative products from the models.
+Yes. Subscriptions to Frigate+ provide access to the infrastructure used to train the models. Models you train during an active subscription remain licensed for your continued use even after your subscription ends — models already in your model cache will keep working indefinitely. An active subscription is required to train new models and download new versions.
+
+### Can I use Frigate+ models commercially?
+
+A standard subscription covers use on camera systems you own or operate, including for your business. A shop, restaurant, warehouse, or office running Frigate+ at its own locations (including multiple locations) is exactly the kind of use the subscription is for.
+What the standard subscription does not cover is using Frigate+ models to provide a product or service to others. If you're deploying models at your customers' sites, bundling them with hardware you sell, or running them as part of a hosted or managed service, even if your customers never receive the model files themselves, you'll need a commercial license.
+Note that professional installers are fine under standard subscriptions when each customer holds their own Frigate+ subscription. The commercial license is for cases where your license powers your customers' sites.
 
 ### Why can't I submit images to Frigate+?
 

docs/docs/plus/first_model.md

@@ -64,20 +64,20 @@ Frigate+ models generally have much higher scores than the default model provide
 <ConfigTabs>
 <TabItem value="ui">
 
-Navigate to <NavPath path="Settings > Global configuration > Objects" />. Under **Object filters**, set **Min Score** and **Threshold** for each object type, then click **Save**.
+Navigate to <NavPath path="Settings > Global configuration > Objects" />. Under **Object filters**, set **Minimum confidence** and **Confidence threshold** for each object type, then click **Save**.
 
-| Object            | Min Score | Threshold |
-| ----------------- | --------- | --------- |
-| **dog**           | .7        | .9        |
-| **cat**           | .65       | .8        |
-| **face**          | .7        |           |
-| **package**       | .65       | .9        |
-| **license_plate** | .6        |           |
-| **amazon**        | .75       |           |
-| **ups**           | .75       |           |
-| **fedex**         | .75       |           |
-| **person**        | .65       | .85       |
-| **car**           | .65       | .85       |
+| Object            | Minimum confidence | Confidence threshold |
+| ----------------- | ------------------ | -------------------- |
+| **dog**           | .7                 | .9                   |
+| **cat**           | .65                | .8                   |
+| **face**          | .7                 |                      |
+| **package**       | .65                | .9                   |
+| **license_plate** | .6                 |                      |
+| **amazon**        | .75                |                      |
+| **ups**           | .75                |                      |
+| **fedex**         | .75                |                      |
+| **person**        | .65                | .85                  |
+| **car**           | .65                | .85                  |
 
 </TabItem>
 <TabItem value="yaml">

docs/docs/plus/index.md

@@ -65,11 +65,11 @@ Some users may find that Frigate+ models result in more false positives initiall
 
 Frigate+ models support a more relevant set of objects for security cameras. The labels for annotation in Frigate+ are configurable by editing the camera in the Cameras section of Frigate+. Currently, the following objects are supported:
 
-- **People**: `person`, `face`
-- **Vehicles**: `car`, `motorcycle`, `bicycle`, `boat`, `school_bus`, `license_plate`
+- **People**: `person`, `face`, `baby`
+- **Vehicles**: `car`, `motorcycle`, `bicycle`, `boat`, `school_bus`, `garbage truck`, `license_plate`
 - **Delivery Logos**: `amazon`, `usps`, `ups`, `fedex`, `dhl`, `an_post`, `purolator`, `postnl`, `nzpost`, `postnord`, `gls`, `dpd`, `canada_post`, `royal_mail`
-- **Animals**: `dog`, `cat`, `deer`, `horse`, `bird`, `raccoon`, `fox`, `bear`, `cow`, `squirrel`, `goat`, `rabbit`, `skunk`, `kangaroo`
-- **Other**: `package`, `waste_bin`, `bbq_grill`, `robot_lawnmower`, `umbrella`
+- **Animals**: `dog`, `cat`, `deer`, `horse`, `bird`, `raccoon`, `fox`, `bear`, `cow`, `squirrel`, `goat`, `rabbit`, `skunk`, `kangaroo`, `possum`, `rodent`
+- **Other**: `package`, `waste_bin`, `bbq_grill`, `robot_lawnmower`, `umbrella`, `baby_stroller`
 
 Other object types available in the default Frigate model are not available. Additional object types will be added in future releases.
 
@@ -77,9 +77,12 @@ Other object types available in the default Frigate model are not available. Add
 
 Candidate labels are also available for annotation. These labels don't have enough data to be included in the model yet, but using them will help add support sooner. You can enable these labels by editing the camera settings.
 
-Where possible, these labels are mapped to existing labels during training. For example, any `baby` labels are mapped to `person` until support for new labels is added.
+Where possible, these labels are mapped to existing labels during training. For example, any `duck` labels are mapped to `bird` until support for new labels is added.
 
-The candidate labels are: `baby`, `bpost`, `badger`, `possum`, `rodent`, `chicken`, `groundhog`, `boar`, `hedgehog`, `tractor`, `golf cart`, `garbage truck`, `bus`, `sports ball`, `la_poste`, `lawnmower`, `heron`, `rickshaw`, `wombat`, `auspost`, `aramex`, `bobcat`, `mustelid`, `transoflex`, `airplane`, `drone`, `mountain_lion`, `crocodile`, `turkey`, `baby_stroller`, `monkey`, `coyote`, `porcupine`, `parcelforce`, `sheep`, `snake`, `helicopter`, `lizard`, `duck`, `hermes`, `cargus`, `fan_courier`, `sameday`
+- **Vehicles**: `tractor`, `golf_cart`, `bus`, `airplane`, `helicopter`, `rickshaw`, `scooter`
+- **Delivery Logos**: `bpost`, `auspost`, `aramex`, `transoflex`, `parcelforce`, `hermes`, `cargus`, `fan_courier`, `sameday`, `la_poste`
+- **Animals**: `badger`, `chicken`, `duck`, `turkey`, `groundhog`, `boar`, `hedgehog`, `wombat`, `bobcat`, `mustelid`, `mountain_lion`, `crocodile`, `monkey`, `coyote`, `porcupine`, `sheep`, `snake`, `lizard`, `heron`, `elk`, `moose`, `pig`, `donkey`, `civet`
+- **Other**: `sports_ball`, `drone`, `lawnmower`
 
 Candidate labels are not available for automatic suggestions.
 

docs/docs/troubleshooting/common_errors.md

@@ -66,17 +66,19 @@ An FFmpeg message meaning it probed the stream but never saw enough decodable vi
 
 ## Recording
 
-<FaqItem id="no-new-recording-segments" question="No new recording segments were created for <camera> in the last 120s">
+<FaqItem id="no-new-recording-segments" question="No new recording segments were created (or: No new valid recording segments were created / No valid segments created since last invalid segment) for <camera> in the last 120s">
 
-Frigate's record watchdog is restarting the record FFmpeg process because no valid segment has reached the cache. This means the record stream is not connecting or the segments are being rejected (see the audio-codec entry below).
+Frigate's record watchdog is restarting the record FFmpeg process because the camera stopped producing usable recordings. The wording distinguishes the cases: `No new recording segments` means no new segment file reached the cache, so ffmpeg isn't getting video out of the record stream; the two `valid` variants mean recordings are arriving but keep failing validation. Either way the fault is on the camera or network side, and the restart is Frigate trying to recover.
 
-See [Recordings: the record stream isn't connecting](/troubleshooting/recordings#the-record-stream-isnt-connecting).
+See [Recordings: no new recording segments were created](/troubleshooting/recordings#no-new-recording-segments-were-created).
 
 </FaqItem>
 
-<FaqItem id="invalid-or-missing-video-stream-in-segment" question="Invalid or missing video stream in segment. Discarding.">
+<FaqItem id="invalid-or-missing-video-stream-in-segment" question="Invalid or missing video stream in segment. Discarding. / Discarding a corrupt recording segment / Failed to probe corrupt segment / Invalid recording segment detected">
 
-A cached recording segment failed validation (no readable video stream) and was deleted. The most common cause is a segment that was truncated because the record FFmpeg process was killed mid-write, so this often appears alongside, and as a consequence of, the record-stream restarts above. A segment containing only audio triggers it too.
+A cached recording segment failed validation and was deleted, either because it had no readable video stream or because its length was impossible. This nearly always means the camera stopped sending usable video partway through the segment: a camera that rebooted, dropped the connection, or ran out of simultaneous connections, or an unreliable link such as WiFi or a failing switch port. Broken camera timestamps (a "Smart Codec" / H.264+ mode) cause the corrupt-segment variants. The same stream failure trips the record watchdog, so the restarts above usually appear alongside these messages.
+
+See [Recordings: invalid or missing video stream in segment](/troubleshooting/recordings#invalid-or-missing-video-stream-in-segment).
 
 </FaqItem>
 

docs/docs/troubleshooting/cpu.md

@@ -3,7 +3,31 @@ id: cpu
 title: High CPU Usage
 ---
 
-High CPU usage can impact Frigate's performance and responsiveness. This guide outlines the most effective configuration changes to help reduce CPU consumption and optimize resource usage.
+High CPU usage can impact Frigate's performance and responsiveness. This guide explains how to interpret the CPU values Frigate reports and outlines the most effective configuration changes to help reduce CPU consumption and optimize resource usage.
+
+## Understanding Frigate's Reported CPU Usage
+
+Frigate's CPU percentages often look much higher than what the host reports. Usually both numbers are correct and are simply measured against different denominators, so confirm you actually have a problem before tuning anything.
+
+### Per-process values are relative to a single core
+
+The values Frigate reports for FFmpeg, capture, detect, detector, and other processes follow the same convention as `top`: 100% means one CPU core is fully saturated, not that the whole system is saturated. A multithreaded process such as FFmpeg can legitimately report well over 100%.
+
+Host and hypervisor tools instead report a percentage of the machine's total capacity across all cores. This includes `docker stats`, the `htop` summary, the Proxmox summary graph, the Unraid dashboard, Synology Resource Monitor, and Home Assistant's system monitor sensors. To reconcile the two:
+
+```
+host percentage ≈ (sum of Frigate's process percentages) / (number of cores)
+```
+
+On a 4 core system, an FFmpeg process reporting 100% is consuming one quarter of the machine, so the host will show roughly 25 to 30% once the remaining Frigate processes are included. That same 100% on a 16 core system is about 6%. Frigate's own warning thresholds use the per-core convention as well, so an FFmpeg process is flagged at 20% of a single core, not 20% of the system.
+
+### Instantaneous samples and averages measure different things
+
+Frigate collects stats every 15 seconds, and the `cpu` value covers only the interval since the previous collection. The `cpu_average` value in the stats API and MQTT payload is the average across the entire life of the process, and it is what the high CPU usage warnings are based on. Host dashboards generally plot data averaged over a longer window, so a single Frigate sample can show a peak that a host graph never displays. A process that has just started, such as FFmpeg after a camera reconnect, reports 0 until it has been sampled twice.
+
+### The system-wide value depends on what the container can see
+
+The system CPU value is read from `/proc/stat`. Under Docker that file belongs to the host, so the value covers the entire machine including workloads unrelated to Frigate, and it will not match `docker stats` for the Frigate container. Under an LXC container, lxcfs virtualizes `/proc/stat` and the value reflects only the cores assigned to the container. In a virtual machine, the guest sees only its assigned vCPUs while the hypervisor divides by every physical thread on the node, so guest and host percentages will not agree even when both are accurate.
 
 ## 1. Hardware Acceleration for Video Decoding
 
@@ -72,3 +96,19 @@ The model you use significantly impacts detector performance. Frigate provides d
 - Larger models (640x640): Slower inference, can sometimes have higher accuracy on very large objects that take up a majority of the frame.
 
 For more detail on picking the right size, see [Choosing a model size](../configuration/object_detectors.md#choosing-a-model-size).
+
+## 3. Reducing Detector CPU Usage
+
+**Priority: High**
+
+The **Detector CPU Usage** metric measures the CPU spent converting frames into the tensor format the model expects and post-processing the model's output. It does not include inference, so this value can be high even when you've configured a GPU, NPU, or Coral for object detection.
+
+This metric scales with how many detections per second Frigate runs and how expensive each one is to prepare. Tuning [motion detection](../configuration/motion_detection) is usually the first recommendation to reduce the number of detections. Additionally, you can:
+
+- **Lower `detect -> fps`.** 5 is the recommended value for nearly all cameras. Running at 10 doubles the frames eligible for detection and is one of the largest contributors to this metric.
+- **Use a 320x320 model.** A 640x640 model has 4 times as many pixels to transpose, convert, and copy on every inference.
+- **Prefer a model that takes integer input.** Models configured with `input_dtype: float` require each frame to be converted to float32 and normalized on the CPU first. Models taking `int` input, such as the tflite models used by the Edge TPU, skip that step.
+- **Do not match the detect resolution to the model resolution.** The detect stream should match your camera's aspect ratio, for example `1280x720`, not the model's input size. Frigate crops and scales regions of motion itself, so an oversized detect stream only adds work.
+- **Tune stationary object behavior.** Objects that never settle into a stationary state are re-detected continuously. Raising `detect -> stationary -> interval` reduces how often detection runs on objects that are already parked. See [stationary objects](../configuration/stationary_objects).
+
+Adding [more detector instances](#multiple-detector-instances) spreads this work across more CPU cores, but does not reduce the total CPU used.

docs/docs/troubleshooting/faqs.md

@@ -39,6 +39,20 @@ To do this efficiently the following setup is required:
 
 When this is done correctly, the GPU will do the decoding and scaling which will result in a small increase in CPU usage but with better results.
 
+### How can I rotate my camera's video feed?
+
+Rotation is best done in the camera's firmware settings (usually called rotate, flip, or corridor mode) so the video arrives already rotated and no extra processing is needed. Check there first.
+
+If your camera does not support rotation, go2rtc's ffmpeg module can rotate the stream with the `#rotate` parameter (`90`, `180`, `270`, or `-90`), but this is not recommended: rotation requires transcoding (re-encoding) the video, which significantly increases CPU usage, especially for high resolution streams.
+
+```yaml
+go2rtc:
+  streams:
+    my_camera: "ffmpeg:rtsp://user:password@192.168.1.10:554/stream#video=h264#hardware#rotate=90"
+```
+
+Point the camera's inputs at the restream as described in the [restream docs](/configuration/restream.md), and swap `detect -> width` and `detect -> height` to match the rotated resolution.
+
 ### My mjpeg stream or snapshots look green and crazy
 
 This almost always means that the width/height defined for your camera are not correct. Double check the resolution with VLC or another player. Also make sure you don't have the width and height values backwards.
@@ -133,6 +147,12 @@ cameras:
       height: 720
 ```
 
+### What is the `version` key in my config file?
+
+`version` records the config format that your config was last migrated to. On startup Frigate compares it against the format the running version expects, and if it is older it copies your config to `/config/backup_config.yaml`, rewrites it to the new format, and updates `version` as the final step. A config with no `version` key is assumed to predate 0.14 and is migrated from there.
+
+Frigate manages this key for you, so do not set or edit it. Raising it makes Frigate skip migrations your config still needs, and lowering it re-runs migrations against config that has already been converted. Either can leave you with a config that no longer validates.
+
 ### Why does Frigate keep creating new tracked objects for my parked car?
 
 Stationary tracking is designed to _prevent_ this: a parked car should remain a single tracked object rather than generating new ones. If you're repeatedly getting new tracked objects for the same car, it's likely that Frigate is losing the object and re-detecting it as a new one.

docs/docs/troubleshooting/go2rtc.md

@@ -78,7 +78,9 @@ go2rtc:
 
 :::warning
 
-The `#`-modifiers (`#video=`, `#audio=`, `#hardware`, `#backchannel=0`, …) **only take effect on a source that is prefixed with `ffmpeg:`**. Adding them to a bare `rtsp://…#audio=opus` source does nothing: go2rtc ignores them. Likewise, when a source references another stream by name (e.g. `ffmpeg:back#audio=aac`), the name must match the stream key **exactly** (it is case sensitive), or the transcode is silently never produced. This is the single most common configuration mistake. In the Frigate UI, the **Use compatibility mode (ffmpeg)** toggle adds the `ffmpeg:` prefix for you.
+The transcoding modifiers (`#video=`, `#audio=`, `#hardware`, …) **only take effect on a source that is prefixed with `ffmpeg:`**. Adding them to a bare `rtsp://…#audio=opus` source does nothing: go2rtc ignores them. Likewise, when a source references another stream by name (e.g. `ffmpeg:back#audio=aac`), the name must match the stream key **exactly** (it is case sensitive), or the transcode is silently never produced. This is the single most common configuration mistake. In the Frigate UI, the **Use compatibility mode (ffmpeg)** toggle adds the `ffmpeg:` prefix for you.
+
+A bare `rtsp://` source reads a different set of modifiers: `#backchannel=`, `#media=`, `#timeout=`, and `#transport=`. These do nothing on an `ffmpeg:` source. Adding **any** modifier to a bare `rtsp://` source also disables the camera's backchannel unless the URL explicitly contains `#backchannel=1`, so a stream dedicated to two-way talk should carry no modifiers at all.
 
 :::
 
@@ -153,7 +155,7 @@ WebRTC is only attempted when MSE fails or when using a camera's two-way talk fe
 
 - **Codec mismatch**: WebRTC cannot carry H.265 or AAC. The stream backing the WebRTC view must provide Opus (or PCMA/PCMU) audio and H.264 video. Add an `ffmpeg:back#audio=opus` source as shown above.
 - **Port `8555` not reachable, or no candidates set**: WebRTC needs port `8555` (both TCP and UDP) open and a reachable candidate advertised. On Docker installs running on a custom/overlay network, go2rtc may advertise unreachable container IPs as ICE candidates; setting `webrtc.filters.candidates: []` and supplying only your host's LAN IP resolves this. See [WebRTC extra configuration](/configuration/live#webrtc-extra-configuration).
-- **Two-way talk** additionally requires a secure context (HTTPS or the authenticated port `8971`, because browsers block microphone access on plain HTTP). The camera's RTSP backchannel must also be handled correctly: go2rtc seizes the backchannel by default, which blocks two-way audio for other consumers and can inject static. Disable it on the primary stream with `#backchannel=0` and use a separate dedicated stream for talk, as documented in [preventing go2rtc from blocking two-way audio](/configuration/restream#two-way-talk-restream).
+- **Two-way talk** additionally requires a secure context (HTTPS or the authenticated port `8971`, because browsers block microphone access on plain HTTP). The camera's RTSP backchannel must also be handled correctly: go2rtc seizes the backchannel by default, which blocks two-way audio for other consumers and can inject static. Disable it on the primary stream with `#backchannel=0` and use a separate dedicated stream for talk, carrying no `#` modifiers of any kind, as documented in [preventing go2rtc from blocking two-way audio](/configuration/restream#two-way-talk-restream).
 
 ## High CPU usage
 

docs/docs/troubleshooting/recordings.md

@@ -209,6 +209,50 @@ If the record stream uses a "Smart Codec"/H.264+ mode or changes encoding parame
 
 </FaqItem>
 
+<FaqItem id="invalid-or-missing-video-stream-in-segment" question="I see the message: WARNING : Invalid or missing video stream in segment ... Discarding.">
+
+Every recording segment is validated before it leaves the cache. Frigate probes each finished `.mp4` in `/tmp/cache` and requires a readable video stream and a valid duration before moving to storage. A segment that fails is deleted, so those ~10 seconds of footage are lost. Three messages come from this check:
+
+- `Invalid or missing video stream in segment <path>. Discarding.` The segment holds no video, or could not be read at all.
+- `Failed to probe corrupt segment <path>` followed by `Discarding a corrupt recording segment: <path>`. The segment was read, but its length could not be determined.
+- `Discarding a corrupt recording segment: <path>` on its own. The segment's length is impossible (empty, or longer than ten minutes), which points at broken timestamps coming from the camera.
+
+For each one, the camera watchdog also logs `Invalid recording segment detected for <camera> at <timestamp>`.
+
+:::warning
+
+This is almost always a **camera or network problem**, not a Frigate one. A segment is only complete once ffmpeg has finished writing it, so anything that interrupts the stream partway through leaves behind a file that cannot be saved. Frigate is reporting the interruption, not causing it.
+
+:::
+
+#### Start with the camera and the network
+
+- **The camera dropped the connection.** Cameras reboot, reinitialize their stream when switching to night mode, and cut clients off when they are overloaded or out of simultaneous connections. Count everything pulling from the camera at once: Frigate's detect and record streams, go2rtc, a phone app, and any other NVR each use one. Routing all roles through a single [RTSP restream](/configuration/restream#reduce-connections-to-camera) so the camera only ever sees one connection often resolves this by itself.
+- **The link to the camera is unreliable.** WiFi cameras, powerline adapters, a saturated uplink, a failing switch port, or a marginal cable all produce this pattern, and usually only on one camera at a time. WiFi cameras are [not recommended](https://ipcamtalk.com/threads/multiple-cameras-high-bandwidth.77100/#post-861110).
+- **The camera cannot reliably send what it is being asked for.** A high bitrate 4K stream can be more than the camera's own hardware can encode and push out under load. Lower the bitrate, or record a lower-resolution profile.
+- **The camera is using a "Smart Codec", H.264+, or H.265+ mode.** These change encoding parameters mid-stream and produce the broken timestamps behind the corrupt-segment variant. Turn the mode off and set the camera's keyframe interval equal to its frame rate. See [Segments are only ~1 second long](#segments-are-only-1-second-long).
+
+Read the rest of the Frigate and/or go2rtc log around the **first** occurrence. When the camera or the network is at fault, other messages show up with it, such as `No frames received from <camera> in 20 seconds`, `Non-monotonic DTS`, `RTP: PT=xx: bad cseq`, `error while decoding MB`, or a connection timeout. Each of those is explained in [Common error messages](/troubleshooting/common_errors). To confirm the camera is the source, open its stream in the [go2rtc web interface](/troubleshooting/go2rtc) on port `1984` or play the same URL in VLC, and leave it running long enough for the failures to happen again.
+
+#### If the camera and network check out
+
+- **Audio the recording cannot store.** Some cameras send G.711 audio, which cannot be saved in an MP4 and stops segments from finalizing. See [Incompatible audio codec](#incompatible-audio-codec-recordings-silently-fail-to-save).
+- **Frigate itself was stopped or restarted.** A single warning per camera around a restart is expected and needs no action.
+- **The system ran out of room or memory.** A full `/tmp/cache`, or the host killing Frigate for using too much memory, cuts off the segment being written. Both leave other errors in the log alongside this one. See [No space left on device](#errno-28-no-space-left-on-device).
+
+</FaqItem>
+
+<FaqItem id="no-new-recording-segments-were-created" question="I see the message: ERROR : No new recording segments were created for <camera> in the last 120s. Restarting the ffmpeg record process...">
+
+When a camera stops producing usable recordings for two minutes, Frigate restarts that camera's record process to try to recover. The wording tells you how far the recordings got:
+
+- **`No new recording segments were created`**: no new segment file showed up in the cache at all, so ffmpeg isn't getting video out of the record stream. The camera is unreachable or refusing the connection, the stream URL, path, or credentials are wrong, or the camera accepted the connection and then sent nothing. See [The record stream isn't connecting](#the-record-stream-isnt-connecting).
+- **`No new valid recording segments were created`** and **`No valid segments created since last invalid segment`**: recordings are arriving, but they keep failing validation, so the camera is sending video that cannot be saved. See [Invalid or missing video stream in segment](#invalid-or-missing-video-stream-in-segment) above.
+
+The restart is Frigate recovering from a problem, not causing one. One of these after a camera reboot or a brief network drop is normal. Seeing them repeat every couple of minutes means the camera or the network is still failing, and the restarts can extend the damage, because each one cuts off the segment that was being written. Work from the earliest failure in that camera's log rather than from the restarts.
+
+</FaqItem>
+
 <FaqItem id="i-see-the-message-warning--unable-to-keep-up-with-recording-segments-in-cache-for-camera-keeping-the-5-most-recent-segments-out-of-6-and-discarding-the-rest" question="I see the message: WARNING : Unable to keep up with recording segments in cache for camera. Keeping the 5 most recent segments out of 6 and discarding the rest...">
 
 This warning means the recording maintainer cannot move recording segments from the RAM cache to disk fast enough. When the cache fills up, Frigate discards the oldest segments to avoid running out of memory and crashing, so you lose recorded footage. This is almost always a storage throughput or system resource problem. Work through the steps below to identify which.
@@ -353,19 +397,11 @@ dmesg | grep -i -E "gpu|drm|reset|hang"
 
 Messages like `trying reset from guc_exec_queue_timedout_job` or similar GPU reset/hang messages indicate a driver or hardware issue. Ensure your kernel and GPU drivers (especially Intel) are up to date.
 
-#### Step 6: Verify hardware acceleration configuration
-
-An incorrect `hwaccel_args` preset can cause ffmpeg to fail silently or consume excessive CPU, starving the detector of resources.
-
-- After upgrading Frigate, verify your preset matches your hardware (e.g., `preset-intel-qsv-h264` instead of the deprecated `preset-vaapi`).
-- For h265 cameras, use the corresponding h265 preset (e.g., `preset-intel-qsv-h265`).
-- Note that `hwaccel_args` are only relevant for the detect stream. Frigate does not decode the record stream.
-
-#### Step 7: Verify go2rtc stream configuration
+#### Step 6: Verify go2rtc stream configuration
 
 Ensure that the ffmpeg source names in your go2rtc configuration match the correct camera stream. A misconfigured stream name (e.g., copying a config from one camera to another without updating the stream reference) will cause the wrong stream to be used or the stream to fail entirely.
 
-#### Step 8: Check system resources
+#### Step 7: Check system resources
 
 If none of the above apply, the issue may be a general resource constraint. Monitor the following on your host:
 

docs/docusaurus.config.ts

@@ -3,6 +3,9 @@ import * as path from "node:path";
 import type { Config, PluginConfig } from "@docusaurus/types";
 import type * as OpenApiPlugin from "docusaurus-plugin-openapi-docs";
 
+// Bump when a new stable release ships
+const STABLE_VERSION = "0.18";
+
 const config: Config = {
   title: "Frigate",
   tagline: "NVR With Realtime Object Detection for IP Cameras",
@@ -23,17 +26,17 @@ const config: Config = {
     mermaid: true,
   },
   i18n: {
-    defaultLocale: 'en',
-    locales: ['en'],
+    defaultLocale: "en",
+    locales: ["en"],
     localeConfigs: {
       en: {
-        label: 'English',
-      }
+        label: "English",
+      },
     },
   },
   themeConfig: {
     announcementBar: {
-      id: 'frigate_plus',
+      id: "frigate_plus",
       content: `
         <span style="margin-right: 8px; display: inline-block; animation: pulse 2s infinite;">🚀</span>
         Get more relevant and accurate detections with Frigate+ models.
@@ -45,8 +48,8 @@ const config: Config = {
             50%       { transform: scale(1.1); }
           }
         </style>`,
-      backgroundColor: '#005f73',
-      textColor: '#e0fbfc',
+      backgroundColor: "#005f73",
+      textColor: "#e0fbfc",
       isCloseable: false,
     },
     docs: {
@@ -83,15 +86,15 @@ const config: Config = {
       },
     },
     prism: {
-      magicComments:[
+      magicComments: [
         {
-          className: 'theme-code-block-highlighted-line',
-          line: 'highlight-next-line',
-          block: {start: 'highlight-start', end: 'highlight-end'},
+          className: "theme-code-block-highlighted-line",
+          line: "highlight-next-line",
+          block: { start: "highlight-start", end: "highlight-end" },
         },
         {
-          className: 'code-block-error-line',
-          line: 'highlight-error-line',
+          className: "code-block-error-line",
+          line: "highlight-error-line",
         },
       ],
       additionalLanguages: ["bash", "json"],
@@ -131,6 +134,11 @@ const config: Config = {
         srcDark: "img/branding/logo-dark.svg",
       },
       items: [
+        {
+          href: "https://github.com/blakeblackshear/frigate/releases",
+          label: `${STABLE_VERSION}`,
+          position: "left",
+        },
         {
           to: "/",
           activeBasePath: "docs",
@@ -148,19 +156,19 @@ const config: Config = {
           position: "right",
         },
         {
-          type: 'localeDropdown',
-          position: 'right',
+          type: "localeDropdown",
+          position: "right",
           dropdownItemsAfter: [
             {
-              label: '简体中文（社区翻译）',
-              href: 'https://docs.frigate-cn.video',
-            }
-          ]
+              label: "简体中文（社区翻译）",
+              href: "https://docs.frigate-cn.video",
+            },
+          ],
         },
         {
-          href: 'https://github.com/blakeblackshear/frigate',
-          label: 'GitHub',
-          position: 'right',
+          href: "https://github.com/blakeblackshear/frigate",
+          label: "GitHub",
+          position: "right",
         },
       ],
     },

docs/static/frigate-api.yaml

@@ -1476,7 +1476,7 @@ paths:
         - Classification
       summary: Get custom classification attributes
       description: |-
-        **Access:** Admin role required.
+        **Access:** Authenticated user with access to all cameras.
 
         Returns custom classification attributes for a given object type.
             Only includes models with classification_type set to 'attribute'.
@@ -1510,8 +1510,8 @@ paths:
               schema:
                 $ref: '#/components/schemas/HTTPValidationError'
       security:
-        - frigateAdminAuth: []
-      x-required-role: admin
+        - frigateUserAuth: []
+      x-required-role: all_cameras
   /classification/{name}/train:
     get:
       tags:
@@ -2308,15 +2308,15 @@ paths:
                 $ref: '#/components/schemas/HTTPValidationError'
       security:
         - frigateUserAuth: []
-      x-required-role: any
-      description: '**Access:** Any authenticated user.'
+      x-required-role: camera
+      description: '**Access:** Authenticated user with access to the referenced camera.'
   /review/summarize/start/{start_ts}/end/{end_ts}:
     post:
       tags:
         - Review
       summary: Generate Review Summary
       description: |-
-        **Access:** Admin role required.
+        **Access:** Authenticated user with access to all cameras.
 
         Use GenAI to summarize review items over a period of time.
       operationId: 
@@ -2347,8 +2347,8 @@ paths:
               schema:
                 $ref: '#/components/schemas/HTTPValidationError'
       security:
-        - frigateAdminAuth: []
-      x-required-role: admin
+        - frigateUserAuth: []
+      x-required-role: all_cameras
   /:
     get:
       tags:
@@ -2946,44 +2946,6 @@ paths:
         - frigateUserAuth: []
       x-required-role: any
       description: '**Access:** Any authenticated user.'
-  /categorized_object_names:
-    get:
-      tags:
-        - App
-      summary: Get known object names by object type
-      description: |-
-        **Access:** Any authenticated user.
-
-        Returns the sub labels and attributes this install can attach,
-            grouped by object type. Unlike /sub_labels, which reflects what has already been
-            detected, this reads the config and model files, so it covers recognized face
-            names, named license plates, custom object classification categories, and the
-            detector attributes of tracked objects.
-      operationId: categorized_object_names_categorized_object_names_get
-      parameters:
-        - name: object_type
-          in: query
-          required: false
-          schema:
-            anyOf:
-              - type: string
-              - type: 'null'
-            title: Object Type
-      responses:
-        '200':
-          description: Successful Response
-          content:
-            application/json:
-              schema: {}
-        '422':
-          description: Validation Error
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/HTTPValidationError'
-      security:
-        - frigateUserAuth: []
-      x-required-role: any
   /audio_labels:
     get:
       tags:
@@ -4111,6 +4073,16 @@ paths:
               - type: 'null'
             default: 100
             title: Limit
+        - name: offset
+          in: query
+          required: false
+          schema:
+            anyOf:
+              - type: integer
+                minimum: 0
+              - type: 'null'
+            default: 0
+            title: Offset
         - name: after
           in: query
           required: false
@@ -4416,6 +4388,16 @@ paths:
               - type: 'null'
             default: 50
             title: Limit
+        - name: offset
+          in: query
+          required: false
+          schema:
+            anyOf:
+              - type: integer
+                minimum: 0
+              - type: 'null'
+            default: 0
+            title: Offset
         - name: cameras
           in: query
           required: false
@@ -7147,7 +7129,9 @@ paths:
               schema:
                 $ref: '#/components/schemas/DebugReplayStartResponse'
         '400':
-          description: Invalid camera, time range, or no recordings
+          description: Invalid camera or time range
+        '404':
+          description: No recordings in the requested time range
         '409':
           description: A replay session is already active
         '422':

frigate/api/app.py

@@ -71,7 +71,6 @@ from frigate.util.config import (
     find_config_file,
     redact_credential,
 )
-from frigate.util.object_names import get_categorized_object_names
 from frigate.util.schema import get_config_schema
 from frigate.util.services import (
     get_nvidia_driver_info,
@@ -1314,28 +1313,6 @@ def get_sub_labels(
     return JSONResponse(content=sub_labels)
 
 
-@router.get(
-    "/categorized_object_names",
-    dependencies=[Depends(allow_any_authenticated())],
-    summary="Get known object names by object type",
-    description="""Returns the sub labels and attributes this install can attach,
-    grouped by object type. Unlike /sub_labels, which reflects what has already been
-    detected, this reads the config and model files, so it covers recognized face
-    names, named license plates, custom object classification categories, and the
-    detector attributes of tracked objects.""",
-)
-def categorized_object_names(
-    request: Request,
-    object_type: str | None = None,
-    allowed_cameras: list[str] = Depends(get_allowed_cameras_for_filter),
-):
-    return JSONResponse(
-        content=get_categorized_object_names(
-            request.app.frigate_config, allowed_cameras, object_type
-        )
-    )
-
-
 @router.get("/audio_labels", dependencies=[Depends(allow_any_authenticated())])
 def get_audio_labels():
     labels = load_labels("/audio-labelmap.txt", prefill=521)

frigate/api/auth.py

@@ -83,9 +83,9 @@ def require_admin_by_default():
         "/nvinfo",
         "/labels",
         "/sub_labels",
-        "/categorized_object_names",
         "/plus/models",
         "/recognized_license_plates",
+        "/classification/attributes",
         "/timeline",
         "/timeline/hourly",
         "/recordings/storage",
@@ -127,23 +127,18 @@ def require_admin_by_default():
         if path.startswith(EXEMPT_PREFIXES):
             return
 
-        # Dynamic camera path exemption:
-        # Any path whose first segment matches a configured camera name should
-        # bypass the global admin requirement. These endpoints enforce access
-        # via route-level dependencies (e.g. require_camera_access) to ensure
-        # per-camera authorization. This allows non-admin authenticated users
-        # (e.g. viewer role) to access camera-specific resources without
-        # needing admin privileges.
-        try:
-            if path.startswith("/"):
-                first_segment = path.split("/", 2)[1]
-                if (
-                    first_segment
-                    and first_segment in request.app.frigate_config.cameras
-                ):
-                    return
-        except Exception:
-            pass
+        # Camera routes enforce per-camera access via route-level dependencies
+        # (e.g. require_camera_access). Match on the route template, not the raw
+        # path, so a camera named like another namespace (e.g. "faces") can't
+        # waive the admin check for that namespace's routes.
+        route = request.scope.get("route")
+        if (
+            route is not None
+            and route.path.startswith("/{camera_name}")
+            and request.path_params.get("camera_name")
+            in request.app.frigate_config.cameras
+        ):
+            return
 
         # For all other paths, require admin role
         # Internal port requests have admin role set automatically
@@ -972,6 +967,7 @@ def delete_user(request: Request, username: str):
     summary="Update user password",
     description="Updates a user's password. Users can only change their own password unless they have admin role. Requires the current password to verify identity for non-admin users. Password must be at least 12 characters long. If user changes their own password, a new JWT cookie is automatically issued.",
 )
+@limiter.limit(limit_value=rateLimiter.get_limit)
 async def update_password(
     request: Request,
     username: str,
@@ -985,10 +981,11 @@ async def update_password(
     current_username = current_user.get("username")
     current_role = current_user.get("role")
 
-    # viewers can only change their own password
-    if current_role == "viewer" and current_username != username:
+    # Only admins may target another account. This has to cover every non-admin
+    # role rather than just viewer, since custom roles are arbitrary names
+    if current_role != "admin" and current_username != username:
         raise HTTPException(
-            status_code=403, detail="Viewers can only update their own password"
+            status_code=403, detail="Users can only update their own password"
         )
 
     HASH_ITERATIONS = request.app.frigate_config.auth.hash_iterations
@@ -1252,3 +1249,23 @@ async def get_allowed_cameras_for_filter(request: Request):
     all_camera_names = set(request.app.frigate_config.cameras.keys())
     roles_dict = request.app.frigate_config.auth.roles
     return User.get_allowed_cameras(role, roles_dict, all_camera_names)
+
+
+async def require_full_camera_access(
+    request: Request,
+    allowed_cameras: list[str] = Depends(get_allowed_cameras_for_filter),
+):
+    """Dependency for endpoints returning data that spans every camera.
+
+    Some responses cannot be meaningfully scoped to a subset of cameras, so
+    rather than filter them the endpoint is limited to callers who can already
+    see every camera. Admin and viewer always qualify; a custom role qualifies
+    only when its camera list covers all configured cameras.
+    """
+    all_camera_names = set(request.app.frigate_config.cameras.keys())
+
+    if not all_camera_names.issubset(allowed_cameras):
+        raise HTTPException(
+            status_code=403,
+            detail="Access to all cameras is required for this endpoint",
+        )

frigate/api/camera.py

@@ -35,7 +35,11 @@ from frigate.config.camera.updater import (
 )
 from frigate.config.env import substitute_frigate_vars
 from frigate.models import User
-from frigate.util.builtin import clean_camera_user_pass, get_record_segment_time
+from frigate.util.builtin import (
+    clean_camera_user_pass,
+    clear_orphaned_comments,
+    get_record_segment_time,
+)
 from frigate.util.camera_cleanup import cleanup_camera_db, cleanup_camera_files
 from frigate.util.config import find_config_file
 from frigate.util.image import run_ffmpeg_snapshot
@@ -1201,6 +1205,7 @@ async def delete_camera(
                 # Remove camera from config
                 if "cameras" in data and camera_name in data["cameras"]:
                     del data["cameras"][camera_name]
+                    clear_orphaned_comments(data["cameras"], data, "cameras")
 
                 # Remove camera from auth roles
                 auth = data.get("auth", {})

frigate/api/chat.py

@@ -50,7 +50,6 @@ from frigate.jobs.vlm_watch import (
     stop_vlm_watch_job,
 )
 from frigate.models import Event
-from frigate.util.object_names import get_categorized_object_names
 
 logger = logging.getLogger(__name__)
 
@@ -540,11 +539,6 @@ async def execute_tool(
     if tool_name == "search_objects":
         return await _execute_search_objects(request, arguments, allowed_cameras)
 
-    if tool_name == "get_categorized_object_names":
-        return JSONResponse(
-            content=_execute_get_categorized_object_names(request, allowed_cameras)
-        )
-
     if tool_name == "find_similar_objects":
         result = await _execute_find_similar_objects(
             request, arguments, allowed_cameras
@@ -597,7 +591,7 @@ async def _execute_get_live_context(
 
     try:
         frame_processor = request.app.detected_frames_processor
-        camera_state = frame_processor.get_camera_state(camera)
+        camera_state = frame_processor.camera_states.get(camera)
 
         if camera_state is None:
             return {
@@ -661,7 +655,7 @@ async def _get_live_frame_image_url(
         return None
     try:
         frame_processor = request.app.detected_frames_processor
-        if frame_processor.get_camera_state(camera) is None:
+        if camera not in frame_processor.camera_states:
             return None
         frame = frame_processor.get_current_frame(camera, {})
         if frame is None:
@@ -723,21 +717,6 @@ async def _execute_set_camera_state(
     return {"success": True, "camera": camera, "feature": feature, "value": value}
 
 
-def _execute_get_categorized_object_names(
-    request: Request,
-    allowed_cameras: list[str],
-) -> dict[str, Any]:
-    names = get_categorized_object_names(request.app.frigate_config, allowed_cameras)
-
-    if not names:
-        return {
-            "names": {},
-            "message": "No names configured; search by label or semantic_query.",
-        }
-
-    return {"names": names}
-
-
 async def _execute_tool_internal(
     tool_name: str,
     arguments: dict[str, Any],
@@ -762,8 +741,6 @@ async def _execute_tool_internal(
         except (json.JSONDecodeError, AttributeError) as e:
             logger.warning(f"Failed to extract tool result: {e}")
             return {"error": "Failed to parse tool result"}
-    elif tool_name == "get_categorized_object_names":
-        return _execute_get_categorized_object_names(request, allowed_cameras)
     elif tool_name == "find_similar_objects":
         return await _execute_find_similar_objects(request, arguments, allowed_cameras)
     elif tool_name == "set_camera_state":
@@ -796,8 +773,8 @@ async def _execute_tool_internal(
     else:
         logger.error(
             "Tool call failed: unknown tool %r. Expected one of: search_objects, find_similar_objects, "
-            "get_categorized_object_names, get_live_context, start_camera_watch, stop_camera_watch, "
-            "get_profile_status, get_recap. Arguments received: %s",
+            "get_live_context, start_camera_watch, stop_camera_watch, get_profile_status, get_recap. "
+            "Arguments received: %s",
             tool_name,
             json.dumps(arguments),
         )

frigate/api/classification.py

@@ -14,7 +14,7 @@ from fastapi.responses import JSONResponse
 from peewee import DoesNotExist
 from playhouse.shortcuts import model_to_dict
 
-from frigate.api.auth import require_role
+from frigate.api.auth import require_full_camera_access, require_role
 from frigate.api.defs.request.classification_body import (
     AudioTranscriptionBody,
     DeleteFaceImagesBody,
@@ -741,6 +741,7 @@ def get_classification_dataset(name: str):
 
 @router.get(
     "/classification/attributes",
+    dependencies=[Depends(require_full_camera_access)],
     summary="Get custom classification attributes",
     description="""Returns custom classification attributes for a given object type.
     Only includes models with classification_type set to 'attribute'.

frigate/api/debug_replay.py

@@ -13,6 +13,7 @@ from frigate.api.auth import require_role
 from frigate.api.defs.tags import Tags
 from frigate.jobs.debug_replay import (
     ExportDebugReplaySource,
+    NoRecordingsError,
     RecordingDebugReplaySource,
     start_debug_replay_job,
 )
@@ -74,7 +75,8 @@ class DebugReplayStopResponse(BaseModel):
     response_model=DebugReplayStartResponse,
     status_code=202,
     responses={
-        400: {"description": "Invalid camera, time range, or no recordings"},
+        400: {"description": "Invalid camera or time range"},
+        404: {"description": "No recordings in the requested time range"},
         409: {"description": "A replay session is already active"},
     },
     dependencies=[Depends(require_role(["admin"]))],
@@ -113,6 +115,14 @@ async def start_debug_replay(request: Request, body: DebugReplayStartBody):
             },
             status_code=409,
         )
+    except NoRecordingsError:
+        return JSONResponse(
+            content={
+                "success": False,
+                "message": "No recordings found in the selected time range",
+            },
+            status_code=404,
+        )
     except ValueError:
         logger.exception("Rejected debug replay start request")
         return JSONResponse(

frigate/api/defs/query/events_query_parameters.py

@@ -14,6 +14,7 @@ class EventsQueryParams(BaseModel):
     zone: str | None = "all"
     zones: str | None = "all"
     limit: int | None = 100
+    offset: int | None = Field(0, ge=0)
     after: float | None = None
     before: float | None = None
     time_range: str | None = DEFAULT_TIME_RANGE
@@ -55,6 +56,7 @@ class EventsSearchQueryParams(BaseModel):
         deprecated=True,
     )
     limit: int | None = 50
+    offset: int | None = Field(0, ge=0)
     cameras: str | None = "all"
     labels: str | None = "all"
     sub_labels: str | None = "all"

frigate/api/event.py

@@ -129,6 +129,7 @@ def events(
         zones = zone
 
     limit = params.limit
+    offset = params.offset
     after = params.after
     before = params.before
     time_range = params.time_range
@@ -361,11 +362,15 @@ def events(
     else:
         order_by = Event.start_time.desc()
 
+    # offset paging needs a stable order when scores or speeds tie
+    tiebreaker = [Event.id] if sort and sort.startswith(("score", "speed")) else []
+
     events = (
         Event.select(*selected_columns)
         .where(reduce(operator.and_, clauses))
-        .order_by(order_by)
+        .order_by(order_by, *tiebreaker)
         .limit(limit)
+        .offset(offset)
         .dicts()
         .iterator()
     )
@@ -518,6 +523,7 @@ def events_search(
     search_type = params.search_type
     include_thumbnails = params.include_thumbnails
     limit = params.limit
+    offset = params.offset
     sort = params.sort
 
     # Filters
@@ -824,6 +830,9 @@ def events_search(
     if search_results:
         events_query = events_query.where(Event.id << list(search_results.keys()))
 
+    # sorts below are stable, so this orders ties for offset paging
+    events_query = events_query.order_by(Event.id)
+
     # Fetch events and process them in a single pass
     processed_events = []
     for event in events_query.dicts():
@@ -881,7 +890,7 @@ def events_search(
         processed_events.sort(key=lambda x: x["start_time"], reverse=True)
 
     # Limit the number of events returned
-    processed_events = processed_events[:limit]
+    processed_events = processed_events[offset:][:limit]
 
     return JSONResponse(content=processed_events)
 
@@ -1313,7 +1322,7 @@ async def set_sub_label(
     if request.app.detected_frames_processor:
         tracked_obj: TrackedObject = None
 
-        for state in request.app.detected_frames_processor.get_camera_states():
+        for state in request.app.detected_frames_processor.camera_states.values():
             tracked_obj = state.tracked_objects.get(event_id)
 
             if tracked_obj is not None:
@@ -1372,7 +1381,7 @@ async def set_plate(
     if request.app.detected_frames_processor:
         tracked_obj: TrackedObject = None
 
-        for state in request.app.detected_frames_processor.get_camera_states():
+        for state in request.app.detected_frames_processor.camera_states.values():
             tracked_obj = state.tracked_objects.get(event_id)
 
             if tracked_obj is not None:

frigate/api/export.py

@@ -9,6 +9,7 @@ import zipfile
 from collections import deque
 from collections.abc import Iterator
 from pathlib import Path
+from urllib.parse import quote
 
 import psutil
 from fastapi import APIRouter, Depends, Query, Request
@@ -68,6 +69,7 @@ from frigate.jobs.export import (
 from frigate.models import Export, ExportCase, Previews, Recordings
 from frigate.record.export import (
     DEFAULT_TIME_LAPSE_FFMPEG_ARGS,
+    DEFAULT_TIME_LAPSE_FFMPEG_INPUT_ARGS,
     ChaptersEnum,
     PlaybackSourceEnum,
     validate_ffmpeg_args,
@@ -453,6 +455,22 @@ def _stream_case_archive(exports: list[Export]) -> Iterator[bytes]:
     yield from buffer.drain()
 
 
+def _content_disposition(filename: str, ascii_fallback: str) -> str:
+    """Build an attachment Content-Disposition that survives non-ASCII names.
+
+    Header values are encoded as latin-1, so a name outside that range cannot
+    go in filename at all. RFC 6266 handles this with a pair: a plain ASCII
+    filename for old clients, plus a percent-encoded UTF-8 filename* that
+    every current browser prefers.
+    """
+    ascii_name = filename if filename.isascii() else ascii_fallback
+
+    return (
+        f'attachment; filename="{ascii_name}"; '
+        f"filename*=UTF-8''{quote(filename, safe='')}"
+    )
+
+
 @router.get(
     "/cases/{case_id}/download",
     dependencies=[Depends(allow_any_authenticated())],
@@ -495,7 +513,9 @@ def download_export_case(
         _stream_case_archive(exports),
         media_type="application/zip",
         headers={
-            "Content-Disposition": f'attachment; filename="{archive_base}.zip"',
+            "Content-Disposition": _content_disposition(
+                f"{archive_base}.zip", f"{case_id}.zip"
+            ),
         },
     )
 
@@ -993,7 +1013,7 @@ def export_recording_custom(
 
     # Set default values if not provided (timelapse defaults)
     if ffmpeg_input_args is None:
-        ffmpeg_input_args = ""
+        ffmpeg_input_args = DEFAULT_TIME_LAPSE_FFMPEG_INPUT_ARGS
 
     if ffmpeg_output_args is None:
         ffmpeg_output_args = DEFAULT_TIME_LAPSE_FFMPEG_ARGS

frigate/api/media.py

@@ -351,8 +351,13 @@ async def get_snapshot_from_recording(
         mime_type = "png" if format == "png" else "jpeg"
         config: FrigateConfig = request.app.frigate_config
 
-        image_data = get_image_from_recording(
-            config.ffmpeg, recording.path, time_in_segment, codec, height
+        image_data = await asyncio.to_thread(
+            get_image_from_recording,
+            config.ffmpeg,
+            recording.path,
+            time_in_segment,
+            codec,
+            height,
         )
 
         if not image_data:
@@ -406,8 +411,12 @@ async def submit_recording_snapshot_to_plus(
         config: FrigateConfig = request.app.frigate_config
         recording: Recordings = recording_query.get()
         time_in_segment = frame_time - recording.start_time
-        image_data = get_image_from_recording(
-            config.ffmpeg, recording.path, time_in_segment, "png"
+        image_data = await asyncio.to_thread(
+            get_image_from_recording,
+            config.ffmpeg,
+            recording.path,
+            time_in_segment,
+            "png",
         )
 
         if not image_data:
@@ -575,11 +584,11 @@ async def vod_ts(
             Recordings.start_time,
         )
         .where(
-            Recordings.camera == camera_name,
-            Recordings.start_time >= start_ts - MAX_SEGMENT_DURATION,
-            Recordings.start_time <= end_ts,
-            Recordings.end_time >= start_ts,
+            Recordings.start_time.between(start_ts, end_ts)
+            | Recordings.end_time.between(start_ts, end_ts)
+            | ((start_ts > Recordings.start_time) & (end_ts < Recordings.end_time))
         )
+        .where(Recordings.camera == camera_name)
         .order_by(Recordings.start_time.asc())
         .iterator()
     )
@@ -820,7 +829,7 @@ async def event_snapshot(
         # see if the object is currently being tracked
         try:
             camera_states: list[CameraState] = (
-                request.app.detected_frames_processor.get_camera_states()
+                request.app.detected_frames_processor.camera_states.values()
             )
             for camera_state in camera_states:
                 if event_id in camera_state.tracked_objects:
@@ -898,7 +907,7 @@ async def event_thumbnail(
     if thumbnail_bytes is None:
         # see if the object is currently being tracked
         try:
-            camera_states = request.app.detected_frames_processor.get_camera_states()
+            camera_states = request.app.detected_frames_processor.camera_states.values()
             for camera_state in camera_states:
                 if event_id in camera_state.tracked_objects:
                     tracked_obj = camera_state.tracked_objects.get(event_id)
@@ -1127,7 +1136,7 @@ async def event_snapshot_clean(request: Request, event_id: str, download: bool =
             # see if the object is currently being tracked
             try:
                 camera_states = (
-                    request.app.detected_frames_processor.get_camera_states()
+                    request.app.detected_frames_processor.camera_states.values()
                 )
                 for camera_state in camera_states:
                     if event_id in camera_state.tracked_objects:

frigate/api/notification.py

@@ -1,8 +1,10 @@
 """Notification apis."""
 
+import ipaddress
 import logging
 import os
 from typing import Any
+from urllib.parse import urlparse
 
 from cryptography.hazmat.primitives import serialization
 from fastapi import APIRouter, Depends, Request
@@ -19,6 +21,95 @@ logger = logging.getLogger(__name__)
 
 router = APIRouter(tags=[Tags.notifications])
 
+# Push endpoints are opaque URLs but stay well under this in practice
+MAX_ENDPOINT_LENGTH = 2048
+
+# Suffixes that only ever resolve on the local network
+INTERNAL_HOST_SUFFIXES = (".local", ".localdomain", ".internal", ".home.arpa")
+
+
+def _validate_push_endpoint(endpoint: Any) -> str | None:
+    """Return a reason the endpoint is unusable, or None when it is valid.
+
+    Subscriptions are issued by the browser vendor's push service, so a valid
+    endpoint is always a public https URL. Anything else is either a broken
+    registration or an attempt to aim the notification sender somewhere it
+    should not reach.
+    """
+    if not isinstance(endpoint, str) or not endpoint:
+        return "endpoint must be a url"
+
+    if len(endpoint) > MAX_ENDPOINT_LENGTH:
+        return "endpoint is too long"
+
+    try:
+        parsed = urlparse(endpoint)
+        port = parsed.port
+    except ValueError:
+        return "endpoint is not a valid url"
+
+    if parsed.scheme != "https":
+        return "endpoint must use https"
+
+    if parsed.username or parsed.password:
+        return "endpoint must not include credentials"
+
+    if port is not None and port != 443:
+        return "endpoint must use the default https port"
+
+    hostname = parsed.hostname
+
+    if not hostname:
+        return "endpoint must include a hostname"
+
+    try:
+        address = ipaddress.ip_address(hostname)
+    except ValueError:
+        address = None
+
+    if address is not None:
+        # A push service is never reachable at an address only this network can
+        # route, so anything non-global is a misconfiguration at best
+        if not address.is_global:
+            return "endpoint must not use a private address"
+    elif hostname == "localhost" or "." not in hostname:
+        return "endpoint must use a fully qualified hostname"
+    elif hostname.endswith(INTERNAL_HOST_SUFFIXES):
+        return "endpoint must not use an internal hostname"
+
+    # The subscription token lives in the path, and webpush.py assumes there is
+    # a separator after the host when it builds the VAPID audience
+    if len(parsed.path) <= 1:
+        return "endpoint must include a subscription path"
+
+    return None
+
+
+def _validate_subscription(sub: Any) -> str | None:
+    """Return a reason the subscription is unusable, or None when it is valid."""
+    if not isinstance(sub, dict):
+        return "subscription must be an object"
+
+    reason = _validate_push_endpoint(sub.get("endpoint"))
+
+    if reason:
+        return reason
+
+    keys = sub.get("keys")
+
+    if not isinstance(keys, dict):
+        return "subscription must include keys"
+
+    # WebPusher raises on a missing key, which would break every send for the
+    # user rather than just this registration
+    for name in ("p256dh", "auth"):
+        value = keys.get(name)
+
+        if not isinstance(value, str) or not value:
+            return f"subscription keys must include {name}"
+
+    return None
+
 
 @router.get(
     "/notifications/pubkey",
@@ -71,6 +162,17 @@ def register_notifications(request: Request, body: dict = None):
             status_code=400,
         )
 
+    reason = _validate_subscription(sub)
+
+    if reason:
+        logger.warning(
+            "Rejected notification registration for %s: %s", username, reason
+        )
+        return JSONResponse(
+            content={"success": False, "message": f"Invalid subscription: {reason}"},
+            status_code=400,
+        )
+
     try:
         User.update(notification_tokens=User.notification_tokens.append(sub)).where(
             User.username == username

frigate/api/record.py

@@ -25,7 +25,7 @@ from frigate.api.defs.query.recordings_query_parameters import (
 )
 from frigate.api.defs.response.generic_response import GenericResponse
 from frigate.api.defs.tags import Tags
-from frigate.const import MAX_SEGMENT_DURATION, RECORD_DIR
+from frigate.const import RECORD_DIR
 from frigate.models import Event, Recordings
 from frigate.util.time import get_dst_transitions
 
@@ -243,7 +243,6 @@ async def recordings(
         )
         .where(
             Recordings.camera == camera_name,
-            Recordings.start_time >= after - MAX_SEGMENT_DURATION,
             Recordings.end_time >= after,
             Recordings.start_time <= before,
         )

frigate/api/review.py

@@ -17,6 +17,7 @@ from frigate.api.auth import (
     get_allowed_cameras_for_filter,
     get_current_user,
     require_camera_access,
+    require_full_camera_access,
     require_role,
 )
 from frigate.api.defs.query.review_query_parameters import (
@@ -42,6 +43,22 @@ logger = logging.getLogger(__name__)
 router = APIRouter(tags=[Tags.review])
 
 
+def get_label_clause(label: str, include_audio: bool = True):
+    """Build a clause matching a label within a review segment's data.
+
+    Verified objects are stored with a `-verified` suffix (eg. `person-verified`)
+    so that variant is matched as well.
+    """
+    clause = (ReviewSegment.data["objects"].cast("text") % f'*"{label}"*') | (
+        ReviewSegment.data["objects"].cast("text") % f'*"{label}-verified"*'
+    )
+
+    if include_audio:
+        clause |= ReviewSegment.data["audio"].cast("text") % f'*"{label}"*'
+
+    return clause
+
+
 @router.get(
     "/review",
     response_model=list[ReviewSegmentResponse],
@@ -91,10 +108,7 @@ async def review(
         filtered_labels = labels.split(",")
 
         for label in filtered_labels:
-            label_clauses.append(
-                (ReviewSegment.data["objects"].cast("text") % f'*"{label}"*')
-                | (ReviewSegment.data["audio"].cast("text") % f'*"{label}"*')
-            )
+            label_clauses.append(get_label_clause(label))
         clauses.append(reduce(operator.or_, label_clauses))
 
     if zones != "all":
@@ -235,10 +249,7 @@ async def review_summary(
         filtered_labels = labels.split(",")
 
         for label in filtered_labels:
-            label_clauses.append(
-                (ReviewSegment.data["objects"].cast("text") % f'*"{label}"*')
-                | (ReviewSegment.data["audio"].cast("text") % f'*"{label}"*')
-            )
+            label_clauses.append(get_label_clause(label))
         clauses.append(reduce(operator.or_, label_clauses))
     if zones != "all":
         # use matching so segments with multiple zones
@@ -336,9 +347,8 @@ async def review_summary(
         filtered_labels = labels.split(",")
 
         for label in filtered_labels:
-            label_clauses.append(
-                ReviewSegment.data["objects"].cast("text") % f'*"{label}"*'
-            )
+            label_clauses.append(get_label_clause(label, include_audio=False))
+
         clauses.append(reduce(operator.or_, label_clauses))
 
     # Find the time range of available data
@@ -709,6 +719,7 @@ async def get_review(request: Request, review_id: str):
     dependencies=[Depends(allow_any_authenticated())],
 )
 async def set_not_reviewed(
+    request: Request,
     review_id: str,
     current_user: dict = Depends(get_current_user),
 ):
@@ -727,6 +738,8 @@ async def set_not_reviewed(
             status_code=404,
         )
 
+    await require_camera_access(review.camera, request=request)
+
     try:
         user_review = UserReviewStatus.get(
             UserReviewStatus.user_id == user_id,
@@ -743,9 +756,12 @@ async def set_not_reviewed(
     )
 
 
+# Intentionally not camera scoped, as the summary correlates each flagged event
+# with overlapping activity on other cameras. Restricted to callers who can
+# already see every camera, so the unscoped query discloses nothing.
 @router.post(
     "/review/summarize/start/{start_ts}/end/{end_ts}",
-    dependencies=[Depends(require_role(["admin"]))],
+    dependencies=[Depends(require_full_camera_access)],
     description="Use GenAI to summarize review items over a period of time.",
 )
 def generate_review_summary(request: Request, start_ts: float, end_ts: float):

frigate/app.py

@@ -335,7 +335,6 @@ class FrigateApp:
             self.ptz_metrics,
             comms,
         )
-        self.dispatcher.start_communicators()
 
     def init_profile_manager(self) -> None:
         self.profile_manager = ProfileManager(

frigate/camera/activity_manager.py

@@ -103,12 +103,13 @@ class CameraActivityManager:
         all_objects: list[dict[str, Any]] = []
 
         for camera in new_activity.keys():
-            if camera not in self.config.cameras:
+            camera_config = self.config.cameras.get(camera)
+            if camera_config is None:
                 continue
 
             # handle cameras that were added dynamically
             if camera not in self.camera_all_object_counts:
-                self.__init_camera(self.config.cameras[camera])
+                self.__init_camera(camera_config)
 
             new_objects = new_activity[camera].get("objects", [])
             all_objects.extend(new_objects)
@@ -233,12 +234,13 @@ class AudioActivityManager:
         now = datetime.datetime.now().timestamp()
 
         for camera in new_activity.keys():
-            if camera not in self.config.cameras:
+            camera_config = self.config.cameras.get(camera)
+            if camera_config is None:
                 continue
 
             # handle cameras that were added dynamically
             if camera not in self.current_audio_detections:
-                self.__init_camera(self.config.cameras[camera])
+                self.__init_camera(camera_config)
 
             new_detections = new_activity[camera].get("detections", [])
             if self.compare_audio_activity(camera, new_detections, now):

frigate/camera/state.py

@@ -60,6 +60,11 @@ class CameraState:
         # face/LPR pipelines when using a model without built-in detection.
         self.face_recognition_min_obj_area: int = 0
         self.lpr_min_obj_area: int = 0
+        self.lp_objects = {
+            label
+            for label, attributes in config.model.attributes_map.items()
+            if "license_plate" in attributes
+        }
 
         if (
             self.camera_config.face_recognition.enabled
@@ -452,7 +457,7 @@ class CameraState:
                 and obj_area >= self.face_recognition_min_obj_area
                 and updated_obj.obj_data.get("sub_label") is None
             ) or (
-                obj_label in ("car", "motorcycle")
+                obj_label in self.lp_objects
                 and self.lpr_min_obj_area > 0
                 and obj_area >= self.lpr_min_obj_area
                 and updated_obj.obj_data.get("sub_label") is None
@@ -548,7 +553,7 @@ class CameraState:
                     current_best.thumbnail_data is not None
                     and obj.thumbnail_data is not None
                     and is_better_thumbnail(
-                        object_type,
+                        obj.thumbnail_attributes,
                         current_best.thumbnail_data,
                         obj.thumbnail_data,
                         self.camera_config.frame_shape,

frigate/comms/base_communicator.py

@@ -1,27 +1,11 @@
 from abc import ABC, abstractmethod
 from collections.abc import Callable
-from typing import TYPE_CHECKING, Any
-
-if TYPE_CHECKING:
-    from frigate.comms.dispatcher import Dispatcher
+from typing import Any
 
 
 class Communicator(ABC):
     """pub/sub model via specific protocol."""
 
-    def attach_dispatcher(self, dispatcher: "Dispatcher") -> None:
-        """Receive the owning dispatcher.
-
-        Transports that need more than the receiver callback (the command topic
-        surface, the snapshot API) take it here rather than reaching through the
-        bound receiver.
-        """
-        return None
-
-    def start(self) -> None:
-        """Start background I/O after receiver wiring is complete."""
-        return None
-
     @abstractmethod
     def publish(self, topic: str, payload: Any, retain: bool = False) -> None:
         """Send data via specific protocol."""

frigate/comms/dispatcher.py

@@ -11,7 +11,7 @@ from frigate.camera.activity_manager import AudioActivityManager, CameraActivity
 from frigate.comms.base_communicator import Communicator
 from frigate.comms.runtime_state import RuntimeStatePersistence
 from frigate.comms.webpush import WebPushClient
-from frigate.config import BirdseyeModeConfig, FrigateConfig
+from frigate.config import BirdseyeModeEnum, FrigateConfig
 from frigate.config.camera.updater import (
     CameraConfigUpdateEnum,
     CameraConfigUpdatePublisher,
@@ -45,11 +45,6 @@ from frigate.util.services import restart_frigate
 
 logger = logging.getLogger(__name__)
 
-# <camera>/<command>/<sub_command>/set, one segment longer than the rest
-SUB_COMMAND_TOPICS = frozenset({"motion_mask", "object_mask", "zone"})
-
-BARE_COMMAND_TOPICS = frozenset({"onConnect", "restart"})
-
 
 class Dispatcher:
     """Handle communication between Frigate and communicators."""
@@ -104,113 +99,11 @@ class Dispatcher:
         }
         self.profile_manager: ProfileManager | None = None
 
-        self.web_push_client = next(
-            (comm for comm in communicators if isinstance(comm, WebPushClient)), None
-        )
-
         for comm in self.comms:
             comm.subscribe(self._receive)
-            comm.attach_dispatcher(self)
 
-    def start_communicators(self) -> None:
-        """Start communicators after dispatcher wiring is fully initialized."""
-        for comm in self.comms:
-            comm.start()
-
-    def is_command_topic(self, topic: str) -> bool:
-        """Whether a prefix-stripped topic maps to a command handler.
-
-        Transports that fan a whole topic tree in must filter on this:
-        _receive() republishes anything it does not recognize, so forwarding
-        unfiltered would echo Frigate's own publishes back.
-        """
-        parts = topic.split("/")
-
-        if topic in BARE_COMMAND_TOPICS:
-            return True
-
-        if len(parts) == 2 and parts[1] == "ptz":
-            return True
-
-        if len(parts) == 2 and parts[1] == "set":
-            return parts[0] in self._global_settings_handlers
-
-        if len(parts) == 3 and parts[2] == "set":
-            return (
-                parts[1] in self._camera_settings_handlers
-                and parts[1] not in SUB_COMMAND_TOPICS
-            )
-
-        if len(parts) == 3 and parts[2] == "suspend":
-            return parts[1] == "notifications"
-
-        if len(parts) == 4 and parts[3] == "set":
-            return parts[1] in SUB_COMMAND_TOPICS
-
-        return False
-
-    def _build_camera_activity_snapshot(self) -> tuple[dict[str, Any], dict[str, Any]]:
-        """Build the current runtime activity snapshot for reconnect consumers."""
-        camera_status = {
-            camera: status
-            for camera, status in self.camera_activity.last_camera_activity.copy().items()
-            if camera in self.config.cameras
-        }
-        audio_detections = self.audio_activity.current_audio_detections.copy()
-        cameras_with_status = camera_status.keys()
-
-        for camera in self.config.cameras.keys():
-            if camera not in cameras_with_status:
-                camera_status[camera] = {}
-
-            camera_status[camera]["config"] = {
-                "detect": self.config.cameras[camera].detect.enabled,
-                "enabled": self.config.cameras[camera].enabled,
-                "snapshots": self.config.cameras[camera].snapshots.enabled,
-                "record": self.config.cameras[camera].record.enabled,
-                "audio": self.config.cameras[camera].audio.enabled,
-                "audio_transcription": self.config.cameras[
-                    camera
-                ].audio_transcription.live_enabled,
-                "notifications": self.config.cameras[camera].notifications.enabled,
-                "notifications_suspended": int(
-                    self.web_push_client.suspended_cameras.get(camera, 0)
-                )
-                if self.web_push_client
-                and camera in self.web_push_client.suspended_cameras
-                else 0,
-                "autotracking": self.config.cameras[camera].onvif.autotracking.enabled,
-                "alerts": self.config.cameras[camera].review.alerts.enabled,
-                "detections": self.config.cameras[camera].review.detections.enabled,
-                "object_descriptions": self.config.cameras[
-                    camera
-                ].objects.genai.enabled,
-                "review_descriptions": self.config.cameras[camera].review.genai.enabled,
-            }
-
-        return camera_status, audio_detections
-
-    def publish_runtime_snapshot(
-        self,
-        publisher: Callable[[str, Any, bool], None] | None = None,
-    ) -> None:
-        """Publish the runtime snapshot for newly connected listeners."""
-        publish = publisher or self.publish
-        camera_status, audio_detections = self._build_camera_activity_snapshot()
-
-        publish("camera_activity", json.dumps(camera_status), False)
-        publish("model_state", json.dumps(self.model_state.copy()), False)
-        publish(
-            "embeddings_reindex_progress",
-            json.dumps(self.embeddings_reindex.copy()),
-            False,
-        )
-        publish("birdseye_layout", json.dumps(self.birdseye_layout.copy()), False)
-        publish("audio_detections", json.dumps(audio_detections), False)
-        publish(
-            "profile/state",
-            self.config.active_profile or "none",
-            True,
+        self.web_push_client = next(
+            (comm for comm in communicators if isinstance(comm, WebPushClient)), None
         )
         if self.web_push_client is not None:
             self.web_push_client.set_suspension_broadcaster(self.publish)
@@ -230,11 +123,17 @@ class Dispatcher:
 
             try:
                 if command_type == "set":
+                    # Commands that require a sub-command (mask/zone name)
+                    sub_command_required = {
+                        "motion_mask",
+                        "object_mask",
+                        "zone",
+                    }
                     if sub_command:
                         self._camera_settings_handlers[command](
                             camera_name, sub_command, payload
                         )
-                    elif command in SUB_COMMAND_TOPICS:
+                    elif command in sub_command_required:
                         logger.error(
                             "Command %s requires a sub-command (mask/zone name)",
                             command,
@@ -368,11 +267,67 @@ class Dispatcher:
         def handle_birdseye_layout() -> None:
             self.publish("birdseye_layout", json.dumps(self.birdseye_layout.copy()))
 
+        def handle_on_connect() -> None:
+            camera_status = {
+                camera: status
+                for camera, status in self.camera_activity.last_camera_activity.copy().items()
+                if camera in self.config.cameras
+            }
+            audio_detections = self.audio_activity.current_audio_detections.copy()
+            cameras_with_status = camera_status.keys()
+
+            for camera in self.config.cameras.keys():
+                if camera not in cameras_with_status:
+                    camera_status[camera] = {}
+
+                camera_status[camera]["config"] = {
+                    "detect": self.config.cameras[camera].detect.enabled,
+                    "enabled": self.config.cameras[camera].enabled,
+                    "snapshots": self.config.cameras[camera].snapshots.enabled,
+                    "record": self.config.cameras[camera].record.enabled,
+                    "audio": self.config.cameras[camera].audio.enabled,
+                    "audio_transcription": self.config.cameras[
+                        camera
+                    ].audio_transcription.live_enabled,
+                    "notifications": self.config.cameras[camera].notifications.enabled,
+                    "notifications_suspended": int(
+                        self.web_push_client.suspended_cameras.get(camera, 0)
+                    )
+                    if self.web_push_client
+                    and camera in self.web_push_client.suspended_cameras
+                    else 0,
+                    "autotracking": self.config.cameras[
+                        camera
+                    ].onvif.autotracking.enabled,
+                    "alerts": self.config.cameras[camera].review.alerts.enabled,
+                    "detections": self.config.cameras[camera].review.detections.enabled,
+                    "object_descriptions": self.config.cameras[
+                        camera
+                    ].objects.genai.enabled,
+                    "review_descriptions": self.config.cameras[
+                        camera
+                    ].review.genai.enabled,
+                }
+
+            self.publish("camera_activity", json.dumps(camera_status))
+            self.publish("model_state", json.dumps(self.model_state.copy()))
+            self.publish(
+                "embeddings_reindex_progress",
+                json.dumps(self.embeddings_reindex.copy()),
+            )
+            self.publish("birdseye_layout", json.dumps(self.birdseye_layout.copy()))
+            self.publish("audio_detections", json.dumps(audio_detections))
+            self.publish(
+                "profile/state",
+                self.config.active_profile or "none",
+                retain=True,
+            )
+
         def handle_notification_test() -> None:
             self.publish("notification_test", "Test notification")
 
         # Dictionary mapping topic to handlers
-        topic_handlers: dict[str, Callable[[], Any]] = {
+        topic_handlers = {
             INSERT_MANY_RECORDINGS: handle_insert_many_recordings,
             REQUEST_REGION_GRID: handle_request_region_grid,
             INSERT_PREVIEW: handle_insert_preview,
@@ -395,7 +350,7 @@ class Dispatcher:
             "jobState": handle_job_state,
             "audioTranscriptionState": handle_audio_transcription_state,
             "birdseyeLayout": handle_birdseye_layout,
-            "onConnect": self.publish_runtime_snapshot,
+            "onConnect": handle_on_connect,
         }
 
         if topic.endswith("set") or topic.endswith("ptz") or topic.endswith("suspend"):
@@ -927,9 +882,8 @@ class Dispatcher:
     def _on_birdseye_mode_command(self, camera_name: str, payload: str) -> None:
         """Callback for birdseye mode topic."""
 
-        mode = BirdseyeModeConfig.from_mqtt_payload(payload)
-        if mode is None:
-            logger.info("Invalid birdseye_mode command: %s", payload)
+        if payload not in ["CONTINUOUS", "MOTION", "OBJECTS"]:
+            logger.info(f"Invalid birdseye_mode command: {payload}")
             return
 
         birdseye_settings = self.config.cameras[camera_name].birdseye
@@ -938,7 +892,7 @@ class Dispatcher:
             logger.info(f"Birdseye mode not enabled for {camera_name}")
             return
 
-        birdseye_settings.mode = mode
+        birdseye_settings.mode = BirdseyeModeEnum(payload.lower())
         logger.info(
             f"Setting birdseye mode for {camera_name} to {birdseye_settings.mode}"
         )
@@ -947,9 +901,7 @@ class Dispatcher:
             CameraConfigUpdateTopic(CameraConfigUpdateEnum.birdseye, camera_name),
             birdseye_settings,
         )
-        self.publish(
-            f"{camera_name}/birdseye_mode/state", mode.to_mqtt_payload(), retain=True
-        )
+        self.publish(f"{camera_name}/birdseye_mode/state", payload, retain=True)
 
     def _on_camera_notification_command(self, camera_name: str, payload: str) -> None:
         """Callback for camera level notifications topic."""

frigate/comms/inter_process.py

@@ -18,13 +18,10 @@ SOCKET_REP_REQ = "ipc:///tmp/cache/comms"
 
 class InterProcessCommunicator(Communicator):
     def __init__(self) -> None:
-        # bound eagerly so subprocesses starting before start_communicators()
-        # can still connect; their requests queue in zmq until the reader runs
         self.context = zmq.Context()
         self.socket = self.context.socket(zmq.REP)
         self.socket.bind(SOCKET_REP_REQ)
         self.stop_event: MpEvent = mp.Event()
-        self.reader_thread: threading.Thread | None = None
 
     def publish(self, topic: str, payload: Any, retain: bool = False) -> None:
         """There is no communication back to the processes."""
@@ -32,8 +29,6 @@ class InterProcessCommunicator(Communicator):
 
     def subscribe(self, receiver: Callable) -> None:
         self._dispatcher = receiver
-
-    def start(self) -> None:
         self.reader_thread = threading.Thread(target=self.read)
         self.reader_thread.start()
 
@@ -66,8 +61,7 @@ class InterProcessCommunicator(Communicator):
 
     def stop(self) -> None:
         self.stop_event.set()
-        if self.reader_thread is not None:
-            self.reader_thread.join()
+        self.reader_thread.join()
         self.socket.close(linger=0)
         self.context.destroy(linger=0)
 

frigate/comms/mqtt.py

@@ -1,12 +1,7 @@
-from __future__ import annotations
-
 import logging
-import queue
 import threading
-import time
 from collections.abc import Callable
-from dataclasses import dataclass
-from typing import TYPE_CHECKING, Any
+from typing import Any
 
 import paho.mqtt.client as mqtt
 from paho.mqtt.enums import CallbackAPIVersion
@@ -14,25 +9,8 @@ from paho.mqtt.enums import CallbackAPIVersion
 from frigate.comms.base_communicator import Communicator
 from frigate.config import FrigateConfig
 
-if TYPE_CHECKING:
-    from frigate.comms.dispatcher import Dispatcher
-
 logger = logging.getLogger(__name__)
 
-MQTT_LOOP_TIMEOUT = 1.0
-MQTT_RECONNECT_INTERVAL = 10.0
-MQTT_SHUTDOWN_FLUSH_TIMEOUT = 5.0
-MQTT_ON_CONNECT_RATE_LIMIT = 1.0
-MQTT_PUBLISH_WAIT_INTERVAL = 0.1
-
-
-@dataclass(slots=True)
-class QueuedPublish:
-    topic: str
-    payload: Any
-    retain: bool
-    done: threading.Event | None = None
-
 
 class MqttClient(Communicator):
     """Frigate wrapper for mqtt client."""
@@ -41,80 +19,28 @@ class MqttClient(Communicator):
         self.config = config
         self.mqtt_config = config.mqtt
         self.connected = False
-        self.client: mqtt.Client | None = None
-        self._dispatcher: Callable[[str, Any], Any] | None = None
-        self._command_router: Dispatcher | None = None
-        self._worker: threading.Thread | None = None
-        self._stop_event = threading.Event()
-        self._publish_queue: queue.Queue[QueuedPublish] = queue.Queue()
-        self._callback_queue: queue.Queue[tuple[Any, ...]] = queue.Queue()
-        self._retained_lock = threading.Lock()
-        self._pending_retained: dict[str, tuple[Any, bool]] = {}
-        self._inflight_retained: dict[int, tuple[str, Any]] = {}
-        self._subscription_mid: int | None = None
-        self._subscription_ready = False
-        self._next_connect_time = 0.0
-        self._last_on_connect_dispatch = 0.0
 
     def subscribe(self, receiver: Callable) -> None:
         """Wrapper for allowing dispatcher to subscribe."""
         self._dispatcher = receiver
-
-    def attach_dispatcher(self, dispatcher: Dispatcher) -> None:
-        """Take Dispatcher's command surface and snapshot API."""
-        self._command_router = dispatcher
-
-    def start(self) -> None:
-        """Start the MQTT worker after all receiver wiring is complete."""
-
-        if self._worker and self._worker.is_alive():
-            return
-
-        self._stop_event.clear()
-        self._start_worker()
+        self._start()
 
     def publish(self, topic: str, payload: Any, retain: bool = False) -> None:
         """Wrapper for publishing when client is in valid state."""
-        full_topic = f"{self.mqtt_config.topic_prefix}/{topic}"
-
         if not self.connected:
-            if retain:
-                self._queue_retained(full_topic, payload, retain)
-            else:
-                logger.debug("Unable to publish to %s: client is not connected", topic)
+            logger.debug(f"Unable to publish to {topic}: client is not connected")
             return
 
-        self._publish_queue.put(QueuedPublish(full_topic, payload, retain))
+        self.client.publish(
+            f"{self.mqtt_config.topic_prefix}/{topic}",
+            payload,
+            qos=self.config.mqtt.qos,
+            retain=retain,
+        )
 
     def stop(self) -> None:
-        if self._worker is None:
-            return
-
-        if self.connected and self._subscription_ready:
-            publish_done = threading.Event()
-            self._publish_queue.put(
-                QueuedPublish(
-                    f"{self.mqtt_config.topic_prefix}/available",
-                    "stopped",
-                    True,
-                    publish_done,
-                )
-            )
-            publish_done.wait(MQTT_SHUTDOWN_FLUSH_TIMEOUT)
-
-        self._stop_event.set()
-
-        if self.client is not None:
-            try:
-                self.client.disconnect()
-            except Exception:
-                logger.debug("MQTT disconnect raised during shutdown", exc_info=True)
-
-        if self._worker.is_alive():
-            self._worker.join(MQTT_SHUTDOWN_FLUSH_TIMEOUT + MQTT_LOOP_TIMEOUT)
-
-        self._cleanup_client()
-        self._worker = None
+        self.publish("available", "stopped", retain=True)
+        self.client.disconnect()
 
     def _notifications_enabled_in_config(self) -> bool:
         """Whether notifications are configured globally or on any camera.
@@ -128,17 +54,17 @@ class MqttClient(Communicator):
             for cam in self.config.cameras.values()
         )
 
-    def _publish_retained_state(self) -> None:
-        """Publish retained MQTT state after a successful subscribe."""
+    def _set_initial_topics(self) -> None:
+        """Set initial state topics."""
         for camera_name, camera in self.config.cameras.items():
             self.publish(
                 f"{camera_name}/enabled/state",
-                "ON" if camera.enabled else "OFF",
+                "ON" if camera.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
                 f"{camera_name}/recordings/state",
-                "ON" if camera.record.enabled else "OFF",
+                "ON" if camera.record.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
@@ -148,7 +74,7 @@ class MqttClient(Communicator):
             )
             self.publish(
                 f"{camera_name}/audio/state",
-                "ON" if camera.audio.enabled else "OFF",
+                "ON" if camera.audio.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
@@ -163,7 +89,7 @@ class MqttClient(Communicator):
             )
             self.publish(
                 f"{camera_name}/motion/state",
-                "ON" if camera.motion.enabled else "OFF",
+                "ON",
                 retain=True,
             )
             self.publish(
@@ -173,7 +99,7 @@ class MqttClient(Communicator):
             )
             self.publish(
                 f"{camera_name}/ptz_autotracker/state",
-                "ON" if camera.onvif.autotracking.enabled else "OFF",
+                "ON" if camera.onvif.autotracking.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
@@ -199,7 +125,7 @@ class MqttClient(Communicator):
             self.publish(
                 f"{camera_name}/birdseye_mode/state",
                 (
-                    camera.birdseye.mode.to_mqtt_payload()
+                    camera.birdseye.mode.value.upper()
                     if camera.birdseye.enabled
                     else "OFF"
                 ),
@@ -207,22 +133,22 @@ class MqttClient(Communicator):
             )
             self.publish(
                 f"{camera_name}/review_alerts/state",
-                "ON" if camera.review.alerts.enabled else "OFF",
+                "ON" if camera.review.alerts.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
                 f"{camera_name}/review_detections/state",
-                "ON" if camera.review.detections.enabled else "OFF",
+                "ON" if camera.review.detections.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
                 f"{camera_name}/object_descriptions/state",
-                "ON" if camera.objects.genai.enabled else "OFF",
+                "ON" if camera.objects.genai.enabled_in_config else "OFF",
                 retain=True,
             )
             self.publish(
                 f"{camera_name}/review_descriptions/state",
-                "ON" if camera.review.genai.enabled else "OFF",
+                "ON" if camera.review.genai.enabled_in_config else "OFF",
                 retain=True,
             )
 
@@ -263,514 +189,13 @@ class MqttClient(Communicator):
         )
         self.publish("available", "online", retain=True)
 
-    def _create_client(self) -> mqtt.Client:
-        """Build a fresh paho client for a single connect attempt."""
-        client = mqtt.Client(
-            callback_api_version=CallbackAPIVersion.VERSION2,
-            client_id=self.mqtt_config.client_id,
-            reconnect_on_failure=False,
-        )
-        client.on_connect = self._on_connect
-        client.on_disconnect = self._on_disconnect
-        client.on_message = self._on_message
-        client.on_subscribe = self._on_subscribe
-        client.on_publish = self._on_publish
-        client.will_set(
-            self.mqtt_config.topic_prefix + "/available",
-            payload="offline",
-            qos=1,
-            retain=True,
-        )
-
-        if self.mqtt_config.tls_ca_certs is not None:
-            if (
-                self.mqtt_config.tls_client_cert is not None
-                and self.mqtt_config.tls_client_key is not None
-            ):
-                client.tls_set(
-                    self.mqtt_config.tls_ca_certs,
-                    self.mqtt_config.tls_client_cert,
-                    self.mqtt_config.tls_client_key,
-                )
-            else:
-                client.tls_set(self.mqtt_config.tls_ca_certs)
-
-        if self.mqtt_config.tls_insecure is not None:
-            client.tls_insecure_set(self.mqtt_config.tls_insecure)
-
-        if self.mqtt_config.user is not None:
-            client.username_pw_set(
-                self.mqtt_config.user,
-                password=self.mqtt_config.password,
-            )
-
-        return client
-
-    def _start_worker(self) -> None:
-        self._worker = threading.Thread(
-            target=self._worker_main, name="mqtt", daemon=True
-        )
-        self._worker.start()
-        logger.info("MQTT worker started")
-
-    def _worker_main(self) -> None:
-        """Run the worker loop.
-
-        An unexpected crash disables MQTT for this session rather than taking
-        Frigate down with it, so it has to announce itself: without the offline
-        publish, consumers keep the last retained values and see a healthy
-        Frigate that has simply stopped updating.
-        """
-        try:
-            self._mqtt_loop_worker()
-        except Exception:
-            if not self._stop_event.is_set():
-                logger.exception("MQTT worker crashed, disabling MQTT for this session")
-                self._stop_event.set()
-                self._subscription_ready = False
-                self._publish_offline_availability()
-                self.connected = False
-        finally:
-            # nothing drains the queue once the loop is gone, so release any
-            # waiter here or stop() blocks for the full flush timeout
-            self._requeue_disconnected_publishes()
-            self._cleanup_client()
-
-    def _publish_offline_availability(self) -> None:
-        """Announce that MQTT is going away after a worker crash.
-
-        _cleanup_client() disconnects cleanly, which tells the broker to
-        suppress the will, so the retained topic would otherwise stay "online".
-        """
-        if self.client is None:
-            return
-
-        try:
-            message_info = self.client.publish(
-                f"{self.mqtt_config.topic_prefix}/available",
-                "offline",
-                qos=self.config.mqtt.qos,
-                retain=True,
-            )
-
-            # pumped here rather than through _wait_for_publish() so the drain
-            # that may have just crashed is not re-entered
-            deadline = time.monotonic() + MQTT_SHUTDOWN_FLUSH_TIMEOUT
-            while not message_info.is_published() and time.monotonic() < deadline:
-                if (
-                    self.client.loop(timeout=MQTT_PUBLISH_WAIT_INTERVAL)
-                    != mqtt.MQTT_ERR_SUCCESS
-                ):
-                    break
-        except Exception:
-            logger.warning(
-                "MQTT is dormant and the broker could not be told Frigate is offline",
-                exc_info=True,
-            )
-
-    def _mqtt_loop_worker(self) -> None:
-        # The worker owns all socket I/O so reconnect, subscribe, and publish
-        # ordering stays serialized in one place.
-        while not self._stop_event.is_set():
-            if self.client is None:
-                wait_time = self._next_connect_time - time.monotonic()
-                if wait_time > 0:
-                    self._stop_event.wait(min(wait_time, MQTT_LOOP_TIMEOUT))
-                    continue
-
-                if not self._connect_client():
-                    self._next_connect_time = time.monotonic() + MQTT_RECONNECT_INTERVAL
-                    continue
-
-            assert self.client is not None
-            try:
-                result = self.client.loop(timeout=MQTT_LOOP_TIMEOUT)
-            except (OSError, mqtt.WebsocketConnectionError) as err:
-                logger.warning("MQTT loop error: %s", err)
-                self._schedule_reconnect()
-                continue
-
-            self._drain_callback_queue()
-            self._drain_publish_queue()
-
-            if self._stop_event.is_set():
-                break
-
-            if result != mqtt.MQTT_ERR_SUCCESS and self.client is not None:
-                logger.error("MQTT loop returned error code: %s", result)
-                self._schedule_reconnect()
-
-    def _connect_client(self) -> bool:
-        """Create and connect a new client instance owned by the worker thread."""
-        try:
-            self.client = self._create_client()
-            self.client.connect(self.mqtt_config.host, self.mqtt_config.port, 60)
-        except Exception as err:
-            logger.error("Unable to connect to MQTT server: %s", err)
-            self._cleanup_client()
-            return False
-
-        return True
-
-    def _cleanup_client(self) -> None:
-        """Drop session-specific state and release the current paho client."""
-        self.connected = False
-        self._subscription_ready = False
-        self._subscription_mid = None
-        self._requeue_inflight_retained()
-
-        client = self.client
-        self.client = None
-
-        if client is None:
-            return
-
-        try:
-            client.disconnect()
-        except Exception:
-            logger.debug("MQTT client cleanup raised disconnect error", exc_info=True)
-
-    def _schedule_reconnect(self) -> None:
-        """Tear down the current session and arm the next reconnect attempt."""
-        if self._stop_event.is_set():
-            return
-
-        self.connected = False
-        self._subscription_ready = False
-        self._subscription_mid = None
-        self._requeue_disconnected_publishes()
-        self._next_connect_time = time.monotonic() + MQTT_RECONNECT_INTERVAL
-        logger.info("MQTT reconnect scheduled in %.1fs", MQTT_RECONNECT_INTERVAL)
-        self._cleanup_client()
-
-    def _requeue_inflight_retained(self) -> None:
-        """Rebuffer retained publishes paho took but the broker never acked.
-
-        Dropping the client drops paho's outbound queue with it, and the session
-        is clean, so the broker will not resume delivery on the new one.
-        """
-        with self._retained_lock:
-            # mids are insertion ordered, so collapsing by topic keeps the
-            # newest value when several updates to one topic were in flight
-            latest = {
-                topic: payload for topic, payload in self._inflight_retained.values()
-            }
-            self._inflight_retained.clear()
-
-        for topic, payload in latest.items():
-            self._queue_retained(topic, payload, True, overwrite=False)
-
-    def _buffer_undelivered(
-        self, queued_publish: QueuedPublish, overwrite: bool = True
+    def on_mqtt_command(
+        self, client: mqtt.Client, userdata: Any, message: mqtt.MQTTMessage
     ) -> None:
-        """Handle a publish that never reached the broker.
-
-        Releasing the waiter matters on every path: stop() blocks on it, so a
-        broker error would otherwise stall shutdown for the full flush timeout.
-        """
-        if queued_publish.retain:
-            self._queue_retained(
-                queued_publish.topic,
-                queued_publish.payload,
-                queued_publish.retain,
-                overwrite=overwrite,
-            )
-
-        if queued_publish.done is not None:
-            queued_publish.done.set()
-
-    def _requeue_disconnected_publishes(self) -> None:
-        while True:
-            try:
-                queued_publish = self._publish_queue.get_nowait()
-            except queue.Empty:
-                break
-
-            self._buffer_undelivered(queued_publish)
-
-    def _drain_callback_queue(self) -> None:
-        # Paho callbacks only enqueue transport events; state transitions run
-        # here on the worker thread.
-        while True:
-            try:
-                event = self._callback_queue.get_nowait()
-            except queue.Empty:
-                break
-
-            event_type = event[0]
-
-            if event_type == "connect":
-                self._handle_connect_event(event[1])
-            elif event_type == "connect_failure":
-                self._handle_connect_failure(event[1])
-            elif event_type == "disconnect":
-                self._handle_disconnect_event(event[1])
-            elif event_type == "subscribed":
-                self._handle_subscribe_event(event[1], event[2])
-            elif event_type == "message":
-                self._handle_inbound_message(event[1], event[2])
-            elif event_type == "published":
-                self._handle_publish_event(event[1])
-
-    def _drain_publish_queue(self) -> None:
-        """Publish queued work only after the session is fully subscribed."""
-        if self.connected and not self._subscription_ready:
-            return
-
-        while True:
-            try:
-                queued_publish = self._publish_queue.get_nowait()
-            except queue.Empty:
-                break
-
-            if not self.connected:
-                self._buffer_undelivered(queued_publish)
-                continue
-
-            self._publish_direct(queued_publish)
-
-        self._flush_pending_retained()
-
-    def _flush_pending_retained(self) -> None:
-        """Replay the latest retained state once the broker session is ready."""
-        if not self.connected or not self._subscription_ready:
-            return
-
-        with self._retained_lock:
-            pending = list(self._pending_retained.items())
-            self._pending_retained.clear()
-
-        for topic, (payload, retain) in pending:
-            self._publish_direct(QueuedPublish(topic, payload, retain))
-
-    def _publish_direct(self, queued_publish: QueuedPublish) -> None:
-        """Publish a queued message from the worker thread's serialized context.
-
-        The waiter is released however this exits. The message is already off
-        the queue by now, so nothing else can recover it for a stop() that is
-        blocked waiting on it.
-        """
-        try:
-            if self.client is None:
-                self._buffer_undelivered(queued_publish)
-                return
-
-            try:
-                message_info = self.client.publish(
-                    queued_publish.topic,
-                    queued_publish.payload,
-                    qos=self.config.mqtt.qos,
-                    retain=queued_publish.retain,
-                )
-            except (OSError, mqtt.WebsocketConnectionError) as err:
-                logger.warning(
-                    "MQTT publish failed for %s: %s", queued_publish.topic, err
-                )
-                # a newer buffered value for this topic wins over the failed one
-                self._buffer_undelivered(queued_publish, overwrite=False)
-                self._schedule_reconnect()
-                return
-
-            if message_info.rc != mqtt.MQTT_ERR_SUCCESS:
-                logger.error(
-                    "Unable to publish to %s: mqtt error %s",
-                    queued_publish.topic,
-                    message_info.rc,
-                )
-                self._buffer_undelivered(queued_publish, overwrite=False)
-                self._schedule_reconnect()
-                return
-
-            # a successful rc only means paho accepted the message; above qos 0
-            # it is not durable until the broker acks, so keep a copy for replay
-            if queued_publish.retain and not message_info.is_published():
-                with self._retained_lock:
-                    self._inflight_retained[message_info.mid] = (
-                        queued_publish.topic,
-                        queued_publish.payload,
-                    )
-
-            if queued_publish.done is not None:
-                self._wait_for_publish(message_info)
-        finally:
-            if queued_publish.done is not None:
-                queued_publish.done.set()
-
-    def _handle_publish_event(self, mid: int) -> None:
-        """Drop the replay copy once the broker has acknowledged the message."""
-        with self._retained_lock:
-            self._inflight_retained.pop(mid, None)
-
-    def _wait_for_publish(self, message_info: mqtt.MQTTMessageInfo) -> None:
-        """Pump the loop until a shutdown-critical publish is acknowledged."""
-        deadline = time.monotonic() + MQTT_SHUTDOWN_FLUSH_TIMEOUT
-
-        while not message_info.is_published() and time.monotonic() < deadline:
-            if self.client is None:
-                return
-
-            try:
-                result = self.client.loop(timeout=MQTT_PUBLISH_WAIT_INTERVAL)
-            except (OSError, mqtt.WebsocketConnectionError) as err:
-                logger.warning("MQTT publish wait failed: %s", err)
-                self._schedule_reconnect()
-                return
-
-            self._drain_callback_queue()
-
-            if result != mqtt.MQTT_ERR_SUCCESS:
-                logger.error(
-                    "MQTT loop returned error code while waiting for publish: %s",
-                    result,
-                )
-                self._schedule_reconnect()
-                return
-
-    def _queue_retained(
-        self,
-        topic: str,
-        payload: Any,
-        retain: bool,
-        overwrite: bool = True,
-    ) -> None:
-        """Store the last retained value per topic for replay after reconnect."""
-        with self._retained_lock:
-            if overwrite or topic not in self._pending_retained:
-                self._pending_retained[topic] = (payload, retain)
-
-    def _handle_connect_event(self, reason_code: mqtt.ReasonCode) -> None:  # type: ignore[name-defined]
-        """Begin a new session by subscribing before any replay is published."""
-        if self.client is None:
-            return
-
-        self.connected = True
-        self._subscription_ready = False
-        self._subscription_mid = None
-        logger.debug("MQTT connected")
-
-        try:
-            result, mid = self.client.subscribe(
-                f"{self.mqtt_config.topic_prefix}/#",
-                qos=self.config.mqtt.qos,
-            )
-        except (OSError, mqtt.WebsocketConnectionError) as err:
-            logger.warning("MQTT subscribe failed: %s", err)
-            self._schedule_reconnect()
-            return
-
-        if result != mqtt.MQTT_ERR_SUCCESS:
-            logger.error(
-                "Unable to subscribe to MQTT command tree: mqtt error %s", result
-            )
-            self._schedule_reconnect()
-            return
-
-        self._subscription_mid = mid
-
-    def _handle_connect_failure(self, reason_code: mqtt.ReasonCode) -> None:  # type: ignore[name-defined]
-        """Record a failed connect attempt and transition into reconnect state."""
-        self.connected = False
-        logger.error(
-            "Unable to connect to MQTT server: %s", self._reason_code_name(reason_code)
+        self._dispatcher(
+            message.topic.replace(f"{self.mqtt_config.topic_prefix}/", "", 1),
+            message.payload.decode(),
         )
-        self._schedule_reconnect()
-
-    def _handle_disconnect_event(self, reason_code: mqtt.ReasonCode) -> None:  # type: ignore[name-defined]
-        """Handle broker disconnects idempotently from the worker thread."""
-        if not self.connected:
-            return
-
-        self.connected = False
-        self._subscription_ready = False
-        self._subscription_mid = None
-
-        if self._stop_event.is_set():
-            logger.debug("MQTT disconnected")
-            self._cleanup_client()
-            return
-
-        logger.error("MQTT disconnected: %s", self._reason_code_name(reason_code))
-        self._schedule_reconnect()
-
-    def _handle_subscribe_event(
-        self,
-        mid: int,
-        reason_codes: list[mqtt.ReasonCode],  # type: ignore[name-defined]
-    ) -> None:
-        """Mark the session ready after SUBACK, then replay retained/runtime state."""
-        if mid != self._subscription_mid:
-            return
-
-        if any(
-            getattr(reason_code, "is_failure", False) for reason_code in reason_codes
-        ):
-            logger.error("MQTT subscription was rejected by the broker")
-            self._schedule_reconnect()
-            return
-
-        self._subscription_ready = True
-        self._subscription_mid = None
-
-        # a bug in replay should cost a snapshot, not the MQTT session
-        try:
-            self._publish_retained_state()
-
-            if self._command_router is not None:
-                self._command_router.publish_runtime_snapshot(self.publish)
-        except Exception:
-            logger.exception("Error replaying MQTT state after subscribe")
-
-    def _handle_inbound_message(self, topic: str, payload: str) -> None:
-        """Forward supported command topics into Dispatcher semantics."""
-        if self._dispatcher is None:
-            return
-
-        if not self._is_supported_command_topic(topic):
-            return
-
-        if topic == "onConnect":
-            now = time.monotonic()
-            if now - self._last_on_connect_dispatch < MQTT_ON_CONNECT_RATE_LIMIT:
-                logger.debug("Skipping MQTT onConnect replay request due to rate limit")
-                return
-            self._last_on_connect_dispatch = now
-
-        # a raise here used to end the network thread and take MQTT down
-        try:
-            self._dispatcher(topic, payload)
-        except Exception:
-            logger.exception("Error handling MQTT command topic %s", topic)
-
-    def _is_supported_command_topic(self, topic: str) -> bool:
-        """Filter the wildcard subscription down to Dispatcher's command surface.
-
-        Load-bearing rather than an optimization: the broker echoes Frigate's own
-        publishes back through frigate/#, and Dispatcher republishes topics it
-        does not recognize, so forwarding unfiltered would loop.
-        """
-        if self._command_router is None:
-            return False
-
-        # mirrors the gate on the state topic in _publish_retained_state()
-        if topic == "notifications/set" and not self._notifications_enabled_in_config():
-            return False
-
-        return self._command_router.is_command_topic(topic)
-
-    def _strip_topic_prefix(self, topic: str) -> str:
-        return topic.replace(f"{self.mqtt_config.topic_prefix}/", "", 1)
-
-    def _is_success_reason_code(self, reason_code: mqtt.ReasonCode) -> bool:  # type: ignore[name-defined]
-        if hasattr(reason_code, "is_failure"):
-            return not bool(reason_code.is_failure)
-
-        return bool(reason_code == 0)
-
-    def _reason_code_name(self, reason_code: mqtt.ReasonCode) -> str:  # type: ignore[name-defined]
-        if hasattr(reason_code, "getName"):
-            return str(reason_code.getName())
-
-        return str(reason_code)
 
     def _on_connect(
         self,
@@ -780,11 +205,29 @@ class MqttClient(Communicator):
         reason_code: mqtt.ReasonCode,  # type: ignore[name-defined]
         properties: Any,
     ) -> None:
-        """Handle broker connect notifications from paho."""
-        if self._is_success_reason_code(reason_code):
-            self._callback_queue.put(("connect", reason_code))
-        else:
-            self._callback_queue.put(("connect_failure", reason_code))
+        """Mqtt connection callback."""
+        threading.current_thread().name = "mqtt"
+        if reason_code != 0:
+            if reason_code == "Server unavailable":
+                logger.error(
+                    "Unable to connect to MQTT server: MQTT Server unavailable"
+                )
+            elif reason_code == "Bad user name or password":
+                logger.error(
+                    "Unable to connect to MQTT server: MQTT Bad username or password"
+                )
+            elif reason_code == "Not authorized":
+                logger.error("Unable to connect to MQTT server: MQTT Not authorized")
+            else:
+                logger.error(
+                    "Unable to connect to MQTT server: Connection refused. Error code: %s",
+                    reason_code.getName(),
+                )
+
+        self.connected = True
+        logger.debug("MQTT connected")
+        client.subscribe(f"{self.mqtt_config.topic_prefix}/#", qos=self.config.mqtt.qos)
+        self._set_initial_topics()
 
     def _on_disconnect(
         self,
@@ -794,63 +237,126 @@ class MqttClient(Communicator):
         reason_code: mqtt.ReasonCode,  # type: ignore[name-defined]
         properties: Any,
     ) -> None:
-        """Handle broker disconnect notifications from paho."""
-        self._callback_queue.put(("disconnect", reason_code))
+        """Mqtt disconnection callback."""
+        self.connected = False
+        logger.error("MQTT disconnected")
 
-    def _on_subscribe(
-        self,
-        client: mqtt.Client,
-        userdata: Any,
-        mid: int,
-        reason_codes: list[mqtt.ReasonCode],  # type: ignore[name-defined]
-        properties: Any,
-    ) -> None:
-        """Handle subscribe acknowledgements from paho."""
-        self._callback_queue.put(("subscribed", mid, reason_codes))
-
-    def _on_publish(
-        self,
-        client: mqtt.Client,
-        userdata: Any,
-        mid: int,
-        reason_code: mqtt.ReasonCode,  # type: ignore[name-defined]
-        properties: Any,
-    ) -> None:
-        """Handle publish acknowledgements from paho.
-
-        Only tracked retained messages need an event. At the default qos 0
-        nothing is tracked, so this stays off the hot publish path.
-        """
-        with self._retained_lock:
-            if mid not in self._inflight_retained:
-                return
-
-        self._callback_queue.put(("published", mid))
-
-    def _on_message(
-        self,
-        client: mqtt.Client,
-        userdata: Any,
-        message: mqtt.MQTTMessage,
-    ) -> None:
-        """Queue inbound MQTT messages for processing in the worker loop."""
-        topic = self._strip_topic_prefix(message.topic)
-
-        # Ignore everything outside Frigate's command surface before decoding or
-        # dispatching into the rest of the app.
-        if not self._is_supported_command_topic(topic):
-            return
-
-        try:
-            payload = message.payload.decode()
-        except UnicodeDecodeError:
-            logger.debug("Ignoring non-UTF-8 MQTT payload for topic %s", topic)
-            return
-
-        self._callback_queue.put(
-            (
-                "message",
-                topic,
-                payload,
-            )
+    def _start(self) -> None:
+        """Start mqtt client."""
+        self.client = mqtt.Client(
+            callback_api_version=CallbackAPIVersion.VERSION2,
+            client_id=self.mqtt_config.client_id,
         )
+        self.client.on_connect = self._on_connect
+        self.client.on_disconnect = self._on_disconnect
+        self.client.will_set(
+            self.mqtt_config.topic_prefix + "/available",
+            payload="offline",
+            qos=1,
+            retain=True,
+        )
+
+        # register callbacks
+        callback_types = [
+            "enabled",
+            "recordings",
+            "snapshots",
+            "detect",
+            "audio",
+            "audio_transcription",
+            "motion",
+            "improve_contrast",
+            "ptz_autotracker",
+            "motion_threshold",
+            "motion_contour_area",
+            "birdseye",
+            "birdseye_mode",
+            "review_alerts",
+            "review_detections",
+            "object_descriptions",
+            "review_descriptions",
+            "notifications",
+        ]
+
+        for name in self.config.cameras.keys():
+            for callback in callback_types:
+                self.client.message_callback_add(
+                    f"{self.mqtt_config.topic_prefix}/{name}/{callback}/set",
+                    self.on_mqtt_command,
+                )
+
+            # notifications suspend doesn't follow the /set topic pattern
+            self.client.message_callback_add(
+                f"{self.mqtt_config.topic_prefix}/{name}/notifications/suspend",
+                self.on_mqtt_command,
+            )
+
+            if self.config.cameras[name].onvif.host:
+                self.client.message_callback_add(
+                    f"{self.mqtt_config.topic_prefix}/{name}/ptz",
+                    self.on_mqtt_command,
+                )
+
+            for mask_name in self.config.cameras[name].motion.mask.keys():
+                self.client.message_callback_add(
+                    f"{self.mqtt_config.topic_prefix}/{name}/motion_mask/{mask_name}/set",
+                    self.on_mqtt_command,
+                )
+
+            for mask_name in self.config.cameras[name].objects.mask.keys():
+                self.client.message_callback_add(
+                    f"{self.mqtt_config.topic_prefix}/{name}/object_mask/{mask_name}/set",
+                    self.on_mqtt_command,
+                )
+
+            for zone_name in self.config.cameras[name].zones.keys():
+                self.client.message_callback_add(
+                    f"{self.mqtt_config.topic_prefix}/{name}/zone/{zone_name}/set",
+                    self.on_mqtt_command,
+                )
+
+        if self._notifications_enabled_in_config():
+            self.client.message_callback_add(
+                f"{self.mqtt_config.topic_prefix}/notifications/set",
+                self.on_mqtt_command,
+            )
+
+        self.client.message_callback_add(
+            f"{self.mqtt_config.topic_prefix}/profile/set",
+            self.on_mqtt_command,
+        )
+
+        self.client.message_callback_add(
+            f"{self.mqtt_config.topic_prefix}/onConnect", self.on_mqtt_command
+        )
+
+        self.client.message_callback_add(
+            f"{self.mqtt_config.topic_prefix}/restart", self.on_mqtt_command
+        )
+
+        if self.mqtt_config.tls_ca_certs is not None:
+            if (
+                self.mqtt_config.tls_client_cert is not None
+                and self.mqtt_config.tls_client_key is not None
+            ):
+                self.client.tls_set(
+                    self.mqtt_config.tls_ca_certs,
+                    self.mqtt_config.tls_client_cert,
+                    self.mqtt_config.tls_client_key,
+                )
+            else:
+                self.client.tls_set(self.mqtt_config.tls_ca_certs)
+        if self.mqtt_config.tls_insecure is not None:
+            self.client.tls_insecure_set(self.mqtt_config.tls_insecure)
+        if self.mqtt_config.user is not None:
+            self.client.username_pw_set(
+                self.mqtt_config.user, password=self.mqtt_config.password
+            )
+        try:
+            # https://stackoverflow.com/a/55390477
+            # with connect_async, retries are handled automatically
+            self.client.connect_async(self.mqtt_config.host, self.mqtt_config.port, 60)
+            self.client.loop_start()
+        except Exception as e:
+            logger.error(f"Unable to connect to MQTT server: {e}")
+            return

frigate/comms/webpush.py

@@ -63,8 +63,14 @@ class WebPushClient(Communicator):
         self.last_notification_time: float = 0
         self.user_cameras: dict[str, set[str]] = {}
         self.notification_queue: queue.Queue[PushNotification] = queue.Queue()
-        self.notification_thread: threading.Thread | None = None
-        self.suspension_thread: threading.Thread | None = None
+        self.notification_thread = threading.Thread(
+            target=self._process_notifications, daemon=True
+        )
+        self.notification_thread.start()
+        self.suspension_thread = threading.Thread(
+            target=self._process_suspensions, daemon=True
+        )
+        self.suspension_thread.start()
 
         if not self.config.notifications.email:
             logger.warning("Email must be provided for push notifications to be sent.")
@@ -83,7 +89,9 @@ class WebPushClient(Communicator):
         # notification and auth config updater
         self.global_config_subscriber = ConfigSubscriber("config/")
         self.config_subscriber = CameraConfigUpdateSubscriber(
-            self.config, self.config.cameras, [CameraConfigUpdateEnum.notifications]
+            self.config,
+            self.config.cameras,
+            [CameraConfigUpdateEnum.add, CameraConfigUpdateEnum.notifications],
         )
         self._refresh_user_cameras()
 
@@ -91,16 +99,6 @@ class WebPushClient(Communicator):
         """Wrapper for allowing dispatcher to subscribe."""
         pass
 
-    def start(self) -> None:
-        self.notification_thread = threading.Thread(
-            target=self._process_notifications, daemon=True
-        )
-        self.notification_thread.start()
-        self.suspension_thread = threading.Thread(
-            target=self._process_suspensions, daemon=True
-        )
-        self.suspension_thread.start()
-
     def check_registrations(self) -> None:
         # check for valid claim or create new one
         now = datetime.datetime.now().timestamp()
@@ -217,12 +215,12 @@ class WebPushClient(Communicator):
                 self.suspended_cameras[camera] = 0
                 self.last_camera_notification_time[camera] = 0
 
+            self._refresh_user_cameras()
+
         if topic == "reviews":
             decoded = json.loads(payload)
             camera = decoded["before"]["camera"]
-            camera_config = self.config.cameras.get(camera)
-
-            if camera_config is None or not camera_config.notifications.enabled:
+            if not self.config.cameras[camera].notifications.enabled:
                 return
             if self.is_camera_suspended(camera):
                 logger.debug(f"Notifications for {camera} are currently suspended.")
@@ -236,14 +234,13 @@ class WebPushClient(Communicator):
 
             # ensure notifications are enabled and the specific trigger has
             # notification action enabled
-            camera_config = self.config.cameras.get(camera)
-
             if (
-                camera_config is None
-                or not camera_config.notifications.enabled
-                or name not in camera_config.semantic_search.triggers
+                not self.config.cameras[camera].notifications.enabled
+                or name not in self.config.cameras[camera].semantic_search.triggers
                 or "notification"
-                not in camera_config.semantic_search.triggers[name].actions
+                not in self.config.cameras[camera]
+                .semantic_search.triggers[name]
+                .actions
             ):
                 return
 
@@ -254,9 +251,7 @@ class WebPushClient(Communicator):
         elif topic == "camera_monitoring":
             decoded = json.loads(payload)
             camera = decoded["camera"]
-            camera_config = self.config.cameras.get(camera)
-
-            if camera_config is None or not camera_config.notifications.enabled:
+            if not self.config.cameras[camera].notifications.enabled:
                 return
             if self.is_camera_suspended(camera):
                 logger.debug(f"Notifications for {camera} are currently suspended.")
@@ -426,6 +421,7 @@ class WebPushClient(Communicator):
         # Don't notify if message is an update and important fields don't have an update
         if (
             state == "update"
+            and payload["before"]["severity"] == payload["after"]["severity"]
             and len(payload["before"]["data"]["objects"])
             == len(payload["after"]["data"]["objects"])
             and len(payload["before"]["data"]["zones"])
@@ -607,5 +603,4 @@ class WebPushClient(Communicator):
 
     def stop(self) -> None:
         logger.info("Closing notification queue")
-        if self.notification_thread is not None:
-            self.notification_thread.join()
+        self.notification_thread.join()

frigate/comms/ws.py

@@ -466,6 +466,7 @@ class WebSocketClient(Communicator):
 
     def subscribe(self, receiver: Callable) -> None:
         self._dispatcher = receiver
+        self.start()
 
     def start(self) -> None:
         """Start the websocket client."""

frigate/config/camera/birdseye.py

@@ -1,3 +1,5 @@
+from enum import Enum
+
 from pydantic import BaseModel, Field
 
 from ..base import FrigateBaseModel
@@ -6,78 +8,22 @@ __all__ = [
     "BirdseyeCameraConfig",
     "BirdseyeConfig",
     "BirdseyeLayoutConfig",
-    "BirdseyeModeConfig",
+    "BirdseyeModeEnum",
 ]
 
-BIRDSEYE_ACTIVITY_TYPES = (
-    "objects",
-    "motion",
-    "stationary_objects",
-    "continuous",
-)
 
-
-class BirdseyeModeConfig(FrigateBaseModel):
-    continuous: bool = Field(
-        default=False,
-        title="Continuous",
-        description="Always include the camera in Birdseye.",
-    )
-    motion: bool = Field(
-        default=False,
-        title="Motion",
-        description="Include the camera in Birdseye when motion is detected.",
-    )
-    objects: bool = Field(
-        default=False,
-        title="Active objects",
-        description="Include the camera in Birdseye while an active object is tracked.",
-    )
-    stationary_objects: bool = Field(
-        default=False,
-        title="Stationary objects",
-        description="Include the camera in Birdseye while a stationary object is tracked.",
-    )
+class BirdseyeModeEnum(str, Enum):
+    objects = "objects"
+    motion = "motion"
+    continuous = "continuous"
 
     @classmethod
-    def from_mqtt_payload(cls, payload: str) -> "BirdseyeModeConfig | None":
-        """Create mode options from an uppercase MQTT payload."""
-        raw_modes = payload.split(",")
-        if not raw_modes or any(not mode for mode in raw_modes):
-            return None
+    def get_index(cls, type):
+        return list(cls).index(type)
 
-        modes = [mode.lower() for mode in raw_modes]
-        if any(
-            raw_mode != mode.upper() or mode not in BIRDSEYE_ACTIVITY_TYPES
-            for raw_mode, mode in zip(raw_modes, modes)
-        ):
-            return None
-
-        if len(modes) != len(set(modes)):
-            return None
-
-        return cls(**{mode: True for mode in modes})
-
-    def has_enabled_activity(self) -> bool:
-        """Return whether at least one activity type is enabled."""
-        return any(getattr(self, activity) for activity in BIRDSEYE_ACTIVITY_TYPES)
-
-    def to_mqtt_payload(self) -> str:
-        """Serialize enabled mode options for MQTT state topics."""
-        payload = ",".join(
-            activity.upper()
-            for activity in BIRDSEYE_ACTIVITY_TYPES
-            if getattr(self, activity)
-        )
-        if not payload:
-            raise ValueError("At least one Birdseye activity type must be enabled")
-
-        return payload
-
-
-def default_birdseye_mode() -> BirdseyeModeConfig:
-    """Return the default Birdseye mode configuration."""
-    return BirdseyeModeConfig(objects=True)
+    @classmethod
+    def get(cls, index):
+        return list(cls)[index]
 
 
 class BirdseyeLayoutConfig(FrigateBaseModel):
@@ -101,10 +47,10 @@ class BirdseyeConfig(FrigateBaseModel):
         title="Enable Birdseye",
         description="Enable or disable the Birdseye view feature.",
     )
-    mode: BirdseyeModeConfig = Field(
-        default_factory=default_birdseye_mode,
-        title="Activity types",
-        description="Activity types that include cameras in Birdseye.",
+    mode: BirdseyeModeEnum = Field(
+        default=BirdseyeModeEnum.objects,
+        title="Tracking mode",
+        description="Mode for including cameras in Birdseye: 'objects', 'motion', or 'continuous'.",
     )
 
     restream: bool = Field(
@@ -156,10 +102,10 @@ class BirdseyeCameraConfig(BaseModel):
         title="Enable Birdseye",
         description="Enable or disable the Birdseye view feature.",
     )
-    mode: BirdseyeModeConfig = Field(
-        default_factory=default_birdseye_mode,
-        title="Activity types",
-        description="Activity types that include cameras in Birdseye.",
+    mode: BirdseyeModeEnum = Field(
+        default=BirdseyeModeEnum.objects,
+        title="Tracking mode",
+        description="Mode for including cameras in Birdseye: 'objects', 'motion', or 'continuous'.",
     )
 
     order: int = Field(

frigate/config/config.py

@@ -41,7 +41,7 @@ from .auth import AuthConfig
 from .base import FrigateBaseModel
 from .camera import CameraConfig, CameraLiveConfig
 from .camera.audio import AudioConfig, AudioFilterConfig
-from .camera.birdseye import BirdseyeConfig, BirdseyeModeConfig
+from .camera.birdseye import BirdseyeConfig
 from .camera.detect import DetectConfig
 from .camera.ffmpeg import FfmpegConfig
 from .camera.genai import GenAIConfig, GenAIRoleEnum
@@ -326,20 +326,8 @@ def verify_required_zones_exist(camera_config: CameraConfig) -> None:
 
 
 def verify_profile_overrides_match_base(camera_config: CameraConfig) -> None:
-    """Verify profile overrides against the resolved base camera configuration."""
+    """Verify that profile zone and mask IDs reference entries defined on the base camera."""
     for profile_name, profile in camera_config.profiles.items():
-        if profile.birdseye is not None:
-            overrides = profile.birdseye.mode.model_dump(exclude_unset=True)
-            base_mode = camera_config.birdseye.mode.model_dump()
-            resolved_mode = BirdseyeModeConfig.model_validate(
-                deep_merge(overrides, base_mode)
-            )
-            if not resolved_mode.has_enabled_activity():
-                raise ValueError(
-                    f"Camera '{camera_config.name}' profile '{profile_name}' must "
-                    "enable at least one Birdseye activity type"
-                )
-
         if profile.zones:
             for zone_name in profile.zones:
                 if zone_name not in camera_config.zones:
@@ -1010,10 +998,6 @@ class FrigateConfig(FrigateBaseModel):
             self.cameras[name] = camera_config
 
             verify_config_roles(camera_config)
-            if not camera_config.birdseye.mode.has_enabled_activity():
-                raise ValueError(
-                    f"Camera '{name}' must enable at least one Birdseye activity type"
-                )
             verify_valid_live_stream_names(self, camera_config)
             verify_recording_segments_setup_with_reasonable_time(camera_config)
             verify_zone_objects_are_tracked(camera_config)

frigate/config/profile_manager.py

@@ -43,9 +43,7 @@ SECTION_STATE_TOPICS: dict[str, list[tuple[str, Callable[[Any], Any]]]] = {
         ("birdseye", lambda c: "ON" if c.birdseye.enabled else "OFF"),
         (
             "birdseye_mode",
-            lambda c: (
-                c.birdseye.mode.to_mqtt_payload() if c.birdseye.enabled else "OFF"
-            ),
+            lambda c: c.birdseye.mode.value.upper() if c.birdseye.enabled else "OFF",
         ),
     ],
     "detect": [("detect", lambda c: "ON" if c.detect.enabled else "OFF")],

frigate/const.py

@@ -44,7 +44,11 @@ DEFAULT_ATTRIBUTE_LABEL_MAP = {
         "ups",
         "usps",
     ],
+    "truck": ["license_plate"],
+    "garbage_truck": ["license_plate"],
     "motorcycle": ["license_plate"],
+    "bus": ["license_plate"],
+    "school_bus": ["license_plate"],
 }
 ATTRIBUTE_LABEL_DISPLAY_MAP = {
     "amazon": "Amazon",

frigate/data_processing/common/license_plate/mixin.py

@@ -1290,7 +1290,7 @@ class LicensePlateProcessingMixin:
                 and obj_data.get("label") != "license_plate"
             ):
                 logger.debug(
-                    f"{camera}: Not a processing license plate for non car/motorcycle object."
+                    f"{camera}: Not a processing license plate for {obj_data.get('label', 'unknown')}."
                 )
                 return
 
@@ -1367,7 +1367,7 @@ class LicensePlateProcessingMixin:
 
                 if not license_plate:
                     logger.debug(
-                        f"{camera}: Detected no license plates for car/motorcycle object."
+                        f"{camera}: Detected no license plates for {obj_data.get('label', 'unknown')} object."
                     )
                     return
 

frigate/data_processing/post/audio_transcription.py

@@ -83,10 +83,6 @@ class AudioTranscriptionPostProcessor(PostProcessorApi):
         """
         event_id = data["event_id"]
         camera_name = data["camera"]
-        camera_config = self.config.cameras.get(camera_name)
-
-        if camera_config is None:
-            return
 
         if data_type == PostProcessDataEnum.recording:
             start_ts = data["frame_time"]
@@ -108,7 +104,7 @@ class AudioTranscriptionPostProcessor(PostProcessorApi):
 
         try:
             audio_data = get_audio_from_recording(
-                camera_config.ffmpeg,
+                self.config.cameras[camera_name].ffmpeg,
                 camera_name,
                 start_ts,
                 end_ts,

frigate/data_processing/post/object_descriptions.py

@@ -151,12 +151,7 @@ class ObjectDescriptionProcessor(PostProcessorApi):
             logger.error(f"Event {event_id} not found for description regeneration")
             return
 
-        camera_config = self.config.cameras.get(str(event.camera))
-
-        if camera_config is None:
-            logger.error("Camera %s no longer exists", event.camera)
-            return
-
+        camera_config = self.config.cameras[str(event.camera)]
         if not camera_config.objects.genai.enabled and not force:
             logger.error(f"GenAI not enabled for camera {event.camera}")
             return

frigate/data_processing/post/review_descriptions.py

@@ -137,10 +137,7 @@ class ReviewDescriptionProcessor(PostProcessorApi):
             return
 
         camera = data["after"]["camera"]
-        camera_config = self.config.cameras.get(camera)
-
-        if camera_config is None:
-            return
+        camera_config = self.config.cameras[camera]
 
         if not camera_config.review.genai.enabled:
             return

frigate/db/sqlitevecq.py

@@ -1,8 +1,10 @@
 import logging
 import sqlite3
+import threading
 from typing import Any
 
 import regex
+from peewee import DatabaseError
 from playhouse.sqliteq import SqliteQueueDatabase
 
 logger = logging.getLogger(__name__)
@@ -17,6 +19,7 @@ class SqliteVecQueueDatabase(SqliteQueueDatabase):
         self.load_vec_extension: bool = load_vec_extension
         # no extension necessary, sqlite will load correctly for each platform
         self.sqlite_vec_path = "/usr/local/lib/vec0"
+        self.upsert_lock = threading.Lock()
         super().__init__(*args, **kwargs)
 
     def _connect(self, *args: Any, **kwargs: Any) -> sqlite3.Connection:
@@ -53,6 +56,22 @@ class SqliteVecQueueDatabase(SqliteQueueDatabase):
 
         conn.create_function("REGEXP", 2, regexp)
 
+    def execute_write(self, sql: str, params: Any = None) -> None:
+        """Run a write and wait for it, so that failures are raised here.
+
+        SqliteQueueDatabase hands non-SELECT statements to a writer thread and
+        stores any exception on the cursor it returns, so callers that ignore
+        that cursor never learn the write failed.
+        """
+        self.execute_sql(sql, params).fetchall()
+
+    def _table_exists(self, table: str) -> bool:
+        cursor = self.execute_sql(
+            "SELECT name FROM sqlite_master WHERE type = 'table' AND name = ?",
+            (table,),
+        )
+        return cursor.fetchone() is not None
+
     def _delete_embeddings(self, table: str, event_ids: list[str]) -> None:
         """Delete embeddings for the given events, if the table exists.
 
@@ -63,17 +82,17 @@ class SqliteVecQueueDatabase(SqliteQueueDatabase):
             return
 
         # the embeddings tables are only created once semantic search has run
-        cursor = self.execute_sql(
-            "SELECT name FROM sqlite_master WHERE type = 'table' AND name = ?",
-            (table,),
-        )
-
-        if cursor.fetchone() is None:
+        if not self._table_exists(table):
             logger.debug("Skipping %s cleanup, table does not exist", table)
             return
 
         ids = ",".join(["?" for _ in event_ids])
-        self.execute_sql(f"DELETE FROM {table} WHERE id IN ({ids})", event_ids)
+
+        # callers treat cleanup as best effort, so log rather than propagate
+        try:
+            self.execute_write(f"DELETE FROM {table} WHERE id IN ({ids})", event_ids)
+        except DatabaseError:
+            logger.exception("Failed to delete embeddings from %s", table)
 
     def delete_embeddings_thumbnail(self, event_ids: list[str]) -> None:
         self._delete_embeddings("vec_thumbnails", event_ids)
@@ -81,25 +100,67 @@ class SqliteVecQueueDatabase(SqliteQueueDatabase):
     def delete_embeddings_description(self, event_ids: list[str]) -> None:
         self._delete_embeddings("vec_descriptions", event_ids)
 
+    def _restore_vec_info_table(self, table: str) -> None:
+        """Recreate the _info shadow table a legacy vec0 table is missing.
+
+        sqlite-vec added _info in 0.1.6 and drops it unconditionally when a
+        table is destroyed, so tables written by Frigate 0.17 and earlier fail
+        to drop. An empty stub is enough, and leaving it unseeded keeps the
+        table reading as pre-0.1.10 if the drop does not follow.
+        """
+        if not self._table_exists(table) or self._table_exists(f"{table}_info"):
+            return
+
+        logger.debug("Restoring the %s_info shadow table before dropping", table)
+        self.execute_write(
+            f'CREATE TABLE "{table}_info" (key TEXT PRIMARY KEY, value ANY)'
+        )
+
     def drop_embeddings_tables(self) -> None:
-        self.execute_sql("""
-            DROP TABLE vec_descriptions;
-        """)
-        self.execute_sql("""
-            DROP TABLE vec_thumbnails;
-        """)
+        for table in ("vec_descriptions", "vec_thumbnails"):
+            self._restore_vec_info_table(table)
+            self.execute_write(f"DROP TABLE IF EXISTS {table}")
 
     def create_embeddings_tables(self) -> None:
         """Create vec0 virtual table for embeddings"""
-        self.execute_sql("""
+        self.execute_write("""
             CREATE VIRTUAL TABLE IF NOT EXISTS vec_thumbnails USING vec0(
                 id TEXT PRIMARY KEY,
                 thumbnail_embedding FLOAT[768] distance_metric=cosine
             );
         """)
-        self.execute_sql("""
+        self.execute_write("""
             CREATE VIRTUAL TABLE IF NOT EXISTS vec_descriptions USING vec0(
                 id TEXT PRIMARY KEY,
                 description_embedding FLOAT[768] distance_metric=cosine
             );
         """)
+
+    def upsert_embeddings(
+        self, table: str, column: str, embeddings: dict[str, bytes]
+    ) -> None:
+        """Write embeddings for the given event ids, replacing any that exist.
+
+        vec0 implements neither REPLACE nor UPSERT, so rows that are already
+        there have to be deleted first.
+        """
+        if not embeddings:
+            return
+
+        event_ids = list(embeddings.keys())
+        ids = ",".join(["?" for _ in event_ids])
+        params: list[Any] = []
+
+        for event_id in event_ids:
+            params.extend((event_id, embeddings[event_id]))
+
+        values = ", ".join(["(?, ?)"] * len(event_ids))
+
+        # reindexing and live embedding run on separate threads, and each write
+        # is queued separately, so the delete and the insert have to be held
+        # together or an interleaved pair fails on the vec0 primary key
+        with self.upsert_lock:
+            self.execute_write(f"DELETE FROM {table} WHERE id IN ({ids})", event_ids)
+            self.execute_write(
+                f"INSERT INTO {table}(id, {column}) VALUES {values}", params
+            )

frigate/detectors/detection_runners.py

@@ -25,25 +25,31 @@ def is_arm64_platform() -> bool:
     return machine in ("aarch64", "arm64", "armv8", "armv7l")
 
 
-def get_ort_session_options(
-    is_complex_model: bool = False,
-) -> ort.SessionOptions | None:
+def get_ort_session_options(model_type: str | None = None) -> ort.SessionOptions | None:
     """Get ONNX Runtime session options with appropriate settings.
 
     Args:
-        is_complex_model: Whether the model needs basic optimization to avoid graph fusion issues.
+        model_type: Model being loaded, used to pin its graph optimization level.
 
     Returns:
-        SessionOptions with appropriate optimization level, or None for default settings.
+        SessionOptions with a pinned optimization level, or None for default settings.
     """
-    if is_complex_model:
-        sess_options = ort.SessionOptions()
-        sess_options.graph_optimization_level = (
-            ort.GraphOptimizationLevel.ORT_ENABLE_BASIC
-        )
-        return sess_options
+    # Import here to avoid circular imports
+    from frigate.embeddings.types import EnrichmentModelTypeEnum
 
-    return None
+    if model_type == EnrichmentModelTypeEnum.jina_v2.value:
+        # below EXTENDED the CUDA EP returns an identical vector for every image,
+        # and ORT_ENABLE_ALL fails to build on CPU with a SimplifiedLayerNormFusion error
+        level = ort.GraphOptimizationLevel.ORT_ENABLE_EXTENDED
+    elif model_type == EnrichmentModelTypeEnum.jina_v1.value:
+        # aggressive optimizations create or expect nodes that don't exist
+        level = ort.GraphOptimizationLevel.ORT_ENABLE_BASIC
+    else:
+        return None
+
+    sess_options = ort.SessionOptions()
+    sess_options.graph_optimization_level = level
+    return sess_options
 
 
 # Import OpenVINO only when needed to avoid circular dependencies
@@ -115,21 +121,6 @@ class BaseModelRunner(ABC):
 class ONNXModelRunner(BaseModelRunner):
     """Run ONNX models using ONNX Runtime."""
 
-    @staticmethod
-    def is_cpu_complex_model(model_type: str) -> bool:
-        """Check if model needs basic optimization level to avoid graph fusion issues.
-
-        Some models (like Jina-CLIP) have issues with aggressive optimizations like
-        SimplifiedLayerNormFusion that create or expect nodes that don't exist.
-        """
-        # Import here to avoid circular imports
-        from frigate.embeddings.types import EnrichmentModelTypeEnum
-
-        return model_type in [
-            EnrichmentModelTypeEnum.jina_v1.value,
-            EnrichmentModelTypeEnum.jina_v2.value,
-        ]
-
     @staticmethod
     def is_migraphx_complex_model(model_type: str) -> bool:
         # Import here to avoid circular imports
@@ -208,15 +199,20 @@ class CudaGraphRunner(BaseModelRunner):
             EnrichmentModelTypeEnum.yolov9_license_plate.value,
         ]
 
+    # ORT performs two regular runs before it starts capturing, but on some
+    # driver / cuDNN combinations the arena still has to extend on the run that
+    # captures, and cudaMalloc is not allowed during capture. Running with
+    # capture disabled first keeps those allocations outside of the capture.
+    GRAPH_FREE_WARMUP_RUNS = 2
+
     def __init__(self, session: ort.InferenceSession, cuda_device_id: int):
         self._session = session
         self._cuda_device_id = cuda_device_id
-        self._captured = False
+        self._prepared = False
         self._io_binding: ort.IOBinding | None = None
         self._input_name: str | None = None
         self._output_names: list[str] | None = None
         self._input_ortvalue: ort.OrtValue | None = None
-        self._output_ortvalues: ort.OrtValue | None = None
 
     def get_input_names(self) -> list[str]:
         """Get input names for the model."""
@@ -226,35 +222,41 @@ class CudaGraphRunner(BaseModelRunner):
         """Get the input width of the model."""
         return self._session.get_inputs()[0].shape[3]
 
+    def _prepare(self, input_name: str, tensor_input: np.ndarray) -> None:
+        """Bind CUDA buffers and warm the session up with capture disabled."""
+        self._io_binding = self._session.io_binding()
+        self._input_name = input_name
+        self._output_names = [o.name for o in self._session.get_outputs()]
+
+        self._input_ortvalue = ort.OrtValue.ortvalue_from_numpy(
+            tensor_input, "cuda", self._cuda_device_id
+        )
+        self._io_binding.bind_ortvalue_input(self._input_name, self._input_ortvalue)
+
+        for name in self._output_names:
+            # Bind outputs to CUDA and allow ORT to allocate appropriately
+            self._io_binding.bind_output(name, "cuda", self._cuda_device_id)
+
+        # gpu_graph_id -1 disables capture and replay for the run
+        warmup_options = ort.RunOptions()
+        warmup_options.add_run_config_entry("gpu_graph_id", "-1")
+
+        for _ in range(self.GRAPH_FREE_WARMUP_RUNS):
+            self._session.run_with_iobinding(self._io_binding, warmup_options)
+
+        self._prepared = True
+
     def run(self, input: dict[str, Any]):
         # Extract the single tensor input (assuming one input)
         input_name = list(input.keys())[0]
-        tensor_input = input[input_name]
-        tensor_input = np.ascontiguousarray(tensor_input)
+        tensor_input = np.ascontiguousarray(input[input_name])
 
-        if not self._captured:
-            # Prepare IOBinding with CUDA buffers and let ORT allocate outputs on device
-            self._io_binding = self._session.io_binding()
-            self._input_name = input_name
-            self._output_names = [o.name for o in self._session.get_outputs()]
+        if not self._prepared:
+            self._prepare(input_name, tensor_input)
+        else:
+            # Replay using updated input
+            self._input_ortvalue.update_inplace(tensor_input)
 
-            self._input_ortvalue = ort.OrtValue.ortvalue_from_numpy(
-                tensor_input, "cuda", self._cuda_device_id
-            )
-            self._io_binding.bind_ortvalue_input(self._input_name, self._input_ortvalue)
-
-            for name in self._output_names:
-                # Bind outputs to CUDA and allow ORT to allocate appropriately
-                self._io_binding.bind_output(name, "cuda", self._cuda_device_id)
-
-            # First IOBinding run to allocate, execute, and capture CUDA Graph
-            ro = ort.RunOptions()
-            self._session.run_with_iobinding(self._io_binding, ro)
-            self._captured = True
-            return self._io_binding.copy_outputs_to_cpu()
-
-        # Replay using updated input, copy results to CPU
-        self._input_ortvalue.update_inplace(tensor_input)
         ro = ort.RunOptions()
         self._session.run_with_iobinding(self._io_binding, ro)
         return self._io_binding.copy_outputs_to_cpu()
@@ -323,6 +325,12 @@ class OpenVINOModelRunner(BaseModelRunner):
         if device in ["GPU", "AUTO", "NPU"]:
             self.ov_core.set_property(device, {"PERFORMANCE_HINT": "LATENCY"})
 
+        if device in ["GPU", "AUTO"]:
+            try:
+                self.ov_core.set_property("GPU", {"GPU_QUEUE_THROTTLE": "LOW"})
+            except Exception as e:
+                logger.debug(f"GPU_QUEUE_THROTTLE not supported: {e}")
+
         if device == "NPU" and OpenVINOModelRunner.is_detection_model(model_type):
             try:
                 self.ov_core.set_property(device, {"NPU_TURBO": "YES"})
@@ -626,9 +634,7 @@ def get_optimized_runner(
     return ONNXModelRunner(
         ort.InferenceSession(
             model_path,
-            sess_options=get_ort_session_options(
-                ONNXModelRunner.is_cpu_complex_model(model_type)
-            ),
+            sess_options=get_ort_session_options(model_type),
             providers=providers,
             provider_options=options,
         ),

frigate/embeddings/embeddings.py

@@ -6,9 +6,10 @@ import logging
 import os
 import threading
 import time
+from typing import Any
 
 import numpy as np
-from peewee import DoesNotExist, IntegrityError
+from peewee import DatabaseError, DoesNotExist, IntegrityError
 from PIL import Image
 from playhouse.shortcuts import model_to_dict
 
@@ -207,12 +208,10 @@ class Embeddings:
         embedding = self.vision_embedding([thumbnail])[0]
 
         if upsert:
-            self.db.execute_sql(
-                """
-                INSERT OR REPLACE INTO vec_thumbnails(id, thumbnail_embedding)
-                VALUES(?, ?)
-                """,
-                (event_id, serialize(embedding)),
+            self.db.upsert_embeddings(
+                "vec_thumbnails",
+                "thumbnail_embedding",
+                {event_id: serialize(embedding)},
             )
 
         self.image_inference_speed.update(datetime.datetime.now().timestamp() - start)
@@ -251,19 +250,12 @@ class Embeddings:
         embeddings = self.vision_embedding(valid_thumbs)
 
         if upsert:
-            items = []
+            items = {}
             for i in range(len(valid_ids)):
-                items.append(valid_ids[i])
-                items.append(serialize(embeddings[i]))
+                items[valid_ids[i]] = serialize(embeddings[i])
                 self.image_eps.update()
 
-            self.db.execute_sql(
-                """
-                INSERT OR REPLACE INTO vec_thumbnails(id, thumbnail_embedding)
-                VALUES {}
-                """.format(", ".join(["(?, ?)"] * len(valid_ids))),
-                items,
-            )
+            self.db.upsert_embeddings("vec_thumbnails", "thumbnail_embedding", items)
 
         duration = datetime.datetime.now().timestamp() - start
         self.image_inference_speed.update(duration / len(valid_ids))
@@ -277,12 +269,10 @@ class Embeddings:
         embedding = self.text_embedding([description])[0]
 
         if upsert:
-            self.db.execute_sql(
-                """
-                INSERT OR REPLACE INTO vec_descriptions(id, description_embedding)
-                VALUES(?, ?)
-                """,
-                (event_id, serialize(embedding)),
+            self.db.upsert_embeddings(
+                "vec_descriptions",
+                "description_embedding",
+                {event_id: serialize(embedding)},
             )
 
         self.text_inference_speed.update(datetime.datetime.now().timestamp() - start)
@@ -302,19 +292,14 @@ class Embeddings:
 
         if upsert:
             ids = list(event_descriptions.keys())
-            items = []
+            items = {}
 
             for i in range(len(ids)):
-                items.append(ids[i])
-                items.append(serialize(embeddings[i]))
+                items[ids[i]] = serialize(embeddings[i])
                 self.text_eps.update()
 
-            self.db.execute_sql(
-                """
-                INSERT OR REPLACE INTO vec_descriptions(id, description_embedding)
-                VALUES {}
-                """.format(", ".join(["(?, ?)"] * len(ids))),
-                items,
+            self.db.upsert_embeddings(
+                "vec_descriptions", "description_embedding", items
             )
 
         self.text_inference_speed.update(datetime.datetime.now().timestamp() - start)
@@ -322,6 +307,17 @@ class Embeddings:
         return embeddings
 
     def reindex(self) -> None:
+        """Rebuild every tracked object embedding from scratch."""
+        totals: dict[str, Any] = {"status": "indexing"}
+
+        try:
+            self._reindex(totals)
+        except DatabaseError:
+            logger.exception("Unable to reindex tracked object embeddings")
+            totals["status"] = "failed"
+            self.requestor.send_data(UPDATE_EMBEDDINGS_REINDEX_PROGRESS, totals)
+
+    def _reindex(self, totals: dict[str, Any]) -> None:
         logger.info("Indexing tracked object embeddings...")
 
         self.db.drop_embeddings_tables()
@@ -346,14 +342,18 @@ class Embeddings:
             batch_size = 32
         current_page = 1
 
-        totals = {
-            "thumbnails": 0,
-            "descriptions": 0,
-            "processed_objects": total_events - 1 if total_events < batch_size else 0,
-            "total_objects": total_events,
-            "time_remaining": 0 if total_events < batch_size else -1,
-            "status": "indexing",
-        }
+        totals.update(
+            {
+                "thumbnails": 0,
+                "descriptions": 0,
+                "processed_objects": total_events - 1
+                if total_events < batch_size
+                else 0,
+                "total_objects": total_events,
+                "time_remaining": 0 if total_events < batch_size else -1,
+                "status": "indexing",
+            }
+        )
 
         self.requestor.send_data(UPDATE_EMBEDDINGS_REINDEX_PROGRESS, totals)
 

frigate/embeddings/maintainer.py

@@ -609,18 +609,6 @@ class EmbeddingMaintainer(threading.Thread):
                 # Embed the thumbnail
                 self._embed_thumbnail(event_id, thumbnail)
 
-            # every post processor below reads config.cameras[camera], but
-            # tracked_events still has to be released or the thumbnails held
-            # for this event leak, same as the two exits above
-            if camera not in self.config.cameras:
-                logger.debug("Skipping post processing for removed camera %s", camera)
-
-                for processor in self.post_processors:
-                    if isinstance(processor, ObjectDescriptionProcessor):
-                        processor.cleanup_event(event_id)
-
-                continue
-
             # call any defined post processors
             for processor in self.post_processors:
                 if isinstance(processor, LicensePlatePostProcessor):
@@ -678,18 +666,11 @@ class EmbeddingMaintainer(threading.Thread):
         to_remove = []
 
         for id, data in self.detected_license_plates.items():
-            camera_config = self.config.cameras.get(data["camera"])
-
-            if camera_config is None:
-                # camera was removed, drop the entry rather than expiring it
-                to_remove.append(id)
-                continue
-
             last_seen = data.get("last_seen", 0)
             if not last_seen:
                 continue
 
-            if now - last_seen > camera_config.lpr.expire_time:
+            if now - last_seen > self.config.cameras[data["camera"]].lpr.expire_time:
                 to_remove.append(id)
         for id in to_remove:
             self.event_metadata_publisher.publish(

frigate/events/cleanup.py

@@ -365,6 +365,7 @@ class EventCleanup(threading.Thread):
                     chunk = ids_to_delete[i : i + CHUNK_SIZE]
                     logger.debug(f"Deleting {len(chunk)} events from the database")
                     Event.delete().where(Event.id << chunk).execute()
+                    Timeline.delete().where(Timeline.source_id << chunk).execute()
 
                     # embeddings are always cleaned up, even when semantic search
                     # is disabled, so that they don't outlive their events

frigate/ffmpeg_presets.py

@@ -121,8 +121,8 @@ PRESETS_HW_ACCEL_SCALE = {
     "preset-rpi-64-h264": "-r {0} -vf fps={0},scale={1}:{2}",
     "preset-rpi-64-h265": "-r {0} -vf fps={0},scale={1}:{2}",
     FFMPEG_HWACCEL_VAAPI: "-r {0} -vf fps={0},scale_vaapi=w={1}:h={2},hwdownload,format=nv12",
-    "preset-intel-qsv-h264": "-r {0} -vf vpp_qsv=w={1}:h={2}:format=nv12,hwdownload,format=nv12,fps={0},format=yuv420p",
-    "preset-intel-qsv-h265": "-r {0} -vf vpp_qsv=w={1}:h={2}:format=nv12,hwdownload,format=nv12,fps={0},format=yuv420p",
+    "preset-intel-qsv-h264": "-r {0} -vf fps={0},vpp_qsv=w={1}:h={2}:format=nv12,hwdownload,format=nv12,format=yuv420p",
+    "preset-intel-qsv-h265": "-r {0} -vf fps={0},vpp_qsv=w={1}:h={2}:format=nv12,hwdownload,format=nv12,format=yuv420p",
     FFMPEG_HWACCEL_NVIDIA: "-r {0} -vf fps={0},scale_cuda=w={1}:h={2},hwdownload,format=nv12",
     "preset-jetson-h264": "-r {0}",  # scaled in decoder
     "preset-jetson-h265": "-r {0}",  # scaled in decoder

frigate/genai/plugins/gemini.py

@@ -245,7 +245,7 @@ class GeminiClient(GenAIClient):
                     )
                     gemini_messages.append(
                         types.Content(
-                            role="function",
+                            role="user",
                             parts=[
                                 types.Part.from_function_response(
                                     name=msg.get("name")
@@ -501,7 +501,7 @@ class GeminiClient(GenAIClient):
                     )
                     gemini_messages.append(
                         types.Content(
-                            role="function",
+                            role="user",
                             parts=[
                                 types.Part.from_function_response(
                                     name=msg.get("name")

frigate/genai/prompts.py

@@ -262,10 +262,6 @@ def get_tool_definitions(
     `attribute` parameter is exposed for filtering by their labels. When the
     embeddings model only understands English (JinaV1), the `semantic_query`
     description instructs the model to write the query in English.
-
-    Descriptions here stay mechanical: which tool to reach for, and how the
-    filters relate to each other, is stated once in the system prompt so the
-    guidance is not paid for twice on every request.
     """
     search_objects_properties: dict[str, Any] = {
         "camera": {
@@ -274,13 +270,26 @@ def get_tool_definitions(
         },
         "label": {
             "type": "string",
-            "description": "Tracked object class to filter by.",
+            "description": (
+                "Generic object class to filter by — one of the tracked detector "
+                "labels such as 'person', 'package', 'car', 'dog', 'bird'. Use "
+                "this for broad queries like 'show me all cars today'. Combine "
+                "with semantic_query when the user also describes appearance or "
+                "behavior (e.g. label='person', semantic_query='riding a lawn "
+                "mower')."
+            ),
         },
         "sub_label": {
             "type": "string",
             "description": (
-                "Name recognized in the detection: a person, delivery company, "
-                "animal species or breed, or license plate."
+                "Filter by a DISCRETE NAMED entity recognized in the detection. "
+                "Use this for: a known person's name ('John'), a delivery "
+                "company ('Amazon', 'UPS'), a recognized animal species or "
+                "breed ('blue jay', 'cardinal', 'golden retriever'), or a "
+                "license plate string. When filtering by a specific name, set "
+                "only sub_label and leave label unset. Do NOT use sub_label "
+                "for descriptions of appearance, clothing, or actions — those "
+                "belong in semantic_query."
             ),
         },
         "after": {
@@ -304,11 +313,20 @@ def get_tool_definitions(
     }
 
     if attribute_classifications:
+        model_outline = "; ".join(
+            f"{m['name']} (applies to {', '.join(m['objects']) or 'any object'})"
+            for m in attribute_classifications
+        )
         search_objects_properties["attribute"] = {
             "type": "string",
             "description": (
-                "Attribute label produced by a configured classification model "
-                "(case-sensitive)."
+                "Filter by a classification attribute label produced by a "
+                "configured attribute classification model. Use this INSTEAD "
+                "of semantic_query when the user's request matches one of "
+                "these classifications. Configured models: "
+                f"{model_outline}. "
+                "Set the value to the attribute label that matches the user's "
+                "phrasing (case-sensitive)."
             ),
         }
 
@@ -316,12 +334,29 @@ def get_tool_definitions(
         search_objects_properties["semantic_query"] = {
             "type": "string",
             "description": (
-                "Description of an appearance or activity, used to semantically "
-                "narrow results."
+                "Optional natural-language description of a PHYSICAL "
+                "CHARACTERISTIC, APPEARANCE, or ACTIVITY the user mentioned, "
+                "used to semantically narrow results. Only set this when the "
+                "user describes something beyond what label and sub_label can "
+                "express on their own.\n"
+                "USE for descriptive phrases like: 'riding a lawn mower', "
+                "'wearing a red jacket', 'carrying a package', 'walking a "
+                "dog', 'on a bicycle', 'holding an umbrella'.\n"
+                "DO NOT USE for:\n"
+                "- specific named people, pets, or delivery companies → use sub_label\n"
+                "- animal species or breed names like 'blue jay', 'cardinal', "
+                "'golden retriever' → use sub_label\n"
+                "- license plate strings → use sub_label\n"
+                "- generic object queries like 'all cars today' or 'every "
+                "person' → use label alone with no semantic_query\n"
+                "When set, combine with label/time/camera/zone filters as "
+                "usual (e.g. label='person', semantic_query='riding a lawn "
+                "mower', after='2024-05-01T00:00:00Z')."
                 + (
-                    " The configured embeddings model only understands English, so "
-                    "always write this in English, translating the user's "
-                    "description if they phrased it in another language."
+                    " The configured embeddings model only understands "
+                    "English, so always write semantic_query in English, "
+                    "translating the user's description if they phrased it "
+                    "in another language."
                     if embeddings_language == "english"
                     else ""
                 )
@@ -329,10 +364,26 @@ def get_tool_definitions(
         }
 
     search_objects_description = (
-        "Search the historical record of tracked detections. Use this ONLY for "
-        "questions about the PAST, e.g. 'did anyone come by today?', 'when was the "
-        "last car?'. For alerting on future events use start_camera_watch instead."
+        "Search the historical record of detected objects in Frigate. "
+        "Use this ONLY for questions about the PAST — e.g. 'did anyone come by today?', "
+        "'when was the last car?', 'show me detections from yesterday'. "
+        "Do NOT use this for monitoring or alerting requests about future events — "
+        "use start_camera_watch instead for those. "
+        "An 'object' in Frigate represents a tracked detection (e.g., a person, package, car).\n\n"
+        "Choose filters based on what the user is asking for:\n"
+        "- Generic class query ('show me all cars today'): set `label` only.\n"
+        "- Specific NAMED entity (known person, delivery company, animal "
+        "species/breed like 'blue jay' or 'golden retriever', license "
+        "plate): set `sub_label` only and leave `label` unset.\n"
     )
+    if semantic_search_enabled:
+        search_objects_description += (
+            "- Physical CHARACTERISTIC, APPEARANCE, or ACTIVITY that is not a "
+            "discrete name ('person riding a lawn mower', 'someone in a red "
+            "jacket', 'person carrying a package'): set `semantic_query` with "
+            "the descriptive phrase, optionally alongside `label` for the "
+            "object class. Do NOT put descriptive phrases in sub_label."
+        )
 
     return [
         {
@@ -347,30 +398,20 @@ def get_tool_definitions(
                 "required": [],
             },
         },
-        {
-            "type": "function",
-            "function": {
-                "name": "get_categorized_object_names",
-                "description": (
-                    "Every name that can be attached as a sub_label, grouped by object "
-                    "type: recognized faces, named license plates, classification "
-                    "categories, and delivery logos. Takes no arguments and always "
-                    "returns the complete map."
-                ),
-                "parameters": {
-                    "type": "object",
-                    "properties": {},
-                    "required": [],
-                },
-            },
-        },
         {
             "type": "function",
             "function": {
                 "name": "find_similar_objects",
                 "description": (
-                    "Find tracked objects visually and semantically similar to a "
-                    "specific past event. Requires semantic search to be enabled."
+                    "Find tracked objects that are visually and semantically similar "
+                    "to a specific past event. Use this when the user references a "
+                    "particular object they have seen and wants to find other "
+                    "sightings of the same or similar one ('that green car', 'the "
+                    "person in the red jacket', 'the package that was delivered'). "
+                    "Prefer this over search_objects whenever the user's intent is "
+                    "'find more like this specific one.' Use search_objects first "
+                    "only if you need to locate the anchor event. Requires semantic "
+                    "search to be enabled."
                 ),
                 "parameters": {
                     "type": "object",
@@ -432,8 +473,9 @@ def get_tool_definitions(
             "function": {
                 "name": "set_camera_state",
                 "description": (
-                    "Change a camera's feature state, e.g. turn detection on or off. "
-                    "Only call this when the user explicitly asks to change a setting. "
+                    "Change a camera's feature state (e.g., turn detection on/off, enable/disable recordings). "
+                    "Use camera='*' to apply to all cameras at once. "
+                    "Only call this tool when the user explicitly asks to change a camera setting. "
                     "Requires admin privileges."
                 ),
                 "parameters": {
@@ -468,14 +510,14 @@ def get_tool_definitions(
                             ],
                             "description": (
                                 "The feature to change. Most features accept ON or OFF. "
-                                "birdseye_mode accepts CONTINUOUS, MOTION, OBJECTS, STATIONARY_OBJECTS, or a comma-separated combination. "
+                                "birdseye_mode accepts CONTINUOUS, MOTION, or OBJECTS. "
                                 "motion_contour_area and motion_threshold accept a number. "
                                 "profile accepts a profile name or 'none' to deactivate (requires camera='*')."
                             ),
                         },
                         "value": {
                             "type": "string",
-                            "description": "The value to set, as accepted by the chosen feature.",
+                            "description": "The value to set. ON or OFF for toggles, a number for thresholds, a profile name or 'none' for profile.",
                         },
                     },
                     "required": ["camera", "feature", "value"],
@@ -487,9 +529,11 @@ def get_tool_definitions(
             "function": {
                 "name": "get_live_context",
                 "description": (
-                    "Current live image and detections (tracked objects, zones, "
-                    "timestamps) for one camera. Use this for questions about what is "
-                    "happening right now. Call it again for each additional camera."
+                    "Get the current live image and detection information for a single camera: objects being tracked, "
+                    "zones, timestamps. Use this to understand what is visible in the live view. "
+                    "Call this when answering questions about what is happening right now on a specific camera. "
+                    "Operates on one camera at a time; call the tool again for each additional camera. "
+                    "Wildcards and empty values are not accepted."
                 ),
                 "parameters": {
                     "type": "object",
@@ -497,8 +541,8 @@ def get_tool_definitions(
                         "camera": {
                             "type": "string",
                             "description": (
-                                "Exact name of a single camera. Wildcards (e.g. '*', "
-                                "'all') and empty strings are not accepted."
+                                "Exact name of a single camera to get live context for. "
+                                "Wildcards (e.g. '*', 'all') and empty strings are not accepted."
                             ),
                         },
                     },
@@ -511,9 +555,10 @@ def get_tool_definitions(
             "function": {
                 "name": "start_camera_watch",
                 "description": (
-                    "Start a continuous watch job that monitors a camera and notifies "
-                    "the user when a condition is met, e.g. 'tell me when guests "
-                    "arrive'. Only one watch job can run at a time. Returns a job ID."
+                    "Start a continuous VLM watch job that monitors a camera and sends a notification "
+                    "when a specified condition is met. Use this when the user wants to be alerted about "
+                    "a future event, e.g. 'tell me when guests arrive' or 'notify me when the package is picked up'. "
+                    "Only one watch job can run at a time. Returns a job ID."
                 ),
                 "parameters": {
                     "type": "object",
@@ -553,7 +598,10 @@ def get_tool_definitions(
             "type": "function",
             "function": {
                 "name": "stop_camera_watch",
-                "description": "Cancel the currently running watch job.",
+                "description": (
+                    "Cancel the currently running VLM watch job. Use this when the user wants to "
+                    "stop a previously started watch, e.g. 'stop watching the front door'."
+                ),
                 "parameters": {
                     "type": "object",
                     "properties": {},
@@ -566,9 +614,11 @@ def get_tool_definitions(
             "function": {
                 "name": "get_profile_status",
                 "description": (
-                    "Get the active profile and when each profile was last activated. "
-                    "Call this before get_recap to derive the time window for requests "
-                    "like 'what happened while I was away?'."
+                    "Get the current profile status including the active profile and "
+                    "timestamps of when each profile was last activated. Use this to "
+                    "determine time periods for recap requests — e.g. when the user asks "
+                    "'what happened while I was away?', call this first to find the relevant "
+                    "time window based on profile activation history."
                 ),
                 "parameters": {
                     "type": "object",
@@ -582,9 +632,11 @@ def get_tool_definitions(
             "function": {
                 "name": "get_recap",
                 "description": (
-                    "Get all activity (alerts and detections) for a time period, as a "
-                    "chronological list with camera, objects, zones, and descriptions "
-                    "when available. Summarize the results for the user."
+                    "Get a recap of all activity (alerts and detections) for a given time period. "
+                    "Use this after calling get_profile_status to retrieve what happened during "
+                    "a specific window — e.g. 'what happened while I was away?'. Returns a "
+                    "chronological list of activity with camera, objects, zones, and GenAI-generated "
+                    "descriptions when available. Summarize the results for the user."
                 ),
                 "parameters": {
                     "type": "object",
@@ -671,13 +723,14 @@ def build_chat_system_prompt(
         )
         speed_units_section = f"\n\nReport object speeds to the user in {speed_unit}."
 
-    filter_routing_section = (
-        "\n\nWhen routing a search_objects call, pick filters by the shape of the user's request:\n"
-        "- Generic class ('show me all cars today'): set `label` only.\n"
-        "- Specific named entity — a known person ('John'), delivery company ('Amazon'), animal species/breed ('blue jay', 'golden retriever'), or license plate: set `sub_label` only and leave `label` unset. Call get_categorized_object_names first and use the exact spelling it returns; a guessed spelling matches nothing. If the name is absent, say it is not configured rather than searching for it."
-    )
+    semantic_search_section = ""
     if semantic_search_enabled:
-        filter_routing_section += "\n- Physical characteristic, appearance, or activity that is NOT a discrete name ('riding a lawn mower', 'someone in a red jacket'): set `semantic_query` with the descriptive phrase, optionally combined with `label`. Never put descriptive phrases in `sub_label`."
+        semantic_search_section = (
+            "\n\nWhen routing a search_objects call, pick filters by the shape of the user's request:\n"
+            "- Generic class ('show me all cars today'): set `label` only.\n"
+            "- Specific named entity — a known person ('John'), delivery company ('Amazon'), animal species/breed ('blue jay', 'cardinal', 'golden retriever'), or license plate: set `sub_label` only and leave `label` unset.\n"
+            "- Physical characteristic, appearance, or activity that is NOT a discrete name ('find me people riding a lawn mower', 'someone in a red jacket', 'a person carrying a package'): set `semantic_query` with the descriptive phrase, optionally combined with `label` for the object class. Never put descriptive phrases in `sub_label`."
+        )
 
     attribute_classification_section = ""
     if attribute_classifications:
@@ -686,9 +739,9 @@ def build_chat_system_prompt(
             for m in attribute_classifications
         )
         attribute_classification_section = (
-            "\n\nConfigured attribute classification models:\n"
+            "\n\nAttribute classification models are configured for the following object types:\n"
             f"{model_lines}\n"
-            "When the user's request matches one of these classifications, set the search_objects `attribute` field to the matching label (case-sensitive) rather than using `semantic_query`. Reserve `semantic_query` for descriptive phrases outside the configured attribute labels."
+            "When the user's request matches one of these classifications, set the search_objects `attribute` field to the matching label rather than using `semantic_query`. Reserve `semantic_query` for descriptive phrases that fall outside the configured attribute labels."
         )
 
     return f"""You are a helpful assistant for Frigate, a security camera NVR system. You help users answer questions about their cameras, detected objects, and events.
@@ -697,6 +750,9 @@ Current server local date and time: {current_date_str} at {current_time_str}
 
 Do not start your response with phrases like "I will check...", "Let me see...", or "Let me look...". Answer directly.
 
-Always present times in the server's local timezone. When tool results include start_time_local and end_time_local, quote those strings exactly; never convert or invent timestamps, and fall back to UTC or ISO format only when a result has no local time fields. Resolve relative dates like "today" or "this week" against the current date above, and pass dates to tools in ISO 8601 (e.g. {current_date_str}T00:00:00Z for the start of today).
+Always present times to the user in the server's local timezone. When tool results include start_time_local and end_time_local, use those exact strings when listing or describing detection times—do not convert or invent timestamps. Do not use UTC or ISO format with Z for the user-facing answer unless the tool result only provides Unix timestamps without local time fields.
+When users ask about "today", "yesterday", "this week", etc., use the current date above as reference.
+When searching for objects or events, use ISO 8601 format for dates (e.g., {current_date_str}T00:00:00Z for the start of today).
+Always be accurate with time calculations based on the current date provided.
 
-When the user refers to a specific object they have seen ("that green car", "the person in the red jacket", "a package left today"), prefer find_similar_objects over search_objects, using search_objects only to locate the anchor event and passing its id along. Keep search_objects for generic queries like "show me all cars today". If a user message begins with [attached_event:<id>], treat that id as the anchor for any similarity or "tell me more" request in the same message.{filter_routing_section}{attribute_classification_section}{cameras_section}{speed_units_section}"""
+When a user refers to a specific object they have seen or describe with identifying details ("that green car", "the person in the red jacket", "a package left today"), prefer the find_similar_objects tool over search_objects. Use search_objects first only to locate the anchor event, then pass its id to find_similar_objects. For generic queries like "show me all cars today", keep using search_objects. If a user message begins with [attached_event:<id>], treat that event id as the anchor for any similarity or "tell me more" request in the same message and call find_similar_objects with that id.{semantic_search_section}{attribute_classification_section}{cameras_section}{speed_units_section}"""

frigate/jobs/debug_replay.py

@@ -115,6 +115,10 @@ def query_recordings(source_camera: str, start_ts: float, end_ts: float) -> Mode
     return cast(ModelSelect, query)
 
 
+class NoRecordingsError(ValueError):
+    """Raised when no recordings exist in the requested time range."""
+
+
 class DebugReplaySource(ABC):
     """Abstract source for a debug replay session.
 
@@ -187,7 +191,7 @@ class RecordingDebugReplaySource(DebugReplaySource):
             raise ValueError("End time must be after start time")
 
         if not query_recordings(self._camera, self._start_ts, self._end_ts).count():
-            raise ValueError(
+            raise NoRecordingsError(
                 f"No recordings found for camera '{self._camera}' in the specified time range"
             )
 

frigate/output/birdseye.py

@@ -9,7 +9,6 @@ import queue
 import subprocess as sp
 import threading
 import traceback
-from dataclasses import dataclass
 from multiprocessing.synchronize import Event as MpEvent
 from typing import Any
 
@@ -17,7 +16,7 @@ import cv2
 import numpy as np
 
 from frigate.comms.inter_process import InterProcessRequestor
-from frigate.config import BirdseyeModeConfig, FfmpegConfig, FrigateConfig
+from frigate.config import BirdseyeModeEnum, FfmpegConfig, FrigateConfig
 from frigate.const import BASE_DIR, BIRDSEYE_PIPE, INSTALL_DIR, UPDATE_BIRDSEYE_LAYOUT
 from frigate.output.ws_auth import ws_has_camera_access
 from frigate.util.image import (
@@ -29,15 +28,6 @@ from frigate.util.image import (
 logger = logging.getLogger(__name__)
 
 
-@dataclass(frozen=True, slots=True)
-class BirdseyeActivity:
-    """Activity signals used to decide whether a camera is shown in Birdseye."""
-
-    has_active_object: bool
-    has_stationary_object: bool
-    has_motion: bool
-
-
 def get_standard_aspect_ratio(width: int, height: int) -> tuple[int, int]:
     """Ensure that only standard aspect ratios are used."""
     # it is important that all ratios have the same scale
@@ -419,16 +409,18 @@ class BirdsEyeFrameManager:
         )
 
     def camera_active(
-        self,
-        mode: BirdseyeModeConfig,
-        activity: BirdseyeActivity,
+        self, mode: Any, object_box_count: int, motion_box_count: int
     ) -> bool:
-        return (
-            mode.continuous
-            or (mode.motion and activity.has_motion)
-            or (mode.objects and activity.has_active_object)
-            or (mode.stationary_objects and activity.has_stationary_object)
-        )
+        if mode == BirdseyeModeEnum.continuous:
+            return True
+
+        if mode == BirdseyeModeEnum.motion and motion_box_count > 0:
+            return True
+
+        if mode == BirdseyeModeEnum.objects and object_box_count > 0:
+            return True
+
+        return False
 
     def get_camera_coordinates(self) -> dict[str, dict[str, int]]:
         """Return the coordinates of each camera in the current layout."""
@@ -612,92 +604,112 @@ class BirdsEyeFrameManager:
     ) -> list[list[Any]] | None:
         """Calculate the optimal layout for 2+ cameras."""
 
-        def find_available_x(
-            current_x: int,
-            width: int,
-            reserved_ranges: list[tuple[int, int]],
-            max_width: int,
-        ) -> int | None:
-            """Find the first horizontal slot that does not collide with reservations."""
-            x = current_x
-
-            for reserved_start, reserved_end in sorted(reserved_ranges):
-                if x >= reserved_end:
-                    continue
-
-                if x + width <= reserved_start:
-                    return x
-
-                x = max(x, reserved_end)
-
-            if x + width <= max_width:
-                return x
-
-            return None
-
-        def map_layout(row_height: int) -> tuple[int, int, list[list[Any]] | None]:
-            """Lay out cameras row by row while reserving portrait spans for the next row."""
-            candidate_layout: list[list[Any]] = []
-            reserved_ranges: dict[int, list[tuple[int, int]]] = {}
-            current_row: list[Any] = []
-            row_index = 0
-            row_y = 0
-            row_x = 0
+        def map_layout(
+            camera_layout: list[list[Any]], row_height: int
+        ) -> tuple[int, int, list[list[Any]] | None]:
+            """Map the calculated layout."""
+            candidate_layout = []
+            starting_x = 0
+            x = 0
             max_width = 0
-            max_height = 0
+            y = 0
 
-            for camera in cameras_to_add:
-                camera_dims = self.cameras[camera]["dimensions"].copy()
-                camera_aspect_x, camera_aspect_y = self.canvas.get_camera_aspect(
-                    camera, camera_dims[0], camera_dims[1]
+            for row in camera_layout:
+                final_row = []
+                max_width = max(max_width, x)
+                x = starting_x
+                for cameras in row:
+                    camera_dims = self.cameras[cameras[0]]["dimensions"].copy()
+                    camera_aspect = cameras[1]
+
+                    if camera_dims[1] > camera_dims[0]:
+                        scaled_height = int(row_height * 2)
+                        scaled_width = int(scaled_height * camera_aspect)
+                        starting_x = scaled_width
+                    else:
+                        scaled_height = row_height
+                        scaled_width = int(scaled_height * camera_aspect)
+
+                    # layout is too large
+                    if (
+                        x + scaled_width > self.canvas.width
+                        or y + scaled_height > self.canvas.height
+                    ):
+                        return x + scaled_width, y + scaled_height, None
+
+                    final_row.append((cameras[0], (x, y, scaled_width, scaled_height)))
+                    x += scaled_width
+
+                y += row_height
+                candidate_layout.append(final_row)
+
+            if max_width == 0:
+                max_width = x
+
+            return max_width, y, candidate_layout
+
+        canvas_aspect_x, canvas_aspect_y = self.canvas.get_aspect(coefficient)
+        camera_layout: list[list[Any]] = []
+        camera_layout.append([])
+        starting_x = 0
+        x = starting_x
+        y = 0
+        y_i = 0
+        max_y = 0
+        for camera in cameras_to_add:
+            camera_dims = self.cameras[camera]["dimensions"].copy()
+            camera_aspect_x, camera_aspect_y = self.canvas.get_camera_aspect(
+                camera, camera_dims[0], camera_dims[1]
+            )
+
+            if camera_dims[1] > camera_dims[0]:
+                portrait = True
+            else:
+                portrait = False
+
+            if (x + camera_aspect_x) <= canvas_aspect_x:
+                # insert if camera can fit on current row
+                camera_layout[y_i].append(
+                    (
+                        camera,
+                        camera_aspect_x / camera_aspect_y,
+                    )
                 )
-                portrait = camera_dims[1] > camera_dims[0]
-                scaled_height = row_height * 2 if portrait else row_height
-                scaled_width = int(scaled_height * (camera_aspect_x / camera_aspect_y))
 
-                while True:
-                    x = find_available_x(
-                        row_x,
-                        scaled_width,
-                        reserved_ranges.get(row_index, []),
-                        self.canvas.width,
+                if portrait:
+                    starting_x = camera_aspect_x
+                else:
+                    max_y = max(
+                        max_y,
+                        camera_aspect_y,
                     )
 
-                    if x is not None and row_y + scaled_height <= self.canvas.height:
-                        current_row.append(
-                            (camera, (x, row_y, scaled_width, scaled_height))
-                        )
-                        row_x = x + scaled_width
-                        max_width = max(max_width, row_x)
-                        max_height = max(max_height, row_y + scaled_height)
+                x += camera_aspect_x
+            else:
+                # move on to the next row and insert
+                y += max_y
+                y_i += 1
+                camera_layout.append([])
+                x = starting_x
 
-                        if portrait:
-                            reserved_ranges.setdefault(row_index + 1, []).append(
-                                (x, row_x)
-                            )
+                if x + camera_aspect_x > canvas_aspect_x:
+                    return None
 
-                        break
+                camera_layout[y_i].append(
+                    (
+                        camera,
+                        camera_aspect_x / camera_aspect_y,
+                    )
+                )
+                x += camera_aspect_x
 
-                    if current_row:
-                        candidate_layout.append(current_row)
-                        current_row = []
+        if y + max_y > canvas_aspect_y:
+            return None
 
-                    row_index += 1
-                    row_y = row_index * row_height
-                    row_x = 0
-
-                    if row_y + scaled_height > self.canvas.height:
-                        overflow_width = max(max_width, scaled_width)
-                        overflow_height = row_y + scaled_height
-                        return overflow_width, overflow_height, None
-
-            if current_row:
-                candidate_layout.append(current_row)
-
-            return max_width, max_height, candidate_layout
-
-        row_height = max(1, int(self.canvas.height / coefficient))
-        total_width, total_height, standard_candidate_layout = map_layout(row_height)
+        row_height = int(self.canvas.height / coefficient)
+        total_width, total_height, standard_candidate_layout = map_layout(
+            camera_layout, row_height
+        )
 
         if not standard_candidate_layout:
             # if standard layout didn't work
@@ -706,9 +718,9 @@ class BirdsEyeFrameManager:
                 total_width / self.canvas.width,
                 total_height / self.canvas.height,
             )
-            row_height = max(1, int(row_height / scale_down_percent))
+            row_height = int(row_height / scale_down_percent)
             total_width, total_height, standard_candidate_layout = map_layout(
-                row_height
+                camera_layout, row_height
             )
 
             if not standard_candidate_layout:
@@ -722,8 +734,8 @@ class BirdsEyeFrameManager:
             1 / (total_width / self.canvas.width),
             1 / (total_height / self.canvas.height),
         )
-        row_height = max(1, int(row_height * scale_up_percent))
-        _, _, scaled_layout = map_layout(row_height)
+        row_height = int(row_height * scale_up_percent)
+        _, _, scaled_layout = map_layout(camera_layout, row_height)
 
         if scaled_layout:
             return scaled_layout
@@ -733,7 +745,8 @@ class BirdsEyeFrameManager:
     def update(
         self,
         camera: str,
-        activity: BirdseyeActivity,
+        object_count: int,
+        motion_count: int,
         frame_time: float,
         frame: np.ndarray,
     ) -> tuple[bool, bool]:
@@ -747,29 +760,22 @@ class BirdsEyeFrameManager:
             return False, False
 
         force_update = False
-        camera_state = self.cameras.get(camera)
-
-        if camera_state is None:
-            return False, False
 
         # disabling birdseye is a little tricky
         if not camera_config.birdseye.enabled or not camera_config.enabled:
             # if we've rendered a frame (we have a value for last_active_frame)
             # then we need to set it to zero
-            if camera_state["last_active_frame"] > 0:
-                camera_state["last_active_frame"] = 0
+            if self.cameras[camera]["last_active_frame"] > 0:
+                self.cameras[camera]["last_active_frame"] = 0
                 force_update = True
             else:
                 return False, False
 
         # update the last active frame for the camera
-        camera_state["current_frame"] = frame.copy()
-        camera_state["current_frame_time"] = frame_time
-        if self.camera_active(
-            camera_config.birdseye.mode,
-            activity,
-        ):
-            camera_state["last_active_frame"] = frame_time
+        self.cameras[camera]["current_frame"] = frame.copy()
+        self.cameras[camera]["current_frame_time"] = frame_time
+        if self.camera_active(camera_config.birdseye.mode, object_count, motion_count):
+            self.cameras[camera]["last_active_frame"] = frame_time
 
         now = datetime.datetime.now().timestamp()
 
@@ -876,29 +882,10 @@ class Birdseye:
         frame_time: float,
         frame: np.ndarray,
     ) -> None:
-        has_active_object = False
-        has_stationary_object = False
-        for tracked_object in current_tracked_objects:
-            if tracked_object["stationary"]:
-                if not tracked_object["false_positive"]:
-                    has_stationary_object = True
-            else:
-                # Preserve the existing objects activity behavior, which includes
-                # non-stationary trackers before they are confirmed.
-                has_active_object = True
-
-            if has_active_object and has_stationary_object:
-                break
-
-        activity = BirdseyeActivity(
-            has_active_object=has_active_object,
-            has_stationary_object=has_stationary_object,
-            has_motion=bool(motion_boxes),
-        )
-
         frame_changed, frame_layout_changed = self.birdseye_manager.update(
             camera,
-            activity,
+            len([o for o in current_tracked_objects if not o["stationary"]]),
+            len(motion_boxes),
             frame_time,
             frame,
         )

frigate/output/output.py

@@ -51,12 +51,8 @@ def check_disabled_camera_update(
 
     for camera, last_update in write_times.items():
         offline_time = now - last_update
-        camera_config = config.cameras.get(camera)
 
-        if camera_config is None:
-            continue
-
-        if camera_config.enabled:
+        if config.cameras[camera].enabled:
             has_enabled_camera = True
         else:
             # flag camera as offline when it is disabled
@@ -66,8 +62,8 @@ def check_disabled_camera_update(
             # last camera update was more than 1 second ago
             # need to send empty data to birdseye because current
             # frame is now out of date
-            cam_width = camera_config.detect.width
-            cam_height = camera_config.detect.height
+            cam_width = config.cameras[camera].detect.width
+            cam_height = config.cameras[camera].detect.height
 
             if cam_width is None or cam_height is None:
                 raise ValueError(f"Camera {camera} detect dimensions not configured")
@@ -313,11 +309,10 @@ class OutputProcess(FrigateProcess):
                 regions,
             ) = data
 
-            camera_config = self.config.cameras.get(camera)
-
-            if camera_config is not None:
-                frame_manager.get(frame_name, camera_config.frame_shape_yuv)
-                frame_manager.close(frame_name)
+            frame = frame_manager.get(
+                frame_name, self.config.cameras[camera].frame_shape_yuv
+            )
+            frame_manager.close(frame_name)
 
         detection_subscriber.stop()
 

frigate/ptz/autotrack.py

@@ -799,24 +799,14 @@ class PtzAutoTracker:
             except TimeoutError:
                 continue
 
-            # both are popped when the camera is deleted, so resolve them once
-            # here and use the locals for the rest of the move; a move already
-            # in flight then finishes against valid objects
-            metrics = self.ptz_metrics.get(camera)
-            camera_config = self.config.cameras.get(camera)
-
-            if metrics is None or camera_config is None:
-                logger.debug("%s: Dropping queued move, camera was removed", camera)
-                continue
-
             async with self.move_queue_locks[camera]:
                 frame_time, pan, tilt, zoom = move_data
 
                 # if we're receiving move requests during a PTZ move, ignore them
                 if ptz_moving_at_frame_time(
                     frame_time,
-                    metrics.start_time.value,
-                    metrics.stop_time.value,
+                    self.ptz_metrics[camera].start_time.value,
+                    self.ptz_metrics[camera].stop_time.value,
                 ):
                     logger.debug(
                         f"{camera}: Move queue: PTZ moving, dequeueing move request - frame time: {frame_time}, final pan: {pan}, final tilt: {tilt}, final zoom: {zoom}"
@@ -825,7 +815,7 @@ class PtzAutoTracker:
 
                 else:
                     if (
-                        camera_config.onvif.autotracking.zooming
+                        self.config.cameras[camera].onvif.autotracking.zooming
                         == ZoomingModeEnum.relative
                     ):
                         await self.onvif._move_relative(camera, pan, tilt, zoom, 1)
@@ -834,22 +824,25 @@ class PtzAutoTracker:
                             await self.onvif._move_relative(camera, pan, tilt, 0, 1)
 
                             # Wait until the camera finishes moving
-                            while not metrics.motor_stopped.is_set():
+                            while not self.ptz_metrics[camera].motor_stopped.is_set():
                                 await self.onvif.get_camera_status(camera)
 
-                        if zoom > 0 and metrics.zoom_level.value != zoom:
+                        if (
+                            zoom > 0
+                            and self.ptz_metrics[camera].zoom_level.value != zoom
+                        ):
                             await self.onvif._zoom_absolute(camera, zoom, 1)
 
                     # Wait until the camera finishes moving
-                    while not metrics.motor_stopped.is_set():
+                    while not self.ptz_metrics[camera].motor_stopped.is_set():
                         await self.onvif.get_camera_status(camera)
 
-                    if camera_config.onvif.autotracking.movement_weights:
+                    if self.config.cameras[camera].onvif.autotracking.movement_weights:
                         logger.debug(
                             f"{camera}: Predicted movement time: {self._predict_movement_time(camera, pan, tilt)}"
                         )
                         logger.debug(
-                            f"{camera}: Actual movement time: {metrics.stop_time.value - metrics.start_time.value}"
+                            f"{camera}: Actual movement time: {self.ptz_metrics[camera].stop_time.value - self.ptz_metrics[camera].start_time.value}"
                         )
 
                     # save metrics for better estimate calculations
@@ -858,15 +851,21 @@ class PtzAutoTracker:
                         and len(self.move_metrics[camera])
                         < AUTOTRACKING_MAX_MOVE_METRICS
                         and (pan != 0 or tilt != 0)
-                        and camera_config.onvif.autotracking.calibrate_on_startup
+                        and self.config.cameras[
+                            camera
+                        ].onvif.autotracking.calibrate_on_startup
                     ):
                         logger.debug(f"{camera}: Adding new values to move metrics")
                         self.move_metrics[camera].append(
                             {
                                 "pan": pan,
                                 "tilt": tilt,
-                                "start_timestamp": metrics.start_time.value,
-                                "end_timestamp": metrics.stop_time.value,
+                                "start_timestamp": self.ptz_metrics[
+                                    camera
+                                ].start_time.value,
+                                "end_timestamp": self.ptz_metrics[
+                                    camera
+                                ].stop_time.value,
                             }
                         )
 

frigate/ptz/onvif.py

@@ -180,11 +180,6 @@ class OnvifController:
             return False
 
     async def _init_onvif(self, camera_name: str) -> bool:
-        camera_config = self.config.cameras.get(camera_name)
-
-        if camera_config is None:
-            return False
-
         onvif: ONVIFCamera = self.cams[camera_name]["onvif"]
         try:
             await onvif.update_xaddrs()
@@ -240,7 +235,7 @@ class OnvifController:
                 p.token,
             )
 
-        configured_profile = camera_config.onvif.profile
+        configured_profile = self.config.cameras[camera_name].onvif.profile
         profile = None
 
         if configured_profile is not None:
@@ -344,7 +339,7 @@ class OnvifController:
             except (AttributeError, TypeError):
                 fov_space_id = None
 
-        autotracking_config = camera_config.onvif.autotracking
+        autotracking_config = self.config.cameras[camera_name].onvif.autotracking
         autotracking_enabled = (
             autotracking_config.enabled_in_config and autotracking_config.enabled
         )
@@ -619,11 +614,6 @@ class OnvifController:
             logger.error(f"{camera_name} does not support ONVIF RelativeMove (FOV).")
             return
 
-        metrics = self.ptz_metrics.get(camera_name)
-
-        if metrics is None:
-            return
-
         logger.debug(
             f"{camera_name} called RelativeMove: pan: {pan} tilt: {tilt} zoom: {zoom}"
         )
@@ -637,11 +627,15 @@ class OnvifController:
         self.cams[camera_name]["active"] = True
 
         # only track start_time for autotracking
-        if metrics.autotracker_enabled.value:
-            metrics.motor_stopped.clear()
-            logger.debug(f"{camera_name}: PTZ start time: {metrics.frame_time.value}")
-            metrics.start_time.value = metrics.frame_time.value
-            metrics.stop_time.value = 0
+        if self.ptz_metrics[camera_name].autotracker_enabled.value:
+            self.ptz_metrics[camera_name].motor_stopped.clear()
+            logger.debug(
+                f"{camera_name}: PTZ start time: {self.ptz_metrics[camera_name].frame_time.value}"
+            )
+            self.ptz_metrics[camera_name].start_time.value = self.ptz_metrics[
+                camera_name
+            ].frame_time.value
+            self.ptz_metrics[camera_name].stop_time.value = 0
 
         move_request = self.cams[camera_name]["relative_move_request"]
 
@@ -703,14 +697,9 @@ class OnvifController:
             logger.error(f"{preset} is not a valid preset for {camera_name}")
             return
 
-        metrics = self.ptz_metrics.get(camera_name)
-
-        if metrics is None:
-            return
-
         self.cams[camera_name]["active"] = True
-        metrics.start_time.value = 0
-        metrics.stop_time.value = 0
+        self.ptz_metrics[camera_name].start_time.value = 0
+        self.ptz_metrics[camera_name].stop_time.value = 0
         move_request = self.cams[camera_name]["move_request"]
         preset_token = self.cams[camera_name]["presets"][preset]
 
@@ -749,11 +738,6 @@ class OnvifController:
             logger.error(f"{camera_name} does not support ONVIF AbsoluteMove zooming.")
             return
 
-        metrics = self.ptz_metrics.get(camera_name)
-
-        if metrics is None:
-            return
-
         logger.debug(f"{camera_name} called AbsoluteMove: zoom: {zoom}")
 
         if self.cams[camera_name]["active"]:
@@ -763,10 +747,14 @@ class OnvifController:
             return
 
         self.cams[camera_name]["active"] = True
-        metrics.motor_stopped.clear()
-        logger.debug(f"{camera_name}: PTZ start time: {metrics.frame_time.value}")
-        metrics.start_time.value = metrics.frame_time.value
-        metrics.stop_time.value = 0
+        self.ptz_metrics[camera_name].motor_stopped.clear()
+        logger.debug(
+            f"{camera_name}: PTZ start time: {self.ptz_metrics[camera_name].frame_time.value}"
+        )
+        self.ptz_metrics[camera_name].start_time.value = self.ptz_metrics[
+            camera_name
+        ].frame_time.value
+        self.ptz_metrics[camera_name].stop_time.value = 0
         move_request = self.cams[camera_name]["absolute_move_request"]
 
         # function takes in 0 to 1 for zoom, interpolate to the values of the camera.
@@ -887,18 +875,16 @@ class OnvifController:
 
         Returns camera details including features and presets if available.
         """
-        camera_config = self.config.cameras.get(camera_name)
-
-        if camera_config is None:
-            return {}
-
-        if not camera_config.enabled:
+        if not self.config.cameras[camera_name].enabled:
             logger.debug(
                 f"Camera {camera_name} disabled, won't try to initialize ONVIF"
             )
             return {}
 
-        if camera_name not in self.cams.keys() and (not camera_config.onvif.host):
+        if camera_name not in self.cams.keys() and (
+            camera_name not in self.config.cameras
+            or not self.config.cameras[camera_name].onvif.host
+        ):
             logger.debug(f"ONVIF is not configured for {camera_name}")
             return {}
 
@@ -999,12 +985,6 @@ class OnvifController:
                 logger.error(f"ONVIF is not configured for {camera_name}")
                 return
 
-            metrics = self.ptz_metrics.get(camera_name)
-            camera_config = self.config.cameras.get(camera_name)
-
-            if metrics is None or camera_config is None:
-                return
-
             if not self.cams[camera_name]["init"]:
                 if not await self._init_onvif(camera_name):
                     return
@@ -1043,29 +1023,36 @@ class OnvifController:
                 zoom_status is None or zoom_status == "IDLE"
             ):
                 self.cams[camera_name]["active"] = False
-                if not metrics.motor_stopped.is_set():
-                    metrics.motor_stopped.set()
+                if not self.ptz_metrics[camera_name].motor_stopped.is_set():
+                    self.ptz_metrics[camera_name].motor_stopped.set()
 
                     logger.debug(
-                        f"{camera_name}: PTZ stop time: {metrics.frame_time.value}"
+                        f"{camera_name}: PTZ stop time: {self.ptz_metrics[camera_name].frame_time.value}"
                     )
 
-                    metrics.stop_time.value = metrics.frame_time.value
+                    self.ptz_metrics[camera_name].stop_time.value = self.ptz_metrics[
+                        camera_name
+                    ].frame_time.value
             else:
                 self.cams[camera_name]["active"] = True
-                if metrics.motor_stopped.is_set():
-                    metrics.motor_stopped.clear()
+                if self.ptz_metrics[camera_name].motor_stopped.is_set():
+                    self.ptz_metrics[camera_name].motor_stopped.clear()
 
                     logger.debug(
-                        f"{camera_name}: PTZ start time: {metrics.frame_time.value}"
+                        f"{camera_name}: PTZ start time: {self.ptz_metrics[camera_name].frame_time.value}"
                     )
 
-                    metrics.start_time.value = metrics.frame_time.value
-                    metrics.stop_time.value = 0
+                    self.ptz_metrics[camera_name].start_time.value = self.ptz_metrics[
+                        camera_name
+                    ].frame_time.value
+                    self.ptz_metrics[camera_name].stop_time.value = 0
 
-            if camera_config.onvif.autotracking.zooming != ZoomingModeEnum.disabled:
+            if (
+                self.config.cameras[camera_name].onvif.autotracking.zooming
+                != ZoomingModeEnum.disabled
+            ):
                 # store absolute zoom level as 0 to 1 interpolated from the values of the camera
-                metrics.zoom_level.value = numpy.interp(
+                self.ptz_metrics[camera_name].zoom_level.value = numpy.interp(
                     round(status.Position.Zoom.x, 2),
                     [
                         self.cams[camera_name]["absolute_zoom_range"]["XRange"]["Min"],
@@ -1074,22 +1061,25 @@ class OnvifController:
                     [0, 1],
                 )
                 logger.debug(
-                    f"{camera_name}: Camera zoom level: {metrics.zoom_level.value}"
+                    f"{camera_name}: Camera zoom level: {self.ptz_metrics[camera_name].zoom_level.value}"
                 )
 
             # some hikvision cams won't update MoveStatus, so warn if it hasn't changed
             if (
-                not metrics.motor_stopped.is_set()
-                and not metrics.reset.is_set()
-                and metrics.start_time.value != 0
-                and metrics.frame_time.value > (metrics.start_time.value + 10)
-                and metrics.stop_time.value == 0
+                not self.ptz_metrics[camera_name].motor_stopped.is_set()
+                and not self.ptz_metrics[camera_name].reset.is_set()
+                and self.ptz_metrics[camera_name].start_time.value != 0
+                and self.ptz_metrics[camera_name].frame_time.value
+                > (self.ptz_metrics[camera_name].start_time.value + 10)
+                and self.ptz_metrics[camera_name].stop_time.value == 0
             ):
                 logger.debug(
-                    f"Start time: {metrics.start_time.value}, Stop time: {metrics.stop_time.value}, Frame time: {metrics.frame_time.value}"
+                    f"Start time: {self.ptz_metrics[camera_name].start_time.value}, Stop time: {self.ptz_metrics[camera_name].stop_time.value}, Frame time: {self.ptz_metrics[camera_name].frame_time.value}"
                 )
                 # set the stop time so we don't come back into this again and spam the logs
-                metrics.stop_time.value = metrics.frame_time.value
+                self.ptz_metrics[camera_name].stop_time.value = self.ptz_metrics[
+                    camera_name
+                ].frame_time.value
                 logger.warning(
                     f"Camera {camera_name} is still in ONVIF 'MOVING' status."
                 )

frigate/record/export.py

@@ -36,8 +36,9 @@ from frigate.util.time import is_current_hour
 logger = logging.getLogger(__name__)
 
 
+DEFAULT_TIME_LAPSE_FFMPEG_INPUT_ARGS = "-an"
 DEFAULT_TIME_LAPSE_FFMPEG_ARGS = "-vf setpts=0.04*PTS -r 30"
-TIMELAPSE_DATA_INPUT_ARGS = "-an -skip_frame nokey"
+TIMELAPSE_DATA_INPUT_ARGS = "-skip_frame nokey"
 
 # Matches the setpts factor used in timelapse exports (e.g. setpts=0.04*PTS).
 # Captures the floating-point factor so we can scale expected duration.
@@ -737,7 +738,7 @@ class RecordingExporter(threading.Thread):
                 parse_preset_hardware_acceleration_encode(
                     self.config.ffmpeg.ffmpeg_path,
                     hwaccel_args,
-                    f"{self.ffmpeg_input_args} -an {ffmpeg_input}".strip(),
+                    f"{self.ffmpeg_input_args} {ffmpeg_input}".strip(),
                     f"{self.ffmpeg_output_args} -movflags +faststart".strip(),
                     EncodeTypeEnum.timelapse,
                 )

frigate/record/maintainer.py

@@ -388,6 +388,22 @@ class RecordingMaintainer(threading.Thread):
                 RecordingsDataTypeEnum.valid.value,
             )
 
+        # assume that empty means the relevant recording info has not been received yet
+        camera_info = self.object_recordings_info[camera]
+        most_recently_processed_frame_time = (
+            camera_info[-1][0] if len(camera_info) > 0 else 0
+        )
+
+        # ensure delayed segment info does not lead to lost segments, every
+        # retention decision below depends on complete stats for the segment
+        if (
+            datetime.datetime.fromtimestamp(
+                most_recently_processed_frame_time
+            ).astimezone(datetime.UTC)
+            < end_time
+        ):
+            return None
+
         record_config = self.config.cameras[camera].record
         segment_stats: SegmentInfo | None = None
         highest = None
@@ -401,37 +417,22 @@ class RecordingMaintainer(threading.Thread):
         # we should first just check if this segment matches that
         # and avoid any DB calls
         if highest is not None:
-            # assume that empty means the relevant recording info has not been received yet
-            camera_info = self.object_recordings_info[camera]
-            most_recently_processed_frame_time = (
-                camera_info[-1][0] if len(camera_info) > 0 else 0
+            record_mode = (
+                RetainModeEnum.all if highest == "continuous" else RetainModeEnum.motion
             )
+            segment_stats = self.segment_stats(camera, start_time, end_time)
 
-            # ensure delayed segment info does not lead to lost segments
-            if (
-                datetime.datetime.fromtimestamp(
-                    most_recently_processed_frame_time
-                ).astimezone(datetime.UTC)
-                >= end_time
-            ):
-                record_mode = (
-                    RetainModeEnum.all
-                    if highest == "continuous"
-                    else RetainModeEnum.motion
+            # Here we only check if we should move the segment based on non-object recording retention
+            # we will always want to check for overlapping review items below before dropping the segment
+            if not segment_stats.should_discard_segment(record_mode):
+                return await self.move_segment(
+                    camera,
+                    start_time,
+                    end_time,
+                    duration,
+                    cache_path,
+                    segment_stats,
                 )
-                segment_stats = self.segment_stats(camera, start_time, end_time)
-
-                # Here we only check if we should move the segment based on non-object recording retention
-                # we will always want to check for overlapping review items below before dropping the segment
-                if not segment_stats.should_discard_segment(record_mode):
-                    return await self.move_segment(
-                        camera,
-                        start_time,
-                        end_time,
-                        duration,
-                        cache_path,
-                        segment_stats,
-                    )
 
         # we fell through the continuous / motion check, so we need to check the review items
         # if the cached segment overlaps with the review items:
@@ -487,10 +488,6 @@ class RecordingMaintainer(threading.Thread):
         # continuous/motion retention (either disabled or segment_stats said
         # discard), so waiting longer just fills the cache.
         else:
-            camera_info = self.object_recordings_info[camera]
-            most_recently_processed_frame_time = (
-                camera_info[-1][0] if len(camera_info) > 0 else 0
-            )
             retain_cutoff = datetime.datetime.fromtimestamp(
                 most_recently_processed_frame_time - record_config.event_pre_capture
             ).astimezone(datetime.UTC)
@@ -745,9 +742,7 @@ class RecordingMaintainer(threading.Thread):
                         regions,
                     ) = data
 
-                    camera_config = self.config.cameras.get(camera)
-
-                    if camera_config is not None and camera_config.record.enabled:
+                    if self.config.cameras[camera].record.enabled:
                         self.object_recordings_info[camera].append(
                             (
                                 frame_time,
@@ -764,9 +759,7 @@ class RecordingMaintainer(threading.Thread):
                         audio_detections,
                     ) = data
 
-                    camera_config = self.config.cameras.get(camera)
-
-                    if camera_config is not None and camera_config.record.enabled:
+                    if self.config.cameras[camera].record.enabled:
                         self.audio_recordings_info[camera].append(
                             (
                                 frame_time,

frigate/review/maintainer.py

@@ -418,11 +418,6 @@ class ReviewSegmentMaintainer(threading.Thread):
 
         return None
 
-    def _handle_camera_removed(self, camera: str) -> None:
-        """Close out a deleted camera's segment so a reused name cannot inherit it."""
-        self.forcibly_end_segment(camera)
-        self.indefinite_events.pop(camera, None)
-
     def update_existing_segment(
         self,
         segment: PendingReviewSegment,
@@ -671,10 +666,6 @@ class ReviewSegmentMaintainer(threading.Thread):
                 for camera in updated_topics["enabled"]:
                     self.forcibly_end_segment(camera)
 
-            if "remove" in updated_topics:
-                for camera in updated_topics["remove"]:
-                    self._handle_camera_removed(camera)
-
             result = self.detection_subscriber.check_for_update(timeout=1)
 
             if not result:

frigate/stats/util.py

@@ -352,8 +352,9 @@ def stats_snapshot(
     total_camera_fps = total_process_fps = total_skipped_fps = total_detection_fps = 0
 
     stats["cameras"] = {}
-    for name, camera_stats in camera_metrics.items():
-        if name not in config.cameras:
+    for name, camera_stats in list(camera_metrics.items()):
+        camera_config = config.cameras.get(name)
+        if camera_config is None:
             continue
 
         total_camera_fps += camera_stats.camera_fps.value
@@ -370,7 +371,7 @@ def stats_snapshot(
         # Calculate connection quality based on current state
         # This is computed at stats-collection time so offline cameras
         # correctly show as unusable rather than excellent
-        expected_fps = config.cameras[name].detect.fps
+        expected_fps = camera_config.detect.fps
         current_fps = camera_stats.camera_fps.value
         reconnects = camera_stats.reconnects_last_hour.value
         stalls = camera_stats.stalls_last_hour.value
@@ -398,7 +399,7 @@ def stats_snapshot(
             "process_fps": round(camera_stats.process_fps.value, 2),
             "skipped_fps": round(camera_stats.skipped_fps.value, 2),
             "detection_fps": round(camera_stats.detection_fps.value, 2),
-            "detection_enabled": config.cameras[name].detect.enabled,
+            "detection_enabled": camera_config.detect.enabled,
             "pid": pid,
             "capture_pid": capture_pid,
             "ffmpeg_pid": ffmpeg_pid,

frigate/test/http_api/base_http_test.py

@@ -144,7 +144,9 @@ class BaseTestHttp(unittest.TestCase):
         except OSError:
             pass
 
-    def create_app(self, stats=None, event_metadata_publisher=None):
+    def create_app(
+        self, stats=None, event_metadata_publisher=None, enforce_default_admin=False
+    ):
         from frigate.api.auth import get_allowed_cameras_for_filter, get_current_user
 
         app = create_fastapi_app(
@@ -158,7 +160,7 @@ class BaseTestHttp(unittest.TestCase):
             event_metadata_publisher,
             None,
             DebugReplayManager(),
-            enforce_default_admin=False,
+            enforce_default_admin=enforce_default_admin,
         )
 
         # Default test mocks for authentication

frigate/test/http_api/test_debug_replay_api.py

@@ -2,6 +2,7 @@
 
 from unittest.mock import patch
 
+from frigate.jobs.debug_replay import NoRecordingsError
 from frigate.models import Event, Recordings, ReviewSegment
 from frigate.test.http_api.base_http_test import AuthTestClient, BaseTestHttp
 
@@ -66,6 +67,32 @@ class TestDebugReplayAPI(BaseTestHttp):
         # (CodeQL: information exposure through an exception).
         self.assertEqual(body["message"], "Invalid debug replay parameters")
 
+    def test_start_returns_404_when_no_recordings(self):
+        with patch(
+            "frigate.api.debug_replay.start_debug_replay_job",
+            side_effect=NoRecordingsError(
+                "No recordings found for camera 'front' in the specified time range"
+            ),
+        ):
+            with AuthTestClient(self.app) as client:
+                resp = client.post(
+                    "/debug_replay/start",
+                    json={
+                        "camera": "front",
+                        "start_time": 100,
+                        "end_time": 200,
+                    },
+                )
+
+        self.assertEqual(resp.status_code, 404)
+        body = resp.json()
+        self.assertFalse(body["success"])
+        # Message is hard-coded so we don't echo exception text back to clients
+        # (CodeQL: information exposure through an exception).
+        self.assertEqual(
+            body["message"], "No recordings found in the selected time range"
+        )
+
     def test_start_returns_409_when_session_already_active(self):
         with patch(
             "frigate.api.debug_replay.start_debug_replay_job",

frigate/test/http_api/test_http_app.py

@@ -47,6 +47,25 @@ class TestHttpApp(BaseTestHttp):
             assert response.status_code == 200
             assert response.json()["front_door"]["usage_percent"] == 25.0
 
+    def test_camera_name_collision_keeps_admin_default(self):
+        self.minimal_config["cameras"]["faces"] = self.minimal_config["cameras"].pop(
+            "front_door"
+        )
+        app = super().create_app(enforce_default_admin=True)
+        viewer = {"remote-user": "viewer", "remote-role": "viewer"}
+
+        with AuthTestClient(app) as client:
+            assert client.get("/faces", headers=viewer).status_code == 403
+            assert client.get("/faces").status_code == 200
+            assert (
+                client.post("/faces/train/person/classify", headers=viewer).status_code
+                == 403
+            )
+
+            # Camera routes for the same name stay reachable by viewers
+            response = client.get("/faces/recordings/summary", headers=viewer)
+            assert response.status_code == 200
+
     def test_config_set_in_memory_replaces_objects_track_list(self):
         self.minimal_config["cameras"]["front_door"]["objects"] = {
             "track": ["person", "car"],

frigate/test/http_api/test_http_camera_access.py

@@ -440,3 +440,68 @@ class TestGo2rtcStreamAccess(BaseTestHttp):
             f"limited_user should be denied on alias back_door_main; "
             f"got {resp.status_code}"
         )
+
+
+class TestReviewSummaryAccess(BaseTestHttp):
+    """Tests for POST /review/summarize/start/{start_ts}/end/{end_ts}.
+
+    The summary correlates each flagged event with overlapping activity on
+    other cameras, so it is gated on full camera access rather than scoped to
+    the caller's cameras. These tests pin that decision so the dependency is
+    not loosened without first scoping the query.
+
+    GenAI is not configured in unit tests, so an authorized request returns 400
+    while an unauthorized one is rejected with 403 before the handler runs.
+    """
+
+    def setUp(self):
+        super().setUp([Event, ReviewSegment, Recordings])
+        self.minimal_config = _MULTI_CAMERA_CONFIG
+        self.app = super().create_app()
+
+    def tearDown(self):
+        self.app.dependency_overrides.clear()
+        super().tearDown()
+
+    def _summarize(self, allowed_cameras: list[str]):
+        async def mock_cameras(request: Request):
+            return allowed_cameras
+
+        self.app.dependency_overrides[get_allowed_cameras_for_filter] = mock_cameras
+        with AuthTestClient(self.app) as client:
+            return client.post("/review/summarize/start/0/end/9999999999")
+
+    def _assert_allowed(self, resp):
+        assert resp.status_code not in (401, 403), (
+            f"Caller should not be blocked; got {resp.status_code}"
+        )
+
+    def test_partial_camera_access_blocked(self):
+        assert self._summarize(["front_door"]).status_code == 403
+
+    def test_no_camera_access_blocked(self):
+        assert self._summarize([]).status_code == 403
+
+    def test_full_camera_access_allowed(self):
+        # Covers admin and viewer, which always resolve to every camera, and a
+        # custom role whose list happens to name them all.
+        self._assert_allowed(self._summarize(["front_door", "back_door"]))
+
+    def _summarize_as_role(self, role: str):
+        """Summarize using the real role to allowed-cameras resolution."""
+        self.app.dependency_overrides.pop(get_allowed_cameras_for_filter, None)
+        with AuthTestClient(self.app) as client:
+            return client.post(
+                "/review/summarize/start/0/end/9999999999",
+                headers={"remote-user": "test", "remote-role": role},
+            )
+
+    def test_viewer_role_allowed(self):
+        # viewer is never camera restricted, so it resolves to every camera.
+        self._assert_allowed(self._summarize_as_role("viewer"))
+
+    def test_admin_role_allowed(self):
+        self._assert_allowed(self._summarize_as_role("admin"))
+
+    def test_restricted_role_blocked(self):
+        assert self._summarize_as_role("limited_user").status_code == 403

frigate/test/http_api/test_http_config_set.py

@@ -386,19 +386,9 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
         guess (mode still equals the previous global) wrongly claims a camera
         whose explicit yaml mode happens to match.
         """
-        self.minimal_config["birdseye"] = {
-            "enabled": True,
-            "mode": {"motion": True},
-        }
+        self.minimal_config["birdseye"] = {"enabled": True, "mode": "motion"}
         # explicit override that matches the global value being replaced
-        self.minimal_config["cameras"]["front_door"]["birdseye"] = {
-            "mode": {
-                "continuous": False,
-                "motion": True,
-                "objects": False,
-                "stationary_objects": False,
-            }
-        }
+        self.minimal_config["cameras"]["front_door"]["birdseye"] = {"mode": "motion"}
 
         config_path = self._write_config_file()
         mock_find_config.return_value = config_path
@@ -409,16 +399,7 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
                 resp = client.put(
                     "/config/set",
                     json={
-                        "config_data": {
-                            "birdseye": {
-                                "mode": {
-                                    "continuous": True,
-                                    "motion": False,
-                                    "objects": False,
-                                    "stationary_objects": False,
-                                }
-                            }
-                        },
+                        "config_data": {"birdseye": {"mode": "continuous"}},
                         "update_topic": "config/birdseye",
                         "requires_restart": 0,
                     },
@@ -430,7 +411,7 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
                 mock_publisher.publisher.publish.assert_called_once()
                 topic, settings = mock_publisher.publisher.publish.call_args[0]
                 self.assertEqual(topic, "config/birdseye")
-                self.assertEqual(settings.mode.to_mqtt_payload(), "CONTINUOUS")
+                self.assertEqual(settings.mode.value, "continuous")
 
                 published = {
                     call[0][0].camera: call[0][1]
@@ -444,12 +425,8 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
                     )
 
                 # the override survives, the inheriting camera follows global
-                self.assertEqual(
-                    published["front_door"].mode.to_mqtt_payload(), "MOTION"
-                )
-                self.assertEqual(
-                    published["back_yard"].mode.to_mqtt_payload(), "CONTINUOUS"
-                )
+                self.assertEqual(published["front_door"].mode.value, "motion")
+                self.assertEqual(published["back_yard"].mode.value, "continuous")
         finally:
             os.unlink(config_path)
 

frigate/test/http_api/test_http_event.py

@@ -168,6 +168,29 @@ class TestHttpApp(BaseTestHttp):
             assert events[0]["id"] == id
             assert events[1]["id"] == id2
 
+    def test_get_event_list_offset_pages_score_sort(self):
+        now = datetime.now().timestamp()
+        scores = [0.6, 0.9, 0.7, 0.95, 0.8]
+
+        with AuthTestClient(self.app) as client:
+            for i, score in enumerate(scores):
+                super().insert_mock_event(
+                    f"event-{i}", start_time=now + i, data={"score": score}
+                )
+
+            params = {"sort": "score_desc"}
+            full = [e["id"] for e in client.get("/events", params=params).json()]
+            paged = [
+                e["id"]
+                for offset in (0, 2, 4)
+                for e in client.get(
+                    "/events", params={**params, "limit": 2, "offset": offset}
+                ).json()
+            ]
+
+            assert full == ["event-3", "event-1", "event-4", "event-2", "event-0"]
+            assert paged == full
+
     def test_get_event_list_match_multilingual_attribute(self):
         event_id = "123456.zh"
         attribute = "中文标签"
@@ -219,6 +242,85 @@ class TestHttpApp(BaseTestHttp):
             assert len(events) == 1
             assert events[0]["id"] == event_id
 
+    def test_events_search_offset_pages_score_sort(self):
+        now = datetime.now().timestamp()
+        scores = [0.6, 0.9, 0.7, 0.95, 0.8]
+        ids = [f"event-{i}" for i in range(len(scores))]
+        mock_embeddings = Mock()
+        mock_embeddings.search_thumbnail.return_value = [
+            (event_id, 0.1 * i) for i, event_id in enumerate(ids)
+        ]
+
+        self.app.frigate_config.semantic_search.enabled = True
+        self.app.embeddings = mock_embeddings
+
+        with AuthTestClient(self.app) as client:
+            for i, score in enumerate(scores):
+                super().insert_mock_event(
+                    ids[i], start_time=now + i, data={"score": score}
+                )
+
+            params = {
+                "search_type": "similarity",
+                "event_id": ids[0],
+                "sort": "score_desc",
+            }
+            paged = [
+                e["id"]
+                for offset in (0, 2, 4)
+                for e in client.get(
+                    "/events/search",
+                    params={**params, "limit": 2, "offset": offset},
+                ).json()
+            ]
+
+            assert paged == ["event-3", "event-1", "event-4", "event-2", "event-0"]
+
+    def test_events_search_offset_pages_orders_ties_by_id(self):
+        now = datetime.now().timestamp()
+        ids = ["event-c", "event-a", "event-b"]
+        mock_embeddings = Mock()
+        mock_embeddings.search_thumbnail.return_value = [
+            (event_id, 0.1) for event_id in ids
+        ]
+
+        self.app.frigate_config.semantic_search.enabled = True
+        self.app.embeddings = mock_embeddings
+
+        with AuthTestClient(self.app) as client:
+            for i, event_id in enumerate(ids):
+                super().insert_mock_event(
+                    event_id, start_time=now + i, data={"score": 0.8}
+                )
+
+            for sort in ("score_desc", "relevance"):
+                params = {
+                    "search_type": "similarity",
+                    "event_id": ids[0],
+                    "sort": sort,
+                }
+                paged = [
+                    e["id"]
+                    for offset in (0, 1, 2)
+                    for e in client.get(
+                        "/events/search",
+                        params={**params, "limit": 1, "offset": offset},
+                    ).json()
+                ]
+
+                assert paged == ["event-a", "event-b", "event-c"]
+
+    def test_event_list_rejects_negative_offset(self):
+        with AuthTestClient(self.app) as client:
+            response = client.get("/events", params={"offset": -5})
+            assert response.status_code == 422
+
+            response = client.get(
+                "/events/search",
+                params={"query": "car", "offset": -5},
+            )
+            assert response.status_code == 422
+
     def test_similarity_search_hides_unauthorized_anchor_event(self):
         mock_embeddings = Mock()
         self.app.frigate_config.semantic_search.enabled = True

frigate/test/http_api/test_http_export.py

@@ -1,5 +1,7 @@
+import io
 import os
 import tempfile
+import zipfile
 from unittest.mock import patch
 
 from frigate.jobs.export import (
@@ -1431,3 +1433,79 @@ class TestHttpExport(BaseTestHttp):
             )
 
         assert response.status_code == 403
+
+    def test_download_export_case_with_multibyte_name(self):
+        """A case name outside latin-1 must not break the response headers."""
+        case = ExportCase.create(
+            id="case_multibyte",
+            name="テスト事案",
+            description="",
+            created_at=10,
+            updated_at=10,
+        )
+
+        with tempfile.TemporaryDirectory() as tmpdir:
+            video_path = os.path.join(tmpdir, "multibyte_export.mp4")
+            with open(video_path, "wb") as handle:
+                handle.write(b"video")
+
+            Export.create(
+                id="export_multibyte",
+                camera="front_door",
+                name="現場カメラ",
+                date=100,
+                video_path=video_path,
+                thumb_path=os.path.join(tmpdir, "multibyte_export.webp"),
+                in_progress=False,
+                export_case=case,
+            )
+
+            with AuthTestClient(self.app) as client:
+                response = client.get(f"/cases/{case.id}/download")
+
+        assert response.status_code == 200
+        # RFC 5987/6266: the UTF-8 name rides in filename*, and a latin-1 safe
+        # fallback stays in filename for old clients.
+        assert response.headers["content-disposition"] == (
+            'attachment; filename="case_multibyte.zip"; '
+            "filename*=UTF-8''%E3%83%86%E3%82%B9%E3%83%88%E4%BA%8B%E6%A1%88.zip"
+        )
+
+        archive = zipfile.ZipFile(io.BytesIO(response.content))
+        assert archive.namelist() == ["現場カメラ.mp4"]
+
+    def test_download_export_case_with_ascii_name(self):
+        """An ASCII case name still gets a plain, readable filename."""
+        case = ExportCase.create(
+            id="case_ascii",
+            name="Burglary 2026-08",
+            description="",
+            created_at=10,
+            updated_at=10,
+        )
+
+        with tempfile.TemporaryDirectory() as tmpdir:
+            video_path = os.path.join(tmpdir, "ascii_export.mp4")
+            with open(video_path, "wb") as handle:
+                handle.write(b"video")
+
+            Export.create(
+                id="export_ascii",
+                camera="front_door",
+                name="Front door",
+                date=100,
+                video_path=video_path,
+                thumb_path=os.path.join(tmpdir, "ascii_export.webp"),
+                in_progress=False,
+                export_case=case,
+            )
+
+            with AuthTestClient(self.app) as client:
+                response = client.get(f"/cases/{case.id}/download")
+
+        assert response.status_code == 200
+        assert (
+            response.headers["content-disposition"]
+            == 'attachment; filename="Burglary 2026-08.zip"; '
+            "filename*=UTF-8''Burglary%202026-08.zip"
+        )

frigate/test/http_api/test_http_media.py

@@ -1,6 +1,7 @@
 """Unit tests for recordings/media API endpoints."""
 
-from dataclasses import dataclass
+import threading
+from concurrent.futures import ThreadPoolExecutor
 from datetime import UTC, datetime
 from unittest.mock import patch
 
@@ -8,66 +9,10 @@ import pytz
 from fastapi import Request
 
 from frigate.api.auth import get_allowed_cameras_for_filter, get_current_user
-from frigate.const import MAX_SEGMENT_DURATION
 from frigate.models import Recordings
 from frigate.test.http_api.base_http_test import AuthTestClient, BaseTestHttp
 
 
-@dataclass(frozen=True)
-class RangeCase:
-    """Expected behavior for one segment relative to the requested range.
-
-    Offsets are seconds from REQUEST_START; the request ends at +100 seconds.
-    """
-
-    name: str
-    start_offset: float
-    end_offset: float
-    included_in_recordings: bool
-    vod_clip_from_ms: int | None = None
-    vod_duration_ms: int | None = None
-
-
-REQUEST_START = 1000
-REQUEST_END = 1100
-RANGE_CASES = (
-    RangeCase("before", -MAX_SEGMENT_DURATION + 1, -1, False),
-    RangeCase("meets_start", -10, 0, True),
-    RangeCase(
-        "overlaps_start",
-        -MAX_SEGMENT_DURATION + 0.5,
-        0.25,
-        True,
-        vod_clip_from_ms=599500,
-        vod_duration_ms=250,
-    ),
-    RangeCase("starts_at_start", 0, 10, True, vod_duration_ms=10000),
-    RangeCase("inside", 20, 80, True, vod_duration_ms=60000),
-    RangeCase("ends_at_end", 90, 100, True, vod_duration_ms=10000),
-    RangeCase("matches_range", 0, 100, True, vod_duration_ms=100000),
-    RangeCase("starts_with_range", 0, 110, True, vod_duration_ms=100000),
-    RangeCase(
-        "covers_range",
-        -20,
-        120,
-        True,
-        vod_clip_from_ms=20000,
-        vod_duration_ms=100000,
-    ),
-    RangeCase(
-        "ends_with_range",
-        -10,
-        100,
-        True,
-        vod_clip_from_ms=10000,
-        vod_duration_ms=100000,
-    ),
-    RangeCase("overlaps_end", 95, 105, True, vod_duration_ms=5000),
-    RangeCase("starts_at_end", 100, 110, True),
-    RangeCase("after", 101, 110, False),
-)
-
-
 class TestHttpMedia(BaseTestHttp):
     """Test media API endpoints, particularly recordings with DST handling."""
 
@@ -102,26 +47,6 @@ class TestHttpMedia(BaseTestHttp):
         self.app.dependency_overrides.clear()
         super().tearDown()
 
-    def _assert_vod_response(
-        self,
-        response,
-        expected_clips: list[tuple[str, int | None, int]],
-    ) -> None:
-        """Assert VOD clip metadata and its derived duration fields."""
-        assert response.status_code == 200
-        vod = response.json()
-        assert [
-            (
-                clip["path"],
-                clip.get("clipFrom"),
-                clip["keyFrameDurations"][0],
-            )
-            for clip in vod["sequences"][0]["clips"]
-        ] == expected_clips
-        expected_durations = [clip[2] for clip in expected_clips]
-        assert vod["durations"] == expected_durations
-        assert vod["segment_duration"] == max(expected_durations)
-
     def test_recordings_summary_across_dst_spring_forward(self):
         """
         Test recordings summary across spring DST transition (spring forward).
@@ -482,102 +407,6 @@ class TestHttpMedia(BaseTestHttp):
             assert "2024-03-10" in summary
             assert summary["2024-03-10"] is True
 
-    def test_recordings_handles_all_range_relations(self):
-        """Recordings return every interval relation that touches the range."""
-        with AuthTestClient(self.app) as client:
-            for case in RANGE_CASES:
-                with self.subTest(case=case.name):
-                    Recordings.delete().execute()
-                    super().insert_mock_recording(
-                        case.name,
-                        REQUEST_START + case.start_offset,
-                        REQUEST_START + case.end_offset,
-                    )
-
-                    response = client.get(
-                        "/front_door/recordings",
-                        params={"after": REQUEST_START, "before": REQUEST_END},
-                    )
-
-                    assert response.status_code == 200
-                    expected_ids = [case.name] if case.included_in_recordings else []
-                    assert [
-                        recording["id"] for recording in response.json()
-                    ] == expected_ids
-
-    def test_vod_handles_all_range_relations(self):
-        """VOD clips every interval relation with positive playback duration."""
-        with (
-            AuthTestClient(self.app) as client,
-            patch(
-                "frigate.api.media.get_keyframe_before",
-                side_effect=lambda _path, offset: offset,
-            ),
-        ):
-            for case in RANGE_CASES:
-                with self.subTest(case=case.name):
-                    Recordings.delete().execute()
-                    super().insert_mock_recording(
-                        case.name,
-                        REQUEST_START + case.start_offset,
-                        REQUEST_START + case.end_offset,
-                    )
-
-                    response = client.get(
-                        f"/vod/front_door/start/{REQUEST_START}/end/{REQUEST_END}"
-                    )
-
-                    if case.vod_duration_ms is None:
-                        assert response.status_code == 404
-                        continue
-
-                    self._assert_vod_response(
-                        response,
-                        [
-                            (
-                                case.name,
-                                case.vod_clip_from_ms,
-                                case.vod_duration_ms,
-                            )
-                        ],
-                    )
-
-    def test_vod_handles_segment_ending_at_start_with_keyframe_fallbacks(self):
-        """VOD keeps a boundary segment when keyframe lookup extends it."""
-
-        def keyframe_before(path: str, offset: int) -> int | None:
-            return offset - 1000 if path == "previous_keyframe" else None
-
-        with (
-            AuthTestClient(self.app) as client,
-            patch(
-                "frigate.api.media.get_keyframe_before",
-                side_effect=keyframe_before,
-            ),
-        ):
-            super().insert_mock_recording(
-                "previous_keyframe",
-                REQUEST_START - 10,
-                REQUEST_START,
-            )
-            super().insert_mock_recording(
-                "missing_keyframe",
-                REQUEST_START - 5,
-                REQUEST_START,
-            )
-
-            response = client.get(
-                f"/vod/front_door/start/{REQUEST_START}/end/{REQUEST_END}"
-            )
-
-            self._assert_vod_response(
-                response,
-                [
-                    ("previous_keyframe", 9000, 1000),
-                    ("missing_keyframe", None, 5000),
-                ],
-            )
-
     def test_recordings_unavailable_reports_gap_between_recordings(self):
         """A gap between two recordings is reported as an unavailable segment."""
         with AuthTestClient(self.app) as client:
@@ -701,3 +530,90 @@ class TestHttpMedia(BaseTestHttp):
 
             assert response.status_code == 200
             assert response.json() == [{"start_time": 1010, "end_time": 1030}]
+
+    def _insert_recording(self, id: str, start_time: float, end_time: float) -> None:
+        Recordings.insert(
+            id=id,
+            path=f"/media/recordings/{id}.mp4",
+            camera="front_door",
+            start_time=start_time,
+            end_time=end_time,
+            duration=end_time - start_time,
+            motion=0,
+        ).execute()
+
+    def test_recording_snapshot_does_not_block_event_loop(self):
+        self._insert_recording("snapshot", 1000, 1010)
+        started = threading.Event()
+        release = threading.Event()
+        finished = threading.Event()
+
+        def slow_image(*args):
+            started.set()
+            release.wait(timeout=5)
+            finished.set()
+            return b"jpeg"
+
+        with (
+            AuthTestClient(self.app) as client,
+            patch("frigate.api.media.get_image_from_recording", slow_image),
+            ThreadPoolExecutor(max_workers=1) as executor,
+        ):
+            snapshot = executor.submit(
+                client.get, "/front_door/recordings/1005/snapshot.jpg"
+            )
+            self.assertTrue(started.wait(timeout=2))
+            version = client.get("/version")
+            blocked = finished.is_set()
+            release.set()
+
+            self.assertEqual(version.status_code, 200)
+            self.assertFalse(blocked)
+            self.assertEqual(snapshot.result().status_code, 200)
+
+    def test_recording_snapshot_hit_returns_image(self):
+        self._insert_recording("snapshot", 1000, 1010)
+
+        with (
+            AuthTestClient(self.app) as client,
+            patch("frigate.api.media.get_image_from_recording", return_value=b"jpeg"),
+        ):
+            response = client.get("/front_door/recordings/1005/snapshot.jpg")
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.headers["Content-Type"], "image/jpeg")
+        self.assertEqual(response.content, b"jpeg")
+
+    def test_recording_snapshot_misses_return_404(self):
+        self._insert_recording("snapshot", 1000, 1010)
+
+        with AuthTestClient(self.app) as client:
+            absent = client.get("/front_door/recordings/2000/snapshot.jpg")
+            rounded_miss = client.get("/front_door/recordings/1010.5/snapshot.jpg")
+
+        self.assertEqual(absent.status_code, 404)
+        self.assertEqual(rounded_miss.status_code, 404)
+
+    def test_plus_snapshot_miss_returns_404_without_image_lookup(self):
+        with (
+            AuthTestClient(self.app) as client,
+            patch("frigate.api.media.get_image_from_recording") as image,
+        ):
+            response = client.post("/front_door/plus/1005")
+
+        self.assertEqual(response.status_code, 404)
+        image.assert_not_called()
+
+    def test_plus_snapshot_hit_uploads_image(self):
+        self._insert_recording("snapshot", 1000, 1010)
+
+        with (
+            AuthTestClient(self.app) as client,
+            patch("frigate.api.media.get_image_from_recording", return_value=b"png"),
+            patch("frigate.api.media.cv2.imdecode", return_value="frame"),
+            patch.object(self.app.frigate_config.plus_api, "upload_image") as upload,
+        ):
+            response = client.post("/front_door/plus/1005")
+
+        self.assertEqual(response.status_code, 200)
+        upload.assert_called_once_with("frame", "front_door")

frigate/test/http_api/test_http_password.py

@@ -0,0 +1,113 @@
+"""Tests for password change authorization."""
+
+from fastapi import Request
+
+from frigate.api.auth import get_current_user, hash_password, verify_password
+from frigate.models import Event, Recordings, ReviewSegment, User
+from frigate.test.http_api.base_http_test import AuthTestClient, BaseTestHttp
+
+# Config carrying a custom role, which is the class of user the literal
+# "viewer" check used to let through.
+_CUSTOM_ROLE_CONFIG = {
+    "mqtt": {"host": "mqtt"},
+    "auth": {"roles": {"neighbor": ["front_door"]}, "hash_iterations": 10},
+    "cameras": {
+        "front_door": {
+            "ffmpeg": {
+                "inputs": [{"path": "rtsp://10.0.0.1:554/video", "roles": ["detect"]}]
+            },
+            "detect": {"height": 1080, "width": 1920, "fps": 5},
+        },
+    },
+}
+
+ADMIN_PASSWORD = "admin-real-password"
+NEW_PASSWORD = "AttackerChosenPassword123!"
+
+
+class TestUpdatePasswordAccess(BaseTestHttp):
+    def setUp(self):
+        super().setUp([Event, ReviewSegment, Recordings, User])
+        self.minimal_config = _CUSTOM_ROLE_CONFIG
+        self.app = super().create_app()
+        User.insert(
+            username="admin",
+            password_hash=hash_password(ADMIN_PASSWORD, iterations=10),
+            role="admin",
+            notification_tokens=[],
+        ).execute()
+
+        async def mock_get_current_user(request: Request):
+            return {
+                "username": request.headers.get("remote-user"),
+                "role": request.headers.get("remote-role"),
+            }
+
+        self.app.dependency_overrides[get_current_user] = mock_get_current_user
+
+    def tearDown(self):
+        self.app.dependency_overrides.clear()
+        super().tearDown()
+
+    def _change_password(self, actor: str, role: str, target: str, old_password: str):
+        with AuthTestClient(self.app) as client:
+            return client.put(
+                f"/users/{target}/password",
+                json={"password": NEW_PASSWORD, "old_password": old_password},
+                headers={"remote-user": actor, "remote-role": role},
+            )
+
+    def _admin_password_unchanged(self) -> bool:
+        return verify_password(ADMIN_PASSWORD, User.get_by_id("admin").password_hash)
+
+    def test_custom_role_cannot_target_another_account(self):
+        resp = self._change_password("neighbor", "neighbor", "admin", "wrong-guess")
+        assert resp.status_code == 403
+        assert self._admin_password_unchanged()
+
+    def test_custom_role_cannot_target_another_account_with_correct_password(self):
+        # The 403 must land before old_password is checked, so knowing the
+        # target's password is not a way through
+        resp = self._change_password("neighbor", "neighbor", "admin", ADMIN_PASSWORD)
+        assert resp.status_code == 403
+        assert self._admin_password_unchanged()
+
+    def test_viewer_cannot_target_another_account(self):
+        resp = self._change_password("viewer_user", "viewer", "admin", ADMIN_PASSWORD)
+        assert resp.status_code == 403
+        assert self._admin_password_unchanged()
+
+    def test_admin_can_target_another_account(self):
+        User.insert(
+            username="neighbor",
+            password_hash=hash_password("neighbor-password", iterations=10),
+            role="neighbor",
+            notification_tokens=[],
+        ).execute()
+
+        resp = self._change_password("admin", "admin", "neighbor", "")
+        assert resp.status_code == 200
+
+    def test_non_admin_can_change_own_password(self):
+        User.insert(
+            username="neighbor",
+            password_hash=hash_password("neighbor-password", iterations=10),
+            role="neighbor",
+            notification_tokens=[],
+        ).execute()
+
+        resp = self._change_password(
+            "neighbor", "neighbor", "neighbor", "neighbor-password"
+        )
+        assert resp.status_code == 200
+
+    def test_non_admin_own_password_still_requires_old_password(self):
+        User.insert(
+            username="neighbor",
+            password_hash=hash_password("neighbor-password", iterations=10),
+            role="neighbor",
+            notification_tokens=[],
+        ).execute()
+
+        resp = self._change_password("neighbor", "neighbor", "neighbor", "wrong-guess")
+        assert resp.status_code == 401

frigate/test/http_api/test_http_review.py

@@ -240,9 +240,101 @@ class TestHttpReview(BaseTestHttp):
             assert len(response_json) == 1
             assert response_json[0]["id"] == id_reviewed
 
+    def test_get_review_with_label_filter_matches_verified(self):
+        """Test that a label filter also matches the `-verified` variant."""
+        now = datetime.now().timestamp()
+
+        with AuthTestClient(self.app) as client:
+            super().insert_mock_review_segment(
+                "123456.person", now, now + 2, data={"objects": ["person"]}
+            )
+            super().insert_mock_review_segment(
+                "123456.verified", now, now + 2, data={"objects": ["person-verified"]}
+            )
+            super().insert_mock_review_segment(
+                "123456.car", now, now + 2, data={"objects": ["car"]}
+            )
+
+            params = {
+                "labels": "person",
+                "after": now - 1,
+                "before": now + 3,
+            }
+            response = client.get("/review", params=params)
+            assert response.status_code == 200
+            response_json = response.json()
+            assert {r["id"] for r in response_json} == {
+                "123456.person",
+                "123456.verified",
+            }
+
+    def test_get_review_with_label_filter_does_not_match_prefix(self):
+        """Test that a label filter does not match labels that only share a prefix."""
+        now = datetime.now().timestamp()
+
+        with AuthTestClient(self.app) as client:
+            super().insert_mock_review_segment(
+                "123456.carrot", now, now + 2, data={"objects": ["carrot"]}
+            )
+
+            params = {
+                "labels": "car",
+                "after": now - 1,
+                "before": now + 3,
+            }
+            response = client.get("/review", params=params)
+            assert response.status_code == 200
+            assert len(response.json()) == 0
+
+    def test_get_review_with_audio_label_filter(self):
+        """Test that a label filter still matches audio labels."""
+        now = datetime.now().timestamp()
+
+        with AuthTestClient(self.app) as client:
+            super().insert_mock_review_segment(
+                "123456.audio", now, now + 2, data={"audio": ["speech"]}
+            )
+
+            params = {
+                "labels": "speech",
+                "after": now - 1,
+                "before": now + 3,
+            }
+            response = client.get("/review", params=params)
+            assert response.status_code == 200
+            response_json = response.json()
+            assert len(response_json) == 1
+            assert response_json[0]["id"] == "123456.audio"
+
     ####################################################################################################################
     ###################################  GET /review/summary Endpoint   #################################################
     ####################################################################################################################
+    def test_get_review_summary_label_filter_matches_verified(self):
+        """Test that the summary label filter also matches the `-verified` variant."""
+        with AuthTestClient(self.app) as client:
+            super().insert_mock_review_segment(
+                "123456.verified", data={"objects": ["person-verified"]}
+            )
+            super().insert_mock_review_segment(
+                "123456.car", data={"objects": ["car"]}, severity=SeverityEnum.detection
+            )
+
+            params = {
+                "cameras": "front_door",
+                "labels": "person",
+                "zones": "all",
+                "timezone": "utc",
+            }
+            response = client.get("/review/summary", params=params)
+            assert response.status_code == 200
+            response_json = response.json()
+            assert response_json["last24Hours"]["total_alert"] == 1
+            assert response_json["last24Hours"]["total_detection"] == 0
+
+            today_formatted = datetime.today().strftime("%Y-%m-%d")
+            assert response_json[today_formatted]["total_alert"] == 1
+            assert response_json[today_formatted]["total_detection"] == 0
+
     def test_get_review_summary_all_filters(self):
         with AuthTestClient(self.app) as client:
             super().insert_mock_review_segment("123456.random")

frigate/test/test_birdseye.py

@@ -1,70 +1,13 @@
-"""Tests for Birdseye canvas sizing and layout behavior."""
+"""Test camera user and password cleanup."""
 
 import multiprocessing as mp
 import unittest
-from unittest.mock import Mock
 
-from frigate.config import BirdseyeModeConfig, FrigateConfig
-from frigate.output.birdseye import (
-    Birdseye,
-    BirdseyeActivity,
-    BirdsEyeFrameManager,
-    get_canvas_shape,
-)
+from frigate.config import FrigateConfig
+from frigate.output.birdseye import BirdsEyeFrameManager, get_canvas_shape
 
 
 class TestBirdseye(unittest.TestCase):
-    def _build_manager(
-        self, camera_dimensions: dict[str, tuple[int, int]]
-    ) -> BirdsEyeFrameManager:
-        config = {
-            "mqtt": {"host": "mqtt"},
-            "birdseye": {"width": 1280, "height": 720},
-            "cameras": {},
-        }
-
-        for order, (camera, dimensions) in enumerate(
-            camera_dimensions.items(), start=1
-        ):
-            config["cameras"][camera] = {
-                "ffmpeg": {
-                    "inputs": [
-                        {
-                            "path": f"rtsp://10.0.0.1:554/{camera}",
-                            "roles": ["detect"],
-                        }
-                    ]
-                },
-                "detect": {
-                    "width": dimensions[0],
-                    "height": dimensions[1],
-                    "fps": 5,
-                },
-                "birdseye": {"order": order},
-            }
-
-        return BirdsEyeFrameManager(FrigateConfig(**config), mp.Event())
-
-    def _assert_no_overlaps(
-        self, layout: list[list[tuple[str, tuple[int, int, int, int]]]]
-    ):
-        rectangles = [position for row in layout for _, position in row]
-
-        for index, rect in enumerate(rectangles):
-            x1, y1, width1, height1 = rect
-            for other in rectangles[index + 1 :]:
-                x2, y2, width2, height2 = other
-                overlap = (
-                    x1 < x2 + width2
-                    and x2 < x1 + width1
-                    and y1 < y2 + height2
-                    and y2 < y1 + height1
-                )
-                self.assertFalse(
-                    overlap,
-                    msg=f"Overlapping rectangles found: {rect} and {other}",
-                )
-
     def test_16x9(self):
         """Test 16x9 aspect ratio works as expected for birdseye."""
         width = 1280
@@ -105,212 +48,6 @@ class TestBirdseye(unittest.TestCase):
         assert canvas_width == width  # width will be the same
         assert canvas_height != height
 
-    def test_portrait_camera_does_not_overlap_next_row(self):
-        """Portrait cameras should reserve their real horizontal position on the next row."""
-        manager = self._build_manager(
-            {
-                "cam_a": (1280, 720),
-                "cam_p": (360, 640),
-                "cam_b": (1280, 720),
-                "cam_c": (640, 480),
-            }
-        )
-
-        layout = manager.calculate_layout(["cam_a", "cam_p", "cam_b", "cam_c"], 3)
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-        cam_c = [
-            position for row in layout for camera, position in row if camera == "cam_c"
-        ][0]
-        self.assertEqual(cam_c[0], 0)
-
-    def test_portrait_reservation_only_applies_to_next_row(self):
-        """Portrait reservations should not push later rows after the span ends."""
-        manager = self._build_manager(
-            {
-                "cam_a": (1280, 720),
-                "cam_p": (360, 640),
-                "cam_b": (1280, 720),
-                "cam_c": (1280, 720),
-                "cam_d": (1280, 720),
-                "cam_e": (1280, 720),
-            }
-        )
-
-        layout = manager.calculate_layout(
-            ["cam_a", "cam_p", "cam_b", "cam_c", "cam_d", "cam_e"],
-            3,
-        )
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-        cam_e = [
-            position for row in layout for camera, position in row if camera == "cam_e"
-        ][0]
-        self.assertEqual(cam_e[0], 0)
-
-    def test_multiple_portraits_reserve_distinct_ranges(self):
-        """Multiple portrait cameras in one row should reserve separate spans below them."""
-        manager = self._build_manager(
-            {
-                "cam_a": (640, 480),
-                "cam_p1": (360, 640),
-                "cam_p2": (360, 640),
-                "cam_b": (640, 480),
-                "cam_c": (1280, 720),
-                "cam_d": (640, 480),
-            }
-        )
-
-        layout = manager.calculate_layout(
-            ["cam_a", "cam_p1", "cam_p2", "cam_b", "cam_c", "cam_d"],
-            4,
-        )
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-    def test_two_landscapes_then_portrait_then_two_landscapes(self):
-        """A portrait after two landscapes should reserve only its own tail span."""
-        manager = self._build_manager(
-            {
-                "cam_a": (1280, 720),
-                "cam_b": (1280, 720),
-                "cam_p": (360, 640),
-                "cam_c": (1280, 720),
-                "cam_d": (1280, 720),
-            }
-        )
-
-        layout = manager.calculate_layout(
-            ["cam_a", "cam_b", "cam_p", "cam_c", "cam_d"],
-            3,
-        )
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-        cam_c = [
-            position for row in layout for camera, position in row if camera == "cam_c"
-        ][0]
-        cam_d = [
-            position for row in layout for camera, position in row if camera == "cam_d"
-        ][0]
-        self.assertEqual(cam_c[0], 0)
-        self.assertEqual(cam_d[0], cam_c[0] + cam_c[2])
-
-
-class TestBirdseyeActivity(unittest.TestCase):
-    """Test which camera activity is included in each Birdseye mode."""
-
-    def setUp(self):
-        config = {
-            "mqtt": {"enabled": False},
-            "birdseye": {
-                "enabled": True,
-                "mode": {
-                    "motion": True,
-                    "objects": True,
-                    "stationary_objects": True,
-                },
-            },
-            "cameras": {
-                "front": {
-                    "ffmpeg": {
-                        "inputs": [
-                            {"path": "rtsp://10.0.0.1:554/video", "roles": ["detect"]}
-                        ]
-                    },
-                    "detect": {"height": 1080, "width": 1920, "fps": 5},
-                }
-            },
-        }
-        self.manager = BirdsEyeFrameManager(FrigateConfig(**config), mp.Event())
-
-    def test_existing_modes_keep_their_activity_rules(self):
-        continuous = BirdseyeModeConfig(continuous=True)
-        motion = BirdseyeModeConfig(motion=True)
-        objects = BirdseyeModeConfig(objects=True)
-
-        no_activity = BirdseyeActivity(False, False, False)
-        motion_activity = BirdseyeActivity(False, False, True)
-        stationary_activity = BirdseyeActivity(False, True, False)
-        active_object_activity = BirdseyeActivity(True, False, False)
-
-        assert self.manager.camera_active(continuous, no_activity)
-        assert self.manager.camera_active(motion, motion_activity)
-        assert not self.manager.camera_active(motion, stationary_activity)
-        assert self.manager.camera_active(objects, active_object_activity)
-        assert not self.manager.camera_active(objects, stationary_activity)
-
-    def test_modes_can_be_combined(self):
-        mode = BirdseyeModeConfig(motion=True, stationary_objects=True)
-
-        assert self.manager.camera_active(mode, BirdseyeActivity(False, False, True))
-        assert self.manager.camera_active(mode, BirdseyeActivity(False, True, False))
-        assert not self.manager.camera_active(
-            mode, BirdseyeActivity(False, False, False)
-        )
-
-    def test_stationary_objects_are_independent_from_active_objects(self):
-        stationary_objects = BirdseyeModeConfig(stationary_objects=True)
-
-        assert self.manager.camera_active(
-            stationary_objects, BirdseyeActivity(False, True, False)
-        )
-        assert not self.manager.camera_active(
-            stationary_objects, BirdseyeActivity(True, False, False)
-        )
-
-    def test_write_data_preserves_active_and_confirms_stationary_activity(self):
-        birdseye = Birdseye.__new__(Birdseye)
-        birdseye.birdseye_manager = Mock()
-        birdseye.birdseye_manager.update.return_value = (False, False)
-        birdseye._idle_interval = None
-        frame = Mock()
-
-        birdseye.write_data(
-            "front",
-            [
-                {"stationary": True, "false_positive": True},
-                {"stationary": False, "false_positive": True},
-                {"stationary": True, "false_positive": False},
-            ],
-            [[0, 0, 10, 10]],
-            1.0,
-            frame,
-        )
-
-        birdseye.birdseye_manager.update.assert_called_once_with(
-            "front", BirdseyeActivity(True, True, True), 1.0, frame
-        )
-
-    def test_stationary_false_positive_does_not_activate_birdseye(self):
-        birdseye = Birdseye.__new__(Birdseye)
-        birdseye.birdseye_manager = Mock()
-        birdseye.birdseye_manager.update.return_value = (False, False)
-        birdseye._idle_interval = None
-        frame = Mock()
-
-        birdseye.write_data(
-            "front",
-            [{"stationary": True, "false_positive": True}],
-            [],
-            1.0,
-            frame,
-        )
-
-        birdseye.birdseye_manager.update.assert_called_once_with(
-            "front", BirdseyeActivity(False, False, False), 1.0, frame
-        )
-
 
 class TestBirdseyeCameraOrder(unittest.TestCase):
     """Test that birdseye reacts to camera order changes without a restart."""
@@ -318,7 +55,7 @@ class TestBirdseyeCameraOrder(unittest.TestCase):
     def setUp(self):
         config = {
             "mqtt": {"enabled": False},
-            "birdseye": {"enabled": True, "mode": {"continuous": True}},
+            "birdseye": {"enabled": True, "mode": "continuous"},
             "cameras": {
                 camera: {
                     "ffmpeg": {

frigate/test/test_camera_lifecycle.py

@@ -1,227 +0,0 @@
-"""Regression tests for runtime camera add and delete handling."""
-
-import asyncio
-import threading
-import unittest
-from types import SimpleNamespace
-from unittest.mock import MagicMock
-
-# LicensePlatePostProcessor is imported via the maintainer rather than from
-# data_processing.post.license_plate, which circularly imports back through
-# frigate.embeddings before that package finishes initializing
-from frigate.embeddings.maintainer import (
-    EmbeddingMaintainer,
-    LicensePlatePostProcessor,
-)
-from frigate.ptz.autotrack import PtzAutoTracker
-from frigate.review.maintainer import ReviewSegmentMaintainer
-from frigate.track.object_processing import TrackedObjectProcessor
-
-
-def _make_processor() -> TrackedObjectProcessor:
-    """Build a processor with no cameras, bypassing __init__."""
-    processor = TrackedObjectProcessor.__new__(TrackedObjectProcessor)
-    processor.camera_states = {}
-    processor.camera_states_lock = threading.Lock()
-    processor.config = SimpleNamespace(cameras={})
-    processor.event_sender = MagicMock()
-    processor.detection_publisher = MagicMock()
-    processor.ongoing_manual_events = {}
-    return processor
-
-
-class TestObjectProcessorUnknownCamera(unittest.TestCase):
-    def test_save_lpr_snapshot_ignores_unknown_camera(self):
-        processor = _make_processor()
-
-        # 1x1 png, base64; decoding must not be what fails
-        payload = (
-            "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mP8z8BQDwAEhQGAhKmMIQAAAABJRU5ErkJggg==",
-            "1234.5-abcdef",
-            "deleted_cam",
-        )
-
-        processor.save_lpr_snapshot(payload)
-
-        processor.event_sender.publish.assert_not_called()
-
-    def test_create_manual_event_ignores_unknown_camera(self):
-        processor = _make_processor()
-
-        payload = (
-            1234.5,
-            "deleted_cam",
-            "person",
-            "1234.5-abcdef",
-            True,
-            0.9,
-            None,
-            None,
-            "api",
-            False,
-            None,
-        )
-
-        processor.create_manual_event(payload)
-
-        processor.event_sender.publish.assert_not_called()
-        self.assertEqual(processor.ongoing_manual_events, {})
-
-    def test_create_lpr_event_ignores_unknown_camera(self):
-        processor = _make_processor()
-
-        payload = (
-            1234.5,
-            "deleted_cam",
-            "license_plate",
-            "1234.5-abcdef",
-            True,
-            0.9,
-            None,
-            "ABC123",
-        )
-
-        processor.create_lpr_event(payload)
-
-        processor.event_sender.publish.assert_not_called()
-        self.assertEqual(processor.ongoing_manual_events, {})
-
-    def test_create_manual_event_ignores_camera_added_but_not_yet_drained(self):
-        """The add window: present in config.cameras, absent from camera_states.
-
-        debug_replay writes the camera into the shared config before publishing
-        add, so a guard on config.cameras passes here and falls through to
-        camera_states. This test fails against such a guard.
-        """
-        processor = _make_processor()
-        processor.config = SimpleNamespace(
-            cameras={
-                "new_cam": SimpleNamespace(
-                    record=SimpleNamespace(event_pre_capture=5, enabled=True)
-                )
-            }
-        )
-
-        payload = (
-            1234.5,
-            "new_cam",
-            "person",
-            "1234.5-abcdef",
-            True,
-            0.9,
-            None,
-            None,
-            "api",
-            False,
-            None,
-        )
-
-        processor.create_manual_event(payload)
-
-        processor.event_sender.publish.assert_not_called()
-
-
-class TestEmbeddingsUnknownCamera(unittest.TestCase):
-    def _make_maintainer(self) -> EmbeddingMaintainer:
-        maintainer = EmbeddingMaintainer.__new__(EmbeddingMaintainer)
-        maintainer.config = SimpleNamespace(cameras={})
-        maintainer.event_end_subscriber = MagicMock()
-        maintainer.realtime_processors = [MagicMock()]
-        # spec is required: the dispatch loop is a chain of isinstance checks,
-        # and a bare MagicMock matches none of them, so the crashing branch
-        # would never run and the test would pass against unfixed code
-        maintainer.post_processors = [MagicMock(spec=LicensePlatePostProcessor)]
-        maintainer.detected_license_plates = {"1234.5-abcdef": {"obj_data": {}}}
-        maintainer.recordings_available_through = {"deleted_cam": 1234.5}
-        maintainer.event_metadata_publisher = MagicMock()
-        return maintainer
-
-    def test_process_finalized_skips_unknown_camera(self):
-        maintainer = self._make_maintainer()
-        # updated_db=False bypasses the Event.get branch, which would hit the
-        # database and mask the KeyError this test is about
-        maintainer.event_end_subscriber.check_for_update.side_effect = [
-            ("1234.5-abcdef", "deleted_cam", False),
-            None,
-        ]
-
-        maintainer._process_finalized()
-
-        maintainer.post_processors[0].process_data.assert_not_called()
-
-    def test_process_finalized_still_expires_realtime_state(self):
-        """The guard must not skip per-event cleanup, only post processing."""
-        maintainer = self._make_maintainer()
-        maintainer.event_end_subscriber.check_for_update.side_effect = [
-            ("1234.5-abcdef", "deleted_cam", False),
-            None,
-        ]
-
-        maintainer._process_finalized()
-
-        maintainer.realtime_processors[0].expire_object.assert_called_once_with(
-            "1234.5-abcdef", "deleted_cam"
-        )
-
-    def test_expire_dedicated_lpr_drops_entry_for_unknown_camera(self):
-        maintainer = self._make_maintainer()
-        maintainer.detected_license_plates = {
-            "1234.5-abcdef": {"camera": "deleted_cam", "last_seen": 1.0}
-        }
-
-        maintainer._expire_dedicated_lpr()
-
-        self.assertEqual(maintainer.detected_license_plates, {})
-
-
-class TestReviewMaintainerRemoval(unittest.TestCase):
-    def test_camera_removal_ends_segment_and_clears_state(self):
-        maintainer = ReviewSegmentMaintainer.__new__(ReviewSegmentMaintainer)
-        maintainer.active_review_segments = {"deleted_cam": MagicMock()}
-        maintainer.indefinite_events = {"deleted_cam": {"1234.5-abcdef": 1.0}}
-        maintainer.forcibly_end_segment = MagicMock()
-
-        maintainer._handle_camera_removed("deleted_cam")
-
-        maintainer.forcibly_end_segment.assert_called_once_with("deleted_cam")
-        self.assertNotIn("deleted_cam", maintainer.indefinite_events)
-
-
-class TestAutotrackerMoveQueue(unittest.TestCase):
-    def test_move_queue_drops_move_for_removed_camera(self):
-        tracker = PtzAutoTracker.__new__(PtzAutoTracker)
-        tracker.stop_event = MagicMock()
-        # one pass through the loop, then stop
-        tracker.stop_event.is_set.side_effect = [False, True]
-        tracker.ptz_metrics = {}
-        tracker.move_queues = {"deleted_cam": asyncio.Queue()}
-        tracker.move_queue_locks = {"deleted_cam": asyncio.Lock()}
-        tracker.onvif = MagicMock()
-        tracker.config = SimpleNamespace(cameras={})
-        tracker.move_queues["deleted_cam"].put_nowait((1234.5, 0.1, 0.1, 0.0))
-
-        asyncio.run(tracker._process_move_queue("deleted_cam"))
-
-        tracker.onvif._move_relative.assert_not_called()
-
-
-class TestCameraStateAccessors(unittest.TestCase):
-    def test_get_camera_state_returns_none_for_unknown_camera(self):
-        processor = _make_processor()
-
-        self.assertIsNone(processor.get_camera_state("deleted_cam"))
-
-    def test_get_camera_states_returns_a_snapshot_not_a_view(self):
-        """A live values() view raises RuntimeError if the writer pops mid-iteration."""
-        processor = _make_processor()
-        processor.camera_states = {"one": MagicMock(), "two": MagicMock()}
-
-        states = processor.get_camera_states()
-        processor.camera_states.pop("one")
-
-        self.assertEqual(len(states), 2)
-
-    def test_get_current_frame_time_is_zero_for_unknown_camera(self):
-        processor = _make_processor()
-
-        self.assertEqual(processor.get_current_frame_time("deleted_cam"), 0.0)

frigate/test/test_config.py

@@ -7,7 +7,7 @@ import numpy as np
 from pydantic import ValidationError
 from ruamel.yaml.constructor import DuplicateKeyError
 
-from frigate.config import FrigateConfig
+from frigate.config import BirdseyeModeEnum, FrigateConfig
 from frigate.const import MODEL_CACHE_DIR
 from frigate.detectors import DetectorTypeEnum
 from frigate.util.builtin import deep_merge
@@ -170,7 +170,7 @@ class TestConfig(unittest.TestCase):
     def test_override_birdseye(self):
         config = {
             "mqtt": {"host": "mqtt"},
-            "birdseye": {"enabled": True, "mode": {"continuous": True}},
+            "birdseye": {"enabled": True, "mode": "continuous"},
             "cameras": {
                 "back": {
                     "ffmpeg": {
@@ -183,30 +183,19 @@ class TestConfig(unittest.TestCase):
                         "width": 1920,
                         "fps": 5,
                     },
-                    "birdseye": {
-                        "enabled": False,
-                        "mode": {"continuous": False, "motion": True},
-                    },
+                    "birdseye": {"enabled": False, "mode": "motion"},
                 }
             },
         }
 
         frigate_config = FrigateConfig(**config)
         assert not frigate_config.cameras["back"].birdseye.enabled
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert mode.motion
-        assert not mode.continuous
-        assert not mode.objects
-        assert not mode.stationary_objects
+        assert frigate_config.cameras["back"].birdseye.mode is BirdseyeModeEnum.motion
 
     def test_override_birdseye_non_inheritable(self):
         config = {
             "mqtt": {"host": "mqtt"},
-            "birdseye": {
-                "enabled": True,
-                "mode": {"continuous": True},
-                "height": 1920,
-            },
+            "birdseye": {"enabled": True, "mode": "continuous", "height": 1920},
             "cameras": {
                 "back": {
                     "ffmpeg": {
@@ -229,7 +218,7 @@ class TestConfig(unittest.TestCase):
     def test_inherit_birdseye(self):
         config = {
             "mqtt": {"host": "mqtt"},
-            "birdseye": {"enabled": True, "mode": {"continuous": True}},
+            "birdseye": {"enabled": True, "mode": "continuous"},
             "cameras": {
                 "back": {
                     "ffmpeg": {
@@ -248,89 +237,9 @@ class TestConfig(unittest.TestCase):
 
         frigate_config = FrigateConfig(**config)
         assert frigate_config.cameras["back"].birdseye.enabled
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert mode.continuous
-        assert not mode.motion
-        assert not mode.objects
-        assert not mode.stationary_objects
-
-    def test_combine_birdseye_activity_types(self):
-        config = {
-            **self.minimal,
-            "birdseye": {
-                "mode": {
-                    "motion": True,
-                    "stationary_objects": True,
-                }
-            },
-        }
-
-        frigate_config = FrigateConfig(**config)
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert mode.motion
-        assert mode.stationary_objects
-        assert not mode.continuous
-        assert not mode.objects
-
-    def test_birdseye_requires_an_activity_type(self):
-        config = {
-            **self.minimal,
-            "birdseye": {
-                "mode": {
-                    "continuous": False,
-                    "motion": False,
-                    "objects": False,
-                    "stationary_objects": False,
-                }
-            },
-        }
-
-        with self.assertRaisesRegex(
-            ValidationError, "must enable at least one Birdseye activity type"
-        ):
-            FrigateConfig(**config)
-
-    def test_camera_can_disable_an_inherited_activity_type(self):
-        config = {
-            **self.minimal,
-            "birdseye": {"mode": {"motion": True, "objects": True}},
-        }
-        config["cameras"]["back"]["birdseye"] = {"mode": {"motion": False}}
-
-        frigate_config = FrigateConfig(**config)
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert not mode.motion
-        assert mode.objects
-
-    def test_profile_must_leave_an_activity_type_enabled(self):
-        config = {
-            **self.minimal,
-            "profiles": {"away": {"friendly_name": "Away"}},
-            "birdseye": {"mode": {"objects": True}},
-        }
-        config["cameras"]["back"]["profiles"] = {
-            "away": {"birdseye": {"mode": {"objects": False}}}
-        }
-
-        with self.assertRaisesRegex(
-            ValidationError, "must enable at least one Birdseye activity type"
-        ):
-            FrigateConfig(**config)
-
-    def test_camera_birdseye_activity_types_override_global_values(self):
-        config = {
-            **self.minimal,
-            "birdseye": {"mode": {"motion": True, "objects": True}},
-        }
-        config["cameras"]["back"]["birdseye"] = {
-            "mode": {"motion": False, "stationary_objects": True}
-        }
-
-        frigate_config = FrigateConfig(**config)
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert not mode.motion
-        assert mode.objects
-        assert mode.stationary_objects
+        assert (
+            frigate_config.cameras["back"].birdseye.mode is BirdseyeModeEnum.continuous
+        )
 
     def test_override_tracked_objects(self):
         config = {

frigate/test/test_debug_replay_job.py

@@ -9,6 +9,7 @@ from unittest.mock import MagicMock, patch
 from frigate.debug_replay import DebugReplayManager
 from frigate.jobs.debug_replay import (
     DebugReplayJob,
+    NoRecordingsError,
     RecordingDebugReplaySource,
     cancel_debug_replay_job,
     get_active_runner,
@@ -129,7 +130,7 @@ class TestStartDebugReplayJob(unittest.TestCase):
         empty_qs = MagicMock()
         empty_qs.count.return_value = 0
         with patch("frigate.jobs.debug_replay.query_recordings", return_value=empty_qs):
-            with self.assertRaises(ValueError):
+            with self.assertRaises(NoRecordingsError):
                 start_debug_replay_job(
                     source=RecordingDebugReplaySource(
                         source_camera="front",

frigate/test/test_detection_runners.py

@@ -0,0 +1,88 @@
+"""Tests for ONNX Runtime session option selection."""
+
+import unittest
+from unittest.mock import MagicMock, patch
+
+import numpy as np
+import onnxruntime as ort
+
+from frigate.detectors.detection_runners import (
+    CudaGraphRunner,
+    get_ort_session_options,
+)
+from frigate.detectors.detector_config import ModelTypeEnum
+from frigate.embeddings.types import EnrichmentModelTypeEnum
+
+
+class TestGetOrtSessionOptions(unittest.TestCase):
+    def test_jina_v2_uses_extended(self):
+        """jina-clip-v2 returns an identical vector for every image on the CUDA
+        execution provider at anything below EXTENDED."""
+        options = get_ort_session_options(EnrichmentModelTypeEnum.jina_v2.value)
+
+        self.assertIsNotNone(options)
+        self.assertEqual(
+            options.graph_optimization_level,
+            ort.GraphOptimizationLevel.ORT_ENABLE_EXTENDED,
+        )
+
+    def test_jina_v1_uses_basic(self):
+        options = get_ort_session_options(EnrichmentModelTypeEnum.jina_v1.value)
+
+        self.assertIsNotNone(options)
+        self.assertEqual(
+            options.graph_optimization_level,
+            ort.GraphOptimizationLevel.ORT_ENABLE_BASIC,
+        )
+
+    def test_other_models_use_defaults(self):
+        for model_type in [
+            None,
+            EnrichmentModelTypeEnum.paddleocr.value,
+            EnrichmentModelTypeEnum.arcface.value,
+            ModelTypeEnum.rfdetr.value,
+        ]:
+            with self.subTest(model_type=model_type):
+                self.assertIsNone(get_ort_session_options(model_type))
+
+
+class TestCudaGraphRunner(unittest.TestCase):
+    """CUDA graph capture fails if the arena has to allocate during capture, so
+    the session is warmed up with capture disabled before the first real run."""
+
+    def setUp(self):
+        self.session = MagicMock()
+        self.session.get_outputs.return_value = [MagicMock(name="output")]
+        self.io_binding = self.session.io_binding.return_value
+        self.input = {"images": np.zeros((1, 3, 320, 320), np.float32)}
+
+    def _annotations(self) -> list[str | None]:
+        """Graph annotation id passed with each run, None when unset."""
+        annotations = []
+
+        for call in self.session.run_with_iobinding.call_args_list:
+            try:
+                annotations.append(call.args[1].get_run_config_entry("gpu_graph_id"))
+            except RuntimeError:
+                annotations.append(None)
+
+        return annotations
+
+    def test_first_run_warms_up_with_capture_disabled(self):
+        with patch.object(ort.OrtValue, "ortvalue_from_numpy"):
+            CudaGraphRunner(self.session, 0).run(self.input)
+
+        self.assertEqual(
+            self._annotations(),
+            ["-1"] * CudaGraphRunner.GRAPH_FREE_WARMUP_RUNS + [None],
+        )
+
+    def test_later_runs_allow_capture(self):
+        with patch.object(ort.OrtValue, "ortvalue_from_numpy"):
+            runner = CudaGraphRunner(self.session, 0)
+            runner.run(self.input)
+            self.session.run_with_iobinding.reset_mock()
+            runner.run(self.input)
+
+        self.assertEqual(self._annotations(), [None])
+        runner._input_ortvalue.update_inplace.assert_called_once()

frigate/test/test_dispatcher_runtime_state.py

@@ -8,7 +8,6 @@ from unittest.mock import MagicMock, patch
 from frigate.app import FrigateApp
 from frigate.comms.dispatcher import Dispatcher
 from frigate.comms.runtime_state import RuntimeStatePersistence
-from frigate.config import BirdseyeModeConfig
 
 
 def _make_camera_mock(
@@ -52,58 +51,6 @@ def _build_dispatcher(cameras: dict[str, MagicMock]) -> Dispatcher:
         return Dispatcher(config, config_updater, onvif, ptz_metrics, communicators)
 
 
-class TestBirdseyeModeCommands(unittest.TestCase):
-    """Verify Birdseye mode commands use the boolean mode contract."""
-
-    def setUp(self) -> None:
-        self.camera = _make_camera_mock()
-        self.camera.birdseye.enabled = True
-        self.dispatcher = _build_dispatcher({"front_door": self.camera})
-        self.dispatcher.publish = MagicMock()
-
-    def test_combined_modes_are_accepted(self) -> None:
-        self.dispatcher._on_birdseye_mode_command(
-            "front_door", "STATIONARY_OBJECTS,MOTION"
-        )
-
-        self.assertEqual(
-            self.camera.birdseye.mode,
-            BirdseyeModeConfig(motion=True, stationary_objects=True),
-        )
-        self.dispatcher.config_updater.publish_update.assert_called_once()
-        self.dispatcher.publish.assert_called_once_with(
-            "front_door/birdseye_mode/state",
-            "MOTION,STATIONARY_OBJECTS",
-            retain=True,
-        )
-
-    def test_single_activity_type_is_accepted(self) -> None:
-        self.dispatcher._on_birdseye_mode_command("front_door", "OBJECTS")
-
-        self.assertEqual(
-            self.camera.birdseye.mode,
-            BirdseyeModeConfig(objects=True),
-        )
-        self.dispatcher.publish.assert_called_once_with(
-            "front_door/birdseye_mode/state", "OBJECTS", retain=True
-        )
-
-    def test_unknown_mode_is_rejected(self) -> None:
-        for payload in (
-            "UNKNOWN",
-            "motion",
-            "MOTION_OBJECTS",
-            "NONE",
-            "NONE,MOTION",
-            "MOTION,MOTION",
-            "MOTION,",
-        ):
-            with self.subTest(payload=payload):
-                self.dispatcher._on_birdseye_mode_command("front_door", payload)
-
-        self.dispatcher.config_updater.publish_update.assert_not_called()
-
-
 class TestRestoreRuntimeState(unittest.TestCase):
     """Verify replay routes through handlers and tolerates missing entries."""
 

frigate/test/test_gpu_stats.py

@@ -1,12 +1,7 @@
 import unittest
-from io import StringIO
 from unittest.mock import MagicMock, patch
 
-from frigate.util.services import (
-    get_amd_gpu_stats,
-    get_intel_gpu_stats,
-    get_openvino_npu_stats,
-)
+from frigate.util.services import get_amd_gpu_stats, get_intel_gpu_stats
 
 
 class TestGpuStats(unittest.TestCase):
@@ -22,88 +17,6 @@ class TestGpuStats(unittest.TestCase):
         amd_stats = get_amd_gpu_stats()
         assert amd_stats == {"gpu": "4.17%", "mem": "60.37%"}
 
-    @patch("frigate.util.services.time.sleep")
-    @patch("frigate.util.services.time.time", side_effect=[0.0, 1.0])
-    @patch(
-        "frigate.util.services.os.readlink",
-        return_value="/sys/bus/pci/drivers/intel_vpu",
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=["/sys/class/accel/accel0"],
-    )
-    @patch(
-        "builtins.open",
-        side_effect=[StringIO("1000"), StringIO("1250")],
-    )
-    def test_openvino_npu_stats_discovers_accel0(
-        self, open_file, glob, readlink, time, sleep
-    ):
-        assert get_openvino_npu_stats() == {"npu": "25.0", "mem": "-%"}
-
-        open_file.assert_any_call(
-            "/sys/class/accel/accel0/device/power/runtime_active_time"
-        )
-
-    @patch("frigate.util.services.time.sleep")
-    @patch("frigate.util.services.time.time", side_effect=[0.0, 1.0])
-    @patch(
-        "frigate.util.services.os.readlink",
-        side_effect=[
-            "/sys/bus/pci/drivers/other",
-            "/sys/bus/pci/drivers/intel_vpu",
-        ],
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=[
-            "/sys/class/accel/accel0",
-            "/sys/class/accel/accel1",
-        ],
-    )
-    @patch(
-        "builtins.open",
-        side_effect=[StringIO("1000"), StringIO("1250")],
-    )
-    def test_openvino_npu_stats_skips_non_intel_accelerator(
-        self, open_file, glob, readlink, time, sleep
-    ):
-        assert get_openvino_npu_stats() == {"npu": "25.0", "mem": "-%"}
-
-        open_file.assert_any_call(
-            "/sys/class/accel/accel1/device/power/runtime_active_time"
-        )
-
-    @patch(
-        "frigate.util.services.os.readlink",
-        return_value="/sys/bus/pci/drivers/other",
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=["/sys/class/accel/accel0"],
-    )
-    @patch("builtins.open")
-    def test_openvino_npu_stats_no_intel_accelerator(self, open_file, glob, readlink):
-        assert get_openvino_npu_stats() is None
-        open_file.assert_not_called()
-
-    @patch(
-        "frigate.util.services.os.readlink",
-        return_value="/sys/bus/pci/drivers/intel_vpu",
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=["/sys/class/accel/accel0"],
-    )
-    @patch("builtins.open", side_effect=FileNotFoundError)
-    def test_openvino_npu_stats_runtime_counter_unavailable(
-        self, open_file, glob, readlink
-    ):
-        assert get_openvino_npu_stats() is None
-        open_file.assert_called_once_with(
-            "/sys/class/accel/accel0/device/power/runtime_active_time"
-        )
-
     @patch("frigate.stats.intel_gpu_info.intel_gpu_name_resolver.get_names")
     @patch("frigate.util.services.time.sleep")
     @patch("frigate.util.services.time.monotonic")

frigate/test/test_maintainer.py

@@ -1,7 +1,7 @@
 import datetime
 import sys
 import unittest
-from unittest.mock import MagicMock, patch
+from unittest.mock import AsyncMock, MagicMock, patch
 
 # Mock complex imports before importing maintainer, saving originals so we can
 # restore them after import and avoid polluting sys.modules for other tests.
@@ -16,7 +16,7 @@ for name in _MOCKED_MODULES:
     sys.modules[name] = MagicMock()
 
 # Now import the class under test
-from frigate.config import FrigateConfig  # noqa: E402
+from frigate.config import FrigateConfig, RetainModeEnum  # noqa: E402
 from frigate.record.maintainer import RecordingMaintainer  # noqa: E402
 
 # Restore original modules (or remove mock if there was no original)
@@ -115,6 +115,70 @@ class TestMaintainer(unittest.IsolatedAsyncioTestCase):
         self.assertIsNone(result)
         maintainer.drop_segment.assert_called_once_with(cache_path)
 
+    async def test_defers_review_overlap_segment_until_metadata_catches_up(self):
+        # Regression: a segment overlapping an active_objects review must not
+        # be dropped while detection metadata lags behind the segment end,
+        # the missing frames may hold the active objects (or continuous
+        # retention would keep it anyway).
+        config = MagicMock(spec=FrigateConfig)
+
+        camera_config = MagicMock()
+        camera_config.record.enabled = True
+        camera_config.record.continuous.days = 7
+        camera_config.record.motion.days = 0
+        camera_config.record.alerts.retain.mode = RetainModeEnum.active_objects
+        camera_config.record.get_review_pre_capture.return_value = 5
+        camera_config.record.get_review_post_capture.return_value = 5
+        config.cameras = {"test_cam": camera_config}
+
+        stop_event = MagicMock()
+        maintainer = RecordingMaintainer(config, stop_event)
+
+        now = datetime.datetime.now(datetime.UTC)
+        start_time = now - datetime.timedelta(seconds=20)
+        end_time = now - datetime.timedelta(seconds=10)
+        cache_path = "/tmp/cache/test_cam@20260417150000+0000.mp4"
+
+        maintainer.end_time_cache = {cache_path: (end_time, 10.0)}
+        # Metadata has only reached partway into the segment.
+        maintainer.object_recordings_info["test_cam"] = [
+            (end_time.timestamp() - 8, [], [], [])
+        ]
+        maintainer.audio_recordings_info["test_cam"] = []
+
+        maintainer.drop_segment = MagicMock()
+        maintainer.move_segment = AsyncMock(return_value=None)
+        maintainer.recordings_publisher = MagicMock()
+
+        review = MagicMock()
+        review.severity = "alert"
+        review.start_time = start_time.timestamp() - 30
+        review.end_time = None
+
+        result = await maintainer.validate_and_move_segment(
+            "test_cam",
+            reviews=[review],
+            recording={"start_time": start_time, "cache_path": cache_path},
+        )
+
+        self.assertIsNone(result)
+        maintainer.drop_segment.assert_not_called()
+        maintainer.move_segment.assert_not_awaited()
+
+        # Once metadata passes the segment end, continuous retention keeps it.
+        maintainer.object_recordings_info["test_cam"].append(
+            (now.timestamp(), [], [], [])
+        )
+
+        await maintainer.validate_and_move_segment(
+            "test_cam",
+            reviews=[review],
+            recording={"start_time": start_time, "cache_path": cache_path},
+        )
+
+        maintainer.drop_segment.assert_not_called()
+        maintainer.move_segment.assert_awaited_once()
+
     async def test_expire_stale_recordings_info_drops_only_absent_cameras(self):
         config = MagicMock(spec=FrigateConfig)
         config.cameras = {}

frigate/test/test_mqtt_lifecycle.py

@@ -1,856 +0,0 @@
-import os
-import threading
-import unittest
-from typing import Any
-from unittest.mock import MagicMock, patch
-
-import paho.mqtt.client as mqtt
-
-from frigate.comms.dispatcher import Dispatcher
-from frigate.comms.mqtt import MqttClient, QueuedPublish
-from frigate.config import FrigateConfig
-from frigate.const import MODEL_CACHE_DIR
-
-
-class RuntimeSnapshotReceiver:
-    def __init__(self) -> None:
-        self.messages: list[tuple[str, str]] = []
-
-    def _receive(self, topic: str, payload: str) -> None:
-        self.messages.append((topic, payload))
-
-
-class FakeMessage:
-    def __init__(self, topic: str, payload: bytes) -> None:
-        self.topic = topic
-        self.payload = payload
-
-
-class FakeCommunicator:
-    def __init__(self) -> None:
-        self.receiver = None
-        self.dispatcher = None
-        self.started = False
-
-    def subscribe(self, receiver) -> None:
-        self.receiver = receiver
-
-    def attach_dispatcher(self, dispatcher) -> None:
-        self.dispatcher = dispatcher
-
-    def start(self) -> None:
-        self.started = True
-
-    def publish(self, topic: str, payload: Any, retain: bool = False) -> None:
-        return None
-
-    def stop(self) -> None:
-        return None
-
-
-class FakeSnapshotCommunicator(FakeCommunicator):
-    def start(self) -> None:
-        self.started = True
-        assert self.dispatcher is not None
-        self.dispatcher.publish_runtime_snapshot(lambda *_args, **_kwargs: None)
-
-
-def build_config() -> FrigateConfig:
-    config = {
-        "mqtt": {
-            "host": "mqtt",
-            "client_id": "frigate-test",
-            "topic_prefix": "frigate",
-        },
-        "notifications": {"enabled": True},
-        "cameras": {
-            "front": {
-                "ffmpeg": {
-                    "inputs": [
-                        {
-                            "path": "rtsp://10.0.0.1:554/video",
-                            "roles": ["detect", "audio"],
-                        }
-                    ]
-                },
-                "detect": {
-                    "height": 1080,
-                    "width": 1920,
-                    "fps": 5,
-                },
-                "audio": {"enabled": True},
-                "notifications": {"enabled": False},
-                "onvif": {"host": "10.0.0.5"},
-                "motion": {
-                    "mask": {
-                        "motion_mask_1": {
-                            "coordinates": "0,0,1,0,1,1,0,1",
-                        }
-                    }
-                },
-                "objects": {
-                    "track": ["person"],
-                    "mask": {
-                        "object_mask_1": {
-                            "coordinates": "0,0,1,0,1,1,0,1",
-                        }
-                    },
-                },
-                "zones": {
-                    "driveway": {
-                        "coordinates": "0.1,0.1,0.9,0.1,0.9,0.9,0.1,0.9",
-                        "objects": ["person"],
-                    }
-                },
-            }
-        },
-    }
-    return FrigateConfig(**config)
-
-
-def build_dispatcher(config: FrigateConfig, communicators: list[Any]) -> Dispatcher:
-    """Build a real Dispatcher with only the activity managers stubbed out."""
-    with (
-        patch("frigate.comms.dispatcher.CameraActivityManager") as mock_camera_activity,
-        patch("frigate.comms.dispatcher.AudioActivityManager") as mock_audio_activity,
-    ):
-        mock_camera_activity.return_value.last_camera_activity = {}
-        mock_audio_activity.return_value.current_audio_detections = {}
-
-        return Dispatcher(config, MagicMock(), MagicMock(), {}, communicators)
-
-
-class TestMqttClientLifecycle(unittest.TestCase):
-    def setUp(self) -> None:
-        if not os.path.exists(MODEL_CACHE_DIR) and not os.path.islink(MODEL_CACHE_DIR):
-            os.makedirs(MODEL_CACHE_DIR)
-
-        self.config = build_config()
-        self.client = MqttClient(self.config)
-        self.receiver = RuntimeSnapshotReceiver()
-        self.client.attach_dispatcher(build_dispatcher(self.config, []))
-
-    def test_subscribe_stores_receiver_without_starting_worker(self) -> None:
-        client = MqttClient(self.config)
-
-        with patch.object(client, "_start_worker") as mock_start_worker:
-            client.subscribe(self.receiver._receive)
-
-        self.assertIsNotNone(client._dispatcher)
-        self.assertIs(client._dispatcher.__self__, self.receiver)
-        self.assertIs(client._dispatcher.__func__, RuntimeSnapshotReceiver._receive)
-        mock_start_worker.assert_not_called()
-
-    def test_attach_dispatcher_supplies_command_surface(self) -> None:
-        client = MqttClient(self.config)
-
-        self.assertFalse(client._is_supported_command_topic("front/detect/set"))
-
-        dispatcher = build_dispatcher(self.config, [])
-        client.attach_dispatcher(dispatcher)
-
-        self.assertIs(client._command_router, dispatcher)
-        self.assertTrue(client._is_supported_command_topic("front/detect/set"))
-
-    def test_start_starts_worker_after_receiver_registration(self) -> None:
-        self.client.subscribe(self.receiver._receive)
-
-        with patch.object(self.client, "_start_worker") as mock_start_worker:
-            self.client.start()
-
-        mock_start_worker.assert_called_once()
-
-    def test_dispatcher_initializes_state_before_starting_communicators(self) -> None:
-        fake_comm = FakeSnapshotCommunicator()
-        dispatcher = build_dispatcher(self.config, [fake_comm])
-
-        self.assertIsNone(dispatcher.web_push_client)
-        self.assertIs(fake_comm.receiver.__self__, dispatcher)
-        self.assertIs(fake_comm.dispatcher, dispatcher)
-        self.assertFalse(fake_comm.started)
-
-        dispatcher.start_communicators()
-
-        self.assertTrue(fake_comm.started)
-
-    def test_publish_drops_ephemeral_and_coalesces_retained_while_disconnected(
-        self,
-    ) -> None:
-        self.client.publish("front/events", "payload")
-        self.assertTrue(self.client._publish_queue.empty())
-
-        self.client.publish("profile/state", "armed", retain=True)
-        self.client.publish("profile/state", "disarmed", retain=True)
-
-        self.assertEqual(
-            self.client._pending_retained["frigate/profile/state"],
-            ("disarmed", True),
-        )
-
-    def test_publish_buffers_messages_until_subscription_ready(self) -> None:
-        self.client.connected = True
-
-        self.client.publish("front/events", "payload")
-        self.client.publish("profile/state", "armed", retain=True)
-
-        self.assertEqual(self.client._publish_queue.qsize(), 2)
-        self.assertEqual(self.client._pending_retained, {})
-
-    @patch("frigate.comms.mqtt.mqtt.Client")
-    def test_connect_client_initializes_manual_loop_client(
-        self, mock_client_cls
-    ) -> None:
-        mock_client = MagicMock()
-        mock_client_cls.return_value = mock_client
-
-        connected = self.client._connect_client()
-
-        self.assertTrue(connected)
-        mock_client_cls.assert_called_once_with(
-            callback_api_version=mqtt.CallbackAPIVersion.VERSION2,
-            client_id="frigate-test",
-            reconnect_on_failure=False,
-        )
-        self.assertIs(mock_client.on_connect.__self__, self.client)
-        self.assertIs(mock_client.on_connect.__func__, MqttClient._on_connect)
-        self.assertIs(mock_client.on_disconnect.__self__, self.client)
-        self.assertIs(mock_client.on_disconnect.__func__, MqttClient._on_disconnect)
-        self.assertIs(mock_client.on_message.__self__, self.client)
-        self.assertIs(mock_client.on_message.__func__, MqttClient._on_message)
-        self.assertIs(mock_client.on_subscribe.__self__, self.client)
-        self.assertIs(mock_client.on_subscribe.__func__, MqttClient._on_subscribe)
-        mock_client.connect.assert_called_once_with("mqtt", 1883, 60)
-
-    def test_handle_connect_failure_leaves_client_disconnected(self) -> None:
-        self.client.client = MagicMock()
-        reason_code = MagicMock()
-        reason_code.getName.return_value = "Not authorized"
-
-        with patch.object(
-            self.client, "_schedule_reconnect"
-        ) as mock_schedule_reconnect:
-            self.client._handle_connect_failure(reason_code)
-
-        self.assertFalse(self.client.connected)
-        mock_schedule_reconnect.assert_called_once()
-
-    def test_handle_connect_event_subscribes_wildcard_topic(self) -> None:
-        self.client.client = MagicMock()
-        self.client.client.subscribe.return_value = (mqtt.MQTT_ERR_SUCCESS, 42)
-
-        self.client._handle_connect_event(MagicMock())
-
-        self.assertTrue(self.client.connected)
-        self.assertEqual(self.client._subscription_mid, 42)
-        self.client.client.subscribe.assert_called_once_with("frigate/#", qos=0)
-
-    def test_handle_connect_event_reconnects_on_recoverable_subscribe_error(
-        self,
-    ) -> None:
-        self.client.client = MagicMock()
-        self.client.client.subscribe.side_effect = BrokenPipeError("broken pipe")
-
-        with patch.object(
-            self.client, "_schedule_reconnect"
-        ) as mock_schedule_reconnect:
-            self.client._handle_connect_event(MagicMock())
-
-        mock_schedule_reconnect.assert_called_once()
-
-    def test_handle_subscribe_event_publishes_snapshots_after_matching_suback(
-        self,
-    ) -> None:
-        self.client.connected = True
-        self.client._subscription_mid = 7
-
-        with (
-            patch.object(self.client, "_publish_retained_state") as mock_retained,
-            patch.object(
-                self.client._command_router, "publish_runtime_snapshot"
-            ) as mock_snapshot,
-        ):
-            self.client._handle_subscribe_event(7, [MagicMock(is_failure=False)])
-
-        self.assertTrue(self.client._subscription_ready)
-        mock_retained.assert_called_once()
-        mock_snapshot.assert_called_once_with(self.client.publish)
-
-    def test_handle_subscribe_event_ignores_other_suback_mid(self) -> None:
-        self.client.connected = True
-        self.client._subscription_mid = 8
-
-        with (
-            patch.object(self.client, "_publish_retained_state") as mock_retained,
-            patch.object(
-                self.client._command_router, "publish_runtime_snapshot"
-            ) as mock_snapshot,
-        ):
-            self.client._handle_subscribe_event(9, [MagicMock(is_failure=False)])
-
-        self.assertFalse(self.client._subscription_ready)
-        mock_retained.assert_not_called()
-        mock_snapshot.assert_not_called()
-
-    def test_on_message_strips_prefix_and_dispatches_supported_topic(self) -> None:
-        dispatcher = MagicMock()
-        self.client._dispatcher = dispatcher
-
-        self.client._on_message(
-            MagicMock(),
-            None,
-            FakeMessage("frigate/front/detect/set", b"ON"),
-        )
-        self.client._drain_callback_queue()
-
-        dispatcher.assert_called_once_with("front/detect/set", "ON")
-
-    def test_on_message_ignores_unsupported_state_topic(self) -> None:
-        dispatcher = MagicMock()
-        self.client._dispatcher = dispatcher
-
-        self.client._on_message(
-            MagicMock(),
-            None,
-            FakeMessage("frigate/front/detect/state", b"ON"),
-        )
-        self.client._drain_callback_queue()
-
-        dispatcher.assert_not_called()
-
-    def test_on_message_ignores_non_utf8_payloads(self) -> None:
-        self.client._on_message(
-            MagicMock(),
-            None,
-            FakeMessage("frigate/onConnect", b"\xff"),
-        )
-
-        self.assertTrue(self.client._callback_queue.empty())
-
-    def test_on_connect_requests_are_rate_limited(self) -> None:
-        dispatcher = MagicMock()
-        self.client._dispatcher = dispatcher
-
-        with patch("frigate.comms.mqtt.time.monotonic", side_effect=[100.0, 100.1]):
-            self.client._handle_inbound_message("onConnect", "")
-            self.client._handle_inbound_message("onConnect", "")
-
-        dispatcher.assert_called_once_with("onConnect", "")
-
-    def test_supported_command_topics_preserve_command_surface(self) -> None:
-        for topic in (
-            "front/detect/set",
-            "front/audio_transcription/set",
-            "front/notifications/set",
-            "front/notifications/suspend",
-            "front/zone/driveway/set",
-            "front/motion_mask/motion_mask_1/set",
-            "front/ptz",
-            "notifications/set",
-            "profile/set",
-            "onConnect",
-            "restart",
-        ):
-            with self.subTest(topic=topic):
-                self.assertTrue(self.client._is_supported_command_topic(topic))
-
-        for topic in (
-            # Frigate's own publishes echoing back through the wildcard
-            "front/detect/state",
-            "available",
-            "front/notifications/suspended",
-            "front/zone/set",
-            "front/nonsense/set",
-            "nonsense/set",
-        ):
-            with self.subTest(topic=topic):
-                self.assertFalse(self.client._is_supported_command_topic(topic))
-
-    def test_command_surface_tracks_dispatcher_handlers(self) -> None:
-        """The allowlist is derived, so a new handler is routable for free."""
-        router = self.client._command_router
-        router._camera_settings_handlers["brand_new_toggle"] = MagicMock()
-
-        self.assertTrue(
-            self.client._is_supported_command_topic("front/brand_new_toggle/set")
-        )
-
-    def test_global_notifications_set_follows_config_gate(self) -> None:
-        """The command gate must match the publish gate in
-        _publish_retained_state: with notifications unconfigured there is no
-        state topic, so the command must not flip runtime state either."""
-        self.assertTrue(self.client._notifications_enabled_in_config())
-        self.assertTrue(self.client._is_supported_command_topic("notifications/set"))
-
-        with patch.object(
-            self.client, "_notifications_enabled_in_config", return_value=False
-        ):
-            self.assertFalse(
-                self.client._is_supported_command_topic("notifications/set")
-            )
-            # per-camera topics stay routable regardless of the global gate
-            self.assertTrue(
-                self.client._is_supported_command_topic("front/notifications/set")
-            )
-            self.assertTrue(
-                self.client._is_supported_command_topic("front/notifications/suspend")
-            )
-
-    def test_publish_direct_waits_for_flush_barrier(self) -> None:
-        mock_client = MagicMock()
-        mock_client.loop.return_value = mqtt.MQTT_ERR_SUCCESS
-        self.client.client = mock_client
-        message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS, mid=1)
-        # inflight tracking checks once, then _wait_for_publish polls
-        message_info.is_published.side_effect = [False, False, True]
-        mock_client.publish.return_value = message_info
-        barrier = MagicMock()
-
-        self.client._publish_direct(
-            QueuedPublish("frigate/available", "stopped", True, barrier)
-        )
-
-        mock_client.loop.assert_called_once()
-        barrier.set.assert_called_once()
-
-    def test_shutdown_barrier_releases_when_publish_raises(self) -> None:
-        """stop() waits on this barrier, so a broker error must not stall
-        shutdown for the full flush timeout."""
-        self.client.client = MagicMock()
-        self.client.client.publish.side_effect = BrokenPipeError("broken pipe")
-        barrier = threading.Event()
-
-        with patch.object(self.client, "_schedule_reconnect"):
-            self.client._publish_direct(
-                QueuedPublish("frigate/available", "stopped", True, barrier)
-            )
-
-        self.assertTrue(barrier.is_set())
-        self.assertEqual(
-            self.client._pending_retained["frigate/available"], ("stopped", True)
-        )
-
-    def test_shutdown_barrier_releases_on_publish_error_code(self) -> None:
-        self.client.client = MagicMock()
-        self.client.client.publish.return_value = MagicMock(rc=mqtt.MQTT_ERR_NO_CONN)
-        barrier = threading.Event()
-
-        with patch.object(self.client, "_schedule_reconnect"):
-            self.client._publish_direct(
-                QueuedPublish("frigate/available", "stopped", True, barrier)
-            )
-
-        self.assertTrue(barrier.is_set())
-
-    def test_shutdown_barrier_releases_when_requeued_while_disconnected(self) -> None:
-        barrier = threading.Event()
-        self.client._publish_queue.put(
-            QueuedPublish("frigate/available", "stopped", True, barrier)
-        )
-
-        self.client._requeue_disconnected_publishes()
-
-        self.assertTrue(barrier.is_set())
-        self.assertEqual(
-            self.client._pending_retained["frigate/available"], ("stopped", True)
-        )
-
-    def test_shutdown_barrier_releases_when_worker_crashes(self) -> None:
-        """stop() can queue the final publish just as the worker dies, and
-        nothing drains the queue after that."""
-        barrier = threading.Event()
-        self.client._publish_queue.put(
-            QueuedPublish("frigate/available", "stopped", True, barrier)
-        )
-
-        with patch.object(
-            self.client,
-            "_mqtt_loop_worker",
-            side_effect=RuntimeError("unexpected bug"),
-        ):
-            self.client._worker_main()
-
-        self.assertTrue(barrier.is_set())
-
-    def test_shutdown_barrier_releases_when_publish_raises_unexpectedly(self) -> None:
-        """The message is off the queue by the time this runs, so crash cleanup
-        cannot recover it and only _publish_direct can release the waiter."""
-        self.client.client = MagicMock()
-        self.client.client.publish.side_effect = RuntimeError("unexpected bug")
-        barrier = threading.Event()
-
-        with self.assertRaises(RuntimeError):
-            self.client._publish_direct(
-                QueuedPublish("frigate/available", "stopped", True, barrier)
-            )
-
-        self.assertTrue(barrier.is_set())
-
-    def test_newest_inflight_retained_value_wins(self) -> None:
-        """Several updates to one topic can be unacked at once above qos 0, and
-        the newest is the one subscribers should end up with."""
-        mock_client = MagicMock()
-        self.client.client = mock_client
-        self.client.connected = True
-
-        for mid, payload in ((1, "ON"), (2, "OFF")):
-            message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS, mid=mid)
-            message_info.is_published.return_value = False
-            mock_client.publish.return_value = message_info
-            self.client._publish_direct(
-                QueuedPublish("frigate/front/detect/state", payload, True)
-            )
-
-        self.client._requeue_inflight_retained()
-
-        self.assertEqual(
-            self.client._pending_retained["frigate/front/detect/state"], ("OFF", True)
-        )
-
-    def test_inflight_retained_does_not_clobber_queued_value(self) -> None:
-        """Anything still queued was written later than anything in flight."""
-        self.client._pending_retained = {"frigate/front/detect/state": ("OFF", True)}
-        self.client._inflight_retained = {1: ("frigate/front/detect/state", "ON")}
-
-        self.client._requeue_inflight_retained()
-
-        self.assertEqual(
-            self.client._pending_retained["frigate/front/detect/state"], ("OFF", True)
-        )
-
-    def test_unacked_retained_publish_survives_reconnect(self) -> None:
-        """Above qos 0 a successful rc only means paho queued the message, and
-        dropping the client drops its outbound queue with it."""
-        mock_client = MagicMock()
-        message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS, mid=12)
-        message_info.is_published.return_value = False
-        mock_client.publish.return_value = message_info
-        self.client.client = mock_client
-        self.client.connected = True
-
-        self.client._publish_direct(
-            QueuedPublish("frigate/profile/state", "armed", True)
-        )
-        self.assertEqual(
-            self.client._inflight_retained[12], ("frigate/profile/state", "armed")
-        )
-
-        self.client._cleanup_client()
-
-        self.assertEqual(self.client._inflight_retained, {})
-        self.assertEqual(
-            self.client._pending_retained["frigate/profile/state"], ("armed", True)
-        )
-
-    def test_acked_retained_publish_is_not_replayed(self) -> None:
-        mock_client = MagicMock()
-        message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS, mid=12)
-        message_info.is_published.return_value = False
-        mock_client.publish.return_value = message_info
-        self.client.client = mock_client
-        self.client.connected = True
-
-        self.client._publish_direct(
-            QueuedPublish("frigate/profile/state", "armed", True)
-        )
-        self.client._on_publish(mock_client, None, 12, MagicMock(), None)
-        self.client._drain_callback_queue()
-
-        self.assertEqual(self.client._inflight_retained, {})
-
-        self.client._cleanup_client()
-
-        self.assertEqual(self.client._pending_retained, {})
-
-    def test_already_published_retained_is_not_tracked(self) -> None:
-        """At the default qos 0 paho reports the message as published inline,
-        so there is nothing to wait on."""
-        mock_client = MagicMock()
-        message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS, mid=12)
-        message_info.is_published.return_value = True
-        mock_client.publish.return_value = message_info
-        self.client.client = mock_client
-        self.client.connected = True
-
-        self.client._publish_direct(
-            QueuedPublish("frigate/profile/state", "armed", True)
-        )
-
-        self.assertEqual(self.client._inflight_retained, {})
-
-    def test_wait_for_publish_survives_disconnect_during_wait(self) -> None:
-        mock_client = MagicMock()
-        self.client.client = mock_client
-        self.client.connected = True
-        message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS)
-        message_info.is_published.side_effect = [False, False]
-
-        loop_calls = [0]
-
-        def loop_side_effect(timeout: float) -> int:
-            if loop_calls[0] == 0:
-                self.client._callback_queue.put(("disconnect", 1))
-            loop_calls[0] += 1
-            return mqtt.MQTT_ERR_SUCCESS
-
-        mock_client.loop.side_effect = loop_side_effect
-
-        self.client._wait_for_publish(message_info)
-
-        self.assertEqual(loop_calls[0], 1)
-        self.assertIsNone(self.client.client)
-
-    def test_publish_direct_reconnects_on_recoverable_publish_error(self) -> None:
-        self.client.client = MagicMock()
-        self.client.client.publish.side_effect = BrokenPipeError("broken pipe")
-
-        with patch.object(
-            self.client, "_schedule_reconnect"
-        ) as mock_schedule_reconnect:
-            self.client._publish_direct(
-                QueuedPublish("frigate/profile/state", "armed", True)
-            )
-
-        self.assertEqual(
-            self.client._pending_retained["frigate/profile/state"],
-            ("armed", True),
-        )
-        mock_schedule_reconnect.assert_called_once()
-
-    def test_mqtt_loop_worker_reconnects_on_recoverable_loop_error(self) -> None:
-        self.client.client = MagicMock()
-        self.client.client.loop.side_effect = OSError("socket closed")
-
-        def stop_after_reconnect() -> None:
-            self.client._stop_event.set()
-
-        with patch.object(
-            self.client,
-            "_schedule_reconnect",
-            side_effect=stop_after_reconnect,
-        ) as mock_schedule_reconnect:
-            self.client._mqtt_loop_worker()
-
-        mock_schedule_reconnect.assert_called_once()
-
-    def test_worker_main_goes_dormant_on_unexpected_exception(self) -> None:
-        with patch.object(
-            self.client,
-            "_mqtt_loop_worker",
-            side_effect=RuntimeError("unexpected bug"),
-        ):
-            self.client._worker_main()
-
-        self.assertTrue(self.client._stop_event.is_set())
-        self.assertFalse(self.client.connected)
-        self.assertFalse(self.client._subscription_ready)
-        self.assertIsNone(self.client.client)
-
-    def test_worker_crash_announces_offline_before_disconnecting(self) -> None:
-        """The clean disconnect in cleanup suppresses the will, so a dormant
-        MQTT session must say so itself or consumers keep the stale values."""
-        mock_client = MagicMock()
-        mock_client.publish.return_value = MagicMock(
-            rc=mqtt.MQTT_ERR_SUCCESS, **{"is_published.return_value": True}
-        )
-        self.client.client = mock_client
-        self.client.connected = True
-
-        with patch.object(
-            self.client,
-            "_mqtt_loop_worker",
-            side_effect=RuntimeError("unexpected bug"),
-        ):
-            self.client._worker_main()
-
-        mock_client.publish.assert_called_once_with(
-            "frigate/available",
-            "offline",
-            qos=self.config.mqtt.qos,
-            retain=True,
-        )
-        # the announcement has to land before the socket is torn down
-        self.assertLess(
-            mock_client.method_calls.index(
-                next(c for c in mock_client.method_calls if c[0] == "publish")
-            ),
-            mock_client.method_calls.index(
-                next(c for c in mock_client.method_calls if c[0] == "disconnect")
-            ),
-        )
-
-    def test_worker_crash_stays_dormant_when_offline_publish_fails(self) -> None:
-        self.client.client = MagicMock()
-        self.client.client.publish.side_effect = BrokenPipeError("broken pipe")
-
-        with patch.object(
-            self.client,
-            "_mqtt_loop_worker",
-            side_effect=RuntimeError("unexpected bug"),
-        ):
-            self.client._worker_main()
-
-        self.assertTrue(self.client._stop_event.is_set())
-        self.assertIsNone(self.client.client)
-
-    def test_command_handler_exception_does_not_kill_worker(self) -> None:
-        """A raise in a dispatcher handler used to end the network thread and
-        take MQTT down until the next Frigate restart."""
-        self.client._dispatcher = MagicMock(side_effect=RuntimeError("handler bug"))
-        self.client._callback_queue.put(("message", "front/detect/set", "ON"))
-        self.client._callback_queue.put(("message", "front/motion/set", "ON"))
-
-        with self.assertLogs("frigate.comms.mqtt", level="ERROR"):
-            self.client._drain_callback_queue()
-
-        self.assertEqual(self.client._dispatcher.call_count, 2)
-
-    def test_snapshot_replay_exception_does_not_kill_worker(self) -> None:
-        self.client.connected = True
-        self.client._subscription_mid = 3
-
-        with (
-            patch.object(
-                self.client,
-                "_publish_retained_state",
-                side_effect=RuntimeError("replay bug"),
-            ),
-            self.assertLogs("frigate.comms.mqtt", level="ERROR"),
-        ):
-            self.client._handle_subscribe_event(3, [MagicMock(is_failure=False)])
-
-        self.assertTrue(self.client._subscription_ready)
-
-    def test_schedule_reconnect_drops_stale_ephemeral_and_preserves_retained(
-        self,
-    ) -> None:
-        mock_client = MagicMock()
-        message_info = MagicMock(rc=mqtt.MQTT_ERR_SUCCESS)
-        mock_client.publish.return_value = message_info
-        self.client.client = mock_client
-        self.client.connected = True
-        self.client._subscription_ready = True
-
-        self.client.publish("front/events", "ephemeral")
-        self.client.publish("profile/state", "armed", retain=True)
-
-        self.client._schedule_reconnect()
-
-        self.assertTrue(self.client._publish_queue.empty())
-        self.assertEqual(
-            self.client._pending_retained["frigate/profile/state"],
-            ("armed", True),
-        )
-
-        self.client.client = mock_client
-        self.client.connected = True
-        self.client._subscription_ready = True
-        self.client._drain_publish_queue()
-
-        mock_client.publish.assert_called_once_with(
-            "frigate/profile/state",
-            "armed",
-            qos=self.config.mqtt.qos,
-            retain=True,
-        )
-
-    def test_stop_disconnects_client_and_joins_worker(self) -> None:
-        worker = MagicMock()
-        worker.is_alive.return_value = True
-        self.client._worker = worker
-        mock_client = MagicMock()
-        self.client.client = mock_client
-
-        self.client.stop()
-
-        self.assertTrue(self.client._stop_event.is_set())
-        self.assertGreaterEqual(mock_client.disconnect.call_count, 1)
-        worker.join.assert_called_once()
-
-    def test_stop_skips_stopped_publish_until_subscription_ready(self) -> None:
-        worker = MagicMock()
-        worker.is_alive.return_value = True
-        self.client._worker = worker
-        self.client.client = MagicMock()
-        self.client.connected = True
-        self.client._subscription_ready = False
-
-        with patch.object(self.client._publish_queue, "put") as mock_queue_put:
-            self.client.stop()
-
-        mock_queue_put.assert_not_called()
-
-    def test_duplicate_disconnect_callback_is_safe(self) -> None:
-        self.client.connected = True
-
-        with patch.object(
-            self.client, "_schedule_reconnect"
-        ) as mock_schedule_reconnect:
-            self.client._handle_disconnect_event(MagicMock())
-            self.client._handle_disconnect_event(MagicMock())
-
-        mock_schedule_reconnect.assert_called_once()
-
-    def test_publish_retained_state_emits_expected_topic_families(self) -> None:
-        published_topics: list[tuple[str, Any, bool]] = []
-
-        with patch.object(
-            self.client,
-            "publish",
-            side_effect=lambda topic, payload, retain=False: published_topics.append(
-                (topic, payload, retain)
-            ),
-        ):
-            self.client._publish_retained_state()
-
-        topics = {topic for topic, _, _ in published_topics}
-        self.assertIn("front/enabled/state", topics)
-        self.assertIn("front/motion_mask/motion_mask_1/state", topics)
-        self.assertIn("front/object_mask/object_mask_1/state", topics)
-        self.assertIn("front/zone/driveway/state", topics)
-        self.assertIn("notifications/state", topics)
-        self.assertIn("profile/state", topics)
-        self.assertIn("available", topics)
-
-    def test_publish_retained_state_uses_runtime_values(self) -> None:
-        camera = self.config.cameras["front"]
-        camera.enabled_in_config = True
-        camera.enabled = False
-        camera.record.enabled_in_config = True
-        camera.record.enabled = False
-        camera.audio.enabled_in_config = True
-        camera.audio.enabled = False
-        camera.motion.enabled = False
-        camera.onvif.autotracking.enabled_in_config = True
-        camera.onvif.autotracking.enabled = False
-        camera.review.alerts.enabled_in_config = True
-        camera.review.alerts.enabled = False
-        camera.review.detections.enabled_in_config = True
-        camera.review.detections.enabled = False
-        camera.objects.genai.enabled_in_config = True
-        camera.objects.genai.enabled = False
-        camera.review.genai.enabled_in_config = True
-        camera.review.genai.enabled = False
-        self.config.notifications.enabled_in_config = True
-        self.config.notifications.enabled = False
-
-        published_states: dict[str, Any] = {}
-
-        with patch.object(
-            self.client,
-            "publish",
-            side_effect=lambda topic, payload, retain=False: (
-                published_states.__setitem__(topic, payload)
-            ),
-        ):
-            self.client._publish_retained_state()
-
-        self.assertEqual(published_states["front/enabled/state"], "OFF")
-        self.assertEqual(published_states["front/recordings/state"], "OFF")
-        self.assertEqual(published_states["front/audio/state"], "OFF")
-        self.assertEqual(published_states["front/motion/state"], "OFF")
-        self.assertEqual(published_states["front/ptz_autotracker/state"], "OFF")
-        self.assertEqual(published_states["front/review_alerts/state"], "OFF")
-        self.assertEqual(published_states["front/review_detections/state"], "OFF")
-        self.assertEqual(published_states["front/object_descriptions/state"], "OFF")
-        self.assertEqual(published_states["front/review_descriptions/state"], "OFF")
-        self.assertEqual(published_states["notifications/state"], "OFF")

frigate/test/test_mqtt_topic_registration.py

@@ -0,0 +1,100 @@
+"""Tests for MQTT command topic callback registration."""
+
+import unittest
+from unittest.mock import MagicMock, patch
+
+from frigate.comms.mqtt import MqttClient
+
+
+def _make_camera_mock(
+    *,
+    enabled: bool = True,
+    notifications_enabled_in_config: bool = False,
+) -> MagicMock:
+    """Build a camera config mock with the fields _start() reads."""
+    camera = MagicMock()
+    camera.enabled = enabled
+    camera.notifications.enabled_in_config = notifications_enabled_in_config
+    camera.onvif.host = None
+    camera.motion.mask = {}
+    camera.objects.mask = {}
+    camera.zones = {}
+    return camera
+
+
+def _registered_topics(
+    cameras: dict[str, MagicMock],
+    *,
+    global_notifications_enabled_in_config: bool = False,
+) -> set[str]:
+    """Start an MqttClient against a mocked paho client and collect the
+    topics registered via message_callback_add."""
+    config = MagicMock()
+    config.cameras = cameras
+    config.notifications.enabled_in_config = global_notifications_enabled_in_config
+    config.mqtt.topic_prefix = "frigate"
+    config.mqtt.client_id = "frigate"
+    config.mqtt.user = None
+    config.mqtt.tls_ca_certs = None
+    config.mqtt.tls_insecure = None
+
+    with patch("frigate.comms.mqtt.mqtt.Client") as client_cls:
+        mqtt_client = MqttClient(config)
+        mqtt_client.subscribe(MagicMock())
+
+    paho_client = client_cls.return_value
+    return {call.args[0] for call in paho_client.message_callback_add.call_args_list}
+
+
+class TestMqttTopicRegistration(unittest.TestCase):
+    def test_camera_notification_topics_registered(self):
+        """Per-camera notification set/suspend must be registered so paho
+        routes them to the dispatcher (unregistered topics drop silently)."""
+        topics = _registered_topics(
+            {"front_door": _make_camera_mock(notifications_enabled_in_config=True)}
+        )
+
+        self.assertIn("frigate/front_door/notifications/set", topics)
+        self.assertIn("frigate/front_door/notifications/suspend", topics)
+
+    def test_global_set_registered_with_camera_only_notifications(self):
+        """The global topic must work when notifications are enabled only at
+        the camera level, matching the WebPushClient gating in app.py."""
+        topics = _registered_topics(
+            {"front_door": _make_camera_mock(notifications_enabled_in_config=True)},
+            global_notifications_enabled_in_config=False,
+        )
+
+        self.assertIn("frigate/notifications/set", topics)
+
+    def test_global_set_registered_with_global_notifications(self):
+        topics = _registered_topics(
+            {"front_door": _make_camera_mock()},
+            global_notifications_enabled_in_config=True,
+        )
+
+        self.assertIn("frigate/notifications/set", topics)
+
+    def test_global_set_not_registered_when_notifications_unconfigured(self):
+        topics = _registered_topics(
+            {"front_door": _make_camera_mock()},
+            global_notifications_enabled_in_config=False,
+        )
+
+        self.assertNotIn("frigate/notifications/set", topics)
+
+    def test_disabled_camera_does_not_enable_global_set(self):
+        topics = _registered_topics(
+            {
+                "front_door": _make_camera_mock(
+                    enabled=False, notifications_enabled_in_config=True
+                )
+            },
+            global_notifications_enabled_in_config=False,
+        )
+
+        self.assertNotIn("frigate/notifications/set", topics)
+
+
+if __name__ == "__main__":
+    unittest.main()

frigate/test/test_profiles.py

@@ -560,25 +560,6 @@ class TestProfileManager(unittest.TestCase):
         assert err is None
         assert self.config.cameras["front"].enabled is False
 
-    @patch.object(ProfileManager, "_persist_active_profile")
-    def test_profile_can_disable_inherited_birdseye_activity(self, mock_persist):
-        """A false-only mode override inherits the other base activity types."""
-        self.config.profiles["away"] = ProfileDefinitionConfig(friendly_name="Away")
-        base_mode = self.config.cameras["front"].birdseye.mode
-        base_mode.motion = True
-        base_mode.objects = True
-        self.config.cameras["front"].profiles["away"] = CameraProfileConfig(
-            birdseye={"mode": {"motion": False}}
-        )
-        self.manager = ProfileManager(self.config, self.mock_updater)
-
-        err = self.manager.activate_profile("away")
-
-        assert err is None
-        mode = self.config.cameras["front"].birdseye.mode
-        assert not mode.motion
-        assert mode.objects
-
     @patch.object(ProfileManager, "_persist_active_profile")
     def test_deactivate_restores_enabled(self, mock_persist):
         """Deactivating a profile restores the camera's base enabled state."""
@@ -739,53 +720,6 @@ class TestProfileManager(unittest.TestCase):
         assert "objects" in api_base
         assert api_base["objects"]["track"] == ["person"]
 
-    @patch.object(ProfileManager, "_persist_active_profile")
-    def test_update_config_reapplies_active_profile(self, mock_persist):
-        """Replacing the config preserves the active profile overrides."""
-        self.manager.activate_profile("armed")
-
-        new_config = FrigateConfig(**self.config_data)
-        self.manager.update_config(new_config)
-
-        assert self.manager.config.active_profile == "armed"
-        assert self.manager.config.cameras["front"].notifications.enabled is True
-        assert self.manager.config.cameras["front"].objects.track == [
-            "person",
-            "car",
-            "package",
-        ]
-
-    @patch.object(ProfileManager, "_persist_active_profile")
-    def test_update_config_deactivates_removed_profile(self, mock_persist):
-        """Replacing the config clears the active profile if it no longer exists."""
-        self.manager.activate_profile("armed")
-
-        new_config_data = json.loads(json.dumps(self.config_data))
-        del new_config_data["profiles"]["armed"]
-        del new_config_data["cameras"]["front"]["profiles"]["armed"]
-        del new_config_data["cameras"]["back"]["profiles"]["armed"]
-
-        new_config = FrigateConfig(**new_config_data)
-        self.manager.update_config(new_config)
-
-        assert self.manager.config.active_profile is None
-
-    @patch.object(ProfileManager, "_persist_active_profile")
-    def test_enabled_state_is_published_via_dispatcher_when_profile_changes(
-        self, mock_persist
-    ):
-        """Enabled state updates are published through the dispatcher when present."""
-        self.config.profiles["away"] = ProfileDefinitionConfig(friendly_name="Away")
-        self.config.cameras["front"].profiles["away"] = CameraProfileConfig(
-            enabled=False
-        )
-        dispatcher = MagicMock()
-        self.manager = ProfileManager(self.config, self.mock_updater, dispatcher)
-
-        self.manager.activate_profile("away")
-
-        dispatcher.publish.assert_any_call("front/enabled/state", "OFF", retain=True)
-
     def test_base_configs_for_api_are_json_serializable(self):
         """API base configs are JSON-serializable (mode='json')."""
         import json

frigate/test/test_sqlitevecq_embeddings.py

@@ -1,16 +1,24 @@
-"""Tests for embedding cleanup on the main Frigate database.
+"""Tests for embedding storage and cleanup on the main Frigate database.
 
 Embeddings are deleted whether or not semantic search is currently enabled, so
 the delete path has to tolerate databases where the vec0 tables were never
 created and installs where the sqlite-vec extension is unavailable.
+
+The write paths need the real extension, since the behavior under test belongs
+to vec0 itself, so those tests are skipped when it is not installed.
 """
 
 import os
+import struct
 import tempfile
 import unittest
 
+from peewee import OperationalError
+
 from frigate.db.sqlitevecq import SqliteVecQueueDatabase
 
+VEC_EXTENSION_PATH = "/usr/local/lib/vec0.so"
+
 
 class TestDeleteEmbeddings(unittest.TestCase):
     def setUp(self) -> None:
@@ -52,6 +60,21 @@ class TestDeleteEmbeddings(unittest.TestCase):
 
         self.assertEqual(self._thumbnail_ids(), ["b"])
 
+    def test_delete_failure_is_logged_not_raised(self) -> None:
+        self._create_thumbnails_table()
+        self.db.execute_sql(
+            """
+            CREATE TRIGGER vec_thumbnails_no_delete BEFORE DELETE ON vec_thumbnails
+            BEGIN SELECT RAISE(ABORT, 'delete blocked'); END
+            """
+        ).fetchall()
+
+        with self.assertLogs("frigate.db.sqlitevecq", level="ERROR") as logs:
+            self.db.delete_embeddings_thumbnail(event_ids=["a"])
+
+        self.assertIn("Failed to delete embeddings", logs.output[0])
+        self.assertEqual(self._thumbnail_ids(), ["a", "b"])
+
     def test_delete_skipped_without_extension(self) -> None:
         self._create_thumbnails_table()
         self.db.load_vec_extension = False
@@ -61,3 +84,104 @@ class TestDeleteEmbeddings(unittest.TestCase):
 
         # the vec0 tables cannot be written without the extension
         self.assertEqual(self._thumbnail_ids(), ["a", "b"])
+
+
+def _vector(value: float) -> bytes:
+    return struct.pack("768f", *([value] * 768))
+
+
+@unittest.skipUnless(
+    os.path.exists(VEC_EXTENSION_PATH), "sqlite-vec extension is not installed"
+)
+class TestEmbeddingsTableWrites(unittest.TestCase):
+    """Covers the vec0 writes behind semantic search reindexing."""
+
+    def setUp(self) -> None:
+        self.tmp_dir = tempfile.TemporaryDirectory()
+        self.db = SqliteVecQueueDatabase(
+            os.path.join(self.tmp_dir.name, "test.db"), load_vec_extension=True
+        )
+        self.db.start()
+        self.db.create_embeddings_tables()
+
+    def tearDown(self) -> None:
+        self.db.stop()
+        self.db.close()
+        self.tmp_dir.cleanup()
+
+    def _vec_tables(self) -> list[str]:
+        return [
+            row[0]
+            for row in self.db.execute_sql(
+                "SELECT name FROM sqlite_master WHERE name LIKE 'vec_%' ORDER BY name"
+            )
+        ]
+
+    def _make_legacy(self, table: str) -> None:
+        # sqlite-vec added the _info shadow table in 0.1.6, so tables written by
+        # Frigate 0.17 and earlier do not have one
+        self.db.execute_sql(f"DROP TABLE {table}_info").fetchall()
+
+    def _stored(self, table: str, column: str, event_id: str) -> str | None:
+        row = self.db.execute_sql(
+            f"SELECT vec_to_json({column}) FROM {table} WHERE id = ?", (event_id,)
+        ).fetchone()
+        return row[0] if row else None
+
+    def test_write_error_is_raised(self) -> None:
+        # queued writes hide their exception in the returned cursor
+        with self.assertRaises(OperationalError):
+            self.db.execute_write("INSERT INTO vec_missing(id) VALUES ('a')")
+
+    def test_drop_tables_removes_legacy_tables(self) -> None:
+        self._make_legacy("vec_thumbnails")
+        self._make_legacy("vec_descriptions")
+
+        self.db.drop_embeddings_tables()
+
+        self.assertEqual(self._vec_tables(), [])
+
+    def test_drop_tables_without_any_tables_does_not_raise(self) -> None:
+        self.db.drop_embeddings_tables()
+
+        self.db.drop_embeddings_tables()
+
+    def test_upsert_replaces_existing_embedding(self) -> None:
+        self.db.upsert_embeddings(
+            "vec_thumbnails", "thumbnail_embedding", {"evt1": _vector(0.01)}
+        )
+
+        self.db.upsert_embeddings(
+            "vec_thumbnails", "thumbnail_embedding", {"evt1": _vector(0.99)}
+        )
+
+        stored = self._stored("vec_thumbnails", "thumbnail_embedding", "evt1")
+        self.assertTrue(stored.startswith("[0.990000"), stored)
+
+    def test_upsert_keeps_one_row_per_event(self) -> None:
+        for _ in range(3):
+            self.db.upsert_embeddings(
+                "vec_descriptions", "description_embedding", {"evt1": _vector(0.5)}
+            )
+
+        count = self.db.execute_sql(
+            "SELECT count(*) FROM vec_descriptions WHERE id = 'evt1'"
+        ).fetchone()[0]
+        self.assertEqual(count, 1)
+
+    def test_reindex_cycle_rewrites_legacy_tables(self) -> None:
+        """The 0.18 upgrade path: old vectors in, new vectors out."""
+        self.db.upsert_embeddings(
+            "vec_thumbnails", "thumbnail_embedding", {"evt1": _vector(0.01)}
+        )
+        self._make_legacy("vec_thumbnails")
+        self._make_legacy("vec_descriptions")
+
+        self.db.drop_embeddings_tables()
+        self.db.create_embeddings_tables()
+        self.db.upsert_embeddings(
+            "vec_thumbnails", "thumbnail_embedding", {"evt1": _vector(0.99)}
+        )
+
+        stored = self._stored("vec_thumbnails", "thumbnail_embedding", "evt1")
+        self.assertTrue(stored.startswith("[0.990000"), stored)

frigate/test/test_timeline.py

@@ -0,0 +1,66 @@
+import unittest
+from unittest.mock import MagicMock, patch
+
+from frigate.events.types import EventStateEnum
+from frigate.models import Timeline
+from frigate.timeline import TimelineProcessor
+
+
+def make_event(has_clip: bool, has_snapshot: bool) -> dict:
+    return {
+        "id": "event-1",
+        "frame_time": 1000.0,
+        "box": [0, 0, 10, 10],
+        "region": [0, 0, 100, 100],
+        "label": "car",
+        "sub_label": None,
+        "score": 0.8,
+        "has_clip": has_clip,
+        "has_snapshot": has_snapshot,
+        "current_zones": [],
+        "stationary": False,
+        "attributes": {},
+        "current_attributes": [],
+    }
+
+
+class TestTimelineProcessor(unittest.TestCase):
+    def setUp(self):
+        camera_config = MagicMock()
+        camera_config.detect.width = 1280
+        camera_config.detect.height = 720
+        config = MagicMock()
+        config.cameras.get.return_value = camera_config
+        self.processor = TimelineProcessor(config, MagicMock(), MagicMock())
+
+    @patch.object(Timeline, "insert")
+    def test_unsaved_event_writes_no_timeline_rows(self, insert):
+        event = make_event(has_clip=False, has_snapshot=False)
+        self.processor.handle_object_detection(
+            "front", EventStateEnum.start, None, event
+        )
+        self.processor.handle_object_detection(
+            "front", EventStateEnum.end, event, event
+        )
+
+        insert.assert_not_called()
+        self.assertEqual(self.processor.pre_event_cache, {})
+
+    @patch.object(Timeline, "insert")
+    def test_cached_entries_flush_when_event_is_saved(self, insert):
+        start = make_event(has_clip=False, has_snapshot=False)
+        self.processor.handle_object_detection(
+            "front", EventStateEnum.start, None, start
+        )
+        insert.assert_not_called()
+
+        end = make_event(has_clip=True, has_snapshot=False)
+        self.processor.handle_object_detection("front", EventStateEnum.end, start, end)
+
+        class_types = [c.args[0][Timeline.class_type] for c in insert.call_args_list]
+        self.assertEqual(class_types, ["visible", "gone"])
+        self.assertEqual(self.processor.pre_event_cache, {})
+
+
+if __name__ == "__main__":
+    unittest.main()