Bump onnx from 1.14.0 to 1.23.2 in /docker/tensorrt

Bumps [onnx](https://github.com/onnx/onnx) from 1.14.0 to 1.23.2.
- [Release notes](https://github.com/onnx/onnx/releases)
- [Changelog](https://github.com/onnx/onnx/blob/main/docs/Changelog-ml.md)
- [Commits](https://github.com/onnx/onnx/compare/v1.14.0...v1.23.2)

---
updated-dependencies:
- dependency-name: onnx
  dependency-version: 1.23.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

docker/main/requirements-wheels.txt

@@ -2,9 +2,9 @@ aiofiles == 25.1.*
 click == 8.5.*
 # FastAPI
 aiohttp == 3.12.*
-starlette == 0.47.*
+starlette == 1.7.*
 starlette-context == 0.5.*
-fastapi[standard-no-fastapi-cloud-cli] == 0.116.*
+fastapi[standard-no-fastapi-cloud-cli] == 0.142.*
 uvicorn == 0.52.*
 slowapi == 0.1.*
 joserfc == 1.6.*

docker/tensorrt/requirements-amd64.txt

@@ -12,6 +12,6 @@ nvidia-cusolver-cu12==11.7.3.90; platform_machine == 'x86_64'
 nvidia-cusparse-cu12==12.5.8.93; platform_machine == 'x86_64'
 nvidia-nccl-cu12==2.26.2.post1; platform_machine == 'x86_64'
 nvidia-nvjitlink-cu12==12.8.93; platform_machine == 'x86_64'
-onnx==1.16.*; platform_machine == 'x86_64'
+onnx==1.23.*; platform_machine == 'x86_64'
 onnxruntime-gpu==1.24.*; platform_machine == 'x86_64'
 protobuf==3.20.3; platform_machine == 'x86_64'

docker/tensorrt/requirements-models-arm64.txt

@@ -1,2 +1,2 @@
-onnx == 1.14.0; platform_machine == 'aarch64'
+onnx == 1.23.2; platform_machine == 'aarch64'
 protobuf == 3.20.3; platform_machine == 'aarch64'

docs/docs/configuration/camera_specific.md

@@ -169,10 +169,10 @@ The [Add Camera Wizard](cameras.md#adding-a-camera-with-the-add-camera-wizard) i
 
 1. Click **Add Camera** in <NavPath path="Settings > Global configuration > Camera management" />.
 2. Choose **Manual selection** as the stream detection method and select **Reolink** as the camera brand.
-3. The wizard queries the camera and automatically uses an http-flv stream for cameras 5MP and lower, or an RTSP stream for higher resolution cameras.
-4. In the validation step, enable **Use stream compatibility mode** for http-flv streams when the wizard recommends it.
+3. The wizard queries the camera and automatically uses an http-flv stream for cameras 5MP and lower. For higher resolution cameras, it tries the http-flv stream first and falls back to RTSP when the camera does not support it.
+4. The wizard turns on **Use stream compatibility mode** for the http-flv stream it selects. Enable it for any other http-flv stream you add, such as the sub stream.
 
-If you use the **Probe camera** method instead, the discovered stream URLs will be RTSP. For Reolink cameras where http-flv is recommended, the wizard will show a warning in the validation step.
+If you use the **Probe camera** method instead, the discovered stream URLs will be RTSP. For Reolink cameras 5MP and lower, where http-flv is recommended, the wizard will show a warning in the validation step.
 
 The wizard covers standard single-camera setups. For two way talk, cameras connected through a Reolink NVR, or audio transcoding for WebRTC live view, configure the camera manually as shown below.
 

docs/docs/frigate/hardware.md

@@ -189,7 +189,7 @@ Frigate is able to utilize an Nvidia GPU which supports the 12.x series of CUDA
 
 #### Minimum Hardware Support
 
-12.x series of CUDA libraries are used which have minor version compatibility. The minimum driver version on the host system must be `>=545`. Also the GPU must support a Compute Capability of `5.0` or greater. This generally correlates to a Maxwell-era GPU or newer, check the NVIDIA GPU Compute Capability table linked below.
+12.x series of CUDA libraries are used which have minor version compatibility. The minimum driver version on the host system must be `>=545`. The oldest supported GPU generation for object detection is Pascal (Compute Capability 6.0 or greater). Older generations such as Maxwell are not supported but can still be used by following a [community workaround](https://github.com/blakeblackshear/frigate/discussions/20088). For other GPUs, check the NVIDIA GPU Compute Capability table linked below.
 
 Make sure your host system has the [nvidia-container-runtime](https://docs.docker.com/config/containers/resource_constraints/#access-an-nvidia-gpu) installed to pass through the GPU to the container and the host system has a compatible driver installed for your GPU.
 

docs/docs/troubleshooting/faqs.md

@@ -53,14 +53,6 @@ go2rtc:
 
 Point the camera's inputs at the restream as described in the [restream docs](/configuration/restream.md), and swap `detect -> width` and `detect -> height` to match the rotated resolution.
 
-### Can I add a privacy mask to hide part of my camera's view?
-
-Frigate does not have privacy masks. [Motion masks and object filter masks](../configuration/masks.md) only affect detection, they don't hide anything in live view, recordings, or snapshots.
-
-Privacy masks are best configured in the camera's firmware settings so the area is blacked out before the video ever leaves the camera and no extra processing is needed. Check there first.
-
-If your camera does not support privacy masks, there is no efficient alternative. Frigate copies the camera's video into recordings and live view without decoding it, so part of the image can't be hidden without transcoding (re-encoding) the stream. This can be done with a custom ffmpeg filter in go2rtc, but it is not recommended. Every masked camera needs a continuous re-encode, which significantly increases CPU usage, especially for high resolution streams.
-
 ### My mjpeg stream or snapshots look green and crazy
 
 This almost always means that the width/height defined for your camera are not correct. Double check the resolution with VLC or another player. Also make sure you don't have the width and height values backwards.

docs/package-lock.json

@@ -7030,9 +7030,9 @@
       }
     },
     "node_modules/brace-expansion": {
-      "version": "1.1.18",
-      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.18.tgz",
-      "integrity": "sha512-Edep/X9fGqVNmzKBVsDYIOtD+z1tuezV70LBjdCst9Tqu76lsnvRiZ6oTic1n+/BIwX6QDGAO94PN4N2SADvtw==",
+      "version": "1.1.21",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.21.tgz",
+      "integrity": "sha512-9zeA+KLZNNzglF2TPKRQEDyx6Yby7daAkuy8MiPzpXPsYDWi/DRM8jmwUDxokQjYqBpv5DgPiwD4h4ZZSy1Ujw==",
       "license": "MIT",
       "dependencies": {
         "balanced-match": "^1.0.0",
@@ -7698,14 +7698,15 @@
       }
     },
     "node_modules/compression": {
-      "version": "1.8.1",
-      "resolved": "https://registry.npmjs.org/compression/-/compression-1.8.1.tgz",
-      "integrity": "sha512-9mAqGPHLakhCLeNyxPkK4xVo746zQ/czLH1Ky+vkitMnWfWZps8r0qXuwhwizagCRttsL4lfG4pIOvaWLpAP0w==",
+      "version": "1.8.2",
+      "resolved": "https://registry.npmjs.org/compression/-/compression-1.8.2.tgz",
+      "integrity": "sha512-o8vI5RE5A6EVVOd9o41jKp41aJom+QTEO/Bx8MYNjexMo/Bv2WOjUfZr+aL0WnYSgymUy6zeguqLTsIhV0gMvQ==",
       "license": "MIT",
       "dependencies": {
         "bytes": "3.1.2",
         "compressible": "~2.0.18",
         "debug": "2.6.9",
+        "destroy": "1.2.0",
         "negotiator": "~0.6.4",
         "on-headers": "~1.1.0",
         "safe-buffer": "5.2.1",
@@ -7713,6 +7714,10 @@
       },
       "engines": {
         "node": ">= 0.8.0"
+      },
+      "funding": {
+        "type": "opencollective",
+        "url": "https://opencollective.com/express"
       }
     },
     "node_modules/compression/node_modules/bytes": {
@@ -17448,9 +17453,9 @@
       "license": "ISC"
     },
     "node_modules/proxy-addr": {
-      "version": "2.0.7",
-      "resolved": "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.7.tgz",
-      "integrity": "sha512-llQsMLSUDUPT44jdrU/O37qlnifitDP+ZwrmmZcoSKyLKvtZxpyV0n2/bD/N4tBAAZ/gJEdZU7KMraoK1+XYAg==",
+      "version": "2.0.8",
+      "resolved": "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.8.tgz",
+      "integrity": "sha512-5nnx0yGyVUcY6t9RnWcARWtwT9F1D8O9rt08htPvnd49W1IgZtmLkhu9WfMzQj1cFxjHIO6connUNVW5k7AVyQ==",
       "license": "MIT",
       "dependencies": {
         "forwarded": "0.2.0",
@@ -17458,6 +17463,10 @@
       },
       "engines": {
         "node": ">= 0.10"
+      },
+      "funding": {
+        "type": "opencollective",
+        "url": "https://opencollective.com/express"
       }
     },
     "node_modules/proxy-addr/node_modules/ipaddr.js": {
@@ -19229,9 +19238,9 @@
       }
     },
     "node_modules/shell-quote": {
-      "version": "1.10.0",
-      "resolved": "https://registry.npmjs.org/shell-quote/-/shell-quote-1.10.0.tgz",
-      "integrity": "sha512-w1aiOKwKuRgtwAReIIj89puqg+I7GvX4IbLrvmhXbzQsj1+Zwi4VO3+fa6ZF91TWSjIxoEkKnMeHcLEODK5ZXA==",
+      "version": "1.12.0",
+      "resolved": "https://registry.npmjs.org/shell-quote/-/shell-quote-1.12.0.tgz",
+      "integrity": "sha512-PcByqNyT/38F2kDNi006HAMRJaULuBzq/FOsw3qdZvX/GA9W/jamDaRskgHjubHiftXK5sIFxLNkvrXUwcof6Q==",
       "license": "MIT",
       "engines": {
         "node": ">= 0.4"
@@ -19513,9 +19522,9 @@
       }
     },
     "node_modules/source-map-js": {
-      "version": "1.2.1",
-      "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.1.tgz",
-      "integrity": "sha512-UXWMKhLOwVKb728IUtQPXxfYU+usdybtUrK/8uGE8CQMvrhOpwvzDBwj0QhSL7MQc7vIsISBG8VQ8+IDQxpfQA==",
+      "version": "1.2.2",
+      "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.2.tgz",
+      "integrity": "sha512-KGj/8Y43x35aZVDtt+J4mK1hoLGHULMYfSkODJNQjNDC3oW1PqPoxMwo0pLUsWM/UEGzON/NxeHywEfNXNP3Vw==",
       "license": "BSD-3-Clause",
       "engines": {
         "node": ">=0.10.0"

docs/static/frigate-api.yaml

@@ -8017,7 +8017,7 @@ components:
       properties:
         file:
           type: string
-          format: binary
+          contentMediaType: application/octet-stream
           title: File
       type: object
       required:
@@ -8027,7 +8027,7 @@ components:
       properties:
         file:
           type: string
-          format: binary
+          contentMediaType: application/octet-stream
           title: File
       type: object
       required:
@@ -9601,6 +9601,11 @@ components:
         type:
           type: string
           title: Error Type
+        input:
+          title: Input
+        ctx:
+          type: object
+          title: Context
       type: object
       required:
         - loc

frigate/comms/mqtt.py

@@ -3,6 +3,7 @@ from __future__ import annotations
 import logging
 import queue
 import selectors
+import socket
 import threading
 import time
 from collections.abc import Callable
@@ -57,6 +58,11 @@ class MqttClient(Communicator):
         self._next_connect_time = 0.0
         self._last_on_connect_dispatch = 0.0
 
+        # lets other threads interrupt the worker's socket wait
+        self._wake_recv, self._wake_send = socket.socketpair()
+        self._wake_recv.setblocking(False)
+        self._wake_send.setblocking(False)
+
     def subscribe(self, receiver: Callable) -> None:
         """Wrapper for allowing dispatcher to subscribe."""
         self._dispatcher = receiver
@@ -86,6 +92,7 @@ class MqttClient(Communicator):
             return
 
         self._publish_queue.put(QueuedPublish(full_topic, payload, retain))
+        self._wake_worker()
 
     def stop(self) -> None:
         if self._worker is None:
@@ -101,9 +108,11 @@ class MqttClient(Communicator):
                     publish_done,
                 )
             )
+            self._wake_worker()
             publish_done.wait(MQTT_SHUTDOWN_FLUSH_TIMEOUT)
 
         self._stop_event.set()
+        self._wake_worker()
 
         if self.client is not None:
             try:
@@ -369,11 +378,17 @@ class MqttClient(Communicator):
                 exc_info=True,
             )
 
+    def _wake_worker(self) -> None:
+        try:
+            self._wake_send.send(b"\0")
+        except BlockingIOError:
+            # the buffer is full, so a wake is already pending
+            pass
+
     def _loop_client(self, timeout: float) -> int:
         """Drive Paho without select()'s limit on socket file descriptors."""
+        assert self.client is not None
         client = self.client
-        if client is None:
-            return mqtt.MQTT_ERR_NO_CONN
         sock = client.socket()
         if sock is None:
             return mqtt.MQTT_ERR_NO_CONN
@@ -385,11 +400,19 @@ class MqttClient(Communicator):
         pending = hasattr(sock, "pending") and sock.pending() > 0
         with selectors.DefaultSelector() as selector:
             selector.register(sock, events)
-            ready = selector.select(0.0 if pending else timeout)
+            selector.register(self._wake_recv, selectors.EVENT_READ)
+            ready = {
+                key.fileobj: mask
+                for key, mask in selector.select(0.0 if pending else timeout)
+            }
 
-        ready_events = 0
-        for _, mask in ready:
-            ready_events |= mask
+        if self._wake_recv in ready:
+            try:
+                self._wake_recv.recv(4096)
+            except BlockingIOError:
+                pass
+
+        ready_events = ready.get(sock, 0)
         if pending or ready_events & selectors.EVENT_READ:
             result = client.loop_read()
             if result != mqtt.MQTT_ERR_SUCCESS or client.socket() is None:

frigate/jobs/export.py

@@ -15,7 +15,7 @@ from peewee import DoesNotExist
 from frigate.comms.inter_process import InterProcessRequestor
 from frigate.config import FrigateConfig
 from frigate.config.camera.record import ChaptersEnum
-from frigate.const import EXPORT_DIR, UPDATE_JOB_STATE
+from frigate.const import UPDATE_JOB_STATE
 from frigate.jobs.job import Job
 from frigate.models import Export
 from frigate.record.export import (
@@ -415,10 +415,6 @@ def reap_stale_exports() -> None:
     this in a try/except. A failure on a single row will not stop the rest
     of the sweep, and a failure in the top-level query will log and return.
     """
-    # staged stream runs live on disk, so a killed export leaves them behind
-    for staged in Path(EXPORT_DIR).glob("export_stage_*"):
-        staged.unlink(missing_ok=True)
-
     try:
         stale_exports = list(Export.select().where(Export.in_progress == True))  # noqa: E712
     except Exception:

frigate/record/export.py

@@ -559,7 +559,7 @@ class RecordingExporter(threading.Thread):
         )
 
     def _staged_run_path(self, index: int) -> str:
-        return os.path.join(EXPORT_DIR, f"export_stage_{self.export_id}_{index}.mp4")
+        return os.path.join(CACHE_DIR, f"export_stage_{self.export_id}_{index}.mp4")
 
     def _probe_stream_resolution(self, run: StreamRun) -> tuple[int, int] | None:
         """Probe one recording from a run for its resolution.

frigate/test/http_api/test_http_export.py

@@ -453,21 +453,6 @@ class TestHttpExport(BaseTestHttp):
             assert unchanged.name == "front door export"
             assert unchanged.video_path == video
 
-    def test_reap_stale_exports_removes_staged_runs(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            staged = os.path.join(tmpdir, "export_stage_front_door_abc_0.mp4")
-            finished = os.path.join(tmpdir, "front_door_export.mp4")
-
-            for path in (staged, finished):
-                with open(path, "w") as handle:
-                    handle.write("video")
-
-            with patch("frigate.jobs.export.EXPORT_DIR", tmpdir):
-                reap_stale_exports()
-
-            assert not os.path.exists(staged)
-            assert os.path.exists(finished)
-
     def test_reap_stale_exports_deletes_rows_with_no_file(self):
         with tempfile.TemporaryDirectory() as tmpdir:
             stale_video = os.path.join(tmpdir, "stale.mp4")

frigate/test/test_mqtt_lifecycle.py

@@ -126,12 +126,18 @@ class TestMqttClientLifecycle(unittest.TestCase):
             os.makedirs(MODEL_CACHE_DIR)
 
         self.config = build_config()
-        self.client = MqttClient(self.config)
+        self.client = self._build_client()
         self.receiver = RuntimeSnapshotReceiver()
         self.client.attach_dispatcher(build_dispatcher(self.config, []))
 
-    def test_subscribe_stores_receiver_without_starting_worker(self) -> None:
+    def _build_client(self) -> MqttClient:
         client = MqttClient(self.config)
+        self.addCleanup(client._wake_recv.close)
+        self.addCleanup(client._wake_send.close)
+        return client
+
+    def test_subscribe_stores_receiver_without_starting_worker(self) -> None:
+        client = self._build_client()
 
         with patch.object(client, "_start_worker") as mock_start_worker:
             client.subscribe(self.receiver._receive)
@@ -142,7 +148,7 @@ class TestMqttClientLifecycle(unittest.TestCase):
         mock_start_worker.assert_not_called()
 
     def test_attach_dispatcher_supplies_command_surface(self) -> None:
-        client = MqttClient(self.config)
+        client = self._build_client()
 
         self.assertFalse(client._is_supported_command_topic("front/detect/set"))
 
@@ -295,6 +301,13 @@ class TestMqttClientLifecycle(unittest.TestCase):
         self.assertEqual(self.client._subscription_mid, 42)
         self.client.client.subscribe.assert_called_once_with("frigate/#", qos=0)
 
+    def test_publish_wakes_worker(self) -> None:
+        self.client.connected = True
+
+        self.client.publish("events", "payload")
+
+        self.assertEqual(self.client._wake_recv.recv(16), b"\0")
+
     def test_handle_connect_event_reconnects_on_recoverable_subscribe_error(
         self,
     ) -> None:

frigate/test/test_mqtt_network_loop.py

@@ -2,6 +2,7 @@ import fcntl
 import resource
 import selectors
 import socket
+import time
 import unittest
 from unittest.mock import MagicMock, patch
 
@@ -23,6 +24,11 @@ class TestMqttNetworkLoop(unittest.TestCase):
         self.sock, self.peer = socket.socketpair()
         self.addCleanup(self.sock.close)
         self.addCleanup(self.peer.close)
+        self.transport._wake_recv, self.transport._wake_send = socket.socketpair()
+        self.transport._wake_recv.setblocking(False)
+        self.transport._wake_send.setblocking(False)
+        self.addCleanup(self.transport._wake_recv.close)
+        self.addCleanup(self.transport._wake_send.close)
         self.client.socket.return_value = self.sock
 
     def test_high_fd_handles_connack_suback_publish_and_puback(self) -> None:
@@ -123,8 +129,18 @@ class TestMqttNetworkLoop(unittest.TestCase):
         self.assertEqual(self.transport._loop_client(0), mqtt.MQTT_ERR_CONN_LOST)
         self.client.loop_misc.assert_not_called()
 
-    def test_missing_client_or_socket_reports_no_connection(self) -> None:
+    def test_missing_socket_reports_no_connection(self) -> None:
         self.client.socket.return_value = None
         self.assertEqual(self.transport._loop_client(0), mqtt.MQTT_ERR_NO_CONN)
-        self.transport.client = None
-        self.assertEqual(self.transport._loop_client(0), mqtt.MQTT_ERR_NO_CONN)
+
+    def test_wake_interrupts_wait_and_is_consumed(self) -> None:
+        self.transport._wake_worker()
+
+        start = time.monotonic()
+        self.assertEqual(self.transport._loop_client(5), mqtt.MQTT_ERR_SUCCESS)
+        self.assertLess(time.monotonic() - start, 1)
+        self.client.loop_read.assert_not_called()
+
+        start = time.monotonic()
+        self.transport._loop_client(0.2)
+        self.assertGreater(time.monotonic() - start, 0.15)

frigate/test/test_recording_coverage.py

@@ -13,7 +13,6 @@ from frigate.models import Recordings
 from frigate.util.recording_coverage import (
     _rows_query,
     coverage_spans,
-    null_audio_glitches,
     plan_clip,
     realized_timeline,
     resolve_coverage,
@@ -167,22 +166,6 @@ class TestRecordingCoverage(CoverageDbTestCase):
         expected = int(5 * 1024 * 1024 * 8 / 10)
         assert summary["main"]["bitrate"] == expected
 
-    def test_unknown_audio_row_keeps_video_only_stream(self):
-        self._insert("s1", 1000.0, 1010.0, "sub", has_audio=False)
-        self._insert("s2", 1010.0, 1020.0, "sub", has_audio=None)
-        self._insert("s3", 1020.0, 1030.0, "sub", has_audio=False)
-        kept = null_audio_glitches(resolve_coverage("front_door", 1000.0, 1030.0))
-        self.assertEqual(
-            [i.sub.path for i in kept], [f"/tmp/s{n}.mp4" for n in (1, 2, 3)]
-        )
-
-    def test_video_only_glitch_dropped_on_audio_stream(self):
-        self._insert("s1", 1000.0, 1010.0, "sub", has_audio=True)
-        self._insert("s2", 1010.0, 1020.0, "sub", has_audio=False)
-        self._insert("s3", 1020.0, 1030.0, "sub", has_audio=None)
-        kept = null_audio_glitches(resolve_coverage("front_door", 1000.0, 1030.0))
-        self.assertEqual([i.sub.path for i in kept], ["/tmp/s1.mp4", "/tmp/s3.mp4"])
-
     def test_other_camera_rows_excluded(self):
         self._insert("m1", 1000.0, 1010.0, "main")
         self._insert("o1", 1000.0, 1010.0, "main", camera="back_yard")

frigate/util/classification.py

@@ -747,14 +747,8 @@ def collect_object_classification_examples(
     selected_events = _select_balanced_events(events, target_count=100)
     logger.debug(f"Selected {len(selected_events)} events")
 
-    # Step 3: Extract thumbnails from events, falling back to the remaining
-    # events when the selected ones have no image on disk
-    selected_ids = {e.id for e in selected_events}
-    remaining_events = [e for e in events if e.id not in selected_ids]
-    random.shuffle(remaining_events)
-    thumbnails = _extract_event_thumbnails(
-        selected_events + remaining_events, temp_dir, target_count=100
-    )
+    # Step 3: Extract thumbnails from events
+    thumbnails = _extract_event_thumbnails(selected_events, temp_dir)
     logger.debug(f"Successfully extracted {len(thumbnails)} thumbnails")
 
     # Step 4: Select 24 most visually distinct thumbnails
@@ -839,16 +833,10 @@ def _select_balanced_events(
         else:
             selected.extend(remaining)
 
-    # groups are ordered oldest first, so truncating unshuffled keeps only the
-    # oldest events, which are the least likely to still have images on disk
-    random.shuffle(selected)
-
     return selected[:target_count]
 
 
-def _extract_event_thumbnails(
-    events: list[Event], output_dir: str, target_count: int = 100
-) -> list[str]:
+def _extract_event_thumbnails(events: list[Event], output_dir: str) -> list[str]:
     """
     Extract a training image for each event.
 
@@ -862,9 +850,8 @@ def _extract_event_thumbnails(
     using a step ladder sized from the box/region area ratio.
 
     Args:
-        events: List of Event objects, in order of preference
+        events: List of Event objects
         output_dir: Directory to save crops
-        target_count: Number of images to extract before stopping
 
     Returns:
         List of paths to successfully extracted images
@@ -872,9 +859,6 @@ def _extract_event_thumbnails(
     image_paths = []
 
     for idx, event in enumerate(events):
-        if len(image_paths) >= target_count:
-            break
-
         try:
             img = _load_event_classification_crop(event)
             if img is None:

frigate/util/recording_coverage.py

@@ -204,12 +204,11 @@ def coverage_spans(intervals: list[CoverageInterval]) -> list[dict[str, Any]]:
 def stream_has_audio(intervals: list[CoverageInterval], main: bool) -> bool:
     """Whether a stream is audio-bearing over a coverage window.
 
-    A stream counts as audio-bearing only when one of its rows is known
-    to carry audio. A NULL row (legacy, or a segment ffprobe could not
-    read) proves nothing either way.
+    A stream counts as audio-bearing unless EVERY one of its rows reports
+    has_audio False; NULL (legacy or undetermined) counts as audio.
     """
     return any(
-        row is not None and row.has_audio is True
+        row is not None and row.has_audio is not False
         for row in ((interval.main if main else interval.sub) for interval in intervals)
     )
 

generate_api_auth_spec.py

@@ -136,33 +136,36 @@ ACCESS_NOTES = {
 }
 
 
+# Mirrors the router set wired up in frigate.api.fastapi_app.
+ROUTERS = [
+    auth.router,
+    camera.router,
+    chat.router,
+    classification.router,
+    review.router,
+    main_app.router,
+    preview.router,
+    notification.router,
+    export.router,
+    hardware.router,
+    notices.router,
+    event.router,
+    media.router,
+    motion_search.router,
+    record.router,
+    debug_replay.router,
+]
+
+
 def build_app() -> FastAPI:
     """Build a bare app with every router mounted.
 
-    This mirrors the router set wired up in frigate.api.fastapi_app. It omits
-    the global admin dependency and all runtime state; the OpenAPI route table
-    and the per-route dependencies are all we need to export and classify.
+    It omits the global admin dependency and all runtime state; the OpenAPI
+    route table and the per-route dependencies are all we need to export and
+    classify.
     """
     app = FastAPI()
-    routers = [
-        auth.router,
-        camera.router,
-        chat.router,
-        classification.router,
-        review.router,
-        main_app.router,
-        preview.router,
-        notification.router,
-        export.router,
-        hardware.router,
-        notices.router,
-        event.router,
-        media.router,
-        motion_search.router,
-        record.router,
-        debug_replay.router,
-    ]
-    for router in routers:
+    for router in ROUTERS:
         app.include_router(router)
     return app
 
@@ -318,13 +321,17 @@ def _classify_base(
 
 
 def build_access_map(
-    app: FastAPI,
     exempt_paths: set[str],
     exempt_prefixes: tuple[str, ...],
 ) -> dict[tuple[str, str], dict]:
     """Map (path, lowercase method) -> classification details."""
     access_map: dict[tuple[str, str], dict] = {}
-    for route in app.routes:
+
+    # app.routes holds opaque wrappers for included routers on newer FastAPI.
+    # The routers mount without a prefix, so their own routes carry final paths.
+    routes = [route for router in ROUTERS for route in router.routes]
+
+    for route in routes:
         if not isinstance(route, APIRoute):
             continue
         level, roles, flag = classify_route(route, exempt_paths, exempt_prefixes)
@@ -515,7 +522,7 @@ def render(spec: dict) -> str:
 def build_spec() -> tuple[dict, dict, list, list, list]:
     app = build_app()
     exempt_paths, exempt_prefixes = read_exempt_rules()
-    access_map = build_access_map(app, exempt_paths, exempt_prefixes)
+    access_map = build_access_map(exempt_paths, exempt_prefixes)
 
     spec = base_document(app.openapi())
     normalized = strip_volatile_defaults(spec)

web/e2e/specs/settings/camera-wizard-reolink.spec.ts

@@ -0,0 +1,155 @@
+/**
+ * Add-camera wizard - Reolink stream selection with the brand template.
+ *
+ * The wizard asks the camera for its resolution, then probes http-flv first
+ * above 5MP and falls back to RTSP. The Step 4 RTSP warning is only for
+ * cameras that should be on http-flv. An http-flv stream the wizard selects
+ * is registered with go2rtc through the ffmpeg module.
+ */
+
+import { test, expect } from "../../fixtures/frigate-test";
+import type { Page } from "@playwright/test";
+
+const FLV_PATH = "channel0_main.bcs";
+const RTSP_PATH = "Preview_01_main";
+const RTSP_WARNING = "Reolink RTSP is not recommended";
+const HTTP_WARNING = "Reolink HTTP streams should use FFmpeg";
+
+const FFPROBE_OK = [
+  {
+    return_code: 0,
+    stderr: [],
+    stdout: {
+      streams: [
+        {
+          codec_type: "video",
+          codec_name: "hevc",
+          width: 3840,
+          height: 2160,
+          avg_frame_rate: "15/1",
+        },
+        { codec_type: "audio", codec_name: "aac" },
+      ],
+    },
+  },
+];
+
+const FFPROBE_FAILED = [
+  { return_code: 1, stderr: ["probe failed"], stdout: "" },
+];
+
+/**
+ * Mock the camera's answers and drive the wizard to Step 3. Returns the
+ * dialog and the stream paths the wizard probed, in order.
+ */
+async function gotoStep3(
+  page: Page,
+  { protocol, flvProbes }: { protocol: string | null; flvProbes: boolean },
+) {
+  const probed: string[] = [];
+
+  await page.route("**/api/reolink/detect**", (route) =>
+    route.fulfill({ json: { success: protocol !== null, protocol } }),
+  );
+  await page.route("**/api/ffprobe**", (route) => {
+    const paths = new URL(route.request().url()).searchParams.get("paths");
+    const isFlv = !!paths?.includes(FLV_PATH);
+    probed.push(isFlv ? FLV_PATH : RTSP_PATH);
+    return route.fulfill({
+      json: isFlv && !flvProbes ? FFPROBE_FAILED : FFPROBE_OK,
+    });
+  });
+  await page.route("**/api/ffprobe/snapshot**", (route) =>
+    route.fulfill({ status: 500 }),
+  );
+
+  await page.getByRole("button", { name: /Add New Camera/i }).click();
+  const dialog = page.getByRole("dialog");
+  await expect(dialog).toBeVisible();
+
+  await dialog.getByPlaceholder(/front_door/i).fill("reolink_test_camera");
+  await dialog.getByPlaceholder("192.168.1.100").fill("192.168.1.100");
+  await dialog.getByPlaceholder("Optional").first().fill("admin");
+  await dialog.getByPlaceholder("Optional").last().fill("pw");
+  await dialog.getByText("Manual selection").click();
+  await dialog.getByRole("combobox").click();
+  await page.getByRole("option", { name: "Reolink" }).click();
+  await dialog.getByRole("button", { name: /^Continue$/i }).click();
+
+  // Step 2 tests the connection on its own, then offers Continue
+  const next = dialog.getByRole("button", { name: /^Continue$/i });
+  await expect(next).toBeEnabled({ timeout: 10_000 });
+  await next.click();
+
+  await expect(
+    dialog.getByRole("button", { name: /Add Another Stream/i }),
+  ).toBeVisible();
+  return { dialog, probed };
+}
+
+test.describe("Camera wizard Reolink stream selection @medium @mobile", () => {
+  test.beforeEach(async ({ frigateApp }) => {
+    // not in the default mock; unmocked it 500s and trips the error collector
+    await frigateApp.page.route("**/api/config/raw_paths", (route) =>
+      route.fulfill({ json: {} }),
+    );
+    await frigateApp.goto("/settings?page=cameraManagement");
+    await expect(
+      frigateApp.page.getByRole("heading", { name: /Manage Cameras/i }),
+    ).toBeVisible();
+  });
+
+  test("above 5MP keeps http-flv when it probes", async ({ frigateApp }) => {
+    const { dialog, probed } = await gotoStep3(frigateApp.page, {
+      protocol: "rtsp",
+      flvProbes: true,
+    });
+
+    expect(probed).toEqual([FLV_PATH]);
+    await expect(dialog.locator(`input[value*="${FLV_PATH}"]`)).toBeVisible();
+
+    const registered: string[] = [];
+    await frigateApp.page.route("**/api/go2rtc/streams/**", (route) => {
+      const src = new URL(route.request().url()).searchParams.get("src");
+      if (src) registered.push(src);
+      return route.fulfill({ json: {} });
+    });
+
+    await dialog.getByRole("button", { name: /^Next$/i }).click();
+    await expect(
+      dialog.getByRole("button", { name: /Save New Camera/i }),
+    ).toBeVisible();
+    await expect.poll(() => registered[0]).toMatch(/^ffmpeg:http:\/\//);
+    await expect(dialog.getByText(HTTP_WARNING)).toHaveCount(0);
+  });
+
+  test("above 5MP falls back to RTSP without a warning", async ({
+    frigateApp,
+  }) => {
+    const { dialog, probed } = await gotoStep3(frigateApp.page, {
+      protocol: "rtsp",
+      flvProbes: false,
+    });
+
+    expect(probed).toEqual([FLV_PATH, RTSP_PATH]);
+    await expect(dialog.locator(`input[value*="${RTSP_PATH}"]`)).toBeVisible();
+
+    await dialog.getByRole("button", { name: /^Next$/i }).click();
+    await expect(
+      dialog.getByRole("button", { name: /Save New Camera/i }),
+    ).toBeVisible();
+    await expect(dialog.getByText(RTSP_WARNING)).toHaveCount(0);
+  });
+
+  test("failed detection uses RTSP and warns", async ({ frigateApp }) => {
+    const { dialog, probed } = await gotoStep3(frigateApp.page, {
+      protocol: null,
+      flvProbes: true,
+    });
+
+    expect(probed).toEqual([RTSP_PATH]);
+
+    await dialog.getByRole("button", { name: /^Next$/i }).click();
+    await expect(dialog.getByText(RTSP_WARNING)).toBeVisible();
+  });
+});

web/e2e/specs/system-health.spec.ts

@@ -14,17 +14,6 @@ const NOW = Math.floor(Date.now() / 1000);
 // the fixture detector runs at 75.5 ms, above the live warning threshold
 const QUIET_STATS = { detectors: { cpu: { inference_speed: 10 } } };
 
-// the fixture has no go2rtc streams, which gives every camera a live view hint
-const RESTREAMED = {
-  go2rtc: {
-    streams: {
-      front_door: ["rtsp://x"],
-      backyard: ["rtsp://x"],
-      garage: ["rtsp://x"],
-    },
-  },
-};
-
 const ERROR_NOTICE = {
   id: "model_download_failed:yolo/model.onnx",
   kind: "model_download_failed",
@@ -62,7 +51,6 @@ test.describe("System — Health tab @medium", () => {
     frigateApp,
   }) => {
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: QUIET_STATS,
       notices: [ERROR_NOTICE, EVENT_NOTICE],
     });
@@ -96,7 +84,6 @@ test.describe("System — Health tab @medium", () => {
   for (const action of ["acknowledge", "mute"] as const) {
     test(`${action} posts and removes the row`, async ({ frigateApp }) => {
       await frigateApp.installDefaults({
-        config: RESTREAMED,
         stats: QUIET_STATS,
         notices: [EVENT_NOTICE],
       });
@@ -139,10 +126,7 @@ test.describe("System — Health tab @medium", () => {
   }
 
   test("empty state with no notices", async ({ frigateApp }) => {
-    await frigateApp.installDefaults({
-      config: RESTREAMED,
-      stats: QUIET_STATS,
-    });
+    await frigateApp.installDefaults({ stats: QUIET_STATS });
     await frigateApp.goto("/system#health");
 
     await expect(
@@ -345,7 +329,6 @@ test.describe("System — Health tab @medium", () => {
     frigateApp,
   }) => {
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: QUIET_STATS,
       notices: [ERROR_NOTICE, EVENT_NOTICE],
     });
@@ -782,7 +765,6 @@ test.describe("System — Health notices sources @medium", () => {
   test("status bar problems stay out of the list", async ({ frigateApp }) => {
     test.skip(frigateApp.isMobile, "Status bar is desktop-only");
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: {
         service: { retention_unmet: true },
         cameras: { front_door: { camera_fps: 0 } },
@@ -847,28 +829,6 @@ test.describe("System — Health notices sources @medium", () => {
     ).toBeVisible({ timeout: 15_000 });
   });
 
-  test("a camera without a go2rtc stream gets a live view hint", async ({
-    frigateApp,
-  }) => {
-    await frigateApp.installDefaults({
-      config: { go2rtc: { streams: { front_door: ["rtsp://x"] } } },
-      stats: QUIET_STATS,
-    });
-    await frigateApp.goto("/system#health");
-
-    const row = frigateApp.page.getByTestId(
-      "health-problem-config:live:no-go2rtc-stream:camera.backyard",
-    );
-    await expect(row).toBeVisible({ timeout: 15_000 });
-    await expect(row).toHaveAttribute("data-severity", "info");
-    await expect(row).toContainText("lower frame rate and no audio");
-    await expect(
-      frigateApp.page.getByTestId(
-        "health-problem-config:live:no-go2rtc-stream:camera.front_door",
-      ),
-    ).toHaveCount(0);
-  });
-
   test("a global config problem is not repeated per camera", async ({
     frigateApp,
   }) => {
@@ -933,10 +893,7 @@ test.describe("System — Health notices sources @medium", () => {
   test("empty state when stats, config, and registry are clean", async ({
     frigateApp,
   }) => {
-    await frigateApp.installDefaults({
-      config: RESTREAMED,
-      stats: QUIET_STATS,
-    });
+    await frigateApp.installDefaults({ stats: QUIET_STATS });
     await frigateApp.goto("/system#health");
 
     await expect(
@@ -1173,7 +1130,6 @@ test.describe("System — Health notices sources @medium", () => {
   }) => {
     test.skip(frigateApp.isMobile, "Status bar is desktop-only");
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: QUIET_STATS,
       notices: [EVENT_NOTICE],
     });

web/package-lock.json

@@ -9910,9 +9910,9 @@
       }
     },
     "node_modules/source-map-js": {
-      "version": "1.2.1",
-      "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.1.tgz",
-      "integrity": "sha512-UXWMKhLOwVKb728IUtQPXxfYU+usdybtUrK/8uGE8CQMvrhOpwvzDBwj0QhSL7MQc7vIsISBG8VQ8+IDQxpfQA==",
+      "version": "1.2.2",
+      "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.2.tgz",
+      "integrity": "sha512-KGj/8Y43x35aZVDtt+J4mK1hoLGHULMYfSkODJNQjNDC3oW1PqPoxMwo0pLUsWM/UEGzON/NxeHywEfNXNP3Vw==",
       "license": "BSD-3-Clause",
       "engines": {
         "node": ">=0.10.0"

web/public/locales/en/views/settings.json

@@ -1997,9 +1997,6 @@
       "genaiImageSourceRecordingsRecordDisabled": "Image source is set to 'recordings', but recording is disabled. Frigate will fall back to preview images.",
       "genaiImageSourceRecordingsRecordRuntimeDisabled": "Image source is set to 'recordings', but recording is currently turned off for this camera even though your config enables it. Frigate will fall back to preview images."
     },
-    "live": {
-      "noGo2rtcStream": "Live view for this camera is using a basic player with a lower frame rate and no audio. Set up a go2rtc stream for this camera to get smoother video and audio."
-    },
     "audio": {
       "noAudioRole": "No streams have the audio role defined. You must enable the audio role for audio detection to function."
     },

web/src/components/config-form/section-configs/live.ts

@@ -1,24 +1,8 @@
-import { isRestreamedStream } from "@/utils/liveTranscode";
 import type { SectionConfigOverrides } from "./types";
 
 const live: SectionConfigOverrides = {
   base: {
     sectionDocs: "/configuration/live",
-    messages: [
-      {
-        key: "no-go2rtc-stream",
-        health: true,
-        messageKey: "configMessages.live.noGo2rtcStream",
-        severity: "info",
-        docLink: "/configuration/live",
-        condition: (ctx) => {
-          if (ctx.level !== "camera" || !ctx.fullCameraConfig) return false;
-          return !Object.values(ctx.fullCameraConfig.live.streams).some(
-            (name) => isRestreamedStream(ctx.fullConfig, name),
-          );
-        },
-      },
-    ],
     restartRequired: [],
     fieldOrder: ["streams", "transcode", "height", "quality"],
     fieldGroups: {},

web/src/components/config-form/theme/fields/HardwarePicker.tsx

@@ -15,7 +15,6 @@ import {
   hardwareForDevices,
   MAX_DETECTORS,
   recommendedDetectorCount,
-  resolveUnitDevice,
 } from "@/utils/detectionHardware";
 
 type HardwarePickerProps = {
@@ -61,13 +60,9 @@ export function HardwarePicker({
       return [];
     }
 
-    const assigned = devices.map((device) =>
-      resolveUnitDevice(selected, device),
-    );
-
     return selected.units
       .map((unit) => unit.device)
-      .filter((device) => assigned.includes(device));
+      .filter((device) => devices.includes(device));
   }, [selected, devices]);
 
   /** Spread `count` detectors round robin over the selected units. */
@@ -205,7 +200,7 @@ export function HardwarePicker({
                 <Checkbox
                   id={`${idPrefix}-${unit.device}`}
                   className="size-5 text-white accent-white data-[state=checked]:bg-selected data-[state=checked]:text-white"
-                  checked={selectedUnits.includes(unit.device)}
+                  checked={devices.includes(unit.device)}
                   disabled={disabled || Boolean(claimedBy)}
                   onCheckedChange={(checked) =>
                     handleUnitToggle(unit.device, checked === true)

web/src/components/settings/wizard/Step2ProbeOrSnapshot.tsx

@@ -222,6 +222,7 @@ export default function Step2ProbeOrSnapshot({
             wizardData.username,
             wizardData.password,
           );
+          update.reolinkProtocol = protocol;
           if (protocol === "http-flv") {
             update.brandTemplate = "reolink";
           }
@@ -294,73 +295,72 @@ export default function Step2ProbeOrSnapshot({
     [probeUri],
   );
 
-  const generateDynamicStreamUrl = useCallback(
-    async (data: Partial<WizardFormData>): Promise<string | null> => {
+  const generateDynamicStreamUrls = useCallback(
+    async (data: Partial<WizardFormData>): Promise<string[]> => {
       const brand = CAMERA_BRANDS.find((b) => b.value === data.brandTemplate);
-      if (!brand || !data.host) return null;
+      const host = data.host;
+      if (!brand || !host) return [];
 
       let protocol = undefined;
       if (data.brandTemplate === "reolink" && data.username && data.password) {
         try {
           protocol = await detectReolinkCamera(
-            data.host,
+            host,
             data.username,
             data.password,
           );
         } catch {
-          return null;
+          return [];
         }
+        onUpdate({ reolinkProtocol: protocol });
       }
 
-      const protocolKey = protocol || "rtsp";
+      // Only some Reolink cameras above 5MP serve http-flv, so RTSP is the
+      // fallback when the http-flv stream does not probe.
+      const protocolKeys =
+        protocol === "rtsp" ? ["http-flv", "rtsp"] : [protocol || "rtsp"];
       const templates: Record<string, string> = brand.dynamicTemplates || {};
 
-      if (Object.keys(templates).includes(protocolKey)) {
-        const template =
-          templates[protocolKey as keyof typeof brand.dynamicTemplates];
-        return template
-          .replace("{username}", data.username || "")
-          .replace("{password}", data.password || "")
-          .replace("{host}", data.host);
-      }
-
-      return null;
+      return protocolKeys
+        .filter((key) => key in templates)
+        .map((key) =>
+          templates[key]
+            .replace("{username}", data.username || "")
+            .replace("{password}", data.password || "")
+            .replace("{host}", host),
+        );
     },
-    [],
+    [onUpdate],
   );
 
-  const generateStreamUrl = useCallback(
-    async (data: Partial<WizardFormData>): Promise<string> => {
+  const generateStreamUrls = useCallback(
+    async (data: Partial<WizardFormData>): Promise<string[]> => {
       if (data.brandTemplate === "other") {
-        return data.customUrl || "";
+        return data.customUrl ? [data.customUrl] : [];
       }
 
       const brand = CAMERA_BRANDS.find((b) => b.value === data.brandTemplate);
-      if (!brand || !data.host) return "";
+      if (!brand || !data.host) return [];
 
       if (brand.template === "dynamic" && "dynamicTemplates" in brand) {
-        const dynamicUrl = await generateDynamicStreamUrl(data);
-
-        if (dynamicUrl) {
-          return dynamicUrl;
-        }
-
-        return "";
+        return generateDynamicStreamUrls(data);
       }
 
-      return brand.template
-        .replace("{username}", data.username || "")
-        .replace("{password}", data.password || "")
-        .replace("{host}", data.host);
+      return [
+        brand.template
+          .replace("{username}", data.username || "")
+          .replace("{password}", data.password || "")
+          .replace("{host}", data.host),
+      ];
     },
-    [generateDynamicStreamUrl],
+    [generateDynamicStreamUrls],
   );
 
   const testConnection = useCallback(
     async (showToast = true) => {
-      const streamUrl = await generateStreamUrl(wizardData);
+      const streamUrls = await generateStreamUrls(wizardData);
 
-      if (!streamUrl) {
+      if (streamUrls.length === 0) {
         toast.error(t("cameraWizard.commonErrors.noUrl"));
         return;
       }
@@ -370,8 +370,18 @@ export default function Step2ProbeOrSnapshot({
       setTestResult(null);
 
       try {
-        setTestStatus(t("cameraWizard.step2.testing.probingMetadata"));
-        const result = await probeUri(streamUrl, true, setTestStatus);
+        let streamUrl = streamUrls[0];
+        let result: TestResult | undefined;
+
+        for (const url of streamUrls) {
+          streamUrl = url;
+          setTestStatus(t("cameraWizard.step2.testing.probingMetadata"));
+          result = await probeUri(url, true, setTestStatus);
+
+          if (result.success && result.resolution) {
+            break;
+          }
+        }
 
         if (result && result.success) {
           setTestResult(result);
@@ -383,6 +393,9 @@ export default function Step2ProbeOrSnapshot({
                 url: streamUrl,
                 roles: ["detect"] as StreamRole[],
                 testResult: result,
+                useFfmpeg:
+                  wizardData.brandTemplate === "reolink" &&
+                  streamUrl.startsWith("http://"),
               },
             ],
           });
@@ -434,7 +447,7 @@ export default function Step2ProbeOrSnapshot({
         setTestStatus("");
       }
     },
-    [wizardData, generateStreamUrl, t, onUpdate, probeUri],
+    [wizardData, generateStreamUrls, t, onUpdate, probeUri],
   );
 
   const handleContinue = useCallback(() => {

web/src/components/settings/wizard/Step4Validation.tsx

@@ -499,6 +499,7 @@ function StreamIssues({
           url: stream.url,
           roles: stream.roles,
           brand: wizardData.brandTemplate,
+          reolinkProtocol: wizardData.reolinkProtocol,
           useFfmpeg: stream.useFfmpeg,
           restream: stream.restream,
           testResult: stream.testResult,

web/src/types/cameraWizard.ts

@@ -110,6 +110,7 @@ export type WizardFormData = {
   username?: string;
   password?: string;
   brandTemplate?: CameraBrand;
+  reolinkProtocol?: "http-flv" | "rtsp" | null; // null when detection failed
   customUrl?: string;
   streams?: StreamConfig[];
   probeMode?: boolean; // true for probe, false for manual

web/src/utils/detectionHardware.ts

@@ -21,31 +21,10 @@ export function hardwareForDevices(
     return undefined;
   }
 
-  return hardware.find((entry) =>
-    devices.every((device) => resolveUnitDevice(entry, device)),
-  );
-}
-
-/**
- * The unit device string a configured device refers to.
- *
- * A config may leave the index off, such as "edgetpu:usb", which the detector
- * resolves to the first unit of that kind.
- */
-export function resolveUnitDevice(
-  entry: DetectionHardware,
-  device: string,
-): string | undefined {
-  const unitDevices = entry.units.map((unit) => unit.device);
-
-  return (
-    unitDevices.find((candidate) => candidate === device) ??
-    unitDevices.find(
-      (candidate) =>
-        candidate.startsWith(`${device}:`) ||
-        candidate.startsWith(`${device}.`),
-    )
-  );
+  return hardware.find((entry) => {
+    const known = new Set(entry.units.map((unit) => unit.device));
+    return devices.every((device) => known.has(device));
+  });
 }
 
 /**

web/src/utils/streamIssues.ts

@@ -13,6 +13,7 @@ export type StreamIssueInput = {
   url: string;
   roles: StreamRole[];
   brand?: CameraBrand;
+  reolinkProtocol?: "http-flv" | "rtsp" | null;
   useFfmpeg?: boolean;
   restream?: boolean;
   testResult?: TestResult;
@@ -96,7 +97,7 @@ export function getStreamIssues(
 
   if (input.brand === "reolink") {
     const streamUrl = input.url.toLowerCase();
-    if (streamUrl.startsWith("rtsp://")) {
+    if (streamUrl.startsWith("rtsp://") && input.reolinkProtocol !== "rtsp") {
       result.push({
         type: "warning",
         rule: "reolink-rtsp",