Compare commits

...
Author SHA1 Message Date
ryzendigo 18c23a1f61 style: ruff format record/maintainer.py 2026-03-17 17:20:24 +08:00
ryzendigo da7dd47436 fix: apply same or operator fix to review/maintainer.py
Same issue as record/maintainer.py — the condition was always true
because the bare enum value is truthy.
2026-03-17 16:11:36 +08:00
ryzendigo 413779ee2a fix: operator precedence bug in detection type check
The condition:
  topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value

evaluates as:
  (topic == DetectionTypeEnum.api.value) or (DetectionTypeEnum.lpr.value)

Since DetectionTypeEnum.lpr.value is a non-empty string (truthy), the
second operand is always True regardless of topic. The intended check
is whether topic matches either enum value:
  topic == DetectionTypeEnum.api.value or topic == DetectionTypeEnum.lpr.value
2026-03-16 14:40:40 +08:00
2 changed files with 6 additions and 2 deletions
+2 -1
View File
@@ -727,7 +727,8 @@ class RecordingMaintainer(threading.Thread):
)
)
elif (
topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value
topic == DetectionTypeEnum.api.value
or topic == DetectionTypeEnum.lpr.value
):
continue
+4 -1
View File
@@ -642,7 +642,10 @@ class ReviewSegmentMaintainer(threading.Thread):
_,
audio_detections,
) = data
elif topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value:
elif (
topic == DetectionTypeEnum.api.value
or topic == DetectionTypeEnum.lpr.value
):
(
camera,
frame_time,