remove path data from thumbnail payloads

* Make review user read status consistent with other APIs

* Validate URLs for web push endpoint

* Validate the role for a custom viewer, rate limit password changing

* Cleanup

Makefile

@@ -1,7 +1,7 @@
 default_target: local
 
 COMMIT_HASH := $(shell git log -1 --pretty=format:"%h"|tail -1)
-VERSION = 0.19.0
+VERSION = 0.18.0
 IMAGE_REPO ?= ghcr.io/blakeblackshear/frigate
 GITHUB_REF_NAME ?= $(shell git rev-parse --abbrev-ref HEAD)
 BOARDS= #Initialized empty

docs/docs/configuration/advanced/reference.md

@@ -251,17 +251,11 @@ birdseye:
   # Optional: Encoding quality of the mpeg1 feed (default: shown below)
   # 1 is the highest quality, and 31 is the lowest. Lower quality feeds utilize less CPU resources.
   quality: 8
-  # Optional: Activity types that include cameras in Birdseye (default: shown below)
+  # Optional: Mode of the view. Available options are: objects, motion, and continuous
-  # Multiple activity types can be enabled at the same time.
+  #   objects - cameras are included if they have had a tracked object within the last 30 seconds
-  mode:
+  #   motion - cameras are included if motion was detected in the last 30 seconds
-    # Optional: All cameras are included always (default: shown below)
+  #   continuous - all cameras are included always
-    continuous: False
+  mode: objects
-    # Optional: Cameras are included if motion was detected in the last 30 seconds (default: shown below)
-    motion: False
-    # Optional: Cameras are included if they have had an active tracked object within the last 30 seconds (default: shown below)
-    objects: True
-    # Optional: Cameras are included while they have a stationary tracked object (default: shown below)
-    stationary_objects: False
   # Optional: Threshold for camera activity to stop showing camera (default: shown below)
   inactivity_threshold: 30
   # Optional: Configure the birdseye layout
@@ -293,8 +287,6 @@ ffmpeg:
     detect: -threads 2 -f rawvideo -pix_fmt yuv420p
     # Optional: output args for record streams (default: shown below)
     record: preset-record-generic
-    # Optional: output args for sub stream record streams (default: the record output args above)
-    # record_sub: preset-record-generic
   # Optional: Time in seconds to wait before ffmpeg retries connecting to the camera. (default: shown below)
   # If set too low, frigate will retry a connection to the camera's stream too frequently, using up the limited streams some cameras can allow at once
   # If set too high, then if a ffmpeg crash or camera stream timeout occurs, you could potentially lose up to a maximum of retry_interval second(s) of footage
@@ -645,42 +637,6 @@ record:
       #       For example, if the camera retain mode is "motion", the segments without motion are
       #       never stored, so setting the mode to "all" here won't bring them back.
       mode: motion
-  # Optional: Sub stream recording settings
-  # Records a second, lower quality stream for quality selection during playback
-  # and extended low quality retention. Requires the record_sub role to be assigned
-  # to one of the camera's inputs.
-  sub:
-    # Optional: Enable sub stream recording (default: shown below)
-    # NOTE: Recording must also be enabled for sub stream recording to run.
-    enabled: False
-    # Optional: Continuous retention settings for sub stream recordings
-    continuous:
-      # Optional: Number of days to retain sub stream recordings regardless of tracked objects or motion (default: shown below)
-      days: 0
-    # Optional: Motion retention settings for sub stream recordings
-    motion:
-      # Optional: Number of days to retain sub stream recordings triggered by motion (default: shown below)
-      days: 0
-    # Optional: Retention settings for sub stream recordings of alerts
-    # NOTE: Pre and post capture windows are taken from the main alerts config above.
-    alerts:
-      # Required: Retention days (default: shown below)
-      days: 10
-      # Optional: Mode for retention. (default: shown below)
-      #   all - save all sub stream recording segments for alerts regardless of activity
-      #   motion - save all sub stream recording segments for alerts with any detected motion
-      #   active_objects - save all sub stream recording segments for alerts with active/moving objects
-      mode: motion
-    # Optional: Retention settings for sub stream recordings of detections
-    # NOTE: Pre and post capture windows are taken from the main detections config above.
-    detections:
-      # Required: Retention days (default: shown below)
-      days: 10
-      # Optional: Mode for retention. (default: shown below)
-      #   all - save all sub stream recording segments for detections regardless of activity
-      #   motion - save all sub stream recording segments for detections with any detected motion
-      #   active_objects - save all sub stream recording segments for detections with active/moving objects
-      mode: motion
 
 # Optional: Configuration for the snapshots written to the clips directory for each tracked object
 # Timestamp, bounding_box, crop and height settings are applied by default to API requests for snapshots.
@@ -932,7 +888,7 @@ cameras:
         # Required: the path to the stream
         # NOTE: path may include environment variables or docker secrets, which must begin with 'FRIGATE_' and be referenced in {}
         - path: rtsp://viewer:{FRIGATE_RTSP_PASSWORD}@10.0.10.10:554/cam/realmonitor?channel=1&subtype=2
-          # Required: list of roles for this stream. valid values are: audio,detect,record,record_sub
+          # Required: list of roles for this stream. valid values are: audio,detect,record
           # NOTICE: In addition to assigning the audio, detect, and record roles
           # they must also be enabled in the camera config.
           roles:

docs/docs/configuration/birdseye.md

@@ -18,14 +18,13 @@ Each camera tile in Birdseye is composed from the frames of the stream assigned
 
 ## Birdseye Behavior
 
-### Birdseye Activity Types
+### Birdseye Modes
 
-Birdseye offers independent activity types that control when cameras are shown. Multiple activity types can be enabled together.
+Birdseye offers different modes to customize which cameras show under which circumstances.
 
-- **continuous:** The camera is always included
+- **continuous:** All cameras are always included
-- **motion:** The camera is included when motion was detected within the last 30 seconds
+- **motion:** Cameras that have detected motion within the last 30 seconds are included
-- **objects:** The camera is included when an active object was tracked within the last 30 seconds
+- **objects:** Cameras that have tracked an active object within the last 30 seconds are included
-- **stationary_objects:** The camera is included while a stationary object is tracked
 
 ### Custom Birdseye Icon
 
@@ -40,30 +39,27 @@ To include a camera in Birdseye view only for specific circumstances, or exclude
 
 **Global settings:** Navigate to <NavPath path="Settings > System > Birdseye" /> to configure the default Birdseye behavior for all cameras.
 
-**Per-camera overrides:** Navigate to <NavPath path="Settings > Camera configuration > Birdseye" /> to override the activity types or disable Birdseye for a specific camera.
+**Per-camera overrides:** Navigate to <NavPath path="Settings > Camera configuration > Birdseye" /> to override the mode or disable Birdseye for a specific camera.
 
-| Field                  | Description                                                |
+| Field               | Description                                                   |
-| ---------------------- | ---------------------------------------------------------- |
+| ------------------- | ------------------------------------------------------------- |
-| **Enable Birdseye**    | Whether this camera appears in Birdseye view               |
+| **Enable Birdseye** | Whether this camera appears in Birdseye view                  |
-| **Activity types**     | Conditions that determine when to show the camera          |
+| **Tracking mode**   | When to show the camera: `continuous`, `motion`, or `objects` |
 
 </TabItem>
 <TabItem value="yaml">
 
-```yaml {8-11,13-15}
+```yaml {8-10,12-14}
 # Include all cameras by default in Birdseye view
 birdseye:
   enabled: True
-  mode:
+  mode: continuous
-    continuous: True
 
 cameras:
   front:
     # Only include the "front" camera in Birdseye view when objects are detected
     birdseye:
-      mode:
+      mode: objects
-        continuous: False
-        objects: True
   back:
     # Exclude the "back" camera from Birdseye view
     birdseye:

docs/docs/configuration/ffmpeg_presets.md

@@ -106,5 +106,3 @@ Output arguments are passed to FFmpeg after your camera source and control how r
 | preset-record-mjpeg              | Record - MJPEG Cameras          | Record an MJPEG stream              | Restreaming the MJPEG stream is recommended instead                                                                                                               |
 | preset-record-jpeg               | Record - JPEG Cameras           | Record a live JPEG                  | Restreaming the live JPEG is recommended instead                                                                                                                  |
 | preset-record-ubiquiti           | Record - Ubiquiti Cameras       | Record a Ubiquiti stream with audio | Handles Ubiquiti's non-standard audio format                                                                                                                      |
-
-These presets apply to the `record` output args. If [sub stream recording](/configuration/record#sub-stream-recording) is enabled, the same args are used for the `record_sub` role unless `output_args.record_sub` is set, which accepts the same presets and manual args.

docs/docs/configuration/genai/config.md

@@ -59,13 +59,17 @@ Running Generative AI models on CPU is not recommended, as high inference times
 
 ### Recommended Local Models
 
+#### Vision models
+
 You must use a vision-capable model with Frigate. The following models are recommended for local deployment of the `descriptions` and `chat` roles:
 
-| Model      | Notes                                                                                                                                                                |
+| Model               | Notes                                                                                                                                                                |
-| ---------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| ------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `qwen3-vl` | Strong visual and situational understanding, enhanced ability to identify smaller objects and interactions with object.                                              |
+| `qwen3-vl`          | Strong visual and situational understanding, enhanced ability to identify smaller objects and interactions with object.                                              |
-| `qwen3.6`  | Strong situational understanding, but missing DeepStack from qwen3-vl leading to worse performance for identifying objects in people's hand and other small details. |
+| `qwen3.6`/`qwen3.8` | Strong situational understanding, but missing DeepStack from qwen3-vl leading to worse performance for identifying objects in people's hand and other small details. |
-| `gemma4`   | Strong situational understanding, sometimes resorts to more vague terms like 'interacts' instead of assigning a specific action.                                     |
+| `gemma4`            | Strong situational understanding, sometimes resorts to more vague terms like 'interacts' instead of assigning a specific action.                                     |
+
+#### Embedding models
 
 The `embeddings` role needs a different kind of model. Text queries are matched against the stored image embeddings, so the model must be trained to place images and text into the same vector space. A chat or description model will still return vectors when asked, but those vectors are not trained for retrieval and text searches will return poor matches with no error to indicate why.
 

docs/docs/configuration/record.md

@@ -275,163 +275,6 @@ record:
 
 This configuration will retain recording segments that overlap with alerts and detections for 10 days. Because multiple tracked objects can reference the same recording segments, this avoids storing duplicate footage for overlapping tracked objects and reduces overall storage needs.
 
-## Sub Stream Recording
-
-In addition to the main recording stream, Frigate can record a second, lower quality stream for each camera. This serves two purposes:
-
-- **Quality selection during playback**: A quality selector (`Auto`, `Original`, or `Low`) appears in History view for cameras with sub stream recording enabled. `Original` and `Low` play only that stream's recordings. Time ranges where the selected stream has no footage are skipped during playback, and the selector notes when the selected stream has no recordings at all in the viewed time range. With `Auto` (the default), playback prefers the original quality and automatically falls back to the low quality stream when the connection cannot keep up, or for time ranges where the original recordings have expired. The selector shows each stream's video codec and audio details beneath the options; footage recorded by older Frigate versions shows no details.
-- **Extended retention**: Sub stream recordings have their own retention settings, fully independent of the main recordings. By giving the low quality recordings a longer retention period, you can keep weeks or months of low quality history using a fraction of the storage, and that history remains playable after the main recordings expire. Playback falls back to the low quality recordings automatically, and the timeline shows a muted treatment for time ranges where only low quality footage remains.
-
-### Configuring sub stream recording
-
-Sub stream recording uses the `record_sub` input role. This role can be assigned to the same input as `detect`, so in the common case where detect already uses the camera's sub stream, no additional camera connection is needed. Like the main recording stream, sub stream segments are copied directly from the camera stream without re-encoding, so the recording quality is determined by the source stream.
-
-The following examples keep 7 days of full quality continuous recordings and 60 days of low quality continuous recordings:
-
-<ConfigTabs>
-<TabItem value="ui">
-
-Navigate to <NavPath path="Settings > Camera configuration > Streams (FFmpeg)" /> and select the camera.
-
-- In **Camera inputs**, enable the **Record (Sub Stream)** role on the stream you want to record at low quality, commonly the same stream that has the **Detect** role. Only one stream may have this role, and it cannot be assigned to the same stream as the **Record** role.
-
-Navigate to <NavPath path="Settings > Camera configuration > Recording" /> and select the camera.
-
-- Set **Enable recording** to on
-- Set **Continuous retention > Retention days** to `7`
-- Set **Sub stream recording > Enable sub stream recording** to on
-- Set **Sub stream recording > Sub stream continuous retention > Retention days** to `60`
-
-The camera setup wizard also offers the **Record (Sub Stream)** role when assigning stream roles for a newly added camera.
-
-</TabItem>
-<TabItem value="yaml">
-
-```yaml
-cameras:
-  front_door:
-    ffmpeg:
-      inputs:
-        - path: rtsp://camera/main
-          roles:
-            - record
-        - path: rtsp://camera/sub
-          roles:
-            - detect
-            - record_sub
-    record:
-      enabled: true
-      continuous:
-        days: 7
-      sub:
-        enabled: true
-        continuous:
-          days: 60
-```
-
-If your camera does not provide a suitable sub stream (or the sub stream is already used at a resolution you don't want to record), you can use a go2rtc transcode as the source for `record_sub` instead:
-
-```yaml
-go2rtc:
-  streams:
-    front_door: rtsp://camera/main
-    front_door_lq: ffmpeg:front_door#video=h264#width=854#hardware
-
-cameras:
-  front_door:
-    ffmpeg:
-      inputs:
-        - path: rtsp://127.0.0.1:8554/front_door
-          input_args: preset-rtsp-restream
-          roles:
-            - detect
-            - record
-        - path: rtsp://127.0.0.1:8554/front_door_lq
-          input_args: preset-rtsp-restream
-          roles:
-            - record_sub
-    record:
-      enabled: true
-      continuous:
-        days: 7
-      sub:
-        enabled: true
-        continuous:
-          days: 60
-```
-
-</TabItem>
-</ConfigTabs>
-
-The `record.sub` config supports the same retention structure as the main recording config: `continuous`, `motion`, `alerts`, and `detections` each with their own `days` (and `mode` for alerts and detections). The pre-capture and post-capture windows for alerts and detections are taken from the main `record.alerts` and `record.detections` config. Extending `sub.alerts.days` or `sub.detections.days` beyond the main values also keeps those review items visible in the review timeline for the longer window, with playback falling back to the low quality stream once the main recordings expire.
-
-:::note
-
-Recording must be enabled (`record.enabled`) for sub stream recording to run, and Frigate will fail to start if `record.sub.enabled` is set without a `record_sub` role assigned to one of the camera's inputs.
-
-:::
-
-### How Auto picks a quality
-
-`Auto` measures throughput on every segment download and compares it against the original stream's bitrate (computed from the recorded footage itself). Playback drops to the low quality stream when any of these happen:
-
-- A freeze lasts 4 seconds (10 seconds when it starts within 2 seconds of a seek, since the seek target is rarely buffered), or freezes total 7 seconds within the last minute.
-- 3 downloads in a row measure below the original bitrate plus 10%, dropping quality before a stall ever becomes visible.
-- No first frame appears within 10 seconds, or loading fails outright.
-
-Playback returns to full quality only when measured throughput exceeds the original bitrate by 50%, checked continuously while playing the low quality stream and again at each new hour. The asymmetric thresholds (1.1x to drop, 1.5x to return) keep a borderline connection from switching back and forth.
-
-The most recent measurement is remembered on the device: a connection last measured below the original bitrate (or below 3 Mbps when the bitrate is not yet known) starts playback on the low quality stream so a first frame appears immediately, then upgrades within a few segments if the speed allows.
-
-The quality selector shows which stream Auto is currently playing and why. A browser with Data Saver enabled stays on the low quality stream, a browser that cannot decode the original stream's codec (for example H.265 without HEVC support) plays the low quality stream for that camera, and pinning `Original` or `Low` bypasses Auto entirely.
-
-### Sub stream output args
-
-By default the sub stream is recorded with the same [output args](/configuration/ffmpeg_presets#output-args-presets) as the main recording stream, so it inherits any customization made to `ffmpeg.output_args.record`. Setting `ffmpeg.output_args.record_sub` gives the sub stream its own args instead. Like all `ffmpeg` config, this can be set globally or per camera.
-
-The most common reason to set this is a pair of streams whose audio differs. Many cameras send AAC on the main stream but PCM on the sub stream, and PCM cannot be copied into an mp4 recording. Copying the main stream's audio avoids re-encoding audio that is already AAC, while the sub stream still needs to be transcoded:
-
-```yaml
-ffmpeg:
-  output_args:
-    # main stream audio is already AAC, so copy it
-    record: preset-record-generic-audio-copy
-    # sub stream audio is PCM, so transcode it to AAC
-    record_sub: preset-record-generic-audio-aac
-```
-
-Other reasons to set this are recording a sub stream whose codec needs a different preset than the main stream, such as `preset-record-mjpeg`, or forcing a matching audio sample rate across the two streams with manual args ending in `-c:a aac -ar 16000`.
-
-:::warning
-
-Avoid removing audio from only one of the two streams (for example with `-an`). When one stream has audio and the other does not, playback of time ranges that combine both qualities is silent, so stripping audio from the sub stream also silences the merged timeline.
-
-:::
-
-### Which stream do features use?
-
-As a general rule, features that read recordings prefer the main stream and fall back to the sub stream for time ranges where the main recordings have expired. Analytics features use only the main stream.
-
-| Feature                                                                                  | Stream used                                                                                                   |
-| ---------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------- |
-| Recording playback (History and Review)                                                  | Both (main preferred with sub fallback by default), or exactly one stream when a quality is selected manually |
-| Tracking details and Explore clip playback                                               | Main, falling back to sub where the main recordings have expired                                              |
-| Exports and clip downloads                                                               | Main; sub is used when no main recordings remain in the range (streams are never mixed in one file)           |
-| Frames grabbed from a recording in History (download snapshot, submit frame to Frigate+) | Main preferred, sub fallback                                                                                  |
-| Audio extraction (e.g., transcription)                                                   | Main preferred, sub fallback                                                                                  |
-| Motion search                                                                            | Main only                                                                                                     |
-| Review timeline motion data                                                              | Main only                                                                                                     |
-| Storage usage statistics                                                                 | Both streams counted, and listed separately per camera                                                        |
-
-This table covers only features that read recordings from disk. Tracked object snapshots and thumbnails (the images shown in Explore and sent with notifications, and the images submitted to Frigate+ from a tracked object) are captured live from the `detect` stream as the object is tracked, never from recordings, so sub stream recording does not affect them.
-
-### Trade-offs
-
-- Recording a second stream increases overall storage use. The increase is typically small relative to the main recordings, since the low quality stream is much smaller.
-- The go2rtc transcode approach continuously encodes the low quality stream, which uses CPU or GPU resources. This cost only applies to the transcode path; recording the camera's native sub stream does not re-encode. See the [go2rtc hardware acceleration documentation](https://github.com/AlexxIT/go2rtc?tab=readme-ov-file#source-ffmpeg) for accelerating the transcode.
-- Many camera sub streams do not include audio. If the source stream has no audio, the low quality recordings will not have audio.
-- **Matching video codecs and audio settings between the two streams gives the smoothest playback.** When playback combines both qualities on one timeline (the default `Auto` behavior: for example original quality during events with low quality in between, or low quality history after the original recordings expire) and the streams use different video codecs or audio settings, for example H.265 on the main stream and H.264 on the sub stream, or 16 kHz audio on one and 8 kHz on the other, playback still works: Frigate inserts a decoder reset at each quality transition, which can cause a barely-perceptible pause there. Configuring both streams in the camera's firmware to use the same video codec, audio codec, and sample rate makes transitions fully seamless, and a mismatched audio sample rate can also be corrected with [sub stream output args](#sub-stream-output-args). If one stream has audio and the other does not, combined time ranges play **without audio**; selecting a single quality with the playback selector always keeps that stream's audio.
-
 ## Can I have "continuous" recordings, but only at certain times?
 
 Using Frigate UI, Home Assistant, or MQTT, cameras can be automated to only record in certain situations or at certain times.

docs/docs/integrations/mqtt.md

@@ -555,21 +555,20 @@ Topic with current state of Birdseye for a camera. Published values are `ON` and
 
 ### `frigate/<camera_name>/birdseye_mode/set`
 
-Topic to set the Birdseye activity types for a camera. Send one uppercase activity type or combine multiple types with commas, for example `MOTION,OBJECTS,STATIONARY_OBJECTS`.
+Topic to set Birdseye mode for a camera. Birdseye offers different modes to customize under which circumstances the camera is shown.
 
-_Note: Changing the value from `CONTINUOUS` to non-continuous activity types will take up to 30 seconds for
+_Note: Changing the value from `CONTINUOUS` -> `MOTION | OBJECTS` will take up to 30 seconds for
 the camera to be removed from the view._
 
-| Command              | Description                                                      |
+| Command      | Description                                                       |
-| -------------------- | ---------------------------------------------------------------- |
+| ------------ | ----------------------------------------------------------------- |
-| `CONTINUOUS`         | Always included                                                  |
+| `CONTINUOUS` | Always included                                                   |
-| `MOTION`             | Shown if motion was detected within the last 30 seconds          |
+| `MOTION`     | Show when detected motion within the last 30 seconds are included |
-| `OBJECTS`            | Shown if an active object was tracked within the last 30 seconds |
+| `OBJECTS`    | Shown if an active object tracked within the last 30 seconds      |
-| `STATIONARY_OBJECTS` | Shown while a stationary object is tracked                       |
 
 ### `frigate/<camera_name>/birdseye_mode/state`
 
-Topic with the current Birdseye activity types for a camera. Multiple enabled types are published as a comma-separated value in the order `OBJECTS`, `MOTION`, `STATIONARY_OBJECTS`, `CONTINUOUS`.
+Topic with current state of the Birdseye mode for a camera. Published values are `CONTINUOUS`, `MOTION`, `OBJECTS`.
 
 ### `frigate/<camera_name>/notifications/set`
 

docs/docs/troubleshooting/cpu.md

@@ -3,7 +3,31 @@ id: cpu
 title: High CPU Usage
 ---
 
-High CPU usage can impact Frigate's performance and responsiveness. This guide outlines the most effective configuration changes to help reduce CPU consumption and optimize resource usage.
+High CPU usage can impact Frigate's performance and responsiveness. This guide explains how to interpret the CPU values Frigate reports and outlines the most effective configuration changes to help reduce CPU consumption and optimize resource usage.
+
+## Understanding Frigate's Reported CPU Usage
+
+Frigate's CPU percentages often look much higher than what the host reports. Usually both numbers are correct and are simply measured against different denominators, so confirm you actually have a problem before tuning anything.
+
+### Per-process values are relative to a single core
+
+The values Frigate reports for FFmpeg, capture, detect, detector, and other processes follow the same convention as `top`: 100% means one CPU core is fully saturated, not that the whole system is saturated. A multithreaded process such as FFmpeg can legitimately report well over 100%.
+
+Host and hypervisor tools instead report a percentage of the machine's total capacity across all cores. This includes `docker stats`, the `htop` summary, the Proxmox summary graph, the Unraid dashboard, Synology Resource Monitor, and Home Assistant's system monitor sensors. To reconcile the two:
+
+```
+host percentage ≈ (sum of Frigate's process percentages) / (number of cores)
+```
+
+On a 4 core system, an FFmpeg process reporting 100% is consuming one quarter of the machine, so the host will show roughly 25 to 30% once the remaining Frigate processes are included. That same 100% on a 16 core system is about 6%. Frigate's own warning thresholds use the per-core convention as well, so an FFmpeg process is flagged at 20% of a single core, not 20% of the system.
+
+### Instantaneous samples and averages measure different things
+
+Frigate collects stats every 15 seconds, and the `cpu` value covers only the interval since the previous collection. The `cpu_average` value in the stats API and MQTT payload is the average across the entire life of the process, and it is what the high CPU usage warnings are based on. Host dashboards generally plot data averaged over a longer window, so a single Frigate sample can show a peak that a host graph never displays. A process that has just started, such as FFmpeg after a camera reconnect, reports 0 until it has been sampled twice.
+
+### The system-wide value depends on what the container can see
+
+The system CPU value is read from `/proc/stat`. Under Docker that file belongs to the host, so the value covers the entire machine including workloads unrelated to Frigate, and it will not match `docker stats` for the Frigate container. Under an LXC container, lxcfs virtualizes `/proc/stat` and the value reflects only the cores assigned to the container. In a virtual machine, the guest sees only its assigned vCPUs while the hypervisor divides by every physical thread on the node, so guest and host percentages will not agree even when both are accurate.
 
 ## 1. Hardware Acceleration for Video Decoding
 
@@ -72,3 +96,19 @@ The model you use significantly impacts detector performance. Frigate provides d
 - Larger models (640x640): Slower inference, can sometimes have higher accuracy on very large objects that take up a majority of the frame.
 
 For more detail on picking the right size, see [Choosing a model size](../configuration/object_detectors.md#choosing-a-model-size).
+
+## 3. Reducing Detector CPU Usage
+
+**Priority: High**
+
+The **Detector CPU Usage** metric measures the CPU spent converting frames into the tensor format the model expects and post-processing the model's output. It does not include inference, so this value can be high even when you've configured a GPU, NPU, or Coral for object detection.
+
+This metric scales with how many detections per second Frigate runs and how expensive each one is to prepare. Tuning [motion detection](../configuration/motion_detection) is usually the first recommendation to reduce the number of detections. Additionally, you can:
+
+- **Lower `detect -> fps`.** 5 is the recommended value for nearly all cameras. Running at 10 doubles the frames eligible for detection and is one of the largest contributors to this metric.
+- **Use a 320x320 model.** A 640x640 model has 4 times as many pixels to transpose, convert, and copy on every inference.
+- **Prefer a model that takes integer input.** Models configured with `input_dtype: float` require each frame to be converted to float32 and normalized on the CPU first. Models taking `int` input, such as the tflite models used by the Edge TPU, skip that step.
+- **Do not match the detect resolution to the model resolution.** The detect stream should match your camera's aspect ratio, for example `1280x720`, not the model's input size. Frigate crops and scales regions of motion itself, so an oversized detect stream only adds work.
+- **Tune stationary object behavior.** Objects that never settle into a stationary state are re-detected continuously. Raising `detect -> stationary -> interval` reduces how often detection runs on objects that are already parked. See [stationary objects](../configuration/stationary_objects).
+
+Adding [more detector instances](#multiple-detector-instances) spreads this work across more CPU cores, but does not reduce the total CPU used.

docs/docs/troubleshooting/faqs.md

@@ -133,6 +133,12 @@ cameras:
       height: 720
 ```
 
+### What is the `version` key in my config file?
+
+`version` records the config format that your config was last migrated to. On startup Frigate compares it against the format the running version expects, and if it is older it copies your config to `/config/backup_config.yaml`, rewrites it to the new format, and updates `version` as the final step. A config with no `version` key is assumed to predate 0.14 and is migrated from there.
+
+Frigate manages this key for you, so do not set or edit it. Raising it makes Frigate skip migrations your config still needs, and lowering it re-runs migrations against config that has already been converted. Either can leave you with a config that no longer validates.
+
 ### Why does Frigate keep creating new tracked objects for my parked car?
 
 Stationary tracking is designed to _prevent_ this: a parked car should remain a single tracked object rather than generating new ones. If you're repeatedly getting new tracked objects for the same car, it's likely that Frigate is losing the object and re-detecting it as a new one.

docs/static/frigate-api.yaml

@@ -2308,15 +2308,15 @@ paths:
                 $ref: '#/components/schemas/HTTPValidationError'
       security:
         - frigateUserAuth: []
-      x-required-role: any
+      x-required-role: camera
-      description: '**Access:** Any authenticated user.'
+      description: '**Access:** Authenticated user with access to the referenced camera.'
   /review/summarize/start/{start_ts}/end/{end_ts}:
     post:
       tags:
         - Review
       summary: Generate Review Summary
       description: |-
-        **Access:** Admin role required.
+        **Access:** Authenticated user with access to all cameras.
 
         Use GenAI to summarize review items over a period of time.
       operationId: 
@@ -2347,8 +2347,8 @@ paths:
               schema:
                 $ref: '#/components/schemas/HTTPValidationError'
       security:
-        - frigateAdminAuth: []
+        - frigateUserAuth: []
-      x-required-role: admin
+      x-required-role: all_cameras
   /:
     get:
       tags:
@@ -2946,44 +2946,6 @@ paths:
         - frigateUserAuth: []
       x-required-role: any
       description: '**Access:** Any authenticated user.'
-  /categorized_object_names:
-    get:
-      tags:
-        - App
-      summary: Get known object names by object type
-      description: |-
-        **Access:** Any authenticated user.
-
-        Returns the sub labels and attributes this install can attach,
-            grouped by object type. Unlike /sub_labels, which reflects what has already been
-            detected, this reads the config and model files, so it covers recognized face
-            names, named license plates, custom object classification categories, and the
-            detector attributes of tracked objects.
-      operationId: categorized_object_names_categorized_object_names_get
-      parameters:
-        - name: object_type
-          in: query
-          required: false
-          schema:
-            anyOf:
-              - type: string
-              - type: 'null'
-            title: Object Type
-      responses:
-        '200':
-          description: Successful Response
-          content:
-            application/json:
-              schema: {}
-        '422':
-          description: Validation Error
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/HTTPValidationError'
-      security:
-        - frigateUserAuth: []
-      x-required-role: any
   /audio_labels:
     get:
       tags:
@@ -6022,65 +5984,6 @@ paths:
       security:
         - frigateUserAuth: []
       x-required-role: camera
-  /vod/{camera_name}/{stream}/start/{start_ts}/end/{end_ts}:
-    get:
-      tags:
-        - Media
-      summary: Vod Ts Stream
-      description: |-
-        **Access:** Authenticated user with access to the referenced camera.
-
-        Returns an HLS playlist pinned to one stream type (main or sub) for the specified timestamp-range on the specified camera. Append /master.m3u8 or /index.m3u8 for HLS playback.
-      operationId: 
-        vod_ts_stream_vod__camera_name___stream__start__start_ts__end__end_ts__get
-      parameters:
-        - name: camera_name
-          in: path
-          required: true
-          schema:
-            anyOf:
-              - type: string
-              - type: 'null'
-            title: Camera Name
-        - name: stream
-          in: path
-          required: true
-          schema:
-            $ref: '#/components/schemas/VodStreamPreference'
-        - name: start_ts
-          in: path
-          required: true
-          schema:
-            type: number
-            title: Start Ts
-        - name: end_ts
-          in: path
-          required: true
-          schema:
-            type: number
-            title: End Ts
-        - name: force_discontinuity
-          in: query
-          required: false
-          schema:
-            type: boolean
-            default: false
-            title: Force Discontinuity
-      responses:
-        '200':
-          description: Successful Response
-          content:
-            application/json:
-              schema: {}
-        '422':
-          description: Validation Error
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/HTTPValidationError'
-      security:
-        - frigateUserAuth: []
-      x-required-role: camera
   /events/{event_id}/snapshot.jpg:
     get:
       tags:
@@ -7019,63 +6922,6 @@ paths:
       security:
         - frigateUserAuth: []
       x-required-role: camera
-  /{camera_name}/recordings/coverage:
-    get:
-      tags:
-        - Recordings
-      summary: Recordings Coverage
-      description: |-
-        **Access:** Authenticated user with access to the referenced camera.
-
-        Returns merged recording coverage spans plus codec compatibility.
-
-        codecs_compatible is false only when more than one known video codec
-        appears across the range's rows, the case where the merged vod route
-        degrades to a single-stream manifest.
-      operationId: recordings_coverage__camera_name__recordings_coverage_get
-      parameters:
-        - name: camera_name
-          in: path
-          required: true
-          schema:
-            anyOf:
-              - type: string
-              - type: 'null'
-            title: Camera Name
-        - name: after
-          in: query
-          required: true
-          schema:
-            type: number
-            title: After
-        - name: before
-          in: query
-          required: true
-          schema:
-            type: number
-            title: Before
-        - name: timelines
-          in: query
-          required: false
-          schema:
-            type: boolean
-            default: false
-            title: Timelines
-      responses:
-        '200':
-          description: Successful Response
-          content:
-            application/json:
-              schema: {}
-        '422':
-          description: Validation Error
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/HTTPValidationError'
-      security:
-        - frigateUserAuth: []
-      x-required-role: camera
   /{camera_name}/recordings:
     get:
       tags:
@@ -7263,7 +7109,9 @@ paths:
               schema:
                 $ref: '#/components/schemas/DebugReplayStartResponse'
         '400':
-          description: Invalid camera, time range, or no recordings
+          description: Invalid camera or time range
+        '404':
+          description: No recordings in the requested time range
         '409':
           description: A replay session is already active
         '422':
@@ -9057,17 +8905,6 @@ components:
         - msg
         - type
       title: ValidationError
-    VodStreamPreference:
-      type: string
-      enum:
-        - main
-        - sub
-      title: VodStreamPreference
-      description: |-
-        Stream pin for the path-segment VOD route.
-
-        nginx-vod derives its mapping fetch URI from the playlist URL path
-        (query params are dropped), so the preference must be a path segment.
   securitySchemes:
     frigateAdminAuth:
       type: apiKey

frigate/api/app.py

@@ -71,7 +71,6 @@ from frigate.util.config import (
     find_config_file,
     redact_credential,
 )
-from frigate.util.object_names import get_categorized_object_names
 from frigate.util.schema import get_config_schema
 from frigate.util.services import (
     get_nvidia_driver_info,
@@ -1314,28 +1313,6 @@ def get_sub_labels(
     return JSONResponse(content=sub_labels)
 
 
-@router.get(
-    "/categorized_object_names",
-    dependencies=[Depends(allow_any_authenticated())],
-    summary="Get known object names by object type",
-    description="""Returns the sub labels and attributes this install can attach,
-    grouped by object type. Unlike /sub_labels, which reflects what has already been
-    detected, this reads the config and model files, so it covers recognized face
-    names, named license plates, custom object classification categories, and the
-    detector attributes of tracked objects.""",
-)
-def categorized_object_names(
-    request: Request,
-    object_type: str | None = None,
-    allowed_cameras: list[str] = Depends(get_allowed_cameras_for_filter),
-):
-    return JSONResponse(
-        content=get_categorized_object_names(
-            request.app.frigate_config, allowed_cameras, object_type
-        )
-    )
-
-
 @router.get("/audio_labels", dependencies=[Depends(allow_any_authenticated())])
 def get_audio_labels():
     labels = load_labels("/audio-labelmap.txt", prefill=521)

frigate/api/auth.py

@@ -83,7 +83,6 @@ def require_admin_by_default():
         "/nvinfo",
         "/labels",
         "/sub_labels",
-        "/categorized_object_names",
         "/plus/models",
         "/recognized_license_plates",
         "/timeline",
@@ -972,6 +971,7 @@ def delete_user(request: Request, username: str):
     summary="Update user password",
     description="Updates a user's password. Users can only change their own password unless they have admin role. Requires the current password to verify identity for non-admin users. Password must be at least 12 characters long. If user changes their own password, a new JWT cookie is automatically issued.",
 )
+@limiter.limit(limit_value=rateLimiter.get_limit)
 async def update_password(
     request: Request,
     username: str,
@@ -985,10 +985,11 @@ async def update_password(
     current_username = current_user.get("username")
     current_role = current_user.get("role")
 
-    # viewers can only change their own password
+    # Only admins may target another account. This has to cover every non-admin
-    if current_role == "viewer" and current_username != username:
+    # role rather than just viewer, since custom roles are arbitrary names
+    if current_role != "admin" and current_username != username:
         raise HTTPException(
-            status_code=403, detail="Viewers can only update their own password"
+            status_code=403, detail="Users can only update their own password"
         )
 
     HASH_ITERATIONS = request.app.frigate_config.auth.hash_iterations
@@ -1252,3 +1253,23 @@ async def get_allowed_cameras_for_filter(request: Request):
     all_camera_names = set(request.app.frigate_config.cameras.keys())
     roles_dict = request.app.frigate_config.auth.roles
     return User.get_allowed_cameras(role, roles_dict, all_camera_names)
+
+
+async def require_full_camera_access(
+    request: Request,
+    allowed_cameras: list[str] = Depends(get_allowed_cameras_for_filter),
+):
+    """Dependency for endpoints returning data that spans every camera.
+
+    Some responses cannot be meaningfully scoped to a subset of cameras, so
+    rather than filter them the endpoint is limited to callers who can already
+    see every camera. Admin and viewer always qualify; a custom role qualifies
+    only when its camera list covers all configured cameras.
+    """
+    all_camera_names = set(request.app.frigate_config.cameras.keys())
+
+    if not all_camera_names.issubset(allowed_cameras):
+        raise HTTPException(
+            status_code=403,
+            detail="Access to all cameras is required for this endpoint",
+        )

frigate/api/camera.py

@@ -651,32 +651,6 @@ async def _connect_onvif_camera(
     raise first_error
 
 
-def _supports_continuous_pan_tilt(nodes) -> bool:
-    """Whether any PTZ node advertises continuous pan/tilt velocity.
-
-    The web UI's directional controls issue ContinuousMove with a PanTilt
-    velocity, so continuous pan/tilt is what makes those controls usable. This
-    is intentionally narrower than ptz_supported, which is true for any device
-    exposing the ONVIF PTZ service - including zoom/focus-only varifocal lenses.
-    """
-    for node in nodes or []:
-        spaces = getattr(node, "SupportedPTZSpaces", None) or (
-            node.get("SupportedPTZSpaces") if isinstance(node, dict) else None
-        )
-        if spaces is None:
-            continue
-
-        continuous = getattr(spaces, "ContinuousPanTiltVelocitySpace", None) or (
-            spaces.get("ContinuousPanTiltVelocitySpace")
-            if isinstance(spaces, dict)
-            else None
-        )
-        if continuous:
-            return True
-
-    return False
-
-
 @router.get(
     "/onvif/probe",
     dependencies=[Depends(require_role(["admin"]))],
@@ -834,7 +808,6 @@ async def onvif_probe(
 
         # Check PTZ support and capabilities
         ptz_supported = False
-        pan_tilt_supported = False
         presets_count = 0
         autotrack_supported = False
 
@@ -868,15 +841,6 @@ async def onvif_probe(
                     logger.debug(f"Failed to get presets: {e}")
                     presets_count = 0
 
-            # Check for real (continuous) pan/tilt, which the UI controls need
-            if ptz_supported:
-                try:
-                    nodes = await ptz_service.GetNodes()
-                    pan_tilt_supported = _supports_continuous_pan_tilt(nodes)
-                    logger.debug(f"Continuous pan/tilt supported: {pan_tilt_supported}")
-                except Exception as e:
-                    logger.debug(f"Failed to read PTZ nodes for pan/tilt support: {e}")
-
             # Check for autotracking support - requires both FOV relative movement and MoveStatus
             if ptz_supported and first_profile_token and ptz_config_token:
                 # First check for FOV relative movement support
@@ -996,7 +960,6 @@ async def onvif_probe(
             "firmware_version": device_info["firmware_version"],
             "profiles_count": profiles_count,
             "ptz_supported": ptz_supported,
-            "pan_tilt_supported": pan_tilt_supported,
             "presets_count": presets_count,
             "autotrack_supported": autotrack_supported,
         }

frigate/api/chat.py

@@ -50,7 +50,6 @@ from frigate.jobs.vlm_watch import (
     stop_vlm_watch_job,
 )
 from frigate.models import Event
-from frigate.util.object_names import get_categorized_object_names
 
 logger = logging.getLogger(__name__)
 
@@ -540,11 +539,6 @@ async def execute_tool(
     if tool_name == "search_objects":
         return await _execute_search_objects(request, arguments, allowed_cameras)
 
-    if tool_name == "get_categorized_object_names":
-        return JSONResponse(
-            content=_execute_get_categorized_object_names(request, allowed_cameras)
-        )
-
     if tool_name == "find_similar_objects":
         result = await _execute_find_similar_objects(
             request, arguments, allowed_cameras
@@ -597,7 +591,7 @@ async def _execute_get_live_context(
 
     try:
         frame_processor = request.app.detected_frames_processor
-        camera_state = frame_processor.get_camera_state(camera)
+        camera_state = frame_processor.camera_states.get(camera)
 
         if camera_state is None:
             return {
@@ -661,7 +655,7 @@ async def _get_live_frame_image_url(
         return None
     try:
         frame_processor = request.app.detected_frames_processor
-        if frame_processor.get_camera_state(camera) is None:
+        if camera not in frame_processor.camera_states:
             return None
         frame = frame_processor.get_current_frame(camera, {})
         if frame is None:
@@ -723,21 +717,6 @@ async def _execute_set_camera_state(
     return {"success": True, "camera": camera, "feature": feature, "value": value}
 
 
-def _execute_get_categorized_object_names(
-    request: Request,
-    allowed_cameras: list[str],
-) -> dict[str, Any]:
-    names = get_categorized_object_names(request.app.frigate_config, allowed_cameras)
-
-    if not names:
-        return {
-            "names": {},
-            "message": "No names configured; search by label or semantic_query.",
-        }
-
-    return {"names": names}
-
-
 async def _execute_tool_internal(
     tool_name: str,
     arguments: dict[str, Any],
@@ -762,8 +741,6 @@ async def _execute_tool_internal(
         except (json.JSONDecodeError, AttributeError) as e:
             logger.warning(f"Failed to extract tool result: {e}")
             return {"error": "Failed to parse tool result"}
-    elif tool_name == "get_categorized_object_names":
-        return _execute_get_categorized_object_names(request, allowed_cameras)
     elif tool_name == "find_similar_objects":
         return await _execute_find_similar_objects(request, arguments, allowed_cameras)
     elif tool_name == "set_camera_state":
@@ -796,8 +773,8 @@ async def _execute_tool_internal(
     else:
         logger.error(
             "Tool call failed: unknown tool %r. Expected one of: search_objects, find_similar_objects, "
-            "get_categorized_object_names, get_live_context, start_camera_watch, stop_camera_watch, "
+            "get_live_context, start_camera_watch, stop_camera_watch, get_profile_status, get_recap. "
-            "get_profile_status, get_recap. Arguments received: %s",
+            "Arguments received: %s",
             tool_name,
             json.dumps(arguments),
         )

frigate/api/debug_replay.py

@@ -13,6 +13,7 @@ from frigate.api.auth import require_role
 from frigate.api.defs.tags import Tags
 from frigate.jobs.debug_replay import (
     ExportDebugReplaySource,
+    NoRecordingsError,
     RecordingDebugReplaySource,
     start_debug_replay_job,
 )
@@ -74,7 +75,8 @@ class DebugReplayStopResponse(BaseModel):
     response_model=DebugReplayStartResponse,
     status_code=202,
     responses={
-        400: {"description": "Invalid camera, time range, or no recordings"},
+        400: {"description": "Invalid camera or time range"},
+        404: {"description": "No recordings in the requested time range"},
         409: {"description": "A replay session is already active"},
     },
     dependencies=[Depends(require_role(["admin"]))],
@@ -113,6 +115,14 @@ async def start_debug_replay(request: Request, body: DebugReplayStartBody):
             },
             status_code=409,
         )
+    except NoRecordingsError:
+        return JSONResponse(
+            content={
+                "success": False,
+                "message": "No recordings found in the selected time range",
+            },
+            status_code=404,
+        )
     except ValueError:
         logger.exception("Rejected debug replay start request")
         return JSONResponse(

frigate/api/event.py

@@ -1313,7 +1313,7 @@ async def set_sub_label(
     if request.app.detected_frames_processor:
         tracked_obj: TrackedObject = None
 
-        for state in request.app.detected_frames_processor.get_camera_states():
+        for state in request.app.detected_frames_processor.camera_states.values():
             tracked_obj = state.tracked_objects.get(event_id)
 
             if tracked_obj is not None:
@@ -1372,7 +1372,7 @@ async def set_plate(
     if request.app.detected_frames_processor:
         tracked_obj: TrackedObject = None
 
-        for state in request.app.detected_frames_processor.get_camera_states():
+        for state in request.app.detected_frames_processor.camera_states.values():
             tracked_obj = state.tracked_objects.get(event_id)
 
             if tracked_obj is not None:

frigate/api/media.py

@@ -8,7 +8,6 @@ import os
 import subprocess as sp
 import time
 from datetime import UTC, datetime, timedelta
-from enum import Enum
 from pathlib import Path as FilePath
 from typing import Any
 from urllib.parse import unquote
@@ -40,9 +39,8 @@ from frigate.config.camera.snapshots import SnapshotsConfig
 from frigate.const import (
     CACHE_DIR,
     INSTALL_DIR,
+    MAX_SEGMENT_DURATION,
     PREVIEW_FRAME_TYPE,
-    STREAM_TYPE_MAIN,
-    STREAM_TYPE_SUB,
 )
 from frigate.models import Event, Previews, Recordings, Regions, ReviewSegment
 from frigate.output.preview import get_most_recent_preview_frame
@@ -54,34 +52,12 @@ from frigate.util.file import (
     load_event_snapshot_image,
 )
 from frigate.util.image import get_image_from_recording, get_image_quality_params
+from frigate.util.media import get_keyframe_before
 from frigate.util.object import create_empty_regions_grid
-from frigate.util.recording_coverage import (
-    build_spans,
-    null_audio_glitches,
-    plan_clip,
-    resolve_coverage,
-    stream_has_audio,
-)
 
 logger = logging.getLogger(__name__)
 
 
-# must match the patched MAX_CLIPS in docker/main/build_nginx.sh; a
-# normal hour needs ~360, one clip per recording file
-NGINX_VOD_MAX_CLIPS = 1080
-
-
-class VodStreamPreference(str, Enum):
-    """Stream pin for the path-segment VOD route.
-
-    nginx-vod derives its mapping fetch URI from the playlist URL path
-    (query params are dropped), so the preference must be a path segment.
-    """
-
-    main = STREAM_TYPE_MAIN
-    sub = STREAM_TYPE_SUB
-
-
 router = APIRouter(tags=[Tags.media])
 
 
@@ -343,7 +319,7 @@ async def get_snapshot_from_recording(
                 & (frame_time <= Recordings.end_time)
             )
             .where(Recordings.camera == camera_name)
-            .order_by(Recordings.stream_type.asc(), Recordings.start_time.desc())
+            .order_by(Recordings.start_time.desc())
             .limit(1)
             .get()
         )
@@ -362,7 +338,7 @@ async def get_snapshot_from_recording(
                     & (frame_time <= Recordings.end_time)
                 )
                 .where(Recordings.camera == camera_name)
-                .order_by(Recordings.stream_type.asc(), Recordings.start_time.desc())
+                .order_by(Recordings.start_time.desc())
                 .limit(1)
                 .get()
             )
@@ -422,7 +398,7 @@ async def submit_recording_snapshot_to_plus(
             (frame_time >= Recordings.start_time) & (frame_time <= Recordings.end_time)
         )
         .where(Recordings.camera == camera_name)
-        .order_by(Recordings.stream_type.asc(), Recordings.start_time.desc())
+        .order_by(Recordings.start_time.desc())
         .limit(1)
     )
 
@@ -496,29 +472,20 @@ async def recording_clip(
                         FilePath(file_path).unlink(missing_ok=True)
                     break
 
-    def get_clip_query(stream_type: str):
+    recordings = (
-        return (
+        Recordings.select(
-            Recordings.select(
+            Recordings.path,
-                Recordings.path,
+            Recordings.start_time,
-                Recordings.start_time,
+            Recordings.end_time,
-                Recordings.end_time,
-            )
-            .where(
-                (Recordings.start_time.between(start_ts, end_ts))
-                | (Recordings.end_time.between(start_ts, end_ts))
-                | ((start_ts > Recordings.start_time) & (end_ts < Recordings.end_time))
-            )
-            .where(Recordings.camera == camera_name)
-            .where(Recordings.stream_type == stream_type)
-            .order_by(Recordings.start_time.asc())
         )
-
+        .where(
-    # never mix streams in one concat; use main when available and
+            (Recordings.start_time.between(start_ts, end_ts))
-    # fall back to sub for expired-main history
+            | (Recordings.end_time.between(start_ts, end_ts))
-    recordings = get_clip_query(STREAM_TYPE_MAIN)
+            | ((start_ts > Recordings.start_time) & (end_ts < Recordings.end_time))
-
+        )
-    if recordings.count() == 0:
+        .where(Recordings.camera == camera_name)
-        recordings = get_clip_query(STREAM_TYPE_SUB)
+        .order_by(Recordings.start_time.asc())
+    )
 
     if recordings.count() == 0:
         return JSONResponse(
@@ -582,52 +549,17 @@ async def recording_clip(
     )
 
 
-def _build_vod_clip(
+@router.get(
-    row: Any, start: float, end: float
+    "/vod/{camera_name}/start/{start_ts}/end/{end_ts}",
-) -> tuple[dict[str, Any], int] | None:
+    dependencies=[Depends(require_camera_access)],
-    """Build one nginx-vod clip dict + duration (ms) for a recording row trimmed to [start, end).
+    description="Returns an HLS playlist for the specified timestamp-range on the specified camera. Append /master.m3u8 or /index.m3u8 for HLS playback.",
-
+)
-    Realization comes entirely from the shared plan_clip, so the coverage
+async def vod_ts(
-    endpoint's realized timelines match this manifest by construction.
-    """
-    plan = plan_clip(row, start, end)
-
-    if plan.skipped:
-        return None
-
-    clip: dict[str, Any] = {"type": "source", "path": row.path}
-    if plan.clip_from_ms is not None:
-        clip["clipFrom"] = plan.clip_from_ms
-    clip["keyFrameDurations"] = [plan.duration_ms]
-    logger.debug(
-        "VOD: added clip %s duration_ms=%s clipFrom=%s",
-        row.path,
-        plan.duration_ms,
-        clip.get("clipFrom"),
-    )
-    return clip, plan.duration_ms
-
-
-async def _vod_response(
     camera_name: str,
     start_ts: float,
     end_ts: float,
     force_discontinuity: bool = False,
-    stream_preference: str | None = None,
+):
-) -> JSONResponse:
-    """Build an nginx-vod mapping JSON for a camera over a timestamp range.
-
-    Always a single-sequence mapping; quality selection happens in the
-    frontend by choosing between this route and the stream-pinned routes.
-
-    Args:
-        camera_name: The camera to build the mapping for
-        start_ts: Range start as a unix timestamp
-        end_ts: Range end as a unix timestamp
-        force_discontinuity: Emit HLS discontinuity markers between clips
-        stream_preference: Pin the manifest to one stream type ("main" or
-            "sub"), serving only that stream's recordings
-    """
     logger.debug(
         "VOD: Generating VOD for %s from %s to %s with force_discontinuity=%s",
         camera_name,
@@ -635,85 +567,104 @@ async def _vod_response(
         end_ts,
         force_discontinuity,
     )
-    intervals = resolve_coverage(camera_name, start_ts, end_ts)
+    recordings = (
-
+        Recordings.select(
-    # rows contradicting their stream's audio composition are
+            Recordings.path,
-    # truncated-shutdown glitches
+            Recordings.duration,
-    main_audio = stream_has_audio(intervals, main=True)
+            Recordings.end_time,
-    sub_audio = stream_has_audio(intervals, main=False)
+            Recordings.start_time,
-
+        )
-    spans = build_spans(
+        .where(
-        null_audio_glitches(intervals, main_audio, sub_audio),
+            Recordings.start_time.between(start_ts, end_ts)
-        stream_preference,
+            | Recordings.end_time.between(start_ts, end_ts)
+            | ((start_ts > Recordings.start_time) & (end_ts < Recordings.end_time))
+        )
+        .where(Recordings.camera == camera_name)
+        .order_by(Recordings.start_time.asc())
+        .iterator()
     )
 
-    durations: list[int] = []
+    clips = []
-    clips: list[dict[str, Any]] = []
+    durations = []
-    # gathered after glitch-nulling and span building, so the policy
+    min_duration_ms = 100  # Minimum 100ms to ensure at least one video frame
-    # decisions below reflect the manifest's real contents
+    max_duration_ms = MAX_SEGMENT_DURATION * 1000
-    video_codecs: set[str] = set()
+
-    audio_presence: set[bool] = set()
+    recording: Recordings
-    audio_params: set[tuple[str | None, int | None]] = set()
+    for recording in recordings:
-    span_streams: set[bool] = set()
-    for row, span_start, span_end, span_is_main in spans:
         logger.debug(
             "VOD: processing recording: %s start=%s end=%s duration=%s",
-            row.path,
+            recording.path,
-            row.start_time,
+            recording.start_time,
-            row.end_time,
+            recording.end_time,
-            row.duration,
+            recording.duration,
         )
-        built = _build_vod_clip(row, span_start, span_end)
 
-        if built is None:
+        clip = {"type": "source", "path": recording.path}
+        duration = int(recording.duration * 1000)
+
+        # adjust start offset if start_ts is after recording.start_time
+        if start_ts > recording.start_time:
+            inpoint = int((start_ts - recording.start_time) * 1000)
+            clip["clipFrom"] = inpoint
+            duration -= inpoint
+            logger.debug(
+                "VOD: applied clipFrom %sms to %s",
+                inpoint,
+                recording.path,
+            )
+
+        # adjust end if recording.end_time is after end_ts
+        if recording.end_time > end_ts:
+            duration -= int((recording.end_time - end_ts) * 1000)
+
+        # nginx-vod-module pushes clipFrom forward to the next keyframe,
+        # which can leave too few frames and produce an empty/unplayable
+        # segment. Snap clipFrom back to the preceding keyframe so the
+        # segment always starts with a decodable frame.
+        if "clipFrom" in clip:
+            keyframe_ms = get_keyframe_before(recording.path, clip["clipFrom"])
+            if keyframe_ms is not None:
+                gained = clip["clipFrom"] - keyframe_ms
+                clip["clipFrom"] = keyframe_ms
+                duration += gained
+                logger.debug(
+                    "VOD: snapped clipFrom to keyframe at %sms for %s, duration now %sms",
+                    keyframe_ms,
+                    recording.path,
+                    duration,
+                )
+            else:
+                # could not read keyframes, remove clipFrom to use full recording
+                logger.debug(
+                    "VOD: no keyframe info for %s, removing clipFrom to use full recording",
+                    recording.path,
+                )
+                del clip["clipFrom"]
+                duration = int(recording.duration * 1000)
+                if recording.end_time > end_ts:
+                    duration -= int((recording.end_time - end_ts) * 1000)
+
+        if duration < min_duration_ms:
+            # skip if the clip has no valid duration (too short to contain frames)
+            logger.debug(
+                "VOD: skipping recording %s - resulting duration %sms too short",
+                recording.path,
+                duration,
+            )
             continue
 
-        clips.append(built[0])
+        if min_duration_ms <= duration < max_duration_ms:
-        durations.append(built[1])
+            clip["keyFrameDurations"] = [duration]
-        span_streams.add(span_is_main)
+            clips.append(clip)
-        if row.video_codec is not None:
+            durations.append(duration)
-            video_codecs.add(row.video_codec)
+            logger.debug(
-        audio_presence.add(row.has_audio is not False)
+                "VOD: added clip %s duration_ms=%s clipFrom=%s",
-        # legacy rows contribute no signature, so uniformly-unknown
+                recording.path,
-        # history keeps the legacy shape
+                duration,
-        if row.has_audio is not False and (
+                clip.get("clipFrom"),
-            row.audio_codec is not None or row.audio_rate is not None
+            )
-        ):
+        else:
-            audio_params.add((row.audio_codec, row.audio_rate))
+            logger.warning(f"Recording clip is missing or empty: {recording.path}")
-
-    # nginx-vod requires a uniform track count per sequence, and adding or
-    # removing an audio track across an MSE discontinuity is unproven
-    if len(audio_presence) > 1:
-        logger.debug(
-            "VOD: %s mixes audio-bearing and audio-less recordings between "
-            "%s and %s; serving the range without audio",
-            camera_name,
-            start_ts,
-            end_ts,
-        )
-        for clip in clips:
-            clip["tracks"] = "v"
-
-    # discontinuity mode emits per-clip init segments, letting the decoder
-    # reconfigure at each boundary. Stream type counts as a signature of
-    # its own: the two encoders differ in SPS/PPS even when codec name and
-    # audio params match, and a single-init manifest then decode-fails on
-    # players that only configure from the init segment (iOS)
-    use_discontinuity = (
-        len(video_codecs) > 1 or len(audio_params) > 1 or len(span_streams) > 1
-    )
-    if use_discontinuity:
-        logger.debug(
-            "VOD: %s mixes media signatures between %s and %s (video codecs "
-            "%s, audio params %s, streams %s); serving a discontinuity "
-            "manifest with per-clip init segments",
-            camera_name,
-            start_ts,
-            end_ts,
-            sorted(video_codecs),
-            sorted(audio_params, key=str),
-            sorted(span_streams),
-        )
 
     if not clips:
         logger.error(
@@ -727,49 +678,16 @@ async def _vod_response(
             status_code=404,
         )
 
-    if len(clips) > NGINX_VOD_MAX_CLIPS:
-        logger.warning(
-            "VOD: %s needs %d clips between %s and %s, exceeding nginx's "
-            "limit of %d; playback of this range will fail. This usually "
-            "means the camera produced abnormally short recording segments "
-            "(check the stream's timestamps)",
-            camera_name,
-            len(clips),
-            start_ts,
-            end_ts,
-            NGINX_VOD_MAX_CLIPS,
-        )
-
     hour_ago = datetime.now() - timedelta(hours=1)
-    content = {
+    return JSONResponse(
-        "cache": hour_ago.timestamp() > start_ts,
+        content={
-        "discontinuity": force_discontinuity or use_discontinuity,
+            "cache": hour_ago.timestamp() > start_ts,
-        "consistentSequenceMediaInfo": True,
+            "discontinuity": force_discontinuity,
-        "durations": durations,
+            "consistentSequenceMediaInfo": True,
-        # aligns segments to recording file boundaries
+            "durations": durations,
-        "segment_duration": max(durations),
+            "segment_duration": max(durations),
-        "sequences": [{"clips": clips}],
+            "sequences": [{"clips": clips}],
-    }
+        }
-    if use_discontinuity:
-        # clip-indexed naming is what makes nginx-vod emit per-clip
-        # EXT-X-MAP outside of its live mode
-        content["initialClipIndex"] = 1
-    return JSONResponse(content=content)
-
-
-@router.get(
-    "/vod/{camera_name}/start/{start_ts}/end/{end_ts}",
-    dependencies=[Depends(require_camera_access)],
-    description="Returns an HLS playlist for the specified timestamp-range on the specified camera. Append /master.m3u8 or /index.m3u8 for HLS playback.",
-)
-async def vod_ts(
-    camera_name: str,
-    start_ts: float,
-    end_ts: float,
-    force_discontinuity: bool = False,
-):
-    return await _vod_response(
-        camera_name, start_ts, end_ts, force_discontinuity=force_discontinuity
     )
 
 
@@ -858,43 +776,7 @@ async def vod_clip(
     start_ts: float,
     end_ts: float,
 ):
-    # the tracking-details player corrects its timeline from
+    return await vod_ts(camera_name, start_ts, end_ts, force_discontinuity=True)
-    # sequences[0].clips[0].clipFrom
-    return await _vod_response(
-        camera_name,
-        start_ts,
-        end_ts,
-        force_discontinuity=True,
-    )
-
-
-# registered after /vod/clip/... on purpose: both routes are six path
-# segments, Starlette matches structurally in registration order, and the
-# enum validation on {stream} would otherwise 422 every /vod/clip request
-@router.get(
-    "/vod/{camera_name}/{stream}/start/{start_ts}/end/{end_ts}",
-    dependencies=[Depends(require_camera_access)],
-    description="Returns an HLS playlist pinned to one stream type (main or sub) for the specified timestamp-range on the specified camera. Append /master.m3u8 or /index.m3u8 for HLS playback.",
-)
-async def vod_ts_stream(
-    camera_name: str,
-    stream: VodStreamPreference,
-    start_ts: float,
-    end_ts: float,
-    force_discontinuity: bool = False,
-):
-    """VOD for a timestamp range pinned to one stream type.
-
-    How the frontend selects quality, now that mappings are always
-    single-sequence.
-    """
-    return await _vod_response(
-        camera_name,
-        start_ts,
-        end_ts,
-        force_discontinuity=force_discontinuity,
-        stream_preference=stream.value,
-    )
 
 
 @router.get(
@@ -938,7 +820,7 @@ async def event_snapshot(
         # see if the object is currently being tracked
         try:
             camera_states: list[CameraState] = (
-                request.app.detected_frames_processor.get_camera_states()
+                request.app.detected_frames_processor.camera_states.values()
             )
             for camera_state in camera_states:
                 if event_id in camera_state.tracked_objects:
@@ -1016,7 +898,7 @@ async def event_thumbnail(
     if thumbnail_bytes is None:
         # see if the object is currently being tracked
         try:
-            camera_states = request.app.detected_frames_processor.get_camera_states()
+            camera_states = request.app.detected_frames_processor.camera_states.values()
             for camera_state in camera_states:
                 if event_id in camera_state.tracked_objects:
                     tracked_obj = camera_state.tracked_objects.get(event_id)
@@ -1245,7 +1127,7 @@ async def event_snapshot_clean(request: Request, event_id: str, download: bool =
             # see if the object is currently being tracked
             try:
                 camera_states = (
-                    request.app.detected_frames_processor.get_camera_states()
+                    request.app.detected_frames_processor.camera_states.values()
                 )
                 for camera_state in camera_states:
                     if event_id in camera_state.tracked_objects:

frigate/api/notification.py

@@ -1,8 +1,10 @@
 """Notification apis."""
 
+import ipaddress
 import logging
 import os
 from typing import Any
+from urllib.parse import urlparse
 
 from cryptography.hazmat.primitives import serialization
 from fastapi import APIRouter, Depends, Request
@@ -19,6 +21,95 @@ logger = logging.getLogger(__name__)
 
 router = APIRouter(tags=[Tags.notifications])
 
+# Push endpoints are opaque URLs but stay well under this in practice
+MAX_ENDPOINT_LENGTH = 2048
+
+# Suffixes that only ever resolve on the local network
+INTERNAL_HOST_SUFFIXES = (".local", ".localdomain", ".internal", ".home.arpa")
+
+
+def _validate_push_endpoint(endpoint: Any) -> str | None:
+    """Return a reason the endpoint is unusable, or None when it is valid.
+
+    Subscriptions are issued by the browser vendor's push service, so a valid
+    endpoint is always a public https URL. Anything else is either a broken
+    registration or an attempt to aim the notification sender somewhere it
+    should not reach.
+    """
+    if not isinstance(endpoint, str) or not endpoint:
+        return "endpoint must be a url"
+
+    if len(endpoint) > MAX_ENDPOINT_LENGTH:
+        return "endpoint is too long"
+
+    try:
+        parsed = urlparse(endpoint)
+        port = parsed.port
+    except ValueError:
+        return "endpoint is not a valid url"
+
+    if parsed.scheme != "https":
+        return "endpoint must use https"
+
+    if parsed.username or parsed.password:
+        return "endpoint must not include credentials"
+
+    if port is not None and port != 443:
+        return "endpoint must use the default https port"
+
+    hostname = parsed.hostname
+
+    if not hostname:
+        return "endpoint must include a hostname"
+
+    try:
+        address = ipaddress.ip_address(hostname)
+    except ValueError:
+        address = None
+
+    if address is not None:
+        # A push service is never reachable at an address only this network can
+        # route, so anything non-global is a misconfiguration at best
+        if not address.is_global:
+            return "endpoint must not use a private address"
+    elif hostname == "localhost" or "." not in hostname:
+        return "endpoint must use a fully qualified hostname"
+    elif hostname.endswith(INTERNAL_HOST_SUFFIXES):
+        return "endpoint must not use an internal hostname"
+
+    # The subscription token lives in the path, and webpush.py assumes there is
+    # a separator after the host when it builds the VAPID audience
+    if len(parsed.path) <= 1:
+        return "endpoint must include a subscription path"
+
+    return None
+
+
+def _validate_subscription(sub: Any) -> str | None:
+    """Return a reason the subscription is unusable, or None when it is valid."""
+    if not isinstance(sub, dict):
+        return "subscription must be an object"
+
+    reason = _validate_push_endpoint(sub.get("endpoint"))
+
+    if reason:
+        return reason
+
+    keys = sub.get("keys")
+
+    if not isinstance(keys, dict):
+        return "subscription must include keys"
+
+    # WebPusher raises on a missing key, which would break every send for the
+    # user rather than just this registration
+    for name in ("p256dh", "auth"):
+        value = keys.get(name)
+
+        if not isinstance(value, str) or not value:
+            return f"subscription keys must include {name}"
+
+    return None
+
 
 @router.get(
     "/notifications/pubkey",
@@ -71,6 +162,17 @@ def register_notifications(request: Request, body: dict = None):
             status_code=400,
         )
 
+    reason = _validate_subscription(sub)
+
+    if reason:
+        logger.warning(
+            "Rejected notification registration for %s: %s", username, reason
+        )
+        return JSONResponse(
+            content={"success": False, "message": f"Invalid subscription: {reason}"},
+            status_code=400,
+        )
+
     try:
         User.update(notification_tokens=User.notification_tokens.append(sub)).where(
             User.username == username

frigate/api/record.py

@@ -25,20 +25,8 @@ from frigate.api.defs.query.recordings_query_parameters import (
 )
 from frigate.api.defs.response.generic_response import GenericResponse
 from frigate.api.defs.tags import Tags
-from frigate.const import (
+from frigate.const import RECORD_DIR
-    MAX_SEGMENT_DURATION,
-    RECORD_DIR,
-    STREAM_TYPE_MAIN,
-    STREAM_TYPE_SUB,
-)
 from frigate.models import Event, Recordings
-from frigate.util.recording_coverage import (
-    coverage_spans,
-    known_video_codecs,
-    realized_timelines,
-    resolve_coverage,
-    stream_media_summary,
-)
 from frigate.util.time import get_dst_transitions
 
 logger = logging.getLogger(__name__)
@@ -161,28 +149,23 @@ async def recordings_summary(camera_name: str, timezone: str = "utc"):
         period_hour_modifier = f"{hours_offset} hour"
         period_minute_modifier = f"{minutes_offset} minute"
 
-        hour_expression = fn.strftime(
-            "%Y-%m-%d %H",
-            fn.datetime(
-                Recordings.start_time,
-                "unixepoch",
-                period_hour_modifier,
-                period_minute_modifier,
-            ),
-        )
-
-        # sub rows duplicate the camera's motion/object stats, so
-        # aggregating them too would double-count
         recording_groups = (
             Recordings.select(
-                hour_expression.alias("hour"),
+                fn.strftime(
+                    "%Y-%m-%d %H",
+                    fn.datetime(
+                        Recordings.start_time,
+                        "unixepoch",
+                        period_hour_modifier,
+                        period_minute_modifier,
+                    ),
+                ).alias("hour"),
                 fn.SUM(Recordings.duration).alias("duration"),
                 fn.SUM(Recordings.motion).alias("motion"),
                 fn.SUM(Recordings.objects).alias("objects"),
             )
             .where(
                 (Recordings.camera == camera_name)
-                & (Recordings.stream_type == STREAM_TYPE_MAIN)
                 & (Recordings.end_time >= period_start)
                 & (Recordings.start_time <= period_end)
             )
@@ -191,23 +174,6 @@ async def recordings_summary(camera_name: str, timezone: str = "utc"):
             .namedtuples()
         )
 
-        # sub recordings can outlive main, so hours covered only by sub
-        # rows are reported too, flagged as sub_only
-        sub_groups = (
-            Recordings.select(
-                hour_expression.alias("hour"),
-                fn.SUM(Recordings.duration).alias("duration"),
-            )
-            .where(
-                (Recordings.camera == camera_name)
-                & (Recordings.stream_type == STREAM_TYPE_SUB)
-                & (Recordings.end_time >= period_start)
-                & (Recordings.start_time <= period_end)
-            )
-            .group_by((Recordings.start_time + period_offset).cast("int") / 3600)
-            .namedtuples()
-        )
-
         event_groups = (
             Event.select(
                 fn.strftime(
@@ -231,43 +197,17 @@ async def recordings_summary(camera_name: str, timezone: str = "utc"):
 
         event_map = {g.hour: g.count for g in event_groups}
 
-        hour_stats = [
+        for recording_group in recording_groups:
-            (
+            parts = recording_group.hour.split()
-                g.hour,
-                {
-                    "motion": g.motion,
-                    "objects": g.objects,
-                    "duration": round(g.duration),
-                },
-            )
-            for g in recording_groups
-        ]
-        main_hours = {group_hour for group_hour, _ in hour_stats}
-        hour_stats.extend(
-            (
-                g.hour,
-                {
-                    "motion": 0,
-                    "objects": 0,
-                    "duration": round(g.duration),
-                    "sub_only": True,
-                },
-            )
-            for g in sub_groups
-            if g.hour not in main_hours
-        )
-        # restore the most-recent-first ordering after merging in sub hours
-        hour_stats.sort(key=lambda entry: entry[0], reverse=True)
-
-        for group_hour, stats in hour_stats:
-            parts = group_hour.split()
             hour = parts[1]
             day = parts[0]
-            events_count = event_map.get(group_hour, 0)
+            events_count = event_map.get(recording_group.hour, 0)
             hour_data = {
                 "hour": hour,
                 "events": events_count,
-                **stats,
+                "motion": recording_group.motion,
+                "objects": recording_group.objects,
+                "duration": round(recording_group.duration),
             }
             if day in days:
                 # merge counts if already present (edge-case at DST boundary)
@@ -283,35 +223,6 @@ async def recordings_summary(camera_name: str, timezone: str = "utc"):
     return JSONResponse(content=list(days.values()))
 
 
-@router.get(
-    "/{camera_name}/recordings/coverage",
-    dependencies=[Depends(require_camera_access)],
-)
-async def recordings_coverage(
-    camera_name: str, after: float, before: float, timelines: bool = False
-):
-    """Returns merged recording coverage spans plus codec compatibility.
-
-    codecs_compatible is false only when more than one known video codec
-    appears across the range's rows, the case where the merged vod route
-    degrades to a single-stream manifest.
-    """
-    intervals = resolve_coverage(camera_name, after, before)
-
-    content = {
-        "spans": coverage_spans(intervals),
-        "codecs_compatible": len(known_video_codecs(intervals)) <= 1,
-        "streams": stream_media_summary(intervals),
-    }
-
-    # pure computation (shared plan_clip, record-time keyframe index), but
-    # opt-in for payload hygiene: day-level requests need only the spans
-    if timelines:
-        content["timelines"] = realized_timelines(intervals)
-
-    return JSONResponse(content=content)
-
-
 @router.get("/{camera_name}/recordings", dependencies=[Depends(require_camera_access)])
 async def recordings(
     camera_name: str,
@@ -332,8 +243,6 @@ async def recordings(
         )
         .where(
             Recordings.camera == camera_name,
-            Recordings.stream_type == STREAM_TYPE_MAIN,
-            Recordings.start_time >= after - MAX_SEGMENT_DURATION,
             Recordings.end_time >= after,
             Recordings.start_time <= before,
         )

frigate/api/review.py

@@ -17,6 +17,7 @@ from frigate.api.auth import (
     get_allowed_cameras_for_filter,
     get_current_user,
     require_camera_access,
+    require_full_camera_access,
     require_role,
 )
 from frigate.api.defs.query.review_query_parameters import (
@@ -32,7 +33,6 @@ from frigate.api.defs.response.review_response import (
     ReviewSummaryResponse,
 )
 from frigate.api.defs.tags import Tags
-from frigate.const import STREAM_TYPE_MAIN
 from frigate.embeddings import EmbeddingsContext
 from frigate.models import Recordings, ReviewSegment, UserReviewStatus
 from frigate.review.types import SeverityEnum
@@ -598,8 +598,6 @@ def motion_activity(
 
     clauses = [(Recordings.start_time > after) & (Recordings.end_time < before)]
     clauses.append(Recordings.motion > 0)
-    # sub rows duplicate the camera's motion stats, so only count main rows
-    clauses.append(Recordings.stream_type == STREAM_TYPE_MAIN)
 
     if cameras != "all":
         requested = set(cameras.split(","))
@@ -712,6 +710,7 @@ async def get_review(request: Request, review_id: str):
     dependencies=[Depends(allow_any_authenticated())],
 )
 async def set_not_reviewed(
+    request: Request,
     review_id: str,
     current_user: dict = Depends(get_current_user),
 ):
@@ -730,6 +729,8 @@ async def set_not_reviewed(
             status_code=404,
         )
 
+    await require_camera_access(review.camera, request=request)
+
     try:
         user_review = UserReviewStatus.get(
             UserReviewStatus.user_id == user_id,
@@ -746,9 +747,12 @@ async def set_not_reviewed(
     )
 
 
+# Intentionally not camera scoped, as the summary correlates each flagged event
+# with overlapping activity on other cameras. Restricted to callers who can
+# already see every camera, so the unscoped query discloses nothing.
 @router.post(
     "/review/summarize/start/{start_ts}/end/{end_ts}",
-    dependencies=[Depends(require_role(["admin"]))],
+    dependencies=[Depends(require_full_camera_access)],
     description="Use GenAI to summarize review items over a period of time.",
 )
 def generate_review_summary(request: Request, start_ts: float, end_ts: float):

frigate/camera/state.py

@@ -396,7 +396,6 @@ class CameraState:
                 "attributes": new_obj.obj_data["attributes"],
                 "current_estimated_speed": 0,
                 "velocity_angle": 0,
-                "path_data": [],
                 "recognized_license_plate": None,
                 "recognized_license_plate_score": None,
             }

frigate/comms/dispatcher.py

@@ -11,7 +11,7 @@ from frigate.camera.activity_manager import AudioActivityManager, CameraActivity
 from frigate.comms.base_communicator import Communicator
 from frigate.comms.runtime_state import RuntimeStatePersistence
 from frigate.comms.webpush import WebPushClient
-from frigate.config import BirdseyeModeConfig, FrigateConfig
+from frigate.config import BirdseyeModeEnum, FrigateConfig
 from frigate.config.camera.updater import (
     CameraConfigUpdateEnum,
     CameraConfigUpdatePublisher,
@@ -882,9 +882,8 @@ class Dispatcher:
     def _on_birdseye_mode_command(self, camera_name: str, payload: str) -> None:
         """Callback for birdseye mode topic."""
 
-        mode = BirdseyeModeConfig.from_mqtt_payload(payload)
+        if payload not in ["CONTINUOUS", "MOTION", "OBJECTS"]:
-        if mode is None:
+            logger.info(f"Invalid birdseye_mode command: {payload}")
-            logger.info("Invalid birdseye_mode command: %s", payload)
             return
 
         birdseye_settings = self.config.cameras[camera_name].birdseye
@@ -893,7 +892,7 @@ class Dispatcher:
             logger.info(f"Birdseye mode not enabled for {camera_name}")
             return
 
-        birdseye_settings.mode = mode
+        birdseye_settings.mode = BirdseyeModeEnum(payload.lower())
         logger.info(
             f"Setting birdseye mode for {camera_name} to {birdseye_settings.mode}"
         )
@@ -902,9 +901,7 @@ class Dispatcher:
             CameraConfigUpdateTopic(CameraConfigUpdateEnum.birdseye, camera_name),
             birdseye_settings,
         )
-        self.publish(
+        self.publish(f"{camera_name}/birdseye_mode/state", payload, retain=True)
-            f"{camera_name}/birdseye_mode/state", mode.to_mqtt_payload(), retain=True
-        )
 
     def _on_camera_notification_command(self, camera_name: str, payload: str) -> None:
         """Callback for camera level notifications topic."""

frigate/comms/mqtt.py

@@ -125,7 +125,7 @@ class MqttClient(Communicator):
             self.publish(
                 f"{camera_name}/birdseye_mode/state",
                 (
-                    camera.birdseye.mode.to_mqtt_payload()
+                    camera.birdseye.mode.value.upper()
                     if camera.birdseye.enabled
                     else "OFF"
                 ),

frigate/comms/webpush.py

@@ -89,7 +89,9 @@ class WebPushClient(Communicator):
         # notification and auth config updater
         self.global_config_subscriber = ConfigSubscriber("config/")
         self.config_subscriber = CameraConfigUpdateSubscriber(
-            self.config, self.config.cameras, [CameraConfigUpdateEnum.notifications]
+            self.config,
+            self.config.cameras,
+            [CameraConfigUpdateEnum.add, CameraConfigUpdateEnum.notifications],
         )
         self._refresh_user_cameras()
 
@@ -213,12 +215,12 @@ class WebPushClient(Communicator):
                 self.suspended_cameras[camera] = 0
                 self.last_camera_notification_time[camera] = 0
 
+            self._refresh_user_cameras()
+
         if topic == "reviews":
             decoded = json.loads(payload)
             camera = decoded["before"]["camera"]
-            camera_config = self.config.cameras.get(camera)
+            if not self.config.cameras[camera].notifications.enabled:
-
-            if camera_config is None or not camera_config.notifications.enabled:
                 return
             if self.is_camera_suspended(camera):
                 logger.debug(f"Notifications for {camera} are currently suspended.")
@@ -232,14 +234,13 @@ class WebPushClient(Communicator):
 
             # ensure notifications are enabled and the specific trigger has
             # notification action enabled
-            camera_config = self.config.cameras.get(camera)
-
             if (
-                camera_config is None
+                not self.config.cameras[camera].notifications.enabled
-                or not camera_config.notifications.enabled
+                or name not in self.config.cameras[camera].semantic_search.triggers
-                or name not in camera_config.semantic_search.triggers
                 or "notification"
-                not in camera_config.semantic_search.triggers[name].actions
+                not in self.config.cameras[camera]
+                .semantic_search.triggers[name]
+                .actions
             ):
                 return
 
@@ -250,9 +251,7 @@ class WebPushClient(Communicator):
         elif topic == "camera_monitoring":
             decoded = json.loads(payload)
             camera = decoded["camera"]
-            camera_config = self.config.cameras.get(camera)
+            if not self.config.cameras[camera].notifications.enabled:
-
-            if camera_config is None or not camera_config.notifications.enabled:
                 return
             if self.is_camera_suspended(camera):
                 logger.debug(f"Notifications for {camera} are currently suspended.")

frigate/comms/ws.py

@@ -3,6 +3,8 @@
 import errno
 import json
 import logging
+import queue
+import socket
 import threading
 from collections.abc import Callable
 from typing import Any
@@ -74,6 +76,9 @@ _WS_VIEWER_TOPICS = frozenset(
 # Camera-scoped command topics a camera-authorized (non-admin) user may send.
 _WS_CAMERA_COMMAND_TOPICS = frozenset({"ptz"})
 
+# Max outbound messages waiting on a client's writer thread.
+WS_MAX_PENDING_MESSAGES = 256
+
 
 def _check_ws_authorization(
     topic: str,
@@ -446,6 +451,63 @@ def _materialize_for_ws(
 
 
 class WebSocket(WebSocket_):  # type: ignore[misc]
+    def __init__(self, *args: Any, **kwargs: Any) -> None:
+        super().__init__(*args, **kwargs)
+        self._send_queue: queue.Queue[tuple[Any, bool] | None] = queue.Queue(
+            maxsize=WS_MAX_PENDING_MESSAGES
+        )
+        self._writer: threading.Thread | None = None
+        self._aborted = False
+
+    def opened(self) -> None:
+        # every client gets its own writer so a client that stops reading only
+        # blocks itself, never the thread that called publish()
+        self._writer = threading.Thread(
+            target=self._drain_send_queue, name="ws_writer", daemon=True
+        )
+        self._writer.start()
+
+    def send(self, payload: Any, binary: bool = False) -> None:
+        try:
+            self._send_queue.put_nowait((payload, binary))
+        except queue.Full:
+            self._abort("Websocket client is not keeping up, disconnecting it")
+
+    def _drain_send_queue(self) -> None:
+        while True:
+            item = self._send_queue.get()
+            if item is None or self.terminated or self.sock is None:
+                return
+            try:
+                super().send(*item)
+            except Exception:
+                self._abort()
+                return
+
+    def _abort(self, reason: str | None = None) -> None:
+        # publish() keeps hitting a full queue until the manager thread removes
+        # the connection, so only act (and log) the first time
+        if self._aborted:
+            return
+        self._aborted = True
+        if reason:
+            logger.warning(reason)
+
+        # shutdown rather than close so the ws4py manager thread sees EOF and
+        # runs its normal unregister/terminate; this also unblocks a stuck sendall
+        sock = self.sock
+        if sock is not None:
+            try:
+                sock.shutdown(socket.SHUT_RDWR)
+            except OSError:
+                pass
+
+    def closed(self, code: int, reason: str | None = None) -> None:
+        try:
+            self._send_queue.put_nowait(None)
+        except queue.Full:
+            pass
+
     def unhandled_error(self, error: Any) -> None:
         """
         Handles the unfriendly socket closures on the server side
@@ -580,10 +642,7 @@ class WebSocketClient(Communicator):
             )
             if message is None:
                 continue
-            try:
+            ws.send(message)
-                ws.send(message)
-            except (ConnectionResetError, BrokenPipeError, ValueError):
-                pass
 
     def stop(self) -> None:
         if self.websocket_server is not None:

frigate/config/camera/birdseye.py

@@ -1,3 +1,5 @@
+from enum import Enum
+
 from pydantic import BaseModel, Field
 
 from ..base import FrigateBaseModel
@@ -6,78 +8,22 @@ __all__ = [
     "BirdseyeCameraConfig",
     "BirdseyeConfig",
     "BirdseyeLayoutConfig",
-    "BirdseyeModeConfig",
+    "BirdseyeModeEnum",
 ]
 
-BIRDSEYE_ACTIVITY_TYPES = (
-    "objects",
-    "motion",
-    "stationary_objects",
-    "continuous",
-)
 
-
+class BirdseyeModeEnum(str, Enum):
-class BirdseyeModeConfig(FrigateBaseModel):
+    objects = "objects"
-    continuous: bool = Field(
+    motion = "motion"
-        default=False,
+    continuous = "continuous"
-        title="Continuous",
-        description="Always include the camera in Birdseye.",
-    )
-    motion: bool = Field(
-        default=False,
-        title="Motion",
-        description="Include the camera in Birdseye when motion is detected.",
-    )
-    objects: bool = Field(
-        default=False,
-        title="Active objects",
-        description="Include the camera in Birdseye while an active object is tracked.",
-    )
-    stationary_objects: bool = Field(
-        default=False,
-        title="Stationary objects",
-        description="Include the camera in Birdseye while a stationary object is tracked.",
-    )
 
     @classmethod
-    def from_mqtt_payload(cls, payload: str) -> "BirdseyeModeConfig | None":
+    def get_index(cls, type):
-        """Create mode options from an uppercase MQTT payload."""
+        return list(cls).index(type)
-        raw_modes = payload.split(",")
-        if not raw_modes or any(not mode for mode in raw_modes):
-            return None
 
-        modes = [mode.lower() for mode in raw_modes]
+    @classmethod
-        if any(
+    def get(cls, index):
-            raw_mode != mode.upper() or mode not in BIRDSEYE_ACTIVITY_TYPES
+        return list(cls)[index]
-            for raw_mode, mode in zip(raw_modes, modes)
-        ):
-            return None
-
-        if len(modes) != len(set(modes)):
-            return None
-
-        return cls(**{mode: True for mode in modes})
-
-    def has_enabled_activity(self) -> bool:
-        """Return whether at least one activity type is enabled."""
-        return any(getattr(self, activity) for activity in BIRDSEYE_ACTIVITY_TYPES)
-
-    def to_mqtt_payload(self) -> str:
-        """Serialize enabled mode options for MQTT state topics."""
-        payload = ",".join(
-            activity.upper()
-            for activity in BIRDSEYE_ACTIVITY_TYPES
-            if getattr(self, activity)
-        )
-        if not payload:
-            raise ValueError("At least one Birdseye activity type must be enabled")
-
-        return payload
-
-
-def default_birdseye_mode() -> BirdseyeModeConfig:
-    """Return the default Birdseye mode configuration."""
-    return BirdseyeModeConfig(objects=True)
 
 
 class BirdseyeLayoutConfig(FrigateBaseModel):
@@ -101,10 +47,10 @@ class BirdseyeConfig(FrigateBaseModel):
         title="Enable Birdseye",
         description="Enable or disable the Birdseye view feature.",
     )
-    mode: BirdseyeModeConfig = Field(
+    mode: BirdseyeModeEnum = Field(
-        default_factory=default_birdseye_mode,
+        default=BirdseyeModeEnum.objects,
-        title="Activity types",
+        title="Tracking mode",
-        description="Activity types that include cameras in Birdseye.",
+        description="Mode for including cameras in Birdseye: 'objects', 'motion', or 'continuous'.",
     )
 
     restream: bool = Field(
@@ -156,10 +102,10 @@ class BirdseyeCameraConfig(BaseModel):
         title="Enable Birdseye",
         description="Enable or disable the Birdseye view feature.",
     )
-    mode: BirdseyeModeConfig = Field(
+    mode: BirdseyeModeEnum = Field(
-        default_factory=default_birdseye_mode,
+        default=BirdseyeModeEnum.objects,
-        title="Activity types",
+        title="Tracking mode",
-        description="Activity types that include cameras in Birdseye.",
+        description="Mode for including cameras in Birdseye: 'objects', 'motion', or 'continuous'.",
     )
 
     order: int = Field(

frigate/config/camera/camera.py

@@ -3,12 +3,7 @@ from enum import Enum
 
 from pydantic import Field, PrivateAttr, model_validator
 
-from frigate.const import (
+from frigate.const import CACHE_DIR, CACHE_SEGMENT_FORMAT, REGEX_CAMERA_NAME
-    CACHE_DIR,
-    CACHE_SEGMENT_FORMAT,
-    REGEX_CAMERA_NAME,
-    SUB_CACHE_TAG,
-)
 from frigate.ffmpeg_presets import (
     parse_preset_hardware_acceleration_decode,
     parse_preset_hardware_acceleration_scale,
@@ -299,28 +294,6 @@ class CameraConfig(FrigateBaseModel):
                 + ffmpeg_output_args
             )
 
-        if (
-            "record_sub" in ffmpeg_input.roles
-            and self.record.enabled
-            and self.record.sub.enabled
-        ):
-            sub_output_args = self.ffmpeg.output_args.effective_record_sub
-            record_args = get_ffmpeg_arg_list(
-                parse_preset_output_record(
-                    sub_output_args,
-                    self.ffmpeg.apple_compatibility,
-                )
-                or sub_output_args
-            )
-
-            ffmpeg_output_args = (
-                record_args
-                + [
-                    f"{os.path.join(CACHE_DIR, self.name)}{SUB_CACHE_TAG}@{CACHE_SEGMENT_FORMAT}.mp4"
-                ]
-                + ffmpeg_output_args
-            )
-
         # if there aren't any outputs enabled for this input
         if len(ffmpeg_output_args) == 0:
             return None

frigate/config/camera/ffmpeg.py

@@ -42,20 +42,6 @@ class FfmpegOutputArgsConfig(FrigateBaseModel):
         title="Record output arguments",
         description="Default output arguments for record role streams.",
     )
-    record_sub: str | list[str] = Field(
-        default_factory=list,
-        title="Sub stream record output arguments",
-        description="Output arguments for record_sub role streams. The record output arguments are used when this is not set.",
-    )
-
-    @property
-    def effective_record_sub(self) -> str | list[str]:
-        """Output arguments used for the record_sub role.
-
-        Falls back to the record arguments rather than to the stock preset so
-        that a customized record value keeps applying to both recorded streams.
-        """
-        return self.record_sub or self.record
 
 
 class FfmpegConfig(FrigateBaseModel):
@@ -113,7 +99,6 @@ class FfmpegConfig(FrigateBaseModel):
 class CameraRoleEnum(str, Enum):
     audio = "audio"
     record = "record"
-    record_sub = "record_sub"
     detect = "detect"
 
 

frigate/config/camera/record.py

@@ -13,7 +13,6 @@ __all__ = [
     "RecordExportConfig",
     "RecordPreviewConfig",
     "RecordQualityEnum",
-    "RecordSubConfig",
     "EventsConfig",
     "ReviewRetainConfig",
     "RecordRetainConfig",
@@ -111,34 +110,6 @@ class RecordExportConfig(FrigateBaseModel):
     )
 
 
-class RecordSubConfig(FrigateBaseModel):
-    enabled: bool = Field(
-        default=False,
-        title="Enable sub stream recording",
-        description="Enable recording of a second, lower quality stream for adaptive quality playback and extended retention.",
-    )
-    continuous: RecordRetainConfig = Field(
-        default_factory=RecordRetainConfig,
-        title="Sub stream continuous retention",
-        description="Number of days to retain sub stream recordings regardless of tracked objects or motion.",
-    )
-    motion: RecordRetainConfig = Field(
-        default_factory=RecordRetainConfig,
-        title="Sub stream motion retention",
-        description="Number of days to retain sub stream recordings triggered by motion.",
-    )
-    alerts: ReviewRetainConfig = Field(
-        default_factory=ReviewRetainConfig,
-        title="Sub stream alert retention",
-        description="Retention settings for sub stream recordings of alerts.",
-    )
-    detections: ReviewRetainConfig = Field(
-        default_factory=ReviewRetainConfig,
-        title="Sub stream detection retention",
-        description="Retention settings for sub stream recordings of detections.",
-    )
-
-
 class RecordConfig(FrigateBaseModel):
     enabled: bool = Field(
         default=False,
@@ -180,35 +151,12 @@ class RecordConfig(FrigateBaseModel):
         title="Preview config",
         description="Settings controlling the quality of recording previews shown in the UI.",
     )
-    sub: RecordSubConfig = Field(
-        default_factory=RecordSubConfig,
-        title="Sub stream recording",
-        description="Settings for recording a second, lower quality stream.",
-    )
     enabled_in_config: bool | None = Field(
         default=None,
         title="Original recording state",
         description="Indicates whether recording was enabled in the original static configuration.",
     )
 
-    @property
-    def effective_alert_days(self) -> float:
-        """Alert retention extended to the sub stream window when sub is enabled.
-
-        Review items and tracked objects must stay visible for as long as
-        either stream still has recordings.
-        """
-        if self.sub.enabled:
-            return max(self.alerts.retain.days, self.sub.alerts.days)
-        return self.alerts.retain.days
-
-    @property
-    def effective_detection_days(self) -> float:
-        """Detection retention extended to the sub window when sub is enabled."""
-        if self.sub.enabled:
-            return max(self.detections.retain.days, self.sub.detections.days)
-        return self.detections.retain.days
-
     @property
     def event_pre_capture(self) -> int:
         return max(

frigate/config/camera/updater.py

@@ -129,13 +129,8 @@ class CameraConfigUpdateSubscriber:
             config.objects = updated_config
         elif update_type == CameraConfigUpdateEnum.record:
             old_enabled_in_config = config.record.enabled_in_config
-            old_sub_enabled = config.record.sub.enabled
             config.record = updated_config
-            # the record and record_sub ffmpeg outputs are gated on these
+            if old_enabled_in_config != updated_config.enabled_in_config:
-            if (
-                old_enabled_in_config != updated_config.enabled_in_config
-                or old_sub_enabled != updated_config.sub.enabled
-            ):
                 config.recreate_ffmpeg_cmds()
         elif update_type == CameraConfigUpdateEnum.review:
             config.review = updated_config

frigate/config/config.py

@@ -41,7 +41,7 @@ from .auth import AuthConfig
 from .base import FrigateBaseModel
 from .camera import CameraConfig, CameraLiveConfig
 from .camera.audio import AudioConfig, AudioFilterConfig
-from .camera.birdseye import BirdseyeConfig, BirdseyeModeConfig
+from .camera.birdseye import BirdseyeConfig
 from .camera.detect import DetectConfig
 from .camera.ffmpeg import FfmpegConfig
 from .camera.genai import GenAIConfig, GenAIRoleEnum
@@ -255,15 +255,6 @@ def verify_config_roles(camera_config: CameraConfig) -> None:
             f"Camera {camera_config.name} has record enabled, but record is not assigned to an input."
         )
 
-    if (
-        camera_config.record.enabled
-        and camera_config.record.sub.enabled
-        and "record_sub" not in assigned_roles
-    ):
-        raise ValueError(
-            f"Camera {camera_config.name} has sub stream recording enabled, but record_sub is not assigned to an input."
-        )
-
     if camera_config.audio.enabled and "audio" not in assigned_roles:
         raise ValueError(
             f"Camera {camera_config.name} has audio events enabled, but audio is not assigned to an input."
@@ -284,11 +275,13 @@ def verify_valid_live_stream_names(
             )
 
 
-def verify_record_output_args_segment_time(
+def verify_recording_segments_setup_with_reasonable_time(
-    camera_config: CameraConfig, output_args: str | list[str], role: str
+    camera_config: CameraConfig,
 ) -> None:
-    """Verify that a recording role's output args segment at a reasonable time."""
+    """Verify that recording segments are setup and segment time is not greater than 60."""
-    record_args: list[str] = get_ffmpeg_arg_list(output_args)
+    record_args: list[str] = get_ffmpeg_arg_list(
+        camera_config.ffmpeg.output_args.record
+    )
 
     if record_args[0].startswith("preset"):
         return
@@ -298,32 +291,16 @@ def verify_record_output_args_segment_time(
     except ValueError:
         raise ValueError(
             f"Camera {camera_config.name} has no segment_time in \
-                         {role} output args, segment args are required for record."
+                         recording output args, segment args are required for record."
         ) from None
 
     if int(record_args[seg_arg_index + 1]) > 60:
         raise ValueError(
-            f"Camera {camera_config.name} has invalid segment_time in {role} output args, \
+            f"Camera {camera_config.name} has invalid segment_time output arg, \
                          segment_time must be 60 or less."
         )
 
 
-def verify_recording_segments_setup_with_reasonable_time(
-    camera_config: CameraConfig,
-) -> None:
-    """Verify that recording segments are setup and segment time is not greater than 60."""
-    verify_record_output_args_segment_time(
-        camera_config, camera_config.ffmpeg.output_args.record, "recording"
-    )
-
-    if camera_config.record.sub.enabled:
-        verify_record_output_args_segment_time(
-            camera_config,
-            camera_config.ffmpeg.output_args.effective_record_sub,
-            "sub stream recording",
-        )
-
-
 def verify_zone_objects_are_tracked(camera_config: CameraConfig) -> None:
     """Verify that user has not entered zone objects that are not in the tracking config."""
     for zone_name, zone in camera_config.zones.items():
@@ -349,20 +326,8 @@ def verify_required_zones_exist(camera_config: CameraConfig) -> None:
 
 
 def verify_profile_overrides_match_base(camera_config: CameraConfig) -> None:
-    """Verify profile overrides against the resolved base camera configuration."""
+    """Verify that profile zone and mask IDs reference entries defined on the base camera."""
     for profile_name, profile in camera_config.profiles.items():
-        if profile.birdseye is not None:
-            overrides = profile.birdseye.mode.model_dump(exclude_unset=True)
-            base_mode = camera_config.birdseye.mode.model_dump()
-            resolved_mode = BirdseyeModeConfig.model_validate(
-                deep_merge(overrides, base_mode)
-            )
-            if not resolved_mode.has_enabled_activity():
-                raise ValueError(
-                    f"Camera '{camera_config.name}' profile '{profile_name}' must "
-                    "enable at least one Birdseye activity type"
-                )
-
         if profile.zones:
             for zone_name in profile.zones:
                 if zone_name not in camera_config.zones:
@@ -1033,10 +998,6 @@ class FrigateConfig(FrigateBaseModel):
             self.cameras[name] = camera_config
 
             verify_config_roles(camera_config)
-            if not camera_config.birdseye.mode.has_enabled_activity():
-                raise ValueError(
-                    f"Camera '{name}' must enable at least one Birdseye activity type"
-                )
             verify_valid_live_stream_names(self, camera_config)
             verify_recording_segments_setup_with_reasonable_time(camera_config)
             verify_zone_objects_are_tracked(camera_config)

frigate/config/profile_manager.py

@@ -43,9 +43,7 @@ SECTION_STATE_TOPICS: dict[str, list[tuple[str, Callable[[Any], Any]]]] = {
         ("birdseye", lambda c: "ON" if c.birdseye.enabled else "OFF"),
         (
             "birdseye_mode",
-            lambda c: (
+            lambda c: c.birdseye.mode.value.upper() if c.birdseye.enabled else "OFF",
-                c.birdseye.mode.to_mqtt_payload() if c.birdseye.enabled else "OFF"
-            ),
         ),
     ],
     "detect": [("detect", lambda c: "ON" if c.detect.enabled else "OFF")],

frigate/const.py

@@ -23,12 +23,6 @@ SHM_FRAMES_VAR = "SHM_MAX_FRAMES"
 
 REDACTED_CREDENTIAL_SENTINEL = "__FRIGATE_SAVED_CREDENTIAL__"
 
-# Stream type constants
-
-STREAM_TYPE_MAIN = "main"
-STREAM_TYPE_SUB = "sub"
-SUB_CACHE_TAG = "@sub"
-
 # Attribute & Object constants
 
 DEFAULT_ATTRIBUTE_LABEL_MAP = {

frigate/data_processing/post/audio_transcription.py

@@ -83,10 +83,6 @@ class AudioTranscriptionPostProcessor(PostProcessorApi):
         """
         event_id = data["event_id"]
         camera_name = data["camera"]
-        camera_config = self.config.cameras.get(camera_name)
-
-        if camera_config is None:
-            return
 
         if data_type == PostProcessDataEnum.recording:
             start_ts = data["frame_time"]
@@ -108,7 +104,7 @@ class AudioTranscriptionPostProcessor(PostProcessorApi):
 
         try:
             audio_data = get_audio_from_recording(
-                camera_config.ffmpeg,
+                self.config.cameras[camera_name].ffmpeg,
                 camera_name,
                 start_ts,
                 end_ts,

frigate/data_processing/post/object_descriptions.py

@@ -151,12 +151,7 @@ class ObjectDescriptionProcessor(PostProcessorApi):
             logger.error(f"Event {event_id} not found for description regeneration")
             return
 
-        camera_config = self.config.cameras.get(str(event.camera))
+        camera_config = self.config.cameras[str(event.camera)]
-
-        if camera_config is None:
-            logger.error("Camera %s no longer exists", event.camera)
-            return
-
         if not camera_config.objects.genai.enabled and not force:
             logger.error(f"GenAI not enabled for camera {event.camera}")
             return

frigate/data_processing/post/review_descriptions.py

@@ -137,10 +137,7 @@ class ReviewDescriptionProcessor(PostProcessorApi):
             return
 
         camera = data["after"]["camera"]
-        camera_config = self.config.cameras.get(camera)
+        camera_config = self.config.cameras[camera]
-
-        if camera_config is None:
-            return
 
         if not camera_config.review.genai.enabled:
             return

frigate/embeddings/maintainer.py

@@ -609,18 +609,6 @@ class EmbeddingMaintainer(threading.Thread):
                 # Embed the thumbnail
                 self._embed_thumbnail(event_id, thumbnail)
 
-            # every post processor below reads config.cameras[camera], but
-            # tracked_events still has to be released or the thumbnails held
-            # for this event leak, same as the two exits above
-            if camera not in self.config.cameras:
-                logger.debug("Skipping post processing for removed camera %s", camera)
-
-                for processor in self.post_processors:
-                    if isinstance(processor, ObjectDescriptionProcessor):
-                        processor.cleanup_event(event_id)
-
-                continue
-
             # call any defined post processors
             for processor in self.post_processors:
                 if isinstance(processor, LicensePlatePostProcessor):
@@ -678,18 +666,11 @@ class EmbeddingMaintainer(threading.Thread):
         to_remove = []
 
         for id, data in self.detected_license_plates.items():
-            camera_config = self.config.cameras.get(data["camera"])
-
-            if camera_config is None:
-                # camera was removed, drop the entry rather than expiring it
-                to_remove.append(id)
-                continue
-
             last_seen = data.get("last_seen", 0)
             if not last_seen:
                 continue
 
-            if now - last_seen > camera_config.lpr.expire_time:
+            if now - last_seen > self.config.cameras[data["camera"]].lpr.expire_time:
                 to_remove.append(id)
         for id in to_remove:
             self.event_metadata_publisher.publish(

frigate/events/cleanup.py

@@ -197,11 +197,9 @@ class EventCleanup(threading.Thread):
 
     def expire_clips(self) -> list[str]:
         ## Expire events from unlisted cameras based on the global config
-        # effective days cover the sub window, keeping tracked objects in
-        # Explore while sub recordings and review items still exist
         expire_days = max(
-            self.config.record.effective_alert_days,
+            self.config.record.alerts.retain.days,
-            self.config.record.effective_detection_days,
+            self.config.record.detections.retain.days,
         )
         file_extension = None  # mp4 clips are no longer stored in /clips
         update_params = {"has_clip": False}
@@ -280,13 +278,15 @@ class EventCleanup(threading.Thread):
 
         ## Expire events from cameras based on the camera config
         for name, camera in self.config.cameras.items():
-            # effective days cover the sub window, keeping tracked objects
+            expire_days = max(
-            # in Explore while sub recordings and review items still exist
+                camera.record.alerts.retain.days,
+                camera.record.detections.retain.days,
+            )
             alert_expire_date = (
-                now - datetime.timedelta(days=camera.record.effective_alert_days)
+                now - datetime.timedelta(days=camera.record.alerts.retain.days)
             ).timestamp()
             detection_expire_date = (
-                now - datetime.timedelta(days=camera.record.effective_detection_days)
+                now - datetime.timedelta(days=camera.record.detections.retain.days)
             ).timestamp()
             # grab all events after specific time
             expired_events = (

frigate/genai/plugins/gemini.py

@@ -245,7 +245,7 @@ class GeminiClient(GenAIClient):
                     )
                     gemini_messages.append(
                         types.Content(
-                            role="function",
+                            role="user",
                             parts=[
                                 types.Part.from_function_response(
                                     name=msg.get("name")
@@ -501,7 +501,7 @@ class GeminiClient(GenAIClient):
                     )
                     gemini_messages.append(
                         types.Content(
-                            role="function",
+                            role="user",
                             parts=[
                                 types.Part.from_function_response(
                                     name=msg.get("name")

frigate/genai/prompts.py

@@ -262,10 +262,6 @@ def get_tool_definitions(
     `attribute` parameter is exposed for filtering by their labels. When the
     embeddings model only understands English (JinaV1), the `semantic_query`
     description instructs the model to write the query in English.
-
-    Descriptions here stay mechanical: which tool to reach for, and how the
-    filters relate to each other, is stated once in the system prompt so the
-    guidance is not paid for twice on every request.
     """
     search_objects_properties: dict[str, Any] = {
         "camera": {
@@ -274,13 +270,26 @@ def get_tool_definitions(
         },
         "label": {
             "type": "string",
-            "description": "Tracked object class to filter by.",
+            "description": (
+                "Generic object class to filter by — one of the tracked detector "
+                "labels such as 'person', 'package', 'car', 'dog', 'bird'. Use "
+                "this for broad queries like 'show me all cars today'. Combine "
+                "with semantic_query when the user also describes appearance or "
+                "behavior (e.g. label='person', semantic_query='riding a lawn "
+                "mower')."
+            ),
         },
         "sub_label": {
             "type": "string",
             "description": (
-                "Name recognized in the detection: a person, delivery company, "
+                "Filter by a DISCRETE NAMED entity recognized in the detection. "
-                "animal species or breed, or license plate."
+                "Use this for: a known person's name ('John'), a delivery "
+                "company ('Amazon', 'UPS'), a recognized animal species or "
+                "breed ('blue jay', 'cardinal', 'golden retriever'), or a "
+                "license plate string. When filtering by a specific name, set "
+                "only sub_label and leave label unset. Do NOT use sub_label "
+                "for descriptions of appearance, clothing, or actions — those "
+                "belong in semantic_query."
             ),
         },
         "after": {
@@ -304,11 +313,20 @@ def get_tool_definitions(
     }
 
     if attribute_classifications:
+        model_outline = "; ".join(
+            f"{m['name']} (applies to {', '.join(m['objects']) or 'any object'})"
+            for m in attribute_classifications
+        )
         search_objects_properties["attribute"] = {
             "type": "string",
             "description": (
-                "Attribute label produced by a configured classification model "
+                "Filter by a classification attribute label produced by a "
-                "(case-sensitive)."
+                "configured attribute classification model. Use this INSTEAD "
+                "of semantic_query when the user's request matches one of "
+                "these classifications. Configured models: "
+                f"{model_outline}. "
+                "Set the value to the attribute label that matches the user's "
+                "phrasing (case-sensitive)."
             ),
         }
 
@@ -316,12 +334,29 @@ def get_tool_definitions(
         search_objects_properties["semantic_query"] = {
             "type": "string",
             "description": (
-                "Description of an appearance or activity, used to semantically "
+                "Optional natural-language description of a PHYSICAL "
-                "narrow results."
+                "CHARACTERISTIC, APPEARANCE, or ACTIVITY the user mentioned, "
+                "used to semantically narrow results. Only set this when the "
+                "user describes something beyond what label and sub_label can "
+                "express on their own.\n"
+                "USE for descriptive phrases like: 'riding a lawn mower', "
+                "'wearing a red jacket', 'carrying a package', 'walking a "
+                "dog', 'on a bicycle', 'holding an umbrella'.\n"
+                "DO NOT USE for:\n"
+                "- specific named people, pets, or delivery companies → use sub_label\n"
+                "- animal species or breed names like 'blue jay', 'cardinal', "
+                "'golden retriever' → use sub_label\n"
+                "- license plate strings → use sub_label\n"
+                "- generic object queries like 'all cars today' or 'every "
+                "person' → use label alone with no semantic_query\n"
+                "When set, combine with label/time/camera/zone filters as "
+                "usual (e.g. label='person', semantic_query='riding a lawn "
+                "mower', after='2024-05-01T00:00:00Z')."
                 + (
-                    " The configured embeddings model only understands English, so "
+                    " The configured embeddings model only understands "
-                    "always write this in English, translating the user's "
+                    "English, so always write semantic_query in English, "
-                    "description if they phrased it in another language."
+                    "translating the user's description if they phrased it "
+                    "in another language."
                     if embeddings_language == "english"
                     else ""
                 )
@@ -329,10 +364,26 @@ def get_tool_definitions(
         }
 
     search_objects_description = (
-        "Search the historical record of tracked detections. Use this ONLY for "
+        "Search the historical record of detected objects in Frigate. "
-        "questions about the PAST, e.g. 'did anyone come by today?', 'when was the "
+        "Use this ONLY for questions about the PAST — e.g. 'did anyone come by today?', "
-        "last car?'. For alerting on future events use start_camera_watch instead."
+        "'when was the last car?', 'show me detections from yesterday'. "
+        "Do NOT use this for monitoring or alerting requests about future events — "
+        "use start_camera_watch instead for those. "
+        "An 'object' in Frigate represents a tracked detection (e.g., a person, package, car).\n\n"
+        "Choose filters based on what the user is asking for:\n"
+        "- Generic class query ('show me all cars today'): set `label` only.\n"
+        "- Specific NAMED entity (known person, delivery company, animal "
+        "species/breed like 'blue jay' or 'golden retriever', license "
+        "plate): set `sub_label` only and leave `label` unset.\n"
     )
+    if semantic_search_enabled:
+        search_objects_description += (
+            "- Physical CHARACTERISTIC, APPEARANCE, or ACTIVITY that is not a "
+            "discrete name ('person riding a lawn mower', 'someone in a red "
+            "jacket', 'person carrying a package'): set `semantic_query` with "
+            "the descriptive phrase, optionally alongside `label` for the "
+            "object class. Do NOT put descriptive phrases in sub_label."
+        )
 
     return [
         {
@@ -347,30 +398,20 @@ def get_tool_definitions(
                 "required": [],
             },
         },
-        {
-            "type": "function",
-            "function": {
-                "name": "get_categorized_object_names",
-                "description": (
-                    "Every name that can be attached as a sub_label, grouped by object "
-                    "type: recognized faces, named license plates, classification "
-                    "categories, and delivery logos. Takes no arguments and always "
-                    "returns the complete map."
-                ),
-                "parameters": {
-                    "type": "object",
-                    "properties": {},
-                    "required": [],
-                },
-            },
-        },
         {
             "type": "function",
             "function": {
                 "name": "find_similar_objects",
                 "description": (
-                    "Find tracked objects visually and semantically similar to a "
+                    "Find tracked objects that are visually and semantically similar "
-                    "specific past event. Requires semantic search to be enabled."
+                    "to a specific past event. Use this when the user references a "
+                    "particular object they have seen and wants to find other "
+                    "sightings of the same or similar one ('that green car', 'the "
+                    "person in the red jacket', 'the package that was delivered'). "
+                    "Prefer this over search_objects whenever the user's intent is "
+                    "'find more like this specific one.' Use search_objects first "
+                    "only if you need to locate the anchor event. Requires semantic "
+                    "search to be enabled."
                 ),
                 "parameters": {
                     "type": "object",
@@ -432,8 +473,9 @@ def get_tool_definitions(
             "function": {
                 "name": "set_camera_state",
                 "description": (
-                    "Change a camera's feature state, e.g. turn detection on or off. "
+                    "Change a camera's feature state (e.g., turn detection on/off, enable/disable recordings). "
-                    "Only call this when the user explicitly asks to change a setting. "
+                    "Use camera='*' to apply to all cameras at once. "
+                    "Only call this tool when the user explicitly asks to change a camera setting. "
                     "Requires admin privileges."
                 ),
                 "parameters": {
@@ -468,14 +510,14 @@ def get_tool_definitions(
                             ],
                             "description": (
                                 "The feature to change. Most features accept ON or OFF. "
-                                "birdseye_mode accepts CONTINUOUS, MOTION, OBJECTS, STATIONARY_OBJECTS, or a comma-separated combination. "
+                                "birdseye_mode accepts CONTINUOUS, MOTION, or OBJECTS. "
                                 "motion_contour_area and motion_threshold accept a number. "
                                 "profile accepts a profile name or 'none' to deactivate (requires camera='*')."
                             ),
                         },
                         "value": {
                             "type": "string",
-                            "description": "The value to set, as accepted by the chosen feature.",
+                            "description": "The value to set. ON or OFF for toggles, a number for thresholds, a profile name or 'none' for profile.",
                         },
                     },
                     "required": ["camera", "feature", "value"],
@@ -487,9 +529,11 @@ def get_tool_definitions(
             "function": {
                 "name": "get_live_context",
                 "description": (
-                    "Current live image and detections (tracked objects, zones, "
+                    "Get the current live image and detection information for a single camera: objects being tracked, "
-                    "timestamps) for one camera. Use this for questions about what is "
+                    "zones, timestamps. Use this to understand what is visible in the live view. "
-                    "happening right now. Call it again for each additional camera."
+                    "Call this when answering questions about what is happening right now on a specific camera. "
+                    "Operates on one camera at a time; call the tool again for each additional camera. "
+                    "Wildcards and empty values are not accepted."
                 ),
                 "parameters": {
                     "type": "object",
@@ -497,8 +541,8 @@ def get_tool_definitions(
                         "camera": {
                             "type": "string",
                             "description": (
-                                "Exact name of a single camera. Wildcards (e.g. '*', "
+                                "Exact name of a single camera to get live context for. "
-                                "'all') and empty strings are not accepted."
+                                "Wildcards (e.g. '*', 'all') and empty strings are not accepted."
                             ),
                         },
                     },
@@ -511,9 +555,10 @@ def get_tool_definitions(
             "function": {
                 "name": "start_camera_watch",
                 "description": (
-                    "Start a continuous watch job that monitors a camera and notifies "
+                    "Start a continuous VLM watch job that monitors a camera and sends a notification "
-                    "the user when a condition is met, e.g. 'tell me when guests "
+                    "when a specified condition is met. Use this when the user wants to be alerted about "
-                    "arrive'. Only one watch job can run at a time. Returns a job ID."
+                    "a future event, e.g. 'tell me when guests arrive' or 'notify me when the package is picked up'. "
+                    "Only one watch job can run at a time. Returns a job ID."
                 ),
                 "parameters": {
                     "type": "object",
@@ -553,7 +598,10 @@ def get_tool_definitions(
             "type": "function",
             "function": {
                 "name": "stop_camera_watch",
-                "description": "Cancel the currently running watch job.",
+                "description": (
+                    "Cancel the currently running VLM watch job. Use this when the user wants to "
+                    "stop a previously started watch, e.g. 'stop watching the front door'."
+                ),
                 "parameters": {
                     "type": "object",
                     "properties": {},
@@ -566,9 +614,11 @@ def get_tool_definitions(
             "function": {
                 "name": "get_profile_status",
                 "description": (
-                    "Get the active profile and when each profile was last activated. "
+                    "Get the current profile status including the active profile and "
-                    "Call this before get_recap to derive the time window for requests "
+                    "timestamps of when each profile was last activated. Use this to "
-                    "like 'what happened while I was away?'."
+                    "determine time periods for recap requests — e.g. when the user asks "
+                    "'what happened while I was away?', call this first to find the relevant "
+                    "time window based on profile activation history."
                 ),
                 "parameters": {
                     "type": "object",
@@ -582,9 +632,11 @@ def get_tool_definitions(
             "function": {
                 "name": "get_recap",
                 "description": (
-                    "Get all activity (alerts and detections) for a time period, as a "
+                    "Get a recap of all activity (alerts and detections) for a given time period. "
-                    "chronological list with camera, objects, zones, and descriptions "
+                    "Use this after calling get_profile_status to retrieve what happened during "
-                    "when available. Summarize the results for the user."
+                    "a specific window — e.g. 'what happened while I was away?'. Returns a "
+                    "chronological list of activity with camera, objects, zones, and GenAI-generated "
+                    "descriptions when available. Summarize the results for the user."
                 ),
                 "parameters": {
                     "type": "object",
@@ -671,13 +723,14 @@ def build_chat_system_prompt(
         )
         speed_units_section = f"\n\nReport object speeds to the user in {speed_unit}."
 
-    filter_routing_section = (
+    semantic_search_section = ""
-        "\n\nWhen routing a search_objects call, pick filters by the shape of the user's request:\n"
-        "- Generic class ('show me all cars today'): set `label` only.\n"
-        "- Specific named entity — a known person ('John'), delivery company ('Amazon'), animal species/breed ('blue jay', 'golden retriever'), or license plate: set `sub_label` only and leave `label` unset. Call get_categorized_object_names first and use the exact spelling it returns; a guessed spelling matches nothing. If the name is absent, say it is not configured rather than searching for it."
-    )
     if semantic_search_enabled:
-        filter_routing_section += "\n- Physical characteristic, appearance, or activity that is NOT a discrete name ('riding a lawn mower', 'someone in a red jacket'): set `semantic_query` with the descriptive phrase, optionally combined with `label`. Never put descriptive phrases in `sub_label`."
+        semantic_search_section = (
+            "\n\nWhen routing a search_objects call, pick filters by the shape of the user's request:\n"
+            "- Generic class ('show me all cars today'): set `label` only.\n"
+            "- Specific named entity — a known person ('John'), delivery company ('Amazon'), animal species/breed ('blue jay', 'cardinal', 'golden retriever'), or license plate: set `sub_label` only and leave `label` unset.\n"
+            "- Physical characteristic, appearance, or activity that is NOT a discrete name ('find me people riding a lawn mower', 'someone in a red jacket', 'a person carrying a package'): set `semantic_query` with the descriptive phrase, optionally combined with `label` for the object class. Never put descriptive phrases in `sub_label`."
+        )
 
     attribute_classification_section = ""
     if attribute_classifications:
@@ -686,9 +739,9 @@ def build_chat_system_prompt(
             for m in attribute_classifications
         )
         attribute_classification_section = (
-            "\n\nConfigured attribute classification models:\n"
+            "\n\nAttribute classification models are configured for the following object types:\n"
             f"{model_lines}\n"
-            "When the user's request matches one of these classifications, set the search_objects `attribute` field to the matching label (case-sensitive) rather than using `semantic_query`. Reserve `semantic_query` for descriptive phrases outside the configured attribute labels."
+            "When the user's request matches one of these classifications, set the search_objects `attribute` field to the matching label rather than using `semantic_query`. Reserve `semantic_query` for descriptive phrases that fall outside the configured attribute labels."
         )
 
     return f"""You are a helpful assistant for Frigate, a security camera NVR system. You help users answer questions about their cameras, detected objects, and events.
@@ -697,6 +750,9 @@ Current server local date and time: {current_date_str} at {current_time_str}
 
 Do not start your response with phrases like "I will check...", "Let me see...", or "Let me look...". Answer directly.
 
-Always present times in the server's local timezone. When tool results include start_time_local and end_time_local, quote those strings exactly; never convert or invent timestamps, and fall back to UTC or ISO format only when a result has no local time fields. Resolve relative dates like "today" or "this week" against the current date above, and pass dates to tools in ISO 8601 (e.g. {current_date_str}T00:00:00Z for the start of today).
+Always present times to the user in the server's local timezone. When tool results include start_time_local and end_time_local, use those exact strings when listing or describing detection times—do not convert or invent timestamps. Do not use UTC or ISO format with Z for the user-facing answer unless the tool result only provides Unix timestamps without local time fields.
+When users ask about "today", "yesterday", "this week", etc., use the current date above as reference.
+When searching for objects or events, use ISO 8601 format for dates (e.g., {current_date_str}T00:00:00Z for the start of today).
+Always be accurate with time calculations based on the current date provided.
 
-When the user refers to a specific object they have seen ("that green car", "the person in the red jacket", "a package left today"), prefer find_similar_objects over search_objects, using search_objects only to locate the anchor event and passing its id along. Keep search_objects for generic queries like "show me all cars today". If a user message begins with [attached_event:<id>], treat that id as the anchor for any similarity or "tell me more" request in the same message.{filter_routing_section}{attribute_classification_section}{cameras_section}{speed_units_section}"""
+When a user refers to a specific object they have seen or describe with identifying details ("that green car", "the person in the red jacket", "a package left today"), prefer the find_similar_objects tool over search_objects. Use search_objects first only to locate the anchor event, then pass its id to find_similar_objects. For generic queries like "show me all cars today", keep using search_objects. If a user message begins with [attached_event:<id>], treat that event id as the anchor for any similarity or "tell me more" request in the same message and call find_similar_objects with that id.{semantic_search_section}{attribute_classification_section}{cameras_section}{speed_units_section}"""

frigate/jobs/debug_replay.py

@@ -115,6 +115,10 @@ def query_recordings(source_camera: str, start_ts: float, end_ts: float) -> Mode
     return cast(ModelSelect, query)
 
 
+class NoRecordingsError(ValueError):
+    """Raised when no recordings exist in the requested time range."""
+
+
 class DebugReplaySource(ABC):
     """Abstract source for a debug replay session.
 
@@ -187,7 +191,7 @@ class RecordingDebugReplaySource(DebugReplaySource):
             raise ValueError("End time must be after start time")
 
         if not query_recordings(self._camera, self._start_ts, self._end_ts).count():
-            raise ValueError(
+            raise NoRecordingsError(
                 f"No recordings found for camera '{self._camera}' in the specified time range"
             )
 

frigate/jobs/motion_search.py

@@ -15,7 +15,7 @@ import numpy as np
 
 from frigate.comms.inter_process import InterProcessRequestor
 from frigate.config import FrigateConfig
-from frigate.const import STREAM_TYPE_MAIN, UPDATE_JOB_STATE
+from frigate.const import UPDATE_JOB_STATE
 from frigate.jobs.job import Job
 from frigate.jobs.manager import (
     get_job_by_id,
@@ -485,7 +485,6 @@ class MotionSearchRunner(threading.Thread):
                 )
             )
             .where(Recordings.camera == camera_name)
-            .where(Recordings.stream_type == STREAM_TYPE_MAIN)
             .order_by(Recordings.start_time.asc())
         )
 

frigate/models.py

@@ -79,12 +79,6 @@ class Recordings(Model):
     segment_size = FloatField(default=0)  # this should be stored as MB
     regions = IntegerField(null=True)
     motion_heatmap = JSONField(null=True)  # 16x16 grid, 256 values (0-255)
-    keyframes = JSONField(null=True)  # ms offsets; NULL = unprobed (legacy rows)
-    stream_type = CharField(default="main", max_length=8)
-    has_audio = BooleanField(null=True)  # NULL = unknown (legacy rows)
-    audio_rate = IntegerField(null=True)  # Hz; NULL = unknown (legacy rows)
-    audio_codec = CharField(null=True, max_length=20)  # NULL = unknown (legacy rows)
-    video_codec = CharField(null=True, max_length=20)  # NULL = unknown (legacy rows)
 
 
 class ExportCase(Model):

frigate/output/birdseye.py

@@ -9,7 +9,6 @@ import queue
 import subprocess as sp
 import threading
 import traceback
-from dataclasses import dataclass
 from multiprocessing.synchronize import Event as MpEvent
 from typing import Any
 
@@ -17,7 +16,7 @@ import cv2
 import numpy as np
 
 from frigate.comms.inter_process import InterProcessRequestor
-from frigate.config import BirdseyeModeConfig, FfmpegConfig, FrigateConfig
+from frigate.config import BirdseyeModeEnum, FfmpegConfig, FrigateConfig
 from frigate.const import BASE_DIR, BIRDSEYE_PIPE, INSTALL_DIR, UPDATE_BIRDSEYE_LAYOUT
 from frigate.output.ws_auth import ws_has_camera_access
 from frigate.util.image import (
@@ -29,15 +28,6 @@ from frigate.util.image import (
 logger = logging.getLogger(__name__)
 
 
-@dataclass(frozen=True, slots=True)
-class BirdseyeActivity:
-    """Activity signals used to decide whether a camera is shown in Birdseye."""
-
-    has_active_object: bool
-    has_stationary_object: bool
-    has_motion: bool
-
-
 def get_standard_aspect_ratio(width: int, height: int) -> tuple[int, int]:
     """Ensure that only standard aspect ratios are used."""
     # it is important that all ratios have the same scale
@@ -419,16 +409,18 @@ class BirdsEyeFrameManager:
         )
 
     def camera_active(
-        self,
+        self, mode: Any, object_box_count: int, motion_box_count: int
-        mode: BirdseyeModeConfig,
-        activity: BirdseyeActivity,
     ) -> bool:
-        return (
+        if mode == BirdseyeModeEnum.continuous:
-            mode.continuous
+            return True
-            or (mode.motion and activity.has_motion)
+
-            or (mode.objects and activity.has_active_object)
+        if mode == BirdseyeModeEnum.motion and motion_box_count > 0:
-            or (mode.stationary_objects and activity.has_stationary_object)
+            return True
-        )
+
+        if mode == BirdseyeModeEnum.objects and object_box_count > 0:
+            return True
+
+        return False
 
     def get_camera_coordinates(self) -> dict[str, dict[str, int]]:
         """Return the coordinates of each camera in the current layout."""
@@ -612,92 +604,112 @@ class BirdsEyeFrameManager:
     ) -> list[list[Any]] | None:
         """Calculate the optimal layout for 2+ cameras."""
 
-        def find_available_x(
+        def map_layout(
-            current_x: int,
+            camera_layout: list[list[Any]], row_height: int
-            width: int,
+        ) -> tuple[int, int, list[list[Any]] | None]:
-            reserved_ranges: list[tuple[int, int]],
+            """Map the calculated layout."""
-            max_width: int,
+            candidate_layout = []
-        ) -> int | None:
+            starting_x = 0
-            """Find the first horizontal slot that does not collide with reservations."""
+            x = 0
-            x = current_x
-
-            for reserved_start, reserved_end in sorted(reserved_ranges):
-                if x >= reserved_end:
-                    continue
-
-                if x + width <= reserved_start:
-                    return x
-
-                x = max(x, reserved_end)
-
-            if x + width <= max_width:
-                return x
-
-            return None
-
-        def map_layout(row_height: int) -> tuple[int, int, list[list[Any]] | None]:
-            """Lay out cameras row by row while reserving portrait spans for the next row."""
-            candidate_layout: list[list[Any]] = []
-            reserved_ranges: dict[int, list[tuple[int, int]]] = {}
-            current_row: list[Any] = []
-            row_index = 0
-            row_y = 0
-            row_x = 0
             max_width = 0
-            max_height = 0
+            y = 0
 
-            for camera in cameras_to_add:
+            for row in camera_layout:
-                camera_dims = self.cameras[camera]["dimensions"].copy()
+                final_row = []
-                camera_aspect_x, camera_aspect_y = self.canvas.get_camera_aspect(
+                max_width = max(max_width, x)
-                    camera, camera_dims[0], camera_dims[1]
+                x = starting_x
+                for cameras in row:
+                    camera_dims = self.cameras[cameras[0]]["dimensions"].copy()
+                    camera_aspect = cameras[1]
+
+                    if camera_dims[1] > camera_dims[0]:
+                        scaled_height = int(row_height * 2)
+                        scaled_width = int(scaled_height * camera_aspect)
+                        starting_x = scaled_width
+                    else:
+                        scaled_height = row_height
+                        scaled_width = int(scaled_height * camera_aspect)
+
+                    # layout is too large
+                    if (
+                        x + scaled_width > self.canvas.width
+                        or y + scaled_height > self.canvas.height
+                    ):
+                        return x + scaled_width, y + scaled_height, None
+
+                    final_row.append((cameras[0], (x, y, scaled_width, scaled_height)))
+                    x += scaled_width
+
+                y += row_height
+                candidate_layout.append(final_row)
+
+            if max_width == 0:
+                max_width = x
+
+            return max_width, y, candidate_layout
+
+        canvas_aspect_x, canvas_aspect_y = self.canvas.get_aspect(coefficient)
+        camera_layout: list[list[Any]] = []
+        camera_layout.append([])
+        starting_x = 0
+        x = starting_x
+        y = 0
+        y_i = 0
+        max_y = 0
+        for camera in cameras_to_add:
+            camera_dims = self.cameras[camera]["dimensions"].copy()
+            camera_aspect_x, camera_aspect_y = self.canvas.get_camera_aspect(
+                camera, camera_dims[0], camera_dims[1]
+            )
+
+            if camera_dims[1] > camera_dims[0]:
+                portrait = True
+            else:
+                portrait = False
+
+            if (x + camera_aspect_x) <= canvas_aspect_x:
+                # insert if camera can fit on current row
+                camera_layout[y_i].append(
+                    (
+                        camera,
+                        camera_aspect_x / camera_aspect_y,
+                    )
                 )
-                portrait = camera_dims[1] > camera_dims[0]
-                scaled_height = row_height * 2 if portrait else row_height
-                scaled_width = int(scaled_height * (camera_aspect_x / camera_aspect_y))
 
-                while True:
+                if portrait:
-                    x = find_available_x(
+                    starting_x = camera_aspect_x
-                        row_x,
+                else:
-                        scaled_width,
+                    max_y = max(
-                        reserved_ranges.get(row_index, []),
+                        max_y,
-                        self.canvas.width,
+                        camera_aspect_y,
                     )
 
-                    if x is not None and row_y + scaled_height <= self.canvas.height:
+                x += camera_aspect_x
-                        current_row.append(
+            else:
-                            (camera, (x, row_y, scaled_width, scaled_height))
+                # move on to the next row and insert
-                        )
+                y += max_y
-                        row_x = x + scaled_width
+                y_i += 1
-                        max_width = max(max_width, row_x)
+                camera_layout.append([])
-                        max_height = max(max_height, row_y + scaled_height)
+                x = starting_x
 
-                        if portrait:
+                if x + camera_aspect_x > canvas_aspect_x:
-                            reserved_ranges.setdefault(row_index + 1, []).append(
+                    return None
-                                (x, row_x)
-                            )
 
-                        break
+                camera_layout[y_i].append(
+                    (
+                        camera,
+                        camera_aspect_x / camera_aspect_y,
+                    )
+                )
+                x += camera_aspect_x
 
-                    if current_row:
+        if y + max_y > canvas_aspect_y:
-                        candidate_layout.append(current_row)
+            return None
-                        current_row = []
 
-                    row_index += 1
+        row_height = int(self.canvas.height / coefficient)
-                    row_y = row_index * row_height
+        total_width, total_height, standard_candidate_layout = map_layout(
-                    row_x = 0
+            camera_layout, row_height
-
+        )
-                    if row_y + scaled_height > self.canvas.height:
-                        overflow_width = max(max_width, scaled_width)
-                        overflow_height = row_y + scaled_height
-                        return overflow_width, overflow_height, None
-
-            if current_row:
-                candidate_layout.append(current_row)
-
-            return max_width, max_height, candidate_layout
-
-        row_height = max(1, int(self.canvas.height / coefficient))
-        total_width, total_height, standard_candidate_layout = map_layout(row_height)
 
         if not standard_candidate_layout:
             # if standard layout didn't work
@@ -706,9 +718,9 @@ class BirdsEyeFrameManager:
                 total_width / self.canvas.width,
                 total_height / self.canvas.height,
             )
-            row_height = max(1, int(row_height / scale_down_percent))
+            row_height = int(row_height / scale_down_percent)
             total_width, total_height, standard_candidate_layout = map_layout(
-                row_height
+                camera_layout, row_height
             )
 
             if not standard_candidate_layout:
@@ -722,8 +734,8 @@ class BirdsEyeFrameManager:
             1 / (total_width / self.canvas.width),
             1 / (total_height / self.canvas.height),
         )
-        row_height = max(1, int(row_height * scale_up_percent))
+        row_height = int(row_height * scale_up_percent)
-        _, _, scaled_layout = map_layout(row_height)
+        _, _, scaled_layout = map_layout(camera_layout, row_height)
 
         if scaled_layout:
             return scaled_layout
@@ -733,7 +745,8 @@ class BirdsEyeFrameManager:
     def update(
         self,
         camera: str,
-        activity: BirdseyeActivity,
+        object_count: int,
+        motion_count: int,
         frame_time: float,
         frame: np.ndarray,
     ) -> tuple[bool, bool]:
@@ -747,29 +760,22 @@ class BirdsEyeFrameManager:
             return False, False
 
         force_update = False
-        camera_state = self.cameras.get(camera)
-
-        if camera_state is None:
-            return False, False
 
         # disabling birdseye is a little tricky
         if not camera_config.birdseye.enabled or not camera_config.enabled:
             # if we've rendered a frame (we have a value for last_active_frame)
             # then we need to set it to zero
-            if camera_state["last_active_frame"] > 0:
+            if self.cameras[camera]["last_active_frame"] > 0:
-                camera_state["last_active_frame"] = 0
+                self.cameras[camera]["last_active_frame"] = 0
                 force_update = True
             else:
                 return False, False
 
         # update the last active frame for the camera
-        camera_state["current_frame"] = frame.copy()
+        self.cameras[camera]["current_frame"] = frame.copy()
-        camera_state["current_frame_time"] = frame_time
+        self.cameras[camera]["current_frame_time"] = frame_time
-        if self.camera_active(
+        if self.camera_active(camera_config.birdseye.mode, object_count, motion_count):
-            camera_config.birdseye.mode,
+            self.cameras[camera]["last_active_frame"] = frame_time
-            activity,
-        ):
-            camera_state["last_active_frame"] = frame_time
 
         now = datetime.datetime.now().timestamp()
 
@@ -876,29 +882,10 @@ class Birdseye:
         frame_time: float,
         frame: np.ndarray,
     ) -> None:
-        has_active_object = False
-        has_stationary_object = False
-        for tracked_object in current_tracked_objects:
-            if tracked_object["stationary"]:
-                if not tracked_object["false_positive"]:
-                    has_stationary_object = True
-            else:
-                # Preserve the existing objects activity behavior, which includes
-                # non-stationary trackers before they are confirmed.
-                has_active_object = True
-
-            if has_active_object and has_stationary_object:
-                break
-
-        activity = BirdseyeActivity(
-            has_active_object=has_active_object,
-            has_stationary_object=has_stationary_object,
-            has_motion=bool(motion_boxes),
-        )
-
         frame_changed, frame_layout_changed = self.birdseye_manager.update(
             camera,
-            activity,
+            len([o for o in current_tracked_objects if not o["stationary"]]),
+            len(motion_boxes),
             frame_time,
             frame,
         )

frigate/output/output.py

@@ -51,12 +51,8 @@ def check_disabled_camera_update(
 
     for camera, last_update in write_times.items():
         offline_time = now - last_update
-        camera_config = config.cameras.get(camera)
 
-        if camera_config is None:
+        if config.cameras[camera].enabled:
-            continue
-
-        if camera_config.enabled:
             has_enabled_camera = True
         else:
             # flag camera as offline when it is disabled
@@ -66,8 +62,8 @@ def check_disabled_camera_update(
             # last camera update was more than 1 second ago
             # need to send empty data to birdseye because current
             # frame is now out of date
-            cam_width = camera_config.detect.width
+            cam_width = config.cameras[camera].detect.width
-            cam_height = camera_config.detect.height
+            cam_height = config.cameras[camera].detect.height
 
             if cam_width is None or cam_height is None:
                 raise ValueError(f"Camera {camera} detect dimensions not configured")
@@ -313,11 +309,10 @@ class OutputProcess(FrigateProcess):
                 regions,
             ) = data
 
-            camera_config = self.config.cameras.get(camera)
+            frame = frame_manager.get(
-
+                frame_name, self.config.cameras[camera].frame_shape_yuv
-            if camera_config is not None:
+            )
-                frame_manager.get(frame_name, camera_config.frame_shape_yuv)
+            frame_manager.close(frame_name)
-                frame_manager.close(frame_name)
 
         detection_subscriber.stop()
 

frigate/ptz/autotrack.py

@@ -799,24 +799,14 @@ class PtzAutoTracker:
             except TimeoutError:
                 continue
 
-            # both are popped when the camera is deleted, so resolve them once
-            # here and use the locals for the rest of the move; a move already
-            # in flight then finishes against valid objects
-            metrics = self.ptz_metrics.get(camera)
-            camera_config = self.config.cameras.get(camera)
-
-            if metrics is None or camera_config is None:
-                logger.debug("%s: Dropping queued move, camera was removed", camera)
-                continue
-
             async with self.move_queue_locks[camera]:
                 frame_time, pan, tilt, zoom = move_data
 
                 # if we're receiving move requests during a PTZ move, ignore them
                 if ptz_moving_at_frame_time(
                     frame_time,
-                    metrics.start_time.value,
+                    self.ptz_metrics[camera].start_time.value,
-                    metrics.stop_time.value,
+                    self.ptz_metrics[camera].stop_time.value,
                 ):
                     logger.debug(
                         f"{camera}: Move queue: PTZ moving, dequeueing move request - frame time: {frame_time}, final pan: {pan}, final tilt: {tilt}, final zoom: {zoom}"
@@ -825,7 +815,7 @@ class PtzAutoTracker:
 
                 else:
                     if (
-                        camera_config.onvif.autotracking.zooming
+                        self.config.cameras[camera].onvif.autotracking.zooming
                         == ZoomingModeEnum.relative
                     ):
                         await self.onvif._move_relative(camera, pan, tilt, zoom, 1)
@@ -834,22 +824,25 @@ class PtzAutoTracker:
                             await self.onvif._move_relative(camera, pan, tilt, 0, 1)
 
                             # Wait until the camera finishes moving
-                            while not metrics.motor_stopped.is_set():
+                            while not self.ptz_metrics[camera].motor_stopped.is_set():
                                 await self.onvif.get_camera_status(camera)
 
-                        if zoom > 0 and metrics.zoom_level.value != zoom:
+                        if (
+                            zoom > 0
+                            and self.ptz_metrics[camera].zoom_level.value != zoom
+                        ):
                             await self.onvif._zoom_absolute(camera, zoom, 1)
 
                     # Wait until the camera finishes moving
-                    while not metrics.motor_stopped.is_set():
+                    while not self.ptz_metrics[camera].motor_stopped.is_set():
                         await self.onvif.get_camera_status(camera)
 
-                    if camera_config.onvif.autotracking.movement_weights:
+                    if self.config.cameras[camera].onvif.autotracking.movement_weights:
                         logger.debug(
                             f"{camera}: Predicted movement time: {self._predict_movement_time(camera, pan, tilt)}"
                         )
                         logger.debug(
-                            f"{camera}: Actual movement time: {metrics.stop_time.value - metrics.start_time.value}"
+                            f"{camera}: Actual movement time: {self.ptz_metrics[camera].stop_time.value - self.ptz_metrics[camera].start_time.value}"
                         )
 
                     # save metrics for better estimate calculations
@@ -858,15 +851,21 @@ class PtzAutoTracker:
                         and len(self.move_metrics[camera])
                         < AUTOTRACKING_MAX_MOVE_METRICS
                         and (pan != 0 or tilt != 0)
-                        and camera_config.onvif.autotracking.calibrate_on_startup
+                        and self.config.cameras[
+                            camera
+                        ].onvif.autotracking.calibrate_on_startup
                     ):
                         logger.debug(f"{camera}: Adding new values to move metrics")
                         self.move_metrics[camera].append(
                             {
                                 "pan": pan,
                                 "tilt": tilt,
-                                "start_timestamp": metrics.start_time.value,
+                                "start_timestamp": self.ptz_metrics[
-                                "end_timestamp": metrics.stop_time.value,
+                                    camera
+                                ].start_time.value,
+                                "end_timestamp": self.ptz_metrics[
+                                    camera
+                                ].stop_time.value,
                             }
                         )
 

frigate/ptz/onvif.py

@@ -72,11 +72,7 @@ class OnvifController:
         self.config_subscriber = CameraConfigUpdateSubscriber(
             self.config,
             self.config.cameras,
-            [
+            [CameraConfigUpdateEnum.onvif],
-                CameraConfigUpdateEnum.onvif,
-                CameraConfigUpdateEnum.add,
-                CameraConfigUpdateEnum.remove,
-            ],
         )
 
         asyncio.run_coroutine_threadsafe(self._init_cameras(), self.loop)
@@ -105,16 +101,6 @@ class OnvifController:
                     if update_type == CameraConfigUpdateEnum.onvif.name:
                         for cam_name in cameras:
                             await self._reinit_camera(cam_name)
-                    elif update_type == CameraConfigUpdateEnum.add.name:
-                        # a camera added at runtime only needs ONVIF set up if
-                        # it actually has an onvif host configured
-                        for cam_name in cameras:
-                            cam = self.config.cameras.get(cam_name)
-                            if cam and cam.onvif.host:
-                                await self._reinit_camera(cam_name)
-                    elif update_type == CameraConfigUpdateEnum.remove.name:
-                        for cam_name in cameras:
-                            await self._remove_camera(cam_name)
             except Exception:
                 logger.error("Error checking for ONVIF config updates")
 
@@ -127,18 +113,6 @@ class OnvifController:
             except Exception:
                 logger.debug(f"Error closing ONVIF session for {cam_name}")
 
-    async def _remove_camera(self, cam_name: str) -> None:
-        """Tear down the ONVIF session for a camera removed at runtime."""
-        if cam_name not in self.cams and cam_name not in self.camera_configs:
-            return
-
-        logger.debug(f"Tearing down ONVIF for {cam_name} after camera removal")
-        await self._close_camera(cam_name)
-        self.cams.pop(cam_name, None)
-        self.camera_configs.pop(cam_name, None)
-        self.failed_cams.pop(cam_name, None)
-        self.status_locks.pop(cam_name, None)
-
     async def _reinit_camera(self, cam_name: str) -> None:
         """Re-initialize a camera after config change."""
         logger.info(f"Re-initializing ONVIF for {cam_name} due to config change")
@@ -206,11 +180,6 @@ class OnvifController:
             return False
 
     async def _init_onvif(self, camera_name: str) -> bool:
-        camera_config = self.config.cameras.get(camera_name)
-
-        if camera_config is None:
-            return False
-
         onvif: ONVIFCamera = self.cams[camera_name]["onvif"]
         try:
             await onvif.update_xaddrs()
@@ -266,7 +235,7 @@ class OnvifController:
                 p.token,
             )
 
-        configured_profile = camera_config.onvif.profile
+        configured_profile = self.config.cameras[camera_name].onvif.profile
         profile = None
 
         if configured_profile is not None:
@@ -370,7 +339,7 @@ class OnvifController:
             except (AttributeError, TypeError):
                 fov_space_id = None
 
-        autotracking_config = camera_config.onvif.autotracking
+        autotracking_config = self.config.cameras[camera_name].onvif.autotracking
         autotracking_enabled = (
             autotracking_config.enabled_in_config and autotracking_config.enabled
         )
@@ -645,11 +614,6 @@ class OnvifController:
             logger.error(f"{camera_name} does not support ONVIF RelativeMove (FOV).")
             return
 
-        metrics = self.ptz_metrics.get(camera_name)
-
-        if metrics is None:
-            return
-
         logger.debug(
             f"{camera_name} called RelativeMove: pan: {pan} tilt: {tilt} zoom: {zoom}"
         )
@@ -663,11 +627,15 @@ class OnvifController:
         self.cams[camera_name]["active"] = True
 
         # only track start_time for autotracking
-        if metrics.autotracker_enabled.value:
+        if self.ptz_metrics[camera_name].autotracker_enabled.value:
-            metrics.motor_stopped.clear()
+            self.ptz_metrics[camera_name].motor_stopped.clear()
-            logger.debug(f"{camera_name}: PTZ start time: {metrics.frame_time.value}")
+            logger.debug(
-            metrics.start_time.value = metrics.frame_time.value
+                f"{camera_name}: PTZ start time: {self.ptz_metrics[camera_name].frame_time.value}"
-            metrics.stop_time.value = 0
+            )
+            self.ptz_metrics[camera_name].start_time.value = self.ptz_metrics[
+                camera_name
+            ].frame_time.value
+            self.ptz_metrics[camera_name].stop_time.value = 0
 
         move_request = self.cams[camera_name]["relative_move_request"]
 
@@ -729,14 +697,9 @@ class OnvifController:
             logger.error(f"{preset} is not a valid preset for {camera_name}")
             return
 
-        metrics = self.ptz_metrics.get(camera_name)
-
-        if metrics is None:
-            return
-
         self.cams[camera_name]["active"] = True
-        metrics.start_time.value = 0
+        self.ptz_metrics[camera_name].start_time.value = 0
-        metrics.stop_time.value = 0
+        self.ptz_metrics[camera_name].stop_time.value = 0
         move_request = self.cams[camera_name]["move_request"]
         preset_token = self.cams[camera_name]["presets"][preset]
 
@@ -775,11 +738,6 @@ class OnvifController:
             logger.error(f"{camera_name} does not support ONVIF AbsoluteMove zooming.")
             return
 
-        metrics = self.ptz_metrics.get(camera_name)
-
-        if metrics is None:
-            return
-
         logger.debug(f"{camera_name} called AbsoluteMove: zoom: {zoom}")
 
         if self.cams[camera_name]["active"]:
@@ -789,10 +747,14 @@ class OnvifController:
             return
 
         self.cams[camera_name]["active"] = True
-        metrics.motor_stopped.clear()
+        self.ptz_metrics[camera_name].motor_stopped.clear()
-        logger.debug(f"{camera_name}: PTZ start time: {metrics.frame_time.value}")
+        logger.debug(
-        metrics.start_time.value = metrics.frame_time.value
+            f"{camera_name}: PTZ start time: {self.ptz_metrics[camera_name].frame_time.value}"
-        metrics.stop_time.value = 0
+        )
+        self.ptz_metrics[camera_name].start_time.value = self.ptz_metrics[
+            camera_name
+        ].frame_time.value
+        self.ptz_metrics[camera_name].stop_time.value = 0
         move_request = self.cams[camera_name]["absolute_move_request"]
 
         # function takes in 0 to 1 for zoom, interpolate to the values of the camera.
@@ -913,18 +875,16 @@ class OnvifController:
 
         Returns camera details including features and presets if available.
         """
-        camera_config = self.config.cameras.get(camera_name)
+        if not self.config.cameras[camera_name].enabled:
-
-        if camera_config is None:
-            return {}
-
-        if not camera_config.enabled:
             logger.debug(
                 f"Camera {camera_name} disabled, won't try to initialize ONVIF"
             )
             return {}
 
-        if camera_name not in self.cams.keys() and (not camera_config.onvif.host):
+        if camera_name not in self.cams.keys() and (
+            camera_name not in self.config.cameras
+            or not self.config.cameras[camera_name].onvif.host
+        ):
             logger.debug(f"ONVIF is not configured for {camera_name}")
             return {}
 
@@ -1025,12 +985,6 @@ class OnvifController:
                 logger.error(f"ONVIF is not configured for {camera_name}")
                 return
 
-            metrics = self.ptz_metrics.get(camera_name)
-            camera_config = self.config.cameras.get(camera_name)
-
-            if metrics is None or camera_config is None:
-                return
-
             if not self.cams[camera_name]["init"]:
                 if not await self._init_onvif(camera_name):
                     return
@@ -1069,29 +1023,36 @@ class OnvifController:
                 zoom_status is None or zoom_status == "IDLE"
             ):
                 self.cams[camera_name]["active"] = False
-                if not metrics.motor_stopped.is_set():
+                if not self.ptz_metrics[camera_name].motor_stopped.is_set():
-                    metrics.motor_stopped.set()
+                    self.ptz_metrics[camera_name].motor_stopped.set()
 
                     logger.debug(
-                        f"{camera_name}: PTZ stop time: {metrics.frame_time.value}"
+                        f"{camera_name}: PTZ stop time: {self.ptz_metrics[camera_name].frame_time.value}"
                     )
 
-                    metrics.stop_time.value = metrics.frame_time.value
+                    self.ptz_metrics[camera_name].stop_time.value = self.ptz_metrics[
+                        camera_name
+                    ].frame_time.value
             else:
                 self.cams[camera_name]["active"] = True
-                if metrics.motor_stopped.is_set():
+                if self.ptz_metrics[camera_name].motor_stopped.is_set():
-                    metrics.motor_stopped.clear()
+                    self.ptz_metrics[camera_name].motor_stopped.clear()
 
                     logger.debug(
-                        f"{camera_name}: PTZ start time: {metrics.frame_time.value}"
+                        f"{camera_name}: PTZ start time: {self.ptz_metrics[camera_name].frame_time.value}"
                     )
 
-                    metrics.start_time.value = metrics.frame_time.value
+                    self.ptz_metrics[camera_name].start_time.value = self.ptz_metrics[
-                    metrics.stop_time.value = 0
+                        camera_name
+                    ].frame_time.value
+                    self.ptz_metrics[camera_name].stop_time.value = 0
 
-            if camera_config.onvif.autotracking.zooming != ZoomingModeEnum.disabled:
+            if (
+                self.config.cameras[camera_name].onvif.autotracking.zooming
+                != ZoomingModeEnum.disabled
+            ):
                 # store absolute zoom level as 0 to 1 interpolated from the values of the camera
-                metrics.zoom_level.value = numpy.interp(
+                self.ptz_metrics[camera_name].zoom_level.value = numpy.interp(
                     round(status.Position.Zoom.x, 2),
                     [
                         self.cams[camera_name]["absolute_zoom_range"]["XRange"]["Min"],
@@ -1100,22 +1061,25 @@ class OnvifController:
                     [0, 1],
                 )
                 logger.debug(
-                    f"{camera_name}: Camera zoom level: {metrics.zoom_level.value}"
+                    f"{camera_name}: Camera zoom level: {self.ptz_metrics[camera_name].zoom_level.value}"
                 )
 
             # some hikvision cams won't update MoveStatus, so warn if it hasn't changed
             if (
-                not metrics.motor_stopped.is_set()
+                not self.ptz_metrics[camera_name].motor_stopped.is_set()
-                and not metrics.reset.is_set()
+                and not self.ptz_metrics[camera_name].reset.is_set()
-                and metrics.start_time.value != 0
+                and self.ptz_metrics[camera_name].start_time.value != 0
-                and metrics.frame_time.value > (metrics.start_time.value + 10)
+                and self.ptz_metrics[camera_name].frame_time.value
-                and metrics.stop_time.value == 0
+                > (self.ptz_metrics[camera_name].start_time.value + 10)
+                and self.ptz_metrics[camera_name].stop_time.value == 0
             ):
                 logger.debug(
-                    f"Start time: {metrics.start_time.value}, Stop time: {metrics.stop_time.value}, Frame time: {metrics.frame_time.value}"
+                    f"Start time: {self.ptz_metrics[camera_name].start_time.value}, Stop time: {self.ptz_metrics[camera_name].stop_time.value}, Frame time: {self.ptz_metrics[camera_name].frame_time.value}"
                 )
                 # set the stop time so we don't come back into this again and spam the logs
-                metrics.stop_time.value = metrics.frame_time.value
+                self.ptz_metrics[camera_name].stop_time.value = self.ptz_metrics[
+                    camera_name
+                ].frame_time.value
                 logger.warning(
                     f"Camera {camera_name} is still in ONVIF 'MOVING' status."
                 )

frigate/record/cleanup.py

@@ -12,14 +12,7 @@ from typing import Any
 from playhouse.sqlite_ext import SqliteExtDatabase
 
 from frigate.config import CameraConfig, FrigateConfig, RetainModeEnum
-from frigate.const import (
+from frigate.const import CACHE_DIR, CLIPS_DIR, MAX_WAL_SIZE, RECORD_DIR
-    CACHE_DIR,
-    CLIPS_DIR,
-    MAX_WAL_SIZE,
-    RECORD_DIR,
-    STREAM_TYPE_MAIN,
-    STREAM_TYPE_SUB,
-)
 from frigate.models import Previews, Recordings, ReviewSegment, UserReviewStatus
 from frigate.util.builtin import clear_and_unlink
 from frigate.util.media import remove_empty_directories
@@ -27,29 +20,6 @@ from frigate.util.media import remove_empty_directories
 logger = logging.getLogger(__name__)
 
 
-def _filter_reviews_for_pass(
-    reviews: list[Any],
-    now: datetime.datetime,
-    alerts_days: float,
-    detections_days: float,
-) -> list[Any]:
-    """Limit reviews to those still within this pass's per-severity retention window.
-
-    Review rows survive to the longer of the main and sub retention windows,
-    so a pass that honored all of them would let extended sub retention keep
-    main recordings alive too. Filtering preserves sort order for the overlap
-    loop in expire_existing_camera_recordings.
-    """
-    alert_cutoff = (now - datetime.timedelta(days=alerts_days)).timestamp()
-    detection_cutoff = (now - datetime.timedelta(days=detections_days)).timestamp()
-    return [
-        r
-        for r in reviews
-        if r.end_time is None
-        or (r.end_time >= (alert_cutoff if r.severity == "alert" else detection_cutoff))
-    ]
-
-
 class RecordingCleanup(threading.Thread):
     """Cleanup existing recordings based on retention config."""
 
@@ -95,14 +65,11 @@ class RecordingCleanup(threading.Thread):
         self, config: CameraConfig, now: datetime.datetime
     ) -> set[Path]:
         """Delete review segments that are expired"""
-        # review rows survive to the longer of the main and sub windows so
+        alert_expire_date = (
-        # they stay visible while either stream still has recordings
+            now - datetime.timedelta(days=config.record.alerts.retain.days)
-        alert_days = config.record.effective_alert_days
+        ).timestamp()
-        detection_days = config.record.effective_detection_days
-
-        alert_expire_date = (now - datetime.timedelta(days=alert_days)).timestamp()
         detection_expire_date = (
-            now - datetime.timedelta(days=detection_days)
+            now - datetime.timedelta(days=config.record.detections.retain.days)
         ).timestamp()
         expired_reviews = (
             ReviewSegment.select(ReviewSegment.id, ReviewSegment.thumb_path)
@@ -142,11 +109,8 @@ class RecordingCleanup(threading.Thread):
 
     def expire_existing_camera_recordings(
         self,
-        stream_type: str,
         continuous_expire_date: float,
         motion_expire_date: float,
-        alerts_retain_mode: RetainModeEnum,
-        detections_retain_mode: RetainModeEnum,
         config: CameraConfig,
         reviews: list[Any],
     ) -> set[Path]:
@@ -166,7 +130,6 @@ class RecordingCleanup(threading.Thread):
             )
             .where(
                 (Recordings.camera == config.name)
-                & (Recordings.stream_type == stream_type)
                 & (
                     (
                         (Recordings.end_time < continuous_expire_date)
@@ -212,9 +175,9 @@ class RecordingCleanup(threading.Thread):
                 ):
                     keep = True
                     mode = (
-                        alerts_retain_mode
+                        config.record.alerts.retain.mode
                         if review.severity == "alert"
-                        else detections_retain_mode
+                        else config.record.detections.retain.mode
                     )
                     break
 
@@ -253,10 +216,6 @@ class RecordingCleanup(threading.Thread):
                 Recordings.id << deleted_recordings_list[i : i + max_deletes]
             ).execute()
 
-        # previews follow main retention, so only the main pass expires them
-        if stream_type != STREAM_TYPE_MAIN:
-            return maybe_empty_dirs
-
         previews = (
             Previews.select(
                 Previews.id,
@@ -383,20 +342,6 @@ class RecordingCleanup(threading.Thread):
                 )
             ).timestamp()
 
-            # computed here so the reviews window below covers both passes
-            sub_continuous_expire_date = (
-                now - datetime.timedelta(days=config.record.sub.continuous.days)
-            ).timestamp()
-            sub_motion_expire_date = (
-                now
-                - datetime.timedelta(
-                    days=max(
-                        config.record.sub.motion.days,
-                        config.record.sub.continuous.days,
-                    )  # can't keep motion for less than continuous
-                )
-            ).timestamp()
-
             # Get all the reviews to check against
             reviews = (
                 ReviewSegment.select(
@@ -406,46 +351,18 @@ class RecordingCleanup(threading.Thread):
                 )
                 .where(
                     ReviewSegment.camera == camera,
-                    # candidate recordings reach the later of the two passes'
+                    # candidate recordings can extend up to continuous_expire_date
-                    # continuous cutoffs, so reviews must cover that whole
+                    # (the no-motion no-audio branch of the recordings query),
-                    # range or segments overlapping recent alerts get deleted
+                    # so reviews must cover that full range to avoid deleting
-                    ReviewSegment.start_time
+                    # segments that overlap recent alerts/detections.
-                    < max(continuous_expire_date, sub_continuous_expire_date),
+                    ReviewSegment.start_time < continuous_expire_date,
                 )
                 .order_by(ReviewSegment.start_time)
                 .namedtuples()
             )
 
             maybe_empty_dirs |= self.expire_existing_camera_recordings(
-                STREAM_TYPE_MAIN,
+                continuous_expire_date, motion_expire_date, config, reviews
-                continuous_expire_date,
-                motion_expire_date,
-                config.record.alerts.retain.mode,
-                config.record.detections.retain.mode,
-                config,
-                _filter_reviews_for_pass(
-                    reviews,
-                    now,
-                    config.record.alerts.retain.days,
-                    config.record.detections.retain.days,
-                ),
-            )
-
-            # runs even when sub recording is disabled so old rows still
-            # expire
-            maybe_empty_dirs |= self.expire_existing_camera_recordings(
-                STREAM_TYPE_SUB,
-                sub_continuous_expire_date,
-                sub_motion_expire_date,
-                config.record.sub.alerts.mode,
-                config.record.sub.detections.mode,
-                config,
-                _filter_reviews_for_pass(
-                    reviews,
-                    now,
-                    config.record.sub.alerts.days,
-                    config.record.sub.detections.days,
-                ),
             )
             logger.debug(f"End camera: {camera}.")
 

frigate/record/export.py

@@ -12,7 +12,6 @@ import threading
 from collections.abc import Callable
 from enum import Enum
 from pathlib import Path
-from typing import Any
 
 import pytz  # type: ignore[import-untyped]
 from peewee import DoesNotExist
@@ -25,8 +24,6 @@ from frigate.const import (
     EXPORT_DIR,
     MAX_PLAYLIST_SECONDS,
     PREVIEW_FRAME_TYPE,
-    STREAM_TYPE_MAIN,
-    STREAM_TYPE_SUB,
 )
 from frigate.ffmpeg_presets import (
     EncodeTypeEnum,
@@ -286,29 +283,6 @@ class RecordingExporter(threading.Thread):
 
         return input_duration * factor
 
-    def _get_recordings_for_range(self, stream_type: str) -> list[Any]:
-        """Fetch one stream type's recording rows overlapping the export range."""
-        return list(
-            Recordings.select(
-                Recordings.start_time,
-                Recordings.end_time,
-            )
-            .where(
-                Recordings.start_time.between(self.start_time, self.end_time)
-                | Recordings.end_time.between(self.start_time, self.end_time)
-                | (
-                    (self.start_time > Recordings.start_time)
-                    & (self.end_time < Recordings.end_time)
-                )
-            )
-            .where(
-                (Recordings.camera == self.camera)
-                & (Recordings.stream_type == stream_type)
-            )
-            .order_by(Recordings.start_time.asc())
-            .iterator()
-        )
-
     def _sum_source_duration_seconds(self) -> float | None:
         """Sum saved-video seconds inside [start_time, end_time].
 
@@ -319,12 +293,19 @@ class RecordingExporter(threading.Thread):
         """
         try:
             if self.playback_source == PlaybackSourceEnum.recordings:
-                # never mix streams in one estimate; use main when available
+                rows = (
-                # and fall back to sub for expired-main history
+                    Recordings.select(Recordings.start_time, Recordings.end_time)
-                rows = self._get_recordings_for_range(STREAM_TYPE_MAIN)
+                    .where(
-
+                        Recordings.start_time.between(self.start_time, self.end_time)
-                if not rows:
+                        | Recordings.end_time.between(self.start_time, self.end_time)
-                    rows = self._get_recordings_for_range(STREAM_TYPE_SUB)
+                        | (
+                            (self.start_time > Recordings.start_time)
+                            & (self.end_time < Recordings.end_time)
+                        )
+                    )
+                    .where(Recordings.camera == self.camera)
+                    .iterator()
+                )
             else:
                 rows = (
                     Previews.select(Previews.start_time, Previews.end_time)
@@ -710,12 +691,23 @@ class RecordingExporter(threading.Thread):
         if type(internal_port) is str:
             internal_port = int(internal_port.split(":")[-1])
 
-        # never mix streams in one playlist; use main when available and
+        recordings = list(
-        # fall back to sub for expired-main history
+            Recordings.select(
-        recordings = self._get_recordings_for_range(STREAM_TYPE_MAIN)
+                Recordings.start_time,
-
+                Recordings.end_time,
-        if not recordings:
+            )
-            recordings = self._get_recordings_for_range(STREAM_TYPE_SUB)
+            .where(
+                Recordings.start_time.between(self.start_time, self.end_time)
+                | Recordings.end_time.between(self.start_time, self.end_time)
+                | (
+                    (self.start_time > Recordings.start_time)
+                    & (self.end_time < Recordings.end_time)
+                )
+            )
+            .where(Recordings.camera == self.camera)
+            .order_by(Recordings.start_time.asc())
+            .iterator()
+        )
 
         playlist_lines: list[str] = []
         if (self.end_time - self.start_time) <= MAX_PLAYLIST_SECONDS:

frigate/record/maintainer.py

@@ -15,7 +15,6 @@ from typing import Any
 
 import numpy as np
 import psutil
-from peewee import fn
 
 from frigate.comms.detections_updater import DetectionSubscriber, DetectionTypeEnum
 from frigate.comms.inter_process import InterProcessRequestor
@@ -36,48 +35,15 @@ from frigate.const import (
     MAX_SEGMENT_DURATION,
     MAX_SEGMENTS_IN_CACHE,
     RECORD_DIR,
-    STREAM_TYPE_MAIN,
-    STREAM_TYPE_SUB,
-    SUB_CACHE_TAG,
 )
 from frigate.models import Recordings, ReviewSegment
 from frigate.review.types import SeverityEnum
-from frigate.util.media import get_keyframe_offsets
 from frigate.util.services import get_video_properties
 
 logger = logging.getLogger(__name__)
 
 STALE_RECORDINGS_INFO_TTL = MAX_SEGMENTS_IN_CACHE * MAX_SEGMENT_DURATION * 2
 
-# cache filenames have whole-second resolution, so a contiguous segment's
-# parsed start lands up to 1s before the previous segment's true end
-SEGMENT_CHAIN_TOLERANCE_S = 1.0
-
-# against an mtime-measured start, disagreement beyond this means
-# accumulated probe-duration error and the chain re-anchors on the mtime
-SEGMENT_CHAIN_DRIFT_LIMIT_S = 0.5
-
-# probing every cached segment at once starves the camera and detection
-# processes, and the probes then blow their own timeouts together, so
-# segments get discarded as corrupt and the record watchdog restarts ffmpeg
-MAX_CONCURRENT_SEGMENT_PROBES = 4
-
-
-def parse_cache_segment_name(basename: str) -> tuple[str, str, str] | None:
-    """Parse a cache segment basename into (camera, stream_type, date).
-
-    Main segments are named {camera}@{date}; sub segments {camera}@sub@{date}.
-    """
-    try:
-        prefix, date = basename.rsplit("@", maxsplit=1)
-    except ValueError:
-        return None
-
-    if prefix.endswith(SUB_CACHE_TAG):
-        return (prefix[: -len(SUB_CACHE_TAG)], STREAM_TYPE_SUB, date)
-
-    return (prefix, STREAM_TYPE_MAIN, date)
-
 
 class SegmentInfo:
     def __init__(
@@ -117,10 +83,6 @@ class SegmentInfo:
 
 
 class RecordingMaintainer(threading.Thread):
-    # move_files replaces this per cycle: an asyncio primitive binds to the
-    # first event loop that contends it, and every cycle runs in a new loop
-    probe_semaphore = asyncio.Semaphore(MAX_CONCURRENT_SEGMENT_PROBES)
-
     def __init__(self, config: FrigateConfig, stop_event: MpEvent):
         super().__init__(name="recording_maintainer")
         self.config = config
@@ -138,101 +100,10 @@ class RecordingMaintainer(threading.Thread):
         self.stop_event = stop_event
         self.object_recordings_info: dict[str, list] = defaultdict(list)
         self.audio_recordings_info: dict[str, list] = defaultdict(list)
-        # cache_path -> (end_time, duration, has_audio, audio_rate,
+        self.end_time_cache: dict[str, tuple[datetime.datetime, float]] = {}
-        # audio_codec, video_codec, keyframes)
-        self.end_time_cache: dict[
-            str,
-            tuple[
-                datetime.datetime,
-                float,
-                bool | None,
-                int | None,
-                str | None,
-                str | None,
-                list[int] | None,
-            ],
-        ] = {}
-        # last known capture end per (camera, stream_type); 0.0 marks a key
-        # whose DB seed found no rows
-        self.last_segment_end: dict[tuple[str, str], float] = {}
         self.unexpected_cache_files_logged: bool = False
 
-    def _get_last_segment_end(self, camera: str, stream_type: str) -> float | None:
-        """Return the last known capture end time for a camera stream.
-
-        Lazily seeds from the most recent stored recording so start-time
-        chains survive restarts.
-        """
-        key = (camera, stream_type)
-
-        if key not in self.last_segment_end:
-            last_db_end = (
-                Recordings.select(fn.MAX(Recordings.end_time))
-                .where(
-                    Recordings.camera == camera,
-                    Recordings.stream_type == stream_type,
-                )
-                .scalar()
-            )
-            # the 0.0 sentinel keeps the seed query from repeating
-            self.last_segment_end[key] = last_db_end if last_db_end is not None else 0.0
-
-        return self.last_segment_end[key] or None
-
-    def _resolve_segment_start(
-        self,
-        camera: str,
-        stream_type: str,
-        filename_start: datetime.datetime,
-        duration: float,
-        cache_path: str,
-    ) -> datetime.datetime:
-        """Resolve a segment's true start time from its cache file.
-
-        Cache filenames carry whole-second resolution, so the parsed start
-        sits up to 1s early. The cache file's mtime is the wall clock when
-        ffmpeg rolled the segment, so mtime minus the probed duration
-        restores the fractional start. Contiguous segments still chain to
-        the previous segment's end so rows stay exactly adjacent.
-        """
-        filename_ts = filename_start.timestamp()
-
-        measured: float | None = None
-        try:
-            mtime = os.path.getmtime(cache_path)
-        except OSError:
-            mtime = None
-        if mtime is not None:
-            candidate = mtime - duration
-            # media shorter than its wall span (a stalled stream, an early
-            # close) derives a start past the truncation window, where the
-            # floored filename start is safer
-            if 0 <= candidate - filename_ts < SEGMENT_CHAIN_TOLERANCE_S:
-                measured = candidate
-
-        last_end = self._get_last_segment_end(camera, stream_type)
-
-        if measured is not None:
-            if (
-                last_end is not None
-                and abs(last_end - measured) < SEGMENT_CHAIN_DRIFT_LIMIT_S
-            ):
-                return datetime.datetime.fromtimestamp(last_end, tz=datetime.UTC)
-            return datetime.datetime.fromtimestamp(measured, tz=datetime.UTC)
-
-        # no usable mtime: capture is continuous within a run, so a
-        # filename start just before the previous end chains to that end
-        if (
-            last_end is not None
-            and 0 <= last_end - filename_ts < SEGMENT_CHAIN_TOLERANCE_S
-        ):
-            return datetime.datetime.fromtimestamp(last_end, tz=datetime.UTC)
-
-        return filename_start
-
     async def move_files(self) -> None:
-        self.probe_semaphore = asyncio.Semaphore(MAX_CONCURRENT_SEGMENT_PROBES)
-
         cache_files = [
             d
             for d in os.listdir(CACHE_DIR)
@@ -246,17 +117,13 @@ class RecordingMaintainer(threading.Thread):
         for cache in cache_files:
             cache_path = os.path.join(CACHE_DIR, cache)
             basename = os.path.splitext(cache)[0]
-            parsed = parse_cache_segment_name(basename)
+            try:
-            if parsed is None:
+                camera, date = basename.rsplit("@", maxsplit=1)
+            except ValueError:
                 if not self.unexpected_cache_files_logged:
                     logger.warning("Skipping unexpected files in cache")
                     self.unexpected_cache_files_logged = True
                 continue
-            camera, stream_type, date = parsed
-
-            # this topic feeds main-stream health/sync consumers only
-            if stream_type == STREAM_TYPE_SUB:
-                continue
 
             start_time = datetime.datetime.strptime(
                 date, CACHE_SEGMENT_FORMAT
@@ -300,10 +167,8 @@ class RecordingMaintainer(threading.Thread):
             except psutil.Error:
                 continue
 
-        # group recordings by camera and stream type (skip in-use for validation/moving)
+        # group recordings by camera (skip in-use for validation/moving)
-        grouped_recordings: defaultdict[tuple[str, str], list[dict[str, Any]]] = (
+        grouped_recordings: defaultdict[str, list[dict[str, Any]]] = defaultdict(list)
-            defaultdict(list)
-        )
         for cache in cache_files:
             # Skip files currently in use
             if cache in files_in_use:
@@ -311,35 +176,32 @@ class RecordingMaintainer(threading.Thread):
 
             cache_path = os.path.join(CACHE_DIR, cache)
             basename = os.path.splitext(cache)[0]
-            parsed = parse_cache_segment_name(basename)
+            try:
-            if parsed is None:
+                camera, date = basename.rsplit("@", maxsplit=1)
+            except ValueError:
                 if not self.unexpected_cache_files_logged:
                     logger.warning("Skipping unexpected files in cache")
                     self.unexpected_cache_files_logged = True
                 continue
-            camera, stream_type, date = parsed
 
             # important that start_time is utc because recordings are stored and compared in utc
             start_time = datetime.datetime.strptime(
                 date, CACHE_SEGMENT_FORMAT
             ).astimezone(datetime.UTC)
 
-            grouped_recordings[(camera, stream_type)].append(
+            grouped_recordings[camera].append(
                 {
                     "cache_path": cache_path,
                     "start_time": start_time,
-                    "stream_type": stream_type,
                 }
             )
 
         # delete all cached files past the most recent MAX_SEGMENTS_IN_CACHE
         keep_count = MAX_SEGMENTS_IN_CACHE
-        for key in grouped_recordings.keys():
+        for camera in grouped_recordings.keys():
-            camera, stream_type = key
-
             # sort based on start time
-            grouped_recordings[key] = sorted(
+            grouped_recordings[camera] = sorted(
-                grouped_recordings[key], key=lambda s: s["start_time"]
+                grouped_recordings[camera], key=lambda s: s["start_time"]
             )
 
             camera_info = self.object_recordings_info[camera]
@@ -354,7 +216,7 @@ class RecordingMaintainer(threading.Thread):
                             r["start_time"].timestamp()
                             < most_recently_processed_frame_time
                         ),
-                        grouped_recordings[key],
+                        grouped_recordings[camera],
                     )
                 )
             )
@@ -364,133 +226,103 @@ class RecordingMaintainer(threading.Thread):
                 logger.warning(
                     f"Unable to keep up with recording segments in cache for {camera}. Keeping the {keep_count} most recent segments out of {processed_segment_count} and discarding the rest..."
                 )
-                to_remove = grouped_recordings[key][:-keep_count]
+                to_remove = grouped_recordings[camera][:-keep_count]
                 for rec in to_remove:
                     cache_path = rec["cache_path"]
                     Path(cache_path).unlink(missing_ok=True)
                     self.end_time_cache.pop(cache_path, None)
-                grouped_recordings[key] = grouped_recordings[key][-keep_count:]
+                grouped_recordings[camera] = grouped_recordings[camera][-keep_count:]
 
             # see if detection has failed and unprocessed segments need to be deleted
             unprocessed_segment_count = (
-                len(grouped_recordings[key]) - processed_segment_count
+                len(grouped_recordings[camera]) - processed_segment_count
             )
             if unprocessed_segment_count > keep_count:
                 logger.warning(
                     f"Too many unprocessed recording segments in cache for {camera}. This likely indicates an issue with the detect stream, keeping the {keep_count} most recent segments out of {unprocessed_segment_count} and discarding the rest..."
                 )
-                to_remove = grouped_recordings[key][:-keep_count]
+                to_remove = grouped_recordings[camera][:-keep_count]
                 for rec in to_remove:
                     cache_path = rec["cache_path"]
                     Path(cache_path).unlink(missing_ok=True)
                     self.end_time_cache.pop(cache_path, None)
-                grouped_recordings[key] = grouped_recordings[key][-keep_count:]
+                grouped_recordings[camera] = grouped_recordings[camera][-keep_count:]
 
-        # frame stats are shared per camera across stream types, so trimming
+        tasks = []
-        # to one stream's oldest cache would pop frames the other still needs
+        for camera, recordings in grouped_recordings.items():
-        min_start_per_camera: dict[str, float] = {}
-        for key, recordings in grouped_recordings.items():
-            camera, _ = key
-            oldest_start = recordings[0]["start_time"].timestamp()
-            if (
-                camera not in min_start_per_camera
-                or oldest_start < min_start_per_camera[camera]
-            ):
-                min_start_per_camera[camera] = oldest_start
-
-        for camera, min_start in min_start_per_camera.items():
             # clear out all the object recording info for old frames
             while (
                 len(self.object_recordings_info[camera]) > 0
-                and self.object_recordings_info[camera][0][0] < min_start
+                and self.object_recordings_info[camera][0][0]
+                < recordings[0]["start_time"].timestamp()
             ):
                 self.object_recordings_info[camera].pop(0)
 
             # clear out all the audio recording info for old frames
             while (
                 len(self.audio_recordings_info[camera]) > 0
-                and self.audio_recordings_info[camera][0][0] < min_start
+                and self.audio_recordings_info[camera][0][0]
+                < recordings[0]["start_time"].timestamp()
             ):
                 self.audio_recordings_info[camera].pop(0)
 
-        tasks = []
+            # get all reviews with the end time after the start of the oldest cache file
-        reviews_by_camera: dict[str, Any] = {}
+            # or with end_time None
-        for key, recordings in grouped_recordings.items():
+            reviews = (
-            camera, stream_type = key
+                ReviewSegment.select(
-
+                    ReviewSegment.start_time,
-            # get all reviews with the end time after the start of the oldest
+                    ReviewSegment.end_time,
-            # cache file or with end_time None; shared across stream types
+                    ReviewSegment.severity,
-            if camera not in reviews_by_camera:
+                    ReviewSegment.data,
-                reviews_by_camera[camera] = (
-                    ReviewSegment.select(
-                        ReviewSegment.start_time,
-                        ReviewSegment.end_time,
-                        ReviewSegment.severity,
-                        ReviewSegment.data,
-                    )
-                    .where(
-                        ReviewSegment.camera == camera,
-                        (ReviewSegment.end_time == None)
-                        | (ReviewSegment.end_time >= min_start_per_camera[camera]),
-                    )
-                    .order_by(ReviewSegment.start_time)
                 )
-            reviews = reviews_by_camera[camera]
+                .where(
+                    ReviewSegment.camera == camera,
+                    (ReviewSegment.end_time == None)
+                    | (
+                        ReviewSegment.end_time
+                        >= recordings[0]["start_time"].timestamp()
+                    ),
+                )
+                .order_by(ReviewSegment.start_time)
+            )
 
             tasks.extend(
                 [self.validate_and_move_segment(camera, reviews, r) for r in recordings]
             )
 
             # publish most recently available recording time and None if disabled
-            if stream_type == STREAM_TYPE_MAIN:
+            camera_cfg = self.config.cameras.get(camera)
-                camera_cfg = self.config.cameras.get(camera)
+            self.recordings_publisher.publish(
-                self.recordings_publisher.publish(
+                (
-                    (
+                    camera,
-                        camera,
+                    recordings[0]["start_time"].timestamp()
-                        recordings[0]["start_time"].timestamp()
+                    if camera_cfg and camera_cfg.record.enabled
-                        if camera_cfg and camera_cfg.record.enabled
+                    else None,
-                        else None,
+                    None,
-                        None,
+                ),
-                    ),
+                RecordingsDataTypeEnum.saved.value,
-                    RecordingsDataTypeEnum.saved.value,
+            )
-                )
 
         self._expire_stale_recordings_info(grouped_recordings)
 
-        # one segment must not abort the cycle: an exception propagating out
+        recordings_to_insert: list[dict[str, Any] | None] = await asyncio.gather(*tasks)
-        # of gather would abandon the other segments' in-flight probes
-        results: list[dict[str, Any] | None | BaseException] = await asyncio.gather(
-            *tasks, return_exceptions=True
-        )
-
-        recordings_to_insert: list[dict[str, Any]] = []
-
-        for result in results:
-            if isinstance(result, BaseException):
-                logger.error(
-                    "Failed to validate and move a recording segment", exc_info=result
-                )
-                continue
-
-            if result is not None:
-                recordings_to_insert.append(result)
 
         # fire and forget recordings entries
-        self.requestor.send_data(INSERT_MANY_RECORDINGS, recordings_to_insert)
+        self.requestor.send_data(
+            INSERT_MANY_RECORDINGS,
+            [r for r in recordings_to_insert if r is not None],
+        )
 
     def _expire_stale_recordings_info(
-        self, grouped_recordings: defaultdict[tuple[str, str], list[dict[str, Any]]]
+        self, grouped_recordings: defaultdict[str, list[dict[str, Any]]]
     ) -> None:
         expire_before = datetime.datetime.now().timestamp() - STALE_RECORDINGS_INFO_TTL
-        # a camera is still active when any of its streams cached segments
-        cameras_with_cache = {camera for camera, _ in grouped_recordings}
-
         for recordings_info in (
             self.object_recordings_info,
             self.audio_recordings_info,
         ):
             for camera in list(recordings_info.keys()):
-                if camera in cameras_with_cache:
+                if camera in grouped_recordings:
                     continue
                 info = recordings_info[camera]
                 while info and info[0][0] < expire_before:
@@ -505,121 +337,64 @@ class RecordingMaintainer(threading.Thread):
     ) -> dict[str, Any] | None:
         cache_path: str = recording["cache_path"]
         start_time: datetime.datetime = recording["start_time"]
-        stream_type: str = recording["stream_type"]
 
         # Just delete files if camera removed or recordings are turned off
         if (
             camera not in self.config.cameras
             or not self.config.cameras[camera].record.enabled
-            or (
-                stream_type == STREAM_TYPE_SUB
-                and not self.config.cameras[camera].record.sub.enabled
-            )
         ):
             self.drop_segment(cache_path)
             return None
 
         if cache_path in self.end_time_cache:
-            (
+            end_time, duration = self.end_time_cache[cache_path]
-                end_time,
-                duration,
-                has_audio,
-                audio_rate,
-                audio_codec,
-                video_codec,
-                keyframes,
-            ) = self.end_time_cache[cache_path]
-            # recover the resolved start rather than reusing the truncated
-            # filename timestamp
-            start_time = end_time - datetime.timedelta(seconds=duration)
         else:
-            async with self.probe_semaphore:
+            segment_info = await get_video_properties(
-                segment_info = await get_video_properties(
+                self.config.ffmpeg, cache_path, get_duration=True
-                    self.config.ffmpeg, cache_path, get_duration=True
+            )
-                )
 
             if not segment_info.get("has_valid_video", False):
                 logger.warning(
                     f"Invalid or missing video stream in segment {cache_path}. Discarding."
                 )
-                if stream_type == STREAM_TYPE_MAIN:
+                self.recordings_publisher.publish(
-                    self.recordings_publisher.publish(
+                    (camera, start_time.timestamp(), cache_path),
-                        (camera, start_time.timestamp(), cache_path),
+                    RecordingsDataTypeEnum.invalid.value,
-                        RecordingsDataTypeEnum.invalid.value,
+                )
-                    )
                 self.drop_segment(cache_path)
                 return None
 
             duration = float(segment_info.get("duration", -1))
-            has_audio = segment_info.get("has_audio")
-            audio_rate = segment_info.get("audio_rate")
-            audio_codec = segment_info.get("audio_codec")
-            video_codec = segment_info.get("video_codec")
 
             # ensure duration is within expected length
             if 0 < duration < MAX_SEGMENT_DURATION:
-                # playback snaps mid-file entry points against these offsets
-                # instead of probing files on demand
-                async with self.probe_semaphore:
-                    keyframes = await get_keyframe_offsets(cache_path)
-
-                start_time = self._resolve_segment_start(
-                    camera, stream_type, start_time, duration, cache_path
-                )
                 end_time = start_time + datetime.timedelta(seconds=duration)
-                self.end_time_cache[cache_path] = (
+                self.end_time_cache[cache_path] = (end_time, duration)
-                    end_time,
-                    duration,
-                    has_audio,
-                    audio_rate,
-                    audio_codec,
-                    video_codec,
-                    keyframes,
-                )
-                # segments later discarded by retention still advance the
-                # chain for the next kept segment
-                self.last_segment_end[(camera, stream_type)] = end_time.timestamp()
             else:
                 if duration == -1:
                     logger.warning(f"Failed to probe corrupt segment {cache_path}")
 
                 logger.warning(f"Discarding a corrupt recording segment: {cache_path}")
-                if stream_type == STREAM_TYPE_MAIN:
+                self.recordings_publisher.publish(
-                    self.recordings_publisher.publish(
+                    (camera, start_time.timestamp(), cache_path),
-                        (camera, start_time.timestamp(), cache_path),
+                    RecordingsDataTypeEnum.invalid.value,
-                        RecordingsDataTypeEnum.invalid.value,
+                )
-                    )
                 self.drop_segment(cache_path)
                 return None
 
             # this segment has a valid duration and has video data, so publish an update
-            if stream_type == STREAM_TYPE_MAIN:
+            self.recordings_publisher.publish(
-                self.recordings_publisher.publish(
+                (camera, start_time.timestamp(), cache_path),
-                    (camera, start_time.timestamp(), cache_path),
+                RecordingsDataTypeEnum.valid.value,
-                    RecordingsDataTypeEnum.valid.value,
+            )
-                )
 
         record_config = self.config.cameras[camera].record
-
-        # sub's alerts/detections carry the retain mode directly, unlike
-        # main's nested retain config
-        if stream_type == STREAM_TYPE_SUB:
-            continuous_days = record_config.sub.continuous.days
-            motion_days = record_config.sub.motion.days
-            alerts_retain_mode = record_config.sub.alerts.mode
-            detections_retain_mode = record_config.sub.detections.mode
-        else:
-            continuous_days = record_config.continuous.days
-            motion_days = record_config.motion.days
-            alerts_retain_mode = record_config.alerts.retain.mode
-            detections_retain_mode = record_config.detections.retain.mode
-
         segment_stats: SegmentInfo | None = None
         highest = None
 
-        if continuous_days > 0:
+        if record_config.continuous.days > 0:
             highest = "continuous"
-        elif motion_days > 0:
+        elif record_config.motion.days > 0:
             highest = "motion"
 
         # if we have continuous or motion recording enabled
@@ -651,17 +426,11 @@ class RecordingMaintainer(threading.Thread):
                 if not segment_stats.should_discard_segment(record_mode):
                     return await self.move_segment(
                         camera,
-                        stream_type,
                         start_time,
                         end_time,
                         duration,
                         cache_path,
                         segment_stats,
-                        has_audio,
-                        audio_rate,
-                        audio_codec,
-                        video_codec,
-                        keyframes,
                     )
 
         # we fell through the continuous / motion check, so we need to check the review items
@@ -690,9 +459,9 @@ class RecordingMaintainer(threading.Thread):
 
         if overlaps:
             record_mode = (
-                alerts_retain_mode
+                record_config.alerts.retain.mode
                 if review.severity == "alert"
-                else detections_retain_mode
+                else record_config.detections.retain.mode
             )
 
             if segment_stats is None:
@@ -702,17 +471,11 @@ class RecordingMaintainer(threading.Thread):
                 # move from cache to recordings immediately
                 return await self.move_segment(
                     camera,
-                    stream_type,
                     start_time,
                     end_time,
                     duration,
                     cache_path,
                     segment_stats,
-                    has_audio,
-                    audio_rate,
-                    audio_codec,
-                    video_codec,
-                    keyframes,
                 )
             else:
                 self.drop_segment(cache_path)
@@ -851,24 +614,17 @@ class RecordingMaintainer(threading.Thread):
     async def move_segment(
         self,
         camera: str,
-        stream_type: str,
         start_time: datetime.datetime,
         end_time: datetime.datetime,
         duration: float,
         cache_path: str,
         segment_info: SegmentInfo,
-        has_audio: bool | None = None,
-        audio_rate: int | None = None,
-        audio_codec: str | None = None,
-        video_codec: str | None = None,
-        keyframes: list[int] | None = None,
     ) -> dict[str, Any] | None:
         # directory will be in utc due to start_time being in utc
-        # sub segments get a tagged directory to avoid filename collisions
         directory = os.path.join(
             RECORD_DIR,
             start_time.strftime("%Y-%m-%d/%H"),
-            camera if stream_type == STREAM_TYPE_MAIN else f"{camera}{SUB_CACHE_TAG}",
+            camera,
         )
 
         os.makedirs(directory, exist_ok=True)
@@ -928,7 +684,6 @@ class RecordingMaintainer(threading.Thread):
                 return {
                     Recordings.id.name: f"{start_time.timestamp()}-{rand_id}",
                     Recordings.camera.name: camera,
-                    Recordings.stream_type.name: stream_type,
                     Recordings.path.name: file_path,
                     Recordings.start_time.name: start_time.timestamp(),
                     Recordings.end_time.name: end_time.timestamp(),
@@ -940,11 +695,6 @@ class RecordingMaintainer(threading.Thread):
                     Recordings.dBFS.name: segment_info.average_dBFS,
                     Recordings.segment_size.name: segment_size,
                     Recordings.motion_heatmap.name: segment_info.motion_heatmap,
-                    Recordings.has_audio.name: has_audio,
-                    Recordings.audio_rate.name: audio_rate,
-                    Recordings.audio_codec.name: audio_codec,
-                    Recordings.video_codec.name: video_codec,
-                    Recordings.keyframes.name: keyframes,
                 }
         except Exception as e:
             logger.error(f"Unable to store recording segment {cache_path}")
@@ -995,9 +745,7 @@ class RecordingMaintainer(threading.Thread):
                         regions,
                     ) = data
 
-                    camera_config = self.config.cameras.get(camera)
+                    if self.config.cameras[camera].record.enabled:
-
-                    if camera_config is not None and camera_config.record.enabled:
                         self.object_recordings_info[camera].append(
                             (
                                 frame_time,
@@ -1014,9 +762,7 @@ class RecordingMaintainer(threading.Thread):
                         audio_detections,
                     ) = data
 
-                    camera_config = self.config.cameras.get(camera)
+                    if self.config.cameras[camera].record.enabled:
-
-                    if camera_config is not None and camera_config.record.enabled:
                         self.audio_recordings_info[camera].append(
                             (
                                 frame_time,
@@ -1038,10 +784,11 @@ class RecordingMaintainer(threading.Thread):
 
             try:
                 asyncio.run(self.move_files())
-            except Exception:
+            except Exception as e:
-                logger.exception(
+                logger.error(
                     "Error occurred when attempting to maintain recording cache"
                 )
+                logger.error(e)
             duration = datetime.datetime.now().timestamp() - run_start
             wait_time = max(0, 5 - duration)
 

frigate/review/maintainer.py

@@ -418,11 +418,6 @@ class ReviewSegmentMaintainer(threading.Thread):
 
         return None
 
-    def _handle_camera_removed(self, camera: str) -> None:
-        """Close out a deleted camera's segment so a reused name cannot inherit it."""
-        self.forcibly_end_segment(camera)
-        self.indefinite_events.pop(camera, None)
-
     def update_existing_segment(
         self,
         segment: PendingReviewSegment,
@@ -671,10 +666,6 @@ class ReviewSegmentMaintainer(threading.Thread):
                 for camera in updated_topics["enabled"]:
                     self.forcibly_end_segment(camera)
 
-            if "remove" in updated_topics:
-                for camera in updated_topics["remove"]:
-                    self._handle_camera_removed(camera)
-
             result = self.detection_subscriber.check_for_update(timeout=1)
 
             if not result:

frigate/storage.py

@@ -9,12 +9,7 @@ from pathlib import Path
 from peewee import SQL, fn
 
 from frigate.config import FrigateConfig
-from frigate.const import (
+from frigate.const import RECORD_DIR, REPLAY_CAMERA_PREFIX
-    RECORD_DIR,
-    REPLAY_CAMERA_PREFIX,
-    STREAM_TYPE_MAIN,
-    STREAM_TYPE_SUB,
-)
 from frigate.models import Event, Recordings
 from frigate.util.builtin import clear_and_unlink
 
@@ -54,55 +49,32 @@ class StorageMaintainer(threading.Thread):
                     )
                 }
 
-                # calculate MB/hr from the last 100 segments of each stream
+                # calculate MB/hr from last 100 segments
-                # type and sum the rates; mixing streams would average small
+                try:
-                # sub segments against large main segments and underestimate
+                    # Subquery to get last 100 segments, then average their bandwidth
-                # the true write rate
+                    last_100 = (
-                bandwidth_by_stream: dict[str, float] = {}
+                        Recordings.select(bandwidth_equation.alias("bw"))
-                for stream_type in (STREAM_TYPE_MAIN, STREAM_TYPE_SUB):
+                        .where(Recordings.camera == camera, Recordings.segment_size > 0)
-                    try:
+                        .order_by(Recordings.start_time.desc())
-                        # Subquery to get last 100 segments, then average their bandwidth
+                        .limit(100)
-                        last_100 = (
+                        .alias("recent")
-                            Recordings.select(bandwidth_equation.alias("bw"))
-                            .where(
-                                Recordings.camera == camera,
-                                Recordings.segment_size > 0,
-                                Recordings.stream_type == stream_type,
-                            )
-                            .order_by(Recordings.start_time.desc())
-                            .limit(100)
-                            .alias("recent")
-                        )
-
-                        bandwidth_by_stream[stream_type] = round(
-                            Recordings.select(fn.AVG(SQL("bw")))
-                            .from_(last_100)
-                            .scalar()
-                            * 3600,
-                            2,
-                        )
-                    except TypeError:
-                        pass
-
-                bandwidth = round(sum(bandwidth_by_stream.values()), 2)
-
-                if bandwidth > MAX_CALCULATED_BANDWIDTH:
-                    logger.warning(
-                        f"{camera} has a bandwidth of {bandwidth} MB/hr which exceeds the expected maximum. This typically indicates an issue with the cameras recordings."
                     )
-                    # scale each stream so the per stream values still sum to
+
-                    # the clamped total the UI displays alongside them
+                    bandwidth = round(
-                    scale = MAX_CALCULATED_BANDWIDTH / bandwidth
+                        Recordings.select(fn.AVG(SQL("bw"))).from_(last_100).scalar()
-                    bandwidth_by_stream = {
+                        * 3600,
-                        stream_type: round(value * scale, 2)
+                        2,
-                        for stream_type, value in bandwidth_by_stream.items()
+                    )
-                    }
+
-                    bandwidth = MAX_CALCULATED_BANDWIDTH
+                    if bandwidth > MAX_CALCULATED_BANDWIDTH:
+                        logger.warning(
+                            f"{camera} has a bandwidth of {bandwidth} MB/hr which exceeds the expected maximum. This typically indicates an issue with the cameras recordings."
+                        )
+                        bandwidth = MAX_CALCULATED_BANDWIDTH
+                except TypeError:
+                    bandwidth = 0
 
                 self.camera_storage_stats[camera]["bandwidth"] = bandwidth
-                self.camera_storage_stats[camera]["bandwidth_by_stream"] = (
-                    bandwidth_by_stream
-                )
                 logger.debug(f"{camera} has a bandwidth of {bandwidth} MiB/hr.")
 
     def calculate_camera_usages(self) -> dict[str, dict]:
@@ -114,40 +86,20 @@ class StorageMaintainer(threading.Thread):
             if camera.startswith(REPLAY_CAMERA_PREFIX):
                 continue
 
-            stream_usages = {
+            camera_storage = (
-                row["stream_type"]: row["usage"] or 0
+                Recordings.select(fn.SUM(Recordings.segment_size))
-                for row in (
+                .where(Recordings.camera == camera, Recordings.segment_size != 0)
-                    Recordings.select(
+                .scalar()
-                        Recordings.stream_type,
-                        fn.SUM(Recordings.segment_size).alias("usage"),
-                    )
-                    .where(Recordings.camera == camera, Recordings.segment_size != 0)
-                    .group_by(Recordings.stream_type)
-                    .dicts()
-                )
-            }
-            stream_bandwidths = self.camera_storage_stats.get(camera, {}).get(
-                "bandwidth_by_stream", {}
             )
 
             camera_key = (
                 getattr(self.config.cameras[camera], "friendly_name", None) or camera
             )
             usages[camera_key] = {
-                "usage": sum(stream_usages.values()),
+                "usage": camera_storage,
                 "bandwidth": self.camera_storage_stats.get(camera, {}).get(
                     "bandwidth", 0
                 ),
-                # only streams with segments on disk are reported, so a camera
-                # keeps its sub entry until sub retention expires those segments
-                "streams": {
-                    stream_type: {
-                        "usage": stream_usages[stream_type],
-                        "bandwidth": stream_bandwidths.get(stream_type, 0),
-                    }
-                    for stream_type in (STREAM_TYPE_MAIN, STREAM_TYPE_SUB)
-                    if stream_usages.get(stream_type)
-                },
             }
 
         return usages

frigate/test/http_api/test_debug_replay_api.py

@@ -2,6 +2,7 @@
 
 from unittest.mock import patch
 
+from frigate.jobs.debug_replay import NoRecordingsError
 from frigate.models import Event, Recordings, ReviewSegment
 from frigate.test.http_api.base_http_test import AuthTestClient, BaseTestHttp
 
@@ -66,6 +67,32 @@ class TestDebugReplayAPI(BaseTestHttp):
         # (CodeQL: information exposure through an exception).
         self.assertEqual(body["message"], "Invalid debug replay parameters")
 
+    def test_start_returns_404_when_no_recordings(self):
+        with patch(
+            "frigate.api.debug_replay.start_debug_replay_job",
+            side_effect=NoRecordingsError(
+                "No recordings found for camera 'front' in the specified time range"
+            ),
+        ):
+            with AuthTestClient(self.app) as client:
+                resp = client.post(
+                    "/debug_replay/start",
+                    json={
+                        "camera": "front",
+                        "start_time": 100,
+                        "end_time": 200,
+                    },
+                )
+
+        self.assertEqual(resp.status_code, 404)
+        body = resp.json()
+        self.assertFalse(body["success"])
+        # Message is hard-coded so we don't echo exception text back to clients
+        # (CodeQL: information exposure through an exception).
+        self.assertEqual(
+            body["message"], "No recordings found in the selected time range"
+        )
+
     def test_start_returns_409_when_session_already_active(self):
         with patch(
             "frigate.api.debug_replay.start_debug_replay_job",

frigate/test/http_api/test_http_camera_access.py

@@ -440,3 +440,68 @@ class TestGo2rtcStreamAccess(BaseTestHttp):
             f"limited_user should be denied on alias back_door_main; "
             f"got {resp.status_code}"
         )
+
+
+class TestReviewSummaryAccess(BaseTestHttp):
+    """Tests for POST /review/summarize/start/{start_ts}/end/{end_ts}.
+
+    The summary correlates each flagged event with overlapping activity on
+    other cameras, so it is gated on full camera access rather than scoped to
+    the caller's cameras. These tests pin that decision so the dependency is
+    not loosened without first scoping the query.
+
+    GenAI is not configured in unit tests, so an authorized request returns 400
+    while an unauthorized one is rejected with 403 before the handler runs.
+    """
+
+    def setUp(self):
+        super().setUp([Event, ReviewSegment, Recordings])
+        self.minimal_config = _MULTI_CAMERA_CONFIG
+        self.app = super().create_app()
+
+    def tearDown(self):
+        self.app.dependency_overrides.clear()
+        super().tearDown()
+
+    def _summarize(self, allowed_cameras: list[str]):
+        async def mock_cameras(request: Request):
+            return allowed_cameras
+
+        self.app.dependency_overrides[get_allowed_cameras_for_filter] = mock_cameras
+        with AuthTestClient(self.app) as client:
+            return client.post("/review/summarize/start/0/end/9999999999")
+
+    def _assert_allowed(self, resp):
+        assert resp.status_code not in (401, 403), (
+            f"Caller should not be blocked; got {resp.status_code}"
+        )
+
+    def test_partial_camera_access_blocked(self):
+        assert self._summarize(["front_door"]).status_code == 403
+
+    def test_no_camera_access_blocked(self):
+        assert self._summarize([]).status_code == 403
+
+    def test_full_camera_access_allowed(self):
+        # Covers admin and viewer, which always resolve to every camera, and a
+        # custom role whose list happens to name them all.
+        self._assert_allowed(self._summarize(["front_door", "back_door"]))
+
+    def _summarize_as_role(self, role: str):
+        """Summarize using the real role to allowed-cameras resolution."""
+        self.app.dependency_overrides.pop(get_allowed_cameras_for_filter, None)
+        with AuthTestClient(self.app) as client:
+            return client.post(
+                "/review/summarize/start/0/end/9999999999",
+                headers={"remote-user": "test", "remote-role": role},
+            )
+
+    def test_viewer_role_allowed(self):
+        # viewer is never camera restricted, so it resolves to every camera.
+        self._assert_allowed(self._summarize_as_role("viewer"))
+
+    def test_admin_role_allowed(self):
+        self._assert_allowed(self._summarize_as_role("admin"))
+
+    def test_restricted_role_blocked(self):
+        assert self._summarize_as_role("limited_user").status_code == 403

frigate/test/http_api/test_http_config_set.py

@@ -386,19 +386,9 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
         guess (mode still equals the previous global) wrongly claims a camera
         whose explicit yaml mode happens to match.
         """
-        self.minimal_config["birdseye"] = {
+        self.minimal_config["birdseye"] = {"enabled": True, "mode": "motion"}
-            "enabled": True,
-            "mode": {"motion": True},
-        }
         # explicit override that matches the global value being replaced
-        self.minimal_config["cameras"]["front_door"]["birdseye"] = {
+        self.minimal_config["cameras"]["front_door"]["birdseye"] = {"mode": "motion"}
-            "mode": {
-                "continuous": False,
-                "motion": True,
-                "objects": False,
-                "stationary_objects": False,
-            }
-        }
 
         config_path = self._write_config_file()
         mock_find_config.return_value = config_path
@@ -409,16 +399,7 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
                 resp = client.put(
                     "/config/set",
                     json={
-                        "config_data": {
+                        "config_data": {"birdseye": {"mode": "continuous"}},
-                            "birdseye": {
-                                "mode": {
-                                    "continuous": True,
-                                    "motion": False,
-                                    "objects": False,
-                                    "stationary_objects": False,
-                                }
-                            }
-                        },
                         "update_topic": "config/birdseye",
                         "requires_restart": 0,
                     },
@@ -430,7 +411,7 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
                 mock_publisher.publisher.publish.assert_called_once()
                 topic, settings = mock_publisher.publisher.publish.call_args[0]
                 self.assertEqual(topic, "config/birdseye")
-                self.assertEqual(settings.mode.to_mqtt_payload(), "CONTINUOUS")
+                self.assertEqual(settings.mode.value, "continuous")
 
                 published = {
                     call[0][0].camera: call[0][1]
@@ -444,12 +425,8 @@ class TestConfigSetWildcardPropagation(BaseTestHttp):
                     )
 
                 # the override survives, the inheriting camera follows global
-                self.assertEqual(
+                self.assertEqual(published["front_door"].mode.value, "motion")
-                    published["front_door"].mode.to_mqtt_payload(), "MOTION"
+                self.assertEqual(published["back_yard"].mode.value, "continuous")
-                )
-                self.assertEqual(
-                    published["back_yard"].mode.to_mqtt_payload(), "CONTINUOUS"
-                )
         finally:
             os.unlink(config_path)
 

frigate/test/http_api/test_http_password.py

@@ -0,0 +1,113 @@
+"""Tests for password change authorization."""
+
+from fastapi import Request
+
+from frigate.api.auth import get_current_user, hash_password, verify_password
+from frigate.models import Event, Recordings, ReviewSegment, User
+from frigate.test.http_api.base_http_test import AuthTestClient, BaseTestHttp
+
+# Config carrying a custom role, which is the class of user the literal
+# "viewer" check used to let through.
+_CUSTOM_ROLE_CONFIG = {
+    "mqtt": {"host": "mqtt"},
+    "auth": {"roles": {"neighbor": ["front_door"]}, "hash_iterations": 10},
+    "cameras": {
+        "front_door": {
+            "ffmpeg": {
+                "inputs": [{"path": "rtsp://10.0.0.1:554/video", "roles": ["detect"]}]
+            },
+            "detect": {"height": 1080, "width": 1920, "fps": 5},
+        },
+    },
+}
+
+ADMIN_PASSWORD = "admin-real-password"
+NEW_PASSWORD = "AttackerChosenPassword123!"
+
+
+class TestUpdatePasswordAccess(BaseTestHttp):
+    def setUp(self):
+        super().setUp([Event, ReviewSegment, Recordings, User])
+        self.minimal_config = _CUSTOM_ROLE_CONFIG
+        self.app = super().create_app()
+        User.insert(
+            username="admin",
+            password_hash=hash_password(ADMIN_PASSWORD, iterations=10),
+            role="admin",
+            notification_tokens=[],
+        ).execute()
+
+        async def mock_get_current_user(request: Request):
+            return {
+                "username": request.headers.get("remote-user"),
+                "role": request.headers.get("remote-role"),
+            }
+
+        self.app.dependency_overrides[get_current_user] = mock_get_current_user
+
+    def tearDown(self):
+        self.app.dependency_overrides.clear()
+        super().tearDown()
+
+    def _change_password(self, actor: str, role: str, target: str, old_password: str):
+        with AuthTestClient(self.app) as client:
+            return client.put(
+                f"/users/{target}/password",
+                json={"password": NEW_PASSWORD, "old_password": old_password},
+                headers={"remote-user": actor, "remote-role": role},
+            )
+
+    def _admin_password_unchanged(self) -> bool:
+        return verify_password(ADMIN_PASSWORD, User.get_by_id("admin").password_hash)
+
+    def test_custom_role_cannot_target_another_account(self):
+        resp = self._change_password("neighbor", "neighbor", "admin", "wrong-guess")
+        assert resp.status_code == 403
+        assert self._admin_password_unchanged()
+
+    def test_custom_role_cannot_target_another_account_with_correct_password(self):
+        # The 403 must land before old_password is checked, so knowing the
+        # target's password is not a way through
+        resp = self._change_password("neighbor", "neighbor", "admin", ADMIN_PASSWORD)
+        assert resp.status_code == 403
+        assert self._admin_password_unchanged()
+
+    def test_viewer_cannot_target_another_account(self):
+        resp = self._change_password("viewer_user", "viewer", "admin", ADMIN_PASSWORD)
+        assert resp.status_code == 403
+        assert self._admin_password_unchanged()
+
+    def test_admin_can_target_another_account(self):
+        User.insert(
+            username="neighbor",
+            password_hash=hash_password("neighbor-password", iterations=10),
+            role="neighbor",
+            notification_tokens=[],
+        ).execute()
+
+        resp = self._change_password("admin", "admin", "neighbor", "")
+        assert resp.status_code == 200
+
+    def test_non_admin_can_change_own_password(self):
+        User.insert(
+            username="neighbor",
+            password_hash=hash_password("neighbor-password", iterations=10),
+            role="neighbor",
+            notification_tokens=[],
+        ).execute()
+
+        resp = self._change_password(
+            "neighbor", "neighbor", "neighbor", "neighbor-password"
+        )
+        assert resp.status_code == 200
+
+    def test_non_admin_own_password_still_requires_old_password(self):
+        User.insert(
+            username="neighbor",
+            password_hash=hash_password("neighbor-password", iterations=10),
+            role="neighbor",
+            notification_tokens=[],
+        ).execute()
+
+        resp = self._change_password("neighbor", "neighbor", "neighbor", "wrong-guess")
+        assert resp.status_code == 401

frigate/test/test_birdseye.py

@@ -1,70 +1,13 @@
-"""Tests for Birdseye canvas sizing and layout behavior."""
+"""Test camera user and password cleanup."""
 
 import multiprocessing as mp
 import unittest
-from unittest.mock import Mock
 
-from frigate.config import BirdseyeModeConfig, FrigateConfig
+from frigate.config import FrigateConfig
-from frigate.output.birdseye import (
+from frigate.output.birdseye import BirdsEyeFrameManager, get_canvas_shape
-    Birdseye,
-    BirdseyeActivity,
-    BirdsEyeFrameManager,
-    get_canvas_shape,
-)
 
 
 class TestBirdseye(unittest.TestCase):
-    def _build_manager(
-        self, camera_dimensions: dict[str, tuple[int, int]]
-    ) -> BirdsEyeFrameManager:
-        config = {
-            "mqtt": {"host": "mqtt"},
-            "birdseye": {"width": 1280, "height": 720},
-            "cameras": {},
-        }
-
-        for order, (camera, dimensions) in enumerate(
-            camera_dimensions.items(), start=1
-        ):
-            config["cameras"][camera] = {
-                "ffmpeg": {
-                    "inputs": [
-                        {
-                            "path": f"rtsp://10.0.0.1:554/{camera}",
-                            "roles": ["detect"],
-                        }
-                    ]
-                },
-                "detect": {
-                    "width": dimensions[0],
-                    "height": dimensions[1],
-                    "fps": 5,
-                },
-                "birdseye": {"order": order},
-            }
-
-        return BirdsEyeFrameManager(FrigateConfig(**config), mp.Event())
-
-    def _assert_no_overlaps(
-        self, layout: list[list[tuple[str, tuple[int, int, int, int]]]]
-    ):
-        rectangles = [position for row in layout for _, position in row]
-
-        for index, rect in enumerate(rectangles):
-            x1, y1, width1, height1 = rect
-            for other in rectangles[index + 1 :]:
-                x2, y2, width2, height2 = other
-                overlap = (
-                    x1 < x2 + width2
-                    and x2 < x1 + width1
-                    and y1 < y2 + height2
-                    and y2 < y1 + height1
-                )
-                self.assertFalse(
-                    overlap,
-                    msg=f"Overlapping rectangles found: {rect} and {other}",
-                )
-
     def test_16x9(self):
         """Test 16x9 aspect ratio works as expected for birdseye."""
         width = 1280
@@ -105,212 +48,6 @@ class TestBirdseye(unittest.TestCase):
         assert canvas_width == width  # width will be the same
         assert canvas_height != height
 
-    def test_portrait_camera_does_not_overlap_next_row(self):
-        """Portrait cameras should reserve their real horizontal position on the next row."""
-        manager = self._build_manager(
-            {
-                "cam_a": (1280, 720),
-                "cam_p": (360, 640),
-                "cam_b": (1280, 720),
-                "cam_c": (640, 480),
-            }
-        )
-
-        layout = manager.calculate_layout(["cam_a", "cam_p", "cam_b", "cam_c"], 3)
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-        cam_c = [
-            position for row in layout for camera, position in row if camera == "cam_c"
-        ][0]
-        self.assertEqual(cam_c[0], 0)
-
-    def test_portrait_reservation_only_applies_to_next_row(self):
-        """Portrait reservations should not push later rows after the span ends."""
-        manager = self._build_manager(
-            {
-                "cam_a": (1280, 720),
-                "cam_p": (360, 640),
-                "cam_b": (1280, 720),
-                "cam_c": (1280, 720),
-                "cam_d": (1280, 720),
-                "cam_e": (1280, 720),
-            }
-        )
-
-        layout = manager.calculate_layout(
-            ["cam_a", "cam_p", "cam_b", "cam_c", "cam_d", "cam_e"],
-            3,
-        )
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-        cam_e = [
-            position for row in layout for camera, position in row if camera == "cam_e"
-        ][0]
-        self.assertEqual(cam_e[0], 0)
-
-    def test_multiple_portraits_reserve_distinct_ranges(self):
-        """Multiple portrait cameras in one row should reserve separate spans below them."""
-        manager = self._build_manager(
-            {
-                "cam_a": (640, 480),
-                "cam_p1": (360, 640),
-                "cam_p2": (360, 640),
-                "cam_b": (640, 480),
-                "cam_c": (1280, 720),
-                "cam_d": (640, 480),
-            }
-        )
-
-        layout = manager.calculate_layout(
-            ["cam_a", "cam_p1", "cam_p2", "cam_b", "cam_c", "cam_d"],
-            4,
-        )
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-    def test_two_landscapes_then_portrait_then_two_landscapes(self):
-        """A portrait after two landscapes should reserve only its own tail span."""
-        manager = self._build_manager(
-            {
-                "cam_a": (1280, 720),
-                "cam_b": (1280, 720),
-                "cam_p": (360, 640),
-                "cam_c": (1280, 720),
-                "cam_d": (1280, 720),
-            }
-        )
-
-        layout = manager.calculate_layout(
-            ["cam_a", "cam_b", "cam_p", "cam_c", "cam_d"],
-            3,
-        )
-
-        self.assertIsNotNone(layout)
-        assert layout is not None
-        self._assert_no_overlaps(layout)
-
-        cam_c = [
-            position for row in layout for camera, position in row if camera == "cam_c"
-        ][0]
-        cam_d = [
-            position for row in layout for camera, position in row if camera == "cam_d"
-        ][0]
-        self.assertEqual(cam_c[0], 0)
-        self.assertEqual(cam_d[0], cam_c[0] + cam_c[2])
-
-
-class TestBirdseyeActivity(unittest.TestCase):
-    """Test which camera activity is included in each Birdseye mode."""
-
-    def setUp(self):
-        config = {
-            "mqtt": {"enabled": False},
-            "birdseye": {
-                "enabled": True,
-                "mode": {
-                    "motion": True,
-                    "objects": True,
-                    "stationary_objects": True,
-                },
-            },
-            "cameras": {
-                "front": {
-                    "ffmpeg": {
-                        "inputs": [
-                            {"path": "rtsp://10.0.0.1:554/video", "roles": ["detect"]}
-                        ]
-                    },
-                    "detect": {"height": 1080, "width": 1920, "fps": 5},
-                }
-            },
-        }
-        self.manager = BirdsEyeFrameManager(FrigateConfig(**config), mp.Event())
-
-    def test_existing_modes_keep_their_activity_rules(self):
-        continuous = BirdseyeModeConfig(continuous=True)
-        motion = BirdseyeModeConfig(motion=True)
-        objects = BirdseyeModeConfig(objects=True)
-
-        no_activity = BirdseyeActivity(False, False, False)
-        motion_activity = BirdseyeActivity(False, False, True)
-        stationary_activity = BirdseyeActivity(False, True, False)
-        active_object_activity = BirdseyeActivity(True, False, False)
-
-        assert self.manager.camera_active(continuous, no_activity)
-        assert self.manager.camera_active(motion, motion_activity)
-        assert not self.manager.camera_active(motion, stationary_activity)
-        assert self.manager.camera_active(objects, active_object_activity)
-        assert not self.manager.camera_active(objects, stationary_activity)
-
-    def test_modes_can_be_combined(self):
-        mode = BirdseyeModeConfig(motion=True, stationary_objects=True)
-
-        assert self.manager.camera_active(mode, BirdseyeActivity(False, False, True))
-        assert self.manager.camera_active(mode, BirdseyeActivity(False, True, False))
-        assert not self.manager.camera_active(
-            mode, BirdseyeActivity(False, False, False)
-        )
-
-    def test_stationary_objects_are_independent_from_active_objects(self):
-        stationary_objects = BirdseyeModeConfig(stationary_objects=True)
-
-        assert self.manager.camera_active(
-            stationary_objects, BirdseyeActivity(False, True, False)
-        )
-        assert not self.manager.camera_active(
-            stationary_objects, BirdseyeActivity(True, False, False)
-        )
-
-    def test_write_data_preserves_active_and_confirms_stationary_activity(self):
-        birdseye = Birdseye.__new__(Birdseye)
-        birdseye.birdseye_manager = Mock()
-        birdseye.birdseye_manager.update.return_value = (False, False)
-        birdseye._idle_interval = None
-        frame = Mock()
-
-        birdseye.write_data(
-            "front",
-            [
-                {"stationary": True, "false_positive": True},
-                {"stationary": False, "false_positive": True},
-                {"stationary": True, "false_positive": False},
-            ],
-            [[0, 0, 10, 10]],
-            1.0,
-            frame,
-        )
-
-        birdseye.birdseye_manager.update.assert_called_once_with(
-            "front", BirdseyeActivity(True, True, True), 1.0, frame
-        )
-
-    def test_stationary_false_positive_does_not_activate_birdseye(self):
-        birdseye = Birdseye.__new__(Birdseye)
-        birdseye.birdseye_manager = Mock()
-        birdseye.birdseye_manager.update.return_value = (False, False)
-        birdseye._idle_interval = None
-        frame = Mock()
-
-        birdseye.write_data(
-            "front",
-            [{"stationary": True, "false_positive": True}],
-            [],
-            1.0,
-            frame,
-        )
-
-        birdseye.birdseye_manager.update.assert_called_once_with(
-            "front", BirdseyeActivity(False, False, False), 1.0, frame
-        )
-
 
 class TestBirdseyeCameraOrder(unittest.TestCase):
     """Test that birdseye reacts to camera order changes without a restart."""
@@ -318,7 +55,7 @@ class TestBirdseyeCameraOrder(unittest.TestCase):
     def setUp(self):
         config = {
             "mqtt": {"enabled": False},
-            "birdseye": {"enabled": True, "mode": {"continuous": True}},
+            "birdseye": {"enabled": True, "mode": "continuous"},
             "cameras": {
                 camera: {
                     "ffmpeg": {

frigate/test/test_camera_config_updater.py

@@ -1,102 +0,0 @@
-"""Tests for dynamic camera config updates recreating ffmpeg commands."""
-
-import unittest
-from unittest.mock import patch
-
-from frigate.config import CameraConfig, FrigateConfig
-from frigate.config.camera.updater import (
-    CameraConfigUpdateEnum,
-    CameraConfigUpdateSubscriber,
-)
-from frigate.const import SUB_CACHE_TAG
-
-
-def _build_camera_config(sub_enabled: bool) -> CameraConfig:
-    config = FrigateConfig(
-        **{
-            "mqtt": {"host": "mqtt"},
-            "cameras": {
-                "front_door": {
-                    "ffmpeg": {
-                        "inputs": [
-                            {
-                                "path": "rtsp://10.0.0.1:554/video",
-                                "roles": ["detect", "record"],
-                            },
-                            {
-                                "path": "rtsp://10.0.0.1:554/video2",
-                                "roles": ["record_sub"],
-                            },
-                        ]
-                    },
-                    "record": {"enabled": True, "sub": {"enabled": sub_enabled}},
-                }
-            },
-        }
-    )
-    return config.cameras["front_door"]
-
-
-def _has_sub_output(camera_config: CameraConfig) -> bool:
-    return any(
-        SUB_CACHE_TAG in part for c in camera_config.ffmpeg_cmds for part in c["cmd"]
-    )
-
-
-class TestRecordUpdateRecreatesFfmpegCmds(unittest.TestCase):
-    def setUp(self):
-        # avoid binding a real ZMQ socket; updates are fed directly through
-        # the mocked subscriber below
-        patcher = patch("frigate.config.camera.updater.ConfigSubscriber")
-        patcher.start()
-        self.addCleanup(patcher.stop)
-
-    def _push_record_update(
-        self, subscriber: CameraConfigUpdateSubscriber, record_config
-    ) -> None:
-        subscriber.subscriber.check_for_update.side_effect = [
-            ("config/cameras/front_door/record", record_config),
-            (None, None),
-        ]
-        subscriber.check_for_updates()
-
-    def test_enabling_sub_recreates_ffmpeg_cmds(self):
-        camera_config = _build_camera_config(sub_enabled=False)
-        subscriber = CameraConfigUpdateSubscriber(
-            None, {"front_door": camera_config}, [CameraConfigUpdateEnum.record]
-        )
-        assert not _has_sub_output(camera_config)
-
-        self._push_record_update(
-            subscriber, _build_camera_config(sub_enabled=True).record
-        )
-
-        assert _has_sub_output(camera_config)
-
-    def test_disabling_sub_recreates_ffmpeg_cmds(self):
-        camera_config = _build_camera_config(sub_enabled=True)
-        subscriber = CameraConfigUpdateSubscriber(
-            None, {"front_door": camera_config}, [CameraConfigUpdateEnum.record]
-        )
-        assert _has_sub_output(camera_config)
-
-        self._push_record_update(
-            subscriber, _build_camera_config(sub_enabled=False).record
-        )
-
-        assert not _has_sub_output(camera_config)
-
-    def test_unchanged_record_update_keeps_existing_cmds(self):
-        camera_config = _build_camera_config(sub_enabled=False)
-        subscriber = CameraConfigUpdateSubscriber(
-            None, {"front_door": camera_config}, [CameraConfigUpdateEnum.record]
-        )
-        cmds_before = camera_config.ffmpeg_cmds
-
-        # neither enabled_in_config nor sub.enabled changed, so the
-        # commands should not be rebuilt
-        self._push_record_update(
-            subscriber, _build_camera_config(sub_enabled=False).record
-        )
-
-        assert camera_config.ffmpeg_cmds is cmds_before

frigate/test/test_camera_lifecycle.py

@@ -1,227 +0,0 @@
-"""Regression tests for runtime camera add and delete handling."""
-
-import asyncio
-import threading
-import unittest
-from types import SimpleNamespace
-from unittest.mock import MagicMock
-
-# LicensePlatePostProcessor is imported via the maintainer rather than from
-# data_processing.post.license_plate, which circularly imports back through
-# frigate.embeddings before that package finishes initializing
-from frigate.embeddings.maintainer import (
-    EmbeddingMaintainer,
-    LicensePlatePostProcessor,
-)
-from frigate.ptz.autotrack import PtzAutoTracker
-from frigate.review.maintainer import ReviewSegmentMaintainer
-from frigate.track.object_processing import TrackedObjectProcessor
-
-
-def _make_processor() -> TrackedObjectProcessor:
-    """Build a processor with no cameras, bypassing __init__."""
-    processor = TrackedObjectProcessor.__new__(TrackedObjectProcessor)
-    processor.camera_states = {}
-    processor.camera_states_lock = threading.Lock()
-    processor.config = SimpleNamespace(cameras={})
-    processor.event_sender = MagicMock()
-    processor.detection_publisher = MagicMock()
-    processor.ongoing_manual_events = {}
-    return processor
-
-
-class TestObjectProcessorUnknownCamera(unittest.TestCase):
-    def test_save_lpr_snapshot_ignores_unknown_camera(self):
-        processor = _make_processor()
-
-        # 1x1 png, base64; decoding must not be what fails
-        payload = (
-            "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mP8z8BQDwAEhQGAhKmMIQAAAABJRU5ErkJggg==",
-            "1234.5-abcdef",
-            "deleted_cam",
-        )
-
-        processor.save_lpr_snapshot(payload)
-
-        processor.event_sender.publish.assert_not_called()
-
-    def test_create_manual_event_ignores_unknown_camera(self):
-        processor = _make_processor()
-
-        payload = (
-            1234.5,
-            "deleted_cam",
-            "person",
-            "1234.5-abcdef",
-            True,
-            0.9,
-            None,
-            None,
-            "api",
-            False,
-            None,
-        )
-
-        processor.create_manual_event(payload)
-
-        processor.event_sender.publish.assert_not_called()
-        self.assertEqual(processor.ongoing_manual_events, {})
-
-    def test_create_lpr_event_ignores_unknown_camera(self):
-        processor = _make_processor()
-
-        payload = (
-            1234.5,
-            "deleted_cam",
-            "license_plate",
-            "1234.5-abcdef",
-            True,
-            0.9,
-            None,
-            "ABC123",
-        )
-
-        processor.create_lpr_event(payload)
-
-        processor.event_sender.publish.assert_not_called()
-        self.assertEqual(processor.ongoing_manual_events, {})
-
-    def test_create_manual_event_ignores_camera_added_but_not_yet_drained(self):
-        """The add window: present in config.cameras, absent from camera_states.
-
-        debug_replay writes the camera into the shared config before publishing
-        add, so a guard on config.cameras passes here and falls through to
-        camera_states. This test fails against such a guard.
-        """
-        processor = _make_processor()
-        processor.config = SimpleNamespace(
-            cameras={
-                "new_cam": SimpleNamespace(
-                    record=SimpleNamespace(event_pre_capture=5, enabled=True)
-                )
-            }
-        )
-
-        payload = (
-            1234.5,
-            "new_cam",
-            "person",
-            "1234.5-abcdef",
-            True,
-            0.9,
-            None,
-            None,
-            "api",
-            False,
-            None,
-        )
-
-        processor.create_manual_event(payload)
-
-        processor.event_sender.publish.assert_not_called()
-
-
-class TestEmbeddingsUnknownCamera(unittest.TestCase):
-    def _make_maintainer(self) -> EmbeddingMaintainer:
-        maintainer = EmbeddingMaintainer.__new__(EmbeddingMaintainer)
-        maintainer.config = SimpleNamespace(cameras={})
-        maintainer.event_end_subscriber = MagicMock()
-        maintainer.realtime_processors = [MagicMock()]
-        # spec is required: the dispatch loop is a chain of isinstance checks,
-        # and a bare MagicMock matches none of them, so the crashing branch
-        # would never run and the test would pass against unfixed code
-        maintainer.post_processors = [MagicMock(spec=LicensePlatePostProcessor)]
-        maintainer.detected_license_plates = {"1234.5-abcdef": {"obj_data": {}}}
-        maintainer.recordings_available_through = {"deleted_cam": 1234.5}
-        maintainer.event_metadata_publisher = MagicMock()
-        return maintainer
-
-    def test_process_finalized_skips_unknown_camera(self):
-        maintainer = self._make_maintainer()
-        # updated_db=False bypasses the Event.get branch, which would hit the
-        # database and mask the KeyError this test is about
-        maintainer.event_end_subscriber.check_for_update.side_effect = [
-            ("1234.5-abcdef", "deleted_cam", False),
-            None,
-        ]
-
-        maintainer._process_finalized()
-
-        maintainer.post_processors[0].process_data.assert_not_called()
-
-    def test_process_finalized_still_expires_realtime_state(self):
-        """The guard must not skip per-event cleanup, only post processing."""
-        maintainer = self._make_maintainer()
-        maintainer.event_end_subscriber.check_for_update.side_effect = [
-            ("1234.5-abcdef", "deleted_cam", False),
-            None,
-        ]
-
-        maintainer._process_finalized()
-
-        maintainer.realtime_processors[0].expire_object.assert_called_once_with(
-            "1234.5-abcdef", "deleted_cam"
-        )
-
-    def test_expire_dedicated_lpr_drops_entry_for_unknown_camera(self):
-        maintainer = self._make_maintainer()
-        maintainer.detected_license_plates = {
-            "1234.5-abcdef": {"camera": "deleted_cam", "last_seen": 1.0}
-        }
-
-        maintainer._expire_dedicated_lpr()
-
-        self.assertEqual(maintainer.detected_license_plates, {})
-
-
-class TestReviewMaintainerRemoval(unittest.TestCase):
-    def test_camera_removal_ends_segment_and_clears_state(self):
-        maintainer = ReviewSegmentMaintainer.__new__(ReviewSegmentMaintainer)
-        maintainer.active_review_segments = {"deleted_cam": MagicMock()}
-        maintainer.indefinite_events = {"deleted_cam": {"1234.5-abcdef": 1.0}}
-        maintainer.forcibly_end_segment = MagicMock()
-
-        maintainer._handle_camera_removed("deleted_cam")
-
-        maintainer.forcibly_end_segment.assert_called_once_with("deleted_cam")
-        self.assertNotIn("deleted_cam", maintainer.indefinite_events)
-
-
-class TestAutotrackerMoveQueue(unittest.TestCase):
-    def test_move_queue_drops_move_for_removed_camera(self):
-        tracker = PtzAutoTracker.__new__(PtzAutoTracker)
-        tracker.stop_event = MagicMock()
-        # one pass through the loop, then stop
-        tracker.stop_event.is_set.side_effect = [False, True]
-        tracker.ptz_metrics = {}
-        tracker.move_queues = {"deleted_cam": asyncio.Queue()}
-        tracker.move_queue_locks = {"deleted_cam": asyncio.Lock()}
-        tracker.onvif = MagicMock()
-        tracker.config = SimpleNamespace(cameras={})
-        tracker.move_queues["deleted_cam"].put_nowait((1234.5, 0.1, 0.1, 0.0))
-
-        asyncio.run(tracker._process_move_queue("deleted_cam"))
-
-        tracker.onvif._move_relative.assert_not_called()
-
-
-class TestCameraStateAccessors(unittest.TestCase):
-    def test_get_camera_state_returns_none_for_unknown_camera(self):
-        processor = _make_processor()
-
-        self.assertIsNone(processor.get_camera_state("deleted_cam"))
-
-    def test_get_camera_states_returns_a_snapshot_not_a_view(self):
-        """A live values() view raises RuntimeError if the writer pops mid-iteration."""
-        processor = _make_processor()
-        processor.camera_states = {"one": MagicMock(), "two": MagicMock()}
-
-        states = processor.get_camera_states()
-        processor.camera_states.pop("one")
-
-        self.assertEqual(len(states), 2)
-
-    def test_get_current_frame_time_is_zero_for_unknown_camera(self):
-        processor = _make_processor()
-
-        self.assertEqual(processor.get_current_frame_time("deleted_cam"), 0.0)

frigate/test/test_config.py

@@ -1,14 +1,13 @@
 import json
 import os
 import unittest
-from copy import deepcopy
 from unittest.mock import patch
 
 import numpy as np
 from pydantic import ValidationError
 from ruamel.yaml.constructor import DuplicateKeyError
 
-from frigate.config import FrigateConfig, RetainModeEnum
+from frigate.config import BirdseyeModeEnum, FrigateConfig
 from frigate.const import MODEL_CACHE_DIR
 from frigate.detectors import DetectorTypeEnum
 from frigate.util.builtin import deep_merge
@@ -171,7 +170,7 @@ class TestConfig(unittest.TestCase):
     def test_override_birdseye(self):
         config = {
             "mqtt": {"host": "mqtt"},
-            "birdseye": {"enabled": True, "mode": {"continuous": True}},
+            "birdseye": {"enabled": True, "mode": "continuous"},
             "cameras": {
                 "back": {
                     "ffmpeg": {
@@ -184,30 +183,19 @@ class TestConfig(unittest.TestCase):
                         "width": 1920,
                         "fps": 5,
                     },
-                    "birdseye": {
+                    "birdseye": {"enabled": False, "mode": "motion"},
-                        "enabled": False,
-                        "mode": {"continuous": False, "motion": True},
-                    },
                 }
             },
         }
 
         frigate_config = FrigateConfig(**config)
         assert not frigate_config.cameras["back"].birdseye.enabled
-        mode = frigate_config.cameras["back"].birdseye.mode
+        assert frigate_config.cameras["back"].birdseye.mode is BirdseyeModeEnum.motion
-        assert mode.motion
-        assert not mode.continuous
-        assert not mode.objects
-        assert not mode.stationary_objects
 
     def test_override_birdseye_non_inheritable(self):
         config = {
             "mqtt": {"host": "mqtt"},
-            "birdseye": {
+            "birdseye": {"enabled": True, "mode": "continuous", "height": 1920},
-                "enabled": True,
-                "mode": {"continuous": True},
-                "height": 1920,
-            },
             "cameras": {
                 "back": {
                     "ffmpeg": {
@@ -230,7 +218,7 @@ class TestConfig(unittest.TestCase):
     def test_inherit_birdseye(self):
         config = {
             "mqtt": {"host": "mqtt"},
-            "birdseye": {"enabled": True, "mode": {"continuous": True}},
+            "birdseye": {"enabled": True, "mode": "continuous"},
             "cameras": {
                 "back": {
                     "ffmpeg": {
@@ -249,89 +237,9 @@ class TestConfig(unittest.TestCase):
 
         frigate_config = FrigateConfig(**config)
         assert frigate_config.cameras["back"].birdseye.enabled
-        mode = frigate_config.cameras["back"].birdseye.mode
+        assert (
-        assert mode.continuous
+            frigate_config.cameras["back"].birdseye.mode is BirdseyeModeEnum.continuous
-        assert not mode.motion
+        )
-        assert not mode.objects
-        assert not mode.stationary_objects
-
-    def test_combine_birdseye_activity_types(self):
-        config = {
-            **self.minimal,
-            "birdseye": {
-                "mode": {
-                    "motion": True,
-                    "stationary_objects": True,
-                }
-            },
-        }
-
-        frigate_config = FrigateConfig(**config)
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert mode.motion
-        assert mode.stationary_objects
-        assert not mode.continuous
-        assert not mode.objects
-
-    def test_birdseye_requires_an_activity_type(self):
-        config = {
-            **self.minimal,
-            "birdseye": {
-                "mode": {
-                    "continuous": False,
-                    "motion": False,
-                    "objects": False,
-                    "stationary_objects": False,
-                }
-            },
-        }
-
-        with self.assertRaisesRegex(
-            ValidationError, "must enable at least one Birdseye activity type"
-        ):
-            FrigateConfig(**config)
-
-    def test_camera_can_disable_an_inherited_activity_type(self):
-        config = {
-            **self.minimal,
-            "birdseye": {"mode": {"motion": True, "objects": True}},
-        }
-        config["cameras"]["back"]["birdseye"] = {"mode": {"motion": False}}
-
-        frigate_config = FrigateConfig(**config)
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert not mode.motion
-        assert mode.objects
-
-    def test_profile_must_leave_an_activity_type_enabled(self):
-        config = {
-            **self.minimal,
-            "profiles": {"away": {"friendly_name": "Away"}},
-            "birdseye": {"mode": {"objects": True}},
-        }
-        config["cameras"]["back"]["profiles"] = {
-            "away": {"birdseye": {"mode": {"objects": False}}}
-        }
-
-        with self.assertRaisesRegex(
-            ValidationError, "must enable at least one Birdseye activity type"
-        ):
-            FrigateConfig(**config)
-
-    def test_camera_birdseye_activity_types_override_global_values(self):
-        config = {
-            **self.minimal,
-            "birdseye": {"mode": {"motion": True, "objects": True}},
-        }
-        config["cameras"]["back"]["birdseye"] = {
-            "mode": {"motion": False, "stationary_objects": True}
-        }
-
-        frigate_config = FrigateConfig(**config)
-        mode = frigate_config.cameras["back"].birdseye.mode
-        assert not mode.motion
-        assert mode.objects
-        assert mode.stationary_objects
 
     def test_override_tracked_objects(self):
         config = {
@@ -969,162 +877,6 @@ class TestConfig(unittest.TestCase):
         assert len(ffmpeg_cmds) == 1
         assert "clips" not in ffmpeg_cmds[0]["roles"]
 
-    def test_record_sub_cmd_writes_sub_cache_path(self):
-        config = {
-            "mqtt": {"host": "mqtt"},
-            "cameras": {
-                "back": {
-                    "ffmpeg": {
-                        "inputs": [
-                            {
-                                "path": "rtsp://10.0.0.1:554/video",
-                                "roles": ["detect", "record"],
-                            },
-                            {
-                                "path": "rtsp://10.0.0.1:554/video2",
-                                "roles": ["record_sub"],
-                            },
-                        ]
-                    },
-                    "record": {"enabled": True, "sub": {"enabled": True}},
-                }
-            },
-        }
-
-        frigate_config = FrigateConfig(**config)
-        cmds = frigate_config.cameras["back"].ffmpeg_cmds
-        sub_cmds = [c for c in cmds if "record_sub" in c["roles"]]
-        assert len(sub_cmds) == 1
-        joined = " ".join(sub_cmds[0]["cmd"])
-        assert "back@sub@" in joined
-
-    def test_record_sub_disabled_no_sub_cache_path(self):
-        config = {
-            "mqtt": {"host": "mqtt"},
-            "cameras": {
-                "back": {
-                    "ffmpeg": {
-                        "inputs": [
-                            {
-                                "path": "rtsp://10.0.0.1:554/video",
-                                "roles": ["detect", "record"],
-                            },
-                        ]
-                    },
-                    "record": {"enabled": True, "sub": {"enabled": False}},
-                }
-            },
-        }
-
-        frigate_config = FrigateConfig(**config)
-        cmds = frigate_config.cameras["back"].ffmpeg_cmds
-        assert all("@sub@" not in " ".join(c["cmd"]) for c in cmds)
-
-    def _sub_record_config(self, ffmpeg_extra: dict | None = None) -> dict:
-        return {
-            "mqtt": {"host": "mqtt"},
-            "cameras": {
-                "back": {
-                    "ffmpeg": {
-                        "inputs": [
-                            {
-                                "path": "rtsp://10.0.0.1:554/video",
-                                "roles": ["detect", "record"],
-                            },
-                            {
-                                "path": "rtsp://10.0.0.1:554/video2",
-                                "roles": ["record_sub"],
-                            },
-                        ],
-                        **(ffmpeg_extra or {}),
-                    },
-                    "record": {"enabled": True, "sub": {"enabled": True}},
-                }
-            },
-        }
-
-    def _sub_record_cmd(self, config: dict) -> str:
-        cmds = FrigateConfig(**config).cameras["back"].ffmpeg_cmds
-        sub_cmds = [c for c in cmds if "record_sub" in c["roles"]]
-        assert len(sub_cmds) == 1
-        return " ".join(sub_cmds[0]["cmd"])
-
-    def test_record_sub_output_args_inherit_record(self):
-        config = self._sub_record_config(
-            {"output_args": {"record": "preset-record-generic-audio-copy"}}
-        )
-
-        cmd = self._sub_record_cmd(config)
-        # the customized record args, not the stock aac default
-        assert "-c copy" in cmd
-        assert "-c:a aac" not in cmd
-
-    def test_record_sub_output_args_override_record(self):
-        config = self._sub_record_config(
-            {
-                "output_args": {
-                    "record": "preset-record-generic-audio-aac",
-                    "record_sub": "preset-record-generic",
-                }
-            }
-        )
-
-        cmd = self._sub_record_cmd(config)
-        assert "-c copy -an" in cmd
-        assert "-c:a aac" not in cmd
-
-    def test_record_output_args_unaffected_by_record_sub(self):
-        config = self._sub_record_config(
-            {
-                "output_args": {
-                    "record": "preset-record-generic-audio-aac",
-                    "record_sub": "preset-record-generic",
-                }
-            }
-        )
-
-        cmds = FrigateConfig(**config).cameras["back"].ffmpeg_cmds
-        record_cmd = " ".join(next(c for c in cmds if "record" in c["roles"])["cmd"])
-        assert "-c:a aac" in record_cmd
-
-    def test_record_sub_manual_output_args(self):
-        config = self._sub_record_config(
-            {
-                "output_args": {
-                    "record_sub": "-f segment -segment_time 10 -segment_format mp4 -reset_timestamps 1 -strftime 1 -c:v copy -c:a aac -ar 16000"
-                }
-            }
-        )
-
-        assert "-ar 16000" in self._sub_record_cmd(config)
-
-    def test_fails_on_bad_record_sub_segment_time(self):
-        config = self._sub_record_config(
-            {
-                "output_args": {
-                    "record_sub": "-f segment -segment_time 70 -segment_format mp4 -reset_timestamps 1 -strftime 1 -c copy -an"
-                }
-            }
-        )
-
-        self.assertRaisesRegex(
-            ValueError,
-            "segment_time",
-            lambda: FrigateConfig(**config).cameras,
-        )
-
-    def test_record_sub_segment_time_not_checked_when_disabled(self):
-        config = self._sub_record_config(
-            {
-                "output_args": {
-                    "record_sub": "-f segment -segment_time 70 -segment_format mp4 -reset_timestamps 1 -strftime 1 -c copy -an"
-                }
-            }
-        )
-        config["cameras"]["back"]["record"]["sub"]["enabled"] = False
-
-        FrigateConfig(**config).cameras
-
     def test_max_disappeared_default(self):
         config = {
             "mqtt": {"host": "mqtt"},
@@ -1367,44 +1119,6 @@ class TestConfig(unittest.TestCase):
 
         self.assertRaises(ValueError, lambda: FrigateConfig(**config))
 
-    def test_record_sub_config_defaults(self):
-        config = FrigateConfig(**self.minimal)
-        record = config.cameras["back"].record
-        assert record.sub.enabled is False
-        assert record.sub.continuous.days == 0
-        assert record.sub.alerts.mode == RetainModeEnum.motion
-
-    def test_record_sub_enabled_requires_role(self):
-        config = deepcopy(self.minimal)
-        config["cameras"]["back"]["ffmpeg"]["inputs"] = [
-            {"path": "rtsp://10.0.0.1:554/video", "roles": ["detect", "record"]},
-        ]
-        config["cameras"]["back"]["record"] = {
-            "enabled": True,
-            "sub": {"enabled": True},
-        }
-
-        # no record_sub role assigned -> must raise
-        self.assertRaisesRegex(
-            ValueError,
-            "record_sub is not assigned",
-            lambda: FrigateConfig(**config),
-        )
-
-    def test_record_sub_role_accepted(self):
-        config = deepcopy(self.minimal)
-        config["cameras"]["back"]["ffmpeg"]["inputs"] = [
-            {"path": "rtsp://10.0.0.1:554/video", "roles": ["detect", "record"]},
-            {"path": "rtsp://10.0.0.1:554/video2", "roles": ["record_sub"]},
-        ]
-        config["cameras"]["back"]["record"] = {
-            "enabled": True,
-            "sub": {"enabled": True, "continuous": {"days": 30}},
-        }
-
-        parsed = FrigateConfig(**config)
-        assert parsed.cameras["back"].record.sub.continuous.days == 30
-
     def test_works_on_missing_role_multiple_cams(self):
         config = {
             "mqtt": {"host": "mqtt"},

frigate/test/test_debug_replay_job.py

@@ -9,6 +9,7 @@ from unittest.mock import MagicMock, patch
 from frigate.debug_replay import DebugReplayManager
 from frigate.jobs.debug_replay import (
     DebugReplayJob,
+    NoRecordingsError,
     RecordingDebugReplaySource,
     cancel_debug_replay_job,
     get_active_runner,
@@ -129,7 +130,7 @@ class TestStartDebugReplayJob(unittest.TestCase):
         empty_qs = MagicMock()
         empty_qs.count.return_value = 0
         with patch("frigate.jobs.debug_replay.query_recordings", return_value=empty_qs):
-            with self.assertRaises(ValueError):
+            with self.assertRaises(NoRecordingsError):
                 start_debug_replay_job(
                     source=RecordingDebugReplaySource(
                         source_camera="front",

frigate/test/test_dispatcher_runtime_state.py

@@ -8,7 +8,6 @@ from unittest.mock import MagicMock, patch
 from frigate.app import FrigateApp
 from frigate.comms.dispatcher import Dispatcher
 from frigate.comms.runtime_state import RuntimeStatePersistence
-from frigate.config import BirdseyeModeConfig
 
 
 def _make_camera_mock(
@@ -52,58 +51,6 @@ def _build_dispatcher(cameras: dict[str, MagicMock]) -> Dispatcher:
         return Dispatcher(config, config_updater, onvif, ptz_metrics, communicators)
 
 
-class TestBirdseyeModeCommands(unittest.TestCase):
-    """Verify Birdseye mode commands use the boolean mode contract."""
-
-    def setUp(self) -> None:
-        self.camera = _make_camera_mock()
-        self.camera.birdseye.enabled = True
-        self.dispatcher = _build_dispatcher({"front_door": self.camera})
-        self.dispatcher.publish = MagicMock()
-
-    def test_combined_modes_are_accepted(self) -> None:
-        self.dispatcher._on_birdseye_mode_command(
-            "front_door", "STATIONARY_OBJECTS,MOTION"
-        )
-
-        self.assertEqual(
-            self.camera.birdseye.mode,
-            BirdseyeModeConfig(motion=True, stationary_objects=True),
-        )
-        self.dispatcher.config_updater.publish_update.assert_called_once()
-        self.dispatcher.publish.assert_called_once_with(
-            "front_door/birdseye_mode/state",
-            "MOTION,STATIONARY_OBJECTS",
-            retain=True,
-        )
-
-    def test_single_activity_type_is_accepted(self) -> None:
-        self.dispatcher._on_birdseye_mode_command("front_door", "OBJECTS")
-
-        self.assertEqual(
-            self.camera.birdseye.mode,
-            BirdseyeModeConfig(objects=True),
-        )
-        self.dispatcher.publish.assert_called_once_with(
-            "front_door/birdseye_mode/state", "OBJECTS", retain=True
-        )
-
-    def test_unknown_mode_is_rejected(self) -> None:
-        for payload in (
-            "UNKNOWN",
-            "motion",
-            "MOTION_OBJECTS",
-            "NONE",
-            "NONE,MOTION",
-            "MOTION,MOTION",
-            "MOTION,",
-        ):
-            with self.subTest(payload=payload):
-                self.dispatcher._on_birdseye_mode_command("front_door", payload)
-
-        self.dispatcher.config_updater.publish_update.assert_not_called()
-
-
 class TestRestoreRuntimeState(unittest.TestCase):
     """Verify replay routes through handlers and tolerates missing entries."""
 

frigate/test/test_event_cleanup_sub.py

@@ -1,127 +0,0 @@
-"""Tests for sub stream retention extending event clip lifetimes."""
-
-import datetime
-import unittest
-from unittest.mock import MagicMock
-
-from playhouse.sqlite_ext import SqliteExtDatabase
-
-from frigate.config import FrigateConfig
-from frigate.events.cleanup import EventCleanup
-from frigate.models import Event, Timeline
-
-
-class TestEventCleanupSubRetention(unittest.TestCase):
-    def setUp(self):
-        # in-memory database keeps these tests isolated from the shared
-        # on-disk test.db used by the http api tests
-        self.db = SqliteExtDatabase(":memory:")
-        models = [Event, Timeline]
-        self.db.bind(models)
-        self.db.create_tables(models)
-
-    def tearDown(self):
-        self.db.close()
-
-    def _build_cleanup(self, record_config: dict) -> EventCleanup:
-        config = FrigateConfig(
-            **{
-                "mqtt": {"host": "mqtt"},
-                "cameras": {
-                    "front_door": {
-                        "ffmpeg": {
-                            "inputs": [
-                                {
-                                    "path": "rtsp://10.0.0.1:554/video",
-                                    "roles": ["detect", "record"],
-                                },
-                                {
-                                    "path": "rtsp://10.0.0.1:554/video2",
-                                    "roles": ["record_sub"],
-                                },
-                            ]
-                        },
-                        "record": record_config,
-                    }
-                },
-            }
-        )
-        return EventCleanup(config, MagicMock(), MagicMock())
-
-    def _insert_event(self, id: str, age_days: float, severity: str = "alert") -> None:
-        end_time = (
-            datetime.datetime.now() - datetime.timedelta(days=age_days)
-        ).timestamp()
-        Event.create(
-            id=id,
-            label="person",
-            camera="front_door",
-            start_time=end_time - 10,
-            end_time=end_time,
-            top_score=0.9,
-            score=0.9,
-            false_positive=False,
-            zones=[],
-            thumbnail="",
-            has_clip=True,
-            has_snapshot=False,
-            region=[],
-            box=[],
-            area=0,
-            retain_indefinitely=False,
-            plus_id="",
-            model_hash="",
-            detector_type="cpu",
-            model_type="ssd",
-            data={"max_severity": severity},
-        )
-
-    def test_sub_alerts_days_extends_event_clip_retention(self):
-        # a 20-day-old alert event keeps its clip for the 60 day sub window
-        # so Explore stays coherent with the surviving sub recordings
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "alerts": {"retain": {"days": 10}},
-                "sub": {"enabled": True, "alerts": {"days": 60}},
-            }
-        )
-        self._insert_event("e1", 20)
-
-        expired = cleanup.expire_clips()
-
-        assert "e1" not in expired
-        assert Event.get(Event.id == "e1").has_clip is True
-
-    def test_event_clip_expires_when_sub_disabled(self):
-        # with sub recording disabled, the 20-day-old alert event expires
-        # under the 10 day main alerts retention exactly as before
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "alerts": {"retain": {"days": 10}},
-                "sub": {"enabled": False, "alerts": {"days": 60}},
-            }
-        )
-        self._insert_event("e1", 20)
-
-        expired = cleanup.expire_clips()
-
-        assert "e1" in expired
-        assert Event.get(Event.id == "e1").has_clip is False
-
-    def test_sub_detections_days_extends_event_clip_retention(self):
-        # detection severity uses the sub detections window
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "detections": {"retain": {"days": 10}},
-                "sub": {"enabled": True, "detections": {"days": 60}},
-            }
-        )
-        self._insert_event("e1", 20, severity="detection")
-
-        expired = cleanup.expire_clips()
-
-        assert "e1" not in expired
-        assert Event.get(Event.id == "e1").has_clip is True

frigate/test/test_gpu_stats.py

@@ -1,12 +1,7 @@
 import unittest
-from io import StringIO
 from unittest.mock import MagicMock, patch
 
-from frigate.util.services import (
+from frigate.util.services import get_amd_gpu_stats, get_intel_gpu_stats
-    get_amd_gpu_stats,
-    get_intel_gpu_stats,
-    get_openvino_npu_stats,
-)
 
 
 class TestGpuStats(unittest.TestCase):
@@ -22,88 +17,6 @@ class TestGpuStats(unittest.TestCase):
         amd_stats = get_amd_gpu_stats()
         assert amd_stats == {"gpu": "4.17%", "mem": "60.37%"}
 
-    @patch("frigate.util.services.time.sleep")
-    @patch("frigate.util.services.time.time", side_effect=[0.0, 1.0])
-    @patch(
-        "frigate.util.services.os.readlink",
-        return_value="/sys/bus/pci/drivers/intel_vpu",
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=["/sys/class/accel/accel0"],
-    )
-    @patch(
-        "builtins.open",
-        side_effect=[StringIO("1000"), StringIO("1250")],
-    )
-    def test_openvino_npu_stats_discovers_accel0(
-        self, open_file, glob, readlink, time, sleep
-    ):
-        assert get_openvino_npu_stats() == {"npu": "25.0", "mem": "-%"}
-
-        open_file.assert_any_call(
-            "/sys/class/accel/accel0/device/power/runtime_active_time"
-        )
-
-    @patch("frigate.util.services.time.sleep")
-    @patch("frigate.util.services.time.time", side_effect=[0.0, 1.0])
-    @patch(
-        "frigate.util.services.os.readlink",
-        side_effect=[
-            "/sys/bus/pci/drivers/other",
-            "/sys/bus/pci/drivers/intel_vpu",
-        ],
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=[
-            "/sys/class/accel/accel0",
-            "/sys/class/accel/accel1",
-        ],
-    )
-    @patch(
-        "builtins.open",
-        side_effect=[StringIO("1000"), StringIO("1250")],
-    )
-    def test_openvino_npu_stats_skips_non_intel_accelerator(
-        self, open_file, glob, readlink, time, sleep
-    ):
-        assert get_openvino_npu_stats() == {"npu": "25.0", "mem": "-%"}
-
-        open_file.assert_any_call(
-            "/sys/class/accel/accel1/device/power/runtime_active_time"
-        )
-
-    @patch(
-        "frigate.util.services.os.readlink",
-        return_value="/sys/bus/pci/drivers/other",
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=["/sys/class/accel/accel0"],
-    )
-    @patch("builtins.open")
-    def test_openvino_npu_stats_no_intel_accelerator(self, open_file, glob, readlink):
-        assert get_openvino_npu_stats() is None
-        open_file.assert_not_called()
-
-    @patch(
-        "frigate.util.services.os.readlink",
-        return_value="/sys/bus/pci/drivers/intel_vpu",
-    )
-    @patch(
-        "frigate.util.services.glob.glob",
-        return_value=["/sys/class/accel/accel0"],
-    )
-    @patch("builtins.open", side_effect=FileNotFoundError)
-    def test_openvino_npu_stats_runtime_counter_unavailable(
-        self, open_file, glob, readlink
-    ):
-        assert get_openvino_npu_stats() is None
-        open_file.assert_called_once_with(
-            "/sys/class/accel/accel0/device/power/runtime_active_time"
-        )
-
     @patch("frigate.stats.intel_gpu_info.intel_gpu_name_resolver.get_names")
     @patch("frigate.util.services.time.sleep")
     @patch("frigate.util.services.time.monotonic")

frigate/test/test_maintainer.py

@@ -98,9 +98,7 @@ class TestMaintainer(unittest.IsolatedAsyncioTestCase):
         end_time = now - datetime.timedelta(seconds=10)
         cache_path = "/tmp/cache/test_cam@20260417150000+0000.mp4"
 
-        maintainer.end_time_cache = {
+        maintainer.end_time_cache = {cache_path: (end_time, 10.0)}
-            cache_path: (end_time, 10.0, None, None, None, None, None)
-        }
         # Single processed frame well past end_time with no motion/objects.
         maintainer.object_recordings_info["test_cam"] = [(now.timestamp(), [], [], [])]
         maintainer.audio_recordings_info["test_cam"] = []
@@ -111,11 +109,7 @@ class TestMaintainer(unittest.IsolatedAsyncioTestCase):
         result = await maintainer.validate_and_move_segment(
             "test_cam",
             reviews=[],
-            recording={
+            recording={"start_time": start_time, "cache_path": cache_path},
-                "start_time": start_time,
-                "cache_path": cache_path,
-                "stream_type": "main",
-            },
         )
 
         self.assertIsNone(result)
@@ -143,8 +137,7 @@ class TestMaintainer(unittest.IsolatedAsyncioTestCase):
             (recent, 0, []),
         ]
 
-        # keyed by (camera, stream_type), matching what move_files passes
+        grouped_recordings = {"present_cam": [{"start_time": ancient}]}
-        grouped_recordings = {("present_cam", "main"): [{"start_time": ancient}]}
 
         maintainer._expire_stale_recordings_info(grouped_recordings)
 

frigate/test/test_profiles.py

@@ -560,25 +560,6 @@ class TestProfileManager(unittest.TestCase):
         assert err is None
         assert self.config.cameras["front"].enabled is False
 
-    @patch.object(ProfileManager, "_persist_active_profile")
-    def test_profile_can_disable_inherited_birdseye_activity(self, mock_persist):
-        """A false-only mode override inherits the other base activity types."""
-        self.config.profiles["away"] = ProfileDefinitionConfig(friendly_name="Away")
-        base_mode = self.config.cameras["front"].birdseye.mode
-        base_mode.motion = True
-        base_mode.objects = True
-        self.config.cameras["front"].profiles["away"] = CameraProfileConfig(
-            birdseye={"mode": {"motion": False}}
-        )
-        self.manager = ProfileManager(self.config, self.mock_updater)
-
-        err = self.manager.activate_profile("away")
-
-        assert err is None
-        mode = self.config.cameras["front"].birdseye.mode
-        assert not mode.motion
-        assert mode.objects
-
     @patch.object(ProfileManager, "_persist_active_profile")
     def test_deactivate_restores_enabled(self, mock_persist):
         """Deactivating a profile restores the camera's base enabled state."""

frigate/test/test_record_cleanup_sub.py

@@ -1,210 +0,0 @@
-"""Tests for independent sub stream retention in recording cleanup."""
-
-import datetime
-import unittest
-from unittest.mock import MagicMock
-
-from playhouse.sqlite_ext import SqliteExtDatabase
-
-from frigate.config import FrigateConfig
-from frigate.models import Previews, Recordings, ReviewSegment, UserReviewStatus
-from frigate.record.cleanup import RecordingCleanup
-
-
-class TestRecordingCleanupSubRetention(unittest.TestCase):
-    def setUp(self):
-        # in-memory database keeps these tests isolated from the shared
-        # on-disk test.db used by the http api tests
-        self.db = SqliteExtDatabase(":memory:")
-        models = [Previews, Recordings, ReviewSegment, UserReviewStatus]
-        self.db.bind(models)
-        self.db.create_tables(models)
-
-    def tearDown(self):
-        self.db.close()
-
-    def _build_cleanup(self, record_config: dict) -> RecordingCleanup:
-        config = FrigateConfig(
-            **{
-                "mqtt": {"host": "mqtt"},
-                "cameras": {
-                    "front_door": {
-                        "ffmpeg": {
-                            "inputs": [
-                                {
-                                    "path": "rtsp://10.0.0.1:554/video",
-                                    "roles": ["detect", "record"],
-                                },
-                                {
-                                    "path": "rtsp://10.0.0.1:554/video2",
-                                    "roles": ["record_sub"],
-                                },
-                            ]
-                        },
-                        "record": record_config,
-                    }
-                },
-            }
-        )
-        return RecordingCleanup(config, MagicMock())
-
-    def _insert_recording(
-        self, id: str, stream_type: str, age_days: float, motion: int = 0
-    ) -> None:
-        end_time = (
-            datetime.datetime.now() - datetime.timedelta(days=age_days)
-        ).timestamp()
-        Recordings.create(
-            id=id,
-            camera="front_door",
-            path=f"/media/frigate/recordings/{id}.mp4",
-            start_time=end_time - 10,
-            end_time=end_time,
-            duration=10,
-            motion=motion,
-            objects=0,
-            dBFS=0,
-            segment_size=0,
-            stream_type=stream_type,
-        )
-
-    def test_sub_recordings_expire_independently(self):
-        # main retention 7 days, sub retention 30 days; rows 10 days old
-        # -> main row deleted, sub row kept
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "continuous": {"days": 7},
-                "sub": {"enabled": True, "continuous": {"days": 30}},
-            }
-        )
-        self._insert_recording("m1", "main", 10)
-        self._insert_recording("s1", "sub", 10)
-
-        cleanup.expire_recordings()
-
-        assert Recordings.get_or_none(Recordings.id == "m1") is None
-        assert Recordings.get_or_none(Recordings.id == "s1") is not None
-
-    def test_sub_recordings_expire_after_sub_retention(self):
-        # sub retention 30 days; sub row 40 days old -> deleted
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "continuous": {"days": 7},
-                "sub": {"enabled": True, "continuous": {"days": 30}},
-            }
-        )
-        self._insert_recording("s_old", "sub", 40)
-        self._insert_recording("s_new", "sub", 10)
-
-        cleanup.expire_recordings()
-
-        assert Recordings.get_or_none(Recordings.id == "s_old") is None
-        assert Recordings.get_or_none(Recordings.id == "s_new") is not None
-
-    def test_sub_recordings_overlapping_recent_reviews_survive(self):
-        # sub retention shorter than main: the reviews window must reach the
-        # sub pass cutoff or sub segments overlapping recent alerts are
-        # deleted on the first cleanup after being stored
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "continuous": {"days": 7},
-                "sub": {"enabled": True, "alerts": {"mode": "motion"}},
-            }
-        )
-        self._insert_recording("m1", "main", 1, motion=10)
-        self._insert_recording("s1", "sub", 1, motion=10)
-
-        # alert review covering the same time window as the recordings
-        recording = Recordings.get(Recordings.id == "s1")
-        ReviewSegment.create(
-            id="r1",
-            camera="front_door",
-            start_time=recording.start_time,
-            end_time=recording.end_time,
-            severity="alert",
-            thumb_path="/media/frigate/clips/review/thumb-r1.webp",
-            data={},
-        )
-
-        cleanup.expire_recordings()
-
-        assert Recordings.get_or_none(Recordings.id == "m1") is not None
-        assert Recordings.get_or_none(Recordings.id == "s1") is not None
-
-    def test_sub_alerts_days_extends_review_and_sub_retention(self):
-        # a 20-day-old alert review survives for the 60 day sub window and
-        # keeps the sub row alive, but must not hold the main row past the
-        # 10 day main alerts window
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "continuous": {"days": 7},
-                "sub": {"enabled": True, "alerts": {"days": 60}},
-            }
-        )
-        self._insert_recording("m1", "main", 20, motion=10)
-        self._insert_recording("s1", "sub", 20, motion=10)
-
-        # alert review covering the same time window as the recordings
-        recording = Recordings.get(Recordings.id == "s1")
-        ReviewSegment.create(
-            id="r1",
-            camera="front_door",
-            start_time=recording.start_time,
-            end_time=recording.end_time,
-            severity="alert",
-            thumb_path="/media/frigate/clips/review/thumb-r1.webp",
-            data={},
-        )
-
-        cleanup.expire_recordings()
-
-        assert ReviewSegment.get_or_none(ReviewSegment.id == "r1") is not None
-        assert Recordings.get_or_none(Recordings.id == "m1") is None
-        assert Recordings.get_or_none(Recordings.id == "s1") is not None
-
-    def test_main_review_lifetime_unchanged_when_sub_disabled(self):
-        # with sub recording disabled, the 20-day-old alert review expires
-        # under the 10 day main alerts retention exactly as before
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "continuous": {"days": 7},
-                "sub": {"enabled": False, "alerts": {"days": 60}},
-            }
-        )
-        end_time = (datetime.datetime.now() - datetime.timedelta(days=20)).timestamp()
-        ReviewSegment.create(
-            id="r1",
-            camera="front_door",
-            start_time=end_time - 10,
-            end_time=end_time,
-            severity="alert",
-            thumb_path="/media/frigate/clips/review/thumb-r1.webp",
-            data={},
-        )
-
-        cleanup.expire_recordings()
-
-        assert ReviewSegment.get_or_none(ReviewSegment.id == "r1") is None
-
-    def test_disabled_sub_still_expires_old_sub_rows(self):
-        # sub disabled but old sub rows remain: the sub pass still runs and
-        # expires them by the sub config dates
-        cleanup = self._build_cleanup(
-            {
-                "enabled": True,
-                "continuous": {"days": 7},
-                "sub": {"enabled": False, "continuous": {"days": 30}},
-            }
-        )
-        self._insert_recording("s_old", "sub", 40)
-        self._insert_recording("s_new", "sub", 10)
-
-        cleanup.expire_recordings()
-
-        assert Recordings.get_or_none(Recordings.id == "s_old") is None
-        assert Recordings.get_or_none(Recordings.id == "s_new") is not None

frigate/test/test_record_sub_maintainer.py

@@ -1,544 +0,0 @@
-"""Tests for sub stream cache segment handling in the recording maintainer."""
-
-import datetime
-import os
-import tempfile
-import unittest
-from collections import defaultdict
-from unittest.mock import AsyncMock, MagicMock, patch
-
-from playhouse.sqlite_ext import SqliteExtDatabase
-
-from frigate.config import FrigateConfig
-from frigate.models import Recordings
-from frigate.record.maintainer import (
-    RecordingMaintainer,
-    SegmentInfo,
-    parse_cache_segment_name,
-)
-
-
-def _build_chaining_maintainer(
-    t0: float, retention: str = "continuous"
-) -> RecordingMaintainer:
-    """Build a maintainer for start-time chaining tests.
-
-    Built without __init__ to avoid the IPC scaffolding; move_segment and
-    drop_segment are mocked so the times passed downstream are observable.
-    """
-    camera_config = MagicMock()
-    camera_config.record.enabled = True
-    camera_config.record.event_pre_capture = 0
-    camera_config.detect.width = 1920
-    camera_config.detect.height = 1080
-    camera_config.record.continuous.days = 1 if retention == "continuous" else 0
-    camera_config.record.motion.days = 0 if retention == "continuous" else 1
-
-    # no spec: pydantic fields like config.ffmpeg are not visible to
-    # spec'd mocks, and the probe path needs them
-    config = MagicMock()
-    config.cameras = {"test_cam": camera_config}
-
-    maintainer = RecordingMaintainer.__new__(RecordingMaintainer)
-    maintainer.config = config
-    maintainer.end_time_cache = {}
-    maintainer.object_recordings_info = defaultdict(list)
-    maintainer.audio_recordings_info = defaultdict(list)
-    maintainer.recordings_publisher = MagicMock()
-    maintainer.drop_segment = MagicMock()
-    maintainer.move_segment = AsyncMock(return_value=None)
-    # pre-seed the chain state so the lazy DB seed query is not attempted
-    maintainer.last_segment_end = {("test_cam", "main"): 0.0}
-    # a processed frame far past any segment end marks segments ready
-    maintainer.object_recordings_info["test_cam"] = [(t0 + 1000, [], [], [])]
-    return maintainer
-
-
-async def _validate_segment(
-    maintainer: RecordingMaintainer,
-    t0: float,
-    offset: float,
-    duration: float,
-    mtime: float | None = None,
-):
-    """Run validate_and_move_segment for a segment named t0+offset.
-
-    mtime injects the cache file's close time; None simulates a missing file.
-    """
-    start = datetime.datetime.fromtimestamp(t0 + offset, tz=datetime.UTC)
-    probe = AsyncMock(return_value={"has_valid_video": True, "duration": duration})
-    getmtime = (
-        MagicMock(side_effect=OSError("missing"))
-        if mtime is None
-        else MagicMock(return_value=mtime)
-    )
-    with (
-        patch("frigate.record.maintainer.get_video_properties", probe),
-        patch(
-            "frigate.record.maintainer.get_keyframe_offsets",
-            AsyncMock(return_value=[0]),
-        ),
-        patch("frigate.record.maintainer.os.path.getmtime", getmtime),
-    ):
-        return await maintainer.validate_and_move_segment(
-            "test_cam",
-            reviews=[],
-            recording={
-                "start_time": start,
-                "cache_path": f"/tmp/cache/test_cam@chain{offset}.mp4",
-                "stream_type": "main",
-            },
-        )
-
-
-class TestParseCacheSegmentName(unittest.TestCase):
-    def test_parses_main_segment(self):
-        camera, stream_type, date = parse_cache_segment_name(
-            "front_door@20260610143022+0000"
-        )
-        assert camera == "front_door"
-        assert stream_type == "main"
-        assert date == "20260610143022+0000"
-
-    def test_parses_sub_segment(self):
-        camera, stream_type, date = parse_cache_segment_name(
-            "front_door@sub@20260610143022+0000"
-        )
-        assert camera == "front_door"
-        assert stream_type == "sub"
-        assert date == "20260610143022+0000"
-
-    def test_returns_none_for_unexpected_name(self):
-        assert parse_cache_segment_name("no_at_sign_here") is None
-
-
-class TestValidateAndMoveSubSegment(unittest.IsolatedAsyncioTestCase):
-    """Behavioral tests for sub stream segments in validate_and_move_segment.
-
-    The maintainer is built without __init__ to avoid the ZMQ scaffolding
-    the real constructor sets up.
-    """
-
-    def _build_maintainer(self, camera_config: MagicMock) -> RecordingMaintainer:
-        config = MagicMock(spec=FrigateConfig)
-        config.cameras = {"test_cam": camera_config}
-
-        maintainer = RecordingMaintainer.__new__(RecordingMaintainer)
-        maintainer.config = config
-        maintainer.end_time_cache = {}
-        maintainer.object_recordings_info = defaultdict(list)
-        maintainer.audio_recordings_info = defaultdict(list)
-        maintainer.drop_segment = MagicMock()
-        maintainer.recordings_publisher = MagicMock()
-        maintainer.move_segment = AsyncMock(return_value=None)
-        return maintainer
-
-    async def test_drops_sub_segment_when_sub_recording_disabled(self):
-        camera_config = MagicMock()
-        camera_config.record.enabled = True
-        camera_config.record.sub.enabled = False
-
-        maintainer = self._build_maintainer(camera_config)
-        cache_path = "/tmp/cache/test_cam@sub@20260610143022+0000.mp4"
-
-        result = await maintainer.validate_and_move_segment(
-            "test_cam",
-            reviews=[],
-            recording={
-                "start_time": datetime.datetime.now(datetime.UTC),
-                "cache_path": cache_path,
-                "stream_type": "sub",
-            },
-        )
-
-        self.assertIsNone(result)
-        maintainer.drop_segment.assert_called_once_with(cache_path)
-        maintainer.move_segment.assert_not_awaited()
-
-    async def test_sub_segment_uses_sub_continuous_retention(self):
-        # main continuous/motion are disabled, but sub continuous is enabled;
-        # the sub segment must be kept based on the sub retention config
-        camera_config = MagicMock()
-        camera_config.record.enabled = True
-        camera_config.record.sub.enabled = True
-        camera_config.record.continuous.days = 0
-        camera_config.record.motion.days = 0
-        camera_config.record.sub.continuous.days = 1
-        camera_config.record.sub.motion.days = 0
-
-        maintainer = self._build_maintainer(camera_config)
-
-        now = datetime.datetime.now(datetime.UTC)
-        start_time = now - datetime.timedelta(seconds=20)
-        end_time = now - datetime.timedelta(seconds=10)
-        cache_path = "/tmp/cache/test_cam@sub@20260610143022+0000.mp4"
-
-        # pre-fill the end time cache so no ffprobe is attempted; the
-        # audio and codec fields stay unknown without one
-        maintainer.end_time_cache = {
-            cache_path: (end_time, 10.0, None, None, None, None, None)
-        }
-        # a processed frame past end_time so the segment is considered ready
-        maintainer.object_recordings_info["test_cam"] = [(now.timestamp(), [], [], [])]
-
-        result = await maintainer.validate_and_move_segment(
-            "test_cam",
-            reviews=[],
-            recording={
-                "start_time": start_time,
-                "cache_path": cache_path,
-                "stream_type": "sub",
-            },
-        )
-
-        self.assertIsNone(result)
-        maintainer.move_segment.assert_awaited_once()
-        call_args = maintainer.move_segment.await_args.args
-        self.assertEqual(call_args[0], "test_cam")
-        self.assertEqual(call_args[1], "sub")
-        maintainer.drop_segment.assert_not_called()
-
-
-class TestSegmentAudioPresence(unittest.IsolatedAsyncioTestCase):
-    """Audio presence must flow from the segment probe into the DB insert."""
-
-    def _build_maintainer(self) -> RecordingMaintainer:
-        camera_config = MagicMock()
-        camera_config.record.enabled = True
-        camera_config.record.continuous.days = 1
-        camera_config.record.motion.days = 0
-
-        # no spec: pydantic fields like config.ffmpeg are not visible to
-        # spec'd mocks, and the probe/move paths need them
-        config = MagicMock()
-        config.cameras = {"test_cam": camera_config}
-
-        maintainer = RecordingMaintainer.__new__(RecordingMaintainer)
-        maintainer.config = config
-        maintainer.end_time_cache = {}
-        maintainer.object_recordings_info = defaultdict(list)
-        maintainer.audio_recordings_info = defaultdict(list)
-        maintainer.recordings_publisher = MagicMock()
-        # pre-seed the chain state so the lazy DB seed query is not attempted
-        maintainer.last_segment_end = {("test_cam", "main"): 0.0}
-        return maintainer
-
-    async def test_probe_audio_presence_reaches_move_segment(self):
-        for has_audio, audio_rate, audio_codec, video_codec in (
-            (True, 16000, "aac", "hevc"),
-            (True, 8000, "pcm_alaw", "h264"),
-            (False, None, None, "h264"),
-            (False, None, None, None),
-        ):
-            with self.subTest(
-                has_audio=has_audio,
-                audio_rate=audio_rate,
-                audio_codec=audio_codec,
-                video_codec=video_codec,
-            ):
-                maintainer = self._build_maintainer()
-                maintainer.move_segment = AsyncMock(return_value=None)
-
-                now = datetime.datetime.now(datetime.UTC)
-                start_time = now - datetime.timedelta(seconds=20)
-                cache_path = "/tmp/cache/test_cam@20260610143022+0000.mp4"
-                # a processed frame past the segment end marks it ready
-                maintainer.object_recordings_info["test_cam"] = [
-                    (now.timestamp(), [], [], [])
-                ]
-
-                probe = AsyncMock(
-                    return_value={
-                        "has_valid_video": True,
-                        "width": 1920,
-                        "height": 1080,
-                        "duration": 10.0,
-                        "has_audio": has_audio,
-                        "audio_rate": audio_rate,
-                        "audio_codec": audio_codec,
-                        "video_codec": video_codec,
-                    }
-                )
-                with (
-                    patch("frigate.record.maintainer.get_video_properties", probe),
-                    patch(
-                        "frigate.record.maintainer.get_keyframe_offsets",
-                        AsyncMock(return_value=[0, 2000]),
-                    ),
-                ):
-                    await maintainer.validate_and_move_segment(
-                        "test_cam",
-                        reviews=[],
-                        recording={
-                            "start_time": start_time,
-                            "cache_path": cache_path,
-                            "stream_type": "main",
-                        },
-                    )
-
-                maintainer.move_segment.assert_awaited_once()
-                call_args = maintainer.move_segment.await_args.args
-                self.assertEqual(call_args[7], has_audio)
-                self.assertEqual(call_args[8], audio_rate)
-                self.assertEqual(call_args[9], audio_codec)
-                self.assertEqual(call_args[11], [0, 2000])
-                self.assertEqual(call_args[10], video_codec)
-                # the probe result is cached alongside the end time so the
-                # cached path stays as informed as the probed path
-                self.assertEqual(maintainer.end_time_cache[cache_path][2], has_audio)
-                self.assertEqual(maintainer.end_time_cache[cache_path][3], audio_rate)
-                self.assertEqual(maintainer.end_time_cache[cache_path][4], audio_codec)
-                self.assertEqual(maintainer.end_time_cache[cache_path][5], video_codec)
-
-    async def test_move_segment_insert_includes_has_audio(self):
-        for has_audio, audio_rate, audio_codec, video_codec in (
-            (True, 16000, "aac", "hevc"),
-            (False, None, None, None),
-        ):
-            with self.subTest(
-                has_audio=has_audio,
-                audio_rate=audio_rate,
-                audio_codec=audio_codec,
-                video_codec=video_codec,
-            ):
-                maintainer = self._build_maintainer()
-                maintainer.config.ffmpeg.ffmpeg_path = "ffmpeg"
-
-                start_time = datetime.datetime.now(datetime.UTC)
-                end_time = start_time + datetime.timedelta(seconds=10)
-
-                proc = MagicMock()
-                proc.returncode = 0
-                proc.wait = AsyncMock(return_value=0)
-
-                with tempfile.TemporaryDirectory() as tmpdir:
-                    cache_path = os.path.join(
-                        tmpdir, "test_cam@20260610143022+0000.mp4"
-                    )
-                    with open(cache_path, "wb") as f:
-                        f.write(b"\x00" * 16)
-
-                    with (
-                        patch(
-                            "frigate.record.maintainer.RECORD_DIR",
-                            os.path.join(tmpdir, "recordings"),
-                        ),
-                        patch(
-                            "frigate.record.maintainer.asyncio.create_subprocess_exec",
-                            AsyncMock(return_value=proc),
-                        ),
-                    ):
-                        result = await maintainer.move_segment(
-                            "test_cam",
-                            "main",
-                            start_time,
-                            end_time,
-                            10.0,
-                            cache_path,
-                            SegmentInfo(0, 0, 0, 0),
-                            has_audio,
-                            audio_rate,
-                            audio_codec,
-                            video_codec,
-                        )
-
-                self.assertIsNotNone(result)
-                self.assertEqual(result[Recordings.has_audio.name], has_audio)
-                self.assertEqual(result[Recordings.audio_rate.name], audio_rate)
-                self.assertEqual(result[Recordings.audio_codec.name], audio_codec)
-                self.assertEqual(result[Recordings.video_codec.name], video_codec)
-
-
-class TestSegmentStartChaining(unittest.IsolatedAsyncioTestCase):
-    """Contiguous segments must chain start times across filename truncation.
-
-    A contiguous segment's parsed start lands up to 1s before the previous
-    segment's fractional end, and must snap to it without ever snapping
-    across a genuine gap.
-    """
-
-    T0 = datetime.datetime(2026, 6, 10, 14, 30, 22, tzinfo=datetime.UTC).timestamp()
-
-    async def test_contiguous_segment_snaps_to_previous_end(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-
-        # segment A named at a whole second with a fractional duration
-        await _validate_segment(maintainer, self.T0, 0, 10.4)
-        # segment B's filename truncates its true start (T0 + 10.4) to T0 + 10
-        await _validate_segment(maintainer, self.T0, 10, 10.4)
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 2)
-        self.assertEqual(calls[0].args[2].timestamp(), self.T0)
-        self.assertAlmostEqual(calls[0].args[3].timestamp(), self.T0 + 10.4, places=3)
-        self.assertAlmostEqual(calls[1].args[2].timestamp(), self.T0 + 10.4, places=3)
-        self.assertAlmostEqual(calls[1].args[3].timestamp(), self.T0 + 20.8, places=3)
-
-    async def test_genuine_gap_is_not_snapped(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-
-        await _validate_segment(maintainer, self.T0, 0, 10.4)
-        # a segment starting well after the previous end is a genuine gap
-        await _validate_segment(maintainer, self.T0, 30, 10.4)
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 2)
-        self.assertEqual(calls[1].args[2].timestamp(), self.T0 + 30)
-        self.assertAlmostEqual(calls[1].args[3].timestamp(), self.T0 + 40.4, places=3)
-
-    async def test_difference_over_tolerance_is_not_snapped(self):
-        # a last end far ahead of the parsed start (dual recorders or
-        # cache-pressure deletions) must never pull the start forward
-        maintainer = _build_chaining_maintainer(self.T0)
-        maintainer.last_segment_end = {("test_cam", "main"): self.T0 + 5.0}
-
-        await _validate_segment(maintainer, self.T0, 0, 10.4)
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 1)
-        self.assertEqual(calls[0].args[2].timestamp(), self.T0)
-
-    async def test_start_after_last_end_within_tolerance_is_not_snapped(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-
-        await _validate_segment(maintainer, self.T0, 0, 10.4)
-        # parsed start T0 + 11 is after the last end (T0 + 10.4): a real
-        # sub-second gap, never snapped backwards
-        await _validate_segment(maintainer, self.T0, 11, 10.4)
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 2)
-        self.assertEqual(calls[1].args[2].timestamp(), self.T0 + 11)
-
-    async def test_chain_survives_retention_discarded_segment(self):
-        # motion retention: A and C overlap motion frames, B has none and is
-        # discarded, but capture continued through B so C chains to B's end
-        maintainer = _build_chaining_maintainer(self.T0, retention="motion")
-        maintainer.object_recordings_info["test_cam"] = [
-            (self.T0 + 5, [], [(0, 0, 10, 10)], []),
-            (self.T0 + 25, [], [(0, 0, 10, 10)], []),
-            (self.T0 + 1000, [], [], []),
-        ]
-
-        await _validate_segment(maintainer, self.T0, 0, 10.4)
-        await _validate_segment(maintainer, self.T0, 10, 10.4)
-        await _validate_segment(maintainer, self.T0, 20, 10.4)
-
-        calls = maintainer.move_segment.await_args_list
-        # B was discarded by motion retention, only A and C moved
-        self.assertEqual(len(calls), 2)
-        maintainer.drop_segment.assert_called_once_with(
-            "/tmp/cache/test_cam@chain10.mp4"
-        )
-        # C snaps to B's end (T0 + 20.8), not A's end (T0 + 10.4)
-        self.assertAlmostEqual(calls[1].args[2].timestamp(), self.T0 + 20.8, places=3)
-        self.assertAlmostEqual(calls[1].args[3].timestamp(), self.T0 + 31.2, places=3)
-
-
-class TestSegmentStartMtimeAnchoring(unittest.IsolatedAsyncioTestCase):
-    """Segment starts must anchor to the cache file's close time.
-
-    mtime is the wall clock when ffmpeg rolled the segment, so mtime minus
-    the probed duration restores the fractional start the filename floored
-    away. Contiguous segments still chain within probe jitter.
-    """
-
-    T0 = datetime.datetime(2026, 8, 7, 9, 15, 42, tzinfo=datetime.UTC).timestamp()
-
-    async def test_mtime_restores_fractional_start(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-
-        # true start T0 + 0.437; the filename floored it to T0
-        await _validate_segment(
-            maintainer, self.T0, 0, 10.0, mtime=self.T0 + 0.437 + 10.0
-        )
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 1)
-        self.assertAlmostEqual(calls[0].args[2].timestamp(), self.T0 + 0.437, places=3)
-        self.assertAlmostEqual(calls[0].args[3].timestamp(), self.T0 + 10.437, places=3)
-
-    async def test_chain_wins_within_probe_jitter(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-
-        await _validate_segment(
-            maintainer, self.T0, 0, 10.0, mtime=self.T0 + 0.437 + 10.0
-        )
-        # B measures T0 + 10.420, a 17ms disagreement with A's chained end
-        # (T0 + 10.437): the chain wins so the rows stay exactly adjacent
-        await _validate_segment(
-            maintainer, self.T0, 10, 10.0, mtime=self.T0 + 10.420 + 10.0
-        )
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 2)
-        self.assertAlmostEqual(calls[1].args[2].timestamp(), self.T0 + 10.437, places=3)
-        self.assertAlmostEqual(calls[1].args[3].timestamp(), self.T0 + 20.437, places=3)
-
-    async def test_chain_reanchors_when_drifted(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-        # accumulated probe error left the chain 0.7s past the measured start
-        maintainer.last_segment_end = {("test_cam", "main"): self.T0 + 0.9}
-
-        await _validate_segment(
-            maintainer, self.T0, 0, 10.0, mtime=self.T0 + 0.2 + 10.0
-        )
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 1)
-        self.assertAlmostEqual(calls[0].args[2].timestamp(), self.T0 + 0.2, places=3)
-
-    async def test_implausible_mtime_falls_back_to_filename_chain(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-        maintainer.last_segment_end = {("test_cam", "main"): self.T0 + 0.4}
-
-        # a stalled stream: media (8s) is shorter than the wall span to the
-        # close time (9.5s), so mtime - duration lands outside the window
-        await _validate_segment(maintainer, self.T0, 0, 8.0, mtime=self.T0 + 9.5)
-
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 1)
-        self.assertAlmostEqual(calls[0].args[2].timestamp(), self.T0 + 0.4, places=3)
-
-
-class TestSegmentChainSeeding(unittest.IsolatedAsyncioTestCase):
-    """Chain state must lazily seed from the DB so chains survive restarts."""
-
-    T0 = datetime.datetime(2026, 6, 10, 14, 30, 22, tzinfo=datetime.UTC).timestamp()
-
-    def setUp(self):
-        self.db = SqliteExtDatabase(":memory:")
-        self.db.bind([Recordings])
-        self.db.create_tables([Recordings])
-
-    def tearDown(self):
-        self.db.close()
-
-    async def test_seeds_chain_from_db_once(self):
-        maintainer = _build_chaining_maintainer(self.T0)
-        # empty chain state forces the lazy DB seed on first encounter
-        maintainer.last_segment_end = {}
-
-        Recordings.create(
-            id="seed-row",
-            camera="test_cam",
-            path="/recordings/seed.mp4",
-            start_time=self.T0 - 10,
-            end_time=self.T0 + 0.35,
-            duration=10.35,
-            stream_type="main",
-        )
-
-        with patch.object(Recordings, "select", wraps=Recordings.select) as select_spy:
-            await _validate_segment(maintainer, self.T0, 0, 10.4)
-            await _validate_segment(maintainer, self.T0, 10, 10.4)
-
-        # the seed query runs once; the second segment uses in-memory state
-        self.assertEqual(select_spy.call_count, 1)
-        calls = maintainer.move_segment.await_args_list
-        self.assertEqual(len(calls), 2)
-        # first segment snaps to the stored fractional end_time
-        self.assertAlmostEqual(calls[0].args[2].timestamp(), self.T0 + 0.35, places=3)
-        self.assertAlmostEqual(calls[0].args[3].timestamp(), self.T0 + 10.75, places=3)
-        # second segment chains off the first's in-memory end
-        self.assertAlmostEqual(calls[1].args[2].timestamp(), self.T0 + 10.75, places=3)

frigate/test/test_recording_coverage.py

@@ -1,305 +0,0 @@
-"""Tests for the unified recording coverage resolver."""
-
-import asyncio
-import json
-import unittest
-from types import SimpleNamespace
-
-from playhouse.sqlite_ext import SqliteExtDatabase
-
-from frigate.api.media import _vod_response
-from frigate.const import MAX_SEGMENT_DURATION
-from frigate.models import Recordings
-from frigate.util.recording_coverage import (
-    _rows_query,
-    coverage_spans,
-    plan_clip,
-    realized_timeline,
-    resolve_coverage,
-    stream_media_summary,
-)
-
-
-class CoverageDbTestCase(unittest.TestCase):
-    def setUp(self):
-        # in-memory database keeps these tests isolated from the shared
-        # on-disk test.db used by the http api tests
-        self.db = SqliteExtDatabase(":memory:")
-        models = [Recordings]
-        self.db.bind(models)
-        self.db.create_tables(models)
-
-    def tearDown(self):
-        self.db.close()
-
-    def _insert(
-        self,
-        id,
-        start,
-        end,
-        stream_type,
-        camera="front_door",
-        video_codec=None,
-        audio_rate=None,
-        audio_codec=None,
-        has_audio=None,
-        segment_size=0,
-        keyframes=None,
-    ):
-        Recordings.create(
-            id=id,
-            camera=camera,
-            path=f"/tmp/{id}.mp4",
-            start_time=start,
-            end_time=end,
-            duration=end - start,
-            stream_type=stream_type,
-            video_codec=video_codec,
-            audio_rate=audio_rate,
-            audio_codec=audio_codec,
-            has_audio=has_audio,
-            segment_size=segment_size,
-            keyframes=keyframes,
-        )
-
-
-class TestRecordingCoverage(CoverageDbTestCase):
-    def test_both_streams_offset_boundaries(self):
-        # main: [1000,1010) [1010,1020)   sub: [1003,1013) [1013,1023)
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("m2", 1010.0, 1020.0, "main")
-        self._insert("s1", 1003.0, 1013.0, "sub")
-        self._insert("s2", 1013.0, 1023.0, "sub")
-        intervals = resolve_coverage("front_door", 1000.0, 1020.0)
-        # boundaries: 1000,1003,1010,1013,1020
-        assert [round(i.start_time) for i in intervals] == [1000, 1003, 1010, 1013]
-        assert intervals[0].main is not None and intervals[0].sub is None
-        assert intervals[1].main is not None and intervals[1].sub is not None
-
-    def test_sub_only_when_main_expired(self):
-        self._insert("s1", 1000.0, 1010.0, "sub")
-        intervals = resolve_coverage("front_door", 1000.0, 1010.0)
-        assert len(intervals) == 1
-        assert intervals[0].main is None and intervals[0].sub is not None
-
-    def test_gap_when_neither_exists(self):
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("m2", 1030.0, 1040.0, "main")
-        intervals = resolve_coverage("front_door", 1000.0, 1040.0)
-        assert len(intervals) == 2  # the [1010,1030) gap produces no interval
-
-    def test_spans_merge_same_availability(self):
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("m2", 1010.0, 1020.0, "main")
-        spans = coverage_spans(resolve_coverage("front_door", 1000.0, 1020.0))
-        assert spans == [
-            {"start_time": 1000.0, "end_time": 1020.0, "streams": ["main"]}
-        ]
-
-    def test_requested_range_clamps_intervals(self):
-        # query range partially overlaps the rows; the first and last
-        # intervals must be clamped to the requested [after, before]
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("m2", 1010.0, 1020.0, "main")
-        intervals = resolve_coverage("front_door", 1005.0, 1015.0)
-        assert intervals[0].start_time == 1005.0
-        assert intervals[-1].end_time == 1015.0
-        spans = coverage_spans(intervals)
-        assert spans == [
-            {"start_time": 1005.0, "end_time": 1015.0, "streams": ["main"]}
-        ]
-
-    def test_stream_media_summary_newest_known_wins(self):
-        # the newer main row's NULL codecs must not mask the older row's
-        # known codecs, while its known audio fields take precedence
-        self._insert(
-            "m1",
-            1000.0,
-            1010.0,
-            "main",
-            video_codec="hevc",
-            audio_rate=16000,
-            audio_codec="aac",
-        )
-        self._insert("m2", 1010.0, 1020.0, "main", audio_rate=8000, has_audio=True)
-        self._insert("s1", 1000.0, 1010.0, "sub", has_audio=False)
-        summary = stream_media_summary(resolve_coverage("front_door", 1000.0, 1020.0))
-        assert summary == {
-            "main": {
-                "video_codec": "hevc",
-                "audio_rate": 8000,
-                "audio_codec": "aac",
-                "has_audio": True,
-                "bitrate": None,
-            },
-            "sub": {
-                "video_codec": None,
-                "audio_rate": None,
-                "audio_codec": None,
-                "has_audio": False,
-                "bitrate": None,
-            },
-        }
-
-    def test_stream_media_summary_omits_absent_stream(self):
-        self._insert("m1", 1000.0, 1010.0, "main", video_codec="h264")
-        summary = stream_media_summary(resolve_coverage("front_door", 1000.0, 1010.0))
-        assert list(summary.keys()) == ["main"]
-        assert stream_media_summary([]) == {}
-
-    def test_stream_media_summary_bitrate_weighted_by_duration(self):
-        # main: 10 MiB over 10s + 30 MiB over 20s -> 40 MiB / 30s
-        self._insert("m1", 1000.0, 1010.0, "main", segment_size=10)
-        self._insert("m2", 1010.0, 1030.0, "main", segment_size=30)
-        # sub rows without a stored size (legacy default 0) report None
-        self._insert("s1", 1000.0, 1030.0, "sub")
-        summary = stream_media_summary(resolve_coverage("front_door", 1000.0, 1030.0))
-        expected = int(40 * 1024 * 1024 * 8 / 30)
-        assert summary["main"]["bitrate"] == expected
-        assert summary["sub"]["bitrate"] is None
-
-    def test_stream_media_summary_bitrate_skips_zero_size_rows(self):
-        # the zero-size glitch row contributes neither bytes nor seconds
-        self._insert("m1", 1000.0, 1010.0, "main", segment_size=5)
-        self._insert("m2", 1010.0, 1020.0, "main", segment_size=0)
-        summary = stream_media_summary(resolve_coverage("front_door", 1000.0, 1020.0))
-        expected = int(5 * 1024 * 1024 * 8 / 10)
-        assert summary["main"]["bitrate"] == expected
-
-    def test_other_camera_rows_excluded(self):
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("o1", 1000.0, 1010.0, "main", camera="back_yard")
-        self._insert("o2", 1000.0, 1010.0, "sub", camera="back_yard")
-        intervals = resolve_coverage("front_door", 1000.0, 1010.0)
-        assert len(intervals) == 1
-        assert intervals[0].main is not None and intervals[0].sub is None
-        assert resolve_coverage("side_gate", 1000.0, 1010.0) == []
-
-    def test_realized_timeline_snap_lead_in(self):
-        """A mid-file resume's back-snap lead-in appears in the realized duration.
-
-        Sub resumes at 1010 with a 7000ms inpoint; the stored keyframe
-        index snaps back to 6000ms, so the clip serves 1000ms of pre-span
-        content on top of the 3000ms span.
-        """
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("s1", 1003.0, 1013.0, "sub", keyframes=[0, 2000, 4000, 6000, 8000])
-        timeline = realized_timeline(
-            resolve_coverage("front_door", 1000.0, 1013.0), None
-        )
-        assert timeline == [
-            {"start_time": 1000.0, "end_time": 1010.0, "duration": 10000},
-            {"start_time": 1010.0, "end_time": 1013.0, "duration": 4000},
-        ]
-
-    def test_realized_timeline_no_keyframe_index_serves_whole_file(self):
-        """A row without a stored keyframe index serves the whole file.
-
-        NULL keyframes mean the record-time probe failed, so a mid-file
-        entry cannot be snapped to a decodable frame.
-        """
-        self._insert("m1", 1000.0, 1010.0, "main")
-        self._insert("s1", 1003.0, 1013.0, "sub")
-        timeline = realized_timeline(
-            resolve_coverage("front_door", 1000.0, 1013.0), None
-        )
-        # the resume clip serves all 10000ms of the sub file for a 3000ms span
-        assert timeline[1] == {
-            "start_time": 1010.0,
-            "end_time": 1013.0,
-            "duration": 10000,
-        }
-
-    def test_realized_timeline_pinned_stream_no_mid_range_lead_in(self):
-        """A pinned stream's spans start at its own file starts: no lead-in."""
-        self._insert("s1", 1000.0, 1010.0, "sub", keyframes=[0, 5000])
-        self._insert("s2", 1010.0, 1020.0, "sub", keyframes=[0, 5000])
-        timeline = realized_timeline(
-            resolve_coverage("front_door", 1000.0, 1020.0), "sub"
-        )
-        assert [t["duration"] for t in timeline] == [10000, 10000]
-
-    def test_rows_query_scan_is_bounded_below(self):
-        """The row query must give SQLite a lower bound on start_time.
-
-        Without one the best index range is (camera=? AND start_time<?),
-        which walks the camera's entire history on every coverage call:
-        ~20s on a cold page cache, blocking the API event loop.
-        """
-        # the index the planner picks in production (migration 020)
-        self.db.execute_sql(
-            "CREATE INDEX recordings_api_recordings_summary ON recordings "
-            '("camera", "start_time" DESC, "duration", "motion", "objects")'
-        )
-        sql, params = _rows_query("front_door", 2000.0, 3000.0, "main").sql()
-        plan = " ".join(
-            row[-1] for row in self.db.execute_sql("EXPLAIN QUERY PLAN " + sql, params)
-        )
-        assert "start_time>?" in plan and "start_time<?" in plan, plan
-
-    def test_longest_segment_spanning_window_start_included(self):
-        # a maximum-length segment overlapping `after` sits right at the
-        # start_time lower bound the query is allowed to apply
-        self._insert("m1", 1000.0, 1000.0 + MAX_SEGMENT_DURATION - 0.5, "main")
-        intervals = resolve_coverage("front_door", 1599.0, 1700.0)
-        assert len(intervals) == 1
-        assert intervals[0].main is not None
-
-    def test_plan_clip_skips_too_short(self):
-        """A clip left with under 100ms of media is skipped (duration 0 in timelines)."""
-        row = SimpleNamespace(
-            path="/tmp/x.mp4",
-            start_time=1000.0,
-            end_time=1000.15,
-            duration=0.15,
-            keyframes=[0, 100],
-        )
-        plan = plan_clip(row, 1000.1, 1000.15)
-        assert plan.skipped
-        assert plan.duration_ms == 0
-
-
-class TestVodManifestPolicy(CoverageDbTestCase):
-    """Discontinuity policy of the vod mapping builder."""
-
-    def _mapping(self, start, end, stream=None):
-        response = asyncio.run(
-            _vod_response("front_door", start, end, stream_preference=stream)
-        )
-        return json.loads(response.body)
-
-    def _insert_stream(self, prefix, stream_type, spans):
-        for idx, (start, end) in enumerate(spans):
-            self._insert(
-                f"{prefix}{idx}",
-                start,
-                end,
-                stream_type,
-                video_codec="h264",
-                audio_codec="aac",
-                audio_rate=16000,
-                has_audio=True,
-            )
-
-    def test_cross_stream_handoff_forces_discontinuity(self):
-        # codec and audio params match on both streams, so only the stream
-        # mix can force per-clip init segments here
-        self._insert_stream("m", "main", [(1000.0, 1010.0)])
-        self._insert_stream("s", "sub", [(1000.0, 1010.0), (1010.0, 1020.0)])
-        mapping = self._mapping(1000.0, 1020.0)
-        assert mapping["discontinuity"] is True
-        assert mapping["initialClipIndex"] == 1
-        assert len(mapping["sequences"][0]["clips"]) == 2
-
-    def test_single_stream_range_stays_consistent(self):
-        self._insert_stream("s", "sub", [(1000.0, 1010.0), (1010.0, 1020.0)])
-        mapping = self._mapping(1000.0, 1020.0)
-        assert mapping["discontinuity"] is False
-        assert "initialClipIndex" not in mapping
-
-    def test_pinned_stream_over_mixed_coverage_stays_consistent(self):
-        self._insert_stream("m", "main", [(1000.0, 1010.0), (1010.0, 1020.0)])
-        self._insert_stream("s", "sub", [(1000.0, 1010.0), (1010.0, 1020.0)])
-        mapping = self._mapping(1000.0, 1020.0, stream="sub")
-        assert mapping["discontinuity"] is False
-        assert "initialClipIndex" not in mapping

frigate/test/test_storage.py

@@ -11,9 +11,8 @@ from playhouse.sqlite_ext import SqliteExtDatabase
 from playhouse.sqliteq import SqliteQueueDatabase
 
 from frigate.config import FrigateConfig
-from frigate.const import STREAM_TYPE_MAIN, STREAM_TYPE_SUB
 from frigate.models import Event, Recordings
-from frigate.storage import MAX_CALCULATED_BANDWIDTH, StorageMaintainer
+from frigate.storage import StorageMaintainer
 from frigate.test.const import TEST_DB, TEST_DB_CLEANUPS
 
 
@@ -115,16 +114,8 @@ class TestHttp(unittest.TestCase):
         )
         storage.calculate_camera_bandwidth()
         assert storage.camera_storage_stats == {
-            "front_door": {
+            "front_door": {"bandwidth": 1440, "needs_refresh": True},
-                "bandwidth": 1440,
+            "back_door": {"bandwidth": 2880, "needs_refresh": True},
-                "bandwidth_by_stream": {STREAM_TYPE_MAIN: 1440},
-                "needs_refresh": True,
-            },
-            "back_door": {
-                "bandwidth": 2880,
-                "bandwidth_by_stream": {STREAM_TYPE_MAIN: 2880},
-                "needs_refresh": True,
-            },
         }
 
     def test_segment_calculations_with_zero_segments(self):
@@ -145,116 +136,9 @@ class TestHttp(unittest.TestCase):
         )
         storage.calculate_camera_bandwidth()
         assert storage.camera_storage_stats == {
-            "front_door": {
+            "front_door": {"bandwidth": 0, "needs_refresh": True},
-                "bandwidth": 0,
-                "bandwidth_by_stream": {},
-                "needs_refresh": True,
-            },
         }
 
-    def test_camera_usages_split_by_stream_type(self):
-        """Usage and bandwidth are reported per stream type."""
-        config = FrigateConfig(**self.minimal_config)
-        storage = StorageMaintainer(config, MagicMock())
-
-        time_keep = datetime.datetime.now().timestamp()
-        _insert_mock_recording(
-            "1234567.frontdoor",
-            os.path.join(self.test_dir, "main.tmp"),
-            time_keep,
-            time_keep + 10,
-            seg_size=20,
-            seg_dur=10,
-            stream_type=STREAM_TYPE_MAIN,
-        )
-        _insert_mock_recording(
-            "1234568.frontdoor",
-            os.path.join(self.test_dir, "sub.tmp"),
-            time_keep,
-            time_keep + 10,
-            seg_size=2,
-            seg_dur=10,
-            stream_type=STREAM_TYPE_SUB,
-        )
-
-        storage.calculate_camera_bandwidth()
-        usages = storage.calculate_camera_usages()
-
-        assert usages["front_door"]["usage"] == 22
-        assert usages["front_door"]["bandwidth"] == 7920
-        assert usages["front_door"]["streams"] == {
-            STREAM_TYPE_MAIN: {"usage": 20, "bandwidth": 7200},
-            STREAM_TYPE_SUB: {"usage": 2, "bandwidth": 720},
-        }
-
-    def test_camera_usages_omits_streams_without_segments(self):
-        """A camera with no sub segments reports no sub entry."""
-        config = FrigateConfig(**self.minimal_config)
-        storage = StorageMaintainer(config, MagicMock())
-
-        time_keep = datetime.datetime.now().timestamp()
-        _insert_mock_recording(
-            "1234567.frontdoor",
-            os.path.join(self.test_dir, "main.tmp"),
-            time_keep,
-            time_keep + 10,
-            seg_size=20,
-            seg_dur=10,
-        )
-
-        storage.calculate_camera_bandwidth()
-        usages = storage.calculate_camera_usages()
-
-        assert usages["front_door"]["usage"] == 20
-        assert usages["front_door"]["streams"] == {
-            STREAM_TYPE_MAIN: {"usage": 20, "bandwidth": 7200},
-        }
-
-    def test_camera_bandwidth_clamp_scales_stream_values(self):
-        """Clamping the total keeps the per stream values summing to it."""
-        config = FrigateConfig(**self.minimal_config)
-        storage = StorageMaintainer(config, MagicMock())
-
-        time_keep = datetime.datetime.now().timestamp()
-        _insert_mock_recording(
-            "1234567.frontdoor",
-            os.path.join(self.test_dir, "main.tmp"),
-            time_keep,
-            time_keep + 10,
-            seg_size=40,
-            seg_dur=10,
-            stream_type=STREAM_TYPE_MAIN,
-        )
-        _insert_mock_recording(
-            "1234568.frontdoor",
-            os.path.join(self.test_dir, "sub.tmp"),
-            time_keep,
-            time_keep + 10,
-            seg_size=4,
-            seg_dur=10,
-            stream_type=STREAM_TYPE_SUB,
-        )
-
-        storage.calculate_camera_bandwidth()
-        stats = storage.camera_storage_stats["front_door"]
-
-        assert stats["bandwidth"] == MAX_CALCULATED_BANDWIDTH
-        assert (
-            round(sum(stats["bandwidth_by_stream"].values()), 2)
-            == MAX_CALCULATED_BANDWIDTH
-        )
-
-    def test_camera_usages_with_no_recordings(self):
-        """A camera with no segments reports zero usage and no streams."""
-        config = FrigateConfig(**self.minimal_config)
-        storage = StorageMaintainer(config, MagicMock())
-
-        storage.calculate_camera_bandwidth()
-        usages = storage.calculate_camera_usages()
-
-        assert usages["front_door"]["usage"] == 0
-        assert usages["front_door"]["streams"] == {}
-
     def test_storage_cleanup(self):
         """Ensure that all recordings are cleaned up when necessary."""
         config = FrigateConfig(**self.minimal_config)
@@ -413,7 +297,6 @@ def _insert_mock_recording(
     camera="front_door",
     seg_size=8,
     seg_dur=10,
-    stream_type=STREAM_TYPE_MAIN,
 ) -> Event:
     """Inserts a basic recording model with a given id."""
     # we must open the file so storage maintainer will delete it
@@ -430,5 +313,4 @@ def _insert_mock_recording(
         motion=True,
         objects=True,
         segment_size=seg_size,
-        stream_type=stream_type,
     ).execute()

frigate/test/test_webpush_registration.py

@@ -0,0 +1,150 @@
+"""Tests for push notification subscription validation."""
+
+import unittest
+
+from frigate.api.notification import _validate_push_endpoint, _validate_subscription
+
+VALID_ENDPOINTS = [
+    "https://fcm.googleapis.com/fcm/send/dGhpcy1pcy1hLXRva2Vu",
+    "https://updates.push.services.mozilla.com/wpush/v2/dGhpcy1pcy1hLXRva2Vu",
+    "https://web.push.apple.com/dGhpcy1pcy1hLXRva2Vu",
+    "https://wns2-by3p.notify.windows.com/w/?token=dGhpcy1pcy1hLXRva2Vu",
+    "https://fcm.googleapis.com:443/fcm/send/dGhpcy1pcy1hLXRva2Vu",
+]
+
+
+def _subscription(endpoint: str) -> dict:
+    return {
+        "endpoint": endpoint,
+        "keys": {"p256dh": "cHVibGljLWtleQ", "auth": "YXV0aC1zZWNyZXQ"},
+    }
+
+
+class TestValidatePushEndpoint(unittest.TestCase):
+    def test_accepts_real_push_service_endpoints(self):
+        for endpoint in VALID_ENDPOINTS:
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_http(self):
+        self.assertIsNotNone(
+            _validate_push_endpoint("http://fcm.googleapis.com/fcm/send/token")
+        )
+
+    def test_rejects_non_http_schemes(self):
+        for endpoint in (
+            "file:///etc/passwd",
+            "ftp://example.com/token",
+            "//example.com/token",
+        ):
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_localhost(self):
+        for endpoint in (
+            "https://localhost/token",
+            "https://localhost:443/token",
+            "https://127.0.0.1/token",
+            "https://[::1]/token",
+        ):
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_private_addresses(self):
+        for endpoint in (
+            "https://192.168.1.10/token",
+            "https://10.0.0.5/token",
+            "https://172.16.0.1/token",
+            "https://169.254.169.254/token",
+            "https://0.0.0.0/token",
+        ):
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_internal_hostnames(self):
+        for endpoint in (
+            "https://frigate/token",
+            "https://nas.local/token",
+            "https://push.internal/token",
+            "https://host.home.arpa/token",
+        ):
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_non_default_port(self):
+        self.assertIsNotNone(
+            _validate_push_endpoint("https://fcm.googleapis.com:8080/fcm/send/token")
+        )
+
+    def test_rejects_embedded_credentials(self):
+        self.assertIsNotNone(
+            _validate_push_endpoint(
+                "https://user:pass@fcm.googleapis.com/fcm/send/token"
+            )
+        )
+
+    def test_rejects_endpoint_without_path(self):
+        for endpoint in ("https://fcm.googleapis.com", "https://fcm.googleapis.com/"):
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_endpoint_that_breaks_audience_parsing(self):
+        # webpush.py locates the host by searching for a separator after index
+        # 10, which raises ValueError when the url has no path at all
+        endpoint = "https://fcm.googleapis.com"
+
+        with self.assertRaises(ValueError):
+            endpoint.index("/", 10)
+
+        self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_missing_or_non_string_endpoint(self):
+        for endpoint in (None, "", 5, {"url": "https://example.com/token"}):
+            with self.subTest(endpoint=endpoint):
+                self.assertIsNotNone(_validate_push_endpoint(endpoint))
+
+    def test_rejects_overlong_endpoint(self):
+        self.assertIsNotNone(
+            _validate_push_endpoint(f"https://fcm.googleapis.com/{'a' * 4096}")
+        )
+
+
+class TestValidateSubscription(unittest.TestCase):
+    def test_accepts_valid_subscription(self):
+        self.assertIsNone(_validate_subscription(_subscription(VALID_ENDPOINTS[0])))
+
+    def test_accepts_extra_fields_sent_by_the_browser(self):
+        sub = _subscription(VALID_ENDPOINTS[0])
+        sub["expirationTime"] = None
+        self.assertIsNone(_validate_subscription(sub))
+
+    def test_rejects_non_object(self):
+        for sub in ("https://fcm.googleapis.com/fcm/send/token", ["endpoint"], 5):
+            with self.subTest(sub=sub):
+                self.assertIsNotNone(_validate_subscription(sub))
+
+    def test_rejects_bad_endpoint(self):
+        self.assertIsNotNone(
+            _validate_subscription(_subscription("https://localhost/t"))
+        )
+
+    def test_rejects_missing_keys(self):
+        sub = _subscription(VALID_ENDPOINTS[0])
+        del sub["keys"]
+        self.assertIsNotNone(_validate_subscription(sub))
+
+    def test_rejects_incomplete_keys(self):
+        for keys in (
+            {"p256dh": "cHVibGljLWtleQ"},
+            {"auth": "YXV0aC1zZWNyZXQ"},
+            {"p256dh": "cHVibGljLWtleQ", "auth": ""},
+            {"p256dh": None, "auth": "YXV0aC1zZWNyZXQ"},
+        ):
+            with self.subTest(keys=keys):
+                sub = _subscription(VALID_ENDPOINTS[0])
+                sub["keys"] = keys
+                self.assertIsNotNone(_validate_subscription(sub))
+
+
+if __name__ == "__main__":
+    unittest.main()

frigate/test/test_ws_send_queue.py

@@ -0,0 +1,107 @@
+"""Outbound websocket sends must never block the thread calling publish()."""
+
+import socket
+import threading
+import unittest
+
+from frigate.comms.ws import WS_MAX_PENDING_MESSAGES, WebSocket
+
+
+class _FakeSock:
+    """Socket stand-in; ``block`` makes sendall hang like a client that stopped reading."""
+
+    def __init__(self, block: bool = False) -> None:
+        self.block = block
+        self.released = threading.Event()
+        self.shutdown_called = threading.Event()
+        self.frames: list[bytes] = []
+
+    def sendall(self, data: bytes) -> None:
+        if self.block and not self.released.is_set():
+            self.released.wait(timeout=10)
+            raise BrokenPipeError()
+        self.frames.append(data)
+
+    def shutdown(self, how: int) -> None:
+        assert how == socket.SHUT_RDWR
+        self.shutdown_called.set()
+        self.released.set()
+
+    def close(self) -> None:
+        pass
+
+    def fileno(self) -> int:
+        return 99
+
+
+def _wait_for(predicate, timeout: float = 2.0) -> bool:
+    deadline = threading.Event()
+    for _ in range(int(timeout / 0.01)):
+        if predicate():
+            return True
+        deadline.wait(0.01)
+    return predicate()
+
+
+class TestWebSocketSendQueue(unittest.TestCase):
+    def _open(self, sock: _FakeSock) -> WebSocket:
+        ws = WebSocket(sock)
+        ws.opened()
+        return ws
+
+    def test_stalled_client_does_not_block_publisher(self):
+        sock = _FakeSock(block=True)
+        ws = self._open(sock)
+
+        def publish_many():
+            for i in range(WS_MAX_PENDING_MESSAGES + 5):
+                ws.send(f"message {i}")
+
+        publisher = threading.Thread(target=publish_many, daemon=True)
+        publisher.start()
+        publisher.join(timeout=2.0)
+
+        self.assertFalse(publisher.is_alive(), "publish() blocked on a stalled client")
+        self.assertTrue(
+            sock.shutdown_called.wait(timeout=2.0),
+            "a client that cannot keep up should be disconnected",
+        )
+
+    def test_overflow_warns_and_shuts_down_once(self):
+        sock = _FakeSock(block=True)
+        ws = self._open(sock)
+        shutdown_calls = []
+        original_shutdown = sock.shutdown
+        sock.shutdown = lambda how: (shutdown_calls.append(how), original_shutdown(how))
+
+        with self.assertLogs("frigate.comms.ws", level="WARNING") as logs:
+            # keep publishing after overflow, as the dispatcher does until the
+            # manager thread removes the connection
+            for i in range(WS_MAX_PENDING_MESSAGES * 3):
+                ws.send(f"message {i}")
+
+        self.assertEqual(len(logs.output), 1)
+        self.assertEqual(len(shutdown_calls), 1)
+
+    def test_messages_delivered_in_order(self):
+        sock = _FakeSock()
+        ws = self._open(sock)
+        for i in range(3):
+            ws.send(f"message {i}")
+
+        self.assertTrue(_wait_for(lambda: len(sock.frames) == 3))
+        for i, frame in enumerate(sock.frames):
+            self.assertIn(f"message {i}".encode(), frame)
+        self.assertFalse(sock.shutdown_called.is_set())
+
+    def test_closed_stops_writer_thread(self):
+        sock = _FakeSock()
+        ws = self._open(sock)
+        writer = ws._writer
+        ws.closed(1000, "bye")
+        writer.join(timeout=2.0)
+        self.assertFalse(writer.is_alive())
+
+
+if __name__ == "__main__":
+    unittest.main()

frigate/track/object_processing.py

@@ -68,7 +68,6 @@ class TrackedObjectProcessor(threading.Thread):
         self.tracked_objects_queue = tracked_objects_queue
         self.stop_event: MpEvent = stop_event
         self.camera_states: dict[str, CameraState] = {}
-        self.camera_states_lock = threading.Lock()
         self.frame_manager = SharedMemoryFrameManager()
         self.last_motion_detected: dict[str, float] = {}
         self.ptz_autotracker_thread = ptz_autotracker_thread
@@ -237,9 +236,7 @@ class TrackedObjectProcessor(threading.Thread):
         camera_state.on("end", end)
         camera_state.on("snapshot", snapshot)
         camera_state.on("camera_activity", camera_activity)
-
+        self.camera_states[camera] = camera_state
-        with self.camera_states_lock:
-            self.camera_states[camera] = camera_state
 
     def should_save_snapshot(self, camera: str, obj: TrackedObject) -> bool:
         if obj.false_positive:
@@ -327,22 +324,9 @@ class TrackedObjectProcessor(threading.Thread):
                 # reset the last_motion so redundant `off` commands aren't sent
                 self.last_motion_detected[camera] = 0
 
-    def get_camera_state(self, camera: str) -> CameraState | None:
-        """Returns the state for a camera, or None if it does not exist."""
-        with self.camera_states_lock:
-            return self.camera_states.get(camera)
-
-    def get_camera_states(self) -> list[CameraState]:
-        """Returns a snapshot of camera states that is safe to iterate."""
-        with self.camera_states_lock:
-            return list(self.camera_states.values())
-
     def get_best(self, camera: str, label: str) -> dict[str, Any]:
-        camera_state = self.get_camera_state(camera)
+        # TODO: need a lock here
-
+        camera_state = self.camera_states[camera]
-        if camera_state is None:
-            return {}
-
         if label in camera_state.best_objects:
             best_obj = camera_state.best_objects[label]
 
@@ -366,21 +350,17 @@ class TrackedObjectProcessor(threading.Thread):
                 (self.config.birdseye.height * 3 // 2, self.config.birdseye.width),
             )
 
-        camera_state = self.get_camera_state(camera)
+        if camera not in self.camera_states:
-
-        if camera_state is None:
             return None
 
-        return camera_state.get_current_frame(draw_options)
+        return self.camera_states[camera].get_current_frame(draw_options)
 
     def get_current_frame_time(self, camera: str) -> float:
         """Returns the latest frame time for a given camera."""
-        camera_state = self.get_camera_state(camera)
+        if camera not in self.camera_states:
-
-        if camera_state is None:
             return 0.0
 
-        return camera_state.current_frame_time
+        return self.camera_states[camera].current_frame_time
 
     def set_sub_label(
         self, event_id: str, sub_label: str | None, score: float | None
@@ -518,18 +498,14 @@ class TrackedObjectProcessor(threading.Thread):
         # save the snapshot image
         (frame, event_id, camera) = payload
 
-        camera_state = self.camera_states.get(camera)
-
-        if camera_state is None:
-            logger.debug("Discarding LPR snapshot for unknown camera %s", camera)
-            return
-
         img = cv2.imdecode(
             np.frombuffer(base64.b64decode(frame), dtype=np.uint8),
             cv2.IMREAD_COLOR,
         )
 
-        camera_state.save_manual_event_image(img, event_id, "license_plate", {})
+        self.camera_states[camera].save_manual_event_image(
+            img, event_id, "license_plate", {}
+        )
 
     def create_manual_event(self, payload: tuple) -> None:
         (
@@ -546,17 +522,13 @@ class TrackedObjectProcessor(threading.Thread):
             pre_capture,
         ) = payload
 
-        camera_state = self.camera_states.get(camera_name)
-
-        if camera_state is None:
-            logger.debug("Discarding manual event for unknown camera %s", camera_name)
-            return
-
         # save the snapshot image
-        camera_state.save_manual_event_image(None, event_id, label, draw)
+        self.camera_states[camera_name].save_manual_event_image(
+            None, event_id, label, draw
+        )
         end_time = frame_time + duration if duration is not None else None
         start_time = (
-            frame_time - camera_state.camera_config.record.event_pre_capture
+            frame_time - self.config.cameras[camera_name].record.event_pre_capture
             if pre_capture is None
             else frame_time - pre_capture
         )
@@ -576,7 +548,7 @@ class TrackedObjectProcessor(threading.Thread):
                     "camera": camera_name,
                     "start_time": start_time,
                     "end_time": end_time,
-                    "has_clip": camera_state.camera_config.record.enabled
+                    "has_clip": self.config.cameras[camera_name].record.enabled
                     and include_recording,
                     "has_snapshot": True,
                     "snapshot_clean": True,
@@ -619,12 +591,6 @@ class TrackedObjectProcessor(threading.Thread):
             plate,
         ) = payload
 
-        camera_state = self.camera_states.get(camera_name)
-
-        if camera_state is None:
-            logger.debug("Discarding LPR event for unknown camera %s", camera_name)
-            return
-
         # send event to event maintainer
         self.event_sender.publish(
             (
@@ -639,9 +605,9 @@ class TrackedObjectProcessor(threading.Thread):
                     "score": score,
                     "camera": camera_name,
                     "start_time": frame_time
-                    - camera_state.camera_config.record.event_pre_capture,
+                    - self.config.cameras[camera_name].record.event_pre_capture,
                     "end_time": None,
-                    "has_clip": camera_state.camera_config.record.enabled
+                    "has_clip": self.config.cameras[camera_name].record.enabled
                     and include_recording,
                     "has_snapshot": True,
                     "snapshot_clean": True,
@@ -733,10 +699,7 @@ class TrackedObjectProcessor(threading.Thread):
                         continue
 
                     camera_state.shutdown()
-
+                    self.camera_states.pop(camera)
-                    with self.camera_states_lock:
-                        self.camera_states.pop(camera)
-
                     self.camera_activity.pop(camera, None)
                     self.last_motion_detected.pop(camera, None)
 
@@ -752,6 +715,8 @@ class TrackedObjectProcessor(threading.Thread):
                 if camera_state is None:
                     continue
 
+                camera_state = self.camera_states[camera]
+
                 if camera_state.prev_enabled and not current_enabled:
                     logger.debug(f"Not processing objects for disabled camera {camera}")
                     self.force_end_all_events(camera, camera_state)
@@ -847,11 +812,7 @@ class TrackedObjectProcessor(threading.Thread):
                     break
 
                 event_id, camera, _ = update
-                camera_state = self.camera_states.get(camera)
+                self.camera_states[camera].finished(event_id)
-
-                # the camera may have been removed while its event was pending
-                if camera_state is not None:
-                    camera_state.finished(event_id)
 
         # shut down camera states
         for state in self.camera_states.values():

frigate/track/tracked_object.py

@@ -164,7 +164,6 @@ class TrackedObject:
                         "attributes": obj_data["attributes"],
                         "current_estimated_speed": self.current_estimated_speed,
                         "velocity_angle": self.velocity_angle,
-                        "path_data": self.path_data.copy(),
                         "recognized_license_plate": obj_data.get(
                             "recognized_license_plate"
                         ),

frigate/util/audio.py

@@ -6,33 +6,12 @@ import subprocess as sp
 
 from pathvalidate import sanitize_filename
 
-from frigate.const import CACHE_DIR, STREAM_TYPE_MAIN, STREAM_TYPE_SUB
+from frigate.const import CACHE_DIR
 from frigate.models import Recordings
 
 logger = logging.getLogger(__name__)
 
 
-def _get_recordings_for_range(
-    camera_name: str, start_ts: float, end_ts: float, stream_type: str
-) -> list[Recordings]:
-    """Fetch one stream type's recording rows overlapping the requested range."""
-    return list(
-        Recordings.select(
-            Recordings.path,
-            Recordings.start_time,
-            Recordings.end_time,
-        )
-        .where(
-            (Recordings.start_time.between(start_ts, end_ts))
-            | (Recordings.end_time.between(start_ts, end_ts))
-            | ((start_ts > Recordings.start_time) & (end_ts < Recordings.end_time))
-        )
-        .where(Recordings.camera == camera_name)
-        .where(Recordings.stream_type == stream_type)
-        .order_by(Recordings.start_time.asc())
-    )
-
-
 def get_audio_from_recording(
     ffmpeg,
     camera_name: str,
@@ -52,16 +31,21 @@ def get_audio_from_recording(
     Returns:
         Bytes of WAV audio data or None if extraction failed
     """
-    # Fetch all relevant recording segments; never mix streams in one
+    # Fetch all relevant recording segments
-    # concat, so prefer main and fall back to sub for expired-main history
+    recordings = (
-    recordings = _get_recordings_for_range(
+        Recordings.select(
-        camera_name, start_ts, end_ts, STREAM_TYPE_MAIN
+            Recordings.path,
-    )
+            Recordings.start_time,
-
+            Recordings.end_time,
-    if not recordings:
-        recordings = _get_recordings_for_range(
-            camera_name, start_ts, end_ts, STREAM_TYPE_SUB
         )
+        .where(
+            (Recordings.start_time.between(start_ts, end_ts))
+            | (Recordings.end_time.between(start_ts, end_ts))
+            | ((start_ts > Recordings.start_time) & (end_ts < Recordings.end_time))
+        )
+        .where(Recordings.camera == camera_name)
+        .order_by(Recordings.start_time.asc())
+    )
 
     if not recordings:
         logger.debug(

frigate/util/classification.py

@@ -18,7 +18,6 @@ from frigate.const import (
     CLIPS_DIR,
     MODEL_CACHE_DIR,
     PROCESS_PRIORITY_LOW,
-    STREAM_TYPE_MAIN,
     UPDATE_MODEL_STATE,
 )
 from frigate.log import redirect_output_to_logger, suppress_stderr_during
@@ -556,7 +555,6 @@ def _extract_keyframes(
                     (timestamp >= Recordings.start_time)
                     & (timestamp <= Recordings.end_time)
                     & (Recordings.camera == camera)
-                    & (Recordings.stream_type == STREAM_TYPE_MAIN)
                 )
                 .order_by(Recordings.start_time.desc())
                 .limit(1)

frigate/util/config.py

@@ -20,7 +20,7 @@ from frigate.util.services import get_video_properties
 
 logger = logging.getLogger(__name__)
 
-CURRENT_CONFIG_VERSION = "0.19-0"
+CURRENT_CONFIG_VERSION = "0.18-0"
 DEFAULT_CONFIG_FILE = os.path.join(CONFIG_DIR, "config.yml")
 
 
@@ -93,7 +93,6 @@ def migrate_frigate_config(config_file: str):
 
     logger.info("copying config as backup...")
     shutil.copy(config_file, os.path.join(CONFIG_DIR, "backup_config.yaml"))
-    new_config = config
 
     if previous_version < "0.14":
         logger.info(f"Migrating frigate config from {previous_version} to 0.14...")
@@ -148,13 +147,6 @@ def migrate_frigate_config(config_file: str):
             yaml.dump(new_config, f)
         previous_version = "0.18-0"
 
-    if previous_version < "0.19-0":
-        logger.info(f"Migrating frigate config from {previous_version} to 0.19-0...")
-        new_config = migrate_019_0(new_config)
-        with open(config_file, "w") as f:
-            yaml.dump(new_config, f)
-        previous_version = "0.19-0"
-
     logger.info("Finished frigate config migration...")
 
 
@@ -533,21 +525,6 @@ def _convert_legacy_mask_to_dict(
     return result
 
 
-def _migrate_birdseye_mode(birdseye: dict[str, Any] | None) -> None:
-    """Convert a scalar Birdseye mode to composable activity types."""
-    if not birdseye or not isinstance(birdseye.get("mode"), str):
-        return
-
-    legacy_mode = birdseye["mode"]
-    activity_types = ("continuous", "motion", "objects", "stationary_objects")
-    if legacy_mode not in activity_types:
-        return
-
-    birdseye["mode"] = {
-        activity_type: activity_type == legacy_mode for activity_type in activity_types
-    }
-
-
 def migrate_018_0(config: dict[str, dict[str, Any]]) -> dict[str, dict[str, Any]]:
     """Handle migrating frigate config to 0.18-0"""
     new_config = config.copy()
@@ -681,26 +658,6 @@ def migrate_018_0(config: dict[str, dict[str, Any]]) -> dict[str, dict[str, Any]
     return new_config
 
 
-def migrate_019_0(config: dict[str, dict[str, Any]]) -> dict[str, dict[str, Any]]:
-    """Handle migrating Frigate config to 0.19-0."""
-    new_config = config.copy()
-
-    _migrate_birdseye_mode(new_config.get("birdseye"))
-
-    for name, camera in new_config.get("cameras", {}).items():
-        camera_config: dict[str, dict[str, Any]] = camera.copy()
-        _migrate_birdseye_mode(camera_config.get("birdseye"))
-
-        for profile in camera_config.get("profiles", {}).values():
-            if isinstance(profile, dict):
-                _migrate_birdseye_mode(profile.get("birdseye"))
-
-        new_config["cameras"][name] = camera_config
-
-    new_config["version"] = "0.19-0"
-    return new_config
-
-
 def get_relative_coordinates(
     mask: str | list | None,
     frame_shape: tuple[int, int],

frigate/util/media.py

@@ -1,11 +1,10 @@
 """Recordings Utilities."""
 
-import asyncio
-import contextlib
 import datetime
 import errno
 import logging
 import os
+import subprocess as sp
 from collections.abc import Iterable
 from dataclasses import dataclass, field
 from pathlib import Path
@@ -880,43 +879,38 @@ def sync_all_media(
     return results
 
 
-async def get_keyframe_offsets(path: str) -> list[int] | None:
+def get_keyframe_before(path: str, offset_ms: int) -> int | None:
-    """Get every video keyframe offset (ms from segment start) in an mp4.
+    """Get the timestamp (ms) of the last keyframe at or before offset_ms.
 
-    Runs at record time so playback never needs to probe. Returns None if
+    Uses ffprobe packet index to read keyframe positions from the mp4 file.
-    ffprobe fails, so the caller stores NULL and playback falls back to
+    Returns None if ffprobe fails or no keyframe is found before the offset.
-    serving whole files.
     """
-    proc = None
     try:
-        proc = await asyncio.create_subprocess_exec(
+        result = sp.run(
-            FFPROBE_PATH,
+            [
-            "-select_streams",
+                FFPROBE_PATH,
-            "v:0",
+                "-select_streams",
-            "-show_entries",
+                "v:0",
-            "packet=pts_time,flags",
+                "-show_entries",
-            "-of",
+                "packet=pts_time,flags",
-            "csv=p=0",
+                "-of",
-            "-loglevel",
+                "csv=p=0",
-            "error",
+                "-loglevel",
-            path,
+                "error",
-            stdout=asyncio.subprocess.PIPE,
+                path,
-            stderr=asyncio.subprocess.DEVNULL,
+            ],
+            capture_output=True,
+            timeout=5,
         )
-        stdout, _ = await asyncio.wait_for(proc.communicate(), timeout=5)
+    except (sp.TimeoutExpired, FileNotFoundError):
-    except (TimeoutError, FileNotFoundError):
-        if proc is not None and proc.returncode is None:
-            with contextlib.suppress(ProcessLookupError):
-                proc.kill()
-            with contextlib.suppress(TimeoutError):
-                await asyncio.wait_for(proc.communicate(), timeout=2)
         return None
 
-    if proc.returncode != 0:
+    if result.returncode != 0:
         return None
 
-    offsets: list[int] = []
+    offset_s = offset_ms / 1000.0
-    for line in stdout.decode().strip().splitlines():
+    best_ms = None
+    for line in result.stdout.decode().strip().splitlines():
         parts = line.strip().split(",")
         if len(parts) != 2:
             continue
@@ -924,8 +918,12 @@ async def get_keyframe_offsets(path: str) -> list[int] | None:
         if "K" not in flags:
             continue
         try:
-            offsets.append(int(float(ts_str) * 1000))
+            ts = float(ts_str)
         except ValueError:
             continue
+        if ts <= offset_s:
+            best_ms = int(ts * 1000)
+        else:
+            break
 
-    return offsets
+    return best_ms

frigate/util/object_names.py

@@ -1,209 +0,0 @@
-"""Aggregation of the known sub label names an object can be tagged with."""
-
-import logging
-import os
-
-from pathvalidate import sanitize_filename
-
-from frigate.config import FrigateConfig
-from frigate.config.classification import ObjectClassificationType
-from frigate.const import CLIPS_DIR, FACE_DIR, MODEL_CACHE_DIR
-from frigate.util.builtin import load_labels
-
-logger = logging.getLogger(__name__)
-
-# subdirectory of FACE_DIR holding unassigned training images, not a face name
-FACE_TRAIN_DIR = "train"
-
-# category used by classification models for "no match", never attached to an object
-CLASSIFICATION_NONE_CATEGORY = "none"
-
-
-def get_categorized_object_names(
-    config: FrigateConfig,
-    allowed_cameras: list[str],
-    object_type: str | None = None,
-) -> dict[str, list[str]]:
-    """Collect every sub label name this install can attach, by object type.
-
-    Unlike the database-backed /sub_labels endpoint, this reads the config and
-    model files, so it also covers names that are configured but have not been
-    detected yet. Names come from the detector's logo attributes (limited to
-    objects the allowed cameras actually track), LPR known plate names,
-    registered face names, and custom object classification categories.
-
-    Structural attributes such as `face` and `license_plate` are excluded: they
-    describe a part of an object rather than naming it, and are never attached
-    as a sub label.
-
-    Args:
-        config: The running Frigate config
-        allowed_cameras: Cameras the requesting user may see
-        object_type: Optional object label to restrict the result to
-
-    Returns:
-        Mapping of object label to its known sub label names, sorted and
-        deduplicated. Object types with no known names are omitted.
-    """
-    tracked_objects = _get_tracked_objects(config, allowed_cameras)
-    names: dict[str, set[str]] = {}
-    logos = set(config.model.all_attribute_logos)
-
-    # 1. detector logo attributes, only for objects that are actually tracked
-    for label, label_attributes in config.model.attributes_map.items():
-        if label not in tracked_objects:
-            continue
-
-        label_logos = logos.intersection(label_attributes)
-
-        if label_logos:
-            names.setdefault(label, set()).update(label_logos)
-
-    # 2. LPR known plate names, for objects that can carry a plate
-    if config.lpr.known_plates and _lpr_enabled(config, allowed_cameras):
-        known_plates = set(config.lpr.known_plates)
-
-        for label in _objects_with_attribute(config, tracked_objects, "license_plate"):
-            names.setdefault(label, set()).update(known_plates)
-
-    # 3. registered face names, for objects that can carry a face
-    if _face_recognition_enabled(config, allowed_cameras):
-        face_names = _get_face_names()
-
-        if face_names:
-            for label in _objects_with_attribute(config, tracked_objects, "face"):
-                names.setdefault(label, set()).update(face_names)
-
-    # 4. custom object classification categories
-    for model_key, model_config in config.classification.custom.items():
-        if not model_config.enabled or model_config.object_config is None:
-            continue
-
-        if (
-            model_config.object_config.classification_type
-            != ObjectClassificationType.sub_label
-        ):
-            continue
-
-        categories = _get_classification_categories(model_key)
-
-        if not categories:
-            continue
-
-        for label in model_config.object_config.objects:
-            names.setdefault(label, set()).update(categories)
-
-    return {
-        label: sorted(label_names)
-        for label, label_names in sorted(names.items())
-        if label_names and (object_type is None or label == object_type)
-    }
-
-
-def _get_tracked_objects(config: FrigateConfig, allowed_cameras: list[str]) -> set[str]:
-    """Get the union of objects tracked by the cameras the user can see."""
-    tracked: set[str] = set()
-
-    for camera_name in allowed_cameras:
-        camera_config = config.cameras.get(camera_name)
-
-        if camera_config is None:
-            continue
-
-        tracked.update(camera_config.objects.track)
-
-    return tracked
-
-
-def _objects_with_attribute(
-    config: FrigateConfig, tracked_objects: set[str], attribute: str
-) -> set[str]:
-    """Get the tracked objects that a given attribute can be recognized on.
-
-    The attribute may also be tracked as an object in its own right, as
-    `license_plate` is on a dedicated LPR camera, in which case the name is
-    attached to that object directly.
-    """
-    objects = {
-        label
-        for label, label_attributes in config.model.attributes_map.items()
-        if attribute in label_attributes and label in tracked_objects
-    }
-
-    if attribute in tracked_objects:
-        objects.add(attribute)
-
-    return objects
-
-
-def _lpr_enabled(config: FrigateConfig, allowed_cameras: list[str]) -> bool:
-    return any(
-        config.cameras[camera_name].lpr.enabled
-        for camera_name in allowed_cameras
-        if camera_name in config.cameras
-    )
-
-
-def _face_recognition_enabled(
-    config: FrigateConfig, allowed_cameras: list[str]
-) -> bool:
-    return any(
-        config.cameras[camera_name].face_recognition.enabled
-        for camera_name in allowed_cameras
-        if camera_name in config.cameras
-    )
-
-
-def _get_face_names() -> set[str]:
-    """Get the names of every registered face collection."""
-    if not os.path.exists(FACE_DIR):
-        return set()
-
-    try:
-        entries = os.listdir(FACE_DIR)
-    except OSError:
-        logger.debug("Failed to read face directory %s", FACE_DIR)
-        return set()
-
-    return {
-        name
-        for name in entries
-        if name != FACE_TRAIN_DIR and os.path.isdir(os.path.join(FACE_DIR, name))
-    }
-
-
-def _get_classification_categories(model_key: str) -> set[str]:
-    """Get the categories a custom classification model can output.
-
-    The trained labelmap is authoritative, but it only exists once the model
-    has been trained, so fall back to the dataset directories that will become
-    the labelmap on the next training run.
-    """
-    safe_key = sanitize_filename(model_key)
-    categories: set[str] = set()
-    labelmap_path = os.path.join(MODEL_CACHE_DIR, safe_key, "labelmap.txt")
-
-    if os.path.exists(labelmap_path):
-        try:
-            labelmap = load_labels(labelmap_path, prefill=0, indexed=False)
-        except OSError:
-            logger.debug("Failed to read labelmap %s", labelmap_path)
-            labelmap = {}
-
-        categories.update(label for label in labelmap.values() if label)
-
-    dataset_dir = os.path.join(CLIPS_DIR, safe_key, "dataset")
-
-    if os.path.exists(dataset_dir):
-        try:
-            entries = os.listdir(dataset_dir)
-        except OSError:
-            logger.debug("Failed to read dataset directory %s", dataset_dir)
-            entries = []
-
-        categories.update(
-            name for name in entries if os.path.isdir(os.path.join(dataset_dir, name))
-        )
-
-    categories.discard(CLASSIFICATION_NONE_CATEGORY)
-    return categories

frigate/util/recording_coverage.py

@@ -1,422 +0,0 @@
-"""Merge main and sub stream recording rows into a unified coverage timeline."""
-
-import logging
-from dataclasses import dataclass
-from typing import Any
-
-from frigate.const import MAX_SEGMENT_DURATION, STREAM_TYPE_MAIN, STREAM_TYPE_SUB
-from frigate.models import Recordings
-
-logger = logging.getLogger(__name__)
-
-# intervals shorter than this are boundary artifacts, not playable content
-MIN_INTERVAL_S = 0.1
-
-
-@dataclass
-class CoverageInterval:
-    """A time span annotated with the recording row covering it per stream."""
-
-    start_time: float
-    end_time: float
-    main: Any | None
-    sub: Any | None
-
-
-def _rows_query(camera: str, after: float, before: float, stream_type: str) -> Any:
-    return (
-        Recordings.select(
-            Recordings.path,
-            Recordings.start_time,
-            Recordings.end_time,
-            Recordings.duration,
-            Recordings.has_audio,
-            Recordings.audio_rate,
-            Recordings.audio_codec,
-            Recordings.video_codec,
-            Recordings.segment_size,
-            Recordings.keyframes,
-        )
-        .where(
-            (Recordings.camera == camera)
-            & (Recordings.stream_type == stream_type)
-            & (Recordings.end_time > after)
-            & (Recordings.start_time < before)
-            & (Recordings.start_time > after - MAX_SEGMENT_DURATION)
-        )
-        .order_by(Recordings.start_time.asc())
-        .namedtuples()
-    )
-
-
-def _get_rows(camera: str, after: float, before: float, stream_type: str) -> list[Any]:
-    return list(_rows_query(camera, after, before, stream_type))
-
-
-def _covering(
-    rows: list[Any], idx: int, start: float, end: float
-) -> tuple[Any | None, int]:
-    """Find the row covering [start, end), advancing idx (rows are sorted, non-overlapping)."""
-    while idx < len(rows) and rows[idx].end_time <= start:
-        idx += 1
-    if idx < len(rows) and rows[idx].start_time <= start and rows[idx].end_time >= end:
-        return rows[idx], idx
-    return None, idx
-
-
-def resolve_coverage(
-    camera: str, after: float, before: float
-) -> list[CoverageInterval]:
-    """Resolve the unified coverage timeline for a camera and time range.
-
-    Returns intervals bounded by the union of both streams' segment edges,
-    clamped to [after, before]. Ranges covered by neither stream produce no
-    interval (a gap).
-    """
-    main_rows = _get_rows(camera, after, before, STREAM_TYPE_MAIN)
-    sub_rows = _get_rows(camera, after, before, STREAM_TYPE_SUB)
-
-    boundaries: set[float] = set()
-    for row in main_rows + sub_rows:
-        boundaries.add(max(row.start_time, after))
-        boundaries.add(min(row.end_time, before))
-
-    ordered = sorted(boundaries)
-    intervals: list[CoverageInterval] = []
-    main_idx = 0
-    sub_idx = 0
-
-    for i in range(len(ordered) - 1):
-        start, end = ordered[i], ordered[i + 1]
-
-        if end - start < MIN_INTERVAL_S:
-            continue
-
-        main_row, main_idx = _covering(main_rows, main_idx, start, end)
-        sub_row, sub_idx = _covering(sub_rows, sub_idx, start, end)
-
-        if main_row is None and sub_row is None:
-            continue
-
-        intervals.append(CoverageInterval(start, end, main_row, sub_row))
-
-    return intervals
-
-
-def known_video_codecs(intervals: list[CoverageInterval]) -> set[str]:
-    """Collect the known video codecs across all rows in a coverage window.
-
-    NULL codecs (legacy rows probed before the column existed) are
-    excluded, so uniformly-unknown data reports an empty set.
-    """
-    return {
-        row.video_codec
-        for interval in intervals
-        for row in (interval.main, interval.sub)
-        if row is not None and row.video_codec is not None
-    }
-
-
-def stream_media_summary(
-    intervals: list[CoverageInterval],
-) -> dict[str, dict[str, Any]]:
-    """Summarize the most recently known media details per stream.
-
-    Every field reports the newest non-NULL value across that stream's
-    rows, so an older row can still supply a value a legacy newer row
-    lacks. A stream with no rows is omitted entirely.
-    """
-    fields = ("video_codec", "audio_rate", "audio_codec", "has_audio")
-    summary: dict[str, dict[str, Any]] = {}
-
-    for stream_type in (STREAM_TYPE_MAIN, STREAM_TYPE_SUB):
-        # the same row can back many intervals, so dedupe by path
-        rows = {
-            row.path: row
-            for interval in intervals
-            if (row := getattr(interval, stream_type)) is not None
-        }
-
-        if not rows:
-            continue
-
-        newest_first = sorted(rows.values(), key=lambda r: r.start_time, reverse=True)
-        stream_summary: dict[str, Any] = {field: None for field in fields}
-
-        for field in fields:
-            for row in newest_first:
-                value = getattr(row, field)
-                if value is not None:
-                    stream_summary[field] = value
-                    break
-
-        # segment_size is stored in MiB; totalling bytes and seconds
-        # weights by duration, unlike averaging per-row ratios
-        total_bytes = 0.0
-        total_seconds = 0.0
-        for row in rows.values():
-            size = row.segment_size
-            if size is None or size <= 0 or row.duration is None or row.duration <= 0:
-                continue
-            total_bytes += size * 1024 * 1024
-            total_seconds += row.duration
-
-        stream_summary["bitrate"] = (
-            int(total_bytes * 8 / total_seconds) if total_seconds > 0 else None
-        )
-
-        summary[stream_type] = stream_summary
-
-    return summary
-
-
-def coverage_spans(intervals: list[CoverageInterval]) -> list[dict[str, Any]]:
-    """Collapse intervals into contiguous spans of identical stream availability."""
-    spans: list[dict[str, Any]] = []
-
-    for interval in intervals:
-        streams = [
-            t
-            for t, row in (
-                (STREAM_TYPE_MAIN, interval.main),
-                (STREAM_TYPE_SUB, interval.sub),
-            )
-            if row is not None
-        ]
-        if (
-            spans
-            and spans[-1]["end_time"] == interval.start_time
-            and spans[-1]["streams"] == streams
-        ):
-            spans[-1]["end_time"] = interval.end_time
-        else:
-            spans.append(
-                {
-                    "start_time": interval.start_time,
-                    "end_time": interval.end_time,
-                    "streams": streams,
-                }
-            )
-
-    return spans
-
-
-def stream_has_audio(intervals: list[CoverageInterval], main: bool) -> bool:
-    """Whether a stream is audio-bearing over a coverage window.
-
-    A stream counts as audio-bearing unless EVERY one of its rows reports
-    has_audio False; NULL (legacy or undetermined) counts as audio.
-    """
-    return any(
-        row is not None and row.has_audio is not False
-        for row in ((interval.main if main else interval.sub) for interval in intervals)
-    )
-
-
-def null_audio_glitches(
-    intervals: list[CoverageInterval], main_audio: bool, sub_audio: bool
-) -> list[CoverageInterval]:
-    """Treat video-only glitch rows on audio-bearing streams as no recording.
-
-    nginx-vod requires every clip in a sequence to carry the same track
-    count, so a truncated video-only segment (a backend restart can flush
-    a sub-second file before any audio packet landed) poisons every
-    manifest that includes it. Nulling the row turns the glitch into a
-    hole the span builder skips like any recording gap.
-    """
-    result: list[CoverageInterval] = []
-    for interval in intervals:
-        main = interval.main
-        sub = interval.sub
-        if main is not None and main_audio and main.has_audio is False:
-            main = None
-        if sub is not None and sub_audio and sub.has_audio is False:
-            sub = None
-        if main is None and sub is None:
-            continue
-        if main is interval.main and sub is interval.sub:
-            result.append(interval)
-        else:
-            result.append(
-                CoverageInterval(interval.start_time, interval.end_time, main, sub)
-            )
-    return result
-
-
-def build_spans(
-    intervals: list[CoverageInterval], stream: str | None
-) -> list[list[Any]]:
-    """Merge coverage intervals into single-sequence spans of one row each.
-
-    Each span is [row, start, end, is_main]; is_main lets the manifest
-    builder detect cross-stream hand-offs. A pinned stream serves only
-    its own rows; otherwise main is preferred and sub fills the gaps.
-    Intervals served by the same row merge on row identity alone, since
-    splitting a row mid-file would re-snap to a keyframe and repeat
-    content.
-    """
-    spans: list[list[Any]] = []
-    last_is_main: bool | None = None
-    for interval in intervals:
-        if stream == STREAM_TYPE_MAIN:
-            row, is_main = interval.main, True
-        elif stream == STREAM_TYPE_SUB:
-            row, is_main = interval.sub, False
-        elif interval.main is not None:
-            row, is_main = interval.main, True
-        else:
-            row, is_main = interval.sub, False
-        if row is None:
-            continue
-        if spans and spans[-1][0] == row:
-            spans[-1][2] = interval.end_time
-        else:
-            start = interval.start_time
-            # adjacent same-stream rows routinely overlap; trimming the
-            # previous span's end is free, where starting this span
-            # mid-file would cost a clipFrom keyframe snap. Inclusive on
-            # the span end, since sub-MIN_INTERVAL_S overlaps are dropped
-            # by the resolver and leave the previous span ending a hair
-            # past this row's start
-            if (
-                spans
-                and is_main == last_is_main
-                and spans[-1][1] < row.start_time <= spans[-1][2]
-            ):
-                spans[-1][2] = row.start_time
-                start = row.start_time
-            spans.append([row, start, interval.end_time, is_main])
-        last_is_main = is_main
-    return spans
-
-
-def _keyframe_before(keyframes: Any, offset_ms: int) -> int | None:
-    """Last stored keyframe offset at or before offset_ms.
-
-    keyframes is the row's record-time keyframe index (ms from segment
-    start). Returns None when the row has no usable index, which callers
-    treat as "serve the whole file".
-    """
-    if not keyframes:
-        return None
-
-    candidates = [k for k in keyframes if k <= offset_ms]
-    return max(candidates) if candidates else None
-
-
-@dataclass
-class ClipPlan:
-    """The exact playlist realization of one span.
-
-    clip_from_ms is the keyframe-snapped clipFrom, or None when the whole
-    file is served. skipped means the clip is omitted from the manifest.
-    """
-
-    clip_from_ms: int | None
-    duration_ms: int
-    skipped: bool
-
-
-def plan_clip(row: Any, start: float, end: float) -> ClipPlan:
-    """Plan one nginx-vod clip for a recording row trimmed to [start, end).
-
-    The single source of truth for clip realization: the vod mapping
-    builder emits exactly this plan and the coverage timelines report it
-    to the frontend, so the playhead model matches the playlist by
-    construction rather than accumulating drift at each hand-off.
-    """
-    min_duration_ms = 100  # Minimum 100ms to ensure at least one video frame
-    max_duration_ms = MAX_SEGMENT_DURATION * 1000
-
-    clip_from: int | None = None
-    duration = int(row.duration * 1000)
-
-    # adjust start offset if start is after the recording start
-    inpoint = int((start - row.start_time) * 1000) if start > row.start_time else 0
-    if inpoint > 0:
-        clip_from = inpoint
-        duration -= inpoint
-
-    # adjust end if the recording ends after the requested end
-    if row.end_time > end:
-        duration -= int((row.end_time - end) * 1000)
-
-    # nginx-vod-module pushes clipFrom forward to the next keyframe,
-    # which can leave too few frames for a playable segment; snapping
-    # back to the preceding keyframe always starts on a decodable frame
-    if clip_from is not None:
-        keyframe_ms = _keyframe_before(row.keyframes, clip_from)
-        if keyframe_ms is not None:
-            gained = clip_from - keyframe_ms
-            clip_from = keyframe_ms
-            duration += gained
-            logger.debug(
-                "VOD: snapped clipFrom to keyframe at %sms for %s, duration now %sms",
-                keyframe_ms,
-                row.path,
-                duration,
-            )
-        else:
-            logger.debug(
-                "VOD: no keyframe index for %s, removing clipFrom to use full recording",
-                row.path,
-            )
-            clip_from = None
-            duration = int(row.duration * 1000)
-            if row.end_time > end:
-                duration -= int((row.end_time - end) * 1000)
-
-    if duration < min_duration_ms:
-        logger.debug(
-            "VOD: skipping recording %s - resulting duration %sms too short",
-            row.path,
-            duration,
-        )
-        return ClipPlan(None, 0, True)
-
-    if duration >= max_duration_ms:
-        logger.warning(f"Recording clip is missing or empty: {row.path}")
-        return ClipPlan(None, 0, True)
-
-    return ClipPlan(clip_from, duration, False)
-
-
-def realized_timeline(
-    intervals: list[CoverageInterval], stream: str | None
-) -> list[dict[str, Any]]:
-    """The exact playlist timeline a vod route will realize for a range.
-
-    Each item pairs a span's wall-clock bounds with the duration (ms) of
-    the manifest clip serving it, including keyframe back-snap lead-in,
-    so summing durations reproduces playlist time exactly. A span whose
-    clip is skipped reports duration 0.
-    """
-    return [
-        {
-            "start_time": span_start,
-            "end_time": span_end,
-            "duration": plan.duration_ms,
-        }
-        for row, span_start, span_end, _ in build_spans(intervals, stream)
-        for plan in (plan_clip(row, span_start, span_end),)
-    ]
-
-
-def realized_timelines(
-    intervals: list[CoverageInterval],
-) -> dict[str, list[dict[str, Any]]]:
-    """All three variant timelines for a coverage window.
-
-    Applies the same glitch-nulling as the manifest builder, then
-    assembles each variant's realized spans. Keyframe snapping reads the
-    per-row index stored at record time, so no file is touched.
-    """
-    main_audio = stream_has_audio(intervals, main=True)
-    sub_audio = stream_has_audio(intervals, main=False)
-    nulled = null_audio_glitches(intervals, main_audio, sub_audio)
-
-    return {
-        "auto": realized_timeline(nulled, None),
-        "main": realized_timeline(nulled, STREAM_TYPE_MAIN),
-        "sub": realized_timeline(nulled, STREAM_TYPE_SUB),
-    }

frigate/util/services.py

@@ -1,8 +1,6 @@
 """Utilities for services."""
 
 import asyncio
-import contextlib
-import glob
 import json
 import logging
 import os
@@ -672,33 +670,19 @@ def get_intel_gpu_stats(
 
 def get_openvino_npu_stats() -> dict[str, str] | None:
     """Get NPU stats using openvino."""
-    for accel_path in sorted(glob.glob("/sys/class/accel/accel*")):
+    NPU_RUNTIME_PATH = "/sys/devices/pci0000:00/0000:00:0b.0/power/runtime_active_time"
-        try:
-            driver = os.path.basename(os.readlink(f"{accel_path}/device/driver"))
-        except OSError:
-            continue
-
-        if driver != "intel_vpu":
-            continue
-
-        try:
-            runtime_path = f"{accel_path}/device/power/runtime_active_time"
-            with open(runtime_path) as f:
-                initial_runtime = float(f.read().strip())
-            break
-        except (FileNotFoundError, PermissionError, ValueError):
-            continue
-    else:
-        return None
 
     try:
+        with open(NPU_RUNTIME_PATH) as f:
+            initial_runtime = float(f.read().strip())
+
         initial_time = time.time()
 
         # Sleep for 1 second to get an accurate reading
         time.sleep(1.0)
 
         # Read runtime value again
-        with open(runtime_path) as f:
+        with open(NPU_RUNTIME_PATH) as f:
             current_runtime = float(f.read().strip())
 
         current_time = time.time()
@@ -1257,22 +1241,8 @@ async def get_video_properties(
     async def probe_with_ffprobe(
         url: str,
         rtsp_transport: str | None = None,
-    ) -> tuple[
+    ) -> tuple[bool, int, int, str | None, float]:
-        bool,
+        """Fallback using ffprobe: returns (valid, width, height, codec, duration)."""
-        int,
-        int,
-        str | None,
-        str | None,
-        float,
-        bool | None,
-        int | None,
-        str | None,
-    ]:
-        """Probe using ffprobe: returns (valid, width, height, fourcc, video_codec, duration, has_audio, audio_rate, audio_codec).
-
-        ffprobe reports the codec name directly, so fourcc and
-        video_codec are the same value on this path.
-        """
         cmd = [ffmpeg.ffprobe_path]
         if rtsp_transport:
             cmd += ["-rtsp_transport", rtsp_transport]
@@ -1300,17 +1270,19 @@ async def get_video_properties(
                     clean_camera_user_pass(url),
                     rtsp_transport or "default",
                 )
-                return False, 0, 0, None, None, -1, None, None, None
+                proc.kill()
+                await proc.wait()
+                return False, 0, 0, None, -1
 
             if proc.returncode != 0:
-                return False, 0, 0, None, None, -1, None, None, None
+                return False, 0, 0, None, -1
 
             data = json.loads(stdout.decode())
             video_streams = [
                 s for s in data.get("streams", []) if s.get("codec_type") == "video"
             ]
             if not video_streams:
-                return False, 0, 0, None, None, -1, None, None, None
+                return False, 0, 0, None, -1
 
             v = video_streams[0]
             width = int(v.get("width", 0))
@@ -1320,70 +1292,16 @@ async def get_video_properties(
             duration_str = data.get("format", {}).get("duration")
             duration = float(duration_str) if duration_str else -1.0
 
-            audio_streams = [
+            return True, width, height, codec, duration
-                s for s in data.get("streams", []) if s.get("codec_type") == "audio"
-            ]
-            has_audio = bool(audio_streams)
-
-            # codec and sample rate distinguish audio tracks whose decoder
-            # configs cannot share an HLS sequence
-            audio_rate: int | None = None
-            audio_codec: str | None = None
-            if audio_streams:
-                try:
-                    audio_rate = int(audio_streams[0]["sample_rate"])
-                except (KeyError, TypeError, ValueError):
-                    audio_rate = None
-                audio_codec = audio_streams[0].get("codec_name")
-
-            return (
-                True,
-                width,
-                height,
-                codec,
-                codec,
-                duration,
-                has_audio,
-                audio_rate,
-                audio_codec,
-            )
         except (json.JSONDecodeError, ValueError, KeyError, sp.SubprocessError):
-            return False, 0, 0, None, None, -1, None, None, None
+            return False, 0, 0, None, -1
-        finally:
-            # callers run in a per-cycle event loop, and an ffprobe still
-            # running when that loop closes is finalized against a dead loop
-            # ("Event loop is closed"). Draining after the kill is what
-            # closes the pipes and their transports
-            if proc is not None and proc.returncode is None:
-                with contextlib.suppress(ProcessLookupError):
-                    proc.kill()
 
-                with contextlib.suppress(TimeoutError):
+    def probe_with_cv2(url: str) -> tuple[bool, int, int, str | None, float]:
-                    await asyncio.wait_for(proc.communicate(), timeout=2)
+        """Primary attempt using cv2: returns (valid, width, height, fourcc, duration)."""
-
-    def probe_with_cv2(
-        url: str,
-    ) -> tuple[
-        bool,
-        int,
-        int,
-        str | None,
-        str | None,
-        float,
-        bool | None,
-        int | None,
-        str | None,
-    ]:
-        """Probe using cv2: returns (valid, width, height, fourcc, video_codec, duration, has_audio, audio_rate, audio_codec).
-
-        cv2 cannot report audio streams or a normalized codec name, so
-        has_audio, audio_rate, audio_codec, and video_codec are always
-        None (unknown) on this path.
-        """
         cap = cv2.VideoCapture(url)
         if not cap.isOpened():
             cap.release()
-            return False, 0, 0, None, None, -1, None, None, None
+            return False, 0, 0, None, -1
 
         width = int(cap.get(cv2.CAP_PROP_FRAME_WIDTH))
         height = int(cap.get(cv2.CAP_PROP_FRAME_HEIGHT))
@@ -1402,7 +1320,7 @@ async def get_video_properties(
                     duration = total_frames / fps
 
         cap.release()
-        return valid, width, height, fourcc, None, duration, None, None, None
+        return valid, width, height, fourcc, duration
 
     is_rtsp = url.startswith("rtsp://")
 
@@ -1410,99 +1328,24 @@ async def get_video_properties(
         # skip cv2 for RTSP: its FFmpeg backend has a hardcoded ~30s internal
         # timeout that cannot be shortened per-call, and ffprobe bounded by
         # -rw_timeout handles RTSP probing reliably
-        (
+        has_video, width, height, fourcc, duration = await probe_with_ffprobe(url)
-            has_video,
-            width,
-            height,
-            fourcc,
-            video_codec,
-            duration,
-            has_audio,
-            audio_rate,
-            audio_codec,
-        ) = await probe_with_ffprobe(url)
-    elif get_duration:
-        # ffprobe first: segment validation also needs audio presence,
-        # which cv2 cannot report
-        (
-            has_video,
-            width,
-            height,
-            fourcc,
-            video_codec,
-            duration,
-            has_audio,
-            audio_rate,
-            audio_codec,
-        ) = await probe_with_ffprobe(url)
-
-        # fallback to cv2 if needed; audio stays unknown there
-        if not has_video or duration < 0:
-            (
-                has_video,
-                width,
-                height,
-                fourcc,
-                video_codec,
-                duration,
-                has_audio,
-                audio_rate,
-                audio_codec,
-            ) = probe_with_cv2(url)
     else:
         # try cv2 first for local files, HTTP, RTMP
-        (
+        has_video, width, height, fourcc, duration = probe_with_cv2(url)
-            has_video,
-            width,
-            height,
-            fourcc,
-            video_codec,
-            duration,
-            has_audio,
-            audio_rate,
-            audio_codec,
-        ) = probe_with_cv2(url)
 
         # fallback to ffprobe if needed
-        if not has_video:
+        if not has_video or (get_duration and duration < 0):
-            (
+            has_video, width, height, fourcc, duration = await probe_with_ffprobe(url)
-                has_video,
-                width,
-                height,
-                fourcc,
-                video_codec,
-                duration,
-                has_audio,
-                audio_rate,
-                audio_codec,
-            ) = await probe_with_ffprobe(url)
 
     # last resort for RTSP: try TCP transport, since default UDP may be blocked
     if (not has_video or (get_duration and duration < 0)) and is_rtsp:
-        (
+        has_video, width, height, fourcc, duration = await probe_with_ffprobe(
-            has_video,
+            url, rtsp_transport="tcp"
-            width,
+        )
-            height,
-            fourcc,
-            video_codec,
-            duration,
-            has_audio,
-            audio_rate,
-            audio_codec,
-        ) = await probe_with_ffprobe(url, rtsp_transport="tcp")
 
     result: dict[str, Any] = {"has_valid_video": has_video}
     if has_video:
-        result.update(
+        result.update({"width": width, "height": height})
-            {
-                "width": width,
-                "height": height,
-                "has_audio": has_audio,
-                "audio_rate": audio_rate,
-                "audio_codec": audio_codec,
-                "video_codec": video_codec,
-            }
-        )
         if fourcc:
             result["fourcc"] = fourcc
     if get_duration:

frigate/video/ffmpeg.py

@@ -54,48 +54,59 @@ def capture_frames(
     skipped_eps = EventsPerSecond()
     skipped_eps.start()
 
-    while not stop_event.is_set():
+    config_subscriber = CameraConfigUpdateSubscriber(
-        # CameraWatchdog applies enabled updates onto this same CameraConfig
+        None, {config.name: config}, [CameraConfigUpdateEnum.enabled]
-        # before it stops ffmpeg. Do not subscribe here: it would be rebuilt per
+    )
-        # ffmpeg restart and strand a pipe in the idle main process config PUB.
-        if not config.enabled:
-            logger.debug(f"Stopping capture thread for disabled {config.name}")
-            break
 
-        fps.value = frame_rate.eps()
+    def get_enabled_state():
-        skipped_fps.value = skipped_eps.eps()
+        """Fetch the latest enabled state from ZMQ."""
-        current_frame.value = datetime.now().timestamp()
+        config_subscriber.check_for_updates()
-        frame_name = f"{config.name}_frame{frame_index}"
+        return config.enabled
-        frame_buffer = frame_manager.write(frame_name)
+
-        try:
+    try:
-            frame_buffer[:] = ffmpeg_process.stdout.read(frame_size)
+        while not stop_event.is_set():
-        except Exception:
+            if not get_enabled_state():
-            # shutdown has been initiated
+                logger.debug(f"Stopping capture thread for disabled {config.name}")
-            if stop_event.is_set():
                 break
 
-            logger.error(f"{config.name}: Unable to read frames from ffmpeg process.")
+            fps.value = frame_rate.eps()
+            skipped_fps.value = skipped_eps.eps()
+            current_frame.value = datetime.now().timestamp()
+            frame_name = f"{config.name}_frame{frame_index}"
+            frame_buffer = frame_manager.write(frame_name)
+            try:
+                frame_buffer[:] = ffmpeg_process.stdout.read(frame_size)
+            except Exception:
+                # shutdown has been initiated
+                if stop_event.is_set():
+                    break
 
-            if ffmpeg_process.poll() is not None:
                 logger.error(
-                    f"{config.name}: ffmpeg process is not running. exiting capture thread..."
+                    f"{config.name}: Unable to read frames from ffmpeg process."
                 )
-                break
 
-            continue
+                if ffmpeg_process.poll() is not None:
+                    logger.error(
+                        f"{config.name}: ffmpeg process is not running. exiting capture thread..."
+                    )
+                    break
 
-        frame_rate.update()
+                continue
 
-        # don't lock the queue to check, just try since it should rarely be full
+            frame_rate.update()
-        try:
-            # add to the queue
-            frame_queue.put((frame_name, current_frame.value), False)
-            frame_manager.close(frame_name)
-        except queue.Full:
-            # if the queue is full, skip this frame
-            skipped_eps.update()
 
-        frame_index = 0 if frame_index == shm_frame_count - 1 else frame_index + 1
+            # don't lock the queue to check, just try since it should rarely be full
+            try:
+                # add to the queue
+                frame_queue.put((frame_name, current_frame.value), False)
+                frame_manager.close(frame_name)
+            except queue.Full:
+                # if the queue is full, skip this frame
+                skipped_eps.update()
+
+            frame_index = 0 if frame_index == shm_frame_count - 1 else frame_index + 1
+    finally:
+        config_subscriber.stop()
 
 
 class CameraWatchdog(threading.Thread):
@@ -147,7 +158,6 @@ class CameraWatchdog(threading.Thread):
         self.requestor = InterProcessRequestor()
         self.was_enabled = self.config.enabled
         self.was_record_enabled_in_config = self.config.record.enabled_in_config
-        self.was_record_sub_enabled = self.config.record.sub.enabled
 
         self.segment_subscriber = RecordingsDataSubscriber(RecordingsDataTypeEnum.all)
         self.latest_valid_segment_time: float = 0
@@ -313,24 +323,6 @@ class CameraWatchdog(threading.Thread):
                 self.was_record_enabled_in_config = record_enabled_in_config
                 continue
 
-            record_sub_enabled = self.config.record.sub.enabled
-            if record_sub_enabled != self.was_record_sub_enabled:
-                # adding and removing the record_sub output both require a
-                # restart, unlike the main record toggle
-                if record_enabled_in_config and enabled:
-                    self.logger.debug(
-                        f"Sub stream recording toggled in config for {self.config.name}, restarting ffmpeg"
-                    )
-                    self.stop_all_ffmpeg()
-                    self.start_all_ffmpeg()
-                    self.latest_valid_segment_time = 0
-                    self.latest_invalid_segment_time = 0
-                    self.latest_cache_segment_time = 0
-                    self.record_enable_time = datetime.now().astimezone(UTC)
-                    last_restart_time = datetime.now().timestamp()
-                self.was_record_sub_enabled = record_sub_enabled
-                continue
-
             if not enabled:
                 continue
 

generate_api_auth_spec.py

@@ -94,6 +94,7 @@ SPEC_SERVERS = [
 PUBLIC = "public"
 AUTHENTICATED = "any"
 CAMERA = "camera"
+ALL_CAMERAS = "all_cameras"
 ADMIN = "admin"
 
 ADMIN_SCHEME = "frigateAdminAuth"
@@ -128,6 +129,7 @@ ACCESS_NOTES = {
     PUBLIC: "**Access:** Public — no authentication required.",
     AUTHENTICATED: "**Access:** Any authenticated user.",
     CAMERA: "**Access:** Authenticated user with access to the referenced camera.",
+    ALL_CAMERAS: "**Access:** Authenticated user with access to all cameras.",
     ADMIN: "**Access:** Admin role required.",
 }
 
@@ -197,6 +199,8 @@ def _route_markers(route: APIRoute) -> tuple[set[str], list[str] | None]:
                 pass
         elif name in ("require_camera_access", "require_go2rtc_stream_access"):
             markers.add(CAMERA)
+        elif name == "require_full_camera_access":
+            markers.add(ALL_CAMERAS)
         elif "auth_checker" in qualname:
             markers.add(AUTHENTICATED)
         elif "public_checker" in qualname:
@@ -254,6 +258,8 @@ def _classify_base(
     # Explicit route-level markers win, in order of specificity.
     if ADMIN in markers:
         return ADMIN, admin_roles or ["admin"], None
+    if ALL_CAMERAS in markers:
+        return ALL_CAMERAS, None, None
     if CAMERA in markers:
         return CAMERA, None, None
     if AUTHENTICATED in markers:
@@ -337,8 +343,8 @@ def security_for(level: str) -> list:
         return []
     if level == ADMIN:
         return [{ADMIN_SCHEME: []}]
-    # AUTHENTICATED and CAMERA both require any authenticated session; the
+    # AUTHENTICATED, CAMERA and ALL_CAMERAS all require any authenticated
-    # camera-specific scoping is conveyed in the note and x-required-role.
+    # session; the camera scoping is conveyed in the note and x-required-role.
     return [{USER_SCHEME: []}]
 
 

migrations/036_add_recordings_stream_metadata.py

@@ -1,49 +0,0 @@
-"""Peewee migrations -- 036_add_recordings_stream_metadata.py.
-
-Some examples (model - class or model name)::
-
-    > Model = migrator.orm['model_name']            # Return model in current state by name
-
-    > migrator.sql(sql)                             # Run custom SQL
-    > migrator.python(func, *args, **kwargs)        # Run python code
-    > migrator.create_model(Model)                  # Create a model (could be used as decorator)
-    > migrator.remove_model(model, cascade=True)    # Remove a model
-    > migrator.add_fields(model, **fields)          # Add fields to a model
-    > migrator.change_fields(model, **fields)       # Change fields
-    > migrator.remove_fields(model, *field_names, cascade=True)
-    > migrator.rename_field(model, old_field_name, new_field_name)
-    > migrator.rename_table(model, new_table_name)
-    > migrator.add_index(model, *col_names, unique=False)
-    > migrator.drop_index(model, *col_names)
-    > migrator.add_not_null(model, *field_names)
-    > migrator.drop_not_null(model, *field_names)
-    > migrator.add_default(model, field_name, default)
-
-"""
-
-import peewee as pw
-
-SQL = pw.SQL
-
-
-def migrate(migrator, database, fake=False, **kwargs):
-    migrator.sql(
-        'ALTER TABLE "recordings" ADD COLUMN "stream_type" VARCHAR(8) NOT NULL DEFAULT \'main\''
-    )
-    migrator.sql(
-        'CREATE INDEX IF NOT EXISTS "recordings_camera_stream_type" ON "recordings" ("camera", "stream_type")'
-    )
-
-    # nullable so legacy rows stay NULL, meaning unknown
-    migrator.sql('ALTER TABLE "recordings" ADD COLUMN "has_audio" INTEGER')
-    migrator.sql('ALTER TABLE "recordings" ADD COLUMN "audio_rate" INTEGER')
-    migrator.sql('ALTER TABLE "recordings" ADD COLUMN "audio_codec" TEXT')
-    migrator.sql('ALTER TABLE "recordings" ADD COLUMN "video_codec" TEXT')
-
-    # keyframe offsets in ms from segment start; nullable so legacy rows
-    # stay NULL and playback serves whole files for them
-    migrator.sql('ALTER TABLE "recordings" ADD COLUMN "keyframes" TEXT')
-
-
-def rollback(migrator, database, fake=False, **kwargs):
-    pass

web/e2e/specs/export.spec.ts

@@ -867,31 +867,6 @@ test.describe("Multi-Camera Export from History @high", () => {
     await frigateApp.page.route("**/api/recordings/unavailable**", (route) =>
       route.fulfill({ json: [] }),
     );
-    // registered after the broad recordings route so it wins the match;
-    // coverage is an object, and the array above crashes the player
-    await frigateApp.page.route("**/api/*/recordings/coverage**", (route) =>
-      route.fulfill({
-        json: {
-          spans: [
-            {
-              start_time: playbackTime - 3600,
-              end_time: playbackTime + 600,
-              streams: ["main"],
-            },
-          ],
-          codecs_compatible: true,
-          streams: {
-            main: {
-              video_codec: "h264",
-              audio_rate: null,
-              audio_codec: null,
-              has_audio: false,
-              bitrate: 2_000_000,
-            },
-          },
-        },
-      }),
-    );
 
     await frigateApp.goto(`/review?timestamp=front_door_${playbackTime}`);
   }

web/e2e/specs/settings/camera-wizard-ptz.spec.ts

@@ -1,187 +0,0 @@
-/**
- * Add-camera wizard — PTZ controls pane.
- *
- * The pane lives on Step 3 (Stream Configuration) and only appears when the
- * ONVIF probe from Step 2 reported `ptz_supported`. These tests drive the
- * wizard to Step 3 with a mocked probe and assert the pane's contract:
- *   1. Visible + enabled when the probe reports PTZ, with the connection
- *      fields collapsed by default and pre-filled once expanded.
- *   2. Toggling the switch off hides the disclosure and its fields.
- *   3. Clearing the host shows the validation warning and blocks "Next".
- *   4. Absent entirely when the probe reports no PTZ support.
- *
- * The save path (writing the `onvif` section to config/set) runs through
- * Step 4's live-validation flow, which registers go2rtc streams and renders
- * MSE previews that are unreliable in headless Chromium. Consistent with
- * clone-camera.spec.ts, that assertion is deferred to manual QA; the logic is
- * covered by the Step 4 -> parent handleSave wiring.
- */
-
-import { test, expect } from "../../fixtures/frigate-test";
-import type { Page, Locator } from "@playwright/test";
-
-const PTZ_PROBE = {
-  success: true,
-  host: "192.168.1.100",
-  port: 80,
-  manufacturer: "Acme",
-  model: "PTZ-1",
-  firmware_version: "1.0",
-  profiles_count: 1,
-  ptz_supported: true,
-  pan_tilt_supported: true,
-  presets_count: 2,
-  autotrack_supported: false,
-  rtsp_candidates: [
-    {
-      source: "GetStreamUri",
-      profile_token: "profile_1",
-      uri: "rtsp://admin:pw@192.168.1.100:554/stream1",
-    },
-  ],
-};
-
-async function mockProbe(page: Page, probe: object) {
-  await page.route("**/api/onvif/probe**", (route) =>
-    route.fulfill({ json: probe }),
-  );
-}
-
-/** Open the wizard and drive Step 1 -> Step 2 -> Step 3. */
-async function gotoStep3(page: Page, host = "192.168.1.100") {
-  await page.getByRole("button", { name: /Add New Camera/i }).click();
-  const dialog = page.getByRole("dialog");
-  await expect(dialog).toBeVisible();
-
-  // Step 1: name + host (probe mode is the default), then Continue.
-  await dialog.getByPlaceholder(/front_door/i).fill("ptz_test_camera");
-  await dialog.getByPlaceholder("192.168.1.100").fill(host);
-  await dialog.getByRole("button", { name: /^Continue$/i }).click();
-
-  // Step 2: the probe auto-runs on mount; once candidates exist, Next enables.
-  const next = dialog.getByRole("button", { name: /^Next$/i });
-  await expect(next).toBeEnabled({ timeout: 10_000 });
-  await next.click();
-
-  // Step 3 is the stream-configuration step; key off a stable control rather
-  // than the description text (which has been reworded).
-  await expect(
-    dialog.getByRole("button", { name: /Add Another Stream/i }),
-  ).toBeVisible();
-  return dialog;
-}
-
-/** The PTZ enable switch (scoped to the PTZ card header row). */
-function ptzSwitch(dialog: Locator) {
-  return dialog
-    .locator("div.justify-between", { hasText: "Enable PTZ Controls" })
-    .getByRole("switch");
-}
-
-/** Expand the (collapsed-by-default) ONVIF connection-detail fields. */
-async function expandOnvifDetails(dialog: Locator) {
-  await dialog
-    .getByRole("button", { name: /ONVIF connection details/i })
-    .click();
-}
-
-test.describe("Camera wizard PTZ pane @medium @mobile", () => {
-  test.beforeEach(async ({ frigateApp }) => {
-    // not in the default mock; unmocked it 500s and trips the error collector
-    await frigateApp.page.route("**/api/config/raw_paths", (route) =>
-      route.fulfill({ json: {} }),
-    );
-    await frigateApp.goto("/settings?page=cameraManagement");
-    await expect(
-      frigateApp.page.getByRole("heading", { name: /Manage Cameras/i }),
-    ).toBeVisible();
-  });
-
-  test("shows an enabled PTZ pane with collapsed, pre-filled fields", async ({
-    frigateApp,
-  }) => {
-    await mockProbe(frigateApp.page, PTZ_PROBE);
-    const dialog = await gotoStep3(frigateApp.page);
-
-    // Card is present with the detected note and the switch defaults on.
-    await expect(
-      dialog.getByText("Enable PTZ Controls", { exact: true }),
-    ).toBeVisible();
-    await expect(
-      dialog.getByText(/PTZ support has been detected via ONVIF/i),
-    ).toBeVisible();
-    await expect(ptzSwitch(dialog)).toBeChecked();
-
-    // Connection fields are collapsed by default.
-    await expect(dialog.getByPlaceholder("192.168.1.100")).toHaveCount(0);
-
-    // Expanding reveals the host pre-filled from the probe.
-    await expandOnvifDetails(dialog);
-    await expect(dialog.getByPlaceholder("192.168.1.100")).toHaveValue(
-      "192.168.1.100",
-    );
-  });
-
-  test("toggling the switch off hides the disclosure and fields", async ({
-    frigateApp,
-  }) => {
-    await mockProbe(frigateApp.page, PTZ_PROBE);
-    const dialog = await gotoStep3(frigateApp.page);
-
-    await expandOnvifDetails(dialog);
-    await expect(dialog.getByPlaceholder("192.168.1.100")).toBeVisible();
-
-    await ptzSwitch(dialog).click();
-
-    await expect(dialog.getByPlaceholder("192.168.1.100")).toHaveCount(0);
-    await expect(
-      dialog.getByRole("button", { name: /ONVIF connection details/i }),
-    ).toHaveCount(0);
-  });
-
-  test("clearing the host shows the warning and blocks Next", async ({
-    frigateApp,
-  }) => {
-    await mockProbe(frigateApp.page, PTZ_PROBE);
-    const dialog = await gotoStep3(frigateApp.page);
-
-    await expandOnvifDetails(dialog);
-    await dialog.getByPlaceholder("192.168.1.100").fill("");
-
-    await expect(
-      dialog.getByText(/An ONVIF host and port are required/i),
-    ).toBeVisible();
-    await expect(
-      dialog.getByRole("button", { name: /^Next$/i }),
-    ).toBeDisabled();
-  });
-
-  test("shows the pane but leaves the switch off without continuous pan/tilt", async ({
-    frigateApp,
-  }) => {
-    // e.g. a varifocal camera: PTZ service present, but zoom/focus only
-    await mockProbe(frigateApp.page, {
-      ...PTZ_PROBE,
-      pan_tilt_supported: false,
-    });
-    const dialog = await gotoStep3(frigateApp.page);
-
-    await expect(
-      dialog.getByText("Enable PTZ Controls", { exact: true }),
-    ).toBeVisible();
-    await expect(ptzSwitch(dialog)).not.toBeChecked();
-    // with the switch off, the connection fields are not shown
-    await expect(dialog.getByPlaceholder("192.168.1.100")).toHaveCount(0);
-  });
-
-  test("hides the PTZ pane when the probe reports no PTZ support", async ({
-    frigateApp,
-  }) => {
-    await mockProbe(frigateApp.page, { ...PTZ_PROBE, ptz_supported: false });
-    const dialog = await gotoStep3(frigateApp.page);
-
-    await expect(
-      dialog.getByText("Enable PTZ Controls", { exact: true }),
-    ).toHaveCount(0);
-  });
-});

web/public/locales/ar/audio.json

@@ -38,7 +38,7 @@
   "cough": "سُعَال",
   "throat_clearing": "تَنْحِيم",
   "sneeze": "عُطَاس",
-  "sniff": "شَمَّ",
+  "sniff": "كشف",
   "run": "رَكْض",
   "shuffle": "خَلْط",
   "footsteps": "خُطُوَات",
@@ -161,5 +161,43 @@
   "rumble": "الحلبة",
   "skateboard": "لوح تزلج",
   "echo": "صدى الصوت",
-  "noise": "ازعاج"
+  "noise": "ازعاج",
+  "duck": "بطة",
+  "quack": "صوت البطة",
+  "goose": "وزة",
+  "honk": "نعيق الأوز",
+  "wild_animals": "حيوانات برية",
+  "roar": "زئير",
+  "chirp": "زقزقة",
+  "pigeon": "حمامة",
+  "crow": "غراب",
+  "roaring_cats": "قطط هائجة",
+  "squawk": "نعيق",
+  "coo": "هديل الحمام",
+  "mallet_percussion": "مطرقة إيقاعية",
+  "marimba": "ماريمبا",
+  "glockenspiel": "معزف الأجراس",
+  "vibraphone": "فيبرافون",
+  "steelpan": "طبل نحاسي",
+  "orchestra": "أوركسترا",
+  "brass_instrument": "آلة نحاسية",
+  "french_horn": "بوق فرنسي",
+  "trumpet": "بوق",
+  "trombone": "ترومبون",
+  "bowed_string_instrument": "آلة وترية مقوسة",
+  "string_section": "آلات وترية",
+  "violin": "كمان",
+  "pizzicato": "تقنية العزف بيزيكاتو",
+  "cello": "تشيلو",
+  "double_bass": "كمان كبير",
+  "wind_instrument": "آلة نفخية",
+  "flute": "فلوت",
+  "saxophone": "ساكسفون",
+  "clarinet": "كلارينيت",
+  "harp": "قيثارة",
+  "bell": "جرس",
+  "church_bell": "جرس الكنيسة",
+  "jingle_bell": "جرس جلجل",
+  "bicycle_bell": "جرس الدراجة",
+  "tuning_fork": "شوكة رنانة"
 }

web/public/locales/ca/components/dialog.json

@@ -71,9 +71,9 @@
       "batchSuccess_other": "S'han iniciat {{count}} exportacions. Obrint el cas ara.",
       "batchPartial": "S'han iniciat {{successful}} de {{total}} exportacions. Càmeres fallides: {{failedCameras}}",
       "batchFailed": "No s'han pogut iniciar {{total}} exportacions. Càmeres fallides: {{failedCameras}}",
-      "batchQueuedSuccess_one": "Exporta a la cua 1. Obrint el cas ara.",
+      "batchQueuedSuccess_one": "Exporta a la cua 1.",
-      "batchQueuedSuccess_many": "{{count}} exportacions a la cua. Obrint el cas ara.",
+      "batchQueuedSuccess_many": "{{count}} exportacions a la cua.",
-      "batchQueuedSuccess_other": "{{count}} exportacions a la cua. Obrint el cas ara.",
+      "batchQueuedSuccess_other": "{{count}} exportacions a la cua.",
       "batchQueuedPartial": "{{successful}} de {{total}} exportacions a la cua. Càmeres fallides: {{failedCameras}}",
       "batchQueueFailed": "No s'han pogut posar a la cua {{total}} exportacions. Càmeres fallides: {{failedCameras}}"
     },
@@ -132,9 +132,9 @@
       "exportButton_other": "Exporta {{count}} ressenyes",
       "exportingButton": "S'està exportant...",
       "toast": {
-        "started_one": "S'ha iniciat l'exportació 1. Obrint el cas ara.",
+        "started_one": "S'ha iniciat l'exportació 1.",
-        "started_many": "S'han iniciat {{count}} exportacions. Obrint el cas ara.",
+        "started_many": "S'han iniciat {{count}} exportacions.",
-        "started_other": "S'han iniciat {{count}} exportacions. Obrint el cas ara.",
+        "started_other": "S'han iniciat {{count}} exportacions.",
         "startedNoCase_one": "S'ha iniciat l'exportació 1.",
         "startedNoCase_many": "S'han iniciat {{count}} exportacions.",
         "startedNoCase_other": "S'han iniciat {{count}} exportacions.",

web/public/locales/ca/views/replay.json

@@ -52,7 +52,8 @@
             "error": "No s'ha pogut iniciar la repetició de depuració: {{error}}",
             "alreadyActive": "Ja hi ha activada una sessió de reproducció",
             "stopError": "No s'ha pogut aturar la repetició de depuració: {{error}}",
-            "goToReplay": "Ves a la repetició"
+            "goToReplay": "Ves a la repetició",
+            "noRecordings": "No s'ha trobat cap enregistrament a l'interval de temps seleccionat"
         }
     },
     "description": "Reprodueix els enregistraments de la càmera per a la depuració. La llista d'objectes mostra un resum retardat en el temps dels objectes detectats i la pestanya Missatges mostra un flux de missatges interns de frigate a partir del metratge de reproducció."

web/public/locales/da/audio.json

@@ -265,7 +265,7 @@
   "rhythm_and_blues": "Rhythm and Blues",
   "soul_music": "Soulmusik",
   "reggae": "Reggae",
-  "country": "Country",
+  "country": "Land",
   "disco": "Disko",
   "classical_music": "Klassisk musik",
   "electronic_music": "Elektronisk musik",
@@ -341,5 +341,7 @@
   "propeller": "Probel",
   "fixed-wing_aircraft": "Fastvingefly",
   "engine": "Motor",
-  "light_engine": "Lille motor"
+  "light_engine": "Lille motor",
+  "swing_music": "Swing musik",
+  "bluegrass": "Bluegrass"
 }

web/public/locales/da/config/global.json

@@ -1 +1,7 @@
-{}
+{
+    "camera_ui": {
+        "review": {
+            "label": "Vis i gennemgang"
+        }
+    }
+}

web/public/locales/da/views/classificationModel.json

@@ -170,7 +170,10 @@
     "title": "Rediger kategoriseringsmodel",
     "descriptionState": "Rediger kategorierne for denne model til genstandstilstande. Ændringer kræver, at modellen trænes igen.",
     "descriptionObject": "Rediger genstandstypen og kategoriseringstypen for denne genstandskategoriseringsmodel.",
-    "stateClassesInfo": "Bemærk: Ændring af tilstandskategorier kræver, at modellen trænes igen med de opdaterede kategorier."
+    "stateClassesInfo": "Bemærk: Ændring af tilstandskategorier kræver, at modellen trænes igen med de opdaterede kategorier.",
+    "enabled": "Aktiveret",
+    "enabledDesc": "Kør denne model. Ved deaktivering stopper den med at køre og klassificerer ikke længere",
+    "saveAttempts": "Gem forsøg"
   },
   "deleteDatasetImages": {
     "title": "Slet billeder i datasættet",

web/public/locales/da/views/events.json

@@ -28,5 +28,8 @@
   "detail": {
     "aria": "Skift til detaljevisning"
   },
-  "timeline.aria": "Vælg tidslinje"
+  "timeline.aria": "Vælg tidslinje",
+  "motionPreviews": {
+    "crop": "Beskær til filter"
+  }
 }

web/public/locales/da/views/motionSearch.json

@@ -1 +1,9 @@
-{}
+{
+    "metrics": {
+        "minutesSeconds": "{{minutes}}m {{seconds}}s",
+        "scanSummary": "{{segments}} segmentee · {{time}}"
+    },
+    "polygonControls": {
+        "moveMode": "Flyt"
+    }
+}

web/public/locales/da/views/settings.json

@@ -16,5 +16,31 @@
   "menu": {
     "ui": "Brugergrænseflade",
     "profiles": "Profiler"
+  },
+  "configMessages": {
+    "model": {
+      "optimizedFor320": "Frigate er optimeret til en 320x320 model, der er det bedste valg for de fleste konfigurationer. En 640x640 model er langsommere og hjælper kun i særlige scenarier"
+    }
+  },
+  "configForm": {
+    "cameraInputs": {
+      "sourceMode": {
+        "manual": "Manuel input sti"
+      }
+    }
+  },
+  "cameraManagement": {
+    "clone": {
+      "footer": {
+        "restartNeeded": "Genstart er nødvendig for visse ændringer.",
+        "liveOnly": "Alle ændringer vil blive aktiveret umiddelbart uden genstart.",
+        "submit": "Klone",
+        "submitting": "Kloner…"
+      },
+      "toast": {
+        "success": "Indstillinger kopieret til {{cameraName}}",
+        "successWithRestart": "Indstillinger kopieret til {{cameraName}}. Genstart Frigate for at aktivere alle ændringer."
+      }
+    }
   }
 }

web/public/locales/de/components/dialog.json

@@ -78,8 +78,8 @@
       "batchSuccess_other": "{{count}} Exports gestartet. Öffne den Fall jetzt.",
       "batchPartial": "{{successful}} von {{total}} Exporten gestartet. Fehlgeschlagene Kameras: {{failedCameras}}",
       "batchFailed": "Fehler beim Starten der {{total}} Exporte. Fehlgeschlagene Kameras: {{failedCameras}}",
-      "batchQueuedSuccess_one": "1 Export in die Warteschlange gestellt. Fall wird jetzt geöffnet.",
+      "batchQueuedSuccess_one": "1 Export in die Warteschlange gestellt.",
-      "batchQueuedSuccess_other": "{{count}} Exporte in der Warteschlange. Fall wird jetzt geöffnet.",
+      "batchQueuedSuccess_other": "{{count}} Exporte in der Warteschlange.",
       "batchQueuedPartial": "{{successful}} von {{total}} Exporten in die Warteschlange gestellt. Fehlerhafte Kameras: {{failedCameras}}",
       "batchQueueFailed": "Fehler beim Einreihen von {{total}} Exporten in die Warteschlange. Fehlerhafte Kameras: {{failedCameras}}"
     },
@@ -112,7 +112,7 @@
       "noCameras": "Keine Kameras verfügbar",
       "detectionCount_one": "1 verfolgtes Objekt",
       "detectionCount_other": "{{count}} verfolgte Objekte",
-      "nameLabel": "Exportname",
+      "nameLabel": "Name exportieren",
       "namePlaceholder": "Optionaler Basisname für diese Exporte",
       "queueingButton": "Exporte werden in die Warteschlange gestellt...",
       "exportButton_one": "Export 1 Kamera",
@@ -135,8 +135,8 @@
       "exportButton_other": "{{count}} Bewertung exportieren",
       "exportingButton": "Exportieren...",
       "toast": {
-        "started_one": "1 Export gestartet. Fall wird jetzt geöffnet.",
+        "started_one": "1 Export gestartet.",
-        "started_other": "{{count}} Exporte gestartet. Fall wird jetzt geöffnet.",
+        "started_other": "{{count}} Exporte gestartet.",
         "startedNoCase_one": "1 Export gestartet.",
         "startedNoCase_other": "{{count}} Exports gestartet.",
         "partial": "{{successful}} von {{total}} Exporten gestartet. Fehlgeschlagen: {{failedItems}}",

web/public/locales/de/config/cameras.json

@@ -547,7 +547,7 @@
                 "description": "Maximale Anzahl der gleichzeitig zu verarbeitenden Exportaufträge."
             },
             "chapters": {
-                "label": "Kapitel-Metadaten zur Einbettung in exportierte Aufzeichnungen"
+                "label": "Kapitel-Metadaten, die in exportierte Aufzeichnungen eingebettet werden sollen"
             }
         },
         "preview": {
@@ -772,7 +772,7 @@
         },
         "dashboard": {
             "label": "Im Live-Dashboard anzeigen",
-            "description": "Legt fest, ob diese Kamera im Live-Dashboard ‚Alle Kameras‘ angezeigt wird. Die Kamera bleibt in allen anderen Bereichen der Benutzeroberfläche verfügbar, einschließlich Kamera-Gruppen und Einstellungen."
+            "description": "Legt fest, ob diese Kamera im Standard-Live-Dashboard „Alle Kameras“ angezeigt wird. Die Kamera bleibt in allen anderen Bereichen der Benutzeroberfläche verfügbar, einschließlich Kameragruppen und Einstellungen."
         },
         "review": {
             "label": "In der Überprüfung anzeigen",