Miscellaneous fixes (#24996)
CI / AMD64 Build (push) Canceled after 0s
CI / AMD64 Smoke Test (push) Canceled after 0s
CI / ARM Build (push) Canceled after 0s
CI / Jetson Jetpack 6 (push) Canceled after 0s
CI / AMD64 Extra Build (push) Canceled after 0s
CI / ARM Extra Build (push) Canceled after 0s
CI / Synaptics Build (push) Canceled after 0s
CI / Assemble and push default build (push) Canceled after 0s

* tweak agents file

* add serbian latin

* fix serbian latin components

weblate put them in the wrong directory (sr_Latn). the component style was updated in weblate itself so this shouldn't happen for any future translations

* raise on empty genai embedding response so the maintainer thread survives
This commit is contained in:
Josh Hawkins
2026-11-17 14:25:05 -07:00
committed by GitHub
parent 8a7d89170b
commit 6c09629783
18 changed files with 16 additions and 6 deletions
+7 -6
View File
@@ -6,7 +6,7 @@ This document provides coding guidelines and best practices for contributing to
Frigate NVR is a realtime object detection system for IP cameras that uses:
- **Backend**: Python 3.13+ with FastAPI, OpenCV, TensorFlow/ONNX
- **Backend**: Python 3.11 with FastAPI, OpenCV, TensorFlow/ONNX
- **Frontend**: React with TypeScript, Vite, TailwindCSS
- **Architecture**: Multiprocessing design with ZMQ and MQTT communication
- **Focus**: Minimal resource usage with maximum performance
@@ -23,7 +23,7 @@ When reviewing code, do NOT comment on:
### Python Requirements
- **Compatibility**: Python 3.13+
- **Compatibility**: Python 3.11 (the version in the Docker image)
- **Language Features**: Use modern Python features:
- Pattern matching
- Type hints (comprehensive typing preferred)
@@ -97,11 +97,12 @@ When reviewing code, do NOT comment on:
### Async Programming
- **External I/O**: All external I/O operations must be async
- **Best Practices**:
- Avoid sleeping in loops - use `asyncio.sleep()` not `time.sleep()`
- **Scope**: Frigate is mostly synchronous multiprocess code, and most API handlers are plain `def` running in FastAPI's threadpool. These rules apply to code that is already `async def`.
- **Blocking I/O**: A handler that does blocking work (peewee queries, `requests`, subprocess) should be a plain `def`, not an `async def` that blocks the event loop
- **Best Practices** (inside `async def`):
- Use `asyncio.sleep()`, not `time.sleep()`
- Avoid awaiting in loops - use `asyncio.gather()` instead
- No blocking calls in async functions
- No blocking calls
- Use `asyncio.create_task()` for background operations
- **Thread Safety**: Use proper synchronization for shared state