mirror of
https://github.com/blakeblackshear/frigate.git
synced 2026-11-18 03:23:01 +03:00
Miscellaneous fixes (#24996)
CI / AMD64 Smoke Test (push) Blocked by required conditions
CI / ARM Build (push) Waiting to run
CI / Jetson Jetpack 6 (push) Waiting to run
CI / AMD64 Build (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
CI / AMD64 Smoke Test (push) Blocked by required conditions
CI / ARM Build (push) Waiting to run
CI / Jetson Jetpack 6 (push) Waiting to run
CI / AMD64 Build (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
* tweak agents file * add serbian latin * fix serbian latin components weblate put them in the wrong directory (sr_Latn). the component style was updated in weblate itself so this shouldn't happen for any future translations * raise on empty genai embedding response so the maintainer thread survives
This commit is contained in:
@@ -6,7 +6,7 @@ This document provides coding guidelines and best practices for contributing to
|
||||
|
||||
Frigate NVR is a realtime object detection system for IP cameras that uses:
|
||||
|
||||
- **Backend**: Python 3.13+ with FastAPI, OpenCV, TensorFlow/ONNX
|
||||
- **Backend**: Python 3.11 with FastAPI, OpenCV, TensorFlow/ONNX
|
||||
- **Frontend**: React with TypeScript, Vite, TailwindCSS
|
||||
- **Architecture**: Multiprocessing design with ZMQ and MQTT communication
|
||||
- **Focus**: Minimal resource usage with maximum performance
|
||||
@@ -23,7 +23,7 @@ When reviewing code, do NOT comment on:
|
||||
|
||||
### Python Requirements
|
||||
|
||||
- **Compatibility**: Python 3.13+
|
||||
- **Compatibility**: Python 3.11 (the version in the Docker image)
|
||||
- **Language Features**: Use modern Python features:
|
||||
- Pattern matching
|
||||
- Type hints (comprehensive typing preferred)
|
||||
@@ -97,11 +97,12 @@ When reviewing code, do NOT comment on:
|
||||
|
||||
### Async Programming
|
||||
|
||||
- **External I/O**: All external I/O operations must be async
|
||||
- **Best Practices**:
|
||||
- Avoid sleeping in loops - use `asyncio.sleep()` not `time.sleep()`
|
||||
- **Scope**: Frigate is mostly synchronous multiprocess code, and most API handlers are plain `def` running in FastAPI's threadpool. These rules apply to code that is already `async def`.
|
||||
- **Blocking I/O**: A handler that does blocking work (peewee queries, `requests`, subprocess) should be a plain `def`, not an `async def` that blocks the event loop
|
||||
- **Best Practices** (inside `async def`):
|
||||
- Use `asyncio.sleep()`, not `time.sleep()`
|
||||
- Avoid awaiting in loops - use `asyncio.gather()` instead
|
||||
- No blocking calls in async functions
|
||||
- No blocking calls
|
||||
- Use `asyncio.create_task()` for background operations
|
||||
- **Thread Safety**: Use proper synchronization for shared state
|
||||
|
||||
|
||||
@@ -68,6 +68,10 @@ class GenAIEmbedding:
|
||||
f"Invalid embedding_type '{embedding_type}'. Must be 'text' or 'vision'."
|
||||
)
|
||||
|
||||
# Callers index the result, so an empty provider response must raise
|
||||
if not embeddings:
|
||||
raise ValueError(f"Empty {embedding_type} embedding response from provider")
|
||||
|
||||
result = []
|
||||
for emb in embeddings:
|
||||
arr = np.asarray(emb, dtype=np.float32)
|
||||
|
||||
@@ -216,6 +216,7 @@
|
||||
"hr": "Hrvatski (Croatian)",
|
||||
"bs": "Bosanski (Bosnian)",
|
||||
"sr": "Српски (Serbian)",
|
||||
"srLatn": "Srpski (Serbian, Latin)",
|
||||
"sl": "Slovenščina (Slovenian)",
|
||||
"lt": "Lietuvių (Lithuanian)",
|
||||
"bg": "Български (Bulgarian)",
|
||||
|
||||
@@ -115,6 +115,7 @@ export default function GeneralSettings({
|
||||
"zh-CN": "zhCN",
|
||||
"zh-Hant": "zhHant",
|
||||
"pt-BR": "ptBR",
|
||||
"sr-Latn": "srLatn",
|
||||
};
|
||||
|
||||
return supportedLanguageKeys.map((key) => {
|
||||
|
||||
@@ -42,6 +42,8 @@ const localeMap: Record<string, () => Promise<Locale>> = {
|
||||
ca: () => import("date-fns/locale/ca").then((module) => module.ca),
|
||||
hr: () => import("date-fns/locale/hr").then((module) => module.hr),
|
||||
bs: () => import("date-fns/locale/bs").then((module) => module.bs),
|
||||
"sr-Latn": () =>
|
||||
import("date-fns/locale/sr-Latn").then((module) => module.srLatn),
|
||||
sl: () => import("date-fns/locale/sl").then((module) => module.sl),
|
||||
};
|
||||
|
||||
|
||||
@@ -42,6 +42,7 @@ export const supportedLanguageKeys = [
|
||||
"pl",
|
||||
"hr",
|
||||
"bs",
|
||||
"sr-Latn",
|
||||
"sk",
|
||||
"sl",
|
||||
"lt",
|
||||
|
||||
Reference in New Issue
Block a user