mirror of
https://github.com/blakeblackshear/frigate.git
synced 2026-11-08 06:33:01 +03:00
Josh HawkinsandGitHub
4eb60af5a7
* Add analytics opt-in setting, prompt notice kind, and notice watermarks * Add the analytics report schema * Add the analytics state file * Add the install and hardware analytics collectors * Add the detection analytics collector * Add the cameras analytics collector * Add the features analytics collector * Add the health analytics collector * Build analytics reports from the section collectors * Add the analytics report transport * Send the daily analytics report from the main process * Add the analytics preview API * Generate the analytics schema and check it in CI * Record the image variant in each Dockerfile * Show the analytics preview in telemetry settings * Document anonymous analytics * change wording * fixes * update network requirements docs * adapt analytics to free-form model scenes, split notice counts, and peewee 4 * fixes * change log levels * docstrings * docstrings * honor file-only analytics opt-outs and skip pre-consent notices An opt-out saved through the YAML editor's "Save only" or a hand edit never reached the live config, so reports kept going out under the old install ID until a restart. The reporter now reads telemetry.analytics from the config file when a report is due, validated with TelemetryConfig so yes, on, and 1 still count as consent, and an opt-out there deletes the state file and skips the send. The first report under a new install ID also carried every notice since the counters started, including ones from before the opt-in, so a fresh state file now resets the notice watermarks before the report's snapshot. * take the notice baseline at opt-in instead of the first send The watermark reset ran at the first send attempt, so notices raised between the opt-in and that send, up to 45 minutes after a startup, were absorbed into the reset and never reported. The reporter now writes the new install ID and resets the watermarks as soon as it sees consent without a state file. * report notice counts cumulatively from a database baseline Moving watermarks after each accepted send kept the install ID and the notice baseline out of step: pre-consent notices went out, notices raised before the first send were dropped, and a send that finished after an off/on toggle overwrote the new identity's baseline. health.notices now carries cumulative counts since the install ID was created. Creating an ID copies the lifetime counts into the existing reported_* columns before the state file names it, and nothing is written after a send, so the backend diffs consecutive reports per install ID. * write held notice repeats before the analytics baseline reset Repeats of batched kinds like failed_login wait in memory until the stats emitter flushes them, so a baseline reset taken while some were held left them out, and the next flush counted those pre-opt-in repeats as post-consent. The reset now writes held repeats to the notice history under the same lock before copying the counts. * seed detector inference speed from the first inference The average started at 0 so idle detectors read 0, but that made every detector's speed climb from 0 for its first couple dozen inferences after a start. Detectors now use the same InferenceSpeed helper as enrichments, so the first inference seeds the average and idle detectors still read 0.
113 lines
3.9 KiB
Python
113 lines
3.9 KiB
Python
"""Tests for the shared runtime config swap helper."""
|
|
|
|
import unittest
|
|
from unittest.mock import MagicMock
|
|
|
|
from frigate.api.config_util import swap_runtime_config
|
|
from frigate.config.holder import ConfigHolder
|
|
|
|
|
|
class TestSwapRuntimeConfig(unittest.TestCase):
|
|
"""swap_runtime_config rebinds every collaborator to the new config."""
|
|
|
|
def _make_app(self) -> MagicMock:
|
|
app = MagicMock()
|
|
app.dispatcher.comms = [MagicMock(), MagicMock()]
|
|
app.config_holder = ConfigHolder(MagicMock(name="boot_config"))
|
|
return app
|
|
|
|
def test_rebinds_all_references(self) -> None:
|
|
app = self._make_app()
|
|
config = MagicMock(name="new_config")
|
|
|
|
swap_runtime_config(app, config)
|
|
|
|
self.assertIs(app.frigate_config, config)
|
|
app.genai_manager.update_config.assert_called_once_with(config)
|
|
app.profile_manager.update_config.assert_called_once_with(config)
|
|
self.assertIs(app.stats_emitter.config, config)
|
|
app.stats_emitter.hardware_stats.set_config.assert_called_once_with(config)
|
|
self.assertIs(app.dispatcher.config, config)
|
|
for comm in app.dispatcher.comms:
|
|
self.assertIs(comm.config, config)
|
|
|
|
def test_reapplies_runtime_state_after_swap(self) -> None:
|
|
app = self._make_app()
|
|
config = MagicMock(name="new_config")
|
|
|
|
swap_runtime_config(app, config)
|
|
|
|
# the swap rebuilds cameras from yaml, so overrides must be re-layered
|
|
app.dispatcher.reapply_runtime_state_to_config.assert_called_once_with()
|
|
|
|
def test_updates_the_config_holder(self) -> None:
|
|
app = self._make_app()
|
|
holder = app.config_holder
|
|
config = MagicMock(name="new_config")
|
|
|
|
swap_runtime_config(app, config)
|
|
|
|
self.assertIs(holder.config, config)
|
|
|
|
def test_deferred_factory_builds_from_the_swapped_config(self) -> None:
|
|
"""A watchdog-style factory must not rebuild from the boot config.
|
|
|
|
The factories in FrigateApp are lambdas evaluated when a process is
|
|
restarted, long after a user may have saved. Reading through the
|
|
holder is what keeps a rebuilt process from reverting every change
|
|
made since Frigate started.
|
|
"""
|
|
app = self._make_app()
|
|
holder = app.config_holder
|
|
boot_config = holder.config
|
|
factory = lambda: holder.config # noqa: E731
|
|
self.assertIs(factory(), boot_config)
|
|
|
|
config = MagicMock(name="new_config")
|
|
swap_runtime_config(app, config)
|
|
|
|
self.assertIs(factory(), config)
|
|
|
|
def test_tolerates_missing_optional_collaborators(self) -> None:
|
|
app = MagicMock()
|
|
app.profile_manager = None
|
|
app.stats_emitter = None
|
|
app.dispatcher = None
|
|
app.config_holder = None
|
|
config = MagicMock(name="new_config")
|
|
|
|
# must not raise when the optional collaborators are absent
|
|
swap_runtime_config(app, config)
|
|
|
|
self.assertIs(app.frigate_config, config)
|
|
app.genai_manager.update_config.assert_called_once_with(config)
|
|
|
|
|
|
class TestConfigHolder(unittest.TestCase):
|
|
def test_set_passes_the_new_config_to_subscribers(self) -> None:
|
|
holder = ConfigHolder(MagicMock(name="boot_config"))
|
|
listener = MagicMock()
|
|
holder.subscribe(listener)
|
|
config = MagicMock(name="new_config")
|
|
|
|
holder.set(config)
|
|
|
|
listener.assert_called_once_with(config)
|
|
|
|
def test_a_failing_subscriber_does_not_block_the_swap(self) -> None:
|
|
holder = ConfigHolder(MagicMock(name="boot_config"))
|
|
after = MagicMock()
|
|
holder.subscribe(MagicMock(side_effect=RuntimeError("boom")))
|
|
holder.subscribe(after)
|
|
config = MagicMock(name="new_config")
|
|
|
|
with self.assertLogs("frigate.config.holder", "ERROR"):
|
|
holder.set(config)
|
|
|
|
self.assertIs(holder.config, config)
|
|
after.assert_called_once_with(config)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|