mirror of
https://github.com/blakeblackshear/frigate.git
synced 2026-05-07 05:55:27 +03:00
* add CameraProfileConfig model for named config overrides * add profiles field to CameraConfig * add active_profile field to FrigateConfig Runtime-only field excluded from YAML serialization, tracks which profile is currently active. * add ProfileManager for profile activation and persistence Handles snapshotting base configs, applying profile overrides via deep_merge + apply_section_update, publishing ZMQ updates, and persisting active profile to /config/.active_profile. * add profile API endpoints (GET /profiles, GET/PUT /profile) * add MQTT and dispatcher integration for profiles - Subscribe to frigate/profile/set MQTT topic - Publish profile/state and profiles/available on connect - Add _on_profile_command handler to dispatcher - Broadcast active profile state on WebSocket connect * wire ProfileManager into app startup and FastAPI - Create ProfileManager after dispatcher init - Restore persisted profile on startup - Pass dispatcher and profile_manager to FastAPI app * add tests for invalid profile values and keys Tests that Pydantic rejects: invalid field values (fps: "not_a_number"), unknown section keys (ffmpeg in profile), invalid nested values, and invalid profiles in full config parsing. * formatting * fix CameraLiveConfig JSON serialization error on profile activation refactor _publish_updates to only publish ZMQ updates for sections that actually changed, not all sections on affected cameras. * consolidate * add enabled field to camera profiles for enabling/disabling cameras * add zones support to camera profiles * add frontend profile types, color utility, and config save support * add profile state management and save preview support * add profileName prop to BaseSection for profile-aware config editing * add profile section dropdown and wire into camera settings pages * add per-profile camera enable/disable to Camera Management view * add profiles summary page with card-based layout and fix backend zone comparison bug * add active profile badge to settings toolbar * i18n * add red dot for any pending changes including profiles * profile support for mask and zone editor * fix hidden field validation errors caused by lodash wildcard and schema gaps lodash unset does not support wildcard (*) segments, so hidden fields like filters.*.mask were never stripped from form data, leaving null raw_coordinates that fail RJSF anyOf validation. Add unsetWithWildcard helper and also strip hidden fields from the JSON schema itself as defense-in-depth. * add face_recognition and lpr to profile-eligible sections * move profile dropdown from section panes to settings header * add profiles enable toggle and improve empty state * formatting * tweaks * tweak colors and switch * fix profile save diff, masksAndZones delete, and config sync * ui tweaks * ensure profile manager gets updated config * rename profile settings to ui settings * refactor profilesview and add dots/border colors when overridden * implement an update_config method for profile manager * fix mask deletion * more unique colors * add top-level profiles config section with friendly names * implement profile friendly names and improve profile UI - Add ProfileDefinitionConfig type and profiles field to FrigateConfig - Use ProfilesApiResponse type with friendly_name support throughout - Replace Record<string, unknown> with proper JsonObject/JsonValue types - Add profile creation form matching zone pattern (Zod + NameAndIdFields) - Add pencil icon for renaming profile friendly names in ProfilesView - Move Profiles menu item to first under Camera Configuration - Add activity indicators on save/rename/delete buttons - Display friendly names in CameraManagementView profile selector - Fix duplicate colored dots in management profile dropdown - Fix i18n namespace for overridden base config tooltips - Move profile override deletion from dropdown trash icon to footer button with confirmation dialog, matching Reset to Global pattern - Remove Add Profile from section header dropdown to prevent saving camera overrides before top-level profile definition exists - Clean up newProfiles state after API profile deletion - Refresh profiles SWR cache after saving profile definitions * remove profile badge in settings and add profiles to main menu * use icon only on mobile * change color order * docs * show activity indicator on trash icon while deleting a profile * tweak language * immediately create profiles on backend instead of deferring to Save All * hide restart-required fields when editing a profile section fields that require a restart cannot take effect via profile switching, so they are merged into hiddenFields when profileName is set * show active profile indicator in desktop status bar * fix profile config inheritance bug where Pydantic defaults override base values The /config API was dumping profile overrides with model_dump() which included all Pydantic defaults. When the frontend merged these over the camera's base config, explicitly-set base values were lost. Now profile overrides are re-dumped with exclude_unset=True so only user-specified fields are returned. Also fixes the Save All path generating spurious deletion markers for restart-required fields that are hidden during profile editing but not excluded from the raw data sanitization in prepareSectionSavePayload. * docs tweaks * docs tweak * formatting * formatting * fix typing * fix test pollution test_maintainer was injecting MagicMock() into sys.modules["frigate.config.camera.updater"] at module load time and never restoring it. When the profile tests later imported CameraConfigUpdateEnum and CameraConfigUpdateTopic from that module, they got mock objects instead of the real dataclass/enum, so equality comparisons always failed * remove * fix settings showing profile-merged values when editing base config When a profile is active, the in-memory config contains effective (profile-merged) values. The settings UI was displaying these merged values even when the "Base Config" view was selected. Backend: snapshot pre-profile base configs in ProfileManager and expose them via a `base_config` key in the /api/config camera response when a profile is active. The top-level sections continue to reflect the effective running config. Frontend: read from `base_config` when available in BaseSection, useConfigOverride, useAllCameraOverrides, and prepareSectionSavePayload. Include formData labels in Object/Audio switches widgets so that labels added only by a profile override remain visible when editing that profile. * use rasterized_mask as field makes it easier to exclude from the schema with exclude=True prevents leaking of the field when using model_dump for profiles * fix zones - Fix zone colors not matching across profiles by falling back to base zone color when profile zone data lacks a color field - Use base_config for base-layer values in masks/zones view so profile-merged values don't pollute the base config editing view - Handle zones separately in profile manager snapshot/restore since ZoneConfig requires special serialization (color as private attr, contour generation) - Inherit base zone color and generate contours for profile zone overrides in profile manager * formatting * don't require restart for camera enabled change for profiles * publish camera state when changing profiles * formatting * remove available profiles from mqtt * improve typing
289 lines
7.8 KiB
TypeScript
289 lines
7.8 KiB
TypeScript
// Hook to detect when camera config overrides global defaults
|
|
import { useMemo } from "react";
|
|
import isEqual from "lodash/isEqual";
|
|
import get from "lodash/get";
|
|
import set from "lodash/set";
|
|
import { FrigateConfig } from "@/types/frigateConfig";
|
|
import { JsonObject, JsonValue } from "@/types/configForm";
|
|
import { isJsonObject } from "@/lib/utils";
|
|
import { getBaseCameraSectionValue } from "@/utils/configUtil";
|
|
|
|
const INTERNAL_FIELD_SUFFIXES = ["enabled_in_config", "raw_mask"];
|
|
|
|
function stripInternalFields(value: JsonValue): JsonValue {
|
|
if (Array.isArray(value)) {
|
|
return value.map(stripInternalFields);
|
|
}
|
|
|
|
if (isJsonObject(value)) {
|
|
const obj = value;
|
|
const cleaned: JsonObject = {};
|
|
for (const [key, val] of Object.entries(obj)) {
|
|
if (INTERNAL_FIELD_SUFFIXES.some((suffix) => key.endsWith(suffix))) {
|
|
continue;
|
|
}
|
|
cleaned[key] = stripInternalFields(val as JsonValue);
|
|
}
|
|
return cleaned;
|
|
}
|
|
|
|
return value;
|
|
}
|
|
|
|
export function normalizeConfigValue(value: unknown): JsonValue {
|
|
return stripInternalFields(value as JsonValue);
|
|
}
|
|
|
|
export interface OverrideStatus {
|
|
/** Whether the field is overridden from global */
|
|
isOverridden: boolean;
|
|
/** The global default value */
|
|
globalValue: unknown;
|
|
/** The camera-specific value */
|
|
cameraValue: unknown;
|
|
}
|
|
|
|
export interface UseConfigOverrideOptions {
|
|
/** Full Frigate config */
|
|
config: FrigateConfig | undefined;
|
|
/** Camera name for per-camera settings */
|
|
cameraName?: string;
|
|
/** Config section path (e.g., "detect", "record.events") */
|
|
sectionPath: string;
|
|
/** Optional list of field paths to compare for overrides */
|
|
compareFields?: string[];
|
|
}
|
|
|
|
function pickFields(value: unknown, fields: string[]): JsonObject {
|
|
if (!fields || fields.length === 0) {
|
|
return {};
|
|
}
|
|
|
|
const result: JsonObject = {};
|
|
fields.forEach((path) => {
|
|
if (!path) return;
|
|
const fieldValue = get(value as JsonObject, path);
|
|
if (fieldValue !== undefined) {
|
|
set(result, path, fieldValue);
|
|
}
|
|
});
|
|
return result;
|
|
}
|
|
|
|
/**
|
|
* Hook to detect config overrides between global and camera level
|
|
*
|
|
* @example
|
|
* ```tsx
|
|
* const { isOverridden, getFieldOverride } = useConfigOverride({
|
|
* config,
|
|
* cameraName: "front_door",
|
|
* sectionPath: "detect"
|
|
* });
|
|
*
|
|
* // Check if entire section is overridden
|
|
* if (isOverridden) {
|
|
* // Show override indicator
|
|
* }
|
|
*
|
|
* // Check specific field
|
|
* const fpsOverride = getFieldOverride("fps");
|
|
* ```
|
|
*/
|
|
export function useConfigOverride({
|
|
config,
|
|
cameraName,
|
|
sectionPath,
|
|
compareFields,
|
|
}: UseConfigOverrideOptions) {
|
|
return useMemo(() => {
|
|
if (!config) {
|
|
return {
|
|
isOverridden: false,
|
|
globalValue: undefined,
|
|
cameraValue: undefined,
|
|
getFieldOverride: () => ({
|
|
isOverridden: false,
|
|
globalValue: undefined,
|
|
cameraValue: undefined,
|
|
}),
|
|
resetToGlobal: () => undefined,
|
|
};
|
|
}
|
|
|
|
// Get global value for the section
|
|
const globalValue = get(config, sectionPath);
|
|
|
|
// If no camera specified, return global value info
|
|
if (!cameraName) {
|
|
return {
|
|
isOverridden: false,
|
|
globalValue,
|
|
cameraValue: globalValue,
|
|
getFieldOverride: (fieldPath: string): OverrideStatus => ({
|
|
isOverridden: false,
|
|
globalValue: get(globalValue, fieldPath),
|
|
cameraValue: get(globalValue, fieldPath),
|
|
}),
|
|
resetToGlobal: () => globalValue,
|
|
};
|
|
}
|
|
|
|
// Get camera-specific value
|
|
const cameraConfig = config.cameras?.[cameraName];
|
|
if (!cameraConfig) {
|
|
return {
|
|
isOverridden: false,
|
|
globalValue,
|
|
cameraValue: undefined,
|
|
getFieldOverride: () => ({
|
|
isOverridden: false,
|
|
globalValue: undefined,
|
|
cameraValue: undefined,
|
|
}),
|
|
resetToGlobal: () => globalValue,
|
|
};
|
|
}
|
|
|
|
// Prefer the base (pre-profile) value so that override detection and
|
|
// widget context reflect the camera's own config, not profile effects.
|
|
const cameraValue = getBaseCameraSectionValue(
|
|
config,
|
|
cameraName,
|
|
sectionPath,
|
|
);
|
|
|
|
const normalizedGlobalValue = normalizeConfigValue(globalValue);
|
|
const normalizedCameraValue = normalizeConfigValue(cameraValue);
|
|
|
|
const comparisonGlobal = compareFields
|
|
? pickFields(normalizedGlobalValue, compareFields)
|
|
: normalizedGlobalValue;
|
|
const comparisonCamera = compareFields
|
|
? pickFields(normalizedCameraValue, compareFields)
|
|
: normalizedCameraValue;
|
|
|
|
// Check if the entire section is overridden
|
|
const isOverridden = compareFields
|
|
? compareFields.length > 0 && !isEqual(comparisonGlobal, comparisonCamera)
|
|
: !isEqual(comparisonGlobal, comparisonCamera);
|
|
|
|
/**
|
|
* Get override status for a specific field within the section
|
|
*/
|
|
const getFieldOverride = (fieldPath: string): OverrideStatus => {
|
|
const globalFieldValue = get(normalizedGlobalValue, fieldPath);
|
|
const cameraFieldValue = get(normalizedCameraValue, fieldPath);
|
|
|
|
return {
|
|
isOverridden: !isEqual(globalFieldValue, cameraFieldValue),
|
|
globalValue: globalFieldValue,
|
|
cameraValue: cameraFieldValue,
|
|
};
|
|
};
|
|
|
|
/**
|
|
* Returns the global value to reset camera override
|
|
*/
|
|
const resetToGlobal = (fieldPath?: string) => {
|
|
if (fieldPath) {
|
|
return get(normalizedGlobalValue, fieldPath);
|
|
}
|
|
return normalizedGlobalValue;
|
|
};
|
|
|
|
return {
|
|
isOverridden,
|
|
globalValue: normalizedGlobalValue,
|
|
cameraValue: normalizedCameraValue,
|
|
getFieldOverride,
|
|
resetToGlobal,
|
|
};
|
|
}, [config, cameraName, sectionPath, compareFields]);
|
|
}
|
|
|
|
/**
|
|
* Hook to get all overridden fields for a camera
|
|
*/
|
|
export function useAllCameraOverrides(
|
|
config: FrigateConfig | undefined,
|
|
cameraName: string | undefined,
|
|
) {
|
|
return useMemo(() => {
|
|
if (!config || !cameraName) {
|
|
return [];
|
|
}
|
|
|
|
const cameraConfig = config.cameras?.[cameraName];
|
|
if (!cameraConfig) {
|
|
return [];
|
|
}
|
|
|
|
const overriddenSections: string[] = [];
|
|
|
|
// Check each section that can be overridden
|
|
const sectionsToCheck: Array<{
|
|
key: string;
|
|
compareFields?: string[];
|
|
}> = [
|
|
{ key: "detect" },
|
|
{ key: "record" },
|
|
{ key: "snapshots" },
|
|
{ key: "motion" },
|
|
{ key: "objects" },
|
|
{ key: "review" },
|
|
{ key: "audio" },
|
|
{ key: "notifications" },
|
|
{ key: "live" },
|
|
{ key: "timestamp_style" },
|
|
{
|
|
key: "audio_transcription",
|
|
compareFields: ["enabled", "live_enabled"],
|
|
},
|
|
{ key: "birdseye", compareFields: ["enabled", "mode"] },
|
|
{ key: "face_recognition", compareFields: ["enabled", "min_area"] },
|
|
{
|
|
key: "ffmpeg",
|
|
compareFields: [
|
|
"path",
|
|
"global_args",
|
|
"hwaccel_args",
|
|
"input_args",
|
|
"output_args",
|
|
"retry_interval",
|
|
"apple_compatibility",
|
|
"gpu",
|
|
],
|
|
},
|
|
{
|
|
key: "lpr",
|
|
compareFields: ["enabled", "min_area", "enhancement"],
|
|
},
|
|
];
|
|
|
|
for (const { key, compareFields } of sectionsToCheck) {
|
|
const globalValue = normalizeConfigValue(get(config, key));
|
|
const cameraValue = normalizeConfigValue(
|
|
getBaseCameraSectionValue(config, cameraName, key),
|
|
);
|
|
|
|
const comparisonGlobal = compareFields
|
|
? pickFields(globalValue, compareFields)
|
|
: globalValue;
|
|
const comparisonCamera = compareFields
|
|
? pickFields(cameraValue, compareFields)
|
|
: cameraValue;
|
|
|
|
if (
|
|
compareFields && compareFields.length === 0
|
|
? false
|
|
: !isEqual(comparisonGlobal, comparisonCamera)
|
|
) {
|
|
overriddenSections.push(key);
|
|
}
|
|
}
|
|
|
|
return overriddenSections;
|
|
}, [config, cameraName]);
|
|
}
|