Files
frigate/frigate/test/http_api/test_http_ffprobe.py
T
Josh Hawkins 7208d7e810 fix stream checks missing non-aac audio
The ffprobe API never asked ffprobe for codec_type, so the stream checks could only spot audio and video by codec name. G.711, Opus, and other non-AAC audio showed as no audio, and H.265 detect streams showed an unknown resolution. ffprobe_stream now requests codec_type, and the stream check matches tracks on it alone.
2026-11-18 15:30:09 -06:00

54 lines
1.9 KiB
Python

"""Tests for the ffprobe API."""
import unittest
from types import SimpleNamespace
from unittest.mock import patch
from fastapi.testclient import TestClient
from frigate.test.http_api.base_http_test import AuthTestClient, BaseTestHttp
from frigate.util.services import ffprobe_stream
class TestHttpFfprobe(BaseTestHttp):
def setUp(self):
super().setUp([])
self.app = self.create_app()
def client(self) -> TestClient:
return AuthTestClient(self.app)
def test_failed_probe_scrubs_credentials_from_stderr(self):
failed = SimpleNamespace(
returncode=1,
stdout=b"",
stderr=(
b"[tcp @ 0x1] Connection to tcp://10.0.0.1:554 failed\n"
b"rtsp://admin:hunter2@10.0.0.1:554/video: Connection refused\n"
),
)
with patch("frigate.api.camera.ffprobe_stream", return_value=failed):
with self.client() as client:
response = client.get("/ffprobe", params={"paths": "camera:front_door"})
self.assertEqual(response.status_code, 200)
lines = response.json()[0]["stderr"]
self.assertEqual(len(lines), 2)
self.assertNotIn("hunter2", " ".join(lines))
self.assertEqual(lines[1], "rtsp://*:*@10.0.0.1:554/video: Connection refused")
class TestFfprobeStream(unittest.TestCase):
def test_requests_codec_type(self):
ffmpeg = SimpleNamespace(ffprobe_path="ffprobe")
done = SimpleNamespace(returncode=0, stdout=b"{}", stderr=b"")
for detailed in (False, True):
with patch("frigate.util.services.sp.run", return_value=done) as run:
ffprobe_stream(ffmpeg, "rtsp://10.0.0.1/live", detailed=detailed)
cmd = run.call_args.args[0]
entries = cmd[cmd.index("-show_entries") + 1]
self.assertIn("codec_type", entries.removeprefix("stream=").split(","))