Update scikit-build requirement in /docker/main

Updates the requirements on [scikit-build](https://github.com/scikit-build/scikit-build) to permit the latest version.
- [Release notes](https://github.com/scikit-build/scikit-build/releases)
- [Changelog](https://github.com/scikit-build/scikit-build/blob/main/CHANGES.md)
- [Commits](https://github.com/scikit-build/scikit-build/compare/0.18.0...0.19.1)

---
updated-dependencies:
- dependency-name: scikit-build
  dependency-version: 0.19.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

docker/main/requirements.txt

@@ -1 +1 @@
-scikit-build == 0.18.*
+scikit-build == 0.19.*

docs/docs/troubleshooting/faqs.md

@@ -53,14 +53,6 @@ go2rtc:
 
 Point the camera's inputs at the restream as described in the [restream docs](/configuration/restream.md), and swap `detect -> width` and `detect -> height` to match the rotated resolution.
 
-### Can I add a privacy mask to hide part of my camera's view?
-
-Frigate does not have privacy masks. [Motion masks and object filter masks](../configuration/masks.md) only affect detection, they don't hide anything in live view, recordings, or snapshots.
-
-Privacy masks are best configured in the camera's firmware settings so the area is blacked out before the video ever leaves the camera and no extra processing is needed. Check there first.
-
-If your camera does not support privacy masks, there is no efficient alternative. Frigate copies the camera's video into recordings and live view without decoding it, so part of the image can't be hidden without transcoding (re-encoding) the stream. This can be done with a custom ffmpeg filter in go2rtc, but it is not recommended. Every masked camera needs a continuous re-encode, which significantly increases CPU usage, especially for high resolution streams.
-
 ### My mjpeg stream or snapshots look green and crazy
 
 This almost always means that the width/height defined for your camera are not correct. Double check the resolution with VLC or another player. Also make sure you don't have the width and height values backwards.

frigate/jobs/export.py

@@ -15,7 +15,7 @@ from peewee import DoesNotExist
 from frigate.comms.inter_process import InterProcessRequestor
 from frigate.config import FrigateConfig
 from frigate.config.camera.record import ChaptersEnum
-from frigate.const import EXPORT_DIR, UPDATE_JOB_STATE
+from frigate.const import UPDATE_JOB_STATE
 from frigate.jobs.job import Job
 from frigate.models import Export
 from frigate.record.export import (
@@ -415,10 +415,6 @@ def reap_stale_exports() -> None:
     this in a try/except. A failure on a single row will not stop the rest
     of the sweep, and a failure in the top-level query will log and return.
     """
-    # staged stream runs live on disk, so a killed export leaves them behind
-    for staged in Path(EXPORT_DIR).glob("export_stage_*"):
-        staged.unlink(missing_ok=True)
-
     try:
         stale_exports = list(Export.select().where(Export.in_progress == True))  # noqa: E712
     except Exception:

frigate/record/export.py

@@ -559,7 +559,7 @@ class RecordingExporter(threading.Thread):
         )
 
     def _staged_run_path(self, index: int) -> str:
-        return os.path.join(EXPORT_DIR, f"export_stage_{self.export_id}_{index}.mp4")
+        return os.path.join(CACHE_DIR, f"export_stage_{self.export_id}_{index}.mp4")
 
     def _probe_stream_resolution(self, run: StreamRun) -> tuple[int, int] | None:
         """Probe one recording from a run for its resolution.

frigate/test/http_api/test_http_export.py

@@ -453,21 +453,6 @@ class TestHttpExport(BaseTestHttp):
             assert unchanged.name == "front door export"
             assert unchanged.video_path == video
 
-    def test_reap_stale_exports_removes_staged_runs(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            staged = os.path.join(tmpdir, "export_stage_front_door_abc_0.mp4")
-            finished = os.path.join(tmpdir, "front_door_export.mp4")
-
-            for path in (staged, finished):
-                with open(path, "w") as handle:
-                    handle.write("video")
-
-            with patch("frigate.jobs.export.EXPORT_DIR", tmpdir):
-                reap_stale_exports()
-
-            assert not os.path.exists(staged)
-            assert os.path.exists(finished)
-
     def test_reap_stale_exports_deletes_rows_with_no_file(self):
         with tempfile.TemporaryDirectory() as tmpdir:
             stale_video = os.path.join(tmpdir, "stale.mp4")

frigate/test/test_recording_coverage.py

@@ -13,7 +13,6 @@ from frigate.models import Recordings
 from frigate.util.recording_coverage import (
     _rows_query,
     coverage_spans,
-    null_audio_glitches,
     plan_clip,
     realized_timeline,
     resolve_coverage,
@@ -167,22 +166,6 @@ class TestRecordingCoverage(CoverageDbTestCase):
         expected = int(5 * 1024 * 1024 * 8 / 10)
         assert summary["main"]["bitrate"] == expected
 
-    def test_unknown_audio_row_keeps_video_only_stream(self):
-        self._insert("s1", 1000.0, 1010.0, "sub", has_audio=False)
-        self._insert("s2", 1010.0, 1020.0, "sub", has_audio=None)
-        self._insert("s3", 1020.0, 1030.0, "sub", has_audio=False)
-        kept = null_audio_glitches(resolve_coverage("front_door", 1000.0, 1030.0))
-        self.assertEqual(
-            [i.sub.path for i in kept], [f"/tmp/s{n}.mp4" for n in (1, 2, 3)]
-        )
-
-    def test_video_only_glitch_dropped_on_audio_stream(self):
-        self._insert("s1", 1000.0, 1010.0, "sub", has_audio=True)
-        self._insert("s2", 1010.0, 1020.0, "sub", has_audio=False)
-        self._insert("s3", 1020.0, 1030.0, "sub", has_audio=None)
-        kept = null_audio_glitches(resolve_coverage("front_door", 1000.0, 1030.0))
-        self.assertEqual([i.sub.path for i in kept], ["/tmp/s1.mp4", "/tmp/s3.mp4"])
-
     def test_other_camera_rows_excluded(self):
         self._insert("m1", 1000.0, 1010.0, "main")
         self._insert("o1", 1000.0, 1010.0, "main", camera="back_yard")

frigate/util/classification.py

@@ -747,14 +747,8 @@ def collect_object_classification_examples(
     selected_events = _select_balanced_events(events, target_count=100)
     logger.debug(f"Selected {len(selected_events)} events")
 
-    # Step 3: Extract thumbnails from events, falling back to the remaining
+    # Step 3: Extract thumbnails from events
-    # events when the selected ones have no image on disk
+    thumbnails = _extract_event_thumbnails(selected_events, temp_dir)
-    selected_ids = {e.id for e in selected_events}
-    remaining_events = [e for e in events if e.id not in selected_ids]
-    random.shuffle(remaining_events)
-    thumbnails = _extract_event_thumbnails(
-        selected_events + remaining_events, temp_dir, target_count=100
-    )
     logger.debug(f"Successfully extracted {len(thumbnails)} thumbnails")
 
     # Step 4: Select 24 most visually distinct thumbnails
@@ -839,16 +833,10 @@ def _select_balanced_events(
         else:
             selected.extend(remaining)
 
-    # groups are ordered oldest first, so truncating unshuffled keeps only the
-    # oldest events, which are the least likely to still have images on disk
-    random.shuffle(selected)
-
     return selected[:target_count]
 
 
-def _extract_event_thumbnails(
+def _extract_event_thumbnails(events: list[Event], output_dir: str) -> list[str]:
-    events: list[Event], output_dir: str, target_count: int = 100
-) -> list[str]:
     """
     Extract a training image for each event.
 
@@ -862,9 +850,8 @@ def _extract_event_thumbnails(
     using a step ladder sized from the box/region area ratio.
 
     Args:
-        events: List of Event objects, in order of preference
+        events: List of Event objects
         output_dir: Directory to save crops
-        target_count: Number of images to extract before stopping
 
     Returns:
         List of paths to successfully extracted images
@@ -872,9 +859,6 @@ def _extract_event_thumbnails(
     image_paths = []
 
     for idx, event in enumerate(events):
-        if len(image_paths) >= target_count:
-            break
-
         try:
             img = _load_event_classification_crop(event)
             if img is None:

frigate/util/recording_coverage.py

@@ -204,12 +204,11 @@ def coverage_spans(intervals: list[CoverageInterval]) -> list[dict[str, Any]]:
 def stream_has_audio(intervals: list[CoverageInterval], main: bool) -> bool:
     """Whether a stream is audio-bearing over a coverage window.
 
-    A stream counts as audio-bearing only when one of its rows is known
+    A stream counts as audio-bearing unless EVERY one of its rows reports
-    to carry audio. A NULL row (legacy, or a segment ffprobe could not
+    has_audio False; NULL (legacy or undetermined) counts as audio.
-    read) proves nothing either way.
     """
     return any(
-        row is not None and row.has_audio is True
+        row is not None and row.has_audio is not False
         for row in ((interval.main if main else interval.sub) for interval in intervals)
     )
 

web/e2e/specs/system-health.spec.ts

@@ -14,17 +14,6 @@ const NOW = Math.floor(Date.now() / 1000);
 // the fixture detector runs at 75.5 ms, above the live warning threshold
 const QUIET_STATS = { detectors: { cpu: { inference_speed: 10 } } };
 
-// the fixture has no go2rtc streams, which gives every camera a live view hint
-const RESTREAMED = {
-  go2rtc: {
-    streams: {
-      front_door: ["rtsp://x"],
-      backyard: ["rtsp://x"],
-      garage: ["rtsp://x"],
-    },
-  },
-};
-
 const ERROR_NOTICE = {
   id: "model_download_failed:yolo/model.onnx",
   kind: "model_download_failed",
@@ -62,7 +51,6 @@ test.describe("System — Health tab @medium", () => {
     frigateApp,
   }) => {
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: QUIET_STATS,
       notices: [ERROR_NOTICE, EVENT_NOTICE],
     });
@@ -96,7 +84,6 @@ test.describe("System — Health tab @medium", () => {
   for (const action of ["acknowledge", "mute"] as const) {
     test(`${action} posts and removes the row`, async ({ frigateApp }) => {
       await frigateApp.installDefaults({
-        config: RESTREAMED,
         stats: QUIET_STATS,
         notices: [EVENT_NOTICE],
       });
@@ -139,10 +126,7 @@ test.describe("System — Health tab @medium", () => {
   }
 
   test("empty state with no notices", async ({ frigateApp }) => {
-    await frigateApp.installDefaults({
+    await frigateApp.installDefaults({ stats: QUIET_STATS });
-      config: RESTREAMED,
-      stats: QUIET_STATS,
-    });
     await frigateApp.goto("/system#health");
 
     await expect(
@@ -345,7 +329,6 @@ test.describe("System — Health tab @medium", () => {
     frigateApp,
   }) => {
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: QUIET_STATS,
       notices: [ERROR_NOTICE, EVENT_NOTICE],
     });
@@ -782,7 +765,6 @@ test.describe("System — Health notices sources @medium", () => {
   test("status bar problems stay out of the list", async ({ frigateApp }) => {
     test.skip(frigateApp.isMobile, "Status bar is desktop-only");
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: {
         service: { retention_unmet: true },
         cameras: { front_door: { camera_fps: 0 } },
@@ -847,28 +829,6 @@ test.describe("System — Health notices sources @medium", () => {
     ).toBeVisible({ timeout: 15_000 });
   });
 
-  test("a camera without a go2rtc stream gets a live view hint", async ({
-    frigateApp,
-  }) => {
-    await frigateApp.installDefaults({
-      config: { go2rtc: { streams: { front_door: ["rtsp://x"] } } },
-      stats: QUIET_STATS,
-    });
-    await frigateApp.goto("/system#health");
-
-    const row = frigateApp.page.getByTestId(
-      "health-problem-config:live:no-go2rtc-stream:camera.backyard",
-    );
-    await expect(row).toBeVisible({ timeout: 15_000 });
-    await expect(row).toHaveAttribute("data-severity", "info");
-    await expect(row).toContainText("lower frame rate and no audio");
-    await expect(
-      frigateApp.page.getByTestId(
-        "health-problem-config:live:no-go2rtc-stream:camera.front_door",
-      ),
-    ).toHaveCount(0);
-  });
-
   test("a global config problem is not repeated per camera", async ({
     frigateApp,
   }) => {
@@ -933,10 +893,7 @@ test.describe("System — Health notices sources @medium", () => {
   test("empty state when stats, config, and registry are clean", async ({
     frigateApp,
   }) => {
-    await frigateApp.installDefaults({
+    await frigateApp.installDefaults({ stats: QUIET_STATS });
-      config: RESTREAMED,
-      stats: QUIET_STATS,
-    });
     await frigateApp.goto("/system#health");
 
     await expect(
@@ -1173,7 +1130,6 @@ test.describe("System — Health notices sources @medium", () => {
   }) => {
     test.skip(frigateApp.isMobile, "Status bar is desktop-only");
     await frigateApp.installDefaults({
-      config: RESTREAMED,
       stats: QUIET_STATS,
       notices: [EVENT_NOTICE],
     });

web/public/locales/en/views/settings.json

@@ -1997,9 +1997,6 @@
       "genaiImageSourceRecordingsRecordDisabled": "Image source is set to 'recordings', but recording is disabled. Frigate will fall back to preview images.",
       "genaiImageSourceRecordingsRecordRuntimeDisabled": "Image source is set to 'recordings', but recording is currently turned off for this camera even though your config enables it. Frigate will fall back to preview images."
     },
-    "live": {
-      "noGo2rtcStream": "Live view for this camera is using a basic player with a lower frame rate and no audio. Set up a go2rtc stream for this camera to get smoother video and audio."
-    },
     "audio": {
       "noAudioRole": "No streams have the audio role defined. You must enable the audio role for audio detection to function."
     },

web/src/components/config-form/section-configs/live.ts

@@ -1,24 +1,8 @@
-import { isRestreamedStream } from "@/utils/liveTranscode";
 import type { SectionConfigOverrides } from "./types";
 
 const live: SectionConfigOverrides = {
   base: {
     sectionDocs: "/configuration/live",
-    messages: [
-      {
-        key: "no-go2rtc-stream",
-        health: true,
-        messageKey: "configMessages.live.noGo2rtcStream",
-        severity: "info",
-        docLink: "/configuration/live",
-        condition: (ctx) => {
-          if (ctx.level !== "camera" || !ctx.fullCameraConfig) return false;
-          return !Object.values(ctx.fullCameraConfig.live.streams).some(
-            (name) => isRestreamedStream(ctx.fullConfig, name),
-          );
-        },
-      },
-    ],
     restartRequired: [],
     fieldOrder: ["streams", "transcode", "height", "quality"],
     fieldGroups: {},

web/src/components/config-form/theme/fields/HardwarePicker.tsx

@@ -15,7 +15,6 @@ import {
   hardwareForDevices,
   MAX_DETECTORS,
   recommendedDetectorCount,
-  resolveUnitDevice,
 } from "@/utils/detectionHardware";
 
 type HardwarePickerProps = {
@@ -61,13 +60,9 @@ export function HardwarePicker({
       return [];
     }
 
-    const assigned = devices.map((device) =>
-      resolveUnitDevice(selected, device),
-    );
-
     return selected.units
       .map((unit) => unit.device)
-      .filter((device) => assigned.includes(device));
+      .filter((device) => devices.includes(device));
   }, [selected, devices]);
 
   /** Spread `count` detectors round robin over the selected units. */
@@ -205,7 +200,7 @@ export function HardwarePicker({
                 <Checkbox
                   id={`${idPrefix}-${unit.device}`}
                   className="size-5 text-white accent-white data-[state=checked]:bg-selected data-[state=checked]:text-white"
-                  checked={selectedUnits.includes(unit.device)}
+                  checked={devices.includes(unit.device)}
                   disabled={disabled || Boolean(claimedBy)}
                   onCheckedChange={(checked) =>
                     handleUnitToggle(unit.device, checked === true)

web/src/utils/detectionHardware.ts

@@ -21,31 +21,10 @@ export function hardwareForDevices(
     return undefined;
   }
 
-  return hardware.find((entry) =>
+  return hardware.find((entry) => {
-    devices.every((device) => resolveUnitDevice(entry, device)),
+    const known = new Set(entry.units.map((unit) => unit.device));
-  );
+    return devices.every((device) => known.has(device));
-}
+  });
-
-/**
- * The unit device string a configured device refers to.
- *
- * A config may leave the index off, such as "edgetpu:usb", which the detector
- * resolves to the first unit of that kind.
- */
-export function resolveUnitDevice(
-  entry: DetectionHardware,
-  device: string,
-): string | undefined {
-  const unitDevices = entry.units.map((unit) => unit.device);
-
-  return (
-    unitDevices.find((candidate) => candidate === device) ??
-    unitDevices.find(
-      (candidate) =>
-        candidate.startsWith(`${device}:`) ||
-        candidate.startsWith(`${device}.`),
-    )
-  );
 }
 
 /**