yaml list

applying modal=false to the menu (not to the dialog) to fix this in the same way as elsewhere in the codebase

docs/docs/configuration/license_plate_recognition.md

@@ -374,9 +374,19 @@ Use `match_distance` to allow small character mismatches. Alternatively, define
 
 Start with ["Why isn't my license plate being detected and recognized?"](#why-isnt-my-license-plate-being-detected-and-recognized). If you are still having issues, work through these steps.
 
-1. Enable debug logs to see exactly what Frigate is doing.
+1. Start with a simplified LPR config.
 
-   - Enable debug logs for LPR by adding `frigate.data_processing.common.license_plate: debug` to your `logger` configuration. These logs are _very_ verbose, so only keep this enabled when necessary.
+   - Remove or comment out everything in your LPR config, including `min_area`, `min_plate_length`, `format`, `known_plates`, or `enhancement` values so that the only values left are `enabled` and `debug_save_plates`. This will run LPR with Frigate's default values.
+
+     ```yaml
+     lpr:
+       enabled: true
+       debug_save_plates: true
+     ```
+
+2. Enable debug logs to see exactly what Frigate is doing.
+
+   - Enable debug logs for LPR by adding `frigate.data_processing.common.license_plate: debug` to your `logger` configuration. These logs are _very_ verbose, so only keep this enabled when necessary. Restart Frigate after this change.
 
      ```yaml
      logger:
@@ -385,7 +395,7 @@ Start with ["Why isn't my license plate being detected and recognized?"](#why-is
          frigate.data_processing.common.license_plate: debug
      ```
 
-2. Ensure your plates are being _detected_.
+3. Ensure your plates are being _detected_.
 
    If you are using a Frigate+ or `license_plate` detecting model:
 
@@ -398,7 +408,7 @@ Start with ["Why isn't my license plate being detected and recognized?"](#why-is
    - Watch the debug logs for messages from the YOLOv9 plate detector.
    - You may need to adjust your `detection_threshold` if your plates are not being detected.
 
-3. Ensure the characters on detected plates are being _recognized_.
+4. Ensure the characters on detected plates are being _recognized_.
 
    - Enable `debug_save_plates` to save images of detected text on plates to the clips directory (`/media/frigate/clips/lpr`). Ensure these images are readable and the text is clear.
    - Watch the debug view to see plates recognized in real-time. For non-dedicated LPR cameras, the `car` or `motorcycle` label will change to the recognized plate when LPR is enabled and working.

docs/docs/frigate/installation.md

@@ -135,6 +135,7 @@ Finally, configure [hardware object detection](/configuration/object_detectors#h
 ### MemryX MX3
 
 The MemryX MX3 Accelerator is available in the M.2 2280 form factor (like an NVMe SSD), and supports a variety of configurations:
+
 - x86 (Intel/AMD) PCs
 - Raspberry Pi 5
 - Orange Pi 5 Plus/Max
@@ -142,7 +143,6 @@ The MemryX MX3 Accelerator is available in the M.2 2280 form factor (like an NVM
 
 #### Configuration
 
-
 #### Installation
 
 To get started with MX3 hardware setup for your system, refer to the [Hardware Setup Guide](https://developer.memryx.com/get_started/hardware_setup.html).
@@ -156,7 +156,7 @@ Then follow these steps for installing the correct driver/runtime configuration:
 
 #### Setup
 
-To set up Frigate, follow the default installation instructions, for example:   `ghcr.io/blakeblackshear/frigate:stable`
+To set up Frigate, follow the default installation instructions, for example: `ghcr.io/blakeblackshear/frigate:stable`
 
 Next, grant Docker permissions to access your hardware by adding the following lines to your `docker-compose.yml` file:
 
@@ -173,7 +173,7 @@ In your `docker-compose.yml`, also add:
 privileged: true
 
 volumes:
-    /run/mxa_manager:/run/mxa_manager
+  - /run/mxa_manager:/run/mxa_manager
 ```
 
 If you can't use Docker Compose, you can run the container with something similar to this:
@@ -411,7 +411,7 @@ To install make sure you have the [community app plugin here](https://forums.unr
 
 ## Proxmox
 
-[According to Proxmox documentation](https://pve.proxmox.com/pve-docs/pve-admin-guide.html#chapter_pct) it is recommended that you run application containers like Frigate inside a Proxmox QEMU VM. This will give you all the advantages of application containerization, while also providing the benefits that VMs offer, such as strong isolation from the host and the ability to live-migrate, which otherwise isn’t possible with containers.
+[According to Proxmox documentation](https://pve.proxmox.com/pve-docs/pve-admin-guide.html#chapter_pct) it is recommended that you run application containers like Frigate inside a Proxmox QEMU VM. This will give you all the advantages of application containerization, while also providing the benefits that VMs offer, such as strong isolation from the host and the ability to live-migrate, which otherwise isn’t possible with containers. Ensure that ballooning is **disabled**, especially if you are passing through a GPU to the VM.
 
 :::warning
 

web/public/locales/en/views/events.json

@@ -52,6 +52,7 @@
   },
   "selected_one": "{{count}} selected",
   "selected_other": "{{count}} selected",
+  "select_all": "All",
   "camera": "Camera",
   "detected": "detected",
   "normalActivity": "Normal",

web/public/locales/en/views/faceLibrary.json

@@ -29,6 +29,7 @@
   },
   "train": {
     "title": "Recent Recognitions",
+    "titleShort": "Recent",
     "aria": "Select recent recognitions",
     "empty": "There are no recent face recognition attempts"
   },

web/src/components/card/ClassificationCard.tsx

@@ -7,7 +7,7 @@ import {
 } from "@/types/classification";
 import { Event } from "@/types/event";
 import { forwardRef, useMemo, useRef, useState } from "react";
-import { isDesktop, isMobile, isMobileOnly } from "react-device-detect";
+import { isDesktop, isIOS, isMobile, isMobileOnly } from "react-device-detect";
 import { useTranslation } from "react-i18next";
 import TimeAgo from "../dynamic/TimeAgo";
 import { Tooltip, TooltipContent, TooltipTrigger } from "../ui/tooltip";
@@ -127,6 +127,15 @@ export const ClassificationCard = forwardRef<
           imgClassName,
           isMobile && "w-full",
         )}
+        style={
+          isIOS
+            ? {
+                WebkitUserSelect: "none",
+                WebkitTouchCallout: "none",
+              }
+            : undefined
+        }
+        draggable={false}
         loading="lazy"
         onLoad={() => setImageLoaded(true)}
         src={`${baseUrl}${data.filepath}`}

web/src/components/filter/ReviewActionGroup.tsx

@@ -19,6 +19,7 @@ import {
 import useKeyboardListener from "@/hooks/use-keyboard-listener";
 import { Trans, useTranslation } from "react-i18next";
 import { toast } from "sonner";
+import { useIsAdmin } from "@/hooks/use-is-admin";
 
 type ReviewActionGroupProps = {
   selectedReviews: ReviewSegment[];
@@ -33,6 +34,7 @@ export default function ReviewActionGroup({
   pullLatestData,
 }: ReviewActionGroupProps) {
   const { t } = useTranslation(["components/dialog"]);
+  const isAdmin = useIsAdmin();
   const onClearSelected = useCallback(() => {
     setSelectedReviews([]);
   }, [setSelectedReviews]);
@@ -185,21 +187,23 @@ export default function ReviewActionGroup({
               </div>
             )}
           </Button>
-          <Button
+          {isAdmin && (
-            className="flex items-center gap-2 p-2"
+            <Button
-            aria-label={t("button.delete", { ns: "common" })}
+              className="flex items-center gap-2 p-2"
-            size="sm"
+              aria-label={t("button.delete", { ns: "common" })}
-            onClick={handleDelete}
+              size="sm"
-          >
+              onClick={handleDelete}
-            <HiTrash className="text-secondary-foreground" />
+            >
-            {isDesktop && (
+              <HiTrash className="text-secondary-foreground" />
-              <div className="text-primary">
+              {isDesktop && (
-                {bypassDialog
+                <div className="text-primary">
-                  ? t("recording.button.deleteNow")
+                  {bypassDialog
-                  : t("button.delete", { ns: "common" })}
+                    ? t("recording.button.deleteNow")
-              </div>
+                    : t("button.delete", { ns: "common" })}
-            )}
+                </div>
-          </Button>
+              )}
+            </Button>
+          )}
         </div>
       </div>
     </>

web/src/components/filter/SearchActionGroup.tsx

@@ -16,18 +16,24 @@ import {
 import useKeyboardListener from "@/hooks/use-keyboard-listener";
 import { toast } from "sonner";
 import { Trans, useTranslation } from "react-i18next";
+import { useIsAdmin } from "@/hooks/use-is-admin";
 
 type SearchActionGroupProps = {
   selectedObjects: string[];
   setSelectedObjects: (ids: string[]) => void;
   pullLatestData: () => void;
+  onSelectAllObjects: () => void;
+  totalItems: number;
 };
 export default function SearchActionGroup({
   selectedObjects,
   setSelectedObjects,
   pullLatestData,
+  onSelectAllObjects,
+  totalItems,
 }: SearchActionGroupProps) {
   const { t } = useTranslation(["components/filter"]);
+  const isAdmin = useIsAdmin();
   const onClearSelected = useCallback(() => {
     setSelectedObjects([]);
   }, [setSelectedObjects]);
@@ -122,24 +128,37 @@ export default function SearchActionGroup({
           >
             {t("button.unselect", { ns: "common" })}
           </div>
-        </div>
+          {selectedObjects.length < totalItems && (
-        <div className="flex items-center gap-1 md:gap-2">
+            <>
-          <Button
+              <div className="p-1">{"|"}</div>
-            className="flex items-center gap-2 p-2"
+              <div
-            aria-label={t("button.delete", { ns: "common" })}
+                className="cursor-pointer p-2 text-primary hover:rounded-lg hover:bg-secondary"
-            size="sm"
+                onClick={onSelectAllObjects}
-            onClick={handleDelete}
+              >
-          >
+                {t("select_all", { ns: "views/events" })}
-            <HiTrash className="text-secondary-foreground" />
-            {isDesktop && (
-              <div className="text-primary">
-                {bypassDialog
-                  ? t("button.deleteNow", { ns: "common" })
-                  : t("button.delete", { ns: "common" })}
               </div>
-            )}
+            </>
-          </Button>
+          )}
         </div>
+        {isAdmin && (
+          <div className="flex items-center gap-1 md:gap-2">
+            <Button
+              className="flex items-center gap-2 p-2"
+              aria-label={t("button.delete", { ns: "common" })}
+              size="sm"
+              onClick={handleDelete}
+            >
+              <HiTrash className="text-secondary-foreground" />
+              {isDesktop && (
+                <div className="text-primary">
+                  {bypassDialog
+                    ? t("button.deleteNow", { ns: "common" })
+                    : t("button.delete", { ns: "common" })}
+                </div>
+              )}
+            </Button>
+          </div>
+        )}
       </div>
     </>
   );

web/src/components/menu/SearchResultActions.tsx

@@ -31,6 +31,7 @@ import {
 import useSWR from "swr";
 import { Trans, useTranslation } from "react-i18next";
 import BlurredIconButton from "../button/BlurredIconButton";
+import { useIsAdmin } from "@/hooks/use-is-admin";
 
 type SearchResultActionsProps = {
   searchResult: SearchResult;
@@ -52,6 +53,7 @@ export default function SearchResultActions({
   children,
 }: SearchResultActionsProps) {
   const { t } = useTranslation(["views/explore"]);
+  const isAdmin = useIsAdmin();
 
   const { data: config } = useSWR<FrigateConfig>("config");
 
@@ -137,7 +139,8 @@ export default function SearchResultActions({
             <span>{t("itemMenu.findSimilar.label")}</span>
           </MenuItem>
         )}
-      {config?.semantic_search?.enabled &&
+      {isAdmin &&
+        config?.semantic_search?.enabled &&
         searchResult.data.type == "object" && (
           <MenuItem
             aria-label={t("itemMenu.addTrigger.aria")}
@@ -146,12 +149,14 @@ export default function SearchResultActions({
             <span>{t("itemMenu.addTrigger.label")}</span>
           </MenuItem>
         )}
-      <MenuItem
+      {isAdmin && (
-        aria-label={t("itemMenu.deleteTrackedObject.label")}
+        <MenuItem
-        onClick={() => setDeleteDialogOpen(true)}
+          aria-label={t("itemMenu.deleteTrackedObject.label")}
-      >
+          onClick={() => setDeleteDialogOpen(true)}
-        <span>{t("button.delete", { ns: "common" })}</span>
+        >
-      </MenuItem>
+          <span>{t("button.delete", { ns: "common" })}</span>
+        </MenuItem>
+      )}
     </>
   );
 
@@ -184,7 +189,7 @@ export default function SearchResultActions({
         </AlertDialogContent>
       </AlertDialog>
       {isContextMenu ? (
-        <ContextMenu>
+        <ContextMenu modal={false}>
           <ContextMenuTrigger>{children}</ContextMenuTrigger>
           <ContextMenuContent>{menuItems}</ContextMenuContent>
         </ContextMenu>

web/src/components/overlay/detail/AnnotationOffsetSlider.tsx

@@ -10,6 +10,7 @@ import { Trans, useTranslation } from "react-i18next";
 import { LuInfo } from "react-icons/lu";
 import { cn } from "@/lib/utils";
 import { isMobile } from "react-device-detect";
+import { useIsAdmin } from "@/hooks/use-is-admin";
 
 type Props = {
   className?: string;
@@ -17,6 +18,7 @@ type Props = {
 
 export default function AnnotationOffsetSlider({ className }: Props) {
   const { annotationOffset, setAnnotationOffset, camera } = useDetailStream();
+  const isAdmin = useIsAdmin();
   const { mutate } = useSWRConfig();
   const { t } = useTranslation(["views/explore"]);
   const [isSaving, setIsSaving] = useState(false);
@@ -101,11 +103,13 @@ export default function AnnotationOffsetSlider({ className }: Props) {
           <Button size="sm" variant="ghost" onClick={reset}>
             {t("button.reset", { ns: "common" })}
           </Button>
-          <Button size="sm" onClick={save} disabled={isSaving}>
+          {isAdmin && (
-            {isSaving
+            <Button size="sm" onClick={save} disabled={isSaving}>
-              ? t("button.saving", { ns: "common" })
+              {isSaving
-              : t("button.save", { ns: "common" })}
+                ? t("button.saving", { ns: "common" })
-          </Button>
+                : t("button.save", { ns: "common" })}
+            </Button>
+          )}
         </div>
       </div>
       <div

web/src/components/overlay/detail/AnnotationSettingsPane.tsx

@@ -24,6 +24,7 @@ import { Input } from "@/components/ui/input";
 import { Separator } from "@/components/ui/separator";
 import { Trans, useTranslation } from "react-i18next";
 import { useDocDomain } from "@/hooks/use-doc-domain";
+import { useIsAdmin } from "@/hooks/use-is-admin";
 
 type AnnotationSettingsPaneProps = {
   event: Event;
@@ -36,6 +37,7 @@ export function AnnotationSettingsPane({
   setAnnotationOffset,
 }: AnnotationSettingsPaneProps) {
   const { t } = useTranslation(["views/explore"]);
+  const isAdmin = useIsAdmin();
   const { getLocaleDocUrl } = useDocDomain();
 
   const { data: config, mutate: updateConfig } =
@@ -201,22 +203,24 @@ export function AnnotationSettingsPane({
               >
                 {t("button.apply", { ns: "common" })}
               </Button>
-              <Button
+              {isAdmin && (
-                variant="select"
+                <Button
-                aria-label={t("button.save", { ns: "common" })}
+                  variant="select"
-                disabled={isLoading}
+                  aria-label={t("button.save", { ns: "common" })}
-                className="flex flex-1"
+                  disabled={isLoading}
-                type="submit"
+                  className="flex flex-1"
-              >
+                  type="submit"
-                {isLoading ? (
+                >
-                  <div className="flex flex-row items-center gap-2">
+                  {isLoading ? (
-                    <ActivityIndicator />
+                    <div className="flex flex-row items-center gap-2">
-                    <span>{t("button.saving", { ns: "common" })}</span>
+                      <ActivityIndicator />
-                  </div>
+                      <span>{t("button.saving", { ns: "common" })}</span>
-                ) : (
+                    </div>
-                  t("button.save", { ns: "common" })
+                  ) : (
-                )}
+                    t("button.save", { ns: "common" })
-              </Button>
+                  )}
+                </Button>
+              )}
             </div>
           </div>
         </form>

web/src/components/overlay/detail/DetailActionsMenu.tsx

@@ -15,6 +15,7 @@ import {
 import { HiDotsHorizontal } from "react-icons/hi";
 import { SearchResult } from "@/types/search";
 import { FrigateConfig } from "@/types/frigateConfig";
+import { useIsAdmin } from "@/hooks/use-is-admin";
 
 type Props = {
   search: SearchResult | Event;
@@ -35,6 +36,7 @@ export default function DetailActionsMenu({
   const { t } = useTranslation(["views/explore", "views/faceLibrary"]);
   const navigate = useNavigate();
   const [isOpen, setIsOpen] = useState(false);
+  const isAdmin = useIsAdmin();
 
   const clipTimeRange = useMemo(() => {
     const startTime = (search.start_time ?? 0) - REVIEW_PADDING;
@@ -130,22 +132,24 @@ export default function DetailActionsMenu({
             </DropdownMenuItem>
           )}
 
-          {config?.semantic_search.enabled && search.data.type == "object" && (
+          {isAdmin &&
-            <DropdownMenuItem
+            config?.semantic_search.enabled &&
-              onClick={() => {
+            search.data.type == "object" && (
-                setIsOpen(false);
+              <DropdownMenuItem
-                setTimeout(() => {
+                onClick={() => {
-                  navigate(
+                  setIsOpen(false);
-                    `/settings?page=triggers&camera=${search.camera}&event_id=${search.id}`,
+                  setTimeout(() => {
-                  );
+                    navigate(
-                }, 0);
+                      `/settings?page=triggers&camera=${search.camera}&event_id=${search.id}`,
-              }}
+                    );
-            >
+                  }, 0);
-              <div className="flex cursor-pointer items-center gap-2">
+                }}
-                <span>{t("itemMenu.addTrigger.label")}</span>
+              >
-              </div>
+                <div className="flex cursor-pointer items-center gap-2">
-            </DropdownMenuItem>
+                  <span>{t("itemMenu.addTrigger.label")}</span>
-          )}
+                </div>
+              </DropdownMenuItem>
+            )}
         </DropdownMenuContent>
       </DropdownMenuPortal>
     </DropdownMenu>

web/src/components/overlay/dialog/TrainFilterDialog.tsx

@@ -97,20 +97,9 @@ export default function TrainFilterDialog({
         <Button
           aria-label={t("reset.label")}
           onClick={() => {
-            setCurrentFilter((prevFilter) => ({
+            const resetFilter: TrainFilter = {};
-              ...prevFilter,
+            setCurrentFilter(resetFilter);
-              time_range: undefined,
+            onUpdateFilter(resetFilter);
-              zones: undefined,
-              sub_labels: undefined,
-              search_type: undefined,
-              min_score: undefined,
-              max_score: undefined,
-              min_speed: undefined,
-              max_speed: undefined,
-              has_snapshot: undefined,
-              has_clip: undefined,
-              recognized_license_plate: undefined,
-            }));
           }}
         >
           {t("button.reset", { ns: "common" })}

web/src/pages/FaceLibrary.tsx

@@ -52,7 +52,7 @@ import {
   useRef,
   useState,
 } from "react";
-import { isDesktop } from "react-device-detect";
+import { isDesktop, isMobileOnly } from "react-device-detect";
 import { Trans, useTranslation } from "react-i18next";
 import {
   LuFolderCheck,
@@ -370,10 +370,10 @@ export default function FaceLibrary() {
         />
         {selectedFaces?.length > 0 ? (
           <div className="flex items-center justify-center gap-2">
-            <div className="mx-1 flex w-48 items-center justify-center text-sm text-muted-foreground">
+            <div className="mx-1 flex w-auto items-center justify-center text-sm text-muted-foreground">
               <div className="p-1">
                 {t("selected", {
-                  ns: "views/event",
+                  ns: "views/events",
                   count: selectedFaces.length,
                 })}
               </div>
@@ -384,6 +384,24 @@ export default function FaceLibrary() {
               >
                 {t("button.unselect", { ns: "common" })}
               </div>
+              {selectedFaces.length <
+                (pageToggle === "train"
+                  ? trainImages.length
+                  : faceImages.length) && (
+                <>
+                  <div className="p-1">{"|"}</div>
+                  <div
+                    className="cursor-pointer p-2 text-primary hover:rounded-lg hover:bg-secondary"
+                    onClick={() =>
+                      setSelectedFaces([
+                        ...(pageToggle === "train" ? trainImages : faceImages),
+                      ])
+                    }
+                  >
+                    {t("select_all", { ns: "views/events" })}
+                  </div>
+                </>
+              )}
             </div>
             <Button
               className="flex gap-2"
@@ -482,6 +500,18 @@ function LibrarySelector({
     [renameFace],
   );
 
+  const pageTitle = useMemo(() => {
+    if (pageToggle != "train") {
+      return pageToggle;
+    }
+
+    if (isMobileOnly) {
+      return t("train.titleShort");
+    }
+
+    return t("train.title");
+  }, [pageToggle, t]);
+
   return (
     <>
       <Dialog
@@ -532,7 +562,7 @@ function LibrarySelector({
       <DropdownMenu modal={false}>
         <DropdownMenuTrigger asChild>
           <Button className="flex justify-between smart-capitalize">
-            {pageToggle == "train" ? t("train.title") : pageToggle}
+            {pageTitle}
             <span className="ml-2 text-primary-variant">
               ({(pageToggle && faceData?.[pageToggle]?.length) || 0})
             </span>

web/src/views/classification/ModelTrainingView.tsx

@@ -421,10 +421,10 @@ export default function ModelTrainingView({ model }: ModelTrainingViewProps) {
               isMobileOnly && "justify-between",
             )}
           >
-            <div className="flex w-48 items-center justify-center text-sm text-muted-foreground">
+            <div className="flex w-auto items-center justify-center text-sm text-muted-foreground md:w-auto">
               <div className="p-1">
                 {t("selected", {
-                  ns: "views/event",
+                  ns: "views/events",
                   count: selectedImages.length,
                 })}
               </div>
@@ -435,6 +435,26 @@ export default function ModelTrainingView({ model }: ModelTrainingViewProps) {
               >
                 {t("button.unselect", { ns: "common" })}
               </div>
+              {selectedImages.length <
+                (pageToggle === "train"
+                  ? trainImages?.length || 0
+                  : dataset?.[pageToggle]?.length || 0) && (
+                <>
+                  <div className="p-1">{"|"}</div>
+                  <div
+                    className="cursor-pointer p-2 text-primary hover:rounded-lg hover:bg-secondary"
+                    onClick={() =>
+                      setSelectedImages([
+                        ...(pageToggle === "train"
+                          ? trainImages || []
+                          : dataset?.[pageToggle] || []),
+                      ])
+                    }
+                  >
+                    {t("select_all", { ns: "views/events" })}
+                  </div>
+                </>
+              )}
             </div>
             <Button
               className="flex gap-2"

web/src/views/search/SearchView.tsx

@@ -572,6 +572,8 @@ export default function SearchView({
                     selectedObjects={selectedObjects}
                     setSelectedObjects={setSelectedObjects}
                     pullLatestData={refresh}
+                    onSelectAllObjects={onSelectAllObjects}
+                    totalItems={uniqueResults.length}
                   />
                 </div>
               )}