Merge c238e62ad7 into f448b259a2

docker/rocm/Dockerfile

@@ -13,7 +13,7 @@ ARG ROCM
 
 RUN apt update -qq && \
     apt install -y wget gpg && \
-    wget -O rocm.deb https://repo.radeon.com/amdgpu-install/7.2.3/ubuntu/jammy/amdgpu-install_7.2.3.70203-1_all.deb && \
+    wget -O rocm.deb https://repo.radeon.com/amdgpu-install/7.2/ubuntu/jammy/amdgpu-install_7.2.70200-1_all.deb && \
     apt install -y ./rocm.deb && \
     apt update && \
     apt install -qq -y rocm
@@ -78,10 +78,6 @@ ENV MIGRAPHX_DISABLE_MIOPEN_FUSION=1
 ENV MIGRAPHX_DISABLE_SCHEDULE_PASS=1
 ENV MIGRAPHX_DISABLE_REDUCE_FUSION=1
 ENV MIGRAPHX_ENABLE_HIPRTC_WORKAROUNDS=1
-ENV MIOPEN_CUSTOM_CACHE_DIR=/config/model_cache/migraphx
-ENV MIOPEN_USER_DB_PATH=/config/model_cache/migraphx
-ENV AMD_COMGR_CACHE=1
-ENV AMD_COMGR_CACHE_DIR=/config/model_cache/migraphx
 
 COPY --from=rocm-dist / /
 

docker/rocm/requirements-wheels-rocm.txt

@@ -1 +1 @@
-onnxruntime-migraphx @ https://github.com/NickM-27/frigate-onnxruntime-rocm/releases/download/v7.2.3-1/onnxruntime_migraphx-1.24.4-cp311-cp311-linux_x86_64.whl
+onnxruntime-migraphx @ https://github.com/NickM-27/frigate-onnxruntime-rocm/releases/download/v7.2.0/onnxruntime_migraphx-1.23.1-cp311-cp311-linux_x86_64.whl

docker/rocm/rocm.hcl

@@ -1,5 +1,5 @@
 variable "ROCM" {
-  default = "7.2.3"
+  default = "7.2.0"
 }
 variable "HSA_OVERRIDE_GFX_VERSION" {
   default = ""

docs/docs/configuration/object_detectors.md

@@ -1022,12 +1022,12 @@ detectors:
 
 ### ONNX Supported Models
 
-| Model                                | Nvidia GPU | AMD GPU | Notes                                               |
-| ------------------------------------ | ---------- | ------- | --------------------------------------------------- |
-| [YOLOv9](#yolo-v3-v4-v7-v9-2)        | ✅         | ✅      | Supports CUDA Graphs for optimal Nvidia performance |
-| [RF-DETR](#rf-detr)                  | ✅         | ⚠️      | Supports CUDA Graphs for optimal Nvidia performance |
-| [YOLO-NAS](#yolo-nas-1)              | ⚠️         | ⚠️      | Not supported by CUDA Graphs                        |
-| [YOLOX](#yolox-1)                    | ✅         | ✅      | Supports CUDA Graphs for optimal Nvidia performance |
+| Model                         | Nvidia GPU | AMD GPU | Notes                                               |
+| ----------------------------- | ---------- | ------- | --------------------------------------------------- |
+| [YOLOv9](#yolo-v3-v4-v7-v9-2) | ✅         | ✅      | Supports CUDA Graphs for optimal Nvidia performance |
+| [RF-DETR](#rf-detr)           | ✅         | ❌      | Supports CUDA Graphs for optimal Nvidia performance |
+| [YOLO-NAS](#yolo-nas-1)       | ⚠️         | ⚠️      | Not supported by CUDA Graphs                        |
+| [YOLOX](#yolox-1)             | ✅         | ✅      | Supports CUDA Graphs for optimal Nvidia performance |
 | [D-FINE / DEIMv2](#d-fine--deimv2-1) | ⚠️         | ❌      | Not supported by CUDA Graphs                        |
 
 There is no default model provided, the following formats are supported:

docs/docs/frigate/hardware.md

@@ -223,11 +223,10 @@ Apple Silicon can not run within a container, so a ZMQ proxy is utilized to comm
 
 With the [ROCm](../configuration/object_detectors.md#amdrocm-gpu-detector) detector Frigate can take advantage of many discrete AMD GPUs.
 
-| Name           | YOLOv9 Inference Time       | YOLO-NAS Inference Time   | RF-DETR Inference Time |
-| -------------- | --------------------------- | ------------------------- | ---------------------- |
-| AMD 780M       | t-320: ~ 14 ms s-320: 20 ms | 320: ~ 25 ms 640: ~ 50 ms |                        |
-| AMD 8700G      |                             | 320: ~ 20 ms 640: ~ 40 ms |                        |
-| AMD 9060XT 16G | t-320: ~ 4 ms  s-320: 5 ms  | 320: ~ 6 ms               | Nano-320: ~ 90 ms      |
+| Name      | YOLOv9 Inference Time       | YOLO-NAS Inference Time   |
+| --------- | --------------------------- | ------------------------- |
+| AMD 780M  | t-320: ~ 14 ms s-320: 20 ms | 320: ~ 25 ms 640: ~ 50 ms |
+| AMD 8700G |                             | 320: ~ 20 ms 640: ~ 40 ms |
 
 ## Community Supported Detectors
 

frigate/api/auth.py

@@ -812,11 +812,6 @@ limiter = Limiter(key_func=get_remote_addr)
 )
 @limiter.limit(limit_value=rateLimiter.get_limit)
 def login(request: Request, body: AppPostLoginBody):
-    if not request.app.frigate_config.auth.enabled:
-        return JSONResponse(
-            content={"message": "Authentication is disabled"}, status_code=404
-        )
-
     JWT_COOKIE_NAME = request.app.frigate_config.auth.cookie_name
     JWT_COOKIE_SECURE = request.app.frigate_config.auth.cookie_secure
     JWT_SESSION_LENGTH = request.app.frigate_config.auth.session_length

frigate/data_processing/real_time/face.py

@@ -229,10 +229,9 @@ class FaceRealTimeProcessor(RealTimeProcessorApi):
                 logger.debug(f"No person box available for {id}")
                 return
 
-            # YuNet (cv2.FaceDetectorYN) is trained on BGR
-            bgr = cv2.cvtColor(frame, cv2.COLOR_YUV2BGR_I420)
+            rgb = cv2.cvtColor(frame, cv2.COLOR_YUV2RGB_I420)
             left, top, right, bottom = person_box
-            person = bgr[top:bottom, left:right]
+            person = rgb[top:bottom, left:right]
             face_box = self.__detect_face(person, self.face_config.detection_threshold)
 
             if not face_box:
@@ -251,6 +250,11 @@ class FaceRealTimeProcessor(RealTimeProcessorApi):
                 )
                 return
 
+            try:
+                face_frame = cv2.cvtColor(face_frame, cv2.COLOR_RGB2BGR)
+            except Exception as e:
+                logger.debug(f"Failed to convert face frame color for {id}: {e}")
+                return
         else:
             # don't run for object without attributes
             if not obj_data.get("current_attributes"):

frigate/detectors/detection_runners.py

@@ -132,6 +132,7 @@ class ONNXModelRunner(BaseModelRunner):
         return model_type in [
             EnrichmentModelTypeEnum.paddleocr.value,
             EnrichmentModelTypeEnum.jina_v2.value,
+            EnrichmentModelTypeEnum.arcface.value,
             ModelTypeEnum.rfdetr.value,
             ModelTypeEnum.dfine.value,
         ]

web/src/components/config-form/theme/widgets/ObjectLabelSwitchesWidget.tsx

@@ -2,7 +2,7 @@
 import { WidgetProps } from "@rjsf/utils";
 import { SwitchesWidget } from "./SwitchesWidget";
 import { FormContext } from "./SwitchesWidget";
-import i18n, { getTranslatedLabel } from "@/utils/i18n";
+import { getTranslatedLabel } from "@/utils/i18n";
 import { FrigateConfig } from "@/types/frigateConfig";
 import { JsonObject } from "@/types/configForm";
 
@@ -76,12 +76,7 @@ function getObjectLabels(context: FormContext): string[] {
     ...sourceLabels,
     ...formDataLabels,
   ]);
-  return [...combinedLabels].sort((a, b) =>
-    getObjectLabelDisplayName(a).localeCompare(
-      getObjectLabelDisplayName(b),
-      i18n.language,
-    ),
-  );
+  return [...combinedLabels].sort();
 }
 
 function getObjectLabelDisplayName(label: string): string {
@@ -99,7 +94,6 @@ export function ObjectLabelSwitchesWidget(props: WidgetProps) {
         i18nKey: "objectLabels",
         listClassName:
           "relative max-h-none overflow-visible md:max-h-64 md:overflow-y-auto md:overscroll-contain md:scrollbar-container",
-        enableSearch: true,
       }}
     />
   );

web/src/views/settings/ProfilesView.tsx

@@ -7,20 +7,13 @@ import useSWR from "swr";
 import axios from "axios";
 import { toast } from "sonner";
 import { Pencil, Trash2 } from "lucide-react";
-import {
-  LuChevronDown,
-  LuChevronRight,
-  LuExternalLink,
-  LuPlus,
-} from "react-icons/lu";
-import { Link } from "react-router-dom";
+import { LuChevronDown, LuChevronRight, LuPlus } from "react-icons/lu";
 import type { FrigateConfig } from "@/types/frigateConfig";
 import type { JsonObject } from "@/types/configForm";
 import type { ProfileState, ProfilesApiResponse } from "@/types/profile";
 import { getProfileColor } from "@/utils/profileColors";
 import { PROFILE_ELIGIBLE_SECTIONS } from "@/utils/configUtil";
 import { resolveCameraName } from "@/hooks/use-camera-friendly-name";
-import { useDocDomain } from "@/hooks/use-doc-domain";
 import { cn } from "@/lib/utils";
 import Heading from "@/components/ui/heading";
 import { Button } from "@/components/ui/button";
@@ -73,7 +66,6 @@ export default function ProfilesView({
   setProfilesUIEnabled,
 }: ProfilesViewProps) {
   const { t } = useTranslation(["views/settings", "common"]);
-  const { getLocaleDocUrl } = useDocDomain();
   const { data: config, mutate: updateConfig } =
     useSWR<FrigateConfig>("config");
   const { data: profilesData, mutate: updateProfiles } =
@@ -368,17 +360,6 @@ export default function ProfilesView({
       <div className="my-1 text-sm text-muted-foreground">
         {t("profiles.disabledDescription", { ns: "views/settings" })}
       </div>
-      <div className="flex items-center text-sm text-primary-variant">
-        <Link
-          to={getLocaleDocUrl("configuration/profiles")}
-          target="_blank"
-          rel="noopener noreferrer"
-          className="inline"
-        >
-          {t("readTheDocumentation", { ns: "common" })}
-          <LuExternalLink className="ml-2 inline-flex size-3" />
-        </Link>
-      </div>
 
       {/* Enable Profiles Toggle — shown only when no profiles exist */}
       {!hasProfiles && setProfilesUIEnabled && (