Commit Graph

1567 Commits

Author SHA1 Message Date
Claude
067fdb50e1
fix: replace useResizeObserver with useLayoutEffect for reliable container width
useResizeObserver reads ref.current during render (before commit), so on
first render ref.current is null, no observation starts, and containerWidth
stays 0 if no subsequent re-render happens (e.g. page refresh with cached
SWR data). useLayoutEffect runs after refs are committed, so ref.current
is always the real DOM element.

This fixes both the right-column overflow (no window.innerWidth fallback
needed — width is always the actual container width) and the black screen
on refresh (containerWidth is reliable before the first paint).

https://claude.ai/code/session_01H1sqbcFmtwwsdNTJcJHJWd
2026-03-15 12:03:54 +00:00
Claude
5e40dbbcd2
fix: reliably init grid width on page refresh using useLayoutEffect
useResizeObserver reads ref.current at render time; on page refresh with
fast SWR cache, no re-render occurs after mount so ref.current remains null
in the effect, observation never starts, and containerWidth stays 0 forever.

Add a useLayoutEffect that measures offsetWidth synchronously before paint
as a seed value (effectiveWidth = containerWidth || initialWidth). Once
ResizeObserver fires normally, containerWidth takes over. The Responsive
grid is gated on effectiveWidth > 0 so it always renders correctly on both
first load and refresh.

https://claude.ai/code/session_01H1sqbcFmtwwsdNTJcJHJWd
2026-03-15 11:32:13 +00:00
Claude
d39590604f
fix: prevent grid right-edge overflow by gating Responsive on containerWidth
Gate <Responsive> rendering on containerWidth > 0 so it only mounts after
ResizeObserver has measured the container. Use availableWidth directly as
the width prop (no window.innerWidth fallback) since the component now only
renders when containerWidth is known. This prevents the grid from rendering
wider than its container (which caused the rightmost column to overflow the
right edge).

https://claude.ai/code/session_01H1sqbcFmtwwsdNTJcJHJWd
2026-03-15 11:03:26 +00:00
Claude
84f3b16461
Fix DraggableGridLayout initial height collapse due to nullish coalescing bug
availableWidth starts at 0 (not null/undefined) before ResizeObserver fires.
The ?? operator passes 0 through instead of falling back to window.innerWidth,
making cellHeight negative and causing react-grid-layout to render a ~10px
container. The overflow-x-hidden div then becomes an implicit scroll container,
producing the 'cards squeezed in a small rectangle' symptom.

Changing ?? to || makes 0 trigger the window.innerWidth fallback, giving a
reasonable initial rowHeight until the real container width is measured.

https://claude.ai/code/session_01H1sqbcFmtwwsdNTJcJHJWd
2026-03-15 10:15:52 +00:00
ibs0d
a0ca322129
revert Update RecordingView.tsx 2026-03-15 14:31:11 +11:00
ibs0d
86de033f74
Merge branch 'blakeblackshear:dev' into dev 2026-03-15 13:55:05 +11:00
ibs0d
0c78103e56
Revert "Claude/fix video stretch history ans qf" 2026-03-15 13:38:11 +11:00
ibs0d
14709511f0
Revert "Claude/fix video stretch history ans qf" 2026-03-15 13:37:31 +11:00
ibs0d
b6b3c970c2
Revert "Add config useSWR to DetectionReview component" 2026-03-15 13:36:49 +11:00
ibs0d
f35a257844
Update RecordingView.tsx 2026-03-14 16:34:48 +11:00
Claude
128f016b5a
Add config useSWR to DetectionReview component
config was referenced but not available in DetectionReview scope.

https://claude.ai/code/session_01EwdaKGsrRLZ74smmCQ1MgW
2026-03-14 04:08:12 +00:00
Claude
0dd59b1409
Fix review card aspect ratio using camera's actual detect dimensions
Hard-coded aspect-video (16:9) caused stretching for non-16:9 cameras.
Now uses camera detect.width/detect.height from config, falling back to 16:9.

https://claude.ai/code/session_01EwdaKGsrRLZ74smmCQ1MgW
2026-03-13 21:13:55 +00:00
Claude
6cb31d1f96
Fix review page preview video stretch by adding object-contain
VideoPreview's <video> had aspect-video + size-full, but size-full overrides
the aspect-ratio constraint, leaving object-fit at the default fill.
Adding object-contain preserves the video's natural aspect ratio in event cards.

https://claude.ai/code/session_01EwdaKGsrRLZ74smmCQ1MgW
2026-03-13 11:57:56 +00:00
Claude
abcb31e30c
Fix History preview video stretch by adding object-contain
PreviewVideoPlayer's <video> had no explicit object-fit, so browsers
applied the CSS default (fill), stretching the video when the container
aspect ratio (detect resolution) didn't match the actual preview video.
Adding object-contain preserves aspect ratio in the recording/history view.

https://claude.ai/code/session_01EwdaKGsrRLZ74smmCQ1MgW
2026-03-13 11:39:52 +00:00
Claude
93a5f2691c
Use fill object-fit in draggable grid, contain elsewhere
Grid tiles explicitly set --frigate-mse-object-fit:fill so video stretches
to fill the card without preserving aspect ratio. The MsePlayer default
is contain, so History preview and all other contexts keep correct proportions.

https://claude.ai/code/session_01EwdaKGsrRLZ74smmCQ1MgW
2026-03-13 11:24:08 +00:00
Claude
b400bd4b96
Fix History preview video stretch by restoring contain as default object-fit
The MSE player default was set to 'fill' which stretches video in all contexts.
Only the draggable grid should use 'cover' (via --frigate-mse-object-fit:cover).
Changing the fallback to 'contain' restores aspect-ratio-preserving behaviour
everywhere else (History preview, etc.) while keeping the grid fill intact.

https://claude.ai/code/session_01EwdaKGsrRLZ74smmCQ1MgW
2026-03-13 11:20:52 +00:00
Josh Hawkins
324953d3a5
UI tweaks (#22405)
Some checks failed
CI / AMD64 Build (push) Has been cancelled
CI / ARM Build (push) Has been cancelled
CI / Jetson Jetpack 6 (push) Has been cancelled
CI / ARM Extra Build (push) Has been cancelled
CI / Synaptics Build (push) Has been cancelled
CI / AMD64 Extra Build (push) Has been cancelled
CI / Assemble and push default build (push) Has been cancelled
* add shm frame lifetime calculation and update UI for shared memory metrics

* consistent sizing on activity indicator in save buttons

* fix offline overlay overflowing on mobile when in grid mode
2026-03-12 16:57:42 -06:00
Josh Hawkins
192aba901a
Replace react-tracked and react-use-websocket with useSyncExternalStore (#22386)
Some checks are pending
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / Jetson Jetpack 6 (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
* refactor websockets to remove react-tracked

react 19 removed useReducer eager bailout, which broke react-tracked.

react-tracked works by wrapping state in a JavaScript Proxy. When a component reads state.someField, the proxy records that access. On the next state update, it compares only the fields each component actually touched and skips re-renders if those fields are unchanged. Under the hood, this relies on useReducer — and in React 18, useReducer had an "eager bail-out" that short-circuited rendering when the new state was === to the old state. React 19 removed that optimization, so every dispatch now schedules a render regardless, and the proxy comparison runs too late to prevent it.

useSyncExternalStore is a React primitive (added in 18, stable in 19) designed for exactly this pattern: subscribing to an external store:

useSyncExternalStore(
  subscribe,   // (listener) => unsubscribe — called when the store changes
  getSnapshot  // () => value — returns the current value for this subscriber
)

React calls getSnapshot during render and compares the result with Object.is. If the value is the same reference, the component bails out — no re-render. The key difference from react-tracked is that this bail-out is built into React's reconciler, not bolted on via proxy tricks and useReducer.

The per-topic subscription model makes this efficient. Instead of one global store where every subscriber has to check if their fields changed, each useWs("some/topic", ...) call subscribes only to that topic's listener set. When a message arrives for front_door/detect/state, only components subscribed to that exact topic get their listener fired → React calls their getSnapshot → Object.is compares the value → bail-out if unchanged. Components watching back_yard/detect/state are never even notified.

* remove react-tracked and react-use-websocket

* refactor usePolygonStates to use ws topic subscription

* fix TimeAgo refresh interval always returning 1s due to unit mismatch (seconds vs milliseconds)

older events now correctly refresh every minute/hour instead of every second

* simplify

* clean up

* don't resend onconnect

* clean up

* remove patch
2026-03-11 09:02:51 -05:00
Josh Hawkins
e8b9225175
Recordings API and calendar UI performance improvements (#22352)
Some checks are pending
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / Jetson Jetpack 6 (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
* optimize recordings/summary endpoint db query

replace strftime with integer arithmetic. increases speed by about 6x, especially noticeable for installs with long retention days

* optimize calendar rendering with Set lookups and remove unnecessary remount key

The old code built Date[] arrays with a TZDate object for every day in recording history (365+ timezone-aware date constructions). react-day-picker then did O(visible × history) date comparisons to match each of the displayed days against these arrays. Now we build Set<string> from the raw keys (zero date construction), and pass matcher functions that do O(1) Set.has() lookups. react-day-picker only calls these for visible days

* clean up
2026-03-09 17:22:01 -06:00
Josh Hawkins
9cbd80d981
Add motion previews filter (#22347)
* add ability to filter motion previews via heatmap grid

* i18n

* use dialog on mobile
2026-03-09 14:14:13 -06:00
ibs0d
c457428180 Fix grid zoom min-scale transform normalization 2026-03-09 15:53:12 +11:00
ibs0d
1e238d2fe2
Revert "Expose mediaContentStyle on LivePlayer and pass through to MSEPlayer and still image" 2026-03-09 15:34:41 +11:00
ibs0d
078b6f62a7 Revert non-MSE style props from live players 2026-03-09 15:07:43 +11:00
ibs0d
626c05179e Restore live grid card zoom at grid layout layer 2026-03-09 14:15:46 +11:00
ibs0d
171688445d Revert LivePlayer transform wrapper regression 2026-03-09 13:57:16 +11:00
ibs0d
534b6ced19 Fix passive wheel listener for live grid card zoom 2026-03-09 12:47:39 +11:00
ibs0d
6940713054 Fix grid live zoom so overlays stay anchored 2026-03-09 12:14:05 +11:00
ibs0d
7969930d21 Persist per-camera live grid zoom state 2026-03-09 11:37:28 +11:00
ibs0d
bf622d5ff7 Add independent shift+wheel zoom for draggable live cards 2026-03-09 10:48:58 +11:00
ibs0d
046568ea6b Harden camera zoom helper restore and key namespace 2026-03-09 10:38:09 +11:00
ibs0d
1820f222ef
Revert "Add live zoom config and helpers for player/debug modes" 2026-03-09 10:16:46 +11:00
ibs0d
6ddfbf3d46
Revert "refactor(live): use shared live-zoom helpers in LiveCameraView" 2026-03-09 10:16:17 +11:00
ibs0d
71327cd94a
Revert "Add cursor-relative shift-wheel zoom and refactor live zoom utilities" 2026-03-09 10:15:43 +11:00
Josh Hawkins
dd9497baf2
Add ability to delete cameras (#22336)
Some checks are pending
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / Jetson Jetpack 6 (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
* refactor camera cleanup code to generic util

* add api endpoint for deleting a camera

* frontend

* i18n

* clean up
2026-03-08 16:23:48 -06:00
Josh Hawkins
df27e04c0f
Frontend updates (#22327)
* add optional field widget

adds a switch to enable nullable fields like skip_motion_threshold

* config field updates

add skip_motion_threshold optional switch
add fps back to detect restart required

* don't use ternary operator when displaying motion previews

the main previews were being unnecessarily unmounted

* lazy mount motion preview clips to reduce DOM overhead
2026-03-08 12:27:53 -05:00
Nicolas Mowen
a705f254e5
Support using GenAI for embeddings / semantic search (#22323)
* Support GenAI for embeddings

* Add embed API support

* Add support for embedding via genai

* Basic docs

* undo

* Fix sending images

* Don't require download check

* Set model

* Handle emb correctly

* Clarification

* Cleanup

* Cleanup
2026-03-08 10:55:00 -05:00
ibs0d
de9878f5fd Clamp live zoom scale and align wheel coordinates to transform viewport 2026-03-08 23:48:37 +11:00
ibs0d
c9283f5990 refactor: use shared live zoom helpers in camera view 2026-03-08 23:31:00 +11:00
ibs0d
36e9c63e91 refactor(web): trim live zoom module to shared primitives only 2026-03-08 23:21:42 +11:00
ibs0d
e398ec5f03 Fix rotated MSE sizing in draggable live grid 2026-03-08 22:18:25 +11:00
ibs0d
3a0d71c47b
Update DraggableGridLayout.tsx 2026-03-08 21:25:46 +11:00
ibs0d
5ee023f5a4 Add grid-only MSE rotation for cameras with ui.rotate 2026-03-08 21:24:02 +11:00
ibs0d
52b14cabf3
Update DraggableGridLayout.tsx 2026-03-08 20:24:07 +11:00
ibs0d
937460abd0 Make draggable live grid MSE video use cover fit 2026-03-08 19:27:11 +11:00
ibs0d
3bc6f59e5e Simplify live grid camera tile sizing 2026-03-08 18:06:07 +11:00
ibs0d
931f1bfcc8 Add camera ui.rotate config/type plumbing 2026-03-08 17:49:11 +11:00
ibs0d
20c060ed8f
Revert "Add per-camera dashboard rotation and cover-fit support for live views" 2026-03-08 16:51:34 +11:00
ibs0d
63e847e3b3
Revert "Support dashboard rotate + cover-fit for camera tiles and players" 2026-03-08 16:50:19 +11:00
ibs0d
d6fced5e56
Revert "Fix dashboard live rendering and rotated cover fitting" 2026-03-08 16:48:17 +11:00
ibs0d
5aa80022ae Fix dashboard live rendering and rotated cover fitting 2026-03-08 16:26:56 +11:00