From fdc8e90c407247daac8843d18c380c1a286bc161 Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Wed, 8 Apr 2026 10:51:31 -0500 Subject: [PATCH] gate strict error mode on E2E_STRICT_ERRORS=1 --- web/e2e/fixtures/frigate-test.ts | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/web/e2e/fixtures/frigate-test.ts b/web/e2e/fixtures/frigate-test.ts index 1f1aa46eab..8fab574c1d 100644 --- a/web/e2e/fixtures/frigate-test.ts +++ b/web/e2e/fixtures/frigate-test.ts @@ -91,13 +91,24 @@ type FrigateFixtures = { export const test = base.extend({ expectedErrors: [[], { option: true }], - errorCollector: async ({ page, expectedErrors }, use) => { + errorCollector: async ({ page, expectedErrors }, use, testInfo) => { const collector = installErrorCollector(page, [ ...GLOBAL_ALLOWLIST, ...expectedErrors, ]); await use(collector); - collector.assertClean(); + if (process.env.E2E_STRICT_ERRORS === "1") { + collector.assertClean(); + } else if (collector.errors.length > 0) { + // Soft mode: attach errors to the test report so they're visible + // without failing the run. Used during the rollout phase. + await testInfo.attach("collected-errors.txt", { + body: collector.errors + .map((e) => `[${e.kind}] ${e.message}${e.url ? ` (${e.url})` : ""}`) + .join("\n"), + contentType: "text/plain", + }); + } }, frigateApp: async ({ page, errorCollector }, use, testInfo) => {