mirror of
https://github.com/blakeblackshear/frigate.git
synced 2026-03-19 22:58:22 +03:00
fix: operator precedence makes detection type check always true (#22471)
* fix: operator precedence bug in detection type check The condition: topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value evaluates as: (topic == DetectionTypeEnum.api.value) or (DetectionTypeEnum.lpr.value) Since DetectionTypeEnum.lpr.value is a non-empty string (truthy), the second operand is always True regardless of topic. The intended check is whether topic matches either enum value: topic == DetectionTypeEnum.api.value or topic == DetectionTypeEnum.lpr.value * fix: apply same or operator fix to review/maintainer.py Same issue as record/maintainer.py — the condition was always true because the bare enum value is truthy. * style: ruff format record/maintainer.py
This commit is contained in:
parent
2ace8d3670
commit
f658dbb158
@ -727,7 +727,8 @@ class RecordingMaintainer(threading.Thread):
|
|||||||
)
|
)
|
||||||
)
|
)
|
||||||
elif (
|
elif (
|
||||||
topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value
|
topic == DetectionTypeEnum.api.value
|
||||||
|
or topic == DetectionTypeEnum.lpr.value
|
||||||
):
|
):
|
||||||
continue
|
continue
|
||||||
|
|
||||||
|
|||||||
@ -642,7 +642,10 @@ class ReviewSegmentMaintainer(threading.Thread):
|
|||||||
_,
|
_,
|
||||||
audio_detections,
|
audio_detections,
|
||||||
) = data
|
) = data
|
||||||
elif topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value:
|
elif (
|
||||||
|
topic == DetectionTypeEnum.api.value
|
||||||
|
or topic == DetectionTypeEnum.lpr.value
|
||||||
|
):
|
||||||
(
|
(
|
||||||
camera,
|
camera,
|
||||||
frame_time,
|
frame_time,
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user