From eecc00865da368b6746ee24362545e7dcb56e615 Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Thu, 29 Jan 2026 10:07:31 -0600 Subject: [PATCH] tweaks --- frigate/config/camera/onvif.py | 2 +- frigate/config/classification.py | 4 ++-- web/public/locales/en/config/cameras.json | 2 +- .../locales/en/config/classification.json | 2 +- .../locales/en/config/face_recognition.json | 2 +- web/public/locales/en/config/onvif.json | 2 +- .../sections/CameraMqttSection.tsx | 5 +++++ .../config-form/sections/OnvifSection.tsx | 19 ++++++++++++++++--- .../config-form/sections/TimestampSection.tsx | 6 +++--- 9 files changed, 31 insertions(+), 13 deletions(-) diff --git a/frigate/config/camera/onvif.py b/frigate/config/camera/onvif.py index c546f9b04..c5f1e19f3 100644 --- a/frigate/config/camera/onvif.py +++ b/frigate/config/camera/onvif.py @@ -119,7 +119,7 @@ class OnvifConfig(FrigateBaseModel): ) autotracking: PtzAutotrackConfig = Field( default_factory=PtzAutotrackConfig, - title="PTZ config", + title="Autotracking", description="Automatically track moving objects and keep them centered in the frame using PTZ camera movements.", ) ignore_time_mismatch: bool = Field( diff --git a/frigate/config/classification.py b/frigate/config/classification.py index 0ed398145..ba9c2d72f 100644 --- a/frigate/config/classification.py +++ b/frigate/config/classification.py @@ -141,7 +141,7 @@ class CustomClassificationConfig(FrigateBaseModel): ) save_attempts: int | None = Field( default=None, - title="Saved attempts", + title="Save attempts", description="How many classification attempts to save for recent classifications UI.", ge=0, ) @@ -283,7 +283,7 @@ class FaceRecognitionConfig(FrigateBaseModel): save_attempts: int = Field( default=200, ge=0, - title="Saved attempts", + title="Save attempts", description="Number of face recognition attempts to retain for recent recognition UI.", ) blur_confidence_filter: bool = Field( diff --git a/web/public/locales/en/config/cameras.json b/web/public/locales/en/config/cameras.json index 0411f1228..69f9a2174 100644 --- a/web/public/locales/en/config/cameras.json +++ b/web/public/locales/en/config/cameras.json @@ -786,7 +786,7 @@ "description": "Skip TLS verification and disable digest auth for ONVIF (unsafe; use in safe networks only)." }, "autotracking": { - "label": "PTZ config", + "label": "Autotracking", "description": "Automatically track moving objects and keep them centered in the frame using PTZ camera movements.", "enabled": { "label": "Enable Autotracking", diff --git a/web/public/locales/en/config/classification.json b/web/public/locales/en/config/classification.json index 9a1effca8..b2e991fde 100644 --- a/web/public/locales/en/config/classification.json +++ b/web/public/locales/en/config/classification.json @@ -29,7 +29,7 @@ "description": "Score threshold used to change the classification state." }, "save_attempts": { - "label": "Saved attempts", + "label": "Save attempts", "description": "How many classification attempts to save for recent classifications UI." }, "object_config": { diff --git a/web/public/locales/en/config/face_recognition.json b/web/public/locales/en/config/face_recognition.json index 27954c62b..cb2e8b171 100644 --- a/web/public/locales/en/config/face_recognition.json +++ b/web/public/locales/en/config/face_recognition.json @@ -30,7 +30,7 @@ "description": "Minimum number of face recognitions required before applying a recognized sub-label to a person." }, "save_attempts": { - "label": "Saved attempts", + "label": "Save attempts", "description": "Number of face recognition attempts to retain for recent recognition UI." }, "blur_confidence_filter": { diff --git a/web/public/locales/en/config/onvif.json b/web/public/locales/en/config/onvif.json index 14c7c520f..13639d505 100644 --- a/web/public/locales/en/config/onvif.json +++ b/web/public/locales/en/config/onvif.json @@ -22,7 +22,7 @@ "description": "Skip TLS verification and disable digest auth for ONVIF (unsafe; use in safe networks only)." }, "autotracking": { - "label": "PTZ config", + "label": "Autotracking", "description": "Automatically track moving objects and keep them centered in the frame using PTZ camera movements.", "enabled": { "label": "Enable Autotracking", diff --git a/web/src/components/config-form/sections/CameraMqttSection.tsx b/web/src/components/config-form/sections/CameraMqttSection.tsx index 75b90313f..9c2b7a256 100644 --- a/web/src/components/config-form/sections/CameraMqttSection.tsx +++ b/web/src/components/config-form/sections/CameraMqttSection.tsx @@ -19,6 +19,11 @@ export const CameraMqttSection = createConfigSection({ hiddenFields: [], advancedFields: ["height", "quality"], overrideFields: [], + uiSchema: { + required_zones: { + "ui:widget": "zoneNames", + }, + }, }, }); diff --git a/web/src/components/config-form/sections/OnvifSection.tsx b/web/src/components/config-form/sections/OnvifSection.tsx index 61069f394..159dd27f4 100644 --- a/web/src/components/config-form/sections/OnvifSection.tsx +++ b/web/src/components/config-form/sections/OnvifSection.tsx @@ -13,12 +13,25 @@ export const OnvifSection = createConfigSection({ "user", "password", "tls_insecure", - "autotracking", "ignore_time_mismatch", + "autotracking", ], - hiddenFields: ["autotracking.enabled_in_config"], - advancedFields: ["tls_insecure", "autotracking", "ignore_time_mismatch"], + hiddenFields: [ + "autotracking.enabled_in_config", + "autotracking.movement_weights", + ], + advancedFields: ["tls_insecure", "ignore_time_mismatch"], overrideFields: [], + uiSchema: { + autotracking: { + required_zones: { + "ui:widget": "zoneNames", + }, + track: { + "ui:widget": "objectLabels", + }, + }, + }, }, }); diff --git a/web/src/components/config-form/sections/TimestampSection.tsx b/web/src/components/config-form/sections/TimestampSection.tsx index 8732c5131..69befd662 100644 --- a/web/src/components/config-form/sections/TimestampSection.tsx +++ b/web/src/components/config-form/sections/TimestampSection.tsx @@ -7,12 +7,12 @@ export const TimestampSection = createConfigSection({ sectionPath: "timestamp_style", i18nNamespace: "config/timestamp_style", defaultConfig: { - fieldOrder: ["position", "format", "color", "thickness", "effect"], + fieldOrder: ["position", "format", "color", "thickness"], fieldGroups: { - appearance: ["color", "thickness", "effect"], + appearance: ["color", "thickness"], }, hiddenFields: ["enabled_in_config"], - advancedFields: ["thickness", "effect"], + advancedFields: [], }, });