Enable event snapshot API to honour query params after event ends (#22375)

* Enable event snapshot API to honour query params

* fix unused imports

* Fixes

* Run ruff check --fix

* Web changes

* Further config and web fixes

* Further docs tweak

* Fix missing quality default in MediaEventsSnapshotQueryParams

* Manual events: don't save annotated jpeg; store frame time

* Remove unnecessary grayscale helper

* Add caveat to docs on snapshot_frame_time pre-0.18

* JPG snapshot should not be treated as clean

* Ensure tracked details uses uncropped, bbox'd snapshot

* Ensure all UI pages / menu actions use uncropped, bbox'd

* web lint

* Add missed config helper text

* Expect  SnapshotsConfig not Any

* docs: Remove pre-0.18 note

* Specify timestamp=0 in the UI

* Move tests out of http media

* Correct missed settings.json wording

Co-authored-by: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>

* Revert to default None for quality

* Correct camera snapshot config wording

Co-authored-by: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>

* Fix quality=0 handling

Co-authored-by: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>

* Fix quality=0 handling #2

Co-authored-by: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>

* ReRun generate_config_translations

---------

Co-authored-by: leccelecce <example@example.com>
Co-authored-by: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>

frigate/config/camera/camera.py

@@ -141,7 +141,7 @@ class CameraConfig(FrigateBaseModel):
     snapshots: SnapshotsConfig = Field(
         default_factory=SnapshotsConfig,
         title="Snapshots",
-        description="Settings for saved JPEG snapshots of tracked objects for this camera.",
+        description="Settings for API-generated snapshots of tracked objects for this camera.",
     )
     timestamp_style: TimestampStyleConfig = Field(
         default_factory=TimestampStyleConfig,

frigate/config/camera/snapshots.py

@@ -32,25 +32,20 @@ class SnapshotsConfig(FrigateBaseModel):
         title="Enable snapshots",
         description="Enable or disable saving snapshots for all cameras; can be overridden per-camera.",
     )
-    clean_copy: bool = Field(
-        default=True,
-        title="Save clean copy",
-        description="Save an unannotated clean copy of snapshots in addition to annotated ones.",
-    )
     timestamp: bool = Field(
         default=False,
         title="Timestamp overlay",
-        description="Overlay a timestamp on saved snapshots.",
+        description="Overlay a timestamp on snapshots from API.",
     )
     bounding_box: bool = Field(
         default=True,
         title="Bounding box overlay",
-        description="Draw bounding boxes for tracked objects on saved snapshots.",
+        description="Draw bounding boxes for tracked objects on snapshots from API.",
     )
     crop: bool = Field(
         default=False,
         title="Crop snapshot",
-        description="Crop saved snapshots to the detected object's bounding box.",
+        description="Crop snapshots from API to the detected object's bounding box.",
     )
     required_zones: list[str] = Field(
         default_factory=list,
@@ -60,17 +55,17 @@ class SnapshotsConfig(FrigateBaseModel):
     height: Optional[int] = Field(
         default=None,
         title="Snapshot height",
-        description="Height (pixels) to resize saved snapshots to; leave empty to preserve original size.",
+        description="Height (pixels) to resize snapshots from API to; leave empty to preserve original size.",
     )
     retain: RetainConfig = Field(
         default_factory=RetainConfig,
         title="Snapshot retention",
-        description="Retention settings for saved snapshots including default days and per-object overrides.",
+        description="Retention settings for snapshots including default days and per-object overrides.",
     )
     quality: int = Field(
-        default=70,
-        title="JPEG quality",
-        description="JPEG encode quality for saved snapshots (0-100).",
+        default=60,
+        title="Snapshot quality",
+        description="Encode quality for saved snapshots (0-100).",
         ge=0,
         le=100,
     )

frigate/config/config.py

@@ -498,7 +498,7 @@ class FrigateConfig(FrigateBaseModel):
     snapshots: SnapshotsConfig = Field(
         default_factory=SnapshotsConfig,
         title="Snapshots",
-        description="Settings for saved JPEG snapshots of tracked objects for all cameras; can be overridden per-camera.",
+        description="Settings for API-generated snapshots of tracked objects for all cameras; can be overridden per-camera.",
     )
     timestamp_style: TimestampStyleConfig = Field(
         default_factory=TimestampStyleConfig,
@@ -933,11 +933,6 @@ class FrigateConfig(FrigateBaseModel):
                         f"Camera {camera.name} has audio transcription enabled, but audio detection is not enabled for this camera. Audio detection must be enabled for cameras with audio transcription when it is disabled globally."
                     )
 
-        if self.plus_api and not self.snapshots.clean_copy:
-            logger.warning(
-                "Frigate+ is configured but clean snapshots are not enabled, submissions to Frigate+ will not be possible./"
-            )
-
         # Validate auth roles against cameras
         camera_names = set(self.cameras.keys())