From e98b402cdfe8cb1ed1c0ec07132b37cbe2c0ff68 Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Sat, 21 Sep 2024 12:38:55 -0500
Subject: [PATCH] Ensure descriptions saved in chroma are non-empty

---
 frigate/embeddings/embeddings.py | 4 ++--
 frigate/embeddings/maintainer.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/frigate/embeddings/embeddings.py b/frigate/embeddings/embeddings.py
index 8179de15e..ba5363cab 100644
--- a/frigate/embeddings/embeddings.py
+++ b/frigate/embeddings/embeddings.py
@@ -126,9 +126,9 @@ class Embeddings:
                 thumbnails["ids"].append(event.id)
                 thumbnails["images"].append(img)
                 thumbnails["metadatas"].append(metadata)
-                if event.data.get("description") is not None:
+                if description := event.data.get("description", "").strip():
                     descriptions["ids"].append(event.id)
-                    descriptions["documents"].append(event.data["description"])
+                    descriptions["documents"].append(description)
                     descriptions["metadatas"].append(metadata)
 
             if len(thumbnails["ids"]) > 0:
diff --git a/frigate/embeddings/maintainer.py b/frigate/embeddings/maintainer.py
index 8e4309d5e..eee0d2994 100644
--- a/frigate/embeddings/maintainer.py
+++ b/frigate/embeddings/maintainer.py
@@ -177,7 +177,7 @@ class EmbeddingMaintainer(threading.Thread):
             camera_config, thumbnails, metadata
         )
 
-        if description is None:
+        if not description:
             logger.debug("Failed to generate description for %s", event.id)
             return