administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-03-18 06:08:22 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: WebSocket connection leaked on WebRTC player cleanup (#22473)

Browse Source 
The connect() function creates a WebSocket but never stores the
reference. The useEffect cleanup only closes the RTCPeerConnection
via pcRef, leaving the WebSocket open.

Each time the component re-renders with changed deps (camera switch,
playback toggle, microphone toggle), a new WebSocket is created
without closing the previous one. This leaks connections until the
browser garbage-collects them or the server times out.

Store the WebSocket in a ref and close it in the cleanup function.
This commit is contained in:
ryzendigo 2026-03-16 20:47:07 +08:00 committed by GitHub
parent 49ffd0b01a
commit e80da2b297
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/components/player/WebRTCPlayer.tsx
View File

@ -52,6 +52,7 @@ export default function WebRtcPlayer({
// camera states // camera states
const pcRef = useRef<RTCPeerConnection | undefined>(undefined); const pcRef = useRef<RTCPeerConnection | undefined>(undefined);
const wsRef = useRef<WebSocket | null>(null);
const videoRef = useRef<HTMLVideoElement | null>(null); const videoRef = useRef<HTMLVideoElement | null>(null);
const [bufferTimeout, setBufferTimeout] = useState<NodeJS.Timeout>(); const [bufferTimeout, setBufferTimeout] = useState<NodeJS.Timeout>();
const videoLoadTimeoutRef = useRef<NodeJS.Timeout>(undefined); const videoLoadTimeoutRef = useRef<NodeJS.Timeout>(undefined);
@ -129,7 +130,8 @@ export default function WebRtcPlayer({
} }
pcRef.current = await aPc; pcRef.current = await aPc;
const ws = new WebSocket(wsURL); wsRef.current = new WebSocket(wsURL);
const ws = wsRef.current;
ws.addEventListener("open", () => { ws.addEventListener("open", () => {
pcRef.current?.addEventListener("icecandidate", (ev) => { pcRef.current?.addEventListener("icecandidate", (ev) => {
@ -183,6 +185,10 @@ export default function WebRtcPlayer({
connect(aPc); connect(aPc);
return () => { return () => {
if (wsRef.current) {
wsRef.current.close();
wsRef.current = null;
}
if (pcRef.current) { if (pcRef.current) {
pcRef.current.close(); pcRef.current.close();
pcRef.current = undefined; pcRef.current = undefined;