show Frigate+ submission failures in the UI instead of showing a false success (#23579)

web/public/locales/en/components/dialog.json

@@ -24,6 +24,9 @@
         },
         "state": {
           "submitted": "Submitted"
+        },
+        "toast": {
+          "error": "Failed to submit to Frigate+. Please check your network connection and try again."
         }
       }
     },

web/src/components/overlay/detail/SearchDetailDialog.tsx

@@ -1251,30 +1251,42 @@ function ObjectDetailsTab({
         return;
       }
 
-      falsePositive
+      try {
-        ? axios.put(`events/${search.id}/false_positive`)
+        const resp = falsePositive
-        : axios.post(`events/${search.id}/plus`, {
+          ? await axios.put(`events/${search.id}/false_positive`)
-            include_annotation: 1,
+          : await axios.post(`events/${search.id}/plus`, {
-          });
+              include_annotation: 1,
+            });
 
-      setState("submitted");
+        if (resp.status !== 200 || !resp.data?.success) {
-      setSearch({ ...search, plus_id: "new_upload" });
+          throw new Error();
-      mutate(
+        }
-        (key) => isEventsKey(key),
+
-        (currentData: SearchResult[][] | SearchResult[] | undefined) =>
+        setState("submitted");
-          mapSearchResults(currentData, (event) =>
+        setSearch({ ...search, plus_id: "new_upload" });
-            event.id === search.id
+        mutate(
-              ? { ...event, plus_id: "new_upload" }
+          (key) => isEventsKey(key),
-              : event,
+          (currentData: SearchResult[][] | SearchResult[] | undefined) =>
-          ),
+            mapSearchResults(currentData, (event) =>
-        {
+              event.id === search.id
-          optimisticData: true,
+                ? { ...event, plus_id: "new_upload" }
-          rollbackOnError: true,
+                : event,
-          revalidate: false,
+            ),
-        },
+          {
-      );
+            optimisticData: true,
+            rollbackOnError: true,
+            revalidate: false,
+          },
+        );
+      } catch {
+        setState("reviewing");
+        toast.error(
+          t("explore.plus.review.toast.error", { ns: "components/dialog" }),
+          { position: "top-center" },
+        );
+      }
     },
-    [search, mutate, mapSearchResults, setSearch, isEventsKey],
+    [search, mutate, mapSearchResults, setSearch, isEventsKey, t],
   );
 
   const popoverContainerRef = useRef<HTMLDivElement | null>(null);

web/src/components/overlay/detail/TrackingDetails.tsx

@@ -1225,11 +1225,15 @@ function LifecycleIconRow({
                       <DropdownMenuItem
                         className="cursor-pointer"
                         onSelect={async () => {
-                          const resp = await axios.post(
+                          try {
-                            `/${item.camera}/plus/${item.timestamp + annotationOffset / 1000}`,
+                            const resp = await axios.post(
-                          );
+                              `/${item.camera}/plus/${item.timestamp + annotationOffset / 1000}`,
+                            );
+
+                            if (resp.status !== 200) {
+                              throw new Error();
+                            }
 
-                          if (resp && resp.status == 200) {
                             toast.success(
                               t("toast.success.submittedFrigatePlus", {
                                 ns: "components/player",
@@ -1238,8 +1242,8 @@ function LifecycleIconRow({
                                 position: "top-center",
                               },
                             );
-                          } else {
+                          } catch {
-                            toast.success(
+                            toast.error(
                               t("toast.error.submitFrigatePlusFailed", {
                                 ns: "components/player",
                               }),

web/src/components/overlay/dialog/FrigatePlusDialog.tsx

@@ -10,6 +10,7 @@ import { isDesktop, isMobile, isSafari } from "react-device-detect";
 import { cn } from "@/lib/utils";
 import { useCallback, useEffect, useState } from "react";
 import axios from "axios";
+import { toast } from "sonner";
 import { useTranslation, Trans } from "react-i18next";
 import { Button } from "@/components/ui/button";
 import ActivityIndicator from "@/components/indicators/activity-indicator";
@@ -48,13 +49,28 @@ export function FrigatePlusDialog({
   const onSubmitToPlus = useCallback(
     async (falsePositive: boolean) => {
       if (!upload) return;
-      falsePositive
+
-        ? axios.put(`events/${upload.id}/false_positive`)
+      try {
-        : axios.post(`events/${upload.id}/plus`, { include_annotation: 1 });
+        const resp = falsePositive
-      setState("submitted");
+          ? await axios.put(`events/${upload.id}/false_positive`)
-      onEventUploaded();
+          : await axios.post(`events/${upload.id}/plus`, {
+              include_annotation: 1,
+            });
+
+        if (resp.status !== 200 || !resp.data?.success) {
+          throw new Error();
+        }
+
+        setState("submitted");
+        onEventUploaded();
+      } catch {
+        setState("reviewing");
+        toast.error(t("explore.plus.review.toast.error"), {
+          position: "top-center",
+        });
+      }
     },
-    [upload, onEventUploaded],
+    [upload, onEventUploaded, t],
   );
 
   const [imgRef, imgLoaded, onImgLoad] = useImageLoaded();