More detail pane tweaks

This commit is contained in:
Josh Hawkins 2025-10-26 11:43:25 -05:00
parent 190925375b
commit de1c1f3fb4
2 changed files with 52 additions and 19 deletions

View File

@ -430,7 +430,8 @@ function EventList({
}: EventListProps) { }: EventListProps) {
const { data: config } = useSWR<FrigateConfig>("config"); const { data: config } = useSWR<FrigateConfig>("config");
const { selectedObjectIds, toggleObjectSelection } = useDetailStream(); const { selectedObjectIds, setSelectedObjectIds, toggleObjectSelection } =
useDetailStream();
const isSelected = selectedObjectIds.includes(event.id); const isSelected = selectedObjectIds.includes(event.id);
@ -438,13 +439,19 @@ function EventList({
const handleObjectSelect = (event: Event | undefined) => { const handleObjectSelect = (event: Event | undefined) => {
if (event) { if (event) {
// onSeek(event.start_time ?? 0); setSelectedObjectIds([]);
toggleObjectSelection(event.id); setSelectedObjectIds([event.id]);
onSeek(event.start_time ?? 0);
} else { } else {
toggleObjectSelection(undefined); setSelectedObjectIds([]);
} }
}; };
const handleTimelineClick = (ts: number, play?: boolean) => {
handleObjectSelect(event);
onSeek(ts, play);
};
// Clear selection when effectiveTime has passed this event's end_time // Clear selection when effectiveTime has passed this event's end_time
useEffect(() => { useEffect(() => {
if (isSelected && effectiveTime && event.end_time) { if (isSelected && effectiveTime && event.end_time) {
@ -468,11 +475,6 @@ function EventList({
isSelected isSelected
? "bg-secondary-highlight" ? "bg-secondary-highlight"
: "outline-transparent duration-500", : "outline-transparent duration-500",
!isSelected &&
(effectiveTime ?? 0) >= (event.start_time ?? 0) - 0.5 &&
(effectiveTime ?? 0) <=
(event.end_time ?? event.start_time ?? 0) + 0.5 &&
"bg-secondary-highlight",
)} )}
> >
<div className="ml-1.5 flex w-full items-end justify-between"> <div className="ml-1.5 flex w-full items-end justify-between">
@ -480,12 +482,18 @@ function EventList({
<div <div
className={cn( className={cn(
"relative rounded-full p-1 text-white", "relative rounded-full p-1 text-white",
isSelected ? "bg-selected" : "bg-muted-foreground", (effectiveTime ?? 0) >= (event.start_time ?? 0) - 0.5 &&
(effectiveTime ?? 0) <=
(event.end_time ?? event.start_time ?? 0) + 0.5
? "bg-selected"
: "bg-muted-foreground",
)} )}
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
handleObjectSelect(isSelected ? undefined : event); onSeek(event.start_time ?? 0);
handleObjectSelect(event);
}} }}
role="button"
> >
{getIconForLabel( {getIconForLabel(
event.sub_label ? event.label + "-verified" : event.label, event.sub_label ? event.label + "-verified" : event.label,
@ -497,6 +505,7 @@ function EventList({
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
onSeek(event.start_time ?? 0); onSeek(event.start_time ?? 0);
handleObjectSelect(event);
}} }}
role="button" role="button"
> >
@ -532,8 +541,10 @@ function EventList({
<div className="mt-2"> <div className="mt-2">
<ObjectTimeline <ObjectTimeline
eventId={event.id} eventId={event.id}
onSeek={onSeek} onSeek={handleTimelineClick}
effectiveTime={effectiveTime} effectiveTime={effectiveTime}
startTime={event.start_time}
endTime={event.end_time}
/> />
</div> </div>
</div> </div>
@ -546,6 +557,7 @@ type LifecycleItemProps = {
isActive?: boolean; isActive?: boolean;
onSeek?: (timestamp: number, play?: boolean) => void; onSeek?: (timestamp: number, play?: boolean) => void;
effectiveTime?: number; effectiveTime?: number;
isTimelineActive?: boolean;
}; };
function LifecycleItem({ function LifecycleItem({
@ -553,6 +565,7 @@ function LifecycleItem({
isActive, isActive,
onSeek, onSeek,
effectiveTime, effectiveTime,
isTimelineActive = false,
}: LifecycleItemProps) { }: LifecycleItemProps) {
const { t } = useTranslation("views/events"); const { t } = useTranslation("views/events");
const { data: config } = useSWR<FrigateConfig>("config"); const { data: config } = useSWR<FrigateConfig>("config");
@ -617,8 +630,9 @@ function LifecycleItem({
<div className="relative flex size-4 items-center justify-center"> <div className="relative flex size-4 items-center justify-center">
<LuCircle <LuCircle
className={cn( className={cn(
"relative z-10 ml-[1px] size-2.5 fill-secondary-foreground stroke-none", "relative z-10 size-2.5 fill-secondary-foreground stroke-none",
(isActive || (effectiveTime ?? 0) >= (item?.timestamp ?? 0)) && (isActive || (effectiveTime ?? 0) >= (item?.timestamp ?? 0)) &&
isTimelineActive &&
"fill-selected duration-300", "fill-selected duration-300",
)} )}
/> />
@ -673,10 +687,14 @@ function ObjectTimeline({
eventId, eventId,
onSeek, onSeek,
effectiveTime, effectiveTime,
startTime,
endTime,
}: { }: {
eventId: string; eventId: string;
onSeek: (ts: number, play?: boolean) => void; onSeek: (ts: number, play?: boolean) => void;
effectiveTime?: number; effectiveTime?: number;
startTime?: number;
endTime?: number;
}) { }) {
const { t } = useTranslation("views/events"); const { t } = useTranslation("views/events");
const { data: timeline, isValidating } = useSWR<ObjectLifecycleSequence[]>([ const { data: timeline, isValidating } = useSWR<ObjectLifecycleSequence[]>([
@ -698,9 +716,17 @@ function ObjectTimeline({
); );
} }
// Check if current time is within the event's start/stop range
const isWithinEventRange =
effectiveTime !== undefined &&
startTime !== undefined &&
endTime !== undefined &&
effectiveTime >= startTime &&
effectiveTime <= endTime;
// Calculate how far down the blue line should extend based on effectiveTime // Calculate how far down the blue line should extend based on effectiveTime
const calculateLineHeight = () => { const calculateLineHeight = () => {
if (!timeline || timeline.length === 0) return 0; if (!timeline || timeline.length === 0 || !isWithinEventRange) return 0;
const currentTime = effectiveTime ?? 0; const currentTime = effectiveTime ?? 0;
@ -742,15 +768,19 @@ function ObjectTimeline({
); );
}; };
const blueLineHeight = calculateLineHeight(); const activeLineHeight = calculateLineHeight();
return ( return (
<div className="-pb-2 relative mx-2"> <div className="-pb-2 relative mx-2">
<div className="absolute -top-2 bottom-2 left-2 z-0 w-0.5 -translate-x-1/2 bg-secondary-foreground" /> <div className="absolute -top-2 bottom-2 left-2 z-0 w-0.5 -translate-x-1/2 bg-secondary-foreground" />
<div {isWithinEventRange && (
className="absolute left-2 top-2 z-[5] max-h-[calc(100%-1rem)] w-0.5 -translate-x-1/2 bg-selected transition-all duration-300" <div
style={{ height: `${blueLineHeight}%` }} className={cn(
/> "absolute left-2 top-2 z-[5] max-h-[calc(100%-1rem)] w-0.5 -translate-x-1/2 bg-selected transition-all duration-300",
)}
style={{ height: `${activeLineHeight}%` }}
/>
)}
<div className="space-y-2"> <div className="space-y-2">
{timeline.map((event, idx) => { {timeline.map((event, idx) => {
const isActive = const isActive =
@ -763,6 +793,7 @@ function ObjectTimeline({
onSeek={onSeek} onSeek={onSeek}
isActive={isActive} isActive={isActive}
effectiveTime={effectiveTime} effectiveTime={effectiveTime}
isTimelineActive={isWithinEventRange}
/> />
); );
})} })}

View File

@ -7,6 +7,7 @@ export interface DetailStreamContextType {
currentTime: number; currentTime: number;
camera: string; camera: string;
annotationOffset: number; // milliseconds annotationOffset: number; // milliseconds
setSelectedObjectIds: React.Dispatch<React.SetStateAction<string[]>>;
setAnnotationOffset: (ms: number) => void; setAnnotationOffset: (ms: number) => void;
toggleObjectSelection: (id: string | undefined) => void; toggleObjectSelection: (id: string | undefined) => void;
isDetailMode: boolean; isDetailMode: boolean;
@ -69,6 +70,7 @@ export function DetailStreamProvider({
camera, camera,
annotationOffset, annotationOffset,
setAnnotationOffset, setAnnotationOffset,
setSelectedObjectIds,
toggleObjectSelection, toggleObjectSelection,
isDetailMode, isDetailMode,
}; };