From d957959ce792f05519ee6871aa9ff689173149de Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Tue, 1 Oct 2024 07:48:10 -0500 Subject: [PATCH] use browser back button to dismiss review pane --- web/src/components/overlay/detail/ReviewDetailDialog.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/web/src/components/overlay/detail/ReviewDetailDialog.tsx b/web/src/components/overlay/detail/ReviewDetailDialog.tsx index 6701fa6d7..0d06dc85e 100644 --- a/web/src/components/overlay/detail/ReviewDetailDialog.tsx +++ b/web/src/components/overlay/detail/ReviewDetailDialog.tsx @@ -37,6 +37,7 @@ import { MobilePageHeader, MobilePageTitle, } from "@/components/mobile/MobilePage"; +import { useOverlayState } from "@/hooks/use-overlay-state"; type ReviewDetailDialogProps = { review?: ReviewSegment; @@ -83,10 +84,12 @@ export default function ReviewDetailDialog({ // dialog and mobile page - const [isOpen, setIsOpen] = useState(review != undefined); + const [isOpen, setIsOpen] = useOverlayState("reviewPane", false); useEffect(() => { setIsOpen(review != undefined); + // we know that these deps are correct + // eslint-disable-next-line react-hooks/exhaustive-deps }, [review]); const Overlay = isDesktop ? Sheet : MobilePage; @@ -102,7 +105,7 @@ export default function ReviewDetailDialog({ return ( <> { if (!open) { setReview(undefined);