Fixed review.py responses and proper path parameter names

This commit is contained in:
Rui Alves 2024-10-17 10:21:19 +01:00
parent 03127f4ccc
commit d55736b11b

View File

@ -576,31 +576,41 @@ def audio_activity(params: ReviewActivityMotionQueryParams = Depends()):
@router.get("/review/event/{event_id}", response_model=ReviewSegmentResponse) @router.get("/review/event/{event_id}", response_model=ReviewSegmentResponse)
def get_review_from_event(event_id: str): def get_review_from_event(event_id: str):
try: try:
return model_to_dict( return JSONResponse(
ReviewSegment.get( model_to_dict(
ReviewSegment.data["detections"].cast("text") % f'*"{event_id}"*' ReviewSegment.get(
ReviewSegment.data["detections"].cast("text") % f'*"{event_id}"*'
)
) )
) )
except DoesNotExist: except DoesNotExist:
return "Review item not found", 404 return JSONResponse(
content={"success": False, "message": "Review item not found"},
status_code=404,
)
@router.get("/review/{event_id}", response_model=ReviewSegmentResponse) @router.get("/review/{review_id}", response_model=ReviewSegmentResponse)
def get_review(event_id: str): def get_review(review_id: str):
try: try:
return model_to_dict(ReviewSegment.get(ReviewSegment.id == event_id)) return JSONResponse(
content=model_to_dict(ReviewSegment.get(ReviewSegment.id == review_id))
)
except DoesNotExist: except DoesNotExist:
return "Review item not found", 404 return JSONResponse(
content={"success": False, "message": "Review item not found"},
status_code=404,
)
@router.delete("/review/{event_id}/viewed", response_model=GenericResponse) @router.delete("/review/{review_id}/viewed", response_model=GenericResponse)
def set_not_reviewed(event_id: str): def set_not_reviewed(review_id: str):
try: try:
review: ReviewSegment = ReviewSegment.get(ReviewSegment.id == event_id) review: ReviewSegment = ReviewSegment.get(ReviewSegment.id == review_id)
except DoesNotExist: except DoesNotExist:
return JSONResponse( return JSONResponse(
content=( content=(
{"success": False, "message": "Review " + event_id + " not found"} {"success": False, "message": "Review " + review_id + " not found"}
), ),
status_code=404, status_code=404,
) )
@ -609,6 +619,8 @@ def set_not_reviewed(event_id: str):
review.save() review.save()
return JSONResponse( return JSONResponse(
content=({"success": True, "message": "Reviewed " + event_id + " not viewed"}), content=(
{"success": True, "message": "Set Review " + review_id + " as not viewed"}
),
status_code=200, status_code=200,
) )