From d2a2ba321dc9270cf3eb42c171bb1502f9c8bc75 Mon Sep 17 00:00:00 2001 From: Felipe Santos Date: Sat, 19 Nov 2022 17:34:49 -0300 Subject: [PATCH] Disable CI stuff which does not work until we fix them --- .github/workflows/pull_request.yml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 667d04e6c..ae36e12f6 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -9,12 +9,13 @@ jobs: build_devcontainer: runs-on: ubuntu-latest name: Build Devcontainer + # The Dockerfile contains features that requires buildkit, and since the + # devcontainer cli uses docker-compose to build the image, the only way to + # ensure docker-compose uses buildkit is to explicitly enable it. env: DOCKER_BUILDKIT: "1" steps: - uses: actions/checkout@v3 - - name: Setup Docker Compose - uses: ndeloof/install-compose-action@v0.0.1 - uses: actions/setup-node@master with: node-version: 16.x @@ -22,10 +23,12 @@ jobs: run: npm install --global @devcontainers/cli - name: Build devcontainer run: devcontainer build --workspace-folder . - - name: Start devcontainer - run: devcontainer up --workspace-folder . - - name: Run devcontainer scripts - run: devcontainer run-user-commands --workspace-folder . + # It would be nice to also test the following commands, but for some + # reason they don't work even though in VS Code devcontainer works. + # - name: Start devcontainer + # run: devcontainer up --workspace-folder . + # - name: Run devcontainer scripts + # run: devcontainer run-user-commands --workspace-folder . web_lint: name: Web - Lint