add ability to edit enabled and save_attempts for classification models in the UI

frigate/embeddings/maintainer.py

@@ -376,20 +376,22 @@ class EmbeddingMaintainer(threading.Thread):
             logger.info(f"Disabled classification processor for model: {model_name}")
             return
 
-        # Check if processor already exists
         for processor in self.realtime_processors:
-            if isinstance(
+            if (
-                processor,
+                isinstance(
-                (
+                    processor,
-                    CustomStateClassificationProcessor,
+                    (
-                    CustomObjectClassificationProcessor,
+                        CustomStateClassificationProcessor,
-                ),
+                        CustomObjectClassificationProcessor,
+                    ),
+                )
+                and processor.model_config.name == model_name
             ):
-                if processor.model_config.name == model_name:
+                processor.model_config = model_config
-                    logger.debug(
+                logger.debug(
-                        f"Classification processor for model {model_name} already exists, skipping"
+                    f"Updated config for classification processor: {model_name}"
-                    )
+                )
-                    return
+                return
 
         if model_config.state_config is not None:
             processor = CustomStateClassificationProcessor(

web/public/locales/en/views/classificationModel.json

@@ -1,5 +1,6 @@
 {
   "documentTitle": "Classification Models - Frigate",
+  "disabled": "Disabled",
   "details": {
     "scoreInfo": "Score represents the average classification confidence across all detections of this object.",
     "none": "None",
@@ -64,7 +65,14 @@
     "title": "Edit Classification Model",
     "descriptionState": "Edit the classes for this state classification model. Changes will require retraining the model.",
     "descriptionObject": "Edit the object type and classification type for this object classification model.",
-    "stateClassesInfo": "Note: Changing state classes requires retraining the model with the updated classes."
+    "enabled": "Enabled",
+    "enabledDesc": "Run this model. When disabled, it stops running and no longer classifies.",
+    "saveAttempts": "Save Attempts",
+    "saveAttemptsDesc": "Number of classification attempt images to keep for the recent classifications UI.",
+    "stateClassesInfo": "Model updated. Retrain the model for the class changes to take effect.",
+    "errors": {
+      "saveAttemptsInvalid": "Save attempts must be a whole number of 0 or greater"
+    }
   },
   "deleteDatasetImages": {
     "title": "Delete Dataset Images",

web/src/components/classification/ClassificationModelEditDialog.tsx

@@ -9,6 +9,7 @@ import {
 import {
   Form,
   FormControl,
+  FormDescription,
   FormField,
   FormItem,
   FormLabel,
@@ -17,6 +18,7 @@ import {
 import { Input } from "@/components/ui/input";
 import { Label } from "@/components/ui/label";
 import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";
+import { Switch } from "@/components/ui/switch";
 import {
   Select,
   SelectContent,
@@ -50,14 +52,23 @@ type ClassificationModelEditDialogProps = {
 type ObjectClassificationType = "sub_label" | "attribute";
 
 type ObjectFormData = {
+  enabled: boolean;
+  saveAttempts: number;
   objectLabel: string;
   objectType: ObjectClassificationType;
 };
 
 type StateFormData = {
+  enabled: boolean;
+  saveAttempts: number;
   classes: string[];
 };
 
+const DEFAULT_SAVE_ATTEMPTS = {
+  object: 200,
+  state: 100,
+} as const;
+
 export default function ClassificationModelEditDialog({
   open,
   model,
@@ -71,6 +82,10 @@ export default function ClassificationModelEditDialog({
   const isStateModel = model.state_config !== undefined;
   const isObjectModel = model.object_config !== undefined;
 
+  const defaultSaveAttempts = isObjectModel
+    ? DEFAULT_SAVE_ATTEMPTS.object
+    : DEFAULT_SAVE_ATTEMPTS.state;
+
   const objectLabels = useMemo(() => {
     if (!config) return [];
 
@@ -93,8 +108,17 @@ export default function ClassificationModelEditDialog({
 
   // Define form schema based on model type
   const formSchema = useMemo(() => {
+    const sharedFields = {
+      enabled: z.boolean(),
+      saveAttempts: z.coerce
+        .number({ message: t("edit.errors.saveAttemptsInvalid") })
+        .int(t("edit.errors.saveAttemptsInvalid"))
+        .min(0, t("edit.errors.saveAttemptsInvalid")),
+    };
+
     if (isObjectModel) {
       return z.object({
+        ...sharedFields,
         objectLabel: z
           .string()
           .min(1, t("wizard.step1.errors.objectLabelRequired")),
@@ -103,6 +127,7 @@ export default function ClassificationModelEditDialog({
     } else {
       // State model
       return z.object({
+        ...sharedFields,
         classes: z
           .array(z.string())
           .min(1, t("wizard.step1.errors.classRequired"))
@@ -129,12 +154,16 @@ export default function ClassificationModelEditDialog({
     resolver: zodResolver(formSchema),
     defaultValues: isObjectModel
       ? ({
+          enabled: model.enabled,
+          saveAttempts: model.save_attempts ?? defaultSaveAttempts,
           objectLabel: model.object_config?.objects?.[0] || "",
           objectType:
             (model.object_config
               ?.classification_type as ObjectClassificationType) || "sub_label",
         } as ObjectFormData)
       : ({
+          enabled: model.enabled,
+          saveAttempts: model.save_attempts ?? defaultSaveAttempts,
           classes: [""], // Will be populated from dataset
         } as StateFormData),
     mode: "onChange",
@@ -151,6 +180,8 @@ export default function ClassificationModelEditDialog({
     if (open) {
       if (isObjectModel) {
         form.reset({
+          enabled: model.enabled,
+          saveAttempts: model.save_attempts ?? defaultSaveAttempts,
           objectLabel: model.object_config?.objects?.[0] || "",
           objectType:
             (model.object_config
@@ -158,6 +189,8 @@ export default function ClassificationModelEditDialog({
         } as ObjectFormData);
       } else {
         form.reset({
+          enabled: model.enabled,
+          saveAttempts: model.save_attempts ?? defaultSaveAttempts,
           classes: [""],
         } as StateFormData);
       }
@@ -166,7 +199,15 @@ export default function ClassificationModelEditDialog({
         mutateDataset();
       }
     }
-  }, [open, isObjectModel, isStateModel, model, form, mutateDataset]);
+  }, [
+    open,
+    isObjectModel,
+    isStateModel,
+    model,
+    form,
+    mutateDataset,
+    defaultSaveAttempts,
+  ]);
 
   // Update form with classes from dataset when loaded
   useEffect(() => {
@@ -243,9 +284,10 @@ export default function ClassificationModelEditDialog({
               classification: {
                 custom: {
                   [model.name]: {
-                    enabled: model.enabled,
+                    enabled: objectData.enabled,
                     name: model.name,
                     threshold: model.threshold,
+                    save_attempts: objectData.saveAttempts,
                     object_config: {
                       objects: [objectData.objectLabel],
                       classification_type: objectData.objectType,
@@ -261,6 +303,22 @@ export default function ClassificationModelEditDialog({
           });
         } else {
           const stateData = data as StateFormData;
+
+          await axios.put("/config/set", {
+            requires_restart: 0,
+            update_topic: `config/classification/custom/${model.name}`,
+            config_data: {
+              classification: {
+                custom: {
+                  [model.name]: {
+                    enabled: stateData.enabled,
+                    save_attempts: stateData.saveAttempts,
+                  },
+                },
+              },
+            },
+          });
+
           const newClasses = stateData.classes.filter(
             (c) => c.trim().length > 0,
           );
@@ -307,11 +365,11 @@ export default function ClassificationModelEditDialog({
           if (renamePromises.length > 0) {
             await Promise.all(renamePromises);
             await mutate(`classification/${model.name}/dataset`);
-            toast.success(t("toast.success.updatedModel"), {
+            toast.success(t("edit.stateClassesInfo"), {
               position: "top-center",
             });
           } else {
-            toast.info(t("edit.stateClassesInfo"), {
+            toast.success(t("toast.success.updatedModel"), {
               position: "top-center",
             });
           }
@@ -359,6 +417,29 @@ export default function ClassificationModelEditDialog({
         <div className="space-y-6">
           <Form {...form}>
             <form onSubmit={form.handleSubmit(onSubmit)} className="space-y-4">
+              <FormField
+                control={form.control}
+                name="enabled"
+                render={({ field }) => (
+                  <FormItem className="flex flex-row items-center justify-between gap-4">
+                    <div className="space-y-0.5">
+                      <FormLabel className="text-primary-variant">
+                        {t("edit.enabled")}
+                      </FormLabel>
+                      <FormDescription className="text-xs">
+                        {t("edit.enabledDesc")}
+                      </FormDescription>
+                    </div>
+                    <FormControl>
+                      <Switch
+                        checked={field.value}
+                        onCheckedChange={field.onChange}
+                      />
+                    </FormControl>
+                  </FormItem>
+                )}
+              />
+
               {isObjectModel && (
                 <>
                   <FormField
@@ -520,6 +601,25 @@ export default function ClassificationModelEditDialog({
                 </div>
               )}
 
+              <FormField
+                control={form.control}
+                name="saveAttempts"
+                render={({ field }) => (
+                  <FormItem>
+                    <FormLabel className="text-primary-variant">
+                      {t("edit.saveAttempts")}
+                    </FormLabel>
+                    <FormControl>
+                      <Input className="h-8" inputMode="numeric" {...field} />
+                    </FormControl>
+                    <FormDescription className="text-xs">
+                      {t("edit.saveAttemptsDesc")}
+                    </FormDescription>
+                    <FormMessage />
+                  </FormItem>
+                )}
+              />
+
               <div className="flex flex-col gap-3 pt-3 sm:flex-row sm:justify-end sm:gap-4">
                 <Button
                   type="button"

web/src/views/classification/ModelSelectionView.tsx

@@ -3,6 +3,7 @@ import ClassificationModelWizardDialog from "@/components/classification/Classif
 import ClassificationModelEditDialog from "@/components/classification/ClassificationModelEditDialog";
 import ActivityIndicator from "@/components/indicators/activity-indicator";
 import { ImageShadowOverlay } from "@/components/overlay/ImageShadowOverlay";
+import { Badge } from "@/components/ui/badge";
 import { Button, buttonVariants } from "@/components/ui/button";
 import { ToggleGroup, ToggleGroupItem } from "@/components/ui/toggle-group";
 import useOptimisticState from "@/hooks/use-optimistic-state";
@@ -330,7 +331,10 @@ function ModelCard({ config, onClick, onUpdate, onDelete }: ModelCardProps) {
         {coverImage ? (
           <>
             <img
-              className="size-full"
+              className={cn(
+                "size-full",
+                !config.enabled && "opacity-50 grayscale",
+              )}
               src={`${baseUrl}clips/${config.name}/dataset/${coverImage.name}/${coverImage.img}`}
             />
             <ImageShadowOverlay lowerClassName="h-[30%] z-0" />
@@ -338,6 +342,14 @@ function ModelCard({ config, onClick, onUpdate, onDelete }: ModelCardProps) {
         ) : (
           <Skeleton className="flex size-full items-center justify-center" />
         )}
+        {!config.enabled && (
+          <Badge
+            variant="secondary"
+            className="absolute right-2 top-2 z-40 text-primary-variant"
+          >
+            {t("disabled")}
+          </Badge>
+        )}
         <div className="absolute bottom-2 left-3 text-lg text-white smart-capitalize">
           {config.name}
         </div>