From cff9c32db7015fccbb1f117db8597fb10caeeb50 Mon Sep 17 00:00:00 2001
From: kirill kulakov <kirill578@gmail.com>
Date: Thu, 15 Jan 2026 21:33:24 -0600
Subject: [PATCH] test(recording): add test for maintainer cache file parsing

---
 frigate/test/test_maintainer.py | 49 +++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 frigate/test/test_maintainer.py

diff --git a/frigate/test/test_maintainer.py b/frigate/test/test_maintainer.py
new file mode 100644
index 000000000..f3556a0ee
--- /dev/null
+++ b/frigate/test/test_maintainer.py
@@ -0,0 +1,49 @@
+
+import unittest
+from unittest.mock import MagicMock, patch
+import sys
+import datetime
+
+# Mock complex imports before importing maintainer
+sys.modules['frigate.comms.inter_process'] = MagicMock()
+sys.modules['frigate.comms.detections_updater'] = MagicMock()
+sys.modules['frigate.comms.recordings_updater'] = MagicMock()
+sys.modules['frigate.config.camera.updater'] = MagicMock()
+
+# Now import the class under test
+from frigate.record.maintainer import RecordingMaintainer
+from frigate.config import FrigateConfig
+
+class TestMaintainer(unittest.IsolatedAsyncioTestCase):
+    async def test_move_files_survives_bad_filename(self):
+        config = MagicMock(spec=FrigateConfig)
+        config.cameras = {}
+        stop_event = MagicMock()
+        
+        maintainer = RecordingMaintainer(config, stop_event)
+        
+        # We need to mock end_time_cache to avoid key errors if logic proceeds
+        maintainer.end_time_cache = {}
+
+        # Mock filesystem
+        # One bad file, one good file
+        files = ['bad_filename.mp4', 'camera@20210101000000+0000.mp4']
+        
+        with patch('os.listdir', return_value=files):
+            with patch('os.path.isfile', return_value=True):
+                with patch('frigate.record.maintainer.psutil.process_iter', return_value=[]):
+                    # Mock validate_and_move_segment to avoid further logic
+                    maintainer.validate_and_move_segment = MagicMock()
+                    
+                    try:
+                        await maintainer.move_files()
+                    except ValueError as e:
+                        if "not enough values to unpack" in str(e):
+                            self.fail("move_files() crashed on bad filename!")
+                        raise e
+                    except Exception:
+                        # Ignore other errors (like DB connection) as we only care about the unpack crash
+                        pass
+
+if __name__ == '__main__':
+    unittest.main()