Migrate web to ESLint 10 flat config (#24326)

* migrate web to eslint 10 flat config

ESLint 10 dropped `.eslintrc` support, so `.eslintrc.cjs` is replaced with `eslint.config.js` and the lint scripts no longer pass `--ext` or `--ignore-path`. typescript-eslint moves to 8, react-hooks to 7, and react-refresh to 0.5, and the unused jest and vitest-globals plugins are removed. Lint behaves as it did before: catch variables aren't checked, unused disable directives aren't reported, and rules newly added to the recommended sets are off until the code passes them. typescript-eslint 8 flags constants used only in `typeof`, so those are now exported, or replaced with a union type where the export would trip react-refresh.

* fix lint findings from the eslint 10 recommended rules

Remove the rule overrides from the flat config migration and fix what they were hiding. Unused catch bindings are dropped, 20 disable directives that suppressed nothing are removed (react-hooks 5.2 and 7.1.1 report identical exhaustive-deps findings with inline config ignored), dead initial values are dropped, short-circuit calls become if statements or optional calls, rethrown errors pass `cause`, and the disabled "No recordings" tooltip in `ReviewTimeline` is removed along with its memo and the `getRecordingAvailability` prop. The 3 react-refresh warnings for files that export contexts or classes are left for a later refactor.

web/src/utils/cameraUtil.ts

@@ -71,7 +71,7 @@ export async function detectReolinkCamera(
     }
 
     return null;
-  } catch (error) {
+  } catch {
     return null;
   }
 }
@@ -94,7 +94,7 @@ export function maskUri(uri: string): string {
       urlObj.searchParams.set("password", "*".repeat(4));
       return urlObj.toString();
     }
-  } catch (e) {
+  } catch {
     // ignore
   }
   return uri;

web/src/utils/dateUtil.ts

@@ -97,7 +97,7 @@ const formatMap: {
 const getResolvedTimeZone = () => {
   try {
     return Intl.DateTimeFormat().resolvedOptions().timeZone;
-  } catch (error) {
+  } catch {
     const offsetMinutes = new Date().getTimezoneOffset();
     return `UTC${offsetMinutes < 0 ? "+" : "-"}${Math.abs(offsetMinutes / 60)
       .toString()
@@ -224,7 +224,7 @@ export const formatUnixTimestampToDateTime = (
     }
 
     return formattedDateTime;
-  } catch (error) {
+  } catch {
     return "Invalid time";
   }
 };

web/src/utils/isIFrame.ts

@@ -1,7 +1,7 @@
 export const isInIframe = (() => {
   try {
     return window.self !== window.top;
-  } catch (e) {
+  } catch {
     // If we get a security error, we're definitely in an iframe
     return true;
   }

web/src/utils/lifecycleUtil.ts

@@ -42,7 +42,7 @@ export function getLifecycleItemDescription(
         label,
       });
     case "attribute": {
-      let title = "";
+      let title: string;
       if (
         lifecycleItem.data.attribute == "face" ||
         lifecycleItem.data.attribute == "license_plate"

web/src/utils/timelineUtil.tsx

@@ -13,7 +13,6 @@ export function getChunkedTimeDay(timeRange: TimeRange): TimeRange[] {
   const startDay = new Date(timeRange.after * 1000);
   startDay.setUTCMinutes(0, 0, 0);
   let start = startDay.getTime() / 1000;
-  let end = 0;
 
   for (let i = 0; i < 24; i++) {
     startDay.setHours(startDay.getHours() + 1);
@@ -22,7 +21,7 @@ export function getChunkedTimeDay(timeRange: TimeRange): TimeRange[] {
       break;
     }
 
-    end = endOfHourOrCurrentTime(startDay.getTime() / 1000);
+    const end = endOfHourOrCurrentTime(startDay.getTime() / 1000);
     data.push({
       after: start,
       before: end,

web/src/utils/zoneEdutUtil.ts

@@ -36,8 +36,6 @@ export const reviewQueries = (
   alertsZones: string[],
   detectionsZones: string[],
 ) => {
-  let alertQueries = "";
-  let detectionQueries = "";
   let same_alerts = false;
   let same_detections = false;
 
@@ -50,7 +48,7 @@ export const reviewQueries = (
     alerts.delete(name);
   }
 
-  alertQueries = [...alerts]
+  let alertQueries = [...alerts]
     .map((zone) => `&cameras.${camera}.review.alerts.required_zones=${zone}`)
     .join("");
 
@@ -63,7 +61,7 @@ export const reviewQueries = (
     detections.delete(name);
   }
 
-  detectionQueries = [...detections]
+  let detectionQueries = [...detections]
     .map(
       (zone) => `&cameras.${camera}.review.detections.required_zones=${zone}`,
     )