Always clear existing listener

This commit is contained in:
Nicolas Mowen 2024-03-07 15:17:43 -07:00
parent 581f292f35
commit c7c91e1ebc
2 changed files with 10 additions and 9 deletions

View File

@ -471,25 +471,25 @@ export class DynamicVideoController {
}
onPlayerTimeUpdate(listener: ((timestamp: number) => void) | undefined) {
if (this.playerProgressListener) {
this.playerRef.off("timeupdate", this.playerProgressListener);
}
if (listener) {
this.playerProgressListener = () =>
listener(this.getProgress(this.playerRef.currentTime() || 0));
this.playerRef.on("timeupdate", this.playerProgressListener);
} else {
if (this.playerProgressListener) {
this.playerRef.off("timeupdate", this.playerProgressListener);
}
}
}
onClipChangedEvent(listener: (dir: "forward") => void) {
if (listener) {
this.playerEndedListener = () => listener("forward");
this.playerRef.on("ended", this.playerEndedListener);
} else {
onClipChangedEvent(listener: ((dir: "forward") => void) | undefined) {
if (this.playerEndedListener) {
this.playerRef.off("ended", this.playerEndedListener);
}
if (listener) {
this.playerEndedListener = () => listener("forward");
this.playerRef.on("ended", this.playerEndedListener);
}
}

View File

@ -117,6 +117,7 @@ export function DesktopRecordingView({
const lastController = videoPlayersRef.current[mainCamera];
const newController = videoPlayersRef.current[newCam];
lastController.onPlayerTimeUpdate(undefined);
lastController.onClipChangedEvent(undefined);
lastController.scrubToTimestamp(currentTime);
newController.onCanPlay(() => {
newController.seekToTimestamp(currentTime, true);