administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-07-14 16:01:13 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

remove PENDING_REWARITE

Browse Source
This commit is contained in:
Josh Hawkins 2026-04-21 16:41:39 -05:00
parent 5ca0ce02e0
commit c6138a973e
1 changed files with 2 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
web/e2e/scripts/lint-specs.mjs
View File

@ -14,10 +14,6 @@
* *
* @mobile rule: every .spec.ts under specs/ (not specs/_meta/) must * @mobile rule: every .spec.ts under specs/ (not specs/_meta/) must
* contain at least one test title or describe with the substring "@mobile". * contain at least one test title or describe with the substring "@mobile".
*
* Specs in PENDING_REWRITE are exempt from all rules until they are
* rewritten with proper assertions and mobile coverage. Remove each
* entry when its spec is updated.
*/ */
import { readFileSync, readdirSync, statSync } from "node:fs"; import { readFileSync, readdirSync, statSync } from "node:fs";
@ -28,24 +24,6 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
const SPECS_DIR = resolve(__dirname, "..", "specs"); const SPECS_DIR = resolve(__dirname, "..", "specs");
const META_PREFIX = resolve(SPECS_DIR, "_meta"); const META_PREFIX = resolve(SPECS_DIR, "_meta");
// Specs exempt from lint rules until they are rewritten with proper
// assertions and mobile coverage. Remove each entry when its spec is updated.
const PENDING_REWRITE = new Set([
"auth.spec.ts",
"chat.spec.ts",
"classification.spec.ts",
"config-editor.spec.ts",
"explore.spec.ts",
"export.spec.ts",
"face-library.spec.ts",
"live.spec.ts",
"logs.spec.ts",
"navigation.spec.ts",
"replay.spec.ts",
"review.spec.ts",
"system.spec.ts",
]);
const BANNED_PATTERNS = [ const BANNED_PATTERNS = [
{ {
name: "page.waitForTimeout", name: "page.waitForTimeout",
@ -62,14 +40,12 @@ const BANNED_PATTERNS = [
{ {
name: "conditional count() assertion", name: "conditional count() assertion",
regex: /\bif\s*\(\s*\(?\s*await\s+[^)]*\.count\s*\(\s*\)\s*\)?\s*[><=!]/, regex: /\bif\s*\(\s*\(?\s*await\s+[^)]*\.count\s*\(\s*\)\s*\)?\s*[><=!]/,
advice: advice: "Assertions must be unconditional. Use expect(...).toHaveCount(n).",
"Assertions must be unconditional. Use expect(...).toHaveCount(n).",
}, },
{ {
name: "vacuous textContent length assertion", name: "vacuous textContent length assertion",
regex: /expect\([^)]*\.length\)\.toBeGreaterThan\(0\)/, regex: /expect\([^)]*\.length\)\.toBeGreaterThan\(0\)/,
advice: advice: "Assert specific content, not that some text exists.",
"Assert specific content, not that some text exists.",
}, },
]; ];
@ -89,8 +65,6 @@ function walk(dir) {
} }
function lintFile(file) { function lintFile(file) {
const basename = file.split("/").pop();
if (PENDING_REWRITE.has(basename)) return [];
if (file.includes("/specs/settings/")) return []; if (file.includes("/specs/settings/")) return [];
const errors = []; const errors = [];