Miscellaneous fixes (0.18 beta) (#23763)

web/src/components/config-form/section-configs/ffmpeg.ts

@@ -1,3 +1,4 @@
+import { parseRestreamStreamName } from "../theme/fields/streamSource";
 import type { SectionConfigOverrides } from "./types";
 
 const arrayAsTextWidget = {
@@ -42,6 +43,29 @@ const ffmpeg: SectionConfigOverrides = {
           return false;
         },
       },
+      {
+        key: "inputs-missing-go2rtc-stream",
+        field: "inputs",
+        position: "before",
+        messageKey: "configMessages.ffmpeg.inputsMissingGo2rtcStream",
+        severity: "warning",
+        docLink: "/configuration/restream",
+        condition: (ctx) => {
+          const streams = ctx.fullConfig?.go2rtc?.streams;
+          const inputs = ctx.formData?.inputs;
+          if (!Array.isArray(inputs)) {
+            return false;
+          }
+
+          return inputs.some((input) => {
+            const path = (input as { path?: unknown } | null)?.path;
+            const streamName = parseRestreamStreamName(
+              typeof path === "string" ? path : undefined,
+            );
+            return streamName !== undefined && !(streamName in (streams ?? {}));
+          });
+        },
+      },
     ],
     fieldDocs: {
       hwaccel_args: "/configuration/ffmpeg_presets#hwaccel-presets",

web/src/components/config-form/theme/fields/CameraInputsField.tsx

@@ -170,6 +170,12 @@ export function CameraInputsField(props: FieldProps) {
     [go2rtcStreamNames],
   );
 
+  useEffect(() => {
+    setSourceModeByIndex((previous) =>
+      Object.keys(previous).length > 0 ? {} : previous,
+    );
+  }, [formContext?.cameraName]);
+
   useEffect(() => {
     setOpenByIndex((previous) => {
       const next: Record<number, boolean> = {};
@@ -222,18 +228,12 @@ export function CameraInputsField(props: FieldProps) {
   const handleSourceModeChange = useCallback(
     (index: number, nextMode: StreamSourceMode) => {
       const input = inputs[index];
-      const currentPath =
-        typeof input?.path === "string" ? input.path : undefined;
 
-      if (nextMode === "manual") {
-        // Only revert the preset we set ourselves; never clobber custom args.
-        if (input?.input_args === RESTREAM_PRESET) {
-          handleFieldValuesChange(index, { input_args: undefined });
-        }
-      } else if (!parseRestreamStreamName(currentPath)) {
-        // Entering restream with a non-restream path: clear it so the dropdown
-        // shows its placeholder until a stream is chosen.
-        handleFieldValuesChange(index, { path: undefined });
+      // Only revert the preset we set ourselves; never clobber custom args.
+      // The path is left alone until a stream is picked, so switching modes
+      // never discards a typed URL or empties a required field.
+      if (nextMode === "manual" && input?.input_args === RESTREAM_PRESET) {
+        handleFieldValuesChange(index, { input_args: undefined });
       }
 
       setSourceModeByIndex((previous) => ({ ...previous, [index]: nextMode }));

web/src/components/config-form/theme/widgets/SemanticSearchModelSizeWidget.tsx

@@ -24,15 +24,19 @@ export function SemanticSearchModelSizeWidget(props: WidgetProps) {
     model !== "jinav1" &&
     model !== "jinav2";
 
-  // Clear model_size while on a provider (buildOverrides converts to ""
-  // which the backend treats as "remove"). Restore the schema default
-  // when returning to a Jina model so the field isn't left empty.
+  // model_size is unused on a GenAI provider. Only clear it (which the backend
+  // treats as "remove") for a non-default value, which can only come from the
+  // config file. A defaulted value is indistinguishable from unset in the
+  // resolved config, so clearing it would falsely dirty the field and delete a
+  // YAML key that isn't there. Restore the default when returning to a Jina model.
   const { value, onChange, schema } = props;
   const schemaDefault = schema?.default as string | undefined;
   useEffect(() => {
-    if (isProvider && value !== undefined) {
-      onChange(undefined);
-    } else if (!isProvider && value === undefined && schemaDefault) {
+    if (isProvider) {
+      if (value !== undefined && value !== schemaDefault) {
+        onChange(undefined);
+      }
+    } else if (value === undefined && schemaDefault) {
       onChange(schemaDefault);
     }
   }, [isProvider, value, onChange, schemaDefault]);