Miscellaneous fixes (0.18 beta) (#23763)

frigate/db/sqlitevecq.py

@@ -1,9 +1,12 @@
+import logging
 import sqlite3
 from typing import Any
 
 import regex
 from playhouse.sqliteq import SqliteQueueDatabase
 
+logger = logging.getLogger(__name__)
+
 REGEXP_TIMEOUT_SECONDS = 1.0
 
 
@@ -28,8 +31,14 @@ class SqliteVecQueueDatabase(SqliteQueueDatabase):
 
     def _load_vec_extension(self, conn: sqlite3.Connection) -> None:
         conn.enable_load_extension(True)
-        conn.load_extension(self.sqlite_vec_path)
-        conn.enable_load_extension(False)
+
+        try:
+            conn.load_extension(self.sqlite_vec_path)
+        except conn.OperationalError:
+            logger.error("Unable to load the sqlite-vec extension")
+            self.load_vec_extension = False
+        finally:
+            conn.enable_load_extension(False)
 
     def _register_regexp(self, conn: sqlite3.Connection) -> None:
         def regexp(expr: str, item: str | None) -> bool:
@@ -44,13 +53,33 @@ class SqliteVecQueueDatabase(SqliteQueueDatabase):
 
         conn.create_function("REGEXP", 2, regexp)
 
-    def delete_embeddings_thumbnail(self, event_ids: list[str]) -> None:
+    def _delete_embeddings(self, table: str, event_ids: list[str]) -> None:
+        """Delete embeddings for the given events, if the table exists.
+
+        Embeddings outlive the events they belong to when semantic search is
+        disabled, so deletes are attempted regardless of the current config.
+        """
+        if not event_ids or not self.load_vec_extension:
+            return
+
+        # the embeddings tables are only created once semantic search has run
+        cursor = self.execute_sql(
+            "SELECT name FROM sqlite_master WHERE type = 'table' AND name = ?",
+            (table,),
+        )
+
+        if cursor.fetchone() is None:
+            logger.debug("Skipping %s cleanup, table does not exist", table)
+            return
+
         ids = ",".join(["?" for _ in event_ids])
-        self.execute_sql(f"DELETE FROM vec_thumbnails WHERE id IN ({ids})", event_ids)
+        self.execute_sql(f"DELETE FROM {table} WHERE id IN ({ids})", event_ids)
+
+    def delete_embeddings_thumbnail(self, event_ids: list[str]) -> None:
+        self._delete_embeddings("vec_thumbnails", event_ids)
 
     def delete_embeddings_description(self, event_ids: list[str]) -> None:
-        ids = ",".join(["?" for _ in event_ids])
-        self.execute_sql(f"DELETE FROM vec_descriptions WHERE id IN ({ids})", event_ids)
+        self._delete_embeddings("vec_descriptions", event_ids)
 
     def drop_embeddings_tables(self) -> None:
         self.execute_sql("""