From b50ad87d34f2055ed40bbe202ef6fa347e0c6d1e Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Sun, 3 Mar 2024 12:30:59 -0600
Subject: [PATCH] mobile touch events

---
 .../timeline/EventReviewTimeline.tsx          | 19 +++++------
 web/src/hooks/use-handle-dragging.ts          | 34 +++++++++++++------
 2 files changed, 33 insertions(+), 20 deletions(-)

diff --git a/web/src/components/timeline/EventReviewTimeline.tsx b/web/src/components/timeline/EventReviewTimeline.tsx
index e78f9ff21..9942d73bf 100644
--- a/web/src/components/timeline/EventReviewTimeline.tsx
+++ b/web/src/components/timeline/EventReviewTimeline.tsx
@@ -159,14 +159,6 @@ export function EventReviewTimeline({
 
   useEffect(() => {
     generateSegments();
-
-    // TODO: touch events for mobile
-    document.addEventListener("mousemove", handleMouseMove);
-    document.addEventListener("mouseup", handleMouseUp);
-    return () => {
-      document.removeEventListener("mousemove", handleMouseMove);
-      document.removeEventListener("mouseup", handleMouseUp);
-    };
     // we know that these deps are correct
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [generateSegments, timelineStart, handleMouseUp, handleMouseMove]);
@@ -174,6 +166,10 @@ export function EventReviewTimeline({
   return (
     <div
       ref={timelineRef}
+      onMouseMove={handleMouseMove}
+      onTouchMove={handleMouseMove}
+      onMouseUp={handleMouseUp}
+      onTouchEnd={handleMouseUp}
       className={`relative h-full overflow-y-scroll no-scrollbar bg-secondary ${
         isDragging && showHandlebar ? "cursor-grabbing" : "cursor-auto"
       }`}
@@ -181,13 +177,16 @@ export function EventReviewTimeline({
       <div className="flex flex-col">{segments}</div>
       {showHandlebar && (
         <div className={`absolute left-0 top-0 z-20 w-full `} role="scrollbar">
-          <div className={`flex items-center justify-center `}>
+          <div
+            className="flex items-center justify-center touch-none select-none"
+            onMouseDown={handleMouseDown}
+            onTouchStart={handleMouseDown}
+          >
             <div
               ref={scrollTimeRef}
               className={`relative w-full ${
                 isDragging ? "cursor-grabbing" : "cursor-grab"
               }`}
-              onMouseDown={handleMouseDown}
             >
               <div
                 className={`bg-destructive rounded-full mx-auto ${
diff --git a/web/src/hooks/use-handle-dragging.ts b/web/src/hooks/use-handle-dragging.ts
index cf2f2e0a0..57a789f12 100644
--- a/web/src/hooks/use-handle-dragging.ts
+++ b/web/src/hooks/use-handle-dragging.ts
@@ -1,5 +1,5 @@
 import { useCallback, useEffect } from "react";
-import scrollIntoView from "scroll-into-view-if-needed";
+import { isMobile } from "react-device-detect";
 
 type DragHandlerProps = {
   contentRef: React.RefObject<HTMLElement>;
@@ -34,7 +34,9 @@ function useDraggableHandler({
   setIsDragging,
 }: DragHandlerProps) {
   const handleMouseDown = useCallback(
-    (e: React.MouseEvent<HTMLDivElement>) => {
+    (
+      e: React.MouseEvent<HTMLDivElement> | React.TouchEvent<HTMLDivElement>,
+    ) => {
       e.preventDefault();
       e.stopPropagation();
       setIsDragging(true);
@@ -43,7 +45,9 @@ function useDraggableHandler({
   );
 
   const handleMouseUp = useCallback(
-    (e: MouseEvent) => {
+    (
+      e: React.MouseEvent<HTMLDivElement> | React.TouchEvent<HTMLDivElement>,
+    ) => {
       e.preventDefault();
       e.stopPropagation();
       if (isDragging) {
@@ -76,10 +80,6 @@ function useDraggableHandler({
               minute: "2-digit",
               ...(segmentDuration < 60 && { second: "2-digit" }),
             });
-            scrollIntoView(thumb, {
-              scrollMode: "if-needed",
-              behavior: "smooth",
-            });
           }
         });
         if (setHandlebarTime) {
@@ -91,7 +91,9 @@ function useDraggableHandler({
   );
 
   const handleMouseMove = useCallback(
-    (e: MouseEvent) => {
+    (
+      e: React.MouseEvent<HTMLDivElement> | React.TouchEvent<HTMLDivElement>,
+    ) => {
       if (
         !contentRef.current ||
         !timelineRef.current ||
@@ -100,10 +102,17 @@ function useDraggableHandler({
         return;
       }
 
+      let clientY;
+      if (isMobile && e.nativeEvent instanceof TouchEvent) {
+        clientY = e.nativeEvent.touches[0].clientY;
+      } else if (e.nativeEvent instanceof MouseEvent) {
+        clientY = e.nativeEvent.clientY;
+      }
+
       e.preventDefault();
       e.stopPropagation();
 
-      if (showHandlebar && isDragging) {
+      if (showHandlebar && isDragging && clientY) {
         const {
           scrollHeight: timelineHeight,
           clientHeight: visibleTimelineHeight,
@@ -120,7 +129,7 @@ function useDraggableHandler({
           visibleTimelineHeight - timelineTop + parentScrollTop,
           Math.max(
             segmentHeight + scrolled,
-            e.clientY - timelineTop + parentScrollTop,
+            clientY - timelineTop + parentScrollTop,
           ),
         );
 
@@ -172,6 +181,11 @@ function useDraggableHandler({
         scrolled;
 
       updateHandlebarPosition(newHandlePosition - segmentHeight, handlebarTime);
+
+      scrollTimeRef.current.scrollIntoView({
+        behavior: "smooth",
+        block: "center",
+      });
     }
     // we know that these deps are correct
     // eslint-disable-next-line react-hooks/exhaustive-deps