administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-07-01 17:41:13 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add mismatch banner and gate save on detector and model compatibility

Browse Source
This commit is contained in:
Josh Hawkins 2026-05-16 11:23:10 -05:00
parent e7f047e915
commit aeeb48f7dd
1 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
web/src/views/settings/DetectorsAndModelSettingsView.tsx
View File

@ -1,5 +1,5 @@
import { useCallback, useContext, useEffect, useMemo, useState } from "react"; import { useCallback, useContext, useEffect, useMemo, useState } from "react";
import { useTranslation } from "react-i18next"; import { Trans, useTranslation } from "react-i18next";
import { Link } from "react-router-dom"; import { Link } from "react-router-dom";
import { LuExternalLink, LuFilter } from "react-icons/lu"; import { LuExternalLink, LuFilter } from "react-icons/lu";
import axios from "axios"; import axios from "axios";
@ -163,6 +163,18 @@ export default function DetectorsAndModelSettingsView(
[currentDetectorType], [currentDetectorType],
); );
const selectedPlusModel = state?.plusModelId
? availableModels?.[state.plusModelId]
: undefined;
const plusMismatch =
state?.modelTab === "plus" &&
selectedPlusModel !== undefined &&
currentDetectorType !== undefined &&
!isModelCompatible(selectedPlusModel);
const plusModelMissing = state?.modelTab === "plus" && !state?.plusModelId;
const handleChildPendingChange = useCallback( const handleChildPendingChange = useCallback(
( (
sectionKey: string, sectionKey: string,
@ -259,7 +271,9 @@ export default function DetectorsAndModelSettingsView(
!isDirty || !isDirty ||
isSaving || isSaving ||
detectorStatus.hasValidationErrors || detectorStatus.hasValidationErrors ||
(state.modelTab === "custom" && modelStatus.hasValidationErrors); (state.modelTab === "custom" && modelStatus.hasValidationErrors) ||
plusMismatch ||
plusModelMissing;
return ( return (
<div className="flex size-full flex-col md:pr-2"> <div className="flex size-full flex-col md:pr-2">
@ -306,6 +320,22 @@ export default function DetectorsAndModelSettingsView(
onStatusChange={handleDetectorStatusChange} onStatusChange={handleDetectorStatusChange}
/> />
</SettingsGroupCard> </SettingsGroupCard>
{plusMismatch && selectedPlusModel && (
<div className="rounded-md border border-danger bg-danger/10 px-4 py-3 text-sm text-danger">
<Trans
ns="views/settings"
i18nKey="detectorsAndModel.mismatch.warning"
values={{
model: selectedPlusModel.name,
required: selectedPlusModel.supportedDetectors.join(", "),
}}
components={{
0: <strong />,
1: <strong />,
}}
/>
</div>
)}
<SettingsGroupCard title={t("detectorsAndModel.cardTitles.model")}> <SettingsGroupCard title={t("detectorsAndModel.cardTitles.model")}>
<Tabs <Tabs
value={state.modelTab} value={state.modelTab}