diff --git a/frigate/api/fastapi_app.py b/frigate/api/fastapi_app.py index 40df19343..0657752dc 100644 --- a/frigate/api/fastapi_app.py +++ b/frigate/api/fastapi_app.py @@ -27,7 +27,6 @@ from frigate.comms.event_metadata_updater import ( ) from frigate.config import FrigateConfig from frigate.embeddings import EmbeddingsContext -from frigate.events.external import ExternalEventProcessor from frigate.ptz.onvif import OnvifController from frigate.stats.emitter import StatsEmitter from frigate.storage import StorageMaintainer @@ -56,7 +55,6 @@ def create_fastapi_app( detected_frames_processor, storage_maintainer: StorageMaintainer, onvif: OnvifController, - external_processor: ExternalEventProcessor, stats_emitter: StatsEmitter, event_metadata_updater: EventMetadataPublisher, ): @@ -129,7 +127,6 @@ def create_fastapi_app( app.onvif = onvif app.stats_emitter = stats_emitter app.event_metadata_updater = event_metadata_updater - app.external_processor = external_processor app.jwt_token = get_jwt_secret() if frigate_config.auth.enabled else None return app diff --git a/frigate/app.py b/frigate/app.py index d97b16d3d..f433fd50f 100644 --- a/frigate/app.py +++ b/frigate/app.py @@ -317,9 +317,6 @@ class FrigateApp: # Create a client for other processes to use self.embeddings = EmbeddingsContext(self.db) - def init_external_event_processor(self) -> None: - self.external_event_processor = ExternalEventProcessor(self.config) - def init_inter_process_communicator(self) -> None: self.inter_process_communicator = InterProcessCommunicator() self.inter_config_updater = ConfigPublisher() @@ -656,7 +653,6 @@ class FrigateApp: self.start_camera_capture_processes() self.start_audio_processor() self.start_storage_maintainer() - self.init_external_event_processor() self.start_stats_emitter() self.start_timeline_processor() self.start_event_processor() @@ -675,7 +671,6 @@ class FrigateApp: self.detected_frames_processor, self.storage_maintainer, self.onvif_controller, - self.external_event_processor, self.stats_emitter, self.event_metadata_updater, ), @@ -747,7 +742,6 @@ class FrigateApp: self.review_segment_process.terminate() self.review_segment_process.join() - self.external_event_processor.stop() self.dispatcher.stop() self.ptz_autotracker_thread.join() diff --git a/frigate/review/maintainer.py b/frigate/review/maintainer.py index e0a7eaa53..3541fef3b 100644 --- a/frigate/review/maintainer.py +++ b/frigate/review/maintainer.py @@ -23,10 +23,9 @@ from frigate.const import ( CLIPS_DIR, UPSERT_REVIEW_SEGMENT, ) -from frigate.events.external import ManualEventState from frigate.models import ReviewSegment -from frigate.track.object_processing import TrackedObject from frigate.review.types import SeverityEnum +from frigate.track.object_processing import ManualEventState, TrackedObject from frigate.util.image import SharedMemoryFrameManager, calculate_16_9_crop logger = logging.getLogger(__name__) diff --git a/frigate/track/object_processing.py b/frigate/track/object_processing.py index 554584932..ddac2b588 100644 --- a/frigate/track/object_processing.py +++ b/frigate/track/object_processing.py @@ -63,7 +63,7 @@ class TrackedObjectProcessor(threading.Thread): self.config_enabled_subscriber = ConfigSubscriber("config/enabled/") self.requestor = InterProcessRequestor() - self.detection_publisher = DetectionPublisher(DetectionTypeEnum.video) + self.detection_publisher = DetectionPublisher(DetectionTypeEnum.all) self.event_sender = EventUpdatePublisher() self.event_end_subscriber = EventEndSubscriber() self.sub_label_subscriber = EventMetadataSubscriber(EventMetadataTypeEnum.all) @@ -404,7 +404,8 @@ class TrackedObjectProcessor(threading.Thread): "event_id": event_id, "end_time": end_time, }, - ) + ), + DetectionTypeEnum.api.value, ) def end_manual_event(self, payload: tuple) -> None: @@ -430,7 +431,8 @@ class TrackedObjectProcessor(threading.Thread): "event_id": event_id, "end_time": end_time, }, - ) + ), + DetectionTypeEnum.api.value, ) self.ongoing_manual_events.pop(event_id) @@ -508,8 +510,7 @@ class TrackedObjectProcessor(threading.Thread): elif topic.endswith(EventMetadataTypeEnum.manual_event_create.value): self.create_manual_event(payload) elif topic.endswith(EventMetadataTypeEnum.manual_event_end.value): - camera_name = payload[0] - self.camera_states[camera_name].process_manual_event(topic, payload) + self.end_manual_event(payload) try: ( @@ -548,7 +549,8 @@ class TrackedObjectProcessor(threading.Thread): tracked_objects, motion_boxes, regions, - ) + ), + DetectionTypeEnum.video.value, ) # cleanup event finished queue