From a759987cae54b9e868c769b3c15cfff73d3a57b3 Mon Sep 17 00:00:00 2001 From: ryzendigo Date: Tue, 17 Mar 2026 06:56:24 +0800 Subject: [PATCH] fix: correct or operator in review maintainer topic dispatch The condition evaluates as (topic == api.value) or (lpr.value), where the second operand is always truthy. This causes the elif branch to execute for any topic that falls through the earlier conditions, leading to incorrect tuple unpacking. Same pattern as the fix applied in record/maintainer.py. --- frigate/review/maintainer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frigate/review/maintainer.py b/frigate/review/maintainer.py index a51c73f88..1852fd565 100644 --- a/frigate/review/maintainer.py +++ b/frigate/review/maintainer.py @@ -642,7 +642,7 @@ class ReviewSegmentMaintainer(threading.Thread): _, audio_detections, ) = data - elif topic == DetectionTypeEnum.api.value or DetectionTypeEnum.lpr.value: + elif topic == DetectionTypeEnum.api.value or topic == DetectionTypeEnum.lpr.value: ( camera, frame_time,