Refactor move_preview_frames function (#23264)
Some checks are pending
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / Jetson Jetpack 6 (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions

Refactor move_preview_frames to simplify logic and improve error handling.
This commit is contained in:
Sean Kelly 2026-05-20 09:52:47 -07:00 committed by GitHub
parent 8ea46e7c6c
commit a576ad5218
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -342,20 +342,30 @@ def move_preview_frames(loc: str) -> None:
preview_holdover = os.path.join(CLIPS_DIR, "preview_restart_cache")
preview_cache = os.path.join(CACHE_DIR, "preview_frames")
try:
if loc == "clips":
shutil.move(preview_cache, preview_holdover)
src = preview_cache
dst = preview_holdover
elif loc == "cache":
if not os.path.exists(preview_holdover):
src = preview_holdover
dst = preview_cache
else:
return
if not os.access(preview_holdover, os.R_OK | os.W_OK):
try:
if not os.path.exists(src):
return
shutil.move(src, dst)
except PermissionError:
logger.error(
"Insufficient permissions on preview restart cache at %s",
preview_holdover,
"Insufficient permissions while moving preview restart cache from %s to %s",
src,
dst,
)
return
shutil.move(preview_holdover, preview_cache)
except shutil.Error:
logger.error("Failed to restore preview cache.")
logger.error(
"Failed to move preview restart cache from %s to %s",
src,
dst,
)