Set modified time on case zip entries (#24803)
CI / AMD64 Build (push) Canceled after 0s
CI / AMD64 Smoke Test (push) Canceled after 0s
CI / ARM Build (push) Canceled after 0s
CI / Jetson Jetpack 6 (push) Canceled after 0s
CI / AMD64 Extra Build (push) Canceled after 0s
CI / ARM Extra Build (push) Canceled after 0s
CI / Synaptics Build (push) Canceled after 0s
CI / Assemble and push default build (push) Canceled after 0s

* set modified time on case download zip entries

Case download zip entries were written with the zip format's 1980 placeholder date, so extracted files showed a blank or 1980 modified date. Each entry now uses the export's recording start time, converted with the UI timezone since zip times have no zone and extractors read them as local time.

* clamp case zip entry dates to 1980
This commit is contained in:
Josh Hawkins
2026-10-26 13:17:48 -05:00
committed by GitHub
parent 0dc05305ae
commit 9769741713
2 changed files with 62 additions and 5 deletions
+33 -1
View File
@@ -4,7 +4,7 @@ import unittest
from pathlib import Path
from unittest.mock import MagicMock, patch
from frigate.api.export import _unique_archive_name
from frigate.api.export import _archive_entry, _unique_archive_name
from frigate.const import MAX_PLAYLIST_SECONDS
from frigate.models import Export
from frigate.record.export import (
@@ -220,6 +220,38 @@ class TestUniqueArchiveName(unittest.TestCase):
)
class TestArchiveEntry(unittest.TestCase):
"""Tests for the modified time stamped on case download zip entries."""
def build_export(self) -> Export:
return Export(
id="front_door_abc123",
camera="front_door",
name="front door",
date=1756000000.0,
video_path="/media/frigate/exports/front_door_abc123.mp4",
thumb_path="/media/frigate/exports/front_door_abc123.webp",
in_progress=False,
)
def test_uses_start_time_in_ui_timezone(self):
zinfo = _archive_entry(self.build_export(), "a.mp4", "America/New_York")
self.assertEqual(zinfo.date_time, (2025, 8, 23, 21, 46, 40))
def test_clamps_dates_before_1980(self):
export = self.build_export()
export.date = 100
zinfo = _archive_entry(export, "a.mp4", "UTC")
self.assertEqual(zinfo.date_time, (1980, 1, 1, 0, 0, 0))
def test_invalid_timezone_falls_back_to_local_time(self):
zinfo = _archive_entry(self.build_export(), "a.mp4", "Not/A_Real_Zone")
self.assertEqual(
zinfo.date_time,
_archive_entry(self.build_export(), "a.mp4", None).date_time,
)
if __name__ == "__main__":
unittest.main()