From eefa532ecc0f32d0117d92444394b081c33bc038 Mon Sep 17 00:00:00 2001 From: Nicolas Mowen Date: Thu, 4 Dec 2025 12:25:51 -0700 Subject: [PATCH 1/5] Improve model titles --- web/public/locales/en/views/classificationModel.json | 2 +- web/src/views/classification/ModelTrainingView.tsx | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/web/public/locales/en/views/classificationModel.json b/web/public/locales/en/views/classificationModel.json index 1b1ec811a..aecf3ca89 100644 --- a/web/public/locales/en/views/classificationModel.json +++ b/web/public/locales/en/views/classificationModel.json @@ -1,5 +1,5 @@ { - "documentTitle": "Classification Models", + "documentTitle": "Classification Models - Frigate", "details": { "scoreInfo": "Score represents the average classification confidence across all detections of this object." }, diff --git a/web/src/views/classification/ModelTrainingView.tsx b/web/src/views/classification/ModelTrainingView.tsx index d6d03c6cc..f9c1044ef 100644 --- a/web/src/views/classification/ModelTrainingView.tsx +++ b/web/src/views/classification/ModelTrainingView.tsx @@ -84,6 +84,12 @@ export default function ModelTrainingView({ model }: ModelTrainingViewProps) { const [page, setPage] = useState("train"); const [pageToggle, setPageToggle] = useOptimisticState(page, setPage, 100); + // title + + useEffect(() => { + document.title = `${model.name} - ${t("documentTitle")}`; + }, [model.name, t]); + // model state const [wasTraining, setWasTraining] = useState(false); From 4d4aa1f41086bfb3eb82147a461861eb787773f5 Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Fri, 5 Dec 2025 09:51:28 -0600 Subject: [PATCH 2/5] remove deprecated strftime_fmt --- docs/docs/configuration/reference.md | 4 ---- frigate/config/ui.py | 3 --- web/public/locales/en/config/ui.json | 5 +---- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/docs/docs/configuration/reference.md b/docs/docs/configuration/reference.md index a375086cb..6dde92fbe 100644 --- a/docs/docs/configuration/reference.md +++ b/docs/docs/configuration/reference.md @@ -1002,10 +1002,6 @@ ui: # full: 8:15:22 PM Mountain Standard Time # (default: shown below). time_style: medium - # Optional: Ability to manually override the date / time styling to use strftime format - # https://www.gnu.org/software/libc/manual/html_node/Formatting-Calendar-Time.html - # possible values are shown above (default: not set) - strftime_fmt: "%Y/%m/%d %H:%M" # Optional: Set the unit system to either "imperial" or "metric" (default: metric) # Used in the UI and in MQTT topics unit_system: metric diff --git a/frigate/config/ui.py b/frigate/config/ui.py index 2f66aeed3..8e0d4d77d 100644 --- a/frigate/config/ui.py +++ b/frigate/config/ui.py @@ -37,9 +37,6 @@ class UIConfig(FrigateBaseModel): time_style: DateTimeStyleEnum = Field( default=DateTimeStyleEnum.medium, title="Override UI timeStyle." ) - strftime_fmt: Optional[str] = Field( - default=None, title="Override date and time format using strftime syntax." - ) unit_system: UnitSystemEnum = Field( default=UnitSystemEnum.metric, title="The unit system to use for measurements." ) diff --git a/web/public/locales/en/config/ui.json b/web/public/locales/en/config/ui.json index fec0a9528..cdd91cb53 100644 --- a/web/public/locales/en/config/ui.json +++ b/web/public/locales/en/config/ui.json @@ -13,11 +13,8 @@ "time_style": { "label": "Override UI timeStyle." }, - "strftime_fmt": { - "label": "Override date and time format using strftime syntax." - }, "unit_system": { "label": "The unit system to use for measurements." } } -} \ No newline at end of file +} From 874138c2731b12fe3a30c3fb9c412c3c096e361b Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Fri, 5 Dec 2025 09:51:38 -0600 Subject: [PATCH 3/5] remove --- web/src/types/frigateConfig.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/web/src/types/frigateConfig.ts b/web/src/types/frigateConfig.ts index 985fe3457..94c9ba6e9 100644 --- a/web/src/types/frigateConfig.ts +++ b/web/src/types/frigateConfig.ts @@ -6,7 +6,6 @@ export interface UiConfig { time_format?: "browser" | "12hour" | "24hour"; date_style?: "full" | "long" | "medium" | "short"; time_style?: "full" | "long" | "medium" | "short"; - strftime_fmt?: string; dashboard: boolean; order: number; unit_system?: "metric" | "imperial"; From 7dd96d02d07a186e27ec76c89eb2b75a97d5997d Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Fri, 5 Dec 2025 09:52:01 -0600 Subject: [PATCH 4/5] remove restart wording --- docs/docs/configuration/masks.md | 1 - web/public/locales/en/views/explore.json | 2 +- web/public/locales/en/views/settings.json | 10 +++++----- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/docs/configuration/masks.md b/docs/docs/configuration/masks.md index 4b57be964..4a4722586 100644 --- a/docs/docs/configuration/masks.md +++ b/docs/docs/configuration/masks.md @@ -28,7 +28,6 @@ To create a poly mask: 5. Click the plus icon under the type of mask or zone you would like to create 6. Click on the camera's latest image to create the points for a masked area. Click the first point again to close the polygon. 7. When you've finished creating your mask, press Save. -8. Restart Frigate to apply your changes. Your config file will be updated with the relative coordinates of the mask/zone: diff --git a/web/public/locales/en/views/explore.json b/web/public/locales/en/views/explore.json index 3f057c38d..6c938c109 100644 --- a/web/public/locales/en/views/explore.json +++ b/web/public/locales/en/views/explore.json @@ -77,7 +77,7 @@ "millisecondsToOffset": "Milliseconds to offset detect annotations by. Default: 0", "tips": "Lower the value if the video playback is ahead of the boxes and path points, and increase the value if the video playback is behind them. This value can be negative.", "toast": { - "success": "Annotation offset for {{camera}} has been saved to the config file. Restart Frigate to apply your changes." + "success": "Annotation offset for {{camera}} has been saved to the config file." } } }, diff --git a/web/public/locales/en/views/settings.json b/web/public/locales/en/views/settings.json index 22dae29de..7ffd29007 100644 --- a/web/public/locales/en/views/settings.json +++ b/web/public/locales/en/views/settings.json @@ -534,7 +534,7 @@ } }, "toast": { - "success": "Zone ({{zoneName}}) has been saved. Restart Frigate to apply changes." + "success": "Zone ({{zoneName}}) has been saved." } }, "motionMasks": { @@ -558,8 +558,8 @@ }, "toast": { "success": { - "title": "{{polygonName}} has been saved. Restart Frigate to apply changes.", - "noName": "Motion Mask has been saved. Restart Frigate to apply changes." + "title": "{{polygonName}} has been saved.", + "noName": "Motion Mask has been saved." } } }, @@ -583,8 +583,8 @@ }, "toast": { "success": { - "title": "{{polygonName}} has been saved. Restart Frigate to apply changes.", - "noName": "Object Mask has been saved. Restart Frigate to apply changes." + "title": "{{polygonName}} has been saved.", + "noName": "Object Mask has been saved." } } } From 83377d98a0c14b693a76d8e8f2f47d9a07d83bd1 Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Fri, 5 Dec 2025 11:02:29 -0600 Subject: [PATCH 5/5] add copilot instructions --- .github/copilot-instructions.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .github/copilot-instructions.md diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md new file mode 100644 index 000000000..6c14bb166 --- /dev/null +++ b/.github/copilot-instructions.md @@ -0,0 +1,2 @@ +Never write strings in the frontend directly, always write to and reference the relevant translations file. +Always conform new and refactored code to the existing coding style in the project.