From 8823818b5794a63f2b0f469c900aafb83016370c Mon Sep 17 00:00:00 2001 From: Nicolas Mowen Date: Sun, 11 Feb 2024 07:06:16 -0700 Subject: [PATCH] Fix gif creation and add better error handling (#9797) * Add better error handling * Fix end_ts logic * Formatting --- frigate/http.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/frigate/http.py b/frigate/http.py index d589186d8..3c35c290e 100644 --- a/frigate/http.py +++ b/frigate/http.py @@ -617,7 +617,9 @@ def event_preview(id: str, max_cache_age=2592000): ) start_ts = event.start_time - end_ts = min(event.end_time - event.start_time, 20) if event.end_time else 20 + end_ts = ( + start_ts + min(event.end_time - event.start_time, 20) if event.end_time else 20 + ) if datetime.fromtimestamp(event.start_time) < datetime.now().replace( minute=0, second=0 @@ -677,6 +679,14 @@ def event_preview(id: str, max_cache_age=2592000): ffmpeg_cmd, capture_output=True, ) + + if process.returncode != 0: + logger.error(process.stderr) + return make_response( + jsonify({"success": False, "message": "Unable to create preview gif"}), + 500, + ) + gif_bytes = process.stdout else: # need to generate from existing images @@ -737,6 +747,7 @@ def event_preview(id: str, max_cache_age=2592000): ) if process.returncode != 0: + logger.error(process.stderr) return make_response( jsonify({"success": False, "message": "Unable to create preview gif"}), 500,