From 863914bd09802e5e7ed2e866537f7c632fa91926 Mon Sep 17 00:00:00 2001 From: Nicolas Mowen Date: Thu, 4 Apr 2024 07:47:41 -0600 Subject: [PATCH] Fix export --- web/src/views/events/RecordingView.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/web/src/views/events/RecordingView.tsx b/web/src/views/events/RecordingView.tsx index c6cc866e9..dbcc37752 100644 --- a/web/src/views/events/RecordingView.tsx +++ b/web/src/views/events/RecordingView.tsx @@ -142,7 +142,7 @@ export function RecordingView({ ); useEffect(() => { - if (scrubbing) { + if (scrubbing || exportRange) { if ( currentTime > currentTimeRange.before + 60 || currentTime < currentTimeRange.after - 60 @@ -157,6 +157,8 @@ export function RecordingView({ controller.scrubToTimestamp(currentTime); }); } + // we only want to seek when current time updates + // eslint-disable-next-line react-hooks/exhaustive-deps }, [ currentTime, scrubbing, @@ -486,7 +488,9 @@ function Timeline({ setExportRange({ after: exportStart, before: exportEnd }); } - }, [exportRange, exportStart, exportEnd, setExportRange, setCurrentTime]); + // we only want to update when the export parts change + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [exportStart, exportEnd, setExportRange, setCurrentTime]); return (