Refactor Notices and System Health pane (#24243)

* refactor notices

* show startup message for enrichments in health pane

* tweaks

frigate/api/notices.py

@@ -7,7 +7,6 @@ from fastapi.responses import JSONResponse
 
 from frigate.api.auth import require_role
 from frigate.api.defs.tags import Tags
-from frigate.notices.registry import DismissResult
 
 logger = logging.getLogger(__name__)
 
@@ -16,13 +15,13 @@ router = APIRouter(tags=[Tags.notices])
 
 @router.get("/notices", dependencies=[Depends(require_role(["admin"]))])
 def get_notices(request: Request, include_dismissed: bool = False) -> JSONResponse:
-    """Get the active notices, most severe first.
+    """Get notices, most severe first.
 
     Args:
-        include_dismissed: Also return event notices the user has dismissed
+        include_dismissed: Also return dismissed notices, for the history view
 
     Returns:
-        The active notices
+        The notices
     """
     return JSONResponse(
         content=request.app.notice_registry.active(include_dismissed=include_dismissed)
@@ -35,26 +34,37 @@ def get_notice_stats(request: Request) -> JSONResponse:
     return JSONResponse(content=request.app.notice_registry.stats())
 
 
+@router.get(
+    "/notices/dismissed_checks", dependencies=[Depends(require_role(["admin"]))]
+)
+def get_dismissed_checks(request: Request) -> JSONResponse:
+    """Get the dismissed config and stream check rows, newest first."""
+    return JSONResponse(content=request.app.notice_registry.dismissed_checks())
+
+
+@router.delete("/notices/dismissed", dependencies=[Depends(require_role(["admin"]))])
+def purge_dismissed(request: Request) -> JSONResponse:
+    """Delete every dismissed notice and check row so each can show again."""
+    request.app.notice_registry.purge_dismissed()
+    return JSONResponse(
+        content={"success": True, "message": "Dismissed notices cleared"}
+    )
+
+
+# model notice ids contain a slash, so the id is a path parameter
 @router.post(
-    "/notices/{notice_id}/dismiss", dependencies=[Depends(require_role(["admin"]))]
+    "/notices/{notice_id:path}/dismiss",
+    dependencies=[Depends(require_role(["admin"]))],
 )
 def dismiss_notice(request: Request, notice_id: str) -> JSONResponse:
-    """Hide an event notice until it is raised again."""
-    result = request.app.notice_registry.dismiss(notice_id)
+    """Hide a notice or a config or stream check row.
 
-    if result == DismissResult.not_found:
+    It stays hidden if the same problem happens again.
+    """
+    if not request.app.notice_registry.dismiss(notice_id):
         return JSONResponse(
             content={"success": False, "message": "Notice not found"},
             status_code=404,
         )
 
-    if result == DismissResult.not_dismissable:
-        return JSONResponse(
-            content={
-                "success": False,
-                "message": "This notice clears itself when the problem is fixed",
-            },
-            status_code=400,
-        )
-
     return JSONResponse(content={"success": True, "message": "Notice dismissed"})