Merge detector and model in settings UI (#23216)

* add embedded mode to BaseSection so parents can host the save action * add optional action slot to current Frigate+ model summary * add w-full to action slot flex wrapper for explicit width contract * i18n * merged detectors and model settings view * fix document title * Embed detector form in merged settings view * add detection model card with tabs and custom model embed * add Frigate+ model selector with filter popover to merged page * Add mismatch banner and gate save on detector and model compatibility * Wire atomic save, restart toast, and undo on detectors and model page * Clear child pending data on undo * route merged detectors and model view in settings * trim Frigate+ page to account-only and remove old detection model view * basic e2e * Fix unsaved-changes guard, custom path leak, and post-failure cache resync * Rename to Detectors and model, float Modified badge, use ConfigMessageBanner for mismatch * Hide Plus/Custom tabs when Frigate+ is not enabled * Detect active Plus model via model.plus.id instead of path prefix * Sync state back to snapshot when child form un-modifies and remount on undo * Always require restart on save since model changes also need one * Wrap Frigate+ model selector in SplitCardRow with label and description * rename tab * update docs * sync top-level model with default detector's resolved model when the user doesn't define a top-level `model:` block, `FrigateConfig.model` stayed at pydantic field defaults (320×320, /labelmap.txt) while the per-detector model picked up `DEFAULT_MODEL` for openvino on cpu (300×300, coco_91cl_bkgr.txt introduced in #23127), causing `RemoteObjectDetector` to fail with "buffer is too small for requested array" because the SHM was sized from the per-detector model but mapped using the top-level one. After the detector loop, copy the first detector's resolved model up to `self.model` so both sides agree on dimensions and labelmap * revert to cpu detector by default use openvino cpu for new configs only * add defaults
2026-08-02 09:02:15 +03:00 · 2026-05-17 11:54:21 -06:00
parent b712e1fbd9
commit 7413ce08d4
18 changed files with 1107 additions and 719 deletions
@@ -0,0 +1,55 @@
+/**
+ * Detectors and model settings page tests -- HIGH tier.
+ *
+ * Tests rendering of the merged page and navigation from the Frigate+ page.
+ */
+
+import { test, expect } from "../../fixtures/frigate-test";
+
+test.describe("Detectors and model Settings @high", () => {
+  test("page renders with detector and model cards", async ({ frigateApp }) => {
+    await frigateApp.goto("/settings?page=systemDetectorsAndModel");
+    await frigateApp.page.waitForTimeout(2000);
+    await expect(frigateApp.page.locator("#pageRoot")).toBeVisible();
+
+    const text = await frigateApp.page.textContent("#pageRoot");
+    expect(text).toContain("Detectors and model");
+    expect(text?.toLowerCase()).toContain("detector hardware");
+    expect(text?.toLowerCase()).toContain("detection model");
+  });
+
+  test("Frigate+ page links to the merged page", async ({ frigateApp }) => {
+    await frigateApp.goto("/settings?page=frigateplus");
+    await frigateApp.page.waitForTimeout(2000);
+
+    const button = frigateApp.page.getByRole("button", {
+      name: /Change in Detectors and model/,
+    });
+
+    // Button only appears when Frigate+ is enabled in the test config; skip
+    // the click assertion if it's not present.
+    if ((await button.count()) > 0) {
+      await button.first().click();
+      await frigateApp.page.waitForURL(/page=systemDetectorsAndModel/);
+      await expect(frigateApp.page.locator("#pageRoot")).toContainText(
+        "Detectors and model",
+      );
+    } else {
+      test.skip(
+        true,
+        "Frigate+ not enabled in this test config; skipping link assertion",
+      );
+    }
+  });
+
+  test("old systemDetectionModel deep-link no longer routes here", async ({
+    frigateApp,
+  }) => {
+    await frigateApp.goto("/settings?page=systemDetectionModel");
+    await frigateApp.page.waitForTimeout(2000);
+    // The old page key is no longer in allSettingsViews; the router
+    // falls back to its default settings page (uiSettings).
+    const text = await frigateApp.page.textContent("#pageRoot");
+    expect(text).not.toContain("Detection model");
+  });
+});