From 73dfdad4c75b051732ac62f3eb1abb2545fd71a1 Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Thu, 1 Feb 2024 09:48:57 -0600
Subject: [PATCH] catch exceptions for unsupported cameras

---
 frigate/ptz/onvif.py | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/frigate/ptz/onvif.py b/frigate/ptz/onvif.py
index a6495b6c7..06570a7d3 100644
--- a/frigate/ptz/onvif.py
+++ b/frigate/ptz/onvif.py
@@ -528,24 +528,25 @@ class OnvifController:
         except Exception:
             pass  # We're unsupported, that'll be reported in the next check.
 
-        # there doesn't seem to be an onvif standard with this optional parameter
-        # some cameras can report MoveStatus with or without PanTilt or Zoom attributes
-        pan_tilt_status = getattr(status.MoveStatus, "PanTilt", None)
-        zoom_status = getattr(status.MoveStatus, "Zoom", None)
+        try:
+            pan_tilt_status = getattr(status.MoveStatus, "PanTilt", None)
+            zoom_status = getattr(status.MoveStatus, "Zoom", None)
 
-        # if it's not an attribute, see if MoveStatus even exists in the status result
-        if pan_tilt_status is None:
-            pan_tilt_status = getattr(status, "MoveStatus", None)
+            # if it's not an attribute, see if MoveStatus even exists in the status result
+            if pan_tilt_status is None:
+                pan_tilt_status = getattr(status, "MoveStatus", None)
 
-            # we're unsupported
-            if pan_tilt_status is None or pan_tilt_status not in [
-                "IDLE",
-                "MOVING",
-            ]:
-                logger.error(
-                    f"Camera {camera_name} does not support the ONVIF GetStatus method. Autotracking will not function correctly and must be disabled in your config."
-                )
-                return
+                # we're unsupported
+                if pan_tilt_status is None or pan_tilt_status not in [
+                    "IDLE",
+                    "MOVING",
+                ]:
+                    raise Exception
+        except Exception:
+            logger.warning(
+                f"Camera {camera_name} does not support the ONVIF GetStatus method. Autotracking will not function correctly and must be disabled in your config."
+            )
+            return
 
         if pan_tilt_status == "IDLE" and (zoom_status is None or zoom_status == "IDLE"):
             self.cams[camera_name]["active"] = False