From 6af95b74872df4e6446e3a30ba69ee4fc8ef804d Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Sun, 8 Dec 2024 13:11:23 -0600
Subject: [PATCH] ensure speed estimation is disabled when user adds more than
 4 points

---
 web/src/components/settings/ZoneEditPane.tsx | 21 +++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/web/src/components/settings/ZoneEditPane.tsx b/web/src/components/settings/ZoneEditPane.tsx
index aee16ec60..ec60086c5 100644
--- a/web/src/components/settings/ZoneEditPane.tsx
+++ b/web/src/components/settings/ZoneEditPane.tsx
@@ -90,7 +90,7 @@ export default function ZoneEditPane({
 
     return Array.isArray(distances)
       ? distances.map((value) => parseFloat(value) || 0)
-      : [0, 0, 0, 0];
+      : [undefined, undefined, undefined, undefined];
   }, [polygon, config]);
 
   const formSchema = z
@@ -197,7 +197,7 @@ export default function ZoneEditPane({
 
   const form = useForm<z.infer<typeof formSchema>>({
     resolver: zodResolver(formSchema),
-    mode: "onChange",
+    mode: "onBlur",
     defaultValues: {
       name: polygon?.name ?? "",
       inertia:
@@ -218,6 +218,19 @@ export default function ZoneEditPane({
     },
   });
 
+  useEffect(() => {
+    if (
+      form.watch("speedEstimation") &&
+      polygon &&
+      polygon.points.length !== 4
+    ) {
+      toast.error(
+        "Speed estimation has been disabled for this zone. Zones with speed estimation must have exactly 4 points.",
+      );
+      form.setValue("speedEstimation", false);
+    }
+  }, [polygon, form]);
+
   const saveToConfig = useCallback(
     async (
       {
@@ -746,7 +759,9 @@ export function ZoneObjectSelector({
 
   useEffect(() => {
     updateLabelFilter(currentLabels);
-  }, [currentLabels, updateLabelFilter]);
+    // we know that these deps are correct
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [currentLabels]);
 
   return (
     <>