From 67a1531da0dea68989185792a476c26b888dd67f Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Sun, 5 Apr 2026 11:08:23 -0500 Subject: [PATCH] Tweaks (#22770) * radix pointer events fix * add debug log for no genai responses * tweak profiles docs * add weblate to maintainers list --- .github/workflows/pr_template_check.yml | 2 +- docs/docs/configuration/profiles.md | 8 ++++---- frigate/genai/__init__.py | 3 +++ web/src/components/card/ReviewCard.tsx | 2 +- web/src/components/menu/LiveContextMenu.tsx | 2 +- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pr_template_check.yml b/.github/workflows/pr_template_check.yml index 6b7d950e3..57db79ecc 100644 --- a/.github/workflows/pr_template_check.yml +++ b/.github/workflows/pr_template_check.yml @@ -16,7 +16,7 @@ jobs: uses: actions/github-script@v7 with: script: | - const maintainers = ['blakeblackshear', 'NickM-27', 'hawkeye217', 'dependabot[bot]']; + const maintainers = ['blakeblackshear', 'NickM-27', 'hawkeye217', 'dependabot[bot]', 'weblate']; const author = context.payload.pull_request.user.login; if (maintainers.includes(author)) { diff --git a/docs/docs/configuration/profiles.md b/docs/docs/configuration/profiles.md index b290d30f7..acb6cf482 100644 --- a/docs/docs/configuration/profiles.md +++ b/docs/docs/configuration/profiles.md @@ -20,7 +20,7 @@ When a profile is activated, Frigate merges each camera's profile overrides on t :::info -Profile changes are applied in-memory and take effect immediately — no restart is required. The active profile is persisted across Frigate restarts (stored in the `/config/.active_profile` file). +Profile changes are applied in-memory and take effect immediately — no restart is required. The active profile is persisted across Frigate restarts (stored in the `/config/.profiles` file). ::: @@ -130,14 +130,14 @@ Profiles can be activated and deactivated from the Frigate UI. Open the Settings ## Example: Home / Away Setup -A common use case is having different detection and notification settings based on whether you are home or away. +A common use case is having different detection and notification settings based on whether you are home or away. This example below is for a system with two cameras, `front_door` and `indoor_cam`. 1. Navigate to and create two profiles: **Home** and **Away**. -2. For the **front_door** camera, configure the **Away** profile to enable notifications and set alert labels to `person` and `car`. Configure the **Home** profile to disable notifications. -3. For the **indoor_cam** camera, configure the **Away** profile to enable the camera, detection, and recording. Configure the **Home** profile to disable the camera entirely for privacy. +2. From to the Camera configuration section in Settings, choose the **front_door** camera, and select the **Away** profile from the profile dropdown. Then, enable notifications from the Notifications pane, and set alert labels to `person` and `car` from the Review pane. Then, from the profile dropdown choose **Home** profile, then navigate to Notifications to disable notifications. +3. For the **indoor_cam** camera, perform similar steps - configure the **Away** profile to enable the camera, detection, and recording. Configure the **Home** profile to disable the camera entirely for privacy. 4. Activate the desired profile from or from the **Profiles** option in Frigate's main menu. diff --git a/frigate/genai/__init__.py b/frigate/genai/__init__.py index 438661f5d..d80e53b2e 100644 --- a/frigate/genai/__init__.py +++ b/frigate/genai/__init__.py @@ -199,6 +199,9 @@ Each line represents a detection state, not necessarily unique individuals. The ) return None else: + logger.debug( + f"Invalid response received from GenAI provider for review description on {review_data['camera']}. Response: {response}", + ) return None def generate_review_summary( diff --git a/web/src/components/card/ReviewCard.tsx b/web/src/components/card/ReviewCard.tsx index bf256ab5e..0ae8d376d 100644 --- a/web/src/components/card/ReviewCard.tsx +++ b/web/src/components/card/ReviewCard.tsx @@ -275,7 +275,7 @@ export default function ReviewCard({ - + {content} diff --git a/web/src/components/menu/LiveContextMenu.tsx b/web/src/components/menu/LiveContextMenu.tsx index 8ed78e348..982895200 100644 --- a/web/src/components/menu/LiveContextMenu.tsx +++ b/web/src/components/menu/LiveContextMenu.tsx @@ -272,7 +272,7 @@ export default function LiveContextMenu({ return (
- + {children}