simplify to use Job infrastructure

This commit is contained in:
Josh Hawkins
2026-05-03 11:09:24 -05:00
parent cbefc3acc4
commit 5eee65984a
4 changed files with 527 additions and 376 deletions
+48 -42
View File
@@ -44,6 +44,7 @@ import { getTranslatedLabel } from "@/utils/i18n";
import { Card } from "@/components/ui/card";
import { Progress } from "@/components/ui/progress";
import { ObjectType } from "@/types/ws";
import { useJobStatus } from "@/api/ws";
import WsMessageFeed from "@/components/ws/WsMessageFeed";
import { ConfigSectionTemplate } from "@/components/config-form/sections/ConfigSectionTemplate";
@@ -57,18 +58,8 @@ import { useDocDomain } from "@/hooks/use-doc-domain";
import DebugDrawingLayer from "@/components/overlay/DebugDrawingLayer";
import { IoMdArrowRoundBack } from "react-icons/io";
type ReplayState =
| "idle"
| "preparing_clip"
| "starting_camera"
| "active"
| "error";
type DebugReplayStatus = {
active: boolean;
state: ReplayState;
progress_percent: number | null;
error_message: string | null;
replay_camera: string | null;
source_camera: string | null;
start_time: number | null;
@@ -76,6 +67,15 @@ type DebugReplayStatus = {
live_ready: boolean;
};
type DebugReplayJobResults = {
current_step: "preparing_clip" | "starting_camera" | null;
progress_percent: number | null;
source_camera: string | null;
replay_camera_name: string | null;
start_ts: number | null;
end_ts: number | null;
};
type DebugOptions = {
bbox: boolean;
timestamp: boolean;
@@ -130,6 +130,8 @@ export default function Replay() {
} = useSWR<DebugReplayStatus>("debug_replay/status", {
refreshInterval: 1000,
});
const { payload: replayJob } =
useJobStatus<DebugReplayJobResults>("debug_replay");
const [isInitializing, setIsInitializing] = useState(true);
// Refresh status immediately on mount to avoid showing "no session" briefly
@@ -248,34 +250,17 @@ export default function Replay() {
);
}
// No active session
if (!status?.active && status?.state !== "error") {
return (
<div className="flex size-full flex-col items-center justify-center gap-4 p-8">
<MdReplay className="size-12" />
<Heading as="h2" className="text-center">
{t("page.noSession")}
</Heading>
<p className="max-w-md text-center text-muted-foreground">
{t("page.noSessionDesc")}
</p>
<Button variant="default" onClick={() => navigate("/review")}>
{t("page.goToRecordings")}
</Button>
</div>
);
}
// Startup error
if (status?.state === "error") {
// Startup error (job failed). Only show when status.active is also true so
// we don't surface stale failed jobs after a session ended cleanly.
if (replayJob?.status === "failed" && status?.active) {
return (
<div className="flex size-full flex-col items-center justify-center gap-4 p-8">
<Heading as="h2" className="text-center">
{t("page.startError.title")}
</Heading>
{status.error_message && (
{replayJob.error_message && (
<p className="max-w-xl text-center text-sm text-muted-foreground">
{status.error_message}
{replayJob.error_message}
</p>
)}
<Button
@@ -293,24 +278,45 @@ export default function Replay() {
);
}
// Preparing or starting
if (
status?.state === "preparing_clip" ||
status?.state === "starting_camera"
) {
// No active session.
if (!status?.active) {
return (
<div className="flex size-full flex-col items-center justify-center gap-4 p-8">
<MdReplay className="size-12" />
<Heading as="h2" className="text-center">
{t("page.noSession")}
</Heading>
<p className="max-w-md text-center text-muted-foreground">
{t("page.noSessionDesc")}
</p>
<Button variant="default" onClick={() => navigate("/review")}>
{t("page.goToRecordings")}
</Button>
</div>
);
}
// Startup in progress (job is running). The session is active but the
// replay camera isn't ready yet; show progress / phase from the job.
const startupStep =
replayJob?.status === "running"
? (replayJob.results?.current_step ?? null)
: null;
if (startupStep === "preparing_clip" || startupStep === "starting_camera") {
const phaseTitle =
status.state === "preparing_clip"
startupStep === "preparing_clip"
? t("page.preparingClip")
: t("page.startingCamera");
const progressPercent = replayJob?.results?.progress_percent ?? null;
const showProgressBar =
status.state === "preparing_clip" && status.progress_percent != null;
startupStep === "preparing_clip" && progressPercent != null;
return (
<div className="flex size-full flex-col items-center justify-center gap-4 p-8">
{showProgressBar ? (
<div className="flex w-64 flex-col items-center gap-2">
<Progress value={status.progress_percent ?? 0} />
<Progress value={progressPercent ?? 0} />
<div className="text-xs text-muted-foreground">
{Math.round(status.progress_percent ?? 0)}%
{Math.round(progressPercent ?? 0)}%
</div>
</div>
) : (
@@ -319,7 +325,7 @@ export default function Replay() {
<Heading as="h3" className="text-center">
{phaseTitle}
</Heading>
{status.state === "preparing_clip" && (
{startupStep === "preparing_clip" && (
<p className="max-w-md text-center text-sm text-muted-foreground">
{t("page.preparingClipDesc")}
</p>