From 5495896154c25dcf16549cdd0cc9fa7b5d36ce27 Mon Sep 17 00:00:00 2001 From: Deviant <16081842+deviant77@users.noreply.github.com> Date: Mon, 18 Jul 2022 23:53:19 +0100 Subject: [PATCH] Add explanatory warning and properly format cache_path warning --- frigate/record.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/frigate/record.py b/frigate/record.py index 62e45d48e..d1d41038a 100644 --- a/frigate/record.py +++ b/frigate/record.py @@ -99,12 +99,15 @@ class RecordingMaintainer(threading.Thread): # delete all cached files past the most recent 5 keep_count = 5 for camera in grouped_recordings.keys(): - if len(grouped_recordings[camera]) > keep_count: + segment_count = len(grouped_recordings[camera]) + if segment_count > keep_count: + logger.warning(f"Too many recording segments in cache for {camera}. Keeping the {keep_count} most recent segments out of {segment_count}, discarding the rest...") to_remove = grouped_recordings[camera][:-keep_count] for f in to_remove: - logger.warning(f"Discarding a recording segment: {f}") - Path(f["cache_path"]).unlink(missing_ok=True) - self.end_time_cache.pop(f["cache_path"], None) + cache_path = f["cache_path"] + logger.warning(f"Discarding a recording segment: {cache_path}") + Path(cache_path).unlink(missing_ok=True) + self.end_time_cache.pop(cache_path, None) grouped_recordings[camera] = grouped_recordings[camera][-keep_count:] for camera, recordings in grouped_recordings.items():