From 5374c18e710c9fb38e590d8ed022f693959e5b43 Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Sun, 13 Oct 2024 16:14:10 -0500
Subject: [PATCH] more readable loops

---
 frigate/embeddings/embeddings.py | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/frigate/embeddings/embeddings.py b/frigate/embeddings/embeddings.py
index 4de0fd7de..330855cba 100644
--- a/frigate/embeddings/embeddings.py
+++ b/frigate/embeddings/embeddings.py
@@ -145,15 +145,19 @@ class Embeddings:
         ]
         ids = list(event_thumbs.keys())
         embeddings = self.vision_embedding(images)
-        items = [(ids[i], serialize(embeddings[i])) for i in range(len(ids))]
-        flat_items = [item for sublist in items for item in sublist]
+
+        items = []
+
+        for i in range(len(ids)):
+            items.append(ids[i])
+            items.append(serialize(embeddings[i]))
 
         self.db.execute_sql(
             """
             INSERT OR REPLACE INTO vec_thumbnails(id, thumbnail_embedding)
             VALUES {}
             """.format(", ".join(["(?, ?)"] * len(items))),
-            flat_items,
+            items,
         )
         return embeddings
 
@@ -172,15 +176,19 @@ class Embeddings:
     def batch_upsert_description(self, event_descriptions: dict[str, str]) -> ndarray:
         embeddings = self.text_embedding(list(event_descriptions.values()))
         ids = list(event_descriptions.keys())
-        items = [(ids[i], serialize(embeddings[i])) for i in range(len(ids))]
-        flat_items = [item for sublist in items for item in sublist]
+
+        items = []
+
+        for i in range(len(ids)):
+            items.append(ids[i])
+            items.append(serialize(embeddings[i]))
 
         self.db.execute_sql(
             """
             INSERT OR REPLACE INTO vec_descriptions(id, description_embedding)
             VALUES {}
             """.format(", ".join(["(?, ?)"] * len(items))),
-            flat_items,
+            items,
         )
 
         return embeddings