From 51e68cee4dc2c4cd63e48ad5925e47483afad598 Mon Sep 17 00:00:00 2001 From: Miguel Valenzuela Date: Fri, 13 Oct 2023 17:04:26 -0700 Subject: [PATCH] Update Output Args Presets AAC Upon researching the nuances of preset-record-generic-audio-copy & preset-record-generic-audio-aac https://github.com/blakeblackshear/frigate/blob/4c7ea01137d5046879355e35fe9e260d1624d031/frigate/ffmpeg_presets.py#L341 https://ffmpeg.org/ffmpeg.html#Main-options https://stackoverflow.com/questions/70148683/will-ffmpeg-try-to-transcode-to-same-encoding I'd suggest to disambiguate what these two do --- docs/docs/configuration/ffmpeg_presets.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/configuration/ffmpeg_presets.md b/docs/docs/configuration/ffmpeg_presets.md index 66747350e..64c9658d1 100644 --- a/docs/docs/configuration/ffmpeg_presets.md +++ b/docs/docs/configuration/ffmpeg_presets.md @@ -72,8 +72,8 @@ Output args presets help make the config more readable and handle use cases for | Preset | Usage | Other Notes | | -------------------------------- | --------------------------------- | --------------------------------------------- | | preset-record-generic | Record WITHOUT audio | This is the default when nothing is specified | -| preset-record-generic-audio-aac | Record WITH aac audio | Use this to enable audio in recordings | | preset-record-generic-audio-copy | Record WITH original audio | Use this to enable audio in recordings | +| preset-record-generic-audio-aac | Record WITH transcoded aac audio | Use this to transcode to aac audio. If your source is already AAC, use preset-record-generic-audio-copy instead to avoid re-encoding | | preset-record-mjpeg | Record an mjpeg stream | Recommend restreaming mjpeg stream instead | | preset-record-jpeg | Record live jpeg | Recommend restreaming live jpeg instead | | preset-record-ubiquiti | Record ubiquiti stream with audio | Recordings with ubiquiti non-standard audio |