From 4ff8168422156e54e5b67736bc2d7c46fe4ae70d Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Thu, 11 Sep 2025 13:17:09 -0500 Subject: [PATCH] don't memoize roles always recalculate on component render --- web/src/views/settings/AuthenticationView.tsx | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/web/src/views/settings/AuthenticationView.tsx b/web/src/views/settings/AuthenticationView.tsx index 757eb16da..161da0f81 100644 --- a/web/src/views/settings/AuthenticationView.tsx +++ b/web/src/views/settings/AuthenticationView.tsx @@ -381,16 +381,14 @@ export default function AuthenticationView({ [t, updateConfig, users, mutateUsers], ); - const roles = useMemo(() => { - return config?.auth?.roles - ? Object.entries(config.auth.roles) - .filter(([name]) => name !== "admin") - .map(([name, data]) => ({ - name, - cameras: Array.isArray(data) ? data : [], - })) - : []; - }, [config]); + const roles = config?.auth?.roles + ? Object.entries(config.auth.roles) + .filter(([name]) => name !== "admin") + .map(([name, data]) => ({ + name, + cameras: Array.isArray(data) ? data : [], + })) + : []; const availableRoles = useMemo(() => { return config ? [...Object.keys(config.auth?.roles || {})] : [];